[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. In D66042#1624697 , @Charusso wrote: > In D66042#1624684 , @NoQ wrote: > > > My idea here was that this new feature isn't going to be user-facing. We > > aren't promising to support all

[PATCH] D66083: [clangd] Remove highlightings coming from non topLevelDecls from included files.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. It is possible to write include code from other files so that the decls from there do not become

r368561 - [OpenCL] Ignore parentheses for sampler initialization

Author: svenvh Date: Mon Aug 12 05:44:26 2019 New Revision: 368561 URL: http://llvm.org/viewvc/llvm-project?rev=368561=rev Log: [OpenCL] Ignore parentheses for sampler initialization The sampler handling logic in SemaInit.cpp would inadvertently treat parentheses around sampler arguments as an

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

jvikstrom updated this revision to Diff 214613. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Mirror the LSP proposal SemanticHighlightingParams/Information types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65998/new/

[clang-tools-extra] r368563 - [clangd] Remove highlightings coming from non topLevelDecls from included files.

Author: jvikstrom Date: Mon Aug 12 06:01:11 2019 New Revision: 368563 URL: http://llvm.org/viewvc/llvm-project?rev=368563=rev Log: [clangd] Remove highlightings coming from non topLevelDecls from included files. Summary: It is possible to write include code from other files so that the decls

[PATCH] D66083: [clangd] Remove highlightings coming from non topLevelDecls from included files.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 3 inline comments as done. Closed by commit rL368563: [clangd] Remove highlightings coming from non topLevelDecls from included files. (authored by jvikstrom, committed by ). Herald added a project: LLVM.

[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

sammccall added a comment. Added a bit of a braindump to https://github.com/clangd/clangd/issues/95 I think always forcing a break is maybe at least as bad as forcing no break, and we should aim to be cleverer. Some (relatively) simple punctuation/capitalization/line-length based heuristics

[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

ilya-biryukov added a comment. The heuristics for properly rendering the comments are probably a good way to go. I'd say this change is still a step in the right direction - text blocks in formatted strings should be properly escaped to avoid being interpreted like markdown constructs. Any

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. Gentle ping. @rsmith, please take a look when you have time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/ https://reviews.llvm.org/D65591 ___ cfe-commits

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:8 +// The information clangd sends when highlightings should be updated. +interface SemanticHighlightingParams { + // The information about the text document

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. mostly good with a few nits. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:9 +// Parameters for the semantic highlighting

[PATCH] D66087: [clangd] Preserve line break when rendering text chunks of markdown

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/95 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66087

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D64274#1623644 , @NoQ wrote: > In D64274#1600834 , @Szelethus wrote: > > > In D64274#1598226

[PATCH] D66080: [OpenCL] Ignore parentheses for sampler initialization

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added subscribers: cfe-commits, yaxunl. Herald added a project: clang. The sampler handling logic in SemaInit.cpp would inadvertently treat parentheses around sampler arguments as an implicit cast, leading to an unreachable

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry, I had marked this as "accepted", but not hit send. I agree with Ilya's comments, but please go ahead and land this when ready. (I wish Phabricator didn't say "sammccall accepted

[PATCH] D66086: [clangd] Separate chunks with a space when rendering markdown

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This results in better rendering of resulting markdown. Especially noticeable in coc.nvim that does not have a visible

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

riccibruno added a comment. It seems that these two options are not exactly the same right ? The `ContainsError` bit is useful to quickly answer "Does this expression contains an invalid sub-expression" without doing the search, while adding an `ErrorExpr` node is useful to note that //this//

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. In D65591#1625154 , @riccibruno wrote: > It seems that these two options are not exactly the same right ? The > `ContainsError` bit is useful to quickly answer "Does this expression > contains an invalid sub-expression"

[PATCH] D66031: clangd: use -j for background index pool

hans added a comment. In D66031#1623935 , @sammccall wrote: > @hans If you don't mind merging this, it's a nice usability improvement. Sure! Merged in r368569. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

aaron.ballman added a comment. In D65591#1625154 , @riccibruno wrote: > It seems that these two options are not exactly the same right ? The > `ContainsError` bit is useful to quickly answer "Does this expression > contains an invalid sub-expression"

r368552 - [OpenCL] Fix lang mode predefined macros for C++ mode.

Author: stulova Date: Mon Aug 12 03:44:07 2019 New Revision: 368552 URL: http://llvm.org/viewvc/llvm-project?rev=368552=rev Log: [OpenCL] Fix lang mode predefined macros for C++ mode. In C++ mode we should only avoid adding __OPENCL_C_VERSION__, all other predefined macros about the language

r368562 - [CrossTU] User docs: remove temporary limiation with macro expansion

Author: martong Date: Mon Aug 12 05:46:28 2019 New Revision: 368562 URL: http://llvm.org/viewvc/llvm-project?rev=368562=rev Log: [CrossTU] User docs: remove temporary limiation with macro expansion D65064, D64635, D64638 pathces solve the issue with macor expansion. Modified:

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 214619. jvikstrom added a comment. Rebased to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D65998: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 5 inline comments as done. Closed by commit rL368568: [clangd] Added the vscode SemanticHighlighting feature code but did not enable… (authored by jvikstrom, committed by ). Herald added a project: LLVM.

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

riccibruno added a comment. In D65591#1625183 , @aaron.ballman wrote: > In D65591#1625154 , @riccibruno > wrote: > > > It seems that these two options are not exactly the same right ? The > > `ContainsError` bit

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

aaron.ballman added a comment. Rather than adding a bit onto `Expr` to specify whether it's erroneous, have you considered making this a property of the type system by introducing an `ErrorExpr` AST node that other nodes can inherit from? I think that approach would work more naturally for

[PATCH] D66080: [OpenCL] Ignore parentheses for sampler initialization

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66080/new/ https://reviews.llvm.org/D66080

[PATCH] D66083: [clangd] Remove highlightings coming from non topLevelDecls from included files.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Great example for the test case! It will definitely stay valid even if we fix all problems caused by RecursiveASTVisitor! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. In D65591#1625183 , @aaron.ballman wrote: > In D65591#1625154 , @riccibruno > wrote: > > > It seems that these two options are not exactly the same right ? The > > `ContainsError`

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

alexfh added a comment. In D66042#1624081 , @NoQ wrote: > +@alexfh because clang-tidy now finally has a way of safely disabling core > checkers without causing crashes all over the place! Would you like to take > the same approach as we picked in

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

riccibruno added a comment. In D65591#1625228 , @ilya-biryukov wrote: > In D65591#1625183 , @aaron.ballman > wrote: > > > In D65591#1625154 , @riccibruno > > wrote: > > >

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66083: [clangd] Remove highlightings coming from non topLevelDecls from included files.

hokein accepted this revision. hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:236 +// topLevelDecls. (example: method declarations being included from another +// file for a class) from another file) +if

[clang-tools-extra] r368581 - [clangd] Separate chunks with a space when rendering markdown

Author: ibiryukov Date: Mon Aug 12 07:35:30 2019 New Revision: 368581 URL: http://llvm.org/viewvc/llvm-project?rev=368581=rev Log: [clangd] Separate chunks with a space when rendering markdown Summary: This results in better rendering of resulting markdown. Especially noticeable in coc.nvim

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

cpplearner added a comment. Herald added a project: clang. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47419/new/ https://reviews.llvm.org/D47419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65941: [OpenCL] Fix lang mode predefined macros for C++ mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL368552: [OpenCL] Fix lang mode predefined macros for C++ mode. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom added a comment. @ilya-biryukov @hokein pinging about this cl (I had completely forgotten about it somehow. Just updated it to the new master though) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/

[PATCH] D64741: [clangd] Added highlighting for tokens that are macro arguments.

jvikstrom updated this revision to Diff 214620. jvikstrom added a comment. Moved comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64741/new/ https://reviews.llvm.org/D64741 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

Re: [clang-tools-extra] r368498 - clangd: use -j for background index pool

Merged to release_90 in r368569. On Sat, Aug 10, 2019 at 1:02 AM Sam McCall via cfe-commits wrote: > > Author: sammccall > Date: Fri Aug 9 16:03:32 2019 > New Revision: 368498 > > URL: http://llvm.org/viewvc/llvm-project?rev=368498=rev > Log: > clangd: use -j for background index pool > >

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Agreed, this seems fine as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65752/new/ https://reviews.llvm.org/D65752

[PATCH] D66080: [OpenCL] Ignore parentheses for sampler initialization

This revision was automatically updated to reflect the committed changes. Closed by commit rL368561: [OpenCL] Ignore parentheses for sampler initialization (authored by svenvh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368568 - [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client.

Author: jvikstrom Date: Mon Aug 12 06:33:43 2019 New Revision: 368568 URL: http://llvm.org/viewvc/llvm-project?rev=368568=rev Log: [clangd] Added the vscode SemanticHighlighting feature code but did not enable it in the client. Summary: Added the code for the StaticFeature that must be

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

alexfh added a comment. One more nit. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:674 + return !( + (isTokAtEndOfExpr(Lsr, LTok, SM) && isTokAtEndOfExpr(Rsr, RTok, SM)) && + isSameToken(LTok, RTok, SM)); aaron.ballman wrote: > You can

[PATCH] D66086: [clangd] Separate chunks with a space when rendering markdown

This revision was automatically updated to reflect the committed changes. Closed by commit rL368581: [clangd] Separate chunks with a space when rendering markdown (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

sepavloff created this revision. sepavloff added reviewers: rjmccall, anemet, kpn, aaron.ballman, hfinkel. Herald added a project: clang. If the value of FPOption is modified, for example by using pragma 'clang fp', create calls to constrained fp intrinsics with metadata arguments corresponding

[clang-tools-extra] r368590 - [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

Author: sammccall Date: Mon Aug 12 10:05:35 2019 New Revision: 368590 URL: http://llvm.org/viewvc/llvm-project?rev=368590=rev Log: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC Summary: This takes this logic out of the Tweak class, and simplifies the signature of

[PATCH] D65994: Extended FPOptions with new attributes

rjmccall added a comment. Since this setting changes IR output, you should write a test that emits IR for source code and tests that you get the right IR output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65994/new/

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel marked 2 inline comments as done. ymandel added a comment. I was going to add a test for `Type`/`QualType` and realized that they don't carry any source location info. Therefore, I don't think they belong as top-level matchers for rewrite rules. Instead, users should use

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: llvm-commits, dexonsmith, jkorous. Herald added a project: LLVM. This is the patch I split out of https://reviews.llvm.org/D64464. The cleanup is pushed in

[PATCH] D25845: [CUDA] Ignore implicit target attributes during function template instantiation.

tra marked an inline comment as done. tra added inline comments. Comment at: cfe/trunk/lib/Sema/SemaDecl.cpp:8416 +// in the CheckFunctionTemplateSpecialization() call below. +if (getLangOpts().CUDA & !isFunctionTemplateSpecialization) +

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

jgravelle-google added a comment. Overall direction looks good to me as well. Ditto that tests would be useful just to make it clearer how this is represented in IR. Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h:47 + MVT getPointerTy(const DataLayout ,

[PATCH] D66100: Add __has_builtin support for builtin function-like type traits.

rsmith created this revision. rsmith added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, kristina, jfb. Herald added a project: clang. Previously __has_builtin(__builtin_*) would return false for __builtin_*s that we modeled as keywords rather than as functions (because they

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

gribozavr added a comment. In D65877#1625493 , @ymandel wrote: > I was going to add a test for `Type`/`QualType` and realized that they don't > carry any source location info. Therefore, I don't think they belong as > top-level matchers for rewrite

Re: r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

On Mon, 12 Aug 2019 at 11:30, Erik Pilkington via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: epilk > Date: Mon Aug 12 11:31:27 2019 > New Revision: 368600 > > URL: http://llvm.org/viewvc/llvm-project?rev=368600=rev > Log: > [Sema] Require a complete type for __builtin_bit_cast

[PATCH] D64464: [CodeGen] Emit destructor calls for non-trivial C structs

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:4647 +pushDestroy(QualType::DK_nontrivial_c_struct, RV.getAggregateAddress(), +E->getType()); + rjmccall wrote: > Does

[clang-tools-extra] r368602 - [clang-doc] Generate HTML links for children namespaces/records

Author: diegoastiazaran Date: Mon Aug 12 11:42:46 2019 New Revision: 368602 URL: http://llvm.org/viewvc/llvm-project?rev=368602=rev Log: [clang-doc] Generate HTML links for children namespaces/records Path is now stored in the references to the child while serializing, then this path is used to

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

This revision was automatically updated to reflect the committed changes. Closed by commit rL368602: [clang-doc] Generate HTML links for children namespaces/records (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

kpn added a comment. Does this work for anything that uses TreeTransform, like C++ templates? Also, if any constrained intrinsics are used in a function then the entire function needs to be constrained. Is this handled anywhere? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked an inline comment as done. jcai19 added inline comments. Comment at: llvm/test/CodeGen/ARM/gnu_mcount_nc.ll:1-6 +; RUN: llc -mtriple=armv7a-linux-gnueabihf %s -o - | FileCheck %s --check-prefix=CHECK-ARM +; RUN: llc -mtriple=armv7a-linux-gnueabihf %s -o - |

[PATCH] D62046: [OpenMP][bugfix] Add missing math functions variants for log and abs.

JonChesterfield added a comment. I'm not sure about this diff. I think it's breaking and . Raised bug https://bugs.llvm.org/show_bug.cgi?id=42972 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62046/new/ https://reviews.llvm.org/D62046

r368588 - Fix multiple lifetime warning messages for range based for loop

Author: xazax Date: Mon Aug 12 09:19:39 2019 New Revision: 368588 URL: http://llvm.org/viewvc/llvm-project?rev=368588=rev Log: Fix multiple lifetime warning messages for range based for loop Modified: cfe/trunk/lib/Sema/SemaInit.cpp cfe/trunk/test/Sema/warn-lifetime-analysis-nocfg.cpp

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

chrish_ericsson_atx marked 3 inline comments as done. chrish_ericsson_atx added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/EnumCastOutOfRangeChecker.cpp:94-98 + // If cast is implicit LValueToRValue, no conversion is taking place, + // and therefore no

[PATCH] D65333: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a3c2c84be2b: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65333: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

sammccall updated this revision to Diff 214652. sammccall added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65333/new/ https://reviews.llvm.org/D65333 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp

[PATCH] D66028: [ASTDump] Add is_anonymous to VisitCXXRecordDecl

This revision was automatically updated to reflect the committed changes. Closed by commit rL368591: [ASTDump] Add is_anonymous to VisitCXXRecordDecl (authored by shafik, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D47419: [SemaDeclCXX] Allow inheriting constructor declaration that specify a cv-qualified type

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDeclCXX.cpp:9690 + CanQualType CanonicalDesiredBase = DesiredBase->getCanonicalTypeUnqualified() +.getUnqualifiedType(); for (auto

[PATCH] D65665: Support for attributes on @class declarations

rjmccall added a comment. Have you looked through the attributes that can be written on `@interface`s and verified that they're all sensible to write on a `@class`? It's not hard to imagine that *some* of them should be diagnosed when added to a non-definition. Repository: rC Clang

[PATCH] D66068: cmake: Make building clang-shlib optional

beanz added a comment. I generally am not a fan of adding more and more options. As long as you're not linking the library it won't be generated by any of the check targets. With the llvm dylib we've had many issues over the years where changes to LLVM break building the dylib and many

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

juliehockett accepted this revision. juliehockett marked an inline comment as done. juliehockett added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:250 + // The resulting path is "../../../A/B/D"

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel marked an inline comment as done. ymandel added a comment. In D65877#1625616 , @gribozavr wrote: > I'd prefer we ban them completely, and let the user wrap them manually if > they need to. While some users would appreciate the ergonomics, I think

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel updated this revision to Diff 214679. ymandel added a comment. Bans qualtype and type and adds corresponding comments and test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65877/new/ https://reviews.llvm.org/D65877 Files:

Re: [clang-tools-extra] r368581 - [clangd] Separate chunks with a space when rendering markdown

+Hans Wennborg , could we merge this into the release? On Mon, Aug 12, 2019 at 4:34 PM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: ibiryukov > Date: Mon Aug 12 07:35:30 2019 > New Revision: 368581 > > URL: http://llvm.org/viewvc/llvm-project?rev=368581=rev > Log:

r368591 - [ASTDump] Add is_anonymous to VisitCXXRecordDecl

Author: shafik Date: Mon Aug 12 10:07:49 2019 New Revision: 368591 URL: http://llvm.org/viewvc/llvm-project?rev=368591=rev Log: [ASTDump] Add is_anonymous to VisitCXXRecordDecl Summary: Adding is_anonymous the ASTDump for CXXRecordDecl. This turned out to be useful when debugging some problems

[PATCH] D66094: [CodeGen] Emit destructor calls for non-trivial C structs returned by function calls and loaded from volatile objects

ahatanak updated this revision to Diff 214660. ahatanak added a comment. Revert changes I made to llvm that are unrelated to this patch. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66094/new/ https://reviews.llvm.org/D66094 Files:

r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

Author: epilk Date: Mon Aug 12 11:31:27 2019 New Revision: 368600 URL: http://llvm.org/viewvc/llvm-project?rev=368600=rev Log: [Sema] Require a complete type for __builtin_bit_cast operands Fixes llvm.org/PR42936 Modified: cfe/trunk/lib/Sema/SemaCast.cpp

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This would fix that we show weird diagnostics on random lines of the main file. Repository: rG LLVM Github Monorepo

[PATCH] D66074: [clangd] Drop diags from non-written #include.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368549: [clangd] Drop diags from non-written #include. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65269: [ASTImporter] Fix for import of friend class template with definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368551: [ASTImporter] Fix for import of friend class template with definition. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository:

r368551 - [ASTImporter] Fix for import of friend class template with definition.

Author: balazske Date: Mon Aug 12 03:07:38 2019 New Revision: 368551 URL: http://llvm.org/viewvc/llvm-project?rev=368551=rev Log: [ASTImporter] Fix for import of friend class template with definition. Summary: If there is a friend class template "prototype" (forward declaration) and later a

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Nice simplification, thanks! Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:127 + // in `taggedMatchers`. + std::map, 1>> + Buckets;

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein updated this revision to Diff 214590. hokein marked an inline comment as done. hokein added a comment. Add a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66074/new/ https://reviews.llvm.org/D66074 Files:

[PATCH] D66074: [clangd] Drop diags from non-written #include.

hokein marked an inline comment as done. hokein added a subscriber: hans. hokein added a comment. @hans is there still any chance to merge this patch into the release? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66074/new/ https://reviews.llvm.org/D66074

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

ilya-biryukov added a subscriber: doug.gregor. ilya-biryukov added a comment. In D65752#1623914 , @sammccall wrote: > This looks reasonable to me, there are a couple of variations you might think > about: > > - also treat QualifiedNameLookup as an

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

balazske added a comment. In this case the problem was that some of the flags of the already created and inserted `ToFunction` are not initialized. During the import of some "ctor initializers" this non-complete ToFunction may be accessed somehow (by structural equivalence or other code) and

[PATCH] D66054: [CrossTU] Fix problem with CrossTU AST load limit and progress messages.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368545: [CrossTU] Fix problem with CrossTU AST load limit and progress messages. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368545 - [CrossTU] Fix problem with CrossTU AST load limit and progress messages.

Author: balazske Date: Mon Aug 12 00:15:29 2019 New Revision: 368545 URL: http://llvm.org/viewvc/llvm-project?rev=368545=rev Log: [CrossTU] Fix problem with CrossTU AST load limit and progress messages. Summary: Number of loaded ASTs is to be incremented only if the AST was really loaded but not

[PATCH] D65373: [clangd] Update features table in the docs with links to LSP extension proposals

ilya-biryukov added inline comments. Comment at: clang-tools-extra/docs/clangd/Features.rst:260 +-++--+ -| Syntax and Semantic Coloring| No | No | +| Syntax and Semantic Coloring|`Proposed`__|

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

kristof.beyls added inline comments. Comment at: llvm/test/CodeGen/ARM/gnu_mcount_nc.ll:1-6 +; RUN: llc -mtriple=armv7a-linux-gnueabihf %s -o - | FileCheck %s --check-prefix=CHECK-ARM +; RUN: llc -mtriple=armv7a-linux-gnueabihf %s -o - | FileCheck %s

[clang-tools-extra] r368549 - [clangd] Drop diags from non-written #include.

Author: hokein Date: Mon Aug 12 02:35:04 2019 New Revision: 368549 URL: http://llvm.org/viewvc/llvm-project?rev=368549=rev Log: [clangd] Drop diags from non-written #include. Summary: This would fix that we show weird diagnostics on random lines of the main file. Reviewers: ilya-biryukov

[PATCH] D65996: [clangd] Highlighting auto variables as the deduced type.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368546: [clangd] Highlighting auto variables as the deduced type. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368546 - [clangd] Highlighting auto variables as the deduced type.

Author: jvikstrom Date: Mon Aug 12 00:45:12 2019 New Revision: 368546 URL: http://llvm.org/viewvc/llvm-project?rev=368546=rev Log: [clangd] Highlighting auto variables as the deduced type. Summary: Done in VisitDeclaratorDecl as the AutoTypeLoc is not deduced. Scoped to only work for variables.

[PATCH] D66074: [clangd] Drop diags from non-written #include.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks! We should also merge this into the release branch if it's not too late yet. Comment at:

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5239 +TEST_P(ASTImporterOptionSpecificTestBase, ImportOfDefaultImplicitFunctions) { + // Test that import of implicit functions works and the

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

balazske updated this revision to Diff 214585. balazske added a comment. - Using StringRef, added comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65999/new/ https://reviews.llvm.org/D65999 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added a comment. In D66042#1626460 , @NoQ wrote: > I'd like to hear @Szelethus's opinion one more time on this patch. I'm > perfectly fine with abandoning the idea and going for in-checker > suppressions, simply because there's at least one

[PATCH] D65999: [ASTImporter] Import additional flags for functions.

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Hi Balazs, The change looks good. I think it can be committed after an unrelated part is removed. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5373

Re: r368600 - [Sema] Require a complete type for __builtin_bit_cast operands

Sure, I fixed this in r368610. Erik > On Aug 12, 2019, at 11:39 AM, Richard Smith wrote: > > On Mon, 12 Aug 2019 at 11:30, Erik Pilkington via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: epilk > Date: Mon Aug 12 11:31:27 2019 > New Revision: 368600 > > URL:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. In D65019#1625780 , @efriedma wrote: > > It seems global-isel does not fall back to DAGISel? > > It does, for targets where it's enabled by default, or if you use the right > flags. I think you want `-global-isel

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214696. jcai19 added a comment. Add proper instruction selection options to unit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files:

  1   2   >