[PATCH] D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}

This revision was automatically updated to reflect the committed changes. Closed by commit rL368805: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h} (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368805 - Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp, h}

Author: gribozavr Date: Wed Aug 14 00:32:51 2019 New Revision: 368805 URL: http://llvm.org/viewvc/llvm-project?rev=368805=rev Log: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h} Reviewers: jkorous Subscribers: dexonsmith, arphaman, cfe-commits Tags: #clang

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 updated this revision to Diff 215039. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c === ---

r368808 - Fix the -Wunused-variable warning.

Author: hokein Date: Wed Aug 14 01:20:42 2019 New Revision: 368808 URL: http://llvm.org/viewvc/llvm-project?rev=368808=rev Log: Fix the -Wunused-variable warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D66173: [Codegen] Updated test for D66158

This revision was automatically updated to reflect the committed changes. Closed by commit rL368809: [Codegen] Updated test for D66158 (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368804 - [NewPM][PassInstrumentation] IR printing support from clang driver

Author: twoh Date: Wed Aug 14 00:11:09 2019 New Revision: 368804 URL: http://llvm.org/viewvc/llvm-project?rev=368804=rev Log: [NewPM][PassInstrumentation] IR printing support from clang driver Summary: https://reviews.llvm.org/D50923 enabled the IR printing support for the new pass manager, but

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

arsenm created this revision. arsenm added reviewers: rampitec, b-sumner. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. arsenm added a parent revision: D66197: AMDGPU: Add intrinsics for address space identification. https://reviews.llvm.org/D66198

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev accepted this revision. fedor.sergeev added a comment. This revision is now accepted and ready to land. LGTM. Thanks for addressing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65975/new/ https://reviews.llvm.org/D65975

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL368804: [NewPM][PassInstrumentation] IR printing support from clang driver (authored by twoh, committed by ). Herald added a project: LLVM. Changed prior to commit:

[PATCH] D66199: [docs] loop pragmas

SjoerdMeijer created this revision. SjoerdMeijer added reviewers: fhahn, Meinersbur, dorit, hsaito. Following our discussion on the cfe dev list (http://lists.llvm.org/pipermail/cfe-dev/2019-August/063054.html), I have added a paragraph that is explicit about transformation options implying the

r368809 - [Codegen] Updated test for D66158

Author: xbolva00 Date: Wed Aug 14 01:32:31 2019 New Revision: 368809 URL: http://llvm.org/viewvc/llvm-project?rev=368809=rev Log: [Codegen] Updated test for D66158 Reviewers: jdoerfert Reviewed By: jdoerfert Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The current behavior for a failed request is just to log it in the output panel. When applyTweak fails for whatever reason, users

[PATCH] D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: sammccall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66212 Files: clang/include/clang/Tooling/AllTUsExecution.h

[PATCH] D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything

This revision was automatically updated to reflect the committed changes. Closed by commit rL368832: Removed ToolExecutor::isSingleProcess, it is not used by anything (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r368832 - Removed ToolExecutor::isSingleProcess, it is not used by anything

Author: gribozavr Date: Wed Aug 14 04:35:04 2019 New Revision: 368832 URL: http://llvm.org/viewvc/llvm-project?rev=368832=rev Log: Removed ToolExecutor::isSingleProcess, it is not used by anything Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66212

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1627589 , @rjmccall wrote: > I see. Is the deduction rule recursive or something, where a pointer to > pointer is inferred to point to the same address space as the pointee? It is recursive indeed and we currently

[clang-tools-extra] r368834 - [clangd] Loading TokenColorRules as a class mapping the rules to their associated clangd TextMate scope index.

Author: jvikstrom Date: Wed Aug 14 05:11:58 2019 New Revision: 368834 URL: http://llvm.org/viewvc/llvm-project?rev=368834=rev Log: [clangd] Loading TokenColorRules as a class mapping the rules to their associated clangd TextMate scope index. Summary: Loads a mapping of the clangd scope lookup

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 215086. svenvh marked 15 inline comments as done. svenvh added a comment. - Update comments as per review comments. - Rename iterator `List` to `VecSizes` in OpenCLBuiltins.td - Format GenericType definition. CHANGES SINCE LAST ACTION

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:222 +// GenType definitions. +def FGenTypeN : GenericType<"FGenTypeN", TLFloat, VecAndScalar>; +// Generate basic GenTypes. Names are like: GenTypeFloatVecAndScalar. Anastasia wrote: >

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rL368836: [analyzer][CFG] Dont track the condition of asserts (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

ilya-biryukov added a comment. Surfacing errors to the users in those cases is definitely something we need to do, thanks! How do they look in practice? In particular, should we add more context information (either in clangd or in the VSCode extension) to those errors, now that we know they

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.cpp:106 + +/// Returns a nested name specifier if \p ND refers to a an out-of-line +/// definition. `if ..

[PATCH] D66206: [CodeGen] Don't keep stale pointers to LoopInfos

ebevhan created this revision. ebevhan added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. CGLoopInfo was keeping pointers to parent loop LoopInfos, but when the loop info vector grew, it reallocated the storage and invalidated all of the parent

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 215065. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Simplified matching code. Use real scopes for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/

[PATCH] D66209: Improved the doc comment for getCommentsInFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL368827: Improved the doc comment for getCommentsInFile (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r368827 - Improved the doc comment for getCommentsInFile

Author: gribozavr Date: Wed Aug 14 04:11:52 2019 New Revision: 368827 URL: http://llvm.org/viewvc/llvm-project?rev=368827=rev Log: Improved the doc comment for getCommentsInFile Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66209 Modified:

r368828 - [NFC] Make test more robust

Author: xbolva00 Date: Wed Aug 14 04:13:10 2019 New Revision: 368828 URL: http://llvm.org/viewvc/llvm-project?rev=368828=rev Log: [NFC] Make test more robust Currently fails on ARMs Modified: cfe/trunk/test/CodeGen/struct-copy.c Modified: cfe/trunk/test/CodeGen/struct-copy.c URL:

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

alexfh added a comment. In D66042#1627760 , @NoQ wrote: > In D66042#1627193 , @alexfh wrote: > > > But without this patch clang seems to have the same two ANALYZE log lines > > regardless of whether I enable

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. In D66042#1629019 , @alexfh wrote: > In D66042#1627760 , @NoQ wrote: > > > In D66042#1627193 , @alexfh wrote: > > > > > But without this patch

r368779 - [analyzer] Don't delete TaintConfig copy constructor

Author: xiaobai Date: Tue Aug 13 18:09:07 2019 New Revision: 368779 URL: http://llvm.org/viewvc/llvm-project?rev=368779=rev Log: [analyzer] Don't delete TaintConfig copy constructor Summary: Explicitly deleting the copy constructor makes compiling the function `ento::registerGenericTaintChecker`

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To improve the UX around navigating and searching through the results. Repository: rG LLVM Github Monorepo

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

This revision was automatically updated to reflect the committed changes. Closed by commit rL368834: [clangd] Loading TokenColorRules as a class mapping the rules to their… (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

r368836 - [analyzer][CFG] Don't track the condition of asserts

Author: szelethus Date: Wed Aug 14 05:20:08 2019 New Revision: 368836 URL: http://llvm.org/viewvc/llvm-project?rev=368836=rev Log: [analyzer][CFG] Don't track the condition of asserts Well, what is says on the tin I guess! Some more changes: * Move isInevitablySinking() from BugReporter.cpp to

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215089. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files:

[clang-tools-extra] r368841 - [Clangd] NFC: Fixed comment typo

Author: sureyeaah Date: Wed Aug 14 05:40:09 2019 New Revision: 368841 URL: http://llvm.org/viewvc/llvm-project?rev=368841=rev Log: [Clangd] NFC: Fixed comment typo Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.h Modified:

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

r368929 - [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

Author: mgehre Date: Wed Aug 14 14:55:57 2019 New Revision: 368929 URL: http://llvm.org/viewvc/llvm-project?rev=368929=rev Log: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() Summary: Diagnose dangling pointers that come from std::stack::top() and

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added a comment. In D65182#1629192 , @Szelethus wrote: > Hmm, why the need for checker options? Why not have them by default? If > fixits are an experimental feature, maybe we should have a global > `enable-fixits` config. But I don't insist :) I

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny updated this revision to Diff 215298. jdenny added a comment. Rebase. Add more tests, as requested at D66247#1630441 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 Files:

r368950 - [NFCI] Always initialize BugReport const fields

Author: xiaobai Date: Wed Aug 14 17:58:51 2019 New Revision: 368950 URL: http://llvm.org/viewvc/llvm-project?rev=368950=rev Log: [NFCI] Always initialize BugReport const fields Summary: Some compilers require that const fields of an object must be explicitly initialized by the constructor. I ran

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. Why there are the changes from the another patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

jdenny added a comment. I think you're referring to stuff like `OpenMPCaptureLevel` in `ScopeInfo.h`. I wrote those changes for this patch first, as can be seen in phabricator history. I needed them for the other patch too, and I thought we were going to end up applying that patch first, so

[PATCH] D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. This migrates objc-forbidden-subclassing to `isDerivedFrom` as it now supports matching Objective-C interface declarations. Test Notes: Ran clang tools tests. Repository: rG

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. Do we really need to map such variables? According to standard, "The map clause specifies how an original list item is mapped from the current task’s data environment to a corresponding list item in the device data environment of the device identified by the

[PATCH] D64564: Loop pragma parsing. NFC.

Meinersbur accepted this revision. Meinersbur added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Parse/ParsePragma.cpp:1010 + StringRef Str = PragmaName.getIdentifierInfo()->getName(); + std::string ClangLoopStr = (Twine("clang loop

[PATCH] D66042: [analyzer] Analysis: Silence checkers

NoQ added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. For me `ddd()` doesn't call `c::c()`. I can fix it by adding the following code: void VisitCXXConstructExpr(CXXConstructExpr *CE) { addCalledDecl(CE->getConstructor()); VisitChildren(CE); } I don't see why it would work without that code, as `CXXConstructExpr`

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added inline comments. Comment at: clang/lib/Analysis/CallGraph.cpp:93 void VisitCXXConstructExpr(CXXConstructExpr *E) { CXXConstructorDecl *Ctor = E->getConstructor(); Yes, there it is. Where does it come from? I don't have it in master.

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. In D66254#1630283 , @puremourning wrote: > In D66254#1630277 , @lebedev.ri > wrote: > > > Tests? > > > Per my comment: I haven't added new tests to HeaderSearchTest.cc because the >

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

RaviNarayanaswamy added inline comments. Comment at: clang/docs/OpenMPSupport.rst:222-226 +| device extension | clause: reverse_offload | :good:`done` | D52780 |

[PATCH] D66164: [LifetimeAnalysis] Support std::stack::top() and std::optional::value()

This revision was automatically updated to reflect the committed changes. Closed by commit rL368929: [LifetimeAnalysis] Support std::stack::top() and std::optional::value() (authored by mgehre, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630398 , @jdenny wrote: > In D66247#1630352 , @ABataev wrote: > > > Yes, just realized that, defaultmap does not affect explicit firstprivates. > > Then just check `map(a)

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added inline comments. Comment at: clang/docs/analyzer/checkers.rst:263 + + void _deref_after_equals() { + std::string s = "llvm"; I suggest `deref_after_assignment`. Comment at: clang/docs/analyzer/checkers.rst:271 + const char

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks, i appreciate! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66261/new/ https://reviews.llvm.org/D66261

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! One more quick question: Who is Husi??? Comment at: clang/docs/analyzer/checkers.rst:261 + + void consume(const char *); + This declaration doesn't add

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

dlj created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The change in r368681 contains a (probably unintentional) behavioral change for rewrite rules with a single matcher. Previously, the single matcher would not need to be bound (`joinCaseMatchers`

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:483-504 + if (!AnOpts.RawSilencedCheckersAndPackages.empty()) { +std::vector Checkers = +AnOpts.getRegisteredCheckers(/*IncludeExperimental=*/true); +std::vector Packages = +

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/PathDiagnostic.h:879 + ArrayRef getFixits() const { return Fixits; } + NoQ wrote: > Szelethus wrote: > > Hmm, will this return an immutable container? If not,

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630245 , @jdenny wrote: > In D66247#1630196 , @ABataev wrote: > > > Do we really need to map such variables? According to standard, "The map > > clause specifies how an original

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

Szelethus added a comment. I really like the high level idea proposed by this patch, and the test files make me believe that its correct as well! I'm really not familiar around this part of the code, so if its okay, I'll take my time to do the usual find references, inserting

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630352 , @ABataev wrote: > Yes, just realized that, defaultmap does not affect explicit firstprivates. > Then just check `map(a) firstprivate(a)` for `int128` type. Check that it > still has `tofrom` mapping. If so,

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 added a comment. In D65019#1630354 , @nickdesaulniers wrote: > Great! LGTM and thank you for this patch. Please give 24hrs for > @eli.friedman or @kristof.beyls to leave comments before merging. Sounds good! Thanks for all the comments.

[PATCH] D66261: [analyzer] Warn about -analyzer-configs being meant for development purposes only

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, rnkovacs, dcoughlin, dkrupp. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. This is more of

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Szelethus added a comment. Shouldn't we just delete this entire visitor altogether and merge it into ConditionBRVisitor (like, eventually, not right now)? It seems to be a relic of the past. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66267/new/

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

NoQ added a comment. Cute!! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60281/new/ https://reviews.llvm.org/D60281 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66273: [Tooling] Add a hack to work around issues with matcher binding in r368681.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL368958: [Tooling] Add a hack to work around issues with matcher binding in r368681. (authored by dlj, committed by ).

r368917 - [AMDGPU] Do not assume a default GCN target

Author: rampitec Date: Wed Aug 14 13:55:15 2019 New Revision: 368917 URL: http://llvm.org/viewvc/llvm-project?rev=368917=rev Log: [AMDGPU] Do not assume a default GCN target Differential Revision: https://reviews.llvm.org/D66246 Modified: cfe/trunk/lib/Basic/Targets/AMDGPU.cpp

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215260. denik added a comment. Herald added a subscriber: ormris. Updated the code (removed Diag propagation). Added test cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files:

[PATCH] D52524: Add -Wno-poison-system-directories flag

denik updated this revision to Diff 215271. denik added a comment. Fixed clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52524/new/ https://reviews.llvm.org/D52524 Files: clang/include/clang/Basic/DiagnosticCommonKinds.td clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

Szelethus added a comment. In D63279#1630491 , @NoQ wrote: > the only reason it's not enabled by default yet is because we forgot to do > that :( Damn, thats a bummer. It wouldn't be too much trouble to run an analysis and check out whether

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum updated this revision to Diff 215272. quantum marked 6 inline comments as done. quantum added a comment. Address review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66255/new/ https://reviews.llvm.org/D66255 Files:

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

quantum added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; dschuff wrote: > This should maybe be called "test_empty_struct" since its size is actually 1 > and not zero.

r368941 - [www] Update DR status page to match latest version of CWG issues list.

Author: rsmith Date: Wed Aug 14 15:57:51 2019 New Revision: 368941 URL: http://llvm.org/viewvc/llvm-project?rev=368941=rev Log: [www] Update DR status page to match latest version of CWG issues list. Modified: cfe/trunk/www/cxx_dr_status.html Modified: cfe/trunk/www/cxx_dr_status.html URL:

r368940 - Fix handling of class member access into a vector type.

Author: rsmith Date: Wed Aug 14 15:57:50 2019 New Revision: 368940 URL: http://llvm.org/viewvc/llvm-project?rev=368940=rev Log: Fix handling of class member access into a vector type. When handling a member access into a non-class, non-ObjC-object type, we would perform a lookup into the

[PATCH] D66267: [analyzer] TrackConstraintBRVisitor: Do not track unknown values

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Charusso added a parent revision: D65889: [analyzer]

[PATCH] D66266: [WIP][RISCV] Set MaxAtomicPromoteWidth and MaxAtomicInlineWidth

pzheng created this revision. Herald added subscribers: cfe-commits, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, jfb, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso,

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran updated this revision to Diff 215304. DiegoAstiazaran marked 11 inline comments as done. DiegoAstiazaran added a comment. Increase version number of clang-doc bitcode. Rename `documentInfo` function to `shouldSerializeInfo`. In new `parseBases` a BaseRecordInfo object is created

[PATCH] D52524: Add -Wno-poison-system-directories flag

thakis added a comment. Wouldn't those projects just move to also disabling the warning by passing -Wno-poison-system-directories? If there are projects that are actively adding -I/usr/include, that means they're consciously fighting the build system and you've kind of already lost, no? Can't

[PATCH] D66240: Remove LVALUE / RVALUE workarounds

jfb added a comment. BTW, if this breaks stuff maybe it's better to do it one project at a time, and remove the helper at the very end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66240/new/ https://reviews.llvm.org/D66240

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 updated this revision to Diff 215268. boga95 marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp test/Analysis/taint-generic.c Index:

r368939 - Remove LVALUE / RVALUE workarounds

Author: jfb Date: Wed Aug 14 15:48:12 2019 New Revision: 368939 URL: http://llvm.org/viewvc/llvm-project?rev=368939=rev Log: Remove LVALUE / RVALUE workarounds Summary: LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION shouldn't be needed anymore because the minimum compiler versions

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 215274. NoQ marked 3 inline comments as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus added a comment. In D60281#1630646 , @NoQ wrote: > Thanks! > > One more quick question: Who is Husi??? Well thats me. Long story short, the reason why my name is Szelethus is that my first ever character to hit max level in World of Warcraft

[PATCH] D66238: [clang-doc] Serialize inherited attributes and methods

DiegoAstiazaran added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:436 + if (const CXXRecordDecl *Base = + cast_or_null(Ty->getDecl()->getDefinition())) { +bool IsVirtual = false; juliehockett wrote: > Will

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 215236. NoQ added a comment. Add a "not implemented yet" assertion for kinds of fixits that are not supported as of that patch (but will definitely need to be supported in the future). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new tests to HeaderSearchTest.cc because the InMemoryFileSystem doesn't support symlinks and I didn't want to try and implement that for this patch. Let me know thoughts on

[PATCH] D65724: [analyzer] Don't make ConditionBRVisitor events prunable when the condition is an interesting field

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:192-194 + if (const auto *DRE = dyn_cast(CondVarExpr)) +if (const auto *VD = dyn_cast(DRE->getDecl())) + return State->getSVal(State->getLValue(VD, LCtx)); >

[PATCH] D66254: Correct include suggestion when search path includes symlink

puremourning created this revision. puremourning added a reviewer: sammccall. Herald added subscribers: cfe-commits, kadircet, ilya-biryukov. Herald added a project: clang. puremourning added a comment. FYI this fixes the issue in https://github.com/clangd/clangd/issues/124 I haven't added new

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630262 , @ABataev wrote: > In D66247#1630245 , @jdenny wrote: > > > In D66247#1630196 , @ABataev wrote: > > > > > Do we really need to map

[PATCH] D66247: [OpenMP] Fix target map for unused variables

jdenny added a comment. In D66247#1630321 , @ABataev wrote: > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > for example. The variable must be mapped as `tofrom` in this case but, most > probably, will be mapped as `to`.

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:200 CXXRecordDecl *Canonical = Record->getCanonicalDecl(); if (Canonical->hasAttr() || Canonical->hasAttr()) return; mgehre wrote: > gribozavr wrote: > > Should this code

[PATCH] D66265: [NFCI] Always initialize BugReport const fields

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66265/new/ https://reviews.llvm.org/D66265

[PATCH] D52524: Add -Wno-poison-system-directories flag

manojgupta added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1071 +// cross-compiling. +def PoisonSystemDirectories : DiagGroup<"poison-system-directories">; + Please verify that the warning is not enabled by default. CHANGES

[PATCH] D66255: [WebAssembly] Correctly handle va_arg of zero-sized structures

dschuff added inline comments. Comment at: clang/test/CodeGen/wasm-varargs.c:104 + +struct S test_zero_size_struct(char *fmt, ...) { + va_list va; This should maybe be called "test_empty_struct" since its size is actually 1 and not zero.

[PATCH] D60281: [analyzer] Add docs for cplusplus.InnerPointer

Szelethus commandeered this revision. Szelethus edited reviewers, added: rnkovacs; removed: Szelethus. Szelethus added a comment. This revision now requires review to proceed. I'll gladly add the finishing touches :) Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

nickdesaulniers accepted this revision. nickdesaulniers added a subscriber: eli.friedman. nickdesaulniers added a comment. This revision is now accepted and ready to land. Great! LGTM and thank you for this patch. Please give 24hrs for @eli.friedman or @kristof.beyls to leave comments before

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630333 , @jdenny wrote: > In D66247#1630321 , @ABataev wrote: > > > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > > for example. The variable

[PATCH] D63279: [Analyzer] Unroll for-loops where the upper boundary is a variable with know value

NoQ added a comment. A quick archaeological dig suggests that i had no concerns with turning on unrolling by default back in 2017: http://lists.llvm.org/pipermail/cfe-dev/2017-August/055221.html - and i don't think i had any new concerns since then. I guess it'll be beneficial to make one

  1   2   3   >