r371066 - Add -m(no)-spe to clang

Author: jhibbits Date: Thu Sep 5 06:38:46 2019 New Revision: 371066 URL: http://llvm.org/viewvc/llvm-project?rev=371066=rev Log: Add -m(no)-spe to clang Summary: r337347 added support for the Signal Processing Engine (SPE) to LLVM. This follows that up with the clang side. This adds -mspe and

[PATCH] D66919: Warn about zero-parameter K definitions in -Wstrict-prototypes

aaron.ballman added a comment. In D66919#1658483 , @aaronpuchert wrote: > In D66919#1658355 , @aaron.ballman > wrote: > > > We do have numerous warnings that are default errors, you can look for > >

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Szelethus added a comment. In D67140#1658365 , @aaron.ballman wrote: > Then again, with the recent resurfacing of discussions about renaming > everything under the sun, maybe we've changed our community opinion here. :-D > I guess I don't see Check

[PATCH] D66716: [analyzer] PR43102: Fix an assertion and an out-of-bounds error for diagnostic location construction

Szelethus added a comment. I'm still working on this, just been kinda busy. I'll try to get it out of the way asap. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66716/new/ https://reviews.llvm.org/D66716

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

ilya-biryukov planned changes to this revision. ilya-biryukov added a comment. Changing behavior of clangd might affect other clients. It would be nice to find alternative ways to fix this. Nevertheless, posting this here as an example of a potential workaround for the problem. Repository:

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1658969 , @gribozavr wrote: > In D67140#1658365 , @aaron.ballman > wrote: > > > Ah, good to know! That reduces my concern, but doesn't negate it. AFAIK, we > > haven't

[clang-tools-extra] r371075 - Add a bugprone-argument-comment option: IgnoreSingleArgument.

Author: alexfh Date: Thu Sep 5 07:48:23 2019 New Revision: 371075 URL: http://llvm.org/viewvc/llvm-project?rev=371075=rev Log: Add a bugprone-argument-comment option: IgnoreSingleArgument. Summary: Add bugprone-argument-comment option: IgnoreSingleArgument. When true, the check will ignore the

[clang-tools-extra] r371076 - [clang-tidy] Make most ArgumentCommentCheck options local, as they should be

Author: alexfh Date: Thu Sep 5 07:48:31 2019 New Revision: 371076 URL: http://llvm.org/viewvc/llvm-project?rev=371076=rev Log: [clang-tidy] Make most ArgumentCommentCheck options local, as they should be Modified: clang-tools-extra/trunk/clang-tidy/bugprone/ArgumentCommentCheck.cpp

r371079 - [ARM] Add support for the s,j,x,N,O inline asm constraints

Author: dcandler Date: Thu Sep 5 08:17:25 2019 New Revision: 371079 URL: http://llvm.org/viewvc/llvm-project?rev=371079=rev Log: [ARM] Add support for the s,j,x,N,O inline asm constraints A number of inline assembly constraints are currently supported by LLVM, but rejected as invalid by Clang:

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

xyb updated this revision to Diff 218893. xyb added a comment. Rebase patch with current HEAD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67084/new/ https://reviews.llvm.org/D67084 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:30 +ClangTidyOptions::OptionMap ) { + Options.store(Opts, "WhitelistedPrefixes", WhitelistedPrefixes); +} aaron.ballman wrote: >

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

steakhal added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:191 static TaintPropagationRule -getTaintPropagationRule(const FunctionDecl *FDecl, StringRef Name, +getTaintPropagationRule(const GenericTaintChecker *Checker, +

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

vit9696 added a comment. @jhibbits, thank you for merging. Will we have this in LLVM 9.0? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 ___ cfe-commits mailing list

[PATCH] D67159: [clang] New __attribute__((__clang_builtin)).

aaron.ballman added a comment. In D67159#1659103 , @simon_tatham wrote: > Come to think of it, it would also not be too hard to constrain it to > //only// be usable for a particular subset of builtins, and perhaps even only > with a particular set of

[PATCH] D65863: [ARM] Add support for the s,j,x,N,O inline asm constraints

This revision was automatically updated to reflect the committed changes. Closed by commit rL371079: [ARM] Add support for the s,j,x,N,O inline asm constraints (authored by dcandler, committed by ). Changed prior to commit: https://reviews.llvm.org/D65863?vs=214205=218927#toc Repository: rL

Re: r369760 - [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

Merged to release_90 in r371058. On Fri, Aug 23, 2019 at 4:19 PM Kristof Umann via cfe-commits wrote: > > Author: szelethus > Date: Fri Aug 23 07:21:13 2019 > New Revision: 369760 > > URL: http://llvm.org/viewvc/llvm-project?rev=369760=rev > Log: > [analyzer] Avoid unnecessary enum range check

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Merged to release_90 in r371060. On Thu, Sep 5, 2019 at 10:41 AM Hans Wennborg via cfe-commits wrote: > > Author: hans > Date: Thu Sep 5 01:43:00 2019 > New Revision: 371027 > > URL: http://llvm.org/viewvc/llvm-project?rev=371027=rev > Log: > Revert r361885 "[Driver] Fix -working-directory

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

Abpostelnicu added a comment. Herald added a project: clang. @aaron.ballman I think the auto usage improves and simplifies the code, however, as I would really like to see this code landed, I would be ok to help Steven to finish this work and replace auto by the "old" way. Do you think we can

[PATCH] D66328: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

This revision was automatically updated to reflect the committed changes. Closed by commit rL371080: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as… (authored by aganea, committed by ). Changed prior to commit:

[clang-tools-extra] r371072 - [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

Author: alexfh Date: Thu Sep 5 07:13:57 2019 New Revision: 371072 URL: http://llvm.org/viewvc/llvm-project?rev=371072=rev Log: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked. Summary: For example: ``` void foo(int a); foo(-2); ``` should be fixed as: ```

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

xyb updated this revision to Diff 218892. xyb added a comment. Update patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67056/new/ https://reviews.llvm.org/D67056 Files: clang-tools-extra/clang-tidy/bugprone/ArgumentCommentCheck.cpp

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

nemanjai added a comment. I have not seen this problem resurface to be honest. When we initially hit it, changing the path for the build worked around the problem for us so we weren't really hitting in any longer. I posted this because I realized the possibility exists of having these dangling

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added a comment. Actually... I think it might need to be weak_odr based on https://llvm.org/docs/LangRef.html#linkage-types We want the merge semantics, but need to make sure that the symbols aren't discarded. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67058/new/

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL371066: Add -m(no)-spe to clang (authored by jhibbits, committed by ). Herald added a project: LLVM. Herald added a

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

ilya-biryukov created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, mgrang, jkorous, MaskRay. Herald added a project: clang. Currently, the completions are not shown to the user as VSCode tries to match 'filterText' against the text in the edit range. Since the text

[PATCH] D54408: [ASTMatchers] Add matchers available through casting to derived

aaron.ballman added a comment. In D54408#1659301 , @Abpostelnicu wrote: > @aaron.ballman > I think the auto usage improves and simplifies the code, however, as I would > really like to see this code landed, I would be ok to help Stephen to finish >

[PATCH] D66872: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

sammccall updated this revision to Diff 218926. sammccall added a comment. remove special-case handling of VarDecl in ExtractFunction that is no longer needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66872/new/

r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: aganea Date: Thu Sep 5 08:24:49 2019 New Revision: 371080 URL: http://llvm.org/viewvc/llvm-project?rev=371080=rev Log: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial Differential Revision: https://reviews.llvm.org/D66328 Added:

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

erichkeane added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, This Resolver should have the same

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

simoncook added a comment. For added context, I have gone and double-checked with GCC's implementation both for AArch64 and RISC-V and for registers used by the calling convention the compiler will still use them for argument passing and return values, but otherwise won't use it for any

[PATCH] D67084: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not checked.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371072: [clang-tidy] Fix bugprone-argument-comment bug: negative literal number is not… (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

jhibbits added a comment. Not in 9.0, but I will try to push for it in 9.0.1. To others, for posterity, I pushed *only* the SPE subset, not the 8548 CPU component. That will be a separate commit. I wanted it to be more than just a dummy stub, so that part will be a separate commit. The part

[PATCH] D67056: Add a bugprone-argument-comment option: IgnoreSingleArgument.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371075: Add a bugprone-argument-comment option: IgnoreSingleArgument. (authored by alexfh, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r371081 - [clangd] Initialize int field to zero. NFC

Author: ibiryukov Date: Thu Sep 5 08:30:05 2019 New Revision: 371081 URL: http://llvm.org/viewvc/llvm-project?rev=371081=rev Log: [clangd] Initialize int field to zero. NFC To make sure we do not have uninitialized values and undefined behavior. Modified:

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 218936. kadircet marked 4 inline comments as done. kadircet added a comment. - Rebase and address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files:

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added a comment. Ah. I expected my comments to be submitted as part of uploading a new revision. Still learning this UI. :-/ Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name =

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218929. kwk added a comment. Herald added subscribers: openmp-commits, libcxx-commits, Sanitizers, cfe-commits, seiya, erik.pilkington, asbirlea, ormris, Petar.Avramovic, jsji, mstorsjo, jfb, kadircet, arphaman, jkorous, george.burgess.iv, christof,

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218930. kwk added a comment. Herald added subscribers: wuzish, rnkovacs. - Fixup - Test for minidebuginfo image dump symtab - Fixed test for corrupted xz blob - Fix test - Added test that runs when no LZMA is configured Repository: rG LLVM Github Monorepo

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218932. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[PATCH] D66791: [lldb][ELF] Read symbols from .gnu_debugdata sect.

kwk updated this revision to Diff 218931. kwk added a comment. - Better names for minidebuginfo files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66791/new/ https://reviews.llvm.org/D66791 Files: lldb/CMakeLists.txt

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. I think I have addressed all comments posted so far. Do you have more notes/comments/suggestions? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 218959. pirama added a comment. Herald added a subscriber: emaste. Supported this flag for NetBSD and FreeBSD as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200

r371112 - [AST][NFC] Doc comments for ASTNameGenerator

Author: jkorous Date: Thu Sep 5 13:04:11 2019 New Revision: 371112 URL: http://llvm.org/viewvc/llvm-project?rev=371112=rev Log: [AST][NFC] Doc comments for ASTNameGenerator Modified: cfe/trunk/include/clang/AST/Mangle.h Modified: cfe/trunk/include/clang/AST/Mangle.h URL:

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1658365 , @aaron.ballman wrote: > In D67140#1658353 , @gribozavr wrote: > > > In D67140#1658315 , @aaron.ballman > > wrote: > > > > >

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

epastor updated this revision to Diff 218934. epastor added a comment. - Add testing for the new deprecation declarations mangling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67202/new/ https://reviews.llvm.org/D67202 Files:

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

epastor added a comment. The change passes ninja check-clang - and I've added a test per your suggestions. Thanks! As for llvm-undname: it works reasonably well, but these are anonymous names. It successfully recognizes $S1, etc. as the "name", though! Repository: rG LLVM Github Monorepo

[PATCH] D65256: [Sema][ObjC] Mark C union fields that have non-trivial ObjC ownership qualifications as unavailable if the union is declared in a system header

rjmccall added a comment. Could you give it a slightly more general name and then use it in the main semantic check in ActOnFields? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65256/new/ https://reviews.llvm.org/D65256

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

On Thu, Sep 5, 2019 at 9:57 AM Duncan P. N. Exon Smith wrote: > > > On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: dexonsmith >> Date: Mon Aug 26 11:29:51 2019 >>

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

vsk added a comment. Still think this looks good. Have you tried running this on the llvm test suite, or some other interesting corpus? Would be curious to see any pre/post patch numbers. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:4703-4720 +// 2) The sign of the

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218953. dgatwood marked 7 inline comments as done. dgatwood added a comment. Fixed a couple of variable names in the .h file, renamed kCustomCategoryMethodIdentifier to CustomCategoryMethodIdentifier, and switched to llvm::any_of. CHANGES SINCE LAST

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! Re llvm-undname: That seems to match behavior of MSVC's undname, so I'd say that's all good :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 218970. jpakkane marked 2 inline comments as done. jpakkane added a comment. Fixed issues raised in review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files:

r371113 - Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Author: aganea Date: Thu Sep 5 13:12:20 2019 New Revision: 371113 URL: http://llvm.org/viewvc/llvm-project?rev=371113=rev Log: Revert: [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial Removed: cfe/trunk/test/CodeGenCXX/debug-info-atexit-stub.cpp

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith added a comment. I don't think you need prior frontend expertise, just some time and patience since the modules code has some technical debt. If you are still willing to look at it, I agree with Richard's suggestion that we could merge this with the map in the Module Manager. One

[PATCH] D67200: Add -static-openmp driver option

danalbert added a comment. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:503 bool tools::addOpenMPRuntime(ArgStringList , const ToolChain , - const ArgList , bool IsOffloadingHost, - bool

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante updated this revision to Diff 218965. Mordante marked an inline comment as done. Mordante added a comment. Removes the unnecessary std::move as suggested by @aaron.ballman. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64644/new/ https://reviews.llvm.org/D64644 Files:

[PATCH] D64644: [Sema] Fixes an assertion failure while instantiation a template with an incomplete typo corrected type

Mordante marked 3 inline comments as done. Mordante added inline comments. Comment at: clang/test/SemaTemplate/instantiate-incomplete-typo-suggested-error-limit.cpp:1 +// RUN: not %clang -fsyntax-only -std=c++11 -ferror-limit=1 %s 2>&1 | FileCheck %s +

Re: r369943 - FileManager: Use llvm::Expected in new getFileRef API

> On Sep 4, 2019, at 17:39, David Blaikie wrote: > > > > On Mon, Aug 26, 2019 at 11:28 AM Duncan P. N. Exon Smith via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: dexonsmith > Date: Mon Aug 26 11:29:51 2019 > New Revision: 369943 > > URL:

Re: r371080 - [DebugInfo] Add debug location to stubs generated by CGDeclCXX and mark them as artificial

Hi Alexandre, Looks like this commit is causing crashes on darwin, can you take a look please? Here is a failing bot: http://lab.llvm.org:8080/green/job/clang-stage1-RA/1671/ Thanks! Erik On Thu, Sep 5, 2019 at 11:23 AM Alexandre Ganea via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

gribozavr added a comment. In D67140#1659356 , @aaron.ballman wrote: > In D67140#1658969 , @gribozavr wrote: > > > In D67140#1658365 , @aaron.ballman > > wrote: > > > > >

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1659831 , @NoQ wrote: > In D67140#1659774 , @aaron.ballman > wrote: > > > I don't think it's a requirement (so long as the diagnostics are clear > > about the issue being

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. Is there some reason why clang can't pass the -exception-model=wasm flag programatically to llc when -mmexception-handling is set? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1659972 , @dschuff wrote: > If this is to be like `-fdwarf-exceptions` I assume the idea is that > eventually it will default on when targeting wasm, and become one of those > flags that most users never set. In that

[PATCH] D67200: Add -static-openmp driver option

pirama updated this revision to Diff 219004. pirama added a comment. Change parameter name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200 Files: clang/include/clang/Driver/Options.td

[PATCH] D66572: [analyzer] NFC: BugReporter Separation Ep.I.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:122 + /// Get the location on which the report should be uniqued. + virtual PathDiagnosticLocation getUniqueingLocation() const { +return Location;

[PATCH] D67247: Added missing unqualified name lookup of operator overloads for fold expressions

jonathanmeier created this revision. jonathanmeier added reviewers: clang, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Valid operator overloads for fold expressions are not found in the current scope, since unqualified name lookup is not performed. This is a

[PATCH] D67249: [Modules][PCH] Hash input files content

bruno created this revision. bruno added reviewers: dexonsmith, arphaman, rsmith, aprantl. Herald added subscribers: cfe-commits, jkorous. Herald added a project: clang. When files often get touched during builds, the mtime based validation leads to different problems in implicit modules builds,

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

rnk added a subscriber: hans. rnk added a comment. Here is some feedback, I apologize for dragging my feet. Also, I would really like to get feedback from @pcc. He's OOO currently, though. Comment at: clang/include/clang/Driver/Options.td:500 def b : JoinedOrSeparate<["-"],

[PATCH] D67200: Add -static-openmp driver option

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Looks really nice. I am sure the NDK developers will be happy to see support for static OpenMP. Do you want to add the public NDK github issue link in the commit message? Repository: rG

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a comment. In D67140#1659774 , @aaron.ballman wrote: > I don't think it's a requirement (so long as the diagnostics are clear about > the issue being diagnosed, I'm happy enough), but I think it's good for a > tool to be self-consistent in

[PATCH] D66365: [clang-tidy] [readability-convert-member-functions-to-static] ignore functions that hide base class methods

mgehre abandoned this revision. mgehre added a comment. The discussions on the bug did not provide further insight (until now). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66365/new/ https://reviews.llvm.org/D66365

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. But why not make -mexception-handling be the option that enabled everything? I mean -mexception-handling is a flag we have today.. if you add -fwasm-exceptions what does -mexception-handling meaning? Is it still useful? Repository: rG LLVM Github Monorepo

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

dschuff added a comment. If this is to be like `-fdwarf-exceptions` I assume the idea is that eventually it will default on when targeting wasm, and become one of those flags that most users never set. In that case it really just selects the default exception model, and thus it should be

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

Szelethus added a comment. In D67140#1659907 , @NoQ wrote: > In D67140#1659872 , @aaron.ballman > wrote: > > > If we're okay with the inconsistency but still feel like giving ourselves > > more work, adding

[PATCH] D67246: clang-format: Add support for formatting lambdas with explicit template parameters.

thakis created this revision. thakis added a reviewer: krasimir. Ports r359967 to clang-format. https://reviews.llvm.org/D67246 Files: clang/lib/Format/TokenAnnotator.cpp clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D67024: [analyzer] NFC: Replace intrusive list of bug reports with a vector of pointers.

NoQ updated this revision to Diff 219011. NoQ added a comment. Fxd, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67024/new/ https://reviews.llvm.org/D67024 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h

[PATCH] D67200: Add -static-openmp driver option

MaskRay added a comment. Instead of more `-static-foobar`, maybe we need `-static=foobar,stdlib,rtlib` instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67200/new/ https://reviews.llvm.org/D67200

r371117 - [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator

Author: jkorous Date: Thu Sep 5 13:33:52 2019 New Revision: 371117 URL: http://llvm.org/viewvc/llvm-project?rev=371117=rev Log: [clang][Index] Replace CodegenNameGenerator with ASTNameGenerator Follow-up to: 3ff8c3b73f6, d5d15b4c1fd Should be NFC since the original patch just moved the code.

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

sbc100 added a comment. I don't really see why we can't just have the existing `-mexception-handling` take on this new meaning? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67208/new/ https://reviews.llvm.org/D67208

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1660041 , @sbc100 wrote: > `-pthreads` enabling `-matomics` and `-mbulk-memory`make some sense > because each of those low level flags might make sense on its own. But if > `-fwasm-exceptions` only going to enable

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1660041 , @sbc100 wrote: > `-pthreads` enabling `-matomics` and `-mbulk-memory`make some sense > because each of those low level flags might make sense on its own. But if > `-fwasm-exceptions` only going to enable

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

paulkirth created this revision. paulkirth added reviewers: phosek, leonardchan, nickdesaulniers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. This is a continuation of the work in D66324 that

[PATCH] D67028: Use musttail for variadic method thunks when possible

efriedma added a comment. > In your test case, we hit the early return that I linked to, so we don't try > to clone, and we don't need to emit an error. Yes, that's what happens with the Itanium ABI; what happens with the MS ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rupprecht added a comment. > Still think this looks good. Have you tried running this on the llvm test > suite, or some other interesting corpus? Would be curious to see any pre/post > patch numbers. I finally had time this morning to patch this in and give it a shot. (Sorry for the delay...

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri added a comment. In D67122#1659882 , @rupprecht wrote: > > Still think this looks good. Have you tried running this on the llvm test > > suite, or some other interesting corpus? Would be curious to see any > > pre/post patch numbers. > > I

[PATCH] D67028: Use musttail for variadic method thunks when possible

rnk updated this revision to Diff 218992. rnk added a comment. - merge into thunks.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67028/new/ https://reviews.llvm.org/D67028 Files: clang/lib/CodeGen/CGVTables.cpp

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. @tlively @sbc100 What I wanted was to make `-fwasm-exceptions` as something like `-pthreads`, which serves as the only flag that needs to be turned on and turns on all other necessary flags, such as `+matomics`, `+mbulk-memory`, and `--shared-memory`. I think all those

[PATCH] D67028: Use musttail for variadic method thunks when possible

rnk added a comment. In D67028#1659881 , @efriedma wrote: > > In your test case, we hit the early return that I linked to, so we don't > > try to clone, and we don't need to emit an error. > > Yes, that's what happens with the Itanium ABI; what happens

[PATCH] D65371: do not emit -Wunused-macros warnings in -frewrite-includes mode (PR15614)

dblaikie added a comment. A test case would be good (in the clang/test directory - probably near/in the other tests for -frewrite-includes) And does the same bug occur for other preprocessor-related warnings? Maybe it's not practical to disable them all this way & there should be a different

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

aheejin added a comment. In D67208#1659941 , @sbc100 wrote: > But why not make -mexception-handling be the option that enabled everything? > I mean -mexception-handling is a flag we have today.. if you add > -fwasm-exceptions what does

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

dschuff added a comment. Oh, you're right, I'm conflating `-mexception-handling` with `-fexceptions`. And also `-fno-exceptions` with `noexcept`. So... just forget I was here Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

Re: r371004 - [c++20] Fix some ambiguities in our mangling of lambdas with explicit

On Wed, Sep 4, 2019 at 9:22 PM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed Sep 4 18:23:47 2019 > New Revision: 371004 > > URL: http://llvm.org/viewvc/llvm-project?rev=371004=rev > Log: > [c++20] Fix some ambiguities in our mangling of lambdas

[PATCH] D67202: Implement Microsoft-compatible mangling for decomposition declarations.

This revision was automatically updated to reflect the committed changes. Closed by commit rL371124: Implement Microsoft-compatible mangling for decomposition declarations. (authored by nico, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

aaron.ballman added a comment. In D67140#1659749 , @gribozavr wrote: > In D67140#1659356 , @aaron.ballman > wrote: > > > In D67140#1658969 , @gribozavr > > wrote: > > > >

[PATCH] D67208: [WebAssembly] Add -fwasm-exceptions for wasm EH

tlively added a comment. Is there a plan to turn this on by default at some point, or will users always have to opt-in to using exceptions? Also, would it make sense to automatically turn this feature on if the user instead supplies `-mexception-handling` to turn on the target feature?

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3002 false); llvm::Constant *Resolver = GetOrCreateLLVMFunction( MangledName + ".resolver", ResolverType, GlobalDecl{}, erichkeane wrote: > This Resolver should

[PATCH] D67058: [clang][CodeGen] Add alias for cpu_dispatch function with IFunc & Fix resolver linkage type

zsrkmyn marked an inline comment as done. zsrkmyn added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:3005 /*ForVTable=*/false); +auto Linkage = (FD->isCPUDispatchMultiVersion() || FD->isCPUSpecificMultiVersion()) +?

r371122 - [Diagnostics] Minor improvements for -Wxor-used-as-pow

Author: xbolva00 Date: Thu Sep 5 13:50:48 2019 New Revision: 371122 URL: http://llvm.org/viewvc/llvm-project?rev=371122=rev Log: [Diagnostics] Minor improvements for -Wxor-used-as-pow Extracted from D66397; implemented suggestion for 2^64; tests revisited. Modified:

r371124 - Implement Microsoft-compatible mangling for decomposition declarations.

Author: nico Date: Thu Sep 5 14:08:50 2019 New Revision: 371124 URL: http://llvm.org/viewvc/llvm-project?rev=371124=rev Log: Implement Microsoft-compatible mangling for decomposition declarations. Match cl.exe's mangling for decomposition declarations. Decomposition declarations are considered

[PATCH] D67140: [analyzer][NFC] Fix inconsistent references to checkers as "checks"

NoQ added a comment. In D67140#1659872 , @aaron.ballman wrote: > If we're okay with the inconsistency but still feel like giving ourselves > more work, adding proper punctuation to Static Analyzer diagnostics would at > least make them grammatically

  1   2   >