r372614 - [docs] Fix some typos in InternalsManual

Author: svenvh Date: Mon Sep 23 07:24:29 2019 New Revision: 372614 URL: http://llvm.org/viewvc/llvm-project?rev=372614=rev Log: [docs] Fix some typos in InternalsManual Modified: cfe/trunk/docs/InternalsManual.rst Modified: cfe/trunk/docs/InternalsManual.rst URL:

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/Sema/warn-conditional-emum-types-mismatch.c:19 + +int get_flag_anon_enum(int cond) { + return cond ? A : C; Gcc warns here, but Clang does not warn when A != C.. So not

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

RKSimon added a comment. @martong This is failing on windows buildbots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19808 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

ilya-biryukov added a comment. @MyDeveloperDay, added you on the assumption that you are interested in all things about `clang-format`. Hope the change is relevant, let me know if not. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/

[PATCH] D67897: Fix __is_signed builtin

zoecarver closed this revision. zoecarver added a comment. Resolved by rL372621 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67897/new/ https://reviews.llvm.org/D67897

r372624 - Fix __is_fundamental to accept nullptr_t

Author: zoecarver Date: Mon Sep 23 09:02:46 2019 New Revision: 372624 URL: http://llvm.org/viewvc/llvm-project?rev=372624=rev Log: Fix __is_fundamental to accept nullptr_t Summary: This patch updates the __is_fundamental builtin type trait to return true for nullptr_t. Reviewers:

r372612 - [Diagnostics] Warn if '<<' in bool context with -Wint-in-bool-context (GCC compatibility)

Author: xbolva00 Date: Mon Sep 23 07:21:08 2019 New Revision: 372612 URL: http://llvm.org/viewvc/llvm-project?rev=372612=rev Log: [Diagnostics] Warn if '<<' in bool context with -Wint-in-bool-context (GCC compatibility) Extracted from D63082, addressed review comments related to a warning

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

owenpan accepted this revision. owenpan added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67888/new/ https://reviews.llvm.org/D67888 ___ cfe-commits mailing list

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:537-540 +private: + void setLValueEmptyPath(LValueBase B, const CharUnits , unsigned Size, + bool OnePastTheEnd, bool IsNullPtr); + LValuePathEntry *getLValuePathPtr();

Re: [PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

Thanks, for reaching out to me. I am looking into it. Gabor On Mon, Sep 23, 2019 at 5:44 PM Simon Pilgrim via Phabricator < revi...@reviews.llvm.org> wrote: > RKSimon added a comment. > > @martong This is failing on windows buildbots: >

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1635595 , @tejohnson wrote: > I had some time to work on this finally late last week. I decided the most > straightforward thing was to implement the necessary interface changes to the > TLI analysis to make it

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao added a comment. The current BuildAtomicExpr expects the arguments to be in the API order instead of the AST order. If RebuildAtomicExpr uses the same BuildAtomicExpr, it needs to ensure the order of arguments are in API order; otherwise, arguments (especially the one with memory order)

r372631 - NFC: Fix a poorly-written test

Author: epilk Date: Mon Sep 23 10:16:55 2019 New Revision: 372631 URL: http://llvm.org/viewvc/llvm-project?rev=372631=rev Log: NFC: Fix a poorly-written test The author of r364954 foolishly forgot that == binds tighter than ?: Modified: cfe/trunk/test/SemaCXX/constexpr-builtin-bit-cast.cpp

[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang-tools-extra/clangd/FindSymbols.cpp:48 if (!Path) { return llvm::make_error( +formatv("Could not resolve path for URI

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. @tejohnson when I run the `clang -flto -Wl,-plugin-opt=-help` command, it shows the --code-model= - Choose code model =tiny- Tiny code model =small

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl updated this revision to Diff 221341. yaxunl added a comment. revised by John's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: lib/Sema/Sema.cpp test/SemaCUDA/openmp-static-func.cu Index:

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Useful warning - GCC compatibility Repository: rC Clang https://reviews.llvm.org/D67919 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D67501: [clang-tidy] Fix relative path in header-filter.

ilya-biryukov added a comment. In D67501#1679050 , @xyb wrote: > `-normalized-header-filter`. I'd like this idea. Any objections? Having two solution for filter is unfortunate - making both discoverable and documenting why we need them is hard. If

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1674597 , @aprantl wrote: > Please be sure the watch the lldb (and other debugger) bots after committing > this.. Could you please commit these changes. Thanks! CHANGES SINCE LAST ACTION

[PATCH] D67385: Pass -mcmodel to LTO plugin

tejohnson added a comment. In D67385#1679127 , @khchen wrote: > @tejohnson when I run the `clang -flto -Wl,-plugin-opt=-help` command, it > shows the > > --code-model= - Choose code model > =tiny

[PATCH] D67897: Fix __is_signed builtin

zoecarver marked an inline comment as done. zoecarver added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1165 Note that this currently returns true for enumeration types if the underlying - type is signed, and returns false for floating-point types, in

r372621 - Fix __is_signed builtin

Author: zoecarver Date: Mon Sep 23 08:41:20 2019 New Revision: 372621 URL: http://llvm.org/viewvc/llvm-project?rev=372621=rev Log: Fix __is_signed builtin Summary: This patch fixes the __is_signed builtin type trait to work with floating point types and enums. Now, the builtin will

[PATCH] D67899: Fix __is_fundamental to accept nullptr_t

zoecarver closed this revision. zoecarver added a comment. Resolved by rL372624 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67899/new/ https://reviews.llvm.org/D67899

[clang-tools-extra] r372627 - [Clang-doc] NFC: Fixed link to llvm bugs in documentation

Author: sureyeaah Date: Mon Sep 23 09:55:13 2019 New Revision: 372627 URL: http://llvm.org/viewvc/llvm-project?rev=372627=rev Log: [Clang-doc] NFC: Fixed link to llvm bugs in documentation Modified: clang-tools-extra/trunk/docs/clang-doc.rst Modified:

[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

hokein updated this revision to Diff 221326. hokein marked 7 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67916/new/ https://reviews.llvm.org/D67916 Files:

[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

hokein added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:48 if (!Path) { return llvm::make_error( +formatv("Could not resolve path for URI '{0}' for symbol '{1}': {2}", kadircet wrote: > `return make_string_error(...` ?

[PATCH] D67916: [clangd] Simplify the callside of URI::resolve, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372617: [clangd] Simplify the callside of URI::resolve, NFC. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r372617 - [clangd] Simplify the callside of URI::resolve, NFC.

Author: hokein Date: Mon Sep 23 07:39:37 2019 New Revision: 372617 URL: http://llvm.org/viewvc/llvm-project?rev=372617=rev Log: [clangd] Simplify the callside of URI::resolve, NFC. Summary: - Add a overrloded URI::resolve, which accepts a string URI; - also fixed some callside that don't check

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221345. ilya-biryukov marked 18 inline comments as done. ilya-biryukov added a comment. Herald added subscribers: jfb, mgrang. - Add simple tests - Address other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov added a comment. Added some tests too. More tests for dependent constructs are still missing, but please take a look at what we have for now. Comment at: clang-tools-extra/clangd/FindTarget.cpp:373 + DeclRelation::TemplateInstantiation)) && +

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 updated this revision to Diff 221346. xbolva00 added a comment. Added test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67919/new/ https://reviews.llvm.org/D67919 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaChecking.cpp

r372623 - [OPENMP]Fix PR43355: DO not emit target calls if only -fopenmp-targets

Author: abataev Date: Mon Sep 23 08:53:51 2019 New Revision: 372623 URL: http://llvm.org/viewvc/llvm-project?rev=372623=rev Log: [OPENMP]Fix PR43355: DO not emit target calls if only -fopenmp-targets is not provided. We should not emit any target-dependent code if only -fopenmp flag is used and

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao created this revision. hliao added a reviewer: erichkeane. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. hliao added a comment. The current BuildAtomicExpr expects the arguments to be in the API order instead of the AST order. If RebuildAtomicExpr uses the same

r372575 - [NFC] Fixed clang wasm test after rL372573

Author: xbolva00 Date: Mon Sep 23 03:14:07 2019 New Revision: 372575 URL: http://llvm.org/viewvc/llvm-project?rev=372575=rev Log: [NFC] Fixed clang wasm test after rL372573 These tests should not depend on -O1.. Modified: cfe/trunk/test/CodeGenCXX/wasm-args-returns.cpp Modified:

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill planned changes to this revision. lewis-revill added a comment. It seems like the regressions I'm seeing are due to the fact that calculating offsets for fixed objects at the top of the frame didn't account for extra stack size adjustment from the libcalls. I'm trying to find a

[PATCH] D53137: Scalable vector core instruction support + size queries

huntergr updated this revision to Diff 221283. huntergr added a comment. Herald added subscribers: cfe-commits, haicheng, eraman. Herald added a project: clang. - Changed existing interface to return ScalableSize objects and added a (mostly) transparent conversion, as per Sander's suggestion. -

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

This revision was automatically updated to reflect the committed changes. Closed by commit rL372564: [ASTImporter][NFC] Add comprehensive tests for ODR violation handling strategies (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r372564 - [ASTImporter][NFC] Add comprehensive tests for ODR violation handling strategies

Author: martong Date: Mon Sep 23 02:32:07 2019 New Revision: 372564 URL: http://llvm.org/viewvc/llvm-project?rev=372564=rev Log: [ASTImporter][NFC] Add comprehensive tests for ODR violation handling strategies Summary: In this patch we provide additional and comprehensive tests for the ODR

r372562 - [Alignment] fix build

Author: gchatelet Date: Mon Sep 23 02:04:12 2019 New Revision: 372562 URL: http://llvm.org/viewvc/llvm-project?rev=372562=rev Log: [Alignment] fix build Modified: cfe/trunk/lib/CodeGen/CGCall.cpp Modified: cfe/trunk/lib/CodeGen/CGCall.cpp URL:

[PATCH] D67888: [clang-format] NFC clang-format the clang-format unit tests

MyDeveloperDay added a comment. In D67888#1678465 , @owenpan wrote: > I suppose the .clang-format file you used only had `BasedOnStyle: LLVM` in > it. Did you run clang-format the second time to ensure that the formatted > file was stable? it used the

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet updated this revision to Diff 221272. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67748/new/ https://reviews.llvm.org/D67748 Files:

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet added a comment. As discussed offline, we decided to change the file once we have more helpers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67748/new/ https://reviews.llvm.org/D67748 ___

[PATCH] D67651: [clangd] No ExtractFunction on empty selections.

kadircet added a comment. In D67651#1672489 , @hokein wrote: > fair enough, didn't notice that fix before, the testcase here probably > doesn't work after that patch. yes it shouldn't work after that one. Repository: rG LLVM Github Monorepo

r372633 - [ASTImporter] Attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 10:29:08 2019 New Revision: 372633 URL: http://llvm.org/viewvc/llvm-project?rev=372633=rev Log: [ASTImporter] Attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified:

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Also, can you add a test for GNUCmpXchg in both situations (inside a template, and outside)? It is the most complicated, and would best reflect the issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

jpakkane updated this revision to Diff 221376. jpakkane added a comment. Added MathHeader documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt

r372640 - [Sema] Fix the atomic expr rebuilding order.

Author: hliao Date: Mon Sep 23 11:48:06 2019 New Revision: 372640 URL: http://llvm.org/viewvc/llvm-project?rev=372640=rev Log: [Sema] Fix the atomic expr rebuilding order. Summary: - Rearrange the atomic expr order to the API order when rebuilding atomic expr during template instantiation.

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Yikes, good catch! Would we be better off instead to just modify how the other switch loads the value? Presumably something like, "if (NeedsRearrangeArgs) SubExprs.append(Args.begin(), Args.end()); else /*the switch*/. Repository: rG LLVM Github Monorepo

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221365. hliao added a comment. Add parameter name for that default argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221369. hliao added a comment. revised Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChecking.cpp

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372640: [Sema] Fix the atomic expr rebuilding order. (authored by hliao, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood marked an inline comment as done. dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( +

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1679529 , @thakis wrote: > 4. Make it so that if DisableFormat is explicitly set to true and > SortIncludes isn't explicitly set, then it disables SortIncludes. Or, put a > different way, when DisableFormat is set,

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221384. Tyker marked 12 inline comments as done. Tyker retitled this revision from "[clang] Improve Serialization/Imporing of APValues" to "[clang] Improve Serialization/Imporing/Dumping of APValues". Tyker edited the summary of this revision. Tyker added a

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; aaron.ballman wrote: > We're horribly inconsistent in this class, but because the other private > member functions go

r372646 - [ASTImporter] 2nd attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 12:49:45 2019 New Revision: 372646 URL: http://llvm.org/viewvc/llvm-project?rev=372646=rev Log: [ASTImporter] 2nd attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified:

r372635 - [OPENMP]Use standard parsing for 'match' clause, NFC.

Author: abataev Date: Mon Sep 23 11:13:31 2019 New Revision: 372635 URL: http://llvm.org/viewvc/llvm-project?rev=372635=rev Log: [OPENMP]Use standard parsing for 'match' clause, NFC. Reused standard clauses parsing scheme for parsing/matching 'match' clause in 'declare variant' directive.

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. Seems your test changes have disappeared as well? Otherwise, 1 comment then I'm ok with this. Comment at: clang/lib/Sema/TreeTransform.h:3319 +Range, Range, RParenLoc, SubExprs, Op, +/*AtomicArgumentOrder*/

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221374. hliao added a comment. add test case for compare_exchange. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h

[PATCH] D67843: DisableFormat also now disables SortIncludes

thakis added a comment. 4. Make it so that if DisableFormat is explicitly set to true and SortIncludes isn't explicitly set, then it disables SortIncludes. Or, put a different way, when DisableFormat is set, set SortIncludes to false at that point. Then an explicit `DisableFormat: true;

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

vsk updated this revision to Diff 221391. vsk marked 3 inline comments as done. vsk added a comment. - Address latest review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

rjmccall added a comment. Okay. And it's okay to fall down to the code below when functions are used in both ways this way? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 ___ cfe-commits mailing

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. Trying to fix in svn commit 372633. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao added a comment. In D67924#1679409 , @erichkeane wrote: > Yikes, good catch! > > Would we be better off instead to just modify how the other switch loads the > value? Presumably something like, "if (NeedsRearrangeArgs) >

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added a comment. It kinda stinks that we have to do this at such a late step. I'd have much preferred doing this as a part of the rebuild, but it appears that the 'form' takes quite a bit to calculate. Also, I'd likely have preferred that the initial reordering happened in codegen

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith added a comment. In D59754#1665601 , @thakis wrote: > Another question about this, sorry. Do you know _why_ C++20 is more > restrictive than C99 wrt "mixture of designated and non-designated > initializers in the same initializer list is a C99

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

hliao updated this revision to Diff 221375. hliao added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67924/new/ https://reviews.llvm.org/D67924 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaChecking.cpp

[PATCH] D67843: DisableFormat also now disables SortIncludes

SamMaier added a comment. In D67843#1677983 , @MyDeveloperDay wrote: > I assume the intention was that users could have DisableFormat=true and > SortIncludes=true when they want to sort the includes but not perform any > additional formatting in the

[PATCH] D67509: [CUDA][HIP] Fix hostness of defaulted constructor

tra added a comment. In D67509#1678394 , @yaxunl wrote: > A reduced test case is > > struct A { > A(); > }; > > template > struct B > { > T a; > constexpr B() = default; > }; > > B x; > > > > `B::B()` got implicit

[PATCH] D67843: DisableFormat also now disables SortIncludes

MyDeveloperDay added a subscriber: klimek. MyDeveloperDay added a comment. I basically agree with all the comments, I agree with you that I doubt its ever used in SortIncludes:true and DisableFormat:true, I just saw this as a hole that probably based on Myrums Law (https://www.hyrumslaw.com/)

[PATCH] D38446: update comments in clang-format.py for python3 compatibility

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. I'm not python expert but as this is a comment I don't see any issue. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D38446/new/

[PATCH] D64671: [clang-tidy] New check: misc-init-local-variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64671/new/ https://reviews.llvm.org/D64671 ___ cfe-commits mailing

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:618 } + const CXXRecordDecl **getMemberPointerPathPtr(); }; Tyker wrote: > aaron.ballman wrote: > > We're horribly

[PATCH] D67924: [Sema] Fix the atomic expr rebuilding order.

erichkeane added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:3319 +return getSema().BuildAtomicExpr(Range, Range, RParenLoc, SubExprs, Op, + true); } When passing a bool, use the comment syntax

[PATCH] D64991: [analyzer][WIP] Implement a primitive reaching definitions analysis

Szelethus updated this revision to Diff 221355. Szelethus added a comment. The following words are echoing in my ears as I'm knowingly going completely against them: In D45532#1083670 , @NoQ wrote: > I'm asking for this because it's, like, actually

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - thanks! Comment at: llvm/include/llvm/ADT/iterator_range.h:27-33 +template +constexpr bool is_random_iterator() { + return std::is_same< +typename

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

martong added a comment. 2nd attempt to fix the windows build errors: 372646 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 ___ cfe-commits mailing list

[PATCH] D67774: [Mangle] Add flag to asm labels to disable global prefixing

rjmccall added inline comments. Comment at: clang/include/clang/Basic/Attr.td:734 +// TODO: Make it possible to specify this in source. +BoolArgument<"LiteralLabel"> + ]; `LiteralLabel` is an unfortunate name for this property because `getLiteralLabel`

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. Got myself distracted with a tiny fix

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach marked 5 inline comments as done. dmaclach added inline comments. Comment at: clang-tidy/objc/AvoidOSReadCheck.cpp:21 +void AvoidOSReadCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + callExpr(callee((functionDecl(hasAnyName(

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

Szelethus added a comment. Hmm, so before this patch, we just used `LVNode` everywhere and ignored `InputNode`. It may not have made much sense, but its still not as confusing as using both if the creation of `LVNode` is unnecessary overall. Could we just remove it? Comment

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

ostannard added a comment. > This makes the IR self-contained, which is good, but it also make the > interpretation of the IR modal, which isn't great. It means that suddenly the > rules of interpretation of what is valid to do or not changes according to > this module flag. I think the

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song created this revision. yonghong-song added reviewers: ast, eli.friedman. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, hiraditya. Herald added projects: clang, LLVM. Previous work for BPF CO-RE (compile once, run everywhere) tries to record structure, union and

r372663 - Support for DWARF-5 C++ language tags.

Author: adrian Date: Mon Sep 23 15:01:49 2019 New Revision: 372663 URL: http://llvm.org/viewvc/llvm-project?rev=372663=rev Log: Support for DWARF-5 C++ language tags. This patch provides support for DW_LANG_C_plus_plus_11, DW_LANG_C_plus_plus_14 tags in the Clang C++ frontend. Patch by Sourabh

[PATCH] D67739: [WebAssembly] Let users know that wasm64 does not exist

tlively planned changes to this revision. tlively added a comment. It sounds reasonable to check this from the backend instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67739/new/ https://reviews.llvm.org/D67739

[PATCH] D67935: Add `#pragma clang deprecated`, used to deprecate macros

erik.pilkington created this revision. erik.pilkington added reviewers: rsmith, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a project: clang. This patch adds support for `#pragma clang deprecated`, which emits a deprecated warning whenever it is

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

This revision was automatically updated to reflect the committed changes. Closed by commit rL372663: Support for DWARF-5 C++ language tags. (authored by adrian, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221420. dmaclach added a comment. Fixed up review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h

[PATCH] D65841: [Driver] Switch -stdlib++-isystem test to -###-verbatim

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65841/new/ https://reviews.llvm.org/D65841

r372664 - [Diagnostics] Warn for enum constants in bool context (-Wint-in-bool-context; GCC compatibility)

Author: xbolva00 Date: Mon Sep 23 15:09:49 2019 New Revision: 372664 URL: http://llvm.org/viewvc/llvm-project?rev=372664=rev Log: [Diagnostics] Warn for enum constants in bool context (-Wint-in-bool-context; GCC compatibility) Extracted from D63082. Modified:

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

xbolva00 added a comment. /srv/llvm-buildbot-srcatch/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/modularize/Modularize.cpp:583:13: warning: enumeration values 'lang_cxx_11' and 'lang_cxx_14' not handled in switch [-Wswitch] 1 warning generated. Repository: rL

r372668 - [NFCI] Return PathSensitiveBugReport where appropriate

Author: xiaobai Date: Mon Sep 23 15:24:47 2019 New Revision: 372668 URL: http://llvm.org/viewvc/llvm-project?rev=372668=rev Log: [NFCI] Return PathSensitiveBugReport where appropriate Some compilers have trouble converting unique_ptr to unique_ptr causing some functions to fail to compile.

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/objc-avoid-osread.rst:26 + +The OSRead* functions from libkern/OSByteOrder.h have undocumented dependencies on aligned reads due to type punning by casting through a pointer: + Please

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach updated this revision to Diff 221433. dmaclach added a comment. Updated based on review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 Files: clang-tidy/objc/AvoidOSReadCheck.cpp clang-tidy/objc/AvoidOSReadCheck.h

r372672 - Revert "Support for DWARF-5 C++ language tags."

Author: jdevlieghere Date: Mon Sep 23 16:49:36 2019 New Revision: 372672 URL: http://llvm.org/viewvc/llvm-project?rev=372672=rev Log: Revert "Support for DWARF-5 C++ language tags." This reverts commit bf9c8ffb54943c6d77398adbedddf05ef9724007. Modified: cfe/trunk/include/clang/AST/DeclCXX.h

r372688 - [ASTImporter] 3rd attempt to fix Windows buildbot test errors

Author: martong Date: Mon Sep 23 22:50:02 2019 New Revision: 372688 URL: http://llvm.org/viewvc/llvm-project?rev=372688=rev Log: [ASTImporter] 3rd attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified:

[PATCH] D67940: [BPF] Preserve and make bitfield access relocatable

yonghong-song updated this revision to Diff 221466. yonghong-song added a comment. Herald added a subscriber: ormris. fix a bug like `foo(..., bar(), value)` where `value` is set in function `bar`. This is not right and depends on compiler optimization as there is not guarantee that arguments

r372685 - Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__"

Author: jkorous Date: Mon Sep 23 20:19:20 2019 New Revision: 372685 URL: http://llvm.org/viewvc/llvm-project?rev=372685=rev Log: Revert "[static analyzer][test] Test directly that driver sets D__clang_analyzer__" This reverts commit c7541903d72765a38808e9973572a8d50c9d94fb. Modified:

r372687 - Revert "[static analyzer] Define __clang_analyzer__ macro in driver"

Author: jkorous Date: Mon Sep 23 20:21:22 2019 New Revision: 372687 URL: http://llvm.org/viewvc/llvm-project?rev=372687=rev Log: Revert "[static analyzer] Define __clang_analyzer__ macro in driver" This reverts commit fbd13570b0d5f92ef2cf6bcfe7cc2f6178500187. Removed:

[PATCH] D66046: Add new tautological compare warning for bitwise-or with a non-zero constant

xbolva00 added a comment. In D66046#1634055 , @sylvestre.ledru wrote: > You should also probably add a note in the release notes (maybe for the > others changes too) > thanks for the work btw! +1 CHANGES SINCE LAST ACTION

  1   2   >