r372709 - [NFC] Update test after r372708

Author: xbolva00 Date: Tue Sep 24 02:24:48 2019 New Revision: 372709 URL: http://llvm.org/viewvc/llvm-project?rev=372709=rev Log: [NFC] Update test after r372708 Modified: cfe/trunk/test/SemaCXX/cxx2a-explicit-bool.cpp Modified: cfe/trunk/test/SemaCXX/cxx2a-explicit-bool.cpp URL:

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221499. usaxena95 marked 7 inline comments as done. usaxena95 added a comment. Addressed comments: Added client/server capabilities. Made lit test smaller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. I am not sure adding client capability is useful here. I have not used the client capability for selectionRange anywhere and I think we can remove it. WDYT ? Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { +

[clang-tools-extra] r372704 - Revert rL372693 : [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Author: rksimon Date: Tue Sep 24 01:56:44 2019 New Revision: 372704 URL: http://llvm.org/viewvc/llvm-project?rev=372704=rev Log: Revert rL372693 : [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops Finding infinite loops is well-known to be impossible (halting

r372705 - [ASTImporter] 4th attempt to fix Windows buildbot test errors

Author: martong Date: Tue Sep 24 02:00:46 2019 New Revision: 372705 URL: http://llvm.org/viewvc/llvm-project?rev=372705=rev Log: [ASTImporter] 4th attempt to fix Windows buildbot test errors Modified: cfe/trunk/unittests/AST/ASTImporterODRStrategiesTest.cpp Modified:

[clang-tools-extra] r372714 - [modularize] Fix compilation warning after r372681

Author: uabelho Date: Tue Sep 24 02:44:55 2019 New Revision: 372714 URL: http://llvm.org/viewvc/llvm-project?rev=372714=rev Log: [modularize] Fix compilation warning after r372681 In r372681 lang_cxx_11 and lang_cxx_14 were added to LanguageIDs but they were not handled in the switch in

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein updated this revision to Diff 221501. hokein marked 10 inline comments as done. hokein added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67496/new/ https://reviews.llvm.org/D67496 Files:

Re: [clang-tools-extra] r372693 - [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Hi Adam, Is InfiniteLoopCheck.cpp missing? I get CMake Error at /data/repo/master/llvm/cmake/modules/AddLLVM.cmake:443 (add_library): Cannot find source file: InfiniteLoopCheck.cpp /Mikael On Tue, 2019-09-24 at 07:43 +, Adam Balogh via cfe-commits wrote: > Author:

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3d969453c9: Revert rL372693 : [clang-tidy] New bugprone-infinite-loop check for detecting… (authored by RKSimon).

[clang-tools-extra] r372706 - [clang-tidy] Add missing InfiniteLoopCheck.h, InfiniteLoopCheck.cpp and test from D64736

Author: maskray Date: Tue Sep 24 02:06:31 2019 New Revision: 372706 URL: http://llvm.org/viewvc/llvm-project?rev=372706=rev Log: [clang-tidy] Add missing InfiniteLoopCheck.h, InfiniteLoopCheck.cpp and test from D64736 Added: clang-tools-extra/trunk/clang-tidy/bugprone/InfiniteLoopCheck.cpp

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein updated this revision to Diff 221492. hokein marked 2 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67496/new/ https://reviews.llvm.org/D67496 Files:

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein updated this revision to Diff 221504. hokein added a comment. update header guard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67496/new/ https://reviews.llvm.org/D67496 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

wenju added a comment. We see error "clang (LLVM option parsing): for the --pgo-warn-misexpect option: may only occur zero or one times!" when clang::CompilerInvocation::CreateFromArgs and clang::ExecuteCompilerInvocation are called twice. This line: if

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL372693: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite… (authored by baloghadamsoftware,

[PATCH] D67907: [clangd] Implement a smart version of HeaderSource switch.

hokein added inline comments. Comment at: clang-tools-extra/clangd/HeaderSourceSwitch.cpp:21 +// file. +class CollectIndexableLocalDecls { +public: kadircet wrote: > this class doesn't seem to have any state(apart from saving AST in > constructor and using it

[PATCH] D67907: [clangd] Implement a smart version of HeaderSource switch.

hokein updated this revision to Diff 221486. hokein marked 4 inline comments as done. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67907/new/ https://reviews.llvm.org/D67907 Files:

[clang-tools-extra] r372715 - [clang-tidy][test] Add -fexceptions to bugprone-infinite-loop.test

Author: maskray Date: Tue Sep 24 02:55:35 2019 New Revision: 372715 URL: http://llvm.org/viewvc/llvm-project?rev=372715=rev Log: [clang-tidy][test] Add -fexceptions to bugprone-infinite-loop.test This fixes llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast. -fexceptions is disabled by default on XCore

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

mehdi_amini added a comment. In D63932#1679910 , @ostannard wrote: > > This makes the IR self-contained, which is good, but it also make the > > interpretation of the IR modal, which isn't great. It means that suddenly > > the rules of interpretation of

[clang-tools-extra] r372693 - [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

Author: baloghadamsoftware Date: Tue Sep 24 00:43:26 2019 New Revision: 372693 URL: http://llvm.org/viewvc/llvm-project?rev=372693=rev Log: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops Finding infinite loops is well-known to be impossible (halting problem).

[PATCH] D67826: [clangd] A helper to find explicit references and their names

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:376 + + // We prefer to return template instantiation, but fallback to template + // pattern if instantiation is not available.

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Macro.h:59 + +if (auto Range = getTokenRange(SM, LangOpts, MacroNameTok.getLocation())) { + MainFileMacros.push_back( hokein wrote:

[PATCH] D67932: [analyzer] Fix accidentally skipping the call during inlined defensive check suppression.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. If you could change that, it would be awesome! But since this revision has its own side effect, let's commit as-is. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

baloghadamsoftware added a comment. In D64736#1680309 , @RKSimon wrote: > @baloghadamsoftware I'm sorry but I've reverted this at as rL372704 > it was causing buildbot failures in > cmake:

r372708 - [Diagnostics] Do not diagnose unsigned shifts in boolean context (-Wint-in-bool-context)

Author: xbolva00 Date: Tue Sep 24 02:14:33 2019 New Revision: 372708 URL: http://llvm.org/viewvc/llvm-project?rev=372708=rev Log: [Diagnostics] Do not diagnose unsigned shifts in boolean context (-Wint-in-bool-context) I was looking at old GCC's patch. Current "trunk" version avoids warning for

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67949/new/ https://reviews.llvm.org/D67949 ___ cfe-commits

[PATCH] D53137: Scalable vector core instruction support + size queries

rovka added a comment. > I suspect 'ScalableSize' is the wrong term now; 'TypeSize' may be better. > Thoughts? I agree, TypeSize sounds better. Maybe we can replace the public constructor with 2 static methods, TypeSize::Fixed(Size) and TypeSize::Scalable(Size), so we don't always have to

[clang-tools-extra] r372711 - [clang-tidy] Add bugprone-infinite-loop.rst from D64736 to fix buildbot

Author: maskray Date: Tue Sep 24 02:32:00 2019 New Revision: 372711 URL: http://llvm.org/viewvc/llvm-project?rev=372711=rev Log: [clang-tidy] Add bugprone-infinite-loop.rst from D64736 to fix buildbot Added: clang-tools-extra/trunk/docs/clang-tidy/checks/bugprone-infinite-loop.rst Added:

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM, thanks. A ton of small NITs too, but they're all small details. Comment at: clang-tools-extra/clangd/Macro.h:1 +//===--- Macro.h

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

SouraVX added a comment. In D67613#1680176 , @uabelho wrote: > In D67613#1679879 , @xbolva00 wrote: > > >

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. In D67720#1680460 , @usaxena95 wrote: > I am not sure adding client capability is useful here. I have not used the > client capability for selectionRange anywhere and I think we can remove it. > WDYT ? The

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: pseyfert, klimek, owenpan. MyDeveloperDay added a project: clang-tools-extra. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=36858 identifies .hh as a missing C++ header extension file while making this

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

RKSimon reopened this revision. RKSimon added a comment. @baloghadamsoftware I'm sorry but I've reverted this at as rL372704 it was causing buildbot failures in cmake: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18147 Repository: rL

[PATCH] D67613: [DWARF-5] Support for DWARF-5 C++ language tags

uabelho added a comment. In D67613#1680176 , @uabelho wrote: > In D67613#1679879 , @xbolva00 wrote: > > >

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

hokein added inline comments. Comment at: clang-tools-extra/clangd/Macro.h:67 + bool InMainFile = true; + std::vector +}; ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Could we model in a way that avoids duplicating macro names on each

[clang-tools-extra] r372725 - [clangd] Collect macros in the preamble region of the main file

Author: hokein Date: Tue Sep 24 04:14:06 2019 New Revision: 372725 URL: http://llvm.org/viewvc/llvm-project?rev=372725=rev Log: [clangd] Collect macros in the preamble region of the main file Summary: - store all macro references in the ParsedAST; - unify the two variants of

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action,

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

Anastasia added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in OpenCL}} +// expected-error@-3{{implicit conversion changes signedness: 'int' to 'uint'

[PATCH] D67496: [clangd] Collect macros in the preamble region of the main file

This revision was automatically updated to reflect the committed changes. Closed by commit rL372725: [clangd] Collect macros in the preamble region of the main file (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221508. hokein marked 8 inline comments as done. hokein added a comment. Herald added a subscriber: usaxena95. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221509. hokein added a comment. fix a typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files: clang-tools-extra/docs/clangd/Installation.rst Index:

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

lebedev.ri added a subscriber: tstellar. lebedev.ri added a comment. Actually, uh oh. @Jiboo can you please file this as a bug? This really should go into next patch release. CC @tstellar @Szelethus this breaks LLVMExports.cmake as compared with LLVM-8, so it's actually a critical bug.

[clang-tools-extra] r372752 - [clangd] Save an unnecessary copy, NFC.

Author: hokein Date: Tue Sep 24 06:25:38 2019 New Revision: 372752 URL: http://llvm.org/viewvc/llvm-project?rev=372752=rev Log: [clangd] Save an unnecessary copy, NFC. Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp URL:

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl added a comment. In D67837#1679670 , @rjmccall wrote: > Okay. And it's okay to fall down to the code below when functions are used > in both ways this way? This part of code is for delayed checking of hostness. If a host function calls device

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

cishida added inline comments. Comment at: clang/include/clang/Driver/Options.td:635 + Flags<[CC1Option]>, Group, + HelpText<"Generate Inteface Stub Files, emit merged text not binary.">; def iterface_stub_version_EQ : JoinedOrSeparate<["-"], "interface-stub-version=">,

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); Does the interface

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D67964: [clangd] Update vscode lsp dependencies to pickup the new changes in LSP v3.15.0.

hokein created this revision. hokein added a reviewer: usaxena95. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This would enable the newly-added semantic selection feature in vscode. Repository: rG LLVM Github Monorepo

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Szelethus added a comment. I have no objections on my end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list

[PATCH] D67713: [OpenCL] Add image query builtin functions

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67713/new/ https://reviews.llvm.org/D67713

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221510. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein updated this revision to Diff 221523. hokein marked 2 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66937/new/ https://reviews.llvm.org/D66937 Files:

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:365 +- background indexing canb be disable by the ``--background-index=false`` flag; + if it is disabled, clangd doesn't have a global view of the whole project, it + only has a view on

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221534. usaxena95 added a comment. Removed ununsed header. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

hokein added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D66937: [clangd] Fix the stale documentation about background indexing.

kadircet added inline comments. Comment at: clang-tools-extra/docs/clangd/Installation.rst:363 -- Pass an experimental `-background-index` command line argument. With - this feature enabled, clangd incrementally builds an index of projects - that you work on and uses the

[clang-tools-extra] r372753 - [clangd] Add semantic selection to ClangdLSPServer.

Author: usaxena95 Date: Tue Sep 24 06:38:33 2019 New Revision: 372753 URL: http://llvm.org/viewvc/llvm-project?rev=372753=rev Log: [clangd] Add semantic selection to ClangdLSPServer. Summary: This adds semantic selection to the LSP Server. Adds support for serialization of input request and the

[PATCH] D67826: [clangd] A helper to find explicit references and their names

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.h:96 +}; +llvm::raw_ostream <<(llvm::raw_ostream , ReferenceLoc R); + ilya-biryukov wrote: > kadircet wrote: > > Is this for testing

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added a comment. > The SelectionRangeClientCapabilities determines what should the LSP server > send the client, if it is true, clangd should send > SelectionRangeRegistrationOptions. > But looking at the current specification, it doesn't seem to add too much > value. I think we

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein added a comment. mostly good, a few nits. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1131 +Callback> Reply) { + if (Params.positions.size() != 1) { +elog("{0} positions provided to SelectionRange. Supports exactly one " usaxena95

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221522. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Use DeclRefExpr::getFoundDecl, add a test - Update a comment - Remove redundant anon namespace declaration - Remove :wa - Do not filter-out macro references -

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov marked 9 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:432 + Ref = ReferenceLoc{ + E->getQualifierLoc(), E->getNameInfo().getLoc(), {E->getDecl()}}; +} kadircet

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 updated this revision to Diff 221521. usaxena95 marked 9 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67720/new/ https://reviews.llvm.org/D67720 Files:

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1169 +Result.emplace_back(render(std::move(*Ranges))); +return Reply(std::move(Result)); + }); hokein wrote: > does

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Comment at: clang-tools-extra/clangd/Protocol.cpp:18 #include "llvm/ADT/Hashing.h" +#include "llvm/ADT/STLExtras.h" #include "llvm/ADT/SmallString.h"

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. Here you go: https://bugs.llvm.org/show_bug.cgi?id=43430 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67877/new/ https://reviews.llvm.org/D67877 ___ cfe-commits mailing list

[PATCH] D67960: [clangd] Move the existing heder-source-switch implemenation out of clangdServer.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a NFC change. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D67960 Files:

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision introduces a separate (small) library for the `MatchConsumer` abstraction: computations over AST match results. This abstraction is central to the Transformer framework, and there

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

ymandel updated this revision to Diff 221531. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67961/new/ https://reviews.llvm.org/D67961 Files: clang/include/clang/Tooling/Refactoring/MatchConsumer.h

[PATCH] D67720: [clangd] Add semantic selection to ClangdLSPServer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372753: [clangd] Add semantic selection to ClangdLSPServer. (authored by usaxena95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r372749 - [Diagnostics] Handle tautological left shifts in boolean context

Author: xbolva00 Date: Tue Sep 24 06:14:18 2019 New Revision: 372749 URL: http://llvm.org/viewvc/llvm-project?rev=372749=rev Log: [Diagnostics] Handle tautological left shifts in boolean context Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D67949: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

This revision was automatically updated to reflect the committed changes. Closed by commit rL372760: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r372760 - [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities

Author: paulhoad Date: Tue Sep 24 07:00:06 2019 New Revision: 372760 URL: http://llvm.org/viewvc/llvm-project?rev=372760=rev Log: [clang-format] [PR36858] Add missing .hh and .cs extensions from python support utilities Summary: https://bugs.llvm.org/show_bug.cgi?id=36858 identifies .hh as a

[PATCH] D67947: [HIP] Support new kernel launching API

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67947/new/ https://reviews.llvm.org/D67947 ___ cfe-commits mailing list

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

That said, prior art in gcc in this area: -fasynchronous-unwind-tables Generate unwind table in DWARF format, if supported by target machine. The table is exact at each instruction boundary, so it can be used for stack unwinding from asynchronous events (such as debugger or garbage collector).

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel updated this revision to Diff 221554. ymandel added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67969/new/ https://reviews.llvm.org/D67969 Files: clang/include/clang/Tooling/Refactoring/Stencil.h

[PATCH] D67714: [OpenCL] Add -Wconversion to fdeclare-opencl-builtins test

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/test/SemaOpenCL/fdeclare-opencl-builtins.cl:102 // expected-error@-2{{implicit declaration of function 'get_sub_group_size' is invalid in OpenCL}} +// expected-error@-3{{implicit

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. @tejohnson for example: $ clang -flto a.c -c -o a.o $ llvm-ar q a.a a.o // archive libraries $ clang -flto a.a b.c -O2 -o main -mcmodel=small In above case user need to aware that passing `-Wl,-plugin-opt=-code-model=small` to plugin is necessary.

[PATCH] D67385: Pass -mcmodel to LTO plugin

tejohnson added a comment. In D67385#1680942 , @khchen wrote: > @tejohnson for example: > > $ clang -flto a.c -c -o a.o > $ llvm-ar q a.a a.o // archive libraries > $ clang -flto a.a b.c -O2 -o main -mcmodel=small > > > In above case

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision adds `run`, a StencilPart that runs a user-defined function that computes a result over `MatchFinder::MatchResult`. Repository: rG LLVM Github Monorepo

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

atanasyan accepted this revision. atanasyan added a comment. LGTM. But before commit get more approvals. For example, from echristo, code owners of other targets, etc. I would keep the as-is. In that case a target of such huge modifications looks a bit more clear. CHANGES SINCE LAST ACTION

[PATCH] D67216: [cfi] Add flag to always generate call frame information

keith.walker.arm added a comment. I feel that using a -g option make more sense. Maybe -gdwarf-frame, or -gdwarf-frame-always might be more user friendly as it relates more to the DWARF section created rather than the section content. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action,

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 3 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D60748: Fix i386 struct and union parameter alignment

emaste added a comment. In D60748#1499756 , @dim wrote: > Please also exclude FreeBSD from these changes, since we care a lot about > backwards compatibility, and specifically about alignment requirements. (We > have run into many issues in our ports

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev marked 2 inline comments as done. anton-afanasyev added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager)

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker updated this revision to Diff 221568. Tyker marked 7 inline comments as done. Tyker added a comment. fixed most comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:599 Out << '[' << Path[I].getAsArrayIndex() << ']'; -ElemTy = Ctx.getAsArrayType(ElemTy)->getElementType(); +ElemTy = cast(ElemTy)->getElementType(); }

[PATCH] D60748: Fix i386 struct and union parameter alignment

kib added a comment. In fact, can we have an option controlling this ? Does it have anything to do with -malign-data gcc switch ? We do want to be able to optionally generate code ABI-compatible with modern gcc, per user discretion. CHANGES SINCE LAST ACTION

r372773 - [HIP] Support new kernel launching API

Author: yaxunl Date: Tue Sep 24 12:16:40 2019 New Revision: 372773 URL: http://llvm.org/viewvc/llvm-project?rev=372773=rev Log: [HIP] Support new kernel launching API Differential Revision: https://reviews.llvm.org/D67947 Modified: cfe/trunk/include/clang/Basic/LangOptions.def

[PATCH] D67947: [HIP] Support new kernel launching API

This revision was automatically updated to reflect the committed changes. Closed by commit rL372773: [HIP] Support new kernel launching API (authored by yaxunl, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: cfe/trunk/lib/CodeGen/BackendUtil.cpp:1426-1431 EmitAssemblyHelper AsmHelper(Diags, HeaderOpts, CGOpts, TOpts, LOpts, M); if (CGOpts.ExperimentalNewPassManager) AsmHelper.EmitAssemblyWithNewPassManager(Action,

Re: [PATCH] D67216: [cfi] Add flag to always generate call frame information

Does the current code generate all the prologue cfi directives?  Epilogue too?  The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work.  We're also looking at using the compact format

[PATCH] D67216: [cfi] Add flag to always generate call frame information

JohnReagan added a comment. Does the current code generate all the prologue cfi directives? Epilogue too? The last time I checked, it did not (especially for epilogues). Fully asynch prologue/epilogue is one of the things that we need for OpenVMS and will be doing that work. We're also

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov updated this revision to Diff 221556. ilya-biryukov marked 8 inline comments as done. ilya-biryukov added a comment. - Remove ExprMemberBase - Add an overload for Decl* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67826/new/

[PATCH] D67826: [clangd] A helper to find explicit references and their names

ilya-biryukov added a comment. I believe all comments were addressed. PTAL and let me know if I missed something. Comment at: clang-tools-extra/clangd/FindTarget.h:93 + /// in 'obj.foo'. + const Expr* MemberExprBase = nullptr; +}; kadircet wrote: > do we

[PATCH] D67385: Pass -mcmodel to LTO plugin

khchen added a comment. In D67385#1680959 , @tejohnson wrote: > In D67385#1680942 , @khchen wrote: > > > @tejohnson for example: > > > > $ clang -flto a.c -c -o a.o > > $ llvm-ar q a.a a.o // archive

[PATCH] D67971: [WIP] Add warning when zero-initializing a union if its first member is not is largest

leonardchan created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This may result in the entire union not being initialized. For example: union U { uint32_t x; uint64_t y; }; void func() { U u = {}; ... } Some might assume that

[PATCH] D67973: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. Currently, some tests use homegrown matchers to handle `llvm::Expected` values. This revision standardizes on EXPECT_THAT_EXPECTED and `HasValue`. Repository: rG LLVM Github Monorepo

  1   2   >