[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

sammccall added a comment. Thanks, rL373724 should fix. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67541/new/ https://reviews.llvm.org/D67541 ___ cfe-commits mailing list

[PATCH] D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode

Anastasia added a comment. Can you please explain why we are deviating from C++ on this? My concern is that this can potentially uncover bugs in C++ parsing due to un-handled restrict cases that would have to be fixed in some unclear way... I would appreciate more detailed analysis before we

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

MaskRay added a comment. Why "inactive region", not "skipped ranges"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 ___ cfe-commits mailing list

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:66 CI->getLangOpts()->CommentOpts.ParseAllComments = true; + CI->getPreprocessorOpts().DetailedRecord = true; return CI; hokein wrote: > I'm not sure how does this flag

[PATCH] D67629: [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rL373707: [clang-format] [PR4] Fix C# breaking before function name when using… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68335: [CodeComplete] Ensure object is the same in compareOverloads()

ilya-biryukov added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:1188 ExprValueKind ObjectKind) { + // This function does not take object type into account. + if (Candidate.getDeclContext() !=

[PATCH] D68335: [CodeComplete] Ensure object is the same in compareOverloads()

ilya-biryukov updated this revision to Diff 223160. ilya-biryukov marked 3 inline comments as done. ilya-biryukov added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68335/new/ https://reviews.llvm.org/D68335 Files:

[PATCH] D67660: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

This revision was automatically updated to reflect the committed changes. Closed by commit rL373709: [clang-format] [PR43338] C# clang format has space issues betweern C# only… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68335: [CodeComplete] Ensure object is the same in compareOverloads()

This revision was automatically updated to reflect the committed changes. Closed by commit rL373710: [CodeComplete] Ensure object is the same in compareOverloads() (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers

baloghadamsoftware added a comment. In D67336#1664168 , @NoQ wrote: > I have mixed feelings. Removing boilerplate is good, but the very fact that > we're legalizing this pattern indicates that our checkers will keep bloating > up, while i always wanted

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd added a comment. In D65761#1660121 , @rnk wrote: > Here is some feedback, I apologize for dragging my feet. > > Also, I would really like to get feedback from @pcc. He's OOO currently, > though. Thanks for this really helpful feedback @rnk! I

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd marked 9 inline comments as done. ajpaverd added inline comments. Comment at: clang/include/clang/Driver/Options.td:500 def b : JoinedOrSeparate<["-"], "b">, Flags<[Unsupported]>; +def cfguard_no_checks : Flag<["-"], "cfguard-no-checks">, Flags<[CC1Option]>, +

r373724 - [Format] Fix docs after r373439

Author: sammccall Date: Fri Oct 4 02:52:54 2019 New Revision: 373724 URL: http://llvm.org/viewvc/llvm-project?rev=373724=rev Log: [Format] Fix docs after r373439 Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst Modified: cfe/trunk/docs/ClangFormatStyleOptions.rst URL:

[PATCH] D68388: [PR41008][OpenCL] Support restrict keyword in C++ mode

kpet added a comment. Something I should probably have explained in the commit message is that the functionality provided by `restrict` is already present in C++, where it is already exposed using different keywords. If you look at `clang/include/clang/Basic/TokenKinds.def`, there are

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/lib/AST/Decl.cpp:3107 +if (!ArmMveAliasValid(BuiltinID, getIdentifier()->getName())) { + getASTContext().getDiagnostics().Report( +getLocation(),

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

jrtc27 created this revision. jrtc27 added reviewers: rsmith, xbolva00. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68526 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sema/div-sizeof-array.cpp

r373709 - [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords

Author: paulhoad Date: Fri Oct 4 01:10:22 2019 New Revision: 373709 URL: http://llvm.org/viewvc/llvm-project?rev=373709=rev Log: [clang-format] [PR43338] C# clang format has space issues betweern C# only keywords Summary: When formatting C# there can be issues with a lack of spaces between

r373710 - [CodeComplete] Ensure object is the same in compareOverloads()

Author: ibiryukov Date: Fri Oct 4 01:10:27 2019 New Revision: 373710 URL: http://llvm.org/viewvc/llvm-project?rev=373710=rev Log: [CodeComplete] Ensure object is the same in compareOverloads() Summary: This fixes a regression that led to size() not being available in clangd when completing

[clang-tools-extra] r373710 - [CodeComplete] Ensure object is the same in compareOverloads()

Author: ibiryukov Date: Fri Oct 4 01:10:27 2019 New Revision: 373710 URL: http://llvm.org/viewvc/llvm-project?rev=373710=rev Log: [CodeComplete] Ensure object is the same in compareOverloads() Summary: This fixes a regression that led to size() not being available in clangd when completing

[PATCH] D68380: [Driver] NFC: Remove duplicate call to getLibGccType

This revision was automatically updated to reflect the committed changes. Closed by commit rL373712: [Driver] NFC: Remove duplicate call to getLibGccType (authored by c-rhodes, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

ajpaverd updated this revision to Diff 223167. ajpaverd marked 22 inline comments as done. ajpaverd added a comment. Improved Control Flow Guard implementation. As suggested by @rnk, the CFGuard dispatch mechanism now uses a new `cfguardtarget` operand bundle to pass the indirect call target.

r373711 - [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST

Author: teemperor Date: Fri Oct 4 01:26:17 2019 New Revision: 373711 URL: http://llvm.org/viewvc/llvm-project?rev=373711=rev Log: [lldb][modern-type-lookup] No longer import temporary declarations into the persistent AST Summary: As we figured out in D67803, importing declarations from a

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. I don't think I can review that but I do appreciate the feature! Maybe we should make that explicit in the release notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

mgorny added a comment. What do you mean by 'feature'? clang-cpp library or `clang_target_link_libraries` function? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with a few nitpicks about unnecessary nesting. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:205 + return; +if (*First == '\\') {

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

mgorny created this revision. mgorny added reviewers: sylvestre.ledru, tstellar, beanz, phosek. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous. Use clang_target_link_libraries() in order to support linking against libclang-cpp instead of static libraries.

r373707 - [clang-format] [PR43333] Fix C# breaking before function name when using Attributes

Author: paulhoad Date: Fri Oct 4 00:56:49 2019 New Revision: 373707 URL: http://llvm.org/viewvc/llvm-project?rev=373707=rev Log: [clang-format] [PR4] Fix C# breaking before function name when using Attributes Summary: This is a fix for https://bugs.llvm.org/show_bug.cgi?id=4 This

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. More dynamic, less static usage :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68273: [clangd] Fix raciness in code completion tests

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:1141 +

[PATCH] D68166: [Clang][OpenMP Offload] Add new tool for wrapping offload device binaries

sdmitriev updated this revision to Diff 223335. sdmitriev added a comment. Rebased patch and changed clang-offload-wrapper CMakeLists.txt to use add_clang_tool() rather than add_clang_executable() with a custom install rule. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68166/new/

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Bigcheese updated this revision to Diff 223345. Bigcheese retitled this revision from "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths." to "[Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.". Bigcheese

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. I think this is reasonable change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68526/new/ https://reviews.llvm.org/D68526

[PATCH] D63397: [clangd] Detect C++ for extension-less source files in vscode extension

malaperle added a comment. Herald added a subscriber: usaxena95. "Extend our extension to support detecting these files as C++ files based on the first line (-*- C++ -*-), it will make clangd work on C++ standard headers (e.g. iostream)." This is not in the standard right? I don't see this in

[PATCH] D68531: [WebAssembly] Add builtin and intrinsic for v8x16.swizzle

tlively created this revision. tlively added reviewers: aheejin, dschuff. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100. Herald added projects: clang, LLVM. This clang builtin and corresponding LLVM intrinsic are necessary to expose the exact

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

echristo created this revision. echristo added reviewers: chandlerc, hfinkel. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mcrosier. Herald added projects: clang, LLVM. In the new pass manager use PTO.LoopUnrolling to determine when and how we will unroll loops. Also comment a

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar created this revision. tstellar added a reviewer: beanz. Herald added a subscriber: mgorny. Herald added a project: clang. We were linking all the clang objects and shared libraries into libclang-cpp.so, which was causing the command line options to be registered twice. Repository:

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths.

Bigcheese created this revision. Bigcheese added reviewers: rsmith, bruno. Herald added a subscriber: dexonsmith. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D68528 Files: include/clang/Driver/CC1Options.td include/clang/Lex/HeaderSearchOptions.h

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:68 +// Lexes from end of \p FD until it finds a semicolon. +llvm::Optional getSemiColonForDecl(const FunctionDecl *FD) { "Lexes" is probably a not very

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68332/new/ https://reviews.llvm.org/D68332 ___ cfe-commits

r373753 - SemaDeclAttr - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Fri Oct 4 08:02:46 2019 New Revision: 373753 URL: http://llvm.org/viewvc/llvm-project?rev=373753=rev Log: SemaDeclAttr - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases

r373749 - Further improve -Wbool-operation bitwise negation message

Author: sammccall Date: Fri Oct 4 07:11:05 2019 New Revision: 373749 URL: http://llvm.org/viewvc/llvm-project?rev=373749=rev Log: Further improve -Wbool-operation bitwise negation message Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

This revision was automatically updated to reflect the committed changes. Closed by commit rL373751: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r373756 - [OPENMP50]Suppport for multiple vendors in the same vendor context

Author: abataev Date: Fri Oct 4 08:58:45 2019 New Revision: 373756 URL: http://llvm.org/viewvc/llvm-project?rev=373756=rev Log: [OPENMP50]Suppport for multiple vendors in the same vendor context selector. According to OpenMP 5.0, multiple vendors could be specified in the vendor context

[PATCH] D68193: In openFileForRead don't cache erroneous entries if the error relates to them being directories. Add tests.

kousikk added a comment. @dexonsmith when you get a chance, can you take another look at this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68193/new/ https://reviews.llvm.org/D68193 ___

r373748 - [clang-rename] Fix a crash when renaming a class without definition.

Author: hokein Date: Fri Oct 4 07:09:31 2019 New Revision: 373748 URL: http://llvm.org/viewvc/llvm-project?rev=373748=rev Log: [clang-rename] Fix a crash when renaming a class without definition. Reviewers: sammccall Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D68459: [clang-rename] Fix a crash when renaming a class without definition.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373748: [clang-rename] Fix a crash when renaming a class without definition. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

MyDeveloperDay updated this revision to Diff 223215. MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. - add additional compl(5) and not(5) unit tests - improve the comments around the condition and explaining the tests - remove the use of .equals(...) CHANGES

r373751 - [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

Author: paulhoad Date: Fri Oct 4 07:25:20 2019 New Revision: 373751 URL: http://llvm.org/viewvc/llvm-project?rev=373751=rev Log: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting Summary: According to the clang-format documentation, "Fundamentally, C++11 braced

r373752 - CGBlocks - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Fri Oct 4 08:01:54 2019 New Revision: 373752 URL: http://llvm.org/viewvc/llvm-project?rev=373752=rev Log: CGBlocks - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 223233. yonghong-song edited the summary of this revision. yonghong-song added a comment. using 64bit buf always, handling non bitfield members, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r373750 - [clang-format] [PR43531] clang-format damages "alternative representations" for operators

Author: paulhoad Date: Fri Oct 4 07:16:59 2019 New Revision: 373750 URL: http://llvm.org/viewvc/llvm-project?rev=373750=rev Log: [clang-format] [PR43531] clang-format damages "alternative representations" for operators Summary: https://bugs.llvm.org/show_bug.cgi?id=43531 Fix for clang-format

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. LGTM and passes [--] Global test environment tear-down [==] 700 tests from 21 test cases ran. (67039 ms total) [ PASSED ] 700 tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/

[PATCH] D68332: [clang-format] [PR43531] clang-format damages "alternative representations" for operators

This revision was automatically updated to reflect the committed changes. Closed by commit rGba12cec21f55: [clang-format] [PR43531] clang-format damages alternative representations for… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

simon_tatham marked 20 inline comments as done. simon_tatham added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8529 "argument should be a multiple of %0">; +def err_argument_not_power_of_2 : Error< + "argument should be a power of 2">;

[PATCH] D68467: [clangd] If an undocumented definition exists, don't accept documentation from other forward decls.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. This fixes cases like: foo.h class Undocumented{} bar.h // break an include cycle. we

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

mitchell-stellar requested changes to this revision. mitchell-stellar added a comment. This revision now requires changes to proceed. This needs to be more thought out. At the very least it needs to cover more keywords like `do`, `switch`, `try`, and `catch`. There may be more. Consideration

[PATCH] D68436: [clang-scan-deps] Improve string/character literal skipping

kousikk accepted this revision. kousikk marked an inline comment as done. kousikk added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:206 +if (*First == '\\') { + if (++First == End) +return; dexonsmith

r373746 - [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

Author: paulhoad Date: Fri Oct 4 06:24:15 2019 New Revision: 373746 URL: http://llvm.org/viewvc/llvm-project?rev=373746=rev Log: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading Summary: https://bugs.llvm.org/show_bug.cgi?id=42417 This revision

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar updated this revision to Diff 223212. mitchell-stellar added a comment. Fixed empty parentheses unit test for C++11 braced initializer list. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 Files:

[PATCH] D68458: [clangd] Collect missing macro references.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Semantic highlghting is missing a few macro references. Repository: rG LLVM Github Monorepo

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

rnk accepted this revision. rnk added a comment. In D67847#1691898 , @jyknight wrote: > The `abort()` function raises SIGABRT, for which the default behavior is to > trigger a coredump. Do we actually want that behavior? > > Either `_exit()` (long

r373712 - [Driver] NFC: Remove duplicate call to getLibGccType

Author: c-rhodes Date: Fri Oct 4 01:26:37 2019 New Revision: 373712 URL: http://llvm.org/viewvc/llvm-project?rev=373712=rev Log: [Driver] NFC: Remove duplicate call to getLibGccType Reviewed By: saugustine Differential Revision: https://reviews.llvm.org/D68380 Modified:

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones planned changes to this revision. edward-jones added a comment. I'm reworking this at the moment and adding some tests. Standby! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

edward-jones updated this revision to Diff 223205. edward-jones added a comment. Herald added subscribers: arichardson, emaste. Herald added a reviewer: espindola. Rebased and added tests I've made this use the Triple from the driver rather than the parsed LLVM triple, this means the Triple

[clang-tools-extra] r373739 - [clangd] update the package-lock.json.

Author: hokein Date: Fri Oct 4 05:35:16 2019 New Revision: 373739 URL: http://llvm.org/viewvc/llvm-project?rev=373739=rev Log: [clangd] update the package-lock.json. Modified: clang-tools-extra/trunk/clangd/clients/clangd-vscode/package-lock.json Modified:

[PATCH] D68458: [clangd] Collect missing macro references.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68458/new/ https://reviews.llvm.org/D68458

r373743 - [NFCI] Improve the -Wbool-operation's warning message

Author: xbolva00 Date: Fri Oct 4 05:55:13 2019 New Revision: 373743 URL: http://llvm.org/viewvc/llvm-project?rev=373743=rev Log: [NFCI] Improve the -Wbool-operation's warning message Based on the request from the post commit review. Also added one new test. Modified:

r373744 - [clang] Prevent false positives in arm-mfpu-none codegen test.

Author: statham Date: Fri Oct 4 06:01:41 2019 New Revision: 373744 URL: http://llvm.org/viewvc/llvm-project?rev=373744=rev Log: [clang] Prevent false positives in arm-mfpu-none codegen test. A user pointed out to me in private email that this test will fail if it sees the letter 's' followed by

[PATCH] D68242: [clang-format] [PR42417] clang-format inserts a space after '->' for operator->() overloading

This revision was automatically updated to reflect the committed changes. Closed by commit rL373746: [clang-format] [PR42417] clang-format inserts a space after - for operator-… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

edward-jones updated this revision to Diff 223209. edward-jones retitled this revision from "[WIP][RISCV] Use compiler-rt if no GCC installation detected" to "[RISCV] Use compiler-rt if no GCC installation detected". edward-jones added a comment. Herald added subscribers: arichardson, emaste.

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

MyDeveloperDay added a comment. @mitchell-stellar I pulled the patch to commit it, but the unit tests fail, could you double-check them for me? [ OK ] FormatTest.LayoutBraceInitializersInReturnStatement (13 ms) [ RUN ] FormatTest.LayoutCxx11BraceInitializers

[PATCH] D68459: [clang-rename] Fix a crash when renaming a class without definition.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68459 Files: clang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp clang/test/clang-rename/ForwardClassDecl.cpp Index:

[PATCH] D68415: [clang-format] C++11 braced lists should respect the SpacesInParentheses setting

mitchell-stellar added a comment. You are correct. I'll work on this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68415/new/ https://reviews.llvm.org/D68415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67773: [clang-format[PR43144] Add support for SpaceAroundBraces style

MyDeveloperDay added a comment. In D67773#1694797 , @mitchell-stellar wrote: > This needs to be more thought out. At the very least it needs to cover more > keywords like `do`, `switch`, `try`, and `catch`. There may be more. > Consideration also needs

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar created this revision. mitchell-stellar added reviewers: MyDeveloperDay, reuk, owenpan. mitchell-stellar added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch makes the `SpacesInSquareBrackets` setting also apply to C++

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

poelmanc added a comment. Herald added a subscriber: mgehre. Hi @alexfh, @jonathanmeier has reviewed my pull request but lacks commit access. It changes ~30 lines of code isolated to modernize-use-using.cpp and adds ~60 lines of tests. If you have time I'd greatly appreciate it if you could

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose added a comment. In D68430#1693965 , @beanz wrote: > clang_cpp can't link the libraries "normally" because it has no unresolved > symbols to force the contents of the libraries to link. I don't like it, but > I think the best option is to

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

aaron.ballman added inline comments. Comment at: clang/lib/AST/Decl.cpp:3107 +if (!ArmMveAliasValid(BuiltinID, getIdentifier()->getName())) { + getASTContext().getDiagnostics().Report( +getLocation(), diag::err_attribute_arm_mve_alias);

[PATCH] D67775: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for this! Comment at: clang/test/Sema/format-strings-pedantic.c:1 -// RUN: %clang_cc1 -fsyntax-only -verify -Wformat -Wformat-pedantic -isystem

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose updated this revision to Diff 223250. jordan_rose added a comment. Okay, having Xcode force-load the static libraries doesn't seem bad at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430

[PATCH] D64874: [Sema] Improve handling of function pointer conversions

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, though I'd like to see this generalized to handle noreturn too. Comment at: clang/lib/Sema/SemaTemplate.cpp:6997 + QualType ResultTy; + if

[PATCH] D64820: [Sema] Avoids an assertion failure when an invalid conversion declaration is used

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64820/new/ https://reviews.llvm.org/D64820 ___ cfe-commits mailing list

[PATCH] D68430: Don't use object libraries with Xcode

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. That's fine. That said, there are things that just can't be done, or don't work well, in the Xcode and Visual Studio generators, so we have precedent for disabling functionality based on those

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang updated this revision to Diff 223255. akhuang added a comment. - move TokenCollector out of function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/ https://reviews.llvm.org/D68114 Files: clang/lib/Lex/Pragma.cpp

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Maybe it could be mentioned in the release notes? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24243/new/ https://reviews.llvm.org/D24243

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

rnk added a subscriber: Bigcheese. rnk added a comment. + @Bigcheese, for amusement. We discussed some interesting behavior of _Pragma and C++ raw string literals last night. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68114/new/

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. In D24243#1695052 , @sylvestre.ledru wrote: > Maybe it could be mentioned in the release notes? Forget about this comment, I have been distracted by the fact that it is now installed https://reviews.llvm.org/D68423

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm I confirmed the test case matches the name that MSVC produces. I guess this regressed in rC362293 / D62746 , so the bug is

r373771 - Add missing null pointer check in -ftime-trace code

Author: rnk Date: Fri Oct 4 11:57:01 2019 New Revision: 373771 URL: http://llvm.org/viewvc/llvm-project?rev=373771=rev Log: Add missing null pointer check in -ftime-trace code createOutputFile diagnoses the error for the caller already, so recover by not writing the output. Fixes PR43555 No

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 223240. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX marked 7 inline comments as done. SouraVX added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1610 + if (const auto *CXXC = dyn_cast(Method)) { +if (CXXC->getCanonicalDecl()->isDeleted()) + SPFlags |= llvm::DISubprogram::SPFlagDeleted;

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

mitchell-stellar added a comment. Thanks, please commit on my behalf. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68473/new/ https://reviews.llvm.org/D68473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r373769 - [CMake] Clang: Don't use object libraries with Xcode

Author: jrose Date: Fri Oct 4 11:17:58 2019 New Revision: 373769 URL: http://llvm.org/viewvc/llvm-project?rev=373769=rev Log: [CMake] Clang: Don't use object libraries with Xcode Undoes some of the effects of r360946 when using the Xcode CMake generator---it doesn't handle object libraries

[PATCH] D68473: [clang-format] SpacesInSquareBrackets should affect lambdas with parameters too

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68473/new/ https://reviews.llvm.org/D68473

[PATCH] D65695: Implements CWG 1601 in [over.ics.rank/4.2]

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65695/new/ https://reviews.llvm.org/D65695 ___ cfe-commits mailing list

[PATCH] D68430: Don't use object libraries with Xcode

jordan_rose closed this revision. jordan_rose added a comment. Committed as rC373769 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68430/new/ https://reviews.llvm.org/D68430

r373774 - [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic

Author: epilk Date: Fri Oct 4 12:20:27 2019 New Revision: 373774 URL: http://llvm.org/viewvc/llvm-project?rev=373774=rev Log: [Sema] Split out -Wformat-type-confusion from -Wformat-pedantic The warnings now in -Wformat-type-confusion don't align with how we interpret 'pedantic' in clang, and

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added inline comments. Comment at: include/clang/Basic/Builtins.def:483 BUILTIN(__builtin_memcpy, "v*v*vC*z", "nF") +BUILTIN(__builtin_memccpy, "v*v*vC*iz", "nF") BUILTIN(__builtin_memmove, "v*v*vC*z", "nF") xbolva00 wrote: > aaron.ballman wrote:

  1   2   >