[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. In D68862#1708132 , @chill wrote: > In D68862#1708079 , @carwil wrote: > > > > IMHO, since reserved registes are per-function, this strongly suggests > > > implementation as function

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-38 See http://jenkins.llvm-merge-guard.org/job/Phabricator/38/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; can we rather use `uint8_t` in here

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Otherwise LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/ https://reviews.llvm.org/D68978

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:463 + // Server, CDB, etc. + llvm::Optional MainContext; + MainContext.emplace(BackgroundContext.clone()); As discussed offline: I think it'd be clearer to put this in a

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

kadircet updated this revision to Diff 225027. kadircet marked an inline comment as done. kadircet added a comment. - Move context swapping next to server creation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/

[clang-tools-extra] r374892 - [clangd] Propagate main context into ClangdServer

Author: kadircet Date: Tue Oct 15 07:20:52 2019 New Revision: 374892 URL: http://llvm.org/viewvc/llvm-project?rev=374892=rev Log: [clangd] Propagate main context into ClangdServer Summary: Currently clangd initializes the ClangdServer lazily during onInitialize request, and it results in

r374893 - [AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST

Author: d0k Date: Tue Oct 15 07:23:05 2019 New Revision: 374893 URL: http://llvm.org/viewvc/llvm-project?rev=374893=rev Log: [AST] Remove unused Sema includes to fix a cyclic dependency from Sema to AST Modified: cfe/trunk/lib/AST/ExprCXX.cpp Modified: cfe/trunk/lib/AST/ExprCXX.cpp URL:

r374895 - Reapply: [Modules][PCH] Hash input files content

Author: bruno Date: Tue Oct 15 07:23:55 2019 New Revision: 374895 URL: http://llvm.org/viewvc/llvm-project?rev=374895=rev Log: Reapply: [Modules][PCH] Hash input files content Summary: When files often get touched during builds, the mtime based validation leads to different problems in implicit

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

This revision was automatically updated to reflect the committed changes. Closed by commit rG9d66247e9b78: [clangd] Propagate main context into ClangdServer (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68978/new/

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added a comment. One query, but this patch is starting to look good. I'm not a libunwind expert - it would be good to have one of the libunwind contributors look over this patch yet. Can you add one as a reviewer? Comment at: libunwind/src/Registers.hpp:3677 + case

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225034. hokein marked 4 inline comments as done. hokein added a comment. Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-39 See http://jenkins.llvm-merge-guard.org/job/Phabricator/39/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68981: [clangd] Use our own relation kind.

hokein added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.h:72 // A map from (subject, predicate) pair to objects. - llvm::DenseMap, std::vector> + llvm::DenseMap, std::vector> Relations; kadircet wrote: > can we rather use

r374943 - [OPENMP]Fix comments/params, NFC.

Author: abataev Date: Tue Oct 15 12:51:30 2019 New Revision: 374943 URL: http://llvm.org/viewvc/llvm-project?rev=374943=rev Log: [OPENMP]Fix comments/params, NFC. Modified: cfe/trunk/include/clang/AST/OpenMPClause.h Modified: cfe/trunk/include/clang/AST/OpenMPClause.h URL:

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

akhuang updated this revision to Diff 225104. akhuang marked an inline comment as done. akhuang added a comment. Address comment about bad decrementing iterator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

probinson added a comment. Apologies for missing this until now. Our email system keeps dropping stuff sent by Phabricator. FTR, since @rnk has mentioned my years-ago writings, what Sony has internally nowadays is a little different than what I said back then. We have an option spelled

r374952 - Remove unnecessary and inappropriate forward-declaration of Sema from

Author: rsmith Date: Tue Oct 15 14:50:24 2019 New Revision: 374952 URL: http://llvm.org/viewvc/llvm-project?rev=374952=rev Log: Remove unnecessary and inappropriate forward-declaration of Sema from AST. Modified: cfe/trunk/include/clang/AST/ExprCXX.h Modified:

[PATCH] D68806: Relro is missing from the original "#pragma clang section" implementation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf14642f2f185: Added support for #pragma clang section relro=name (authored by dmikulin). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

r374936 - Fix as-w-option.c on Windows where no assembler exists

Author: rnk Date: Tue Oct 15 11:39:41 2019 New Revision: 374936 URL: http://llvm.org/viewvc/llvm-project?rev=374936=rev Log: Fix as-w-option.c on Windows where no assembler exists Modified: cfe/trunk/test/Driver/as-w-option.c Modified: cfe/trunk/test/Driver/as-w-option.c URL:

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. Thank you guys the responses. I cannot agree more. The sole reason why this option exists is that if you scroll back in the git blame of that line, you would find a commit, which removed this warning for this exact scenario. Possibly due to some seemingly false

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar requested changes to this revision. mitchell-stellar added inline comments. This revision now requires changes to proceed. Comment at: clang/include/clang/Format/Format.h:1955 + /// \endcode + bool SpacesInConditionalStatement; + Nitpick: this

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

aprantl requested changes to this revision. aprantl added a comment. This revision now requires changes to proceed. Ah sorry. While preparing this for commit I realized that the CGDebugInfo change is untested. Can you add a Clang test that checks that CFE is emitting the expected LLVM IR?

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:4127 + + case Expr::ConceptSpecializationExprClass: { +// ::= L E # external name These mangling changes look like they could be separated out from the rest of the patch. These plus the

r374954 - PR43674: fix incorrect constant evaluation of 'switch' where no case

Author: rsmith Date: Tue Oct 15 15:23:11 2019 New Revision: 374954 URL: http://llvm.org/viewvc/llvm-project?rev=374954=rev Log: PR43674: fix incorrect constant evaluation of 'switch' where no case label corresponds to the condition. Modified: cfe/trunk/lib/AST/ExprConstant.cpp

r374899 - Revert 374882 "[Concepts] Concept Specialization Expressions"

Author: nico Date: Tue Oct 15 07:46:39 2019 New Revision: 374899 URL: http://llvm.org/viewvc/llvm-project?rev=374899=rev Log: Revert 374882 "[Concepts] Concept Specialization Expressions" This reverts commit ec87b003823d63f3342cf648f55a134c1522e612. The test fails on Windows, see e.g.

r374907 - [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp

Author: saar.raz Date: Tue Oct 15 08:49:29 2019 New Revision: 374907 URL: http://llvm.org/viewvc/llvm-project?rev=374907=rev Log: [Concepts] Remove unused and illegal Sema includes from ExprCXX.cpp Fixing accidental includes introduced in 374903 Modified: cfe/trunk/lib/AST/ExprCXX.cpp

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

probinson added a comment. In D68117#1709557 , @SouraVX wrote: > Hi David, > I did some digging about DW_AT_defaulted and stuff, not much of a success > but. Here's what I found -- http://dwarfstd.org/Issues.php?type=closed4 -- > here it;s still

r374934 - Added support for "#pragma clang section relro="

Author: dmikulin Date: Tue Oct 15 11:31:10 2019 New Revision: 374934 URL: http://llvm.org/viewvc/llvm-project?rev=374934=rev Log: Added support for "#pragma clang section relro=" Differential Revision: https://reviews.llvm.org/D68806 Modified: cfe/trunk/docs/LanguageExtensions.rst

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. > Is it worth trying to disallow tail call optimization completely if this flag > is enabled? I'm not sure what GCC does exactly. but this seems to be the > behaviour. I had reported above that I have already run that test: with "-fno-optimize-sibling-calls

r374938 - [Concept] Associated Constraints Infrastructure

Author: saar.raz Date: Tue Oct 15 11:44:06 2019 New Revision: 374938 URL: http://llvm.org/viewvc/llvm-project?rev=374938=rev Log: [Concept] Associated Constraints Infrastructure Add code to correctly calculate the associated constraints of a template (no enforcement yet). D41284 on Phabricator.

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:93 +// TODO: Is there a way to get the location without lexer gymnastics? +auto Colon = findPreviousTokenKind(R.getBegin(), SM, LangOpts,

r374942 - [OPENMP]Allow final clause in combined task-based directives.

Author: abataev Date: Tue Oct 15 12:37:05 2019 New Revision: 374942 URL: http://llvm.org/viewvc/llvm-project?rev=374942=rev Log: [OPENMP]Allow final clause in combined task-based directives. The condition of the final clause must be captured in the combined task-based directives, like 'parallel

[PATCH] D68694: [clang-tidy] hicpp-signed-bitwise: Do not show "use of a signed integer operand with a binary bitwise operator" for positive integer operands

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. But i was inactive for a long time, if @aaron.ballman accepts as well you can commit instantly. Otherwise please let the other people that commented some time to react. :)

[clang-tools-extra] r374901 - [clangd][NFC] Update comments to use triple-slashes

Author: kadircet Date: Tue Oct 15 07:59:08 2019 New Revision: 374901 URL: http://llvm.org/viewvc/llvm-project?rev=374901=rev Log: [clangd][NFC] Update comments to use triple-slashes Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.h Modified:

r374909 - CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization.

Author: dmikulin Date: Tue Oct 15 09:32:50 2019 New Revision: 374909 URL: http://llvm.org/viewvc/llvm-project?rev=374909=rev Log: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization. Differential Revision: https://reviews.llvm.org/D67985 Added:

[PATCH] D68997 [Modules] Allow searching for prebuilt implicit modules

Hello, This is a proposal to allow searching for "implicit modules" in the prebuilt module cache paths. https://reviews.llvm.org/D68997 The current command-line options for prebuilt modules do not allow to easily maintain and use multiple versions of modules.

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick created this revision. nick added a reviewer: alexfh. nick added a project: clang-tools-extra. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, mgorny. Herald added a project: clang. Finds deprecated in C++17 inheritance from `std::iterator` and replaces it with type

r374926 - Reland [Driver] Fix -working-directory issues

Author: jkorous Date: Tue Oct 15 10:51:59 2019 New Revision: 374926 URL: http://llvm.org/viewvc/llvm-project?rev=374926=rev Log: Reland [Driver] Fix -working-directory issues Don't change the default VFS in Driver, update tests & reland. This reverts commit

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

aaron.ballman added a comment. In D55125#1704397 , @dkrupp wrote: > @aaron.ballman could you please commit? > I don't have commit access. Thx. I'm happy to do so, but the patch does not apply cleanly to trunk. Can you rebase? (Sorry for the delayed

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-40 See http://jenkins.llvm-merge-guard.org/job/Phabricator/40/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374903 - [Concepts] Concept Specialization Expressions

Author: saar.raz Date: Tue Oct 15 08:24:26 2019 New Revision: 374903 URL: http://llvm.org/viewvc/llvm-project?rev=374903=rev Log: [Concepts] Concept Specialization Expressions Part of C++20 Concepts implementation effort. Added Concept Specialization Expressions that are created when a concept

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao added a comment. In D68818#1709688 , @tra wrote: > @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules > & ABI scare me. :-) @tra thanks for promoting the review. This patch is quite critical to support extended lambda

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1709316 , @sylvestre.ledru wrote: > @MyDeveloperDay I think it should be added to the release notes. it is a > great new changes for clang format (it would have made my life at Mozilla > much easier ;) I

r374932 - [clang] refactor -Wa,-W test cases.

Author: jcai19 Date: Tue Oct 15 11:17:08 2019 New Revision: 374932 URL: http://llvm.org/viewvc/llvm-project?rev=374932=rev Log: [clang] refactor -Wa,-W test cases. Remove REQUIRES and only keep the clang driver tests, since the assembler are already tested with -Wa,--no-warn. This way we could

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-41 See http://jenkins.llvm-merge-guard.org/job/Phabricator/41/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68997: Allow searching for prebuilt implicit modules.

arames created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. arames edited the summary of this revision. arames added reviewers: bruno, rsmith. Herald added a subscriber: dexonsmith. The behavior is controlled by the `-fprebuilt-implicit-modules` option,

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen marked 2 inline comments as done. khchen added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1521 + {"rv32i", "ilp32"},{"rv32im", "ilp32"}, {"rv32iac", "ilp32"}, + {"rv32imac", "ilp32"}, {"rv32imafc", "ilp32f"}, {"rv64i", "lp64"}, +

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 225068. khchen edited the summary of this revision. khchen added a comment. @lenary Sorry, I don't have the plan to support `MULTILIB_REUSE` now. But if it's necessary to support it, I can do it later. CHANGES SINCE LAST ACTION

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. LGTM with updated testcase, thanks! Comment at: llvm/test/DebugInfo/X86/noreturn_cpp11.ll:59 -attributes #0 = { noreturn } +attributes #0 = { noinline noreturn optnone

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-42 See http://jenkins.llvm-merge-guard.org/job/Phabricator/42/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay added a comment. In D68969#1709321 , @klimek wrote: > My intuitive solution would have been to get the char* for the start and > end-location and then search forward and backwards for \n. I may need to, it feels slow for large files

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

This revision was automatically updated to reflect the committed changes. Closed by commit rG034badb312be: CFI: wrong type passed to llvm.type.test with multiple inheritance… (authored by dmikulin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. In D68117#1708115 , @dblaikie wrote: > In D68117#1708114 , @SouraVX wrote: > > > In D68117#1707680 , @dblaikie > > wrote: > > > > > In

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225037. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files:

[PATCH] D68978: [clangd] Propagate main context into ClangdServer

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:135 + // Since initialization of CDBs and ClangdServer is done lazily, the following + // context captures the one used while creating ClangdLSPServer and passes it

[PATCH] D68981: [clangd] Use our own relation kind.

merge_guards_bot added a comment. Bulid results are available at http://results.llvm-merge-guard.org/Phabricator-43 See http://jenkins.llvm-merge-guard.org/job/Phabricator/43/ for more details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225052. SouraVX added a comment. Thanks Adrian for review! Addressing your review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked 2 inline comments as done. SouraVX added inline comments. Comment at: llvm/test/DebugInfo/X86/noreturn_cpp11.ll:59 -attributes #0 = { noreturn } +attributes #0 = { noinline noreturn optnone uwtable "correctly-rounded-divide-sqrt-fp-math"="false"

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX marked an inline comment as done. SouraVX added a comment. In D68697#1709680 , @SouraVX wrote: > Thanks Adrian for review! > Addressing your review comments. Could you please commit these changes for me, Thanks! CHANGES SINCE LAST ACTION

[PATCH] D67763: [Clang FE] Recognize -mnop-mcount CL option

jonpa added a reviewer: bkramer. jonpa added a comment. @Benjamin: I see that you removed the option that I am now putting back, so perhaps you could take a look and see if this patch looks ok? Thanks. /Jonas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67763/new/

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225049. serge-sans-paille added a comment. Get rid of static mapping + update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 Files:

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary added a comment. In D68391#1694622 , @edward-jones wrote: > Rebased and added tests > > I've made this use the Triple from the driver rather than the parsed LLVM > triple, this means the Triple doesn't get normalized which seems like more >

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

tra added a comment. @rsmith Richard, could you take a look, please? Lambdas, mangling, ODR rules & ABI scare me. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818

r374929 - Fix Driver/working-directory.c test

Author: jkorous Date: Tue Oct 15 11:04:18 2019 New Revision: 374929 URL: http://llvm.org/viewvc/llvm-project?rev=374929=rev Log: Fix Driver/working-directory.c test Accidentally committed debug print. Modified: cfe/trunk/test/Driver/working-directory.c Modified:

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/MemIndex.cpp:95 LookupRequest LookupReq; -auto It = Relations.find(std::make_pair(Subject, Req.Predicate)); +auto It = Relations.find(std::make_pair(Subject, (uint8_t)Req.Predicate)); if

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225039. hokein added a comment. fix a missing static_cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D68981: [clangd] Use our own relation kind.

hokein updated this revision to Diff 225041. hokein added a comment. more static_cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981 Files: clang-tools-extra/clangd/XRefs.cpp

[PATCH] D68981: [clangd] Use our own relation kind.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/ https://reviews.llvm.org/D68981

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham added a comment. Thanks for the review! (I expect to leave this uncommitted until I have enough other patches approved to make it actually useful, and then commit them all together.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r374971 - Fix failing mangle-concept.cpp test.

Author: saar.raz Date: Tue Oct 15 19:56:40 2019 New Revision: 374971 URL: http://llvm.org/viewvc/llvm-project?rev=374971=rev Log: Fix failing mangle-concept.cpp test. Modified: cfe/trunk/test/CodeGenCXX/mangle-concept.cpp Modified: cfe/trunk/test/CodeGenCXX/mangle-concept.cpp URL:

[PATCH] D68697: [DWARF5] Added support for DW_AT_noreturn attribute to be emitted for C++ class member functions.

SouraVX updated this revision to Diff 225159. SouraVX added a comment. Added test case in CFE for checking expected LLVM IR emission. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68697/new/ https://reviews.llvm.org/D68697 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

NoQ added a comment. I think it's worth it to commit the patch as-is, because the crash seems to be fairly popular. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68591/new/ https://reviews.llvm.org/D68591

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 225149. aaronpuchert added a comment. Apply clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68845/new/ https://reviews.llvm.org/D68845 Files: clang/lib/Sema/SemaCoroutine.cpp

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert marked 15 inline comments as done. aaronpuchert added a comment. Given the complexities of this implementation, I'm beginning to doubt whether implicit moves make sense for `co_return` at all. Since there can never be any kind of RVO, why not always require an explicit `std::move`?

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I was not sure why this is not opaque in case of LLDB usage, but now it is perfect, thanks! Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:3079 +

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick updated this revision to Diff 225133. nick added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69000/new/ https://reviews.llvm.org/D69000 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt

LLVM buildmaster will be updated tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 7PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68876: [libTooling] Put all Transformer declarations in a single namespace.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bb47cd8c30c: [libTooling] Put all Transformer declarations in a single namespace. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

vsapsai created this revision. vsapsai added reviewers: bruno, sammccall. Herald added subscribers: ributzka, arphaman, dexonsmith, jkorous. vsapsai added a comment. The plan is to instrument `llvm::sys::fs::status` with `ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk updated this revision to Diff 225153. kousikk added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69017/new/ https://reviews.llvm.org/D69017 Files: clang/lib/Tooling/DependencyScanning/DependencyScanningWorker.cpp

[PATCH] D69017: Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk created this revision. kousikk added reviewers: arphaman, dexonsmith, Bigcheese, jkorous. Herald added a project: clang. Herald added a subscriber: cfe-commits. kousikk updated this revision to Diff 225153. kousikk added a comment. Lint fixes Clang's -M mode includes these extra

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

dblaikie added a comment. In D68117#1709712 , @probinson wrote: > In D68117#1709557 , @SouraVX wrote: > > > Their's not much information available behind the suggestion or intention > > for adding this feature to

[PATCH] D68845: Don't emit unwanted constructor calls in co_return statements

aaronpuchert updated this revision to Diff 225147. aaronpuchert added a comment. Add tests suggested by @Quuxplusone and add fallback to call by lvalue reference. The latter turned out more complicated than I thought, because there seems to be no easy way to just try building a call expression

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. I need this for the demo at the dev

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. I did a quick search of the LLVM code base and found dozens of `const StringRef &`, including the `Twine` API . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

vsapsai added a comment. The plan is to instrument `llvm::sys::fs::status` with `ALWAYS_ENABLED_STATITSTIC` to be able to catch regressions causing lots of `stat` calls. That's why replacing current `stat` calls. And it seems to be a good change regardless of future plans. CHANGES SINCE LAST

[PATCH] D69012: [Headers] Fix compatibility between arm_acle.h and intrin.h

efriedma created this revision. efriedma added reviewers: rnk, chill. Herald added a subscriber: kristof.beyls. Herald added a project: clang. Make sure they don't both define __nop. We use a similar pattern for other functions in arm_acle.h. Repository: rC Clang

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

efriedma added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68838/new/ https://reviews.llvm.org/D68838 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

nick marked 2 inline comments as done. nick added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/DeprecatedIteratorBaseCheck.cpp:218 + // Requires C++. + if (!getLangOpts().CPlusPlus) +return; Eugene.Zelenko wrote: > Should it check

r374962 - [libTooling] Put all Transformer declarations in a single namespace.

Author: ymandel Date: Tue Oct 15 18:06:46 2019 New Revision: 374962 URL: http://llvm.org/viewvc/llvm-project?rev=374962=rev Log: [libTooling] Put all Transformer declarations in a single namespace. Summary: This revision introduces a new namespace, `clang::transformer`, to hold the declarations

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne marked 2 inline comments as done. mhorne added inline comments. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers_riscv::getFloatRegister(int regNum) const { +#ifdef __riscv_float_abi_double + assert(validFloatRegister(regNum));

r374967 - [Concepts] ConceptSpecializationExprs mangling

Author: saar.raz Date: Tue Oct 15 19:33:41 2019 New Revision: 374967 URL: http://llvm.org/viewvc/llvm-project?rev=374967=rev Log: [Concepts] ConceptSpecializationExprs mangling Implement mangling for CSEs to match regular template-ids. Reviewed as part of D41569. Added:

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks It fixed my problem. Maybe you could improve the doc and/or comment to make this behavior more explicit? CHANGES SINCE LAST ACTION

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added a comment. Here are some `const StringRef &` examples . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68914/new/ https://reviews.llvm.org/D68914

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

steakhal added a comment. I think this patch is ok. Although there are remarks: - I think the current implementation of the taint filtering functions does not follow the expected semantics. Now the modelling would remove taint before calling the function (//pre statement//). One might expect

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

klimek added a comment. In D68914#1709002 , @owenpan wrote: > Here are some `const StringRef &` examples > . StringRef already is a const

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

Tyker added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

sylvestre.ledru added a comment. @ostannard Maybe you could add that to the release notes? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

owenpan added inline comments. Comment at: clang/include/clang/Basic/SourceManager.h:232 +// nullptr +static const char *getInvalidBOM(StringRef BufStr); }; klimek wrote: > owenpan wrote: > > Can you make the parameter `const`? > StringRef is

  1   2   >