[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

thakis added a comment. The mangling test fails on Windows: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/15944 It also fails on ppc64le: http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/21092 Please watch http://lab.llvm.org:8011/console for a bit after landing

[PATCH] D68969: [clang-format] Remove the dependency on frontend

klimek added a comment. In D68969#1709696 , @MyDeveloperDay wrote: > In D68969#1709321 , @klimek wrote: > > > My intuitive solution would have been to get the char* for the start and > > end-location and then

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

SjoerdMeijer accepted this revision. SjoerdMeijer added a comment. This revision is now accepted and ready to land. Yep, thanks again! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68838/new/ https://reviews.llvm.org/D68838

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb62b45412168: [clangd] Add RemoveUsingNamespace tweak. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:139 + SourceLocation FirstUsingDirectiveLoc = + SM.getLocForEndOfFile(SM.getMainFileID()); + for (auto *D : AllDirectives) { ilya-biryukov

[clang-tools-extra] r374982 - [clangd] Add RemoveUsingNamespace tweak.

Author: usaxena95 Date: Wed Oct 16 02:53:59 2019 New Revision: 374982 URL: http://llvm.org/viewvc/llvm-project?rev=374982=rev Log: [clangd] Add RemoveUsingNamespace tweak. Summary: Removes the 'using namespace' under the cursor and qualifies all accesses in the current file. E.g.: using

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 225183. usaxena95 marked 11 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/ https://reviews.llvm.org/D68562 Files:

[PATCH] D69025: [Driver,ARM] Make -mfloat-abi=soft turn off MVE.

simon_tatham created this revision. simon_tatham added a reviewer: dmgreen. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Since `-mfloat-abi=soft` is taken to mean turning off all uses of the FP registers, it should turn off the MVE vector instructions as

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

ilya-biryukov added a comment. An alternative approach I'm thinking of: After D68977 lands, we could try using `findExplicitReferences` to produce all of these edits: 1. we collect locations of all references and declaration of relevant parameters and template

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added a comment. Mostly LG, but please take a look at the NITs and the implementation-related comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { This

[PATCH] D69011: Replace platform-dependent `stat` with `llvm::sys::fs::status`. NFC intended.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Watching for regressions in stat calls sounds really useful. This change is trivially equivalent on linux, but the code path is quite different on windows (I have no idea how ::stat

Re: [PATCH] D53137: Scalable vector core instruction support + size queries

Hi Graham, It seems you forgot to push the last round of fixes. Just saying :) Cheers, Diana On Tue, 8 Oct 2019 at 16:01, Graham Hunter via Phabricator wrote: > > huntergr added a comment. > > Hmm, forgot to add the last round of minor fixes before committing. Sorry > about that, will push

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser created this revision. junparser added reviewers: modocache, GorNishanov. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. The assertion of CoroutineParameterMoves happens when build coroutine function with arguments multiple time while fails to build

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

Charusso added a comment. > i'd much rather enable graph dumping in noassert builds. Totally! When I am not an advanced developer I definitely would like to print the graph with the release pre-built binaries to measure my stuff when I analyze. Like after someone watch your tutorial and starts

<    1   2