[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:79 + Token CurToken; + while (!CurToken.is(tok::semi)) { +if (RawLexer.LexFromRawLexer(CurToken)) kadircet wrote: > ilya-biryukov wrote: > > What are

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

balazske updated this revision to Diff 226206. balazske added a comment. - Improved check for C++17. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67545/new/ https://reviews.llvm.org/D67545 Files:

[clang-tools-extra] 13fc899 - [clangd] Handle the missing constructor initializers in findExplicitReferences.

Author: Haojian Wu Date: 2019-10-24T10:38:37+02:00 New Revision: 13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 URL: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903 DIFF: https://github.com/llvm/llvm-project/commit/13fc899cdecc85c944fc5b516a2bdfdd2f5f5903.diff

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Sorry for the confusion @steven_wu. By `stable` I mean the probability that the `-fthin-link-bitcode` option is replaced with some other thinlink mechanism under the distributed build environment. Since at least for ccache, the compilation output caching depends on the

[clang-tools-extra] bf71e4f - [clangd] Collect name references in the index.

Author: Haojian Wu Date: 2019-10-24T10:25:16+02:00 New Revision: bf71e4fe0a68085d29e9e883da1f17ae73945643 URL: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643 DIFF: https://github.com/llvm/llvm-project/commit/bf71e4fe0a68085d29e9e883da1f17ae73945643.diff

[PATCH] D69241: [clangd] Handle the missing constructor initializers in findExplicitReferences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG13fc899cdecc: [clangd] Handle the missing constructor initializers in findExplicitReferences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:208 + + if (HadErrors) { +return llvm::createStringError( kadircet wrote: > ilya-biryukov wrote: > >

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:77 +Source = getSelectedFunction(Sel.ASTSelection.commonAncestor()); +if (!Source || !Source->isThisDeclarationADefinition()) + return false; I

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. A few last NITs and one important comment about handling the case when function definition come from macro expansions Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:323 + +

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:79 + Token CurToken; + while (!CurToken.is(tok::semi)) { +if (RawLexer.LexFromRawLexer(CurToken)) ilya-biryukov wrote: > What are the tokens we expect to

[PATCH] D69338: [clangd] Collect name references in the index.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbf71e4fe0a68: [clangd] Collect name references in the index. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69338/new/

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:119 +llvm::Optional +renameableOutsideFile(const NamedDecl , const SymbolIndex *Index) { hokein wrote: > ilya-biryukov wrote: > > So `llvm::None` means we do not

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 226209. kadircet marked 20 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files:

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

furdyna added a comment. Hi, @krasimir @sylvestre.ledru , would you be able to help me with this patch? I am looking for anyone interested in reviewing this :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67750/new/ https://reviews.llvm.org/D67750

[PATCH] D69266: [clangd] Define out-of-line availability checks

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1556 + +[[void [[Bar::[[b^a^z() [[{ + return; Sorry for not spotting it earlier. Moving out-of-line methods is different than general functions, `void

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. In D69327#1719419 , @steven_wu wrote: > In D69327#1719411 , @ychen wrote: > > > Thanks for the inputs @steven_wu @tejohnson. Totally agree with the points > > you brought up. One last thing

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226218. Typz marked 2 inline comments as done. Typz added a comment. Fix corner in previous rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files:

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b63ca1379a8: [Mips] Use appropriate private label prefix based on Mips ABI (authored by mbrkusanin). Changed prior to commit: https://reviews.llvm.org/D66795?vs=224603=226112#toc Repository: rG

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm marked 2 inline comments as done. peterwaller-arm added inline comments. Comment at: clang/test/Driver/flang/flang-not-installed.f90:11 +! shell syntax. +! UNSUPPORTED: windows + hfinkel wrote: > I believe that you can write: > > REQUIRES:

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:463 + // Check all-scopes completions too. + Opts.AllScopes = true; + Results = completions(R"cpp( I believe `AllScopes` and this feature is orthogonal what

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song created this revision. yonghong-song added reviewers: arsenm, aprantl, Anastasia, ast. yonghong-song added a project: debug-info. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. The RFC intends to kick off the discussion on how to support user defined

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1901 + +Instrument stack allocation to prevent stack clash attacks. + Maybe add that it is Linux only? :) CHANGES SINCE LAST ACTION

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Looks good to me. (Stores are easier than loads) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69378/new/ https://reviews.llvm.org/D69378

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

This revision was automatically updated to reflect the committed changes. Closed by commit rG7c11da0cfd33: [clang] New __attribute__((__clang_arm_mve_alias)). (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

sedykh.eugene created this revision. sedykh.eugene added reviewers: MyDeveloperDay, JonasToth. sedykh.eugene added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre, xazax.hun. Herald added a project: clang. Current implementation suggests to add [[nodiscard]] to methods

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri created this revision. YashasAndaluri added reviewers: hfinkel, Meinersbur, rscottmanley, DTharun. YashasAndaluri created this object with edit policy "Administrators". YashasAndaluri added a project: clang. Herald added subscribers: cfe-commits, zzheng. YashasAndaluri edited the

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || `llvm::StringSwitch` has a method `StartsWithLower` which might help make

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || rogfer01 wrote: >

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: fail - 59611 tests passed, 1 failed and 763 were skipped. failed: libc++.libcxx/thread/thread_threads/thread_thread_this/sleep_for.pass.cpp Log files: cmake-log.txt ,

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: fail - 59587 tests passed, 1 failed and 805 were skipped. failed: LLVM.tools/llvm-ar/mri-utf8.test Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

steven_wu added a comment. `ccache` does not have the support for this, I am just saying that this can be easily implemented in `ccache` and that would be much better than the proposed solution here. If we need to add a clang driver flag so build system can better support to detect thin

[PATCH] D69389: [hip] Relax an allow the declaration of functions with variadic arguments in HIP.

hliao created this revision. hliao added reviewers: jlebar, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - As variadic parameters have the lowest rank in overload resolution, without real usage of `va_arg`, they are commonly used as the catch-all fallbacks

[PATCH] D68340: Add AIX toolchain and basic linker functionality

jasonliu accepted this revision. jasonliu added a comment. This revision is now accepted and ready to land. Aside from the nit comment that can be addressed when checkin. LGTM. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [, ] { +//

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 226270. peterwaller-arm added a comment. I have rebased the patch for conflicts to master and all the tests are passing. While doing so, I discovered that the test for flang-not-installed was not fit for purpose, because clang actually doesn't first

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 226230. kadircet marked 15 inline comments as done. kadircet added a comment. - Improve macro handling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files:

[PATCH] D69378: [AArch64][SVE] Implement masked store intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, greened, dmgreen, rovka. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds support for codegen of masked stores, with non-truncating and truncating variants.

[PATCH] D67159: [clang] New __attribute__((__clang_arm_mve_alias)).

simon_tatham updated this revision to Diff 226238. simon_tatham added a comment. (Rebased to current master; no change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67159/new/ https://reviews.llvm.org/D67159 Files:

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 226252. lenary added a comment. - Correct code formatting issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/lib/Driver/ToolChains/Arch/RISCV.cpp

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226253. ilya-biryukov added a comment. - Fix name of a constructor parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/ https://reviews.llvm.org/D69382 Files:

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary created this revision. lenary added reviewers: asb, luismarques, rogfer01, kito-cheng, khchen. Herald added subscribers: cfe-commits, pzheng, s.egerton, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, edward-jones, zzheng, MaskRay, jrtc27, shiva0217, niosHD,

[clang] 1ae8e8d - Don't add -fsplit-lto-unit for thin LTO builds with PS4 and Darwin toolchains

Author: evgeny Date: 2019-10-24T14:10:03+03:00 New Revision: 1ae8e8d25fd87048d3d8d7429308e52b236c79a1 URL: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1 DIFF: https://github.com/llvm/llvm-project/commit/1ae8e8d25fd87048d3d8d7429308e52b236c79a1.diff LOG:

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 ___ cfe-commits mailing list

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else lenary wrote: > khchen wrote: > > lenary wrote: > > > I think this line is the issue: where someone doesn't specify `-march`, >

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226246. Typz added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Would be nice to also fix this in clang, but that looks like more work if we want to preserve signatures in informative

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:5739 + " ? ccc\n" + " : ddd;"); verifyFormat("bool aa = a //\n" MyDeveloperDay

[PATCH] D67750: Allow additional file suffixes/extensions considered as source in main include grouping

MyDeveloperDay requested changes to this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. This revision now requires changes to proceed. I think fundamentally this seems like a reasonable idea, for those that don't need they don't need to use it.

[clang-tools-extra] ed913a2 - [clangd] Fix case of variables and functions in code complete tests. NFC

Author: Ilya Biryukov Date: 2019-10-24T15:41:50+02:00 New Revision: ed913a291532968c188909e932a94c5cc7b416be URL: https://github.com/llvm/llvm-project/commit/ed913a291532968c188909e932a94c5cc7b416be DIFF: https://github.com/llvm/llvm-project/commit/ed913a291532968c188909e932a94c5cc7b416be.diff

[PATCH] D69173: [clang][ThinLTO][Legacy] Don't add -fsplit-lto-unit for legacy thin LTO builds

This revision was automatically updated to reflect the committed changes. Closed by commit rG1ae8e8d25fd8: Dont add -fsplit-lto-unit for thin LTO builds with PS4 and Darwin toolchains (authored by evgeny777). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Ok, found a path forward for this patch. Notes inline: Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1547 + else if (IsRV64) +MArch = "rv64i"; + else khchen wrote: > lenary wrote: > > I think this line is the issue: where

[PATCH] D69373: [Clang] Fix Sema class build fix

devnexen created this revision. devnexen added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. - DefaultedComparisonKind not being a classic enum, setting as a so small bitfield triggers gcc warning. Repository: rC Clang

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz updated this revision to Diff 226245. Typz added a comment. Fix earlier error in patch upload. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50078/new/ https://reviews.llvm.org/D50078 Files: clang/lib/Format/ContinuationIndenter.cpp

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

tejohnson added a comment. We rely on the minimized bitcode from that option in our builds, so it won't be going away. We could add it as a driver option, but it doesn't sound like that will solve the ccache issue. I'm not very familiar with that cache support, or if there is a way to express

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thank you @steven_wu @tejohnson. I created D69406 to promote the flag to the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69327/new/ https://reviews.llvm.org/D69327

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added a comment. In D68340#1720362 , @Yi-Hong.Lyu wrote: > Seems this commit broke the buildbot > http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 @daltenty's patch rG201ed14aea8c

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen created this revision. ychen added reviewers: tejohnson, steven_wu. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. Herald added a project: clang. A necessary step to let build system caching work for its output. I renamed it to match existing driver options for

[clang] ffa214e - [Concepts] Constraint Enforcement & Diagnostics

Author: Saar Raz Date: 2019-10-25T00:19:51+03:00 New Revision: ffa214ef22892d75340dc6720271863901dc2c90 URL: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90 DIFF: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90.diff

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

dblaikie added a comment. In D67723#1720509 , @aprantl wrote: > In D67723#1720353 , @rnk wrote: > > > In D67723#1717468 , @aprantl wrote: > > > > > I agree that it would

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. In D67508#1720228 , @khchen wrote: > But there is some issue if we set the default rv32 march as `rv32gc`. > Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu > toolchain, >

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

tejohnson added a comment. Thanks. Prefer the old name since it is already in use and since this is for the "thin link" phase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

[clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

Author: Jinsong Ji Date: 2019-10-24T22:49:17Z New Revision: 9671d1dc1764701824913ecca2b76ab17c33c29e URL: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e DIFF: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e.diff LOG:

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

khchen added inline comments. Herald added a subscriber: sameer.abuasal. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else Why do you set rv32gc and rv64gc as default march?

[clang] 7b3de1e - [ARM] Attempt to fixup MveEmitter warnings

Author: David Green Date: 2019-10-24T19:43:15+01:00 New Revision: 7b3de1e811972b874d91554642ccb2ef5b32eed6 URL: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6 DIFF: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6.diff

[clang] 78700ef - [ARM] Fixup MVE intrinsic tests with no assert builds

Author: David Green Date: 2019-10-24T19:59:15+01:00 New Revision: 78700ef8866db7f5cea113fa81d810a28b5b7438 URL: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438 DIFF: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438.diff

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

klimek added a comment. > since resource directory should be picked relative > to the path of the clang-compiler in the compilation command. The resource dir should be the resource dir that shipped with the clang source code that the *tool* was built with. We can think about the resource dir

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. In D67787#1719251 , @vit9696 wrote: > A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I > discovered that this patch was not committed anyhow at all: > https://reviews.llvm.org/D54583#1444288 Yeah,

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa5e98fd191: [clang-format] Remove duplciate code from Invalid BOM detection (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764 + QualType Ty) const { + llvm_unreachable("AMDGPU does not support varargs"); +} tra wrote: >

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

> On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator > wrote: > > dblaikie added a comment. > > In D67723#1720509 , @aprantl wrote: > >> In D67723#1720353 , @rnk wrote: >> >>> In D67723#1717468

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen updated this revision to Diff 226347. ychen added a comment. Address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406 Files: clang/include/clang/Driver/CC1Options.td

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. One other thought: Does the implementation in this diff care what type the reference type pointers are pointing to? It would be nice if we could enforce the use of an opaque pointee type to prevent the reference types from being dereferenced. Repository: rG LLVM

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. It would be great to see some test .ll files here so we can get a better understanding for what is implemented here. I would also like to see tests of what happens if you try to do a `ptrtoint` or some other illegal operation on a reference type.

[clang] 201ed14 - Follow on to Namespace fixup for D68340

Author: David Tenty Date: 2019-10-24T17:01:17-04:00 New Revision: 201ed14aea8cd03e776dbe8484fa7de3ac94a3cf URL: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf DIFF: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf.diff

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz closed this revision. saar.raz added a comment. Committed ffa214ef22892d75340dc6720271863901dc2c90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/

[clang] 70f59b5 - When diagnosing an ambiguity, only note the candidates that contribute

Author: Richard Smith Date: 2019-10-24T14:58:29-07:00 New Revision: 70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 URL: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 DIFF: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479.diff

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. Please don't ping for review after a single day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D68835?vs=225311=226352#toc Repository: rG LLVM Github

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. phosek updated this revision to Diff 226355. leonardchan accepted this revision. This revision is now accepted and ready to land. This

[clang] 7fff716 - [CMake] Update Fuchsia build configuration

Author: Petr Hosek Date: 2019-10-24T16:35:29-07:00 New Revision: 7fff716ec4741f84358a977ddf0cd5ccf448d5c5 URL: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5 DIFF: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5.diff

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 

stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra/clang-tidy/add_new_check.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. stephanemoore added a reviewer: aaron.ballman. stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of

[PATCH] D69415: [CMake] Update Fuchsia build configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fff716ec474: [CMake] Update Fuchsia build configuration (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek updated this revision to Diff 226355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm.org/D69415 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Perhaps we should rename `-fcuda-allow-variadic-functions` to `-fgpu-allow-variadic-functions` after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

probinson added a comment. > These experiments are convincing me that, in general, line zero isn't that > helpful for DWARF consumers. If the goal is to get smooth stepping, we may > want to refocus on getting reliable is_stmt bits in the line table. If you mean, it's not useful for

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. In D67723#1720353 , @rnk wrote: > In D67723#1717468 , @aprantl wrote: > > > I agree that it would make sense to have a > > `-ginline-info-threshold=<#insns>` or

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. tldr: my LGTM still stands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

rjmccall resigned from this revision. rjmccall added a comment. Despite generally knowing about coroutines and generally knowing about Clang, I actually don't know the Clang coroutine code and can't review this properly. Repository: rC Clang CHANGES SINCE LAST ACTION

[clang] 9ab6d82 - [clang-scan-deps] Add basic support for modules.

Author: Michael Spencer Date: 2019-10-24T16:19:11-07:00 New Revision: 9ab6d8236b176bf9dd43741f4d874a8afebed99c URL: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c DIFF:

[clang] 6d424a1 - Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)""

Author: Jordan Rupprecht Date: 2019-10-24T16:35:45-07:00 New Revision: 6d424a161bf3e52730371da0b9439ed93a8ce406 URL: https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406 DIFF:

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

Yi-Hong.Lyu added a comment. Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67161/new/ https://reviews.llvm.org/D67161

[clang] 23b7836 - [clang-format] update documentation

Author: paulhoad Date: 2019-10-24T21:10:13+01:00 New Revision: 23b78364150cd946a8b111e87defdf179eecbc8f URL: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f DIFF: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f.diff

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao updated this revision to Diff 226301. hliao added a comment. revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69389/new/ https://reviews.llvm.org/D69389 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. @Bigcheese I don't have time right now to do the build experiments, so I'll leave it as follow-up for me to resolve later. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

MyDeveloperDay added a comment. Thank you for the patch, I wrote this checker originally and this LGTM. I'm not sure if others have any objections to using "using clang::attr::WarnUnusedResult" in the body of the function, I couldn't see this pattern used elsewhere in clang-tidy, all I've

[PATCH] D68969: [clang-format] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGec66603ac7ea: [clang-format] Remove the dependency on frontend (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else khchen wrote: > Why do you set rv32gc and rv64gc as

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226304. stevewan added a comment. Capture local variable IsArch32Bit by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a reviewer: klimek. Bigcheese added a comment. I've added Manuel as a reviewer as this patch is also changing the tooling APIs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122

  1   2   >