[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

merge_guards_bot added a comment. Build result: fail - 33521 tests passed, 1 failed and 463 were skipped. failed: LLVM.tools/llvm-objdump/X86/disassemble-functions.test Log files: console-log.txt ,

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added a comment. This is failing on Windows: http://45.33.8.238/win/1481/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/ https://reviews.llvm.org/D68937 ___ cfe-commits

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

thakis added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1388 // results in arbitrary failures as function body becomes NULL. ExtraArgs.push_back("-fno-delayed-template-parsing"); + for (const auto : Cases) You might

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. Thanks @kmclaughlin, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69657/new/ https://reviews.llvm.org/D69657

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 marked 3 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:179 + + if (ContainingNS) { +for (auto ReDeclNS : ContainingNS->redecls()) ilya-biryukov wrote: >

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

usaxena95 updated this revision to Diff 227267. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69162/new/ https://reviews.llvm.org/D69162 Files:

[clang] 2573798 - Build fix after 4b6597f

Author: Nico Weber Date: 2019-10-31T07:43:09-04:00 New Revision: 257379855af245abb6c0fc11331d3f45ab0656dd URL: https://github.com/llvm/llvm-project/commit/257379855af245abb6c0fc11331d3f45ab0656dd DIFF: https://github.com/llvm/llvm-project/commit/257379855af245abb6c0fc11331d3f45ab0656dd.diff

[PATCH] D67706: [clang][analyzer] Using CallDescription in StreamChecker.

This revision was automatically updated to reflect the committed changes. balazske marked 3 inline comments as done. Closed by commit rG4980c1333fa4: [clang][analyzer] Using CallDescription in StreamChecker. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69636: Make flang driver stuff work on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG4b6597f49896: Make flang driver stuff work on macOS (authored by thakis). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 4b6597f - Make flang driver stuff work on macOS

Author: Nico Weber Date: 2019-10-31T07:34:32-04:00 New Revision: 4b6597f49896529170fde38f5d5fb46d687e0c71 URL: https://github.com/llvm/llvm-project/commit/4b6597f49896529170fde38f5d5fb46d687e0c71 DIFF: https://github.com/llvm/llvm-project/commit/4b6597f49896529170fde38f5d5fb46d687e0c71.diff

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. In D69624#1728377 , @kadircet wrote: > As discussed offline, it might make more sense to fix this in `targetDecls` > itself. Considering how the `Alias` is handled for

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added a comment. Thanks Jorg! Given that the status is still "Needs Review", I assume I also still need an LGTM from Marshall, Louis or Eric, right? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520

[PATCH] D69162: [clangd] Remove using-namespace present inside a namespace.

ilya-biryukov added a comment. One important question about running on the whole TU in all cases. Other than that LG Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:110 return false; - if (!dyn_cast(TargetDirective->getDeclContext())) -

[PATCH] D33944: git-clang-format: Add --cached option to format index

MyDeveloperDay added a comment. Is this revision still relavant, I find it annoying that I have to run git add again on any files that are already added but have been formatted. If you think this is useful and can rebase it perhaps we can go around the review cycle again with a fresh set of

[PATCH] D69649: [clang-format] Fix SpacesInSquareBrackets for Lambdas with Initial "" Parameter

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for the patch, sorry I must have missed this coming in. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69649/new/

[PATCH] D14927: clang-format: Add SpaceBeforeTemplateParameterList option

MyDeveloperDay added inline comments. Comment at: include/clang/Format/Format.h:500 + /// bracket of a template parameter list. + bool SpaceBeforeTemplateParameterList; + I suggest we make this an enumeration ``` enum { Unaltered, Never, Always, } ```

[PATCH] D69657: [AArch64][SVE] Implement several floating-point arithmetic intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Adds intrinsics for the following: - fabd, fadd, fsub & fsubr - fmul, fmulx, fdiv & fdivr -

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity updated this revision to Diff 227254. whisperity added a comment. - Removed //`This check`// from the documentation comment of the check's class too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69560/new/ https://reviews.llvm.org/D69560 Files:

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity marked 11 inline comments as done. whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AdjacentArgumentsOfSameTypeCheck.cpp:488 +void AdjacentArgumentsOfSameTypeCheck::registerMatchers(MatchFinder *Finder) { + if

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

whisperity updated this revision to Diff 227253. whisperity added a comment. - Fix some comments, formatting and documentation - Organised test files to be in the same directory as others on the Monorepo structure - Helper functions moved from `namespace (anonymous)` to `static`. - Added test

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

This revision was automatically updated to reflect the committed changes. Closed by commit rG92aa0c2dbcb7: [cfi] Add flag to always generate .debug_frame (authored by dcandler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67216/new/

[clang] 92aa0c2 - [cfi] Add flag to always generate .debug_frame

Author: David Candler Date: 2019-10-31T09:48:30Z New Revision: 92aa0c2dbcb723d102c508f6e7559330b637f912 URL: https://github.com/llvm/llvm-project/commit/92aa0c2dbcb723d102c508f6e7559330b637f912 DIFF: https://github.com/llvm/llvm-project/commit/92aa0c2dbcb723d102c508f6e7559330b637f912.diff

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet added a comment. As discussed offline, it might make more sense to fix this in `targetDecls` itself. Considering how the `Alias` is handled for typedefs and usings, it feels like this is a mistake for namespace aliases to be marked in that way. Repository: rG LLVM Github Monorepo

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGb06305e44949: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

MyDeveloperDay updated this revision to Diff 227241. MyDeveloperDay marked an inline comment as done. MyDeveloperDay set the repository for this revision to rC Clang. MyDeveloperDay added a comment. Address review comments, deduction guides with embedded parens Repository: rC Clang CHANGES

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 added a comment. Thanks you for the review and advices! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 ___ cfe-commits mailing list

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 updated this revision to Diff 227237. xbolva00 added a comment. Fixed review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69518/new/ https://reviews.llvm.org/D69518 Files: clang/include/clang/Basic/DiagnosticASTKinds.td

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

merge_guards_bot added a comment. Build result: pass - 59704 tests passed, 0 failed and 762 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

sylvestre.ledru added a comment. Did you see some significant perf improvements for Chromium? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/ https://reviews.llvm.org/D69435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

This revision was automatically updated to reflect the committed changes. Closed by commit rG71aa3f7b7e43: [clangd] Add parameter renaming to define-inline code action (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68937/new/

[clang-tools-extra] 71aa3f7 - [clangd] Add parameter renaming to define-inline code action

Author: Kadir Cetinkaya Date: 2019-10-31T09:23:09+01:00 New Revision: 71aa3f7b7e43bf7d2a8a38324b1f9f7b12bbbdfc URL: https://github.com/llvm/llvm-project/commit/71aa3f7b7e43bf7d2a8a38324b1f9f7b12bbbdfc DIFF:

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

AntonBikineev added a comment. Roman, thanks for reviewing and the ideas. > Can you be more specific what the question is? I meant to ping if anybody has more comments on this patch. Otherwise I would go ahead and submit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69435/new/

[PATCH] D68937: [clangd] Add parameter renaming to define-inline code action

kadircet updated this revision to Diff 227233. kadircet marked an inline comment as done. kadircet added a comment. - Address comments - Get rid of raw string literals inside macro calls, to not break stage1 compilers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

t.p.northover added a comment. > It looks like this patch contains a few other changes, besides the changes to > the prototypes. In particular, the change to CGBuiltin.cpp, and there are a > few new lines in the .td files that don't correspond to anything in the old > versions. Is that

[PATCH] D69624: [clangd] Fix namespace aliases in findExplicitReferences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. This looks good, but it is missing the context. I suppose we were previously not providing any references for namespace aliases, because we were filtering both the alias and the

[PATCH] D69518: [Diagnostics] Warn for std::is_constant_evaluated in constexpr mode

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticASTKinds.td:334 + "'%0' will always evaluate to 'true' in constexpr context">, + InGroup>; + rsmith wrote: > Looks like you decided not

[PATCH] D69435: [clang-tidy] New checker performance-trivially-destructible-check

lebedev.ri marked an inline comment as done. lebedev.ri added a comment. In D69435#1725795 , @AntonBikineev wrote: > Does anybody have suggestions on this? Can you be more specific what the question is? Comment at:

<    1   2