[PATCH] D69263: [clangd] Implement cross-file rename.

merge_guards_bot added a comment. Build result: fail - 59861 tests passed, 21 failed and 763 were skipped. failed: lld.ELF/linkerscript/filename-spec.s failed: Clang.Index/index-module-with-vfs.m failed: Clang.Modules/double-quotes.m failed:

[PATCH] D69263: [clangd] Implement cross-file rename.

ilya-biryukov added a comment. Thanks, this is in a good shape! The only concern I have is the racy way to get dirty buffers, please see the corresponding comment. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:764 + /*WantFormat=*/true, + [this](PathRef

[PATCH] D69564: Include the mangled name in -ast-dump=json

arichardson added a comment. Ping. Does this seem an acceptable change to the JSON output @aaron.ballman ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69564/new/ https://reviews.llvm.org/D69564 ___

[PATCH] D69664: [Diagnostics] Teach -Wnull-dereference about address_space attribute

xbolva00 added a comment. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69664/new/ https://reviews.llvm.org/D69664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69854: [clang-format] [RELAND] Remove the dependency on frontend

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. Thanks! One comment (the stale pointer one) and a more general suggestion (potentially for a future change) below, else I think this is good to go. Comment at:

[PATCH] D56345: [clang-format] Assert that filenames are not empty

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56345/new/ https://reviews.llvm.org/D56345 ___ cfe-commits

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

hans added a comment. In D69760#1734534 , @thakis wrote: > In D69760#1734524 , @thakis wrote: > > > We currently do cross builds of chrome/win on linux, and this breaks that. > > > > As far as I know, no linker

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 228028. hokein marked 5 inline comments as done. hokein added a comment. - use blacklist - change to enum scope Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:107 +if (!Index) + return NoIndexProvided; + ilya-biryukov wrote: > hokein wrote: > > ilya-biryukov wrote: > > > Why isn't this a scope enum in the first place? > >

[PATCH] D69715: NeonEmitter: change Type representation. NFC.

t.p.northover closed this revision. t.p.northover added a comment. > I guess the extra checks are due to existing code "accidentally" doing the > right thing? Yep, they were helpful while I was in the process of converting (in the end I went via `AAAFloating` enumerators to make sure all uses

[PATCH] D69716: NeonEmitter: remove special 'a' modifier.

t.p.northover closed this revision. t.p.northover added a comment. Thanks: To github.com:llvm/llvm-project.git 6c2a4f5ff93..59f063b89c5 master -> master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69716/new/ https://reviews.llvm.org/D69716

[clang] 26bc7cb - [clang, MveEmitter] Fix sign/zero extension in range limits.

Author: Simon Tatham Date: 2019-11-06T09:01:42Z New Revision: 26bc7cb05edd6bea4b9a1593baf0fbe9e45f54e4 URL: https://github.com/llvm/llvm-project/commit/26bc7cb05edd6bea4b9a1593baf0fbe9e45f54e4 DIFF: https://github.com/llvm/llvm-project/commit/26bc7cb05edd6bea4b9a1593baf0fbe9e45f54e4.diff LOG:

[clang] 38f0165 - [ARM MVE] Remove accidental 64-bit vst2/vld2 intrinsics.

Author: Simon Tatham Date: 2019-11-06T09:01:42Z New Revision: 38f016520f6edbfa7d059b60ac54e80dd955ada5 URL: https://github.com/llvm/llvm-project/commit/38f016520f6edbfa7d059b60ac54e80dd955ada5 DIFF: https://github.com/llvm/llvm-project/commit/38f016520f6edbfa7d059b60ac54e80dd955ada5.diff LOG:

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay updated this revision to Diff 228014. MyDeveloperDay added a reviewer: mitchell-stellar. MyDeveloperDay added a comment. remove the asserts at least for now. This fix is important for people using clang-format integrated into some editor tools. CHANGES SINCE LAST ACTION

[PATCH] D69788: [ARM MVE] Remove accidental 64-bit vst2/vld2 intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38f016520f6e: [ARM MVE] Remove accidental 64-bit vst2/vld2 intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69788/new/

[PATCH] D69790: [ARM,MVE] Integer-type nitpicks in MVE intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf0c6890f32c0: [ARM,MVE] Integer-type nitpicks in MVE intrinsics. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69790/new/

[PATCH] D56345: [clang-format] Assert that filenames are not empty

MyDeveloperDay commandeered this revision. MyDeveloperDay edited reviewers, added: jr; removed: MyDeveloperDay. MyDeveloperDay added a comment. This revision now requires review to proceed. @jr As there is no response from you, I wonder if you are ok with me taking this over, I'd like to

[PATCH] D69789: [clang,MveEmitter] Fix sign/zero extension in range limits.

This revision was automatically updated to reflect the committed changes. Closed by commit rG26bc7cb05edd: [clang,MveEmitter] Fix sign/zero extension in range limits. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D63835: [Syntax] Add nodes for most common statements

merge_guards_bot added a comment. Build result: fail - 59843 tests passed, 21 failed and 768 were skipped. failed: lld.ELF/linkerscript/filename-spec.s failed: Clang.Index/index-module-with-vfs.m failed: Clang.Modules/double-quotes.m failed:

[PATCH] D69883: [OpenCL] Add math and common builtin functions

svenvh created this revision. svenvh added reviewers: Anastasia, Pierre, Nicola. Herald added subscribers: cfe-commits, kristina, yaxunl. Herald added a reviewer: rengolin. Herald added a project: clang. Add the math and common builtin functions from the OpenCL C specification. Patch by Pierre

[clang-tools-extra] 24130d6 - [clang-tidy] Add readability-make-member-function-const

Author: Matthias Gehre Date: 2019-11-06T09:27:02+01:00 New Revision: 24130d661ed42c30f009b695d3c9ce57d2208b5e URL: https://github.com/llvm/llvm-project/commit/24130d661ed42c30f009b695d3c9ce57d2208b5e DIFF:

[clang-tools-extra] 7ea4c6f - [clangd] Implement a function to lex the file to find candidate occurrences.

Author: Haojian Wu Date: 2019-11-06T09:56:02+01:00 New Revision: 7ea4c6fa5121b2417875dc1b547162e18be7dbe2 URL: https://github.com/llvm/llvm-project/commit/7ea4c6fa5121b2417875dc1b547162e18be7dbe2 DIFF: https://github.com/llvm/llvm-project/commit/7ea4c6fa5121b2417875dc1b547162e18be7dbe2.diff

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov updated this revision to Diff 228023. ilya-biryukov marked 20 inline comments as done. ilya-biryukov added a comment. - Group Traverse* and Walk* together - s/RAT/RAV - Add a comment about nullability of the accessors - Name function for consuming statements and expressions

[PATCH] D63835: [Syntax] Add nodes for most common statements

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:193 + syntax::Statement *thenStatement(); + syntax::Leaf *elseKeyword(); + syntax::Statement *elseStatement(); sammccall wrote: > ilya-biryukov wrote: > > sammccall

[clang] 76ec6b1 - [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

Author: paulhoad Date: 2019-11-06T09:34:48Z New Revision: 76ec6b1ef69fcbd27cb0d587a5eb2d51a135a6bb URL: https://github.com/llvm/llvm-project/commit/76ec6b1ef69fcbd27cb0d587a5eb2d51a135a6bb DIFF: https://github.com/llvm/llvm-project/commit/76ec6b1ef69fcbd27cb0d587a5eb2d51a135a6bb.diff LOG:

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

merge_guards_bot added a comment. Build result: fail - 59859 tests passed, 22 failed and 763 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_class/try_lock.pass.cpp failed: lld.ELF/linkerscript/filename-spec.s

[clang] 9577ee8 - NeonEmitter: switch to enum for internal Type representation.

Author: Tim Northover Date: 2019-11-06T10:02:15Z New Revision: 9577ee84e638530be7a310c9d50526a36e3c212e URL: https://github.com/llvm/llvm-project/commit/9577ee84e638530be7a310c9d50526a36e3c212e DIFF: https://github.com/llvm/llvm-project/commit/9577ee84e638530be7a310c9d50526a36e3c212e.diff

[clang] 59f063b - NeonEmitter: remove special 'a' type modifier.

Author: Tim Northover Date: 2019-11-06T10:23:36Z New Revision: 59f063b89c518ae81467f6015d1c428c61583f71 URL: https://github.com/llvm/llvm-project/commit/59f063b89c518ae81467f6015d1c428c61583f71 DIFF: https://github.com/llvm/llvm-project/commit/59f063b89c518ae81467f6015d1c428c61583f71.diff

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay updated this revision to Diff 228009. MyDeveloperDay marked 9 inline comments as done. MyDeveloperDay added a comment. Address a few grammatical review comments After modifications F10640074: image.png CHANGES SINCE LAST ACTION

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2001 LS_Latest, -/// Auto: Automatic detection based on the input. -/// Parse using the latest language version. Format based on detected input. +/// Automatic detection based

[clang] f349cc3 - clang-format: Add a fallback style to Emacs mode

Author: paulhoad Date: 2019-11-06T09:50:54Z New Revision: f349cc37cc485fd5fc7b34cb84053af459337ecc URL: https://github.com/llvm/llvm-project/commit/f349cc37cc485fd5fc7b34cb84053af459337ecc DIFF: https://github.com/llvm/llvm-project/commit/f349cc37cc485fd5fc7b34cb84053af459337ecc.diff LOG:

[PATCH] D69752: clang-format: Add a fallback style to Emacs mode

This revision was automatically updated to reflect the committed changes. Closed by commit rGf349cc37cc48: clang-format: Add a fallback style to Emacs mode (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D69752?vs=227584=228010#toc Repository: rG LLVM Github

[PATCH] D63835: [Syntax] Add nodes for most common statements

This revision was automatically updated to reflect the committed changes. Closed by commit rG58fa50f43701: [Syntax] Add nodes for most common statements (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63835/new/

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

This revision was automatically updated to reflect the committed changes. Closed by commit rG24130d661ed4: [clang-tidy] Add readability-make-member-function-const (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D68074?vs=225804=228006#toc Repository: rG LLVM Github

[PATCH] D69577: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted

This revision was automatically updated to reflect the committed changes. Closed by commit rG76ec6b1ef69f: [clang-format] [PR35518] C++17 deduction guides are wrongly formatted (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D69577?vs=227952=228008#toc

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7ea4c6fa5121: [clangd] Implement a function to lex the file to find candidate occurrences. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69615: [clangd] Implement a function to lex the file to find candidate occurrences.

hokein updated this revision to Diff 228011. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69615/new/ https://reviews.llvm.org/D69615 Files:

[clang] 7681435 - [clang-format] Assert that filenames are not empty

Author: paulhoad Date: 2019-11-06T17:25:17Z New Revision: 7681435de148cf7a1c7db1b0daba0497630989d2 URL: https://github.com/llvm/llvm-project/commit/7681435de148cf7a1c7db1b0daba0497630989d2 DIFF: https://github.com/llvm/llvm-project/commit/7681435de148cf7a1c7db1b0daba0497630989d2.diff LOG:

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4011 unsigned NamedModifiersNumber = 0; - SmallVector FoundNameModifiers( - OMPD_unknown + 1); + SmallVector +

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1828-1831 + be flushed to zero by standard floating point operations. It is not + mandated that flushing to zero occurs, but if a subnormal output is + flushed to zero,

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: thakis, klimek, mitchell-stellar, vlad.tsyrklevich. MyDeveloperDay added projects: clang-format, clang. Review comments in D69854: [clang-format] [RELAND] Remove the dependency on frontend

[PATCH] D68568: [clang-format] Make '.clang-format' variants finding a loop

wanders added a comment. In D68568#1735741 , @MyDeveloperDay wrote: > Do you need help landing this? Sorry that I havn't gotten back to this. I started looking into the "PathMatch" idea I floated in D68569

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

aaron.ballman added a comment. In D69813#1735804 , @Szelethus wrote: > In D69813#1734272 , @Charusso wrote: > > > In D69813#1734193 , @Szelethus > > wrote: > > > > > Hmm,

[PATCH] D69433: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

This revision was automatically updated to reflect the committed changes. Closed by commit rGeadb65f273c0: [clang-format] [NFC] update the documentation in Format.h to allow… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } ABataev wrote: > cchen wrote: > > ABataev wrote: > > > cchen wrote: > > > > ABataev

[clang] eadb65f - [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct. (part 2)

Author: paulhoad Date: 2019-11-06T20:03:05Z New Revision: eadb65f273c076c4997b28a51f086eea505c3e78 URL: https://github.com/llvm/llvm-project/commit/eadb65f273c076c4997b28a51f086eea505c3e78 DIFF: https://github.com/llvm/llvm-project/commit/eadb65f273c076c4997b28a51f086eea505c3e78.diff LOG:

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228115. cmtice added a comment. Remove period from help text. Fix tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 6 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:215 LANGOPT(OpenMPCUDAMode, 1, 0, "Generate code for OpenMP pragmas in SIMT/SPMD mode") +LANGOPT(OpenMPNewCodegen , 1, 0, "Use the

[PATCH] D69897: Add #pragma clang loop aligned

Meinersbur added a comment. In D69897#1735983 , @lebedev.ri wrote: > It would be really best if this could just make use of > `CodeGenFunction::EmitAlignmentAssumption()`, > else this is a heavy hammer with loose handle. Since it is a property of the

[PATCH] D69498: IR: Invert convergent attribute handling

mehdi_amini added a comment. In D69498#1735763 , @arsenm wrote: > In D69498#1731265 , @mehdi_amini > wrote: > > > Just thought about a slight variation on this: what about adding a flag on > > the datalayout (or

[PATCH] D69853: [OpenMP][NFCI] Introduce llvm/IR/OpenMPConstants.h

jdoerfert updated this revision to Diff 228126. jdoerfert marked an inline comment as done. jdoerfert added a comment. working version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69853/new/ https://reviews.llvm.org/D69853 Files:

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

dblaikie added inline comments. Comment at: clang/test/Driver/debug-default-version.c:37 + +// NODEBUGINFO-NOT: "-debug-info-kind=" + Same issue as with the dwarf-version below. It's probably easier to remove the "" (FileCheck arguments aren't quoted - these

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:4374 + case DMIB_unspecified: +return OMPC_MAP_tofrom; + } cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev wrote: > > > > cchen wrote: > > > > > ABataev wrote: > > > > >

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228130. cmtice added a comment. Fix NODEBUGINFO-NOT test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69921: [clang-format] refactor the use of the SMDiagnostics in replacement warnings

MyDeveloperDay updated this revision to Diff 228133. MyDeveloperDay added a comment. Remove unused `Ranges` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69921/new/ https://reviews.llvm.org/D69921 Files: clang/tools/clang-format/ClangFormat.cpp Index:

[PATCH] D69638: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

This revision was automatically updated to reflect the committed changes. Closed by commit rG6740a88dc18d: [NFC] Add SUPPORT_PLUGINS to add_llvm_executable() (authored by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69638/new/

[clang] 6740a88 - [NFC] Add SUPPORT_PLUGINS to add_llvm_executable()

Author: David Tenty Date: 2019-11-06T14:32:35-05:00 New Revision: 6740a88dc18d0be14926a5e709bd5062e31ee81c URL: https://github.com/llvm/llvm-project/commit/6740a88dc18d0be14926a5e709bd5062e31ee81c DIFF: https://github.com/llvm/llvm-project/commit/6740a88dc18d0be14926a5e709bd5062e31ee81c.diff

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

probinson added a comment. Is it tested? Intuitively I would expect DW_OP_pick to be kind of an unusual operator, unlikely to be seen in the wild. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added a comment. In D69897#1735961 , @Meinersbur wrote: > Please see my comments in D69900 as well. > > For the font-end side, I suggest the syntax `vectorize_assume_alignment(32)` > instead. We also need to

[PATCH] D69564: Include the mangled name in -ast-dump=json

aaron.ballman added a subscriber: rsmith. aaron.ballman added a comment. Thank you for your patience with my delayed review, I've been at standards meetings for C and C++ and I'm a bit behind schedule. > The AST dump tests were updated using the following script: One of the things @rsmith and

[PATCH] D69813: [analyzer] CERTStrChecker: Model gets()

Charusso added a comment. In D69813#1735988 , @aaron.ballman wrote: > I'm not @NoQ, but I do agree that there should be a separate check per rule > in terms of the UI presented to the user. The name should follow the rule ID > like they do in

[PATCH] D69804: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69804/new/ https://reviews.llvm.org/D69804

[PATCH] D69890: [clangd] Improve the output of rename tests where there are failures.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Many thanks, the new tests are much simpler to read! Comment at: clang-tools-extra/clangd/unittests/RenameTests.cpp:31 + llvm::StringRef Code =

[PATCH] D69892: [clang-rename] Respect the traversal scope when traversing the entire AST.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69892/new/ https://reviews.llvm.org/D69892

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

svenvh marked an inline comment as done. svenvh added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:4091 +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getParamType(FirstIRArg)); + else @Anastasia

[PATCH] D69598: Work on cleaning up denormal mode handling

spatel added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1736-1737 +if (CodeGenOpts.FPSubnormalMode != llvm::SubnormalMode::Invalid) + FuncAttrs.addAttribute("denormal-fp-math", +

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ymandel created this revision. ymandel added a reviewer: ilya-biryukov. Herald added a project: clang. - Rename `transformer::change` to `transformer::changeTo`, make `change` forward to `changeTo` and mark it deprecated. - Mark `transformer::text` and `transformer::selection` deprecated and

[libunwind] 049f94a - Revert "build: explicitly set the linker language for unwind"

Author: Saleem Abdulrasool Date: 2019-11-06T08:34:13-08:00 New Revision: 049f94af487fc8be704f8740e2d2946ac5c6efc9 URL: https://github.com/llvm/llvm-project/commit/049f94af487fc8be704f8740e2d2946ac5c6efc9 DIFF:

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

cchen marked 2 inline comments as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1967 (DSAStack->isForceCaptureByReferenceInTargetExecutable() && !Ty->isAnyPointerType()) || !Ty->isScalarType() ||

[clang] ce2b5cb - [libTooling] Simplify type structure of `Stencil`s.

Author: Yitzhak Mandelbaum Date: 2019-11-06T10:28:34-05:00 New Revision: ce2b5cb6decb5cce32adde0d23bdea521da0908b URL: https://github.com/llvm/llvm-project/commit/ce2b5cb6decb5cce32adde0d23bdea521da0908b DIFF:

[clang] 6c683aa - [libTooling] Fix breakage from change #84922

Author: Yitzhak Mandelbaum Date: 2019-11-06T11:31:35-05:00 New Revision: 6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8 URL: https://github.com/llvm/llvm-project/commit/6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8 DIFF:

[PATCH] D69890: [clangd] Improve the output of rename tests where there are failures.

hokein updated this revision to Diff 228054. hokein marked 3 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69890/new/ https://reviews.llvm.org/D69890 Files:

[PATCH] D69892: [clang-rename] Respect the traversal scope when traversing the entire AST.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet. Herald added a project: clang. This should be NFC to clang-rename, by default the traversal scope is TUDecl. Traversing the TUDecl in clangd is a performance cliff, we should avoid

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

ABataev added inline comments. Comment at: llvm/lib/IR/OpenMPConstants.cpp:1 -//===- OpenMPConstants.cpp - Helpers related to OpenMP code generation ---===// +//===- OpenMPIRBuilder.cpp - Builder for LLVM-IR for OpenMP directives ===// // Constants?

[PATCH] D69890: [clangd] Improve the output of rename tests where there are failures.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0eed2a5cfe1: [clangd] Improve the output of rename tests where there are failures. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] bde3293 - [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

Author: Yitzhak Mandelbaum Date: 2019-11-06T10:13:33-05:00 New Revision: bde32933027a096b6cfe14b0e9385ac1005fc28a URL: https://github.com/llvm/llvm-project/commit/bde32933027a096b6cfe14b0e9385ac1005fc28a DIFF:

[clang] 9f97480 - [libTooling] Small changes in Transformer API.

Author: Yitzhak Mandelbaum Date: 2019-11-06T11:16:50-05:00 New Revision: 9f97480cddd77bd2d169131a290cc996fc78df0f URL: https://github.com/llvm/llvm-project/commit/9f97480cddd77bd2d169131a290cc996fc78df0f DIFF:

[PATCH] D69896: [libTooling] Small changes in Transformer API.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f97480cddd7: [libTooling] Small changes in Transformer API. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/

[PATCH] D69897: Add #pragma clang loop aligned

m-happy created this revision. m-happy added reviewers: hfinkel, DTharun, rscottmanley, Meinersbur. m-happy added a project: clang. Herald added subscribers: cfe-commits, zzheng. This patch adds functionality '#pragma clang loop aligned'. The load/store access in for loop following the '#pragma

[PATCH] D69890: [clangd] Improve the output of rename tests where there are failures.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Previously, we match ranges, which is hard to spot the difference. Now, we diff the code after rename against the

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui created this revision. kamleshbhalui added a reviewer: phosek. Herald added subscribers: libcxx-commits, ldionne, christof. kamleshbhalui edited the summary of this revision. reg is unsigned type and used here for getting array element from the end by negating it. negation of

[PATCH] D69204: [OpenMP 5.0] - Extend defaultmap

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1967 (DSAStack->isForceCaptureByReferenceInTargetExecutable() && !Ty->isAnyPointerType()) || !Ty->isScalarType() || ABataev wrote: > Seems to me, you're

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

ldionne added a reviewer: kledzik. ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. This looks good to me, but I must admit I'm surprised this problem has never come up before (this code is very old), and also I don't know what the code is

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/ https://reviews.llvm.org/D69896

[PATCH] D69896: [libTooling] Small changes in Transformer API.

ymandel added a comment. Build breakage fixed in commit "6c683aa8d7d [libTooling] Fix breakage from change #84922" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69896/new/

[PATCH] D69781: [analyzer] Add test directory for scan-build

thakis added a comment. Also, you probably need to make clang/test/CMakeLists.txt depend on the install target, to make sure scan-build is in bin/. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69781/new/ https://reviews.llvm.org/D69781

[PATCH] D69897: Add #pragma clang loop aligned

lebedev.ri added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3135 + +This predicates all the array references inside the loop to be aligned. The aligned access to them can increase fetch time and increase the performance. + What does this

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

hliao added a comment. PING for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] b0eed2a - [clangd] Improve the output of rename tests where there are failures.

Author: Haojian Wu Date: 2019-11-06T15:34:38+01:00 New Revision: b0eed2a5cfe13a7cd13e2446b7dfe2d7b588d416 URL: https://github.com/llvm/llvm-project/commit/b0eed2a5cfe13a7cd13e2446b7dfe2d7b588d416 DIFF: https://github.com/llvm/llvm-project/commit/b0eed2a5cfe13a7cd13e2446b7dfe2d7b588d416.diff

[PATCH] D69804: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbde32933027a: [clang-tidy] Update TransformerClangTidyCheck to use new Transformer bindings. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69613: [libTooling] Simplify type structure of `Stencil`s.

This revision was automatically updated to reflect the committed changes. Closed by commit rGce2b5cb6decb: [libTooling] Simplify type structure of `Stencil`s. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69613/new/

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

compnerd added a comment. I agree with @efriedma that it sounds odd, could you explain that please? It took about 3 reads before I saw the OUT in the WITHOUT, and then realized that this was just: `NOT (HAVE_CXX_ATOMICS_WITHOUT_LIB AND HAVE_CXX_ATOMICS64_WITHOUT_LIB)`. I don't know if there

[PATCH] D69909: [OPENMP] [DOCS] fix section formatting issues [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f10cc2d124c: [OPENMP] [DOCS] fix section formatting issues [NFC] (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D69893: libunwind: Evaluating DWARF operation DW_OP_pick is broken

kamleshbhalui added a comment. Yes, Tested All tests passes. Testing Time: 0.95s Expected Passes: 4 Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69893/new/ https://reviews.llvm.org/D69893 ___

[PATCH] D69928: [clangd] Set RetainCommentsFromSystemHeaders to true

lh123 created this revision. lh123 added reviewers: sammccall, ilya-biryukov. lh123 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. clangd should retain comments from system headers. fixes

[PATCH] D69925: remove redundant LLVM version from version string when setting CLANG_VENDOR

srhines added a comment. In D69925#1736434 , @efriedma wrote: > I think the reason it's written this way is that CLANG_VERSION_STRING might > not correspond to an LLVM version? For example, Apple has its own versioning > scheme. Line 128 is already

[clang] 9f10cc2 - [OPENMP] [DOCS] fix section formatting issues [NFC]

Author: Kelvin Li Date: 2019-11-06T22:03:09-05:00 New Revision: 9f10cc2d124c275f2e7a6764e168f6b75527e78f URL: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f DIFF: https://github.com/llvm/llvm-project/commit/9f10cc2d124c275f2e7a6764e168f6b75527e78f.diff

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added a project: clang. This is the initial patch to use the OpenMP-IR-Builder, as discussed on the mailing list ([1]

[PATCH] D69822: [clang] Add new -fdebug-default-version flag.

cmtice updated this revision to Diff 228144. cmtice added a comment. Remove quotes from -NOT tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69822/new/ https://reviews.llvm.org/D69822 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D69923: [OPENMP][DOCS] Update OpenMP status (NFC)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69923/new/ https://reviews.llvm.org/D69923 ___ cfe-commits

  1   2   >