[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet reclaimed this revision. courbet added a comment. Actually, thinking more about this, adding this to the existing warning might not be a very consensual change. In the case of the warning: S f() { T&& t = ...; ... return t; } there is no argument against doing the

[PATCH] D70306: clang: Exherbo multiarch ajustments

Keruspe planned changes to this revision. Keruspe marked 3 inline comments as done. Keruspe added a comment. Will give llvm::sys::path::stem a look and try to drop the x86_64 part from the include dir selection Comment at: clang/lib/Driver/ToolChains/Linux.cpp:360 +

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet added a comment. Adding @Quuxplusone (warning author) for opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 ___ cfe-commits mailing list

[PATCH] D50147: clang-format: support external styles

Typz added a comment. In D50147#1648786 , @sammccall wrote: > > First and forehand, I have a problem to solve in my organization : we have > > many projects, and maintaining the config file in some many repositories is > > not practical. > > In some

[PATCH] D70424: clang/AMDGPU: Fix default for frame-pointer attribute

arsenm created this revision. arsenm added reviewers: yaxunl, scott.linder, t-tye. Herald added subscribers: tpr, dstuttard, wdng, kzhuravl. Enabling optimization should allow frame pointer elimination. https://reviews.llvm.org/D70424 Files: clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

This revision was automatically updated to reflect the committed changes. Closed by commit rGe51484abd402: [clangd] Fix hover local scope to include class template params (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D70325?vs=229910=230004#toc Repository: rG

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229986. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp clang/lib/Driver/ToolChains/InterfaceStubs.cpp clang/lib/Driver/Types.cpp

[PATCH] D70355: [clang-format] [NFC] add recent changes to release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b5f6c16476c: [clang-format] [NFC] add recent changes to release notes (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth added a comment. IMHO these two should just not overlap. It makes sense, to have controversial or configurable stuff in clang-tidy. It should just be consistent with the warnings, as those are "always right" and clang-tidy can be opinionated/specialized. Repository: rG LLVM

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! but again it looks as if rebasing went wrong :/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70325/new/

[PATCH] D70340: Add a key method to Sema to optimize debug info size

hans added a comment. Nice! Silly questions, but for my own education: I thought the key function concept only existed in the Itanium ABI, but from your numbers it sounds like it's a concept, at least for debug info, also on Windows? Comment at:

[PATCH] D70359: [clangd] Show values of more expressions on hover

kadircet added a comment. it feels like rebasing went wrong :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/ https://reviews.llvm.org/D70359 ___ cfe-commits mailing list

[PATCH] D70357: [clangd] Untangle Hover from XRefs, move into own file.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:374 + } else { +auto Offset = positionToOffset(SM.getBufferData(SM.getMainFileID()), Pos); +if (!Offset) {

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

JonasToth added inline comments. Comment at: clang/include/clang/Format/Format.h:1110 + /// Different const alignment styles. + enum ConstAlignmentStyle { +/// Don't change const to either East const or West const. Drive-By question:

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet added a comment. > IMHO these two should just not overlap. It makes sense, to have controversial > or configurable stuff in clang-tidy. It should just be consistent with the > warnings, as those are "always right" and clang-tidy can be > opinionated/specialized. So to make sure I

[PATCH] D70317: [clangd] More sensible output for constructors/destructors in hover.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ec071409807: [clangd] More sensible output for constructors/destructors in hover. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add Left/Right Const (East/West , Before/After) fixer capability

MyDeveloperDay updated this revision to Diff 229996. MyDeveloperDay added a comment. - Rebase - Add Release note - Remove repeated lines cause by patch creation artefact CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files:

[clang-tools-extra] 7db1230 - Reland "[clangd] Implement rename by using SelectionTree and findExplicitReferences."

Author: Haojian Wu Date: 2019-11-19T10:20:25+01:00 New Revision: 7db1230a9f5e0185a88019c9aa5b55bd85498285 URL: https://github.com/llvm/llvm-project/commit/7db1230a9f5e0185a88019c9aa5b55bd85498285 DIFF: https://github.com/llvm/llvm-project/commit/7db1230a9f5e0185a88019c9aa5b55bd85498285.diff

[PATCH] D70325: [clangd] Fix hover 'local scope' to include class template params

sammccall added a comment. Sorry about the bad rebase, I landed the right version i think :-) In D70325#1750496 , @sammccall wrote: > In D70325#1749432 , @kadircet wrote: > > > LGTM, with a question. What about

[clang] 8b5f6c1 - [clang-format] [NFC] add recent changes to release notes

Author: mydeveloperday Date: 2019-11-19T08:44:27Z New Revision: 8b5f6c16476c7a8f50b660fb6e1b549759a783b6 URL: https://github.com/llvm/llvm-project/commit/8b5f6c16476c7a8f50b660fb6e1b549759a783b6 DIFF: https://github.com/llvm/llvm-project/commit/8b5f6c16476c7a8f50b660fb6e1b549759a783b6.diff

[PATCH] D69948: [Checkers] Added support for freopen to StreamChecker.

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:176 + const LocationContext *LCtx = C.getPredecessor()->getLocationContext(); + ConstraintManager = C.getConstraintManager(); + auto *CE =

[PATCH] D70359: [clangd] Show values of more expressions on hover

merge_guards_bot added a comment. Build result: fail - 60136 tests passed, 2 failed and 729 were skipped. failed: LLVM.CodeGen/NVPTX/vectorize-misaligned.ll failed: LLVM.Transforms/LoadStoreVectorizer/AMDGPU/merge-stores.ll Log files: console-log.txt

[clang-tools-extra] 6ec0714 - [clangd] More sensible output for constructors/destructors in hover.

Author: Sam McCall Date: 2019-11-19T10:43:22+01:00 New Revision: 6ec07140980770fccfcdf53fe43e7425a9f51a7b URL: https://github.com/llvm/llvm-project/commit/6ec07140980770fccfcdf53fe43e7425a9f51a7b DIFF: https://github.com/llvm/llvm-project/commit/6ec07140980770fccfcdf53fe43e7425a9f51a7b.diff

[clang-tools-extra] f0021f9 - [clangd] Fix ps4 buildbot failure.

Author: Haojian Wu Date: 2019-11-19T10:42:27+01:00 New Revision: f0021f95a1f40369e30bb94be1b0322747631047 URL: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047 DIFF: https://github.com/llvm/llvm-project/commit/f0021f95a1f40369e30bb94be1b0322747631047.diff

[clang-tools-extra] e51484a - [clangd] Fix hover 'local scope' to include class template params

Author: Sam McCall Date: 2019-11-19T10:52:38+01:00 New Revision: e51484abd402016a385e17896e87877b77bf4c7b URL: https://github.com/llvm/llvm-project/commit/e51484abd402016a385e17896e87877b77bf4c7b DIFF: https://github.com/llvm/llvm-project/commit/e51484abd402016a385e17896e87877b77bf4c7b.diff

[libunwind] 4fb8ecd - [libunwind] Adjust the signal_frame test for Arm

Author: Mikhail Maltsev Date: 2019-11-19T09:58:46Z New Revision: 4fb8ecdef4c9b19563e428a151c376a4103d65fc URL: https://github.com/llvm/llvm-project/commit/4fb8ecdef4c9b19563e428a151c376a4103d65fc DIFF: https://github.com/llvm/llvm-project/commit/4fb8ecdef4c9b19563e428a151c376a4103d65fc.diff

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added a comment. Yay, i see the "Schrödinger handle" pattern: until the return value of release is checked, the handle is believed to be both dead and alive at the same time. We usually use this pattern because a lot of code that's already written doesn't check their return values. But do

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

Can you check the `#0` at the end of the globals and other strings that precede that? If you do so, we can also check that `no_dead_strip` isn’t added. > On Nov 19, 2019, at 6:05 PM, Duncan P. N. Exon Smith via Phabricator via > cfe-commits wrote: > > dexonsmith added a comment. > > For some

[clang] f37356d - [clang][IFS][test] Removing driver-test.c. Test is still too brittle.

Author: Puyan Lotfi Date: 2019-11-19T21:42:17-05:00 New Revision: f37356d6f60ae5db978611621d3a375ed87ec0f0 URL: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0 DIFF: https://github.com/llvm/llvm-project/commit/f37356d6f60ae5db978611621d3a375ed87ec0f0.diff

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:279 +if (PredNode->getState() == ErrorNode->getState()) { + IsFalsePositiveFound = true; + PR->markInvalid(nullptr, nullptr); Why is this a

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2576 +CmdArgs.push_back("-ftrapping-math"); + } else if (TrappingMathPresent) CmdArgs.push_back("-fno-trapping-math"); mibintc wrote: > michele.scandale wrote: >

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. Any additional thoughts @dexonsmith @erik.pilkington @ahatanak? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70284/new/ https://reviews.llvm.org/D70284 ___ cfe-commits

[clang] 27b229d - Revert "[clang][IFS][test] Removing driver-test.c. Test is still too brittle."

Author: Puyan Lotfi Date: 2019-11-19T21:59:10-05:00 New Revision: 27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 URL: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8 DIFF: https://github.com/llvm/llvm-project/commit/27b229dc17b2ea1d06fe566df8631bb2fff7b1c8.diff

[clang] 6c6d348 - Revert "[clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot."

Author: Puyan Lotfi Date: 2019-11-19T21:59:22-05:00 New Revision: 6c6d34883a3003693cbf0ab3edf19eb999c1a62d URL: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d DIFF: https://github.com/llvm/llvm-project/commit/6c6d34883a3003693cbf0ab3edf19eb999c1a62d.diff

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:469 + auto = DiffedLines.back(); + for (auto Iter = AddedLine.Tokens.begin(); + Iter != AddedLine.Tokens.end();) { hokein wrote: > nridge wrote: > >

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

nridge updated this revision to Diff 230195. nridge marked 4 inline comments as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files:

[clang] 1b38748 - [clang][IFS] Fixing unsupported emulation mode on clang-ppc64be-linux bot.

Author: Puyan Lotfi Date: 2019-11-19T19:27:46-05:00 New Revision: 1b387484b9b38a4a1e98a9d22a9a26065b0d184e URL: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e DIFF: https://github.com/llvm/llvm-project/commit/1b387484b9b38a4a1e98a9d22a9a26065b0d184e.diff

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:25 +/// TODO: Generalize to handle libclc. +class RocmInstallationDetector { +private: arsenm wrote: > yaxunl wrote: > > I don't think we should

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

arsenm updated this revision to Diff 230197. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/clang/Driver/Options.td

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; NoQ wrote: > xazax.hun wrote: > > NoQ wrote: > >

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. In D70111#1751981 , @aprantl wrote: > There are two options here: > > - leave the C bindings as is (fine with me) > - add an overloaded function to the C bindings that has the extra argument > (also fine with me). In my opinon,

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:67 +// functions: +// 1. __attribute__((clang::acquire_handle)) |handle will be acquired +// 2.

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230162. zturner added a comment. Forgot to remove spurious `llvm::` namespace qualifications. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 Files:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun marked 13 inline comments as done. xazax.hun added a comment. Thanks for the review! I am not very well versed in Fuchsia's syscalls yet but my understanding is that not all of the syscalls can fail so we do not need all the users to check for errors. But this is something I will

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

dexonsmith added a comment. For some reason this revision is locked down and I'm not allowed to "edit" it, which includes adding inline review comments. Can you add me as a reviewer? The two comments: - Please add a period at the end of the sentence in the comment. - Can you give more context

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230187. xazax.hun added a comment. - Addressed **some** of the review comments. More changes are planned :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470 Files:

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

timwoj added a comment. Thanks for the consideration on committer access, but I'm going to have to pass for the time being. That said, can someone land this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 9PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70446: [clangd] Treat UserDefinedLiteral as a leaf in SelectionTree, sidestepping tokenization issues

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70446/new/ https://reviews.llvm.org/D70446

[clang] 69242e9 - clang/Modules: Sink ASTReadResult in ReadControlBlock, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-19T16:10:44-08:00 New Revision: 69242e986823e3fdd11a8e51f47f36bec714363c URL: https://github.com/llvm/llvm-project/commit/69242e986823e3fdd11a8e51f47f36bec714363c DIFF:

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:207 + int PtrToHandleLevel = 0; + const Type *T = QT.getTypePtr(); + while (T->isAnyPointerType() || T->isReferenceType() || T->isArrayType()) { xazax.hun wrote:

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1752811 , @dexonsmith wrote: > For some reason this revision is locked down and I'm not allowed to "edit" > it, which includes adding inline review comments. Can you add me as a > reviewer? Thought I did. > The

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

SouraVX added a comment. Some how, this{eric response} doesn't got it's way to phabricator, anyways FYI > The C bindings, in general, don't have stability guarantees outside of a few > cases. > Whitequark owns all of this now though :) > -eric Repository: rG LLVM Github Monorepo

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; xazax.hun wrote: > NoQ wrote: > > The next obvious step here would be to type-check the

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

NoQ added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; The next obvious step here would be to type-check the declaration to make sure that it's actually

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7287 + case ParsedAttr::AT_AcquireHandle: +handleSimpleAttribute(S, D, AL); +break; NoQ wrote: > The next obvious step here would be

[clang] 8700831 - clang/Modules: Early return in CompilerInstance::createModuleManager, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-19T18:16:23-08:00 New Revision: 8700831734811cb89eafb72b75206f21e9f047e9 URL: https://github.com/llvm/llvm-project/commit/8700831734811cb89eafb72b75206f21e9f047e9 DIFF:

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

michele.scandale added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2337 +<< "-ffp-contract=fast"; +optID = options::OPT_ffast_math; +FPModel = Val; Here it seems you are changing `optID` to `OPT_ffast_math` to

[PATCH] D70320: [Analyzer] [NFC] Iterator Checkers - Separate iterator modeling and the actual checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:1308-1318 +ProgramStateRef removeIteratorPosition(ProgramStateRef State, const SVal ) { if (auto Reg =

[clang] b6d7bbf - [RISCV] Support mutilib in baremetal environment

Author: Zakk Chen Date: 2019-11-19T02:10:39-08:00 New Revision: b6d7bbfa004310777cd41448ffc377aea082fc8c URL: https://github.com/llvm/llvm-project/commit/b6d7bbfa004310777cd41448ffc377aea082fc8c DIFF: https://github.com/llvm/llvm-project/commit/b6d7bbfa004310777cd41448ffc377aea082fc8c.diff

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6d7bbfa0043: [RISCV] Support mutilib in baremetal environment (authored by khchen, committed by Zakk Chen zakk.c...@sifive.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69770/new/ https://reviews.llvm.org/D69770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked an inline comment as done. dnsampaio added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/ https://reviews.llvm.org/D70183 ___ cfe-commits mailing list

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

lebedev.ri added a comment. In D70165#1751402 , @mitchell-stellar wrote: > Oops, it looks like I mixed up this ticket with > https://reviews.llvm.org/D69238. Sorry about that. Would you like me to > revert both commits and then re-commit with the

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D69238. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

mitchell-stellar reopened this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. Reopening in order to correct the accidentally swapped commits between this ticket and https://reviews.llvm.org/D70165. Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 41ee54e - Revert "[clang-tidy] Fix readability-redundant-string-init for c++17/c++2a"

Author: Mitchell Balan Date: 2019-11-19T07:52:31-05:00 New Revision: 41ee54e5d18858c56725485ef637ad5a686368f4 URL: https://github.com/llvm/llvm-project/commit/41ee54e5d18858c56725485ef637ad5a686368f4 DIFF:

[clang] 3de7cc9 - Revert "[RISCV] Support mutilib in baremetal environment"

Author: Nico Weber Date: 2019-11-19T08:16:55-05:00 New Revision: 3de7cc9fc01c8eb19eb344691c4747def1e00311 URL: https://github.com/llvm/llvm-project/commit/3de7cc9fc01c8eb19eb344691c4747def1e00311 DIFF: https://github.com/llvm/llvm-project/commit/3de7cc9fc01c8eb19eb344691c4747def1e00311.diff

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230031. lh123 edited the summary of this revision. lh123 added a comment. Address comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

awpandey added a comment. Hi @aprantl. Can we drop C binding for this feature ? What will be the impact of this. As noted by @sammccall this does not conform / break LLVM-C ABI? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/

[PATCH] D70242: [OpenCL] Allow addr space qualifiers on lambda call expressions

Anastasia added a comment. In D70242#1748313 , @rjmccall wrote: > Well that was easy. > > Do we accept the address-space attribute in this position, or is that TBD? We accept the OpenCL one right at the end. I might need to test more in C++ though...

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

mitchell-stellar added a comment. Oops, it looks like I mixed up this ticket with https://reviews.llvm.org/D69238. Sorry about that. Would you like me to revert both commits and then re-commit with the correct links, etc.? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. The test fails on Windows: http://45.33.8.238/win/2576/step_6.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___ cfe-commits

[PATCH] D70183: Detect source location overflow due includes

miyuki added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:587 +Diag.Report(IncludePos, diag::err_include_too_large); +exit(1); + } dnsampaio wrote: > miyuki wrote: > > dnsampaio wrote: > > > miyuki wrote: > > > > dnsampaio wrote: > > >

[PATCH] D69238: Fix clang-tidy readability-redundant-string-init for c++17/c++2a

This revision was automatically updated to reflect the committed changes. Closed by commit rG1315f4e009b0: [clang-tidy] Fix readability-redundant-string-init for c++17/c++2a (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D69238?vs=229651=230039#toc

[PATCH] D70165: clang-tidy: modernize-use-override new option AllowOverrideAndFinal

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf7086fe: [clang-tidy] modernize-use-override new option AllowOverrideAndFinal (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D70165?vs=229632=230040#toc

[PATCH] D70437: [AArch64][SVE] Implement shift intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: huntergr, sdesmalen, dancgr, mgudim. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following intrinsics: - asr & asrd - insr

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

justinkb reopened this revision. justinkb added a comment. This revision is now accepted and ready to land. Herald added a project: LLVM. The check doesn't work correctly if LLVM is built as a dylib and the LLVMTestingSupport static library isn't installed (which it normally wouldn't be) On my

[PATCH] D70183: Detect source location overflow due includes

dnsampaio marked 2 inline comments as done. dnsampaio added a comment. Yes. It does return a non-valid FileID, and in builds without assert you get the expected error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70183/new/

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth added a comment. In D70390#1751159 , @courbet wrote: > > IMHO these two should just not overlap. It makes sense, to have > > controversial or configurable stuff in clang-tidy. It should just be > > consistent with the warnings, as those are

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

nemanjai accepted this revision. nemanjai added a comment. LGTM. Thanks for adding the test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 ___

[PATCH] D67545: [clang-tidy] Added DefaultOperatorNewCheck.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8a4c74f1157: [clang-tidy] Added DefaultOperatorNewCheck. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D67545?vs=226206=230019#toc Repository: rG LLVM Github Monorepo

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

thakis added a comment. Reverted in 3de7cc9fc01c8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508

[PATCH] D70222: [clangd] Add support for .rsp files in compile_commands.json

lh123 updated this revision to Diff 230033. lh123 added a comment. fix typo in function document. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70222/new/ https://reviews.llvm.org/D70222 Files: clang/include/clang/Tooling/CompilationDatabase.h

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

JonasToth updated this revision to Diff 230048. JonasToth added a comment. - port patch to monorepo - Merge branch 'master' into feature_transform_const.patch - merge current master and new version for previous steps into this patch - fix compilation issues after type renaming - work on fixing

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. I know it has been a long time, but this patch is ready, i think :) i would appreciate some reviews ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395

[PATCH] D70175: [libTooling] Extend `buildASTFromCodeWithArgs` to take files argument.

ymandel added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70175/new/ https://reviews.llvm.org/D70175 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70183: Detect source location overflow due includes

miyuki added a comment. In D70183#1751552 , @dnsampaio wrote: > Yes. It does return a non-valid FileID, and in builds without assert you get > the expected error message. I was asking about "It will still reach an false assert in builds that enable

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a comment. @aaron.ballman, @Anastasia, could you take a look at new version of the patch, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. That sounds like a bug in llvm-config. It shouldn't really return dylib for components that aren't part of it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55891/new/ https://reviews.llvm.org/D55891

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

kpn added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:262 Function *F = BB->getParent(); -if (!F->hasFnAttribute(Attribute::StrictFP)) { +if (F && !F->hasFnAttribute(Attribute::StrictFP)) { F->addFnAttr(Attribute::StrictFP);

[PATCH] D70359: [clangd] Show values of more expressions on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d93c3d0b4a: [clangd] Show values of more expressions on hover (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70359/new/

[PATCH] D70319: [ARM,MVE] Add intrinsics for scalar shifts.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. > That makes even LSLL and ASRL different enough from standard LLVM IR shift > semantics that I couldn't see any better alternative than to simply model the > whole family as a set of

[PATCH] D70440: [Driver] Use VFS to check if sanitizer blacklists exist

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: llvm-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. This is a follow-up to 590f279c456bbde632eca8ef89a85c478f15a249

[PATCH] D69263: [clangd] Implement cross-file rename.

hokein updated this revision to Diff 230068. hokein marked an inline comment as done. hokein added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69263/new/ https://reviews.llvm.org/D69263 Files:

[PATCH] D69922: [OpenMP] Use the OpenMP-IR-Builder

kiranchandramohan added a comment. Thanks @jdoerfert for working on this. Sorry for being late to the party. I am trying to implement one trivial directive (Flush) and one slightly more involved (not decided). I applied D69853 , D69785

[PATCH] D69878: Consoldiate internal denormal flushing controls

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1775 -if (getLangOpts().OpenCL) - FuncAttrs.addAttribute("denorms-are-zero", - llvm::toStringRef(CodeGenOpts.FlushDenorm));

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

gribozavr2 added a comment. > hence not throwing the warning on any platform? I'm not sure I understand? The way I read the buildbot breakage, an existing ClangTidy test passed before and after this change, but broke on Windows. The breakage was that the warnings stopped being produced.

[clang-tools-extra] 33d93c3 - [clangd] Show values of more expressions on hover

Author: Sam McCall Date: 2019-11-19T15:34:04+01:00 New Revision: 33d93c3d0b4a331632902f5fb9874f4e021a2f58 URL: https://github.com/llvm/llvm-project/commit/33d93c3d0b4a331632902f5fb9874f4e021a2f58 DIFF: https://github.com/llvm/llvm-project/commit/33d93c3d0b4a331632902f5fb9874f4e021a2f58.diff

  1   2   3   >