[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked an inline comment as done. poelmanc added a comment. In D68682#1753357 , @kadircet wrote: > also could you rename the revision so that it reflects the fact that, this is > a change to clang-format and has nothing to do with clang-tidy ?

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc marked 5 inline comments as done. poelmanc added inline comments. Comment at: clang/lib/AST/CommentParser.cpp:19 -static inline bool isWhitespace(llvm::StringRef S) { +// Consider moving this useful function to a more general utility location. +bool

[PATCH] D68682: format::cleanupAroundReplacements removes whole line when Removals leave previously non-blank line blank

poelmanc updated this revision to Diff 230375. poelmanc marked 3 inline comments as done. poelmanc retitled this revision from "Clang-tidy fix removals removing all non-blank text from a line should remove the line" to "format::cleanupAroundReplacements removes whole line when Removals leave

[PATCH] D70525: [clang][IFS][test] GreenDragon and Fuchsia Darwin bot fix: BindArchClass Nest.

plotfi created this revision. plotfi added a reviewer: compnerd. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a post commit review. If I can re-implement this in a nicer way I will do an NFC commit. On Darwin the clang driver does not invoke

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

awpandey created this revision. awpandey added reviewers: jini.susan.george, SouraVX, alok, aprantl, dblaikie. awpandey added projects: clang, LLVM, debug-info. Herald added subscribers: llvm-commits, cfe-commits, ormris. This patch will provide support for auto return type for the C++ member

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sunfish added a comment. > Do you think that setting this attribute should also prevent GC? That sounds right to me. > I could split this up into clang, llvm, and lld parts if it makes reviewing > simpler. For me, it's easier to have it all together in one. In this patch, `export_name` has a

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sunfish added a comment. It appears this doesn't handle exporting an imported function yet, which is fine for now, but it would be good to issue a warning, because wasm itself is capable of representing this: void aaa(void) __attribute__((import_module("imp"), import_name("foo"),

[clang] fec3ca7 - [clang][IFS][test] GreenDragon and Fuchsia Darwin bot fix: BindArchClass Nest.

Author: Puyan Lotfi Date: 2019-11-20T22:12:28-05:00 New Revision: fec3ca77bbce6917c103963b7b85b60dfb865c7b URL: https://github.com/llvm/llvm-project/commit/fec3ca77bbce6917c103963b7b85b60dfb865c7b DIFF: https://github.com/llvm/llvm-project/commit/fec3ca77bbce6917c103963b7b85b60dfb865c7b.diff

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. I have a fix. About to push. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) >

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked 2 inline comments as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:105 +OOpt = "0"; + else if (A->getOption().matches(options::OPT_O)) +OOpt = A->getValue(); dschuff wrote: > This

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish updated this revision to Diff 230364. sunfish added a comment. Don't run wasm-opt with -O0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500 Files: clang/lib/Driver/ToolChains/WebAssembly.cpp

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; stevewan

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 230360. stevewan marked an inline comment as done. stevewan added a comment. Add "-u" to accept undefined symbol as extern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/

Re: [clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

I have a solution, stay tuned. So it turns out since the clang driver has special behavior on Darwin for handling Universal apps, there is a different code path that happens during BuildActions. clang::driver::Driver::BuildUniversalActions is called instead of BuildActions on Darwin, and what 

[PATCH] D69620: Add AIX assembler support

stevewan marked 4 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; Xiangling_L

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added inline comments. Comment at: clang/test/Driver/wasm-toolchain-lto.c:6 +// LINK_OPT_KNOWN: clang{{.*}}" "-cc1" {{.*}} "-o" "[[temp:[^"]*]]" +// LINK_OPT_KNOWN: wasm-ld{{.*}}" "-L/foo/lib/wasm32-wasi/llvm-lto/ Include the final path segment in the

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added a comment. LGTM on the approach, just one more question on the wasm-opt flags. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:105 +OOpt = "0"; + else if (A->getOption().matches(options::OPT_O)) +OOpt = A->getValue();

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 created this revision. Herald added subscribers: llvm-commits, cfe-commits, sunfish, aheejin, hiraditya, jgravelle-google, dschuff. Herald added projects: clang, LLVM. sbc100 added a comment. sbc100 added reviewers: dschuff, sunfish. First stab at getting this attribute plumbed all the

[PATCH] D70520: [WebAssembly] Add new `export_name` clang attribute for controlling wasm export names

sbc100 added a comment. First stab at getting this attribute plumbed all the way through. Do you think that setting this attribute should also prevent GC? I could split this up into clang, llvm, and lld parts if it makes reviewing simpler. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/FuchsiaHandleChecker.cpp:19-20 +// handle variable is passed to different function calls or syscalls, its state +// changes. The state changes can be generally represented by following ASCII +// Art: +//

[PATCH] D70411: [analyzer][WIP] CERT: StrChecker: 31.c

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:170 +Report->addVisitor( +allocation_state::getMallocBRVisitor(DestV.getAsSymbol())); + } else { We can do the opposite to see whether the destination

[PATCH] D70411: [analyzer][WIP] CERT: StrChecker: 31.c

Charusso added a comment. In D70411#1754356 , @NoQ wrote: > I think it would really help if you draw a state machine for the checker, > like the ASCII-art thing in D70470 ; you > don't need to spend a lot of time turning

[PATCH] D70411: [analyzer][WIP] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 230354. Charusso marked 2 inline comments as done. Charusso retitled this revision from "[analyzer][WIP] StrChecker: 31.c" to "[analyzer][WIP] CERT: StrChecker: 31.c". Charusso added a comment. - Added a report when the not null-terminated string is read. -

[PATCH] D70411: [analyzer][WIP] StrChecker: 31.c

NoQ added a comment. I think it would really help if you draw a state machine for the checker, like the ASCII-art thing in D70470 ; you don't need to spend a lot of time turning it into ASCII-art, a photo of a quick hand-drawn picture would be totally fine,

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi added a comment. Looking into it. This change also affected Green Dragon. Thanks for the heads up. In D70274#1754306 , @leonardchan wrote: > Hi! I think this patch might be causing some test failures on our mac bots: > > FAIL: Clang ::

Re: [clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

Looking into this. Thanks for the heads up.  PL Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Wednesday, November 20, 2019 4:12 PM, Alex L wrote: > Hi Puyan, > > This commit caused two Clang failures on Darwin: > >     Clang :: InterfaceStubs/merge-conflict-test.c

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish updated this revision to Diff 230350. sunfish added a comment. Use PATH instead of WASM_OPT to find wasm-opt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500 Files:

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese added a comment. In D70351#1754276 , @arphaman wrote: > Adding experimental APIs is something that we haven't done before, but it be > useful for this case. Yep, I'm currently aware of two other people who care about this interface, so I

[clang] d9957c7 - [Sema] Add a 'Semantic' parameter to Expr::isKnownToHaveBooleanValue

Author: Erik Pilkington Date: 2019-11-20T16:29:31-08:00 New Revision: d9957c7405bc726422dbc2736ad62f704916fbe8 URL: https://github.com/llvm/llvm-project/commit/d9957c7405bc726422dbc2736ad62f704916fbe8 DIFF:

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese marked 2 inline comments as done. Bigcheese added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector DirectModuleDependencies; + /// The Clang modules

Re: [clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

Hi Puyan, This commit caused two Clang failures on Darwin: Clang :: InterfaceStubs/merge-conflict-test.c Clang :: InterfaceStubs/object-float.c Here's the build log from out bot: http://lab.llvm.org:8080/green/job/clang-stage1-RA/3929/console Can you please resolve the issue with the

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp:28 +void NoAutomaticMoveCheck::registerMatchers(MatchFinder *finder) { + const auto const_local_variable = + varDecl(hasLocalStorage(),

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

leonardchan added a comment. Hi! I think this patch might be causing some test failures on our mac bots: FAIL: Clang :: InterfaceStubs/merge-conflict-test.c (6268 of 16220) TEST 'Clang :: InterfaceStubs/merge-conflict-test.c' FAILED Script: --

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 230347. xazax.hun marked 8 inline comments as done. xazax.hun added a comment. - Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files: clang/include/clang/Basic/Attr.td

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s"; sunfish wrote: > dschuff

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. Adding experimental APIs is something that we haven't done before, but it be useful for this case. I have a couple of questions about the API: - Should types be prefixed / suffixed with experimental / v0 in case we need to extend the information passed to the client?

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h:31 + /// Modules that the input directly imports. + std::vector DirectModuleDependencies; + /// The Clang modules this input transitively depends on that have

[PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

This revision was automatically updated to reflect the committed changes. Closed by commit rG24aafcadff38: [clang-tidy] modernize-use-equals-default avoid adding redundant semicolons (authored by mitchell-stellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[clang-tools-extra] 24aafca - [clang-tidy] modernize-use-equals-default avoid adding redundant semicolons

Author: Mitchell Balan Date: 2019-11-20T18:08:37-05:00 New Revision: 24aafcadff3851ec3a0c42303fec63e815b19566 URL: https://github.com/llvm/llvm-project/commit/24aafcadff3851ec3a0c42303fec63e815b19566 DIFF:

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

merge_guards_bot added a comment. Build result: pass - 60204 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

sammccall added a comment. This fixes: - https://github.com/clangd/clangd/issues/126 - https://github.com/clangd/clangd/issues/202 (I've amended the commit message) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70512/new/

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s"; sunfish wrote: > dschuff

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The exclusive-claim model is successful at resolving conflicts over tokens between parent/child or siblings.

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:94 +llvm::sys::path::append(IncludePath, InstallPath, "include"); +#if 0 +llvm::sys::path::append(LibDevicePath, InstallPath, "lib", debugging code needs to be removed

[PATCH] D59321: WIP: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added a comment. Add Scott since this may affect comgr. Probably need to add -nodefaultlibs in comgr after this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59321/new/ https://reviews.llvm.org/D59321 ___ cfe-commits

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. @rnk : up ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

Yup will do. Sent from my iPhone - Ben D. Jones > On Nov 19, 2019, at 6:32 PM, Akira Hatanaka wrote: > > Can you check the `#0` at the end of the globals and other strings that > precede that? If you do so, we can also check that `no_dead_strip` isn’t > added. > >> On Nov 19, 2019, at

[clang] 7342912 - [clang][IFS] Driver Pipeline: generate stubs after standard pipeline (3)

Author: Puyan Lotfi Date: 2019-11-20T16:22:50-05:00 New Revision: 73429126c91c2065c6f6ef29b3eec1b7798502bb URL: https://github.com/llvm/llvm-project/commit/73429126c91c2065c6f6ef29b3eec1b7798502bb DIFF: https://github.com/llvm/llvm-project/commit/73429126c91c2065c6f6ef29b3eec1b7798502bb.diff

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish updated this revision to Diff 230322. sunfish added a comment. In D70500#1754012 , @sbc100 wrote: > On I just remember why this is probably a bad idea. llvm bitcode is not > designed to be stable, unlike object files, so its probably not a

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked an inline comment as done. twardakm added a comment. @aaron.ballman thanks for the review :) Can you please push the change on my behalf? I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. In D70500#1754032 , @dschuff wrote: > If the SDK is distributed with the compiler and version-locked, it seems like > it should be ok. Right, but if a given SDK chooses to do that, it can always at its own `-L` flags. I'm not

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added a comment. If the SDK is distributed with the compiler and version-locked, it seems like it should be ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70500/new/ https://reviews.llvm.org/D70500

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s"; sunfish wrote: > dschuff

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

vvereschaka added a comment. Done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f5aabb91a03: [CMake] Fix the path to CrossWinToARMLinux.cmake CMake cache. (authored by vvereschaka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0f5aabb - [CMake] Fix the path to CrossWinToARMLinux.cmake CMake cache.

Author: Vladimir Vereschaka Date: 2019-11-20T12:51:52-08:00 New Revision: 0f5aabb91a03b40635819f71187333dd9535b9de URL: https://github.com/llvm/llvm-project/commit/0f5aabb91a03b40635819f71187333dd9535b9de DIFF:

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. On I just remember why this is probably a bad idea. llvm bitcode is not designed to be stable, unlike object files, so its probably not a good idea to encourage the distributing of bitcode files in SDKs and such.Unless you stronly disagree maybe a good idea to

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def warn_sycl_kernel_invalid_template_param_type : Warning< + "template parameter of template functions with 'sycl_kernel' attribute

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137 + getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple + + "/llvm-lto"); +}

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

jkz added a comment. In D70416#1750978 , @joerg wrote: > This is normally done by using `-Bstatic`/`-Bdynamic` around the library. See > `tools::addOpenMPRuntime`. `-Bstatic`/`-Bdynamic` wrapping does seem to be more common, but that will change the

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sbc100 added a comment. Kinds seems like two different changes here. But lgtm. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:137 + getFilePaths().push_back(getDriver().SysRoot + "/lib/" + MultiarchTriple + + "/llvm-lto"); +}

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb added a comment. Can you commit this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 230310. bader added a comment. Applied code review comments from Aaron. Allow template template parameters for function templates marked with `sycl_kernel` attribute. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] fd8d915 - Fix parser bug that permitted 'private' as a (no-op) decl-specifier even outside OpenCL.

Author: Richard Smith Date: 2019-11-20T11:59:58-08:00 New Revision: fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe URL: https://github.com/llvm/llvm-project/commit/fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe DIFF: https://github.com/llvm/llvm-project/commit/fd8d9155a997ab0f3ef3d7dff1c56efc9b692bfe.diff

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

vvereschaka accepted this revision. vvereschaka added a comment. Thank you Sergej. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499 ___ cfe-commits mailing list

[clang-tools-extra] 6de4577 - Revert "[clangd] Fix a crash in expected types"

Author: Nico Weber Date: 2019-11-20T14:38:35-05:00 New Revision: 6de45772e0910bf7fa626e5493a2798b071eb26c URL: https://github.com/llvm/llvm-project/commit/6de45772e0910bf7fa626e5493a2798b071eb26c DIFF: https://github.com/llvm/llvm-project/commit/6de45772e0910bf7fa626e5493a2798b071eb26c.diff

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230301. ptaylor added a comment. - add package.json entry to contribute cuda language id - remove extra cuda file patterns, update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/

[PATCH] D70481: [clangd] Fix a crash in expected types

thakis added a comment. Reverted for now in 6de45772e0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70481/new/ https://reviews.llvm.org/D70481

[PATCH] D70041: register cuda language activation event and activate for .cuh files

ptaylor updated this revision to Diff 230302. ptaylor added a comment. - fix package.json whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70041/new/ https://reviews.llvm.org/D70041 Files:

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

mcberg2017 added a comment. For us this would be an impediment as we have math models that want ieee behavior while relaxing precision. Adding nnan or ninf would obstruct those choices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70488/new/

[PATCH] D70481: [clangd] Fix a crash in expected types

thakis added a comment. This broke clangd tests on Windows: http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/12324 We now have clangd tests running on main llvm bots (namely, on http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/). Do they not send mail? Repository:

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish marked an inline comment as done. sunfish added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

phosek marked 2 inline comments as done. phosek added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:130 + foreach(target x86_64;aarch64) # Set the per-target runtimes options. lenary wrote: > I don't know what's preventing you from

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. Please update the go bindings and include a release note that this API is changing & why. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70111/new/ https://reviews.llvm.org/D70111

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3450 +def UseHandle : InheritableParamAttr { + let Spellings = [Clang<"use_handle">]; + let Documentation = [UseHandleDocs]; xazax.hun wrote: > aaron.ballman wrote: > > Should

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

lenary added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:130 + foreach(target x86_64;aarch64) # Set the per-target runtimes options. I don't know what's preventing you from enabling compiling the runtimes. I made a cmake config

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

aaron.ballman accepted this revision. aaron.ballman marked an inline comment as done. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

aaron.ballman added a reviewer: arphaman. aaron.ballman added a subscriber: arphaman. aaron.ballman added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

spatel added reviewers: cameron.mcinally, mcberg2017, arsenm. spatel added a comment. Herald added a subscriber: wdng. I like the idea, but I'd be more comfortable reviewing the diffs in stages, so we know that the test coverage for the value tracking calls is good. So I'd prefer if we split

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

aaron.ballman added a comment. This is also missing tests for all the Sema handling (that the attributes only appertain to the specified subjects, accept no arguments, etc). Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; +

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun updated this revision to Diff 230294. xazax.hun added a comment. - Check trivial cases when the acquire_handle attribute is not on an output parameter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70469/new/ https://reviews.llvm.org/D70469 Files:

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added inline comments. Herald added a subscriber: ormris. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:96 + if (Arg *A = Args.getLastArg(options::OPT_O_Group)) { +if (const char *WasmOptPath = getenv("WASM_OPT")) { + StringRef OOpt = "s";

[PATCH] D70469: [attributes] [analyzer] Add handle related attributes

xazax.hun marked 3 inline comments as done. xazax.hun added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3445 + let Spellings = [Clang<"acquire_handle">]; + let Subjects = SubjectList<[Function, ParmVar], ErrorDiag>; + let Documentation =

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish created this revision. sunfish added reviewers: sbc100, dschuff, aheejin. Herald added subscribers: dexonsmith, steven_wu, hiraditya, jgravelle-google, inglorion, aprantl, mehdi_amini. Herald added a project: clang. When the WASM_OPT environment variable is set, run the wasm-opt tool to

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/ https://reviews.llvm.org/D69089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

troyj added a comment. I ran into this same problem and would like to see this patch or a similar one land. Note that there is also a -Og option to consider, which currently has the same problem. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230287. xazax.hun marked 10 inline comments as done. xazax.hun added a comment. - Explicitly model "maybe" states. - Fix some escaping issues. - Address most review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

andreil99 accepted this revision. andreil99 added a comment. This revision is now accepted and ready to land. Thanks for catching and fixing this, Sergej! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70499/new/ https://reviews.llvm.org/D70499

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader marked an inline comment as done. bader added inline comments. Comment at: clang/test/Misc/pragma-attribute-supported-attributes-list.test:134 // CHECK-NEXT: ReturnsTwice (SubjectMatchRule_function) +// CHECK-NEXT: SYCLKernel (SubjectMatchRule_function) // CHECK-NEXT:

[PATCH] D69810: [OpenCL] Fix address space for base method call (PR43145)

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69810/new/ https://reviews.llvm.org/D69810 ___ cfe-commits mailing list

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm marked 9 inline comments as done. twardakm added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/NamespaceCommentCheck.cpp:83 +const SourceManager , Preprocessor *PP, Preprocessor *ModuleExpanderPP) { +

[PATCH] D69855: [clang-tidy] Fix llvm-namespace-comment for macro expansions

twardakm updated this revision to Diff 230285. twardakm added a comment. Fix style issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69855/new/ https://reviews.llvm.org/D69855 Files:

[PATCH] D70499: [clang] Fix the path to CrossWinToARMLinux.cmake CMake cache

broadwaylamb created this revision. broadwaylamb added reviewers: vvereschaka, andreil99. broadwaylamb added a project: clang. Herald added subscribers: cfe-commits, kristof.beyls, mgorny. The comment was slightly misleading. Repository: rG LLVM Github Monorepo

Re: [PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

Am Mi., 20. Nov. 2019 um 10:21 Uhr schrieb HAPPY Mahto : >> #pragma clang loop vectorize_assume_alignment(32) >> for(int i = 0;i < n; i++){ >> a[i] = b[i] + i*i; >> } > > for this all-access inside the loop will be aligned to 32bit, > ex IR >> >> for.cond:

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader updated this revision to Diff 230281. bader marked 5 inline comments as done. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60455/new/ https://reviews.llvm.org/D60455 Files:

[PATCH] D60455: [SYCL] Implement SYCL device code outlining

bader added a subscriber: erichkeane. bader added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10079-10080 +def warn_sycl_kernel_invalid_template_param_type : Warning< + "template parameter of template functions with 'sycl_kernel' attribute

  1   2   >