[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc updated this revision to Diff 231582. bryanpkc added a comment. Add tests for -fopenmp-targets=. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

thakis added a comment. That particular bot does GN builds, but these test failures repro in the cmake build for me on both macs I tried. (Remember that the official mac bots are on greendragon, not on buildbot -- I'd guess it shows there too.) Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D69620: Add AIX assembler support

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); + const InputInfo = Inputs[0];

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231579. stevewan added a comment. Herald added subscribers: kbarton, nemanjai. Add more input file handling 1. Check if the input file is of type Filename or Nothing, throw assertion otherwise. 2. Add a test case to verify the correct behaviour of

[PATCH] D67463: [MS] Warn when shadowing template parameters under -fms-compatibility

aganea added a comment. You probably already know this, but the behavior between MSVC & Clang is different as to the value of the constant (testcase for PR43265). See: https://godbolt.org/z/y4uvgp Clang gives 0, while MSVC gives 5. This incompatibility is a potential source of failure, one of

[PATCH] D70819: [ASTImporter] Support functions with placeholder return types ...

a_sidorin added a comment. Hello Gabor, That's an interesting case, thank for fixing this! Comment at: clang/lib/AST/ASTImporter.cpp:3008 +// which is equal to the given DC. +bool isAncestorDeclContextOf(DeclContext *DC, Decl *D) { + DeclContext *DCi = D->getDeclContext();

[PATCH] D64305: [clangd] Add path mappings functionality

sammccall added a comment. Sorry, I was out for a bit and this fell off my radar. It looks good, but the last snapshot seems to have reverted some earlier changes (book vs enum, some doxygen comments etc). Do you know what's up there? Either way I should be able to apply this on Monday

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 added a comment. Hey @sammccall, any update here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64305/new/ https://reviews.llvm.org/D64305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

sammccall added a comment. Reverted as 905b002c139f039a32ab9bf1fad63d745d12423f @thakis any information available about that bot configuration? I'm not seeing any failures on "official" ones, I can't reproduce locally, and

[PATCH] D70864: update trailing newline treatment in clang-format.py

pseyfert updated this revision to Diff 231568. pseyfert added a comment. added comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70864/new/ https://reviews.llvm.org/D70864 Files: clang/tools/clang-format/clang-format.py Index: clang/tools/clang-format/clang-format.py

[clang-tools-extra] 905b002 - Revert "[clangd] Rethink how SelectionTree deals with macros and #includes."

Author: Sam McCall Date: 2019-11-29T19:59:02+01:00 New Revision: 905b002c139f039a32ab9bf1fad63d745d12423f URL: https://github.com/llvm/llvm-project/commit/905b002c139f039a32ab9bf1fad63d745d12423f DIFF: https://github.com/llvm/llvm-project/commit/905b002c139f039a32ab9bf1fad63d745d12423f.diff

[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

compnerd added a comment. The commit message doesn't really explain much. Why simply consume the argument? Why not actually halt the build since this clearly is conflicting, and its unclear what the user intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70864: update trailing newline treatment in clang-format.py

pseyfert created this revision. pseyfert added reviewers: klimek, MyDeveloperDay. pseyfert added projects: clang-format, clang. The current clang-format.py does not handle trailing newlines at the end of a file correctly. Trailing empty lines get removed except one. As far as I understand this

[PATCH] D70863: [clangd] Try harder to find a plausible `clang` as argv0, particularly on Mac.

sammccall created this revision. sammccall added reviewers: kbobyrev, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/211 Fixes

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you please provide a proper commit message before committing this? Also `-Xifs` is actually the inverse of what you want - that would be a set of arguments designed to be passed to

Re: [PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

Thanks! It's not obvious what's going on, I can't reproduce it. I'm sure I'll end up reverting, but as I can't see it on any of the "official" bots either - do you have any description of the configuration? On Fri, Nov 29, 2019 at 7:06 PM Nico Weber via Phabricator < revi...@reviews.llvm.org>

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. We need more tests here. For one, the flatten attribute is not necessary to pass the test. Second, we need to check the corner cases, e.g. reduction with different cycle lengths. Comment at: llvm/docs/LangRef.rst:1428 can prove that the

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:70 + const InputInfo = Inputs[0]; + if (II.isFilename()) +CmdArgs.push_back(II.getFilename()); Should is also be checked as being either a filename or "nothing"?

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

thakis added a comment. hover.test is failing on Mac: http://45.33.8.238/mac/3308/step_7.txt Please take a look, and revert if it takes a while. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70512/new/ https://reviews.llvm.org/D70512

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); + const InputInfo = Inputs[0]; `llvm_unreachable` is not the right solution if

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231561. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70638/new/ https://reviews.llvm.org/D70638 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Lex/Preprocessor.h

[PATCH] D68862: [ARM] Allocatable Global Register Variables for ARM

carwil added a comment. Reverted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68862/new/ https://reviews.llvm.org/D68862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

vhscampos created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. Add support for vcadd_* family of intrinsics. This set of intrinsics is available in Armv8.3-A. The fp16 versions require the FP16 extension, which

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231557. stevewan added a comment. Correct a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://reviews.llvm.org/D69620 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. >> there is only one case in llvm's code in which this warning is more >> agressive thant GCC's. I think that's okay. If after-commit feedback shows this is bad, we can always tune this diagnostic more and do not warn in that case. CHANGES SINCE LAST ACTION

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2269 +public: /// isCXXDeclarationStatement - C++-specialized function that disambiguates Extra change? Your code does not use isCXXDeclarationStatement. CHANGES SINCE LAST

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

yonghong-song added a comment. @SouraVX Currently, I filtered all external globals if they are not used. See for (auto D: ExternalDeclarations) { if (!D || D->isInvalidDecl() || D->getPreviousDecl() || !D->isUsed()) continue; Consumer.CompleteExternalDeclaration(D); } If I

[clang] 3b0b753 - On Windows, fix fuse-ld.c test when lld is provided explictly in -DCMAKE_LINKER

Author: Alexandre Ganea Date: 2019-11-29T11:28:49-05:00 New Revision: 3b0b7536a3182c1c69ade2bee80cdf954813a059 URL: https://github.com/llvm/llvm-project/commit/3b0b7536a3182c1c69ade2bee80cdf954813a059 DIFF:

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:865 + if (FreeingMemFnMap.lookup(Call)) return true; baloghadamsoftware wrote: > Maybe `return !!FreeingMemFnMap.lookup(Call)`? I think the code

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231545. Tyker added a comment. I just found out that `Parser::isCXXDeclarationStatement` is does more then just disambiguation it can emit diagnostics. which can cause error on correct code. so we can't use it in this context to disambiguate. so it is not

[PATCH] D70149: [C-index] Fix annotate-deep-statements test in Debug target

This revision was automatically updated to reflect the committed changes. Closed by commit rG471d06020a6a: [CIndex] Fix annotate-deep-statements test when using a Debug build (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 471d060 - [CIndex] Fix annotate-deep-statements test when using a Debug build

Author: Alexandre Ganea Date: 2019-11-29T10:52:20-05:00 New Revision: 471d06020a6a12c621131c508e58878890db3906 URL: https://github.com/llvm/llvm-project/commit/471d06020a6a12c621131c508e58878890db3906 DIFF:

[PATCH] D70594: [clangd] Implement range patching heuristics for cross-file rename.

hokein updated this revision to Diff 231541. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70594/new/ https://reviews.llvm.org/D70594 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

xbolva00 added a comment. Please land code fixes as NFC patch and then try to reland this patch. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:2532 +if (Val.getAsLocSymbol() == Sym) { + const VarRegion *VR = MR->getBaseRegion()->getAs(); +

[PATCH] D70829: [ARM][MVE][Intrinsics] Add VMINQ/VMAXQ/VMINNMQ/VMAXNMQ intrinsics.

MarkMurrayARM updated this revision to Diff 231540. MarkMurrayARM added a comment. Fix non-predicated floats. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70829/new/ https://reviews.llvm.org/D70829 Files: clang/include/clang/Basic/arm_mve.td

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

Tyker updated this revision to Diff 231534. Tyker added a comment. yeah i saw. this version of the patch builds all llvm subproject(not tested on llgo) without warnings. there is only one case in llvm's code in which this warning is more agressive thant GCC's. if (1) i = 0; //

[PATCH] D70857: [llvm][Support] Take in CurrentDirectory as a parameter in ExpandResponseFiles

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. kadircet added a parent revision: D70769: [Support] add vfs support for ExpandResponseFiles. kadircet edited parent revisions,

[PATCH] D70856: [Syntax] Build nodes for simple cases of top level declarations

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. More complicated nodes (e.g. template declarations) will be implemented in the follow-up patches. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70856 Files:

[PATCH] D70183: Detect source location overflow due includes

dnsampaio added a comment. Just wondering, I don't fully understand why is that important from the point I do a `return FileID();`. The critical error has already been inserted to the error list. clang shall either die due an assert in debug, or with a nice message in release. Unless clang is

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1165 // FIXME: location of base class? // We traverse this in the type case as well, but how is it not reached through Remove this FIXME Comment

[PATCH] D70853: [clangd] Fix a regression issue in local rename.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:136 + else if (!DeclaredInMainFile) +// the symbol declared outside of the main file, can't

[PATCH] D70854: [Clang] In tests, do not always assume others permissions are set

aganea created this revision. aganea added reviewers: dblaikie, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. aganea retitled this revision from "[Clang] Do not always assume others permissions are set" to "[Clang] In tests, do not always assume others permissions

[PATCH] D70512: [clangd] Rethink how SelectionTree deals with macros and #includes.

This revision was automatically updated to reflect the committed changes. sammccall marked 2 inline comments as done. Closed by commit rG19daa21f841a: [clangd] Rethink how SelectionTree deals with macros and #includes. (authored by sammccall). Changed prior to commit:

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. In D70568#1763824 , @aganea wrote: > Thanks for analyzing this! > > In D70568#1763769 , @hans wrote: > > > - About making CrashRecoveryContext::Enable() the default, that seems > > somewhat

[clang-tools-extra] 19daa21 - [clangd] Rethink how SelectionTree deals with macros and #includes.

Author: Sam McCall Date: 2019-11-29T15:21:13+01:00 New Revision: 19daa21f841ad45290c923689ee3d25198651a4c URL: https://github.com/llvm/llvm-project/commit/19daa21f841ad45290c923689ee3d25198651a4c DIFF: https://github.com/llvm/llvm-project/commit/19daa21f841ad45290c923689ee3d25198651a4c.diff

[PATCH] D69620: Add AIX assembler support

daltenty accepted this revision. daltenty added a comment. This revision is now accepted and ready to land. Other than minor nit, LGTM Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input file."); + const

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea added a comment. Thanks for analyzing this! In D70568#1763769 , @hans wrote: > - About making CrashRecoveryContext::Enable() the default, that seems > somewhat orthogonal to this change. You mention the use case of running > several compilations

[PATCH] D70853: [clangd] Fix a regression issue in local rename.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The regression is that we can't rename symbols in annonymous namespaces. Repository: rG LLVM Github Monorepo

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70727: [clangd] Keep go-to-definition working at the end of an identifier (fixes #194)

hokein added a comment. In D70727#1760485 , @nridge wrote: > By the way, may I get permissions to assign issues to myself (and make other > such metadata changes to issues) on github? sure, we just sent you an invitation to the clangd org.

[PATCH] D70253: [AArch64][SVE2] Implement remaining SVE2 floating-point intrinsics

sdesmalen added inline comments. Herald added a reviewer: efriedma. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:898 + llvm_i32_ty], +[IntrNoMem]>; + efriedma wrote: > kmclaughlin wrote: > > sdesmalen wrote: > > > I'd

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

hans added a comment. Sorry for the slow response. This is a pretty complicated patch, so I needed some time to wrap my head around it. I'm still not entirely sure I got it right, but here are some high-level comments. - About making CrashRecoveryContext::Enable() the default, that seems

[PATCH] D70850: [Clang-Tidy] Quick fix for bug in bugprone-macro-parentheses 43804

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: alexfh, aaron.ballman. baloghadamsoftware added a project: clang-tools-extra. Herald added subscribers: mgehre, gamesh411, Szelethus, rnkovacs, xazax.hun, whisperity. Herald added a project: clang. Applying parentheses

[PATCH] D70849: [AST] Traverse the class type loc inside the member type loc.

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: usaxena95, kadircet, mgorny. Herald added a project: clang. We are missing this currently. This would fix https://github.com/clangd/clangd/issues/216. Repository: rG LLVM Github Monorepo

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

jhenderson added a comment. In D70769#1763703 , @kadircet wrote: > @jhenderson I am planning to commit this if the discussion around `std::errc` > vs `llvm::errc` is resolved, I don't have any preference towards one or the > other both seems to get the

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

kadircet added a comment. @jhenderson I am planning to commit this if the discussion around `std::errc` vs `llvm::errc` is resolved, I don't have any preference towards one or the other both seems to get the work done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70656: [clangd] Define out-of-line qualify function name

kadircet updated this revision to Diff 231513. kadircet added a comment. - Update comments after rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70656/new/ https://reviews.llvm.org/D70656 Files:

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:153 + // Get new begin and end positions for the qualified body. + auto OrigFuncRange = toHalfOpenFileRange( + SM, FD->getASTContext().getLangOpts(),

[PATCH] D70656: [clangd] Define out-of-line qualify function name

kadircet updated this revision to Diff 231512. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70656/new/ https://reviews.llvm.org/D70656 Files:

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

sammccall marked 3 inline comments as done. sammccall added a comment. Sorry about committing this too early, had it confused with another patch. Fixed in 4f000824222f97c0cfd5b19951a1068132e57e79 Comment

[PATCH] D70535: [clangd] Define out-of-line qualify return value

kadircet updated this revision to Diff 231511. kadircet marked 9 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70535/new/ https://reviews.llvm.org/D70535 Files:

[clang-tools-extra] 4f00082 - [clangd] Fix 407ac2e, which was broken and committed too soon

Author: Sam McCall Date: 2019-11-29T12:05:12+01:00 New Revision: 4f000824222f97c0cfd5b19951a1068132e57e79 URL: https://github.com/llvm/llvm-project/commit/4f000824222f97c0cfd5b19951a1068132e57e79 DIFF: https://github.com/llvm/llvm-project/commit/4f000824222f97c0cfd5b19951a1068132e57e79.diff

[PATCH] D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json

lh123 added a comment. In D70222#1763553 , @kadircet wrote: > Thanks a lot for working on this patch, LGTM! > > again please make sure the changes are clang-formatted. I'm sure the code has been formatted. > Do you have commit access? I don't have

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 updated this revision to Diff 231510. lh123 marked an inline comment as done. lh123 added a comment. fix typo: "Could not convert UTF16 To UTF8" -> "Could not convert UTF16 to UTF8" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70769/new/

[PATCH] D60455: [SYCL] Add sycl_kernel attribute for accelerated code outlining

bader updated this revision to Diff 231506. bader added a comment. Minor update adjusting to the recent changes. Updated comment "The 'sycl_kernel' attribute applies only to functions" -> "The 'sycl_kernel' attribute applies only to function templates". Renamed tests from "device-attributes*"

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

This revision was automatically updated to reflect the committed changes. Closed by commit rGe702bdb8598f: [Syntax] Build SimpleDeclaration node that groups multiple declarators (authored by ilya-biryukov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

ilya-biryukov updated this revision to Diff 231504. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. Add tests with declarations inside function body Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70787/new/

[clang] e702bdb - [Syntax] Build SimpleDeclaration node that groups multiple declarators

Author: Ilya Biryukov Date: 2019-11-29T11:39:45+01:00 New Revision: e702bdb8598fcb4224f465569e7692a155c3eb3e URL: https://github.com/llvm/llvm-project/commit/e702bdb8598fcb4224f465569e7692a155c3eb3e DIFF: https://github.com/llvm/llvm-project/commit/e702bdb8598fcb4224f465569e7692a155c3eb3e.diff

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

kbobyrev added a comment. Sorry, seems I was too late :( Comment at: clang-tools-extra/clangd/TUScheduler.cpp:412 std::unique_ptr Invocation = buildCompilerInvocation(Inputs, CompilerInvocationDiagConsumer); +// Log cc1 args even (especially!) if creating

[PATCH] D70787: [Syntax] Build SimpleDeclaration node that groups multiple declarators

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:453 +)txt"}, + // Multiple declarators group into a single SimpleDeclaration. + {R"cpp(

[clang] 4b24ab1 - [AST] Remove unused and undefined `TypeLoc::IgnoreMacroDefinitions` function. NFC

Author: Ilya Biryukov Date: 2019-11-29T11:21:07+01:00 New Revision: 4b24ab181aef58c6e2001e630331385648db3c08 URL: https://github.com/llvm/llvm-project/commit/4b24ab181aef58c6e2001e630331385648db3c08 DIFF: https://github.com/llvm/llvm-project/commit/4b24ab181aef58c6e2001e630331385648db3c08.diff

[PATCH] D70656: [clangd] Define out-of-line qualify function name

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:1831 + struct { +llvm::StringRef Test; +llvm::StringRef SourceFile; maybe name them `TestHeader`, and `TestSource`. Comment at:

[PATCH] D54149: [Analyzer] [WIP] Standard C++ library functions checker for the std::find() family

baloghadamsoftware added a comment. The modeling framework in its current state cannot be used for detailed modeling of complex functions. Even detailed modeling (including handling of `GDM` data for checkers) of standard C functions are done manually: see `C string` and `stream` checkers.

[PATCH] D49074: [Analyzer] Basic support for multiplication and division in the constraint manager

baloghadamsoftware added a comment. We have applied this patch in our internal release and our users have used it for more than half a year without any problems: no crashes, no freezes and no suspicious false positives caused by it. CHANGES SINCE LAST ACTION

[PATCH] D70696: [DebugInfo] Support to emit debugInfo for extern variables

SouraVX added a comment. Hi @yonghong-song , Thanks for doing this. I have a doubt, regarding clang behavior, is this relevant to this. Consider the following test case -- extern global_var; int main(){} Now when compiled with clang -g test.c, In file ELF[DWARF] file their is no,

[PATCH] D70535: [clangd] Define out-of-line qualify return value

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:69 +llvm::Optional +synthesizeContextForNS(llvm::StringRef TargetNS, + const DeclContext *CurContext) { could you add some documentations,

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG407ac2eb5f13: [clangd] Log cc1 args at verbose level. (authored by sammccall). Repository: rG LLVM Github Monorepo

[PATCH] D32905: [Analyzer] Iterator Checker - Part 9: Evaluation of std::find-like calls

baloghadamsoftware abandoned this revision. baloghadamsoftware added a comment. Herald added subscribers: Charusso, gamesh411. The STL `find()` family is modeled in a separate checker: [[ https://reviews.llvm.org/D70818 | [Analyzer] Model STL Algoirthms to improve the iterator checkers ]]

[PATCH] D70818: [Analyzer] Model STL Algoirthms to improve the iterator checkers

baloghadamsoftware added a comment. This patch supersedes both https://reviews.llvm.org/D32905 and https://reviews.llvm.org/D54149. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70818/new/ https://reviews.llvm.org/D70818

[clang-tools-extra] 407ac2e - [clangd] Log cc1 args at verbose level.

Author: Sam McCall Date: 2019-11-29T11:00:01+01:00 New Revision: 407ac2eb5f136af5ddd213b8bcca176481ec5198 URL: https://github.com/llvm/llvm-project/commit/407ac2eb5f136af5ddd213b8bcca176481ec5198 DIFF: https://github.com/llvm/llvm-project/commit/407ac2eb5f136af5ddd213b8bcca176481ec5198.diff

[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

lh123 marked 3 inline comments as done. lh123 added inline comments. Comment at: llvm/lib/Support/CommandLine.cpp:1069 + return llvm::createStringError( + std::make_error_code(std::errc::illegal_byte_sequence), + "Could not convert UTF16 To UTF8");

[PATCH] D70222: [clang][Tooling] Add support for .rsp files in compile_commands.json

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks a lot for working on this patch, LGTM! again please make sure the changes are clang-formatted. Do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D70828: [clangd] Correct the file path in Edit::replacements when generating the rename edit.

This revision was automatically updated to reflect the committed changes. Closed by commit rG66ab932fcc10: [clangd] Correct the file path in Edit::replacements when generating the rename… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70832: [clangd] Log cc1 args at verbose level.

sammccall updated this revision to Diff 231487. sammccall added a comment. Fix Compiler.h changes that got mangled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70832/new/ https://reviews.llvm.org/D70832 Files:

[clang] 302cb3b - [Syntax] Add a comment explaining the pointer keys in std::map. NFC

Author: Ilya Biryukov Date: 2019-11-29T09:49:24+01:00 New Revision: 302cb3bc3d7220e09f5dced64ddfdda33b9c49f9 URL: https://github.com/llvm/llvm-project/commit/302cb3bc3d7220e09f5dced64ddfdda33b9c49f9 DIFF: https://github.com/llvm/llvm-project/commit/302cb3bc3d7220e09f5dced64ddfdda33b9c49f9.diff

[clang] def65bb - [Syntax] Remove unused parameter from `TreeBuilder::markChildToken`. NFC

Author: Ilya Biryukov Date: 2019-11-29T09:45:06+01:00 New Revision: def65bb4f5bc87588fa6f849225397c21dcefb2b URL: https://github.com/llvm/llvm-project/commit/def65bb4f5bc87588fa6f849225397c21dcefb2b DIFF: https://github.com/llvm/llvm-project/commit/def65bb4f5bc87588fa6f849225397c21dcefb2b.diff

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

Hahnfeld added a comment. In D70804#1763443 , @bryanpkc wrote: > In D70804#1763289 , @ABataev wrote: > > > Tests are required > > > The tests for this were added in D30644 , > but