[PATCH] D71041: [analyzer][discussion] Talk about escapes

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if

[PATCH] D70791: Workaround for MSVC 16.3.* pre-c++17 type trait linkage

STL_MSFT added a comment. > I would like to revive D66394 to get it > disabled by default soon. As I recently informed @thakis via email, our compiler documentation was incorrect (I've informed the doc team and they're going to publish a fixed article soon).

Buildbot numbers for the week of 11/17/2019 - 11/23/2019

Hello everyone, Below are some buildbot numbers for the week of 11/17/2019 - 11/23/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D71042: WIP: [DebugInfo] Ensure fallback artificial location is available for cleanups

vsk created this revision. vsk added reviewers: aprantl, dblaikie. When `CodeGenFunction::FinishFunction()` is passed an empty end location the function does not only contain 'simple' return statements, a cleanup which involves a call may be popped. As there is no debug location set (due to the

[PATCH] D70489: [clangd] Add xref for macro to static index.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9347655a2754: [clangd] Add xref for macro to static index. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/

[PATCH] D71043: Exclude bitfield definitions from magic numbers check

0x8000- created this revision. 0x8000- added reviewers: JonasToth, lebedev.ri, aaron.ballman, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. 0x8000- removed a reviewer: lebedev.ri. 0x8000- edited projects, added clang-tools-extra; removed clang.

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

thakis added a comment. > It appears that only the 1st failure there is the fault of this patch. The > 2nd seems to have come from some openmp patch (that didn't consider dso_local > on windows). > > The first (fpconstrained.cpp) likely just needs the check-lines to NOT > explicitly say the

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

akhuang created this revision. akhuang added reviewers: rnk, rsmith. Herald added subscribers: cfe-commits, nhaehnle, jvesely, jholewinski. Herald added a project: clang. This adds parsing of the qualifiers __ptr32, __ptr64, __sptr, and __uptr and lowers them to the corresponding address space

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), ))

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 updated this revision to Diff 232250. usaxena95 marked 5 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70489/new/ https://reviews.llvm.org/D70489 Files:

[PATCH] D70489: [clangd] Add xref for macro to static index.

merge_guards_bot added a comment. Build result: fail - 60403 tests passed, 1 failed and 726 were skipped. failed: LLVM.Bindings/Go/go.test Log files: console-log.txt , CMakeCache.txt

[PATCH] D71041: [analyzer][discussion] Talk about escapes

NoQ added inline comments. Comment at: clang/test/Analysis/fuchsia_handle.cpp:210 + // Because of arrays, structs, the suggestion is to escape when whe no longer + // have any pointer to that symbolic region. + if (zx_channel_create(0, get_handle_address(), ))

[PATCH] D70489: [clangd] Add xref for macro to static index.

usaxena95 added a comment. Updated benchmarks: **Before this patch** Loaded Dex from static-index.idx with estimated memory usage 354410880 bytes - number of symbols: 462463 - number of refs: 6361763 - numnber of relations: 20322 **After this patch** Num refs increases by **5.7%**

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

sbc100 added a comment. ping.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70877/new/ https://reviews.llvm.org/D70877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny added a comment. In D70958#1769589 , @eugenis wrote: > I meant you could define this path in the common lit config as something like > "netbsd_noaslr_prefix" and then set up the %run substitution in > subdirectories. I take that you mean

[PATCH] D69950: Reapply "Fix crash on switch conditions of non-integer types in templates"

mstorsjo added a comment. This (when reapplied in https://reviews.llvm.org/rG878a24ee244a24c39d1c57e9af2) broke compilation of code that earlier built fine. A reduced example: namespace glslang { class TPoolAllocator { void operator=(TPoolAllocator); }; template class a {

[clang] 93cc9dd - Revert "Properly convert all declaration non-type template arguments when"

Author: David L. Jones Date: 2019-12-04T22:12:15-08:00 New Revision: 93cc982f9e971f382ade6acf6634c5914966 URL: https://github.com/llvm/llvm-project/commit/93cc982f9e971f382ade6acf6634c5914966 DIFF:

[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

dschuff added inline comments. Comment at: llvm/test/MC/WebAssembly/import-module.s:13 + .import_module foo, bar + .import_name foo, qux + What should happen if there's a directive that refers to a symbol that doesn't exist in the asm file? Repository:

[PATCH] D71049: Remove implicit conversion that promotes half to other larger precision types for fp classification builtins

Jim created this revision. Jim added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. It shouldn't promote half to double or any larger precision types for fp classification builtins. Because fp classification builtins would get incorrect result

[PATCH] D71026: Fix LLVM_ENABLE_MODULES=ON + BUILD_SHARED_LIBS=ON build

arichardson added a comment. In D71026#1769340 , @arphaman wrote: > Is the `Tooling/Transformer` library used by clang-format? The problem might > be solved if the `Tooling/Transformer` library was its own module (just like > Clang_ToolingInclusions).

[PATCH] D70726: [OpenMP50] Add parallel master construct

cchen added a comment. I've found it: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/1042 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70726/new/ https://reviews.llvm.org/D70726

[PATCH] D70638: [Diagnostic] add a warning which warns about misleading indentation

nathanchance added a comment. > IMO that is misleading indentation. A single space followed by a tab? WTF I guess I will take a look over all of the warnings that cropped up and see if this is the case for all of them. If it is, I will just send patches to fix those (with the justification of

<    1   2   3