[clang] 543ffb4 - [OPENMP]Reorganize OpenMP warning groups.

Author: Alexey Bataev Date: 2019-12-06T13:31:02-05:00 New Revision: 543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef URL: https://github.com/llvm/llvm-project/commit/543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef DIFF: https://github.com/llvm/llvm-project/commit/543ffb4a2d6435004f7e41f2b3d9040aeb3e78ef.diff

[PATCH] D70973: [OPENMP50]Treat context selectors as expressions, not just strings.

ABataev added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70973/new/ https://reviews.llvm.org/D70973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

liuliu added a comment. With this latest fix applied on top of b220662a45c8067a2ae485ae34c1138d93506df9 , in our company's internal code, I still encounter the crash. Showing All Messages

[PATCH] D70553: [clang-apply-replacements] Add command line option to overwrite readonly files.

zturner added a comment. In D70553#1757862 , @aaron.ballman wrote: > Can you add a test case for this functionality? The reason there's no test case is because it seems like that wouldn't really be any different than testing the functionality of

[PATCH] D71005: [AST] Enable expression of OpenCL language address spaces an attribute

bader added a comment. @aaron.ballman, thank you for fixing the problem with documentation generation. With regards to attributes naming question, let me check if I get it right. 1. You suggest checking with Khronos if they want to adopt `[[opencl::private]]` attribute names in OpenCL kernel

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder added a comment. just added all the context this time (-W) Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4030 const ObjCContainerDecl *CD) { - auto I = DirectMethodDefinitions.find(OMD); + auto I =

[clang] f2ace9d - Add `QualType::hasAddressSpace`. NFC.

Author: Michael Liao Date: 2019-12-06T13:08:55-05:00 New Revision: f2ace9d6005b4ffc6f6fc068c1aac897d871df7a URL: https://github.com/llvm/llvm-project/commit/f2ace9d6005b4ffc6f6fc068c1aac897d871df7a DIFF: https://github.com/llvm/llvm-project/commit/f2ace9d6005b4ffc6f6fc068c1aac897d871df7a.diff

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

MadCoder updated this revision to Diff 232602. MadCoder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/ https://reviews.llvm.org/D71091 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/lib/Sema/SemaDeclObjC.cpp

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1772961 , @probinson wrote: > > Perhaps we should implement this mode under -fno-standalone-debug (or > > something more aggressive) since "standalone" is one of the only places I > > can think of where having the

[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71065/new/ https://reviews.llvm.org/D71065

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rG164e0fc5c7f7: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 164e0fc - [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

Author: Raphael Isemann Date: 2019-12-06T18:50:32+01:00 New Revision: 164e0fc5c7f782b174db5c87b37725ea0e174853 URL: https://github.com/llvm/llvm-project/commit/164e0fc5c7f782b174db5c87b37725ea0e174853 DIFF:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. > Perhaps we should implement this mode under -fno-standalone-debug (or > something more aggressive) since "standalone" is one of the only places I can > think of where having the full class definition would be handy You'd also want it for type units, so they

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, after fixing JF's comments. Please upload patches with full context as JF mentioned, as it helps with the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71091/new/

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl added inline comments. Comment at: clang/lib/Basic/OptionUtils.cpp:18 +template +static IntTy getLastArgIntValueImpl(const ArgList , OptSpecifier Id, +IntTy Default, DiagnosticsEngine *Diags) { tra wrote: > I'd use

[PATCH] D71080: [NFC] Separate getLastArgIntValue to Basic

yaxunl updated this revision to Diff 232592. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by Artem's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71080/new/ https://reviews.llvm.org/D71080 Files: clang/include/clang/Basic/OptionUtils.h

[PATCH] D70664: [clang-format] update string comparison in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG79f8c20e2cb6: update string comparison in clang-format.py (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D70664?vs=230873=232591#toc Repository: rG LLVM Github

[clang] 79f8c20 - update string comparison in clang-format.py

Author: mydeveloperday Date: 2019-12-06T17:36:56Z New Revision: 79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60 URL: https://github.com/llvm/llvm-project/commit/79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60 DIFF: https://github.com/llvm/llvm-project/commit/79f8c20e2cb634c1b8e42f01b42fc5ab2a512d60.diff

[PATCH] D70864: [clang-format] update trailing newline treatment in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8e03ff50389: [clang-format] update trailing newline treatment in clang-format.py (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] b8e03ff - [clang-format] update trailing newline treatment in clang-format.py

Author: mydeveloperday Date: 2019-12-06T17:26:02Z New Revision: b8e03ff50389d83dabf800203f689e227697c996 URL: https://github.com/llvm/llvm-project/commit/b8e03ff50389d83dabf800203f689e227697c996 DIFF: https://github.com/llvm/llvm-project/commit/b8e03ff50389d83dabf800203f689e227697c996.diff

[PATCH] D70926: [clang-format] Add option for not breaking line before ObjC params

MyDeveloperDay requested changes to this revision. MyDeveloperDay added inline comments. This revision now requires changes to proceed. Comment at: clang/unittests/Format/FormatTest.cpp:14468 + "NSNumber *v) {\n" \ + " u = v;\n" \"

[PATCH] D71091: Make sure that the implicit arguments for direct methods have been setup

jfb added a comment. You should upload patches with context :) Comment at: clang/lib/CodeGen/CGObjCMac.cpp:4030 const ObjCContainerDecl *CD) { - auto I = DirectMethodDefinitions.find(OMD); + auto I =

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen created this revision. khchen added a project: clang. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27,

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/MisplacedPointerArithmeticInAllocCheck.cpp:81-82 + diag(PtrArith->getBeginLoc(), + "pointer arithmetic is applied to the

[PATCH] D71001: [clang-tidy] New check: bugprone-misplaced-pointer-arithmetic-in-alloc

baloghadamsoftware updated this revision to Diff 232573. baloghadamsoftware added a comment. Updated according to the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71001/new/ https://reviews.llvm.org/D71001 Files:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1772690 , @probinson wrote: > In D70524#1772117 , @dblaikie wrote: > > > In D70524#1771709 , @probinson > > wrote: > > > > > In

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71103: [libomptarget][nfc] Move three more files to common

JonChesterfield updated this revision to Diff 232557. JonChesterfield added a comment. - update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71103/new/ https://reviews.llvm.org/D71103 Files:

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added a comment. In D70524#1772117 , @dblaikie wrote: > In D70524#1771709 , @probinson wrote: > > > In D70524#1771522 , @shafik wrote: > > > > > @probinson I was

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232554. hokein added a comment. Fix empty lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 232553. hokein added a comment. add more symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=aarch64-unknown-linux-gnu,powerpc64-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s +//

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232547. teemperor added a comment. - Reverted unintentional change to unreachable error message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor marked an inline comment as done. teemperor added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } martong wrote: > I think, we should keep the "Not implemented yet!"

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

martong added inline comments. Comment at: clang/unittests/AST/Language.cpp:44 + case Lang_OpenCL: +llvm_unreachable("-std=objc++"); } I think, we should keep the "Not implemented yet!" message here. Perhaps you wanted "-std=objc++" to put next to -x

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

ebevhan added inline comments. Comment at: lib/Sema/SemaInit.cpp:4806-4808 + if ((RefRelationship == Sema::Ref_Related && + (T1CVRQuals | T2CVRQuals) != T1CVRQuals) || + !T1Quals.isAddressSpaceSupersetOf(T2Quals)) { Sorry for the really late comment

[PATCH] D71063: [clangd] New rendering structs

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FormattedString.h:25 /// plaintext upon requrest. -class FormattedString { +class RenderableString { public: Naming: not sure "string" is the right name - it doesn't represent the things

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor updated this revision to Diff 232541. teemperor added a comment. - Put code in raw string (Thanks Gabor!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71112/new/ https://reviews.llvm.org/D71112 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong marked 6 inline comments as done. martong added a comment. In D70439#1772168 , @Charusso wrote: > I would change the order of CCh and scan-build because we usually list stuff > in alphabetical order. Also the chronological order is that, the

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

martong updated this revision to Diff 232540. martong marked 3 inline comments as done. martong added a comment. Put back the menu, add "open source" property. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70439/new/

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

martong added a comment. Thanks for addressing this, I just have some minor comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:5603 +TEST_P(ASTImporterOptionSpecificTestBase, ImplicitlyDeclareSelf) { + Decl *FromTU = getTuDecl("__attribute__((objc_root_class))\n" +

[PATCH] D71112: [ASTImporter] Implicitly declare parameters for imported ObjCMethodDecls

teemperor created this revision. teemperor added a reviewer: martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. When Sema encounters a ObjCMethodDecl definition it declares the implicit

[PATCH] D71111: [Sema] Improve diagnostic about addr spaces for overload candidates

Anastasia created this revision. Anastasia added a reviewer: rjmccall. Herald added a subscriber: ebevhan. As discussed in https://reviews.llvm.org/D69938#inline-629726 this commit improves the diagnostic of addr spaces. The approach is currently reusing diagnostic streaming of `Qualifiers`.

[clang] a3b2552 - Fix for PR44000. Optimization record for bytecode input missing.

Author: Zahira Ammarguellat Date: 2019-12-06T07:48:42-05:00 New Revision: a3b2552575d3c333e928446fac10cc5b0b4092a9 URL: https://github.com/llvm/llvm-project/commit/a3b2552575d3c333e928446fac10cc5b0b4092a9 DIFF:

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG24439a761c5e: [clangd] Store index::SymbolKind in HoverInfo (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/

[PATCH] D70911: [clangd] Switch Hover.All to structured tests

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5adbac9b85a: [clangd] Switch Hover.All to structured tests (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D70911?vs=231735=232537#toc Repository: rG LLVM Github Monorepo

[clang-tools-extra] 24439a7 - [clangd] Store index::SymbolKind in HoverInfo

Author: Kadir Cetinkaya Date: 2019-12-06T13:40:22+01:00 New Revision: 24439a761c5e21fda8f9410a5e80ff07b4ba03a2 URL: https://github.com/llvm/llvm-project/commit/24439a761c5e21fda8f9410a5e80ff07b4ba03a2 DIFF:

[clang-tools-extra] c5adbac - [clangd] Switch Hover.All to structured tests

Author: Kadir Cetinkaya Date: 2019-12-06T13:40:22+01:00 New Revision: c5adbac9b85a53112a9fc9b72e64d2615e3e4df9 URL: https://github.com/llvm/llvm-project/commit/c5adbac9b85a53112a9fc9b72e64d2615e3e4df9 DIFF:

[PATCH] D70849: [AST] Traverse the class type loc inside the member pointer type loc.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1169 DEF_TRAVERSE_TYPELOC(MemberPointerType, { - TRY_TO(TraverseType(QualType(TL.getTypePtr()->getClass(), 0))); + if (auto *TSI =

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

merge_guards_bot added a comment. Build result: pass - 60496 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This is a tool that helps us to evaluate the rename results, we may not submit this tool to the code repository, but it has

[PATCH] D71090: [clangd] Navigation from definition of template specialization to primary templateFixes https://github.com/clangd/clangd/issues/212.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Comment at: clang-tools-extra/clangd/XRefs.cpp:194 // As a consequence, there's no need to look them up in the index either. - SourceLocation

[clang-tools-extra] 6b11760 - [clangd] Try to fix CompileCommandsTests on windows. NFC

Author: Sam McCall Date: 2019-12-06T12:28:01+01:00 New Revision: 6b11760128751455a73d9f00a5f935d1f49fbd0f URL: https://github.com/llvm/llvm-project/commit/6b11760128751455a73d9f00a5f935d1f49fbd0f DIFF: https://github.com/llvm/llvm-project/commit/6b11760128751455a73d9f00a5f935d1f49fbd0f.diff

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

merge_guards_bot added a comment. Build result: pass - 60506 tests passed, 0 failed and 726 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

thakis added a comment. Breaks Win: http://45.33.8.238/win/3549/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71029/new/ https://reviews.llvm.org/D71029 ___ cfe-commits mailing list

[PATCH] D70723: [clangd] Store index::SymbolKind in HoverInfo

kadircet updated this revision to Diff 232519. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70723/new/ https://reviews.llvm.org/D70723 Files:

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] d8821ad - [clangd] Fix gcc warning about extra "; " [NFC]

Author: Mikael Holmen Date: 2019-12-06T11:22:48+01:00 New Revision: d8821adacbb02fe9f9707079087d35cb02ef4a6c URL: https://github.com/llvm/llvm-project/commit/d8821adacbb02fe9f9707079087d35cb02ef4a6c DIFF: https://github.com/llvm/llvm-project/commit/d8821adacbb02fe9f9707079087d35cb02ef4a6c.diff

[PATCH] D70615: Add an -fno-temp-file flag for compilation

hans added a comment. > Our build system does not handle randomly named files created during the > build well. Can you share more details about why this is a problem? At least the build systems I work with would not even see the temporary files, as they're written to /tmp or similar, and

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1771799 , @rsmith wrote: > It's a bit weird for this to be controlled by a `-fmodules` flag, but it's > only a `-cc1` flag, so I'm OK with that; we can rename it if/when we expose > it from the driver. It's a bit

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. The fix looks OK (other alternative is to remove the CHECK with CXXRecordDecl, or make a single line with regular expressions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499

[PATCH] D70157: Align branches within 32-Byte boundary

davezarzycki added a comment. In D70157#1772227 , @annita.zhang wrote: > > > > > >>> Third, I have not see a justification for why complexity for instruction > >>> prefix padding is necessary. All the effected CPUs support multi-byte > >>> nops, so

[PATCH] D70974: [clang-tidy] Fix PR26274

This revision was automatically updated to reflect the committed changes. Closed by commit rGfac4e3c5f8a0: [clang-tidy] Fix PR26274 (authored by alexfh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70974/new/ https://reviews.llvm.org/D70974

[clang-tools-extra] fac4e3c - [clang-tidy] Fix PR26274

Author: Alexander Kornienko Date: 2019-12-06T10:10:15+01:00 New Revision: fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 URL: https://github.com/llvm/llvm-project/commit/fac4e3c5f8a018599cbd9363a735b1c13e8f8a05 DIFF:

[PATCH] D71029: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

This revision was automatically updated to reflect the committed changes. Closed by commit rG99768b243cd7: [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 99768b2 - [clangd] (take 2) Try harder to find a plausible `clang` as argv0, particularly on Mac.

Author: Sam McCall Date: 2019-12-06T09:47:03+01:00 New Revision: 99768b243cd7afd312745da58b20ea067f39f89e URL: https://github.com/llvm/llvm-project/commit/99768b243cd7afd312745da58b20ea067f39f89e DIFF: https://github.com/llvm/llvm-project/commit/99768b243cd7afd312745da58b20ea067f39f89e.diff

[PATCH] D70157: Align branches within 32-Byte boundary

annita.zhang added a comment. > > >>> Third, I have not see a justification for why complexity for instruction >>> prefix padding is necessary. All the effected CPUs support multi-byte >>> nops, so we're talking about a *single micro op* difference between the nop >>> form and prefix form.

<    1   2