[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782812 , @hfinkel wrote: > In D71241#1782779 , @ABataev wrote: > > > In D71241#1782742 , @hfinkel wrote: > > > > > In D71241#1782703

[clang] b71475f - Fix test to work correctly on 32-bit platforms.

Author: Douglas Yung Date: 2019-12-12T17:28:06-08:00 New Revision: b71475ff9ae02a8ec8d9841316c9717ef67b2f40 URL: https://github.com/llvm/llvm-project/commit/b71475ff9ae02a8ec8d9841316c9717ef67b2f40 DIFF: https://github.com/llvm/llvm-project/commit/b71475ff9ae02a8ec8d9841316c9717ef67b2f40.diff

[PATCH] D57732: Correct inf typo

Jim added a comment. I can commit it for you. If you are interested in obtaining the commit right. you can refer https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

No worries, it happens. On Thu, Dec 12, 2019, 10:59 PM Michał Górny wrote: > On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > > As a quick note, this broke the test because you didn't update the line > > numbers in the checks. > > > > Fixed thusly: > > > > echristo@athyra

[PATCH] D71397: [clang] Improve LLVM-style RTTI support in ExternalASTSource/ExternalSemaSource

rjmccall added inline comments. Comment at: clang/include/clang/AST/ExternalASTSource.h:69 - /// Whether this AST source also provides information for - /// semantic analysis. - bool SemaSource = false; + // LLVM-style RTTI. + static char ID; aprantl

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782700 , @hfinkel wrote: > In D71241#1782668 , @ABataev wrote: > > > > > > ... > > >> While we talk a lot about what you think is bad about this solution it > >> seems we ignore

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782779 , @ABataev wrote: > In D71241#1782742 , @hfinkel wrote: > > > In D71241#1782703 , @ABataev wrote: > > > > > > > > > > > ... > > >

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782723 , @ABataev wrote: > I don't insist on function redefinition solution. You want to replace > functions - fine, but do this at the codegen, not in AST. Again, no one is replacing anything, and we're not mutating

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

eugenis added a comment. Nice cleanup! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71408/new/ https://reviews.llvm.org/D71408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rupprecht added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:444 +def warn_drv_experimental_fp_control_incomplete_opt : Warning< + "Support for floating point control option %0 is incomplete and experimental">,

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui added a comment. In D70537#1765607 , @probinson wrote: > I guess first I'm confused about why the type would be undeduced in the first > place, given that it is actually instantiated. > And if undeduced is correct, wouldn't we rather emit

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void added inline comments. Comment at: clang/test/Analysis/uninit-asm-goto.cpp:16 + if (x < 42) +asm volatile goto("testl %0, %0; testl %1, %2; jne %l3" : "+S"(x), "+D"(y) : "r"(x) :: indirect_1, indirect_2); + else nickdesaulniers wrote: > I wonder if

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void updated this revision to Diff 233738. void marked 3 inline comments as done. void added a comment. Use "any_of" and improve tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files:

[PATCH] D69091: [Sema] #pragma clang transform

Meinersbur updated this revision to Diff 233707. Meinersbur added a comment. - Remove handling of LoopHints (#pragma clang loop) and OpenMP (#pragma omp simd) to reducethe size of the patches. Compatibility with OpenMP is still a goal (to implement the upcoming OpenMP loop transformations

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782898 , @JonChesterfield wrote: > In D71241#1782846 , @ABataev wrote: > > > But I suggest to discuss this with Richard Smith. > > > Is the appeal to authority necessary to

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 created this revision. Jac1494 added reviewers: dblaikie, vsk, echristo. Jac1494 added a project: debug-info. Herald added subscribers: cfe-commits, hiraditya, aprantl. Herald added projects: clang, LLVM. Hi Devs, Consider below testcases, $cat shlib.c int var; int test() { return

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782670 , @hfinkel wrote: > In D71241#1782652 , @ABataev wrote: > > > In D71241#1782648 , @hfinkel wrote: > > > > > In D71241#1782614

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. I don't insist on function redefinition solution. You want to replace functions - fine, but do this at the codegen, not in AST. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71241/new/ https://reviews.llvm.org/D71241

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

thakis added a comment. Tests fail on Windows: http://45.33.8.238/win/3976/step_9.txt Probably needs the usual -fno-delayed-template-parsing workaround, see other clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71240/new/

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. Currently we emit a warning if you use `-frounding-math`, saying that the option is ignored. That should have alerted users that they're not getting the correct behavior now. This patch removes the warning and (IIUC) implements the correct behavior but is

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Seems reasonable, looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71439/new/ https://reviews.llvm.org/D71439

[PATCH] D71447: [CIndex] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: abramobagnara, ddunbar, aganea, hfinkel, rjmccall, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki, jdoerfert. Herald added a subscriber:

[PATCH] D71434: [Driver] Use .init_array for all gcc installations and simplify Generic_ELF -fno-use-init-array rules

MaskRay updated this revision to Diff 233721. MaskRay added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71434/new/ https://reviews.llvm.org/D71434 Files: clang/docs/ReleaseNotes.rst

[PATCH] D71167: [Driver] Default to -momit-leaf-frame-pointer for AArch64

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71167/new/ https://reviews.llvm.org/D71167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

On Thu, 2019-12-12 at 14:47 -0800, Eric Christopher wrote: > As a quick note, this broke the test because you didn't update the line > numbers in the checks. > > Fixed thusly: > > echristo@athyra ~/r/llvm-project> git push > To github.com:llvm/llvm-project.git >6bed43f3c40..259a9b10390

[PATCH] D69089: [Parser] #pragma clang transform

Meinersbur updated this revision to Diff 233704. Meinersbur added a comment. - Simplify transformation classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69089/new/ https://reviews.llvm.org/D69089 Files:

[PATCH] D71039: Add support for the MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

rnk added a comment. Sorry for the delay, overall this seems like the right approach. Comment at: clang/include/clang/AST/Type.h:477-479 + ((isPtrSizeAddressSpace(A) && B == LangAS::Default) || +(isPtrSizeAddressSpace(B) && A == LangAS::Default) || +

[clang-tools-extra] 4f732a3 - [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

Author: Nathan Ridge Date: 2019-12-12T20:31:46-05:00 New Revision: 4f732a3d49ace980058bbb12150c8afc499af0ae URL: https://github.com/llvm/llvm-project/commit/4f732a3d49ace980058bbb12150c8afc499af0ae DIFF: https://github.com/llvm/llvm-project/commit/4f732a3d49ace980058bbb12150c8afc499af0ae.diff

[clang] 4daa8d1 - Correct inf typo

Author: Andrew Gaul Date: 2019-12-13T11:02:40+08:00 New Revision: 4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a URL: https://github.com/llvm/llvm-project/commit/4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a DIFF: https://github.com/llvm/llvm-project/commit/4daa8d1de6dda58aebfa7b19547ed3ce4e9bc91a.diff

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782917 , @ABataev wrote: > In D71241#1782898 , @JonChesterfield > wrote: > > > In D71241#1782846 , @ABataev wrote: > > > > > But I

[PATCH] D71374: Improve support of GNU mempcpy

xbolva00 added a comment. Please add a IR codegen test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur updated this revision to Diff 233714. Meinersbur added a comment. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70572/new/ https://reviews.llvm.org/D70572 Files: clang/include/clang/Serialization/ASTBitCodes.h

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782742 , @hfinkel wrote: > In D71241#1782703 , @ABataev wrote: > > > > > > ... > > >> > >> > >>> Given we have two implementations, each at different points in the

[PATCH] D69092: [CodeGen] #pragma clang transform

Meinersbur updated this revision to Diff 233713. Meinersbur added a comment. - Remove handling of OpenMP simd and LoopHints by CGTransform Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69092/new/ https://reviews.llvm.org/D69092 Files:

[PATCH] D71408: [lit] Remove lit's REQUIRES-ANY directive

thopre updated this revision to Diff 233712. thopre added a comment. Herald added subscribers: Sanitizers, cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, delcypher, niosHD,

[clang] bc0c60f - Remove extra character I added to test my changes that I forgot to delete before submitting.

Author: Douglas Yung Date: 2019-12-12T18:23:08-08:00 New Revision: bc0c60f714fca54711b806c54467a8ce28c04181 URL: https://github.com/llvm/llvm-project/commit/bc0c60f714fca54711b806c54467a8ce28c04181 DIFF: https://github.com/llvm/llvm-project/commit/bc0c60f714fca54711b806c54467a8ce28c04181.diff

[PATCH] D57732: Correct inf typo

This revision was automatically updated to reflect the committed changes. Closed by commit rG4daa8d1de6dd: Correct inf typo (authored by gaul, committed by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782668 , @ABataev wrote: > In D71241#1782650 , @jdoerfert wrote: > > > While we talk a lot about what you think is bad about this solution it > > seems we ignore the problems

[PATCH] D71374: Improve support of GNU mempcpy

Jim added a comment. I am curious what is difference of code generation after applying your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71374/new/ https://reviews.llvm.org/D71374 ___

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782668 , @ABataev wrote: > ... >> While we talk a lot about what you think is bad about this solution it seems >> we ignore the problems in the current one. Let me summarize a few: >> >> - Take

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782703 , @ABataev wrote: > ... >> >> >>> Given we have two implementations, each at different points in the >>> pipeline, it might be constructive to each write down why you each >>> choose

[PATCH] D70032: [docs] #pragma clang transform

Meinersbur updated this revision to Diff 233717. Meinersbur added a comment. - Add release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70032/new/ https://reviews.llvm.org/D70032 Files: clang/docs/LanguageExtensions.rst

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782763 , @thakis wrote: > Probably needs the usual -fno-delayed-template-parsing workaround, see other > clangd tests. Thanks for the suggestion! Fix at https://reviews.llvm.org/D71444 Repository: rG LLVM Github

[PATCH] D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D71444 Files: clang-tools-extra/clangd/unittests/XRefsTests.cpp

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

andrew.w.kaylor added a comment. In D62731#1782762 , @rjmccall wrote: > Currently we emit a warning if you use `-frounding-math`, saying that the > option is ignored. That should have alerted users that they're not getting > the correct behavior now.

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

JonChesterfield added a comment. In D71241#1782846 , @ABataev wrote: > But I suggest to discuss this with Richard Smith. Is the appeal to authority necessary to resolve this? The last few posts by Hal look clear to me. Especially convincing is: >

[PATCH] D71444: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to LocateSymbol.Ambiguous

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4f732a3d49ac: [clangd] Fix Windows test failure by adding -fno-delayed-template-parsing to… (authored by nridge).

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

nridge added a comment. In D71240#1782828 , @nridge wrote: > In D71240#1782763 , @thakis wrote: > > > Probably needs the usual -fno-delayed-template-parsing workaround, see > > other clangd tests. > > > Thanks for

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

rjmccall added a comment. In D62731#1782897 , @andrew.w.kaylor wrote: > In D62731#1782762 , @rjmccall wrote: > > > Currently we emit a warning if you use `-frounding-math`, saying that the > > option is ignored.

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. In D68520#1782387 , @tstellar wrote: > After thinking about this more, do we want to even try to support the > BUILD_SHARED=ON + CLANG_LINK_CLANG_DYLIB=ON configuration? We don't support > this in llvm. Actually, even if we

[PATCH] D71345: [clangd] Fall back to selecting token-before-cursor if token-after-cursor fails.

nridge added a comment. In D71345#1781141 , @sammccall wrote: > How do you feel about the approach here? I agree that having more of the logic centralized (in `SelectionTree`) is preferable to having it directly in a call site like `getDeclAtPosition`.

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782614 , @ABataev wrote: > In D71241#1782551 , @hfinkel wrote: > > > In D71241#1779168 , > > @JonChesterfield wrote: > > > > > Lowering

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1778671 , @ABataev wrote: > There can be another one issue with this solution with inline assembly. I’m > not completely sure about it, will try to investigate it tomorrow. I suggest > to discuss this solution with

RE: [clang] 878a24e - Reapply "Fix crash on switch conditions of non-integer types in templates"

Hi Alexander, I am debugging this now but I assume the checks for the if condition were skipped before this commit (therefore no crash) because ‘c’ was set as type dependent. The checks are probably run now since c’s type dependency changed with this patch. The checks might need to be guarded

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

jdoerfert added a comment. In D71241#1782614 , @ABataev wrote: > Actually, early resolution will break tbe tools, not help them. It will > definitely break clangd, for example. The user will try to navigate to > originally called function `base` and

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782648 , @hfinkel wrote: > In D71241#1782614 , @ABataev wrote: > > > In D71241#1782551 , @hfinkel wrote: > > > > > In D71241#1779168

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782430 , @JonChesterfield wrote: > In D71241#1782427 , @ABataev wrote: > > > In D71241#1782425 , > > @JonChesterfield wrote: > > > > >

[PATCH] D71439: Allow redeclaration of __declspec(uuid)

zahen created this revision. zahen added reviewers: rnk, thakis, hans, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. msvc allows a subsequent declaration of a uuid attribute on a struct/class. Mirror this behavior in clang-cl. Repository: rG LLVM Github

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 233691. xazax.hun added a comment. - Fix some problems discovered during some real world stress test - Add more tests - The ASCII art is not updated yet, but will do so at some point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/

[PATCH] D71431: Call objc_retainBlock before passing a block as a variadic argument

rjmccall added a comment. Patch looks good, but could you describe this behavior in the ARC documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71431/new/ https://reviews.llvm.org/D71431 ___

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. In D70524#1779179 , @awpandey wrote: > @dblaikie . I have removed the redundant test case. What else should I do in > this patch? Please address this warning before committing:

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

ABataev added a comment. In D71241#1782650 , @jdoerfert wrote: > In D71241#1782614 , @ABataev wrote: > > > Actually, early resolution will break tbe tools, not help them. It will > > definitely break clangd, for

[PATCH] D71241: [OpenMP][WIP] Use overload centric declare variants

hfinkel added a comment. In D71241#1782652 , @ABataev wrote: > In D71241#1782648 , @hfinkel wrote: > > > In D71241#1782614 , @ABataev wrote: > > > > > In D71241#1782551

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e0bb3b2c24: [LTO] Support for embedding bitcode section during LTO (authored by tejohnson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71240: [clangd] Heuristically resolve dependent method calls

This revision was automatically updated to reflect the committed changes. Closed by commit rGecaa9363303e: [clangd] Heuristically resolve dependent method calls (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D71240?vs=233681=233698#toc Repository: rG LLVM Github

[PATCH] D71403: [clangd] Fix hover crashing on null types

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60654 tests passed, 1 failed and 726 were skipped. failed: lld.ELF/linkerscript/provide-empty-section.s {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 9c48c2f - [NFC] - Typo fix in test/CodeGenCXX/runtime-dllstorage.cpp

Author: Gabor Buella Date: 2019-12-12T11:26:54+01:00 New Revision: 9c48c2f9c477007234c5bdad0bc8c0969afa0724 URL: https://github.com/llvm/llvm-project/commit/9c48c2f9c477007234c5bdad0bc8c0969afa0724 DIFF: https://github.com/llvm/llvm-project/commit/9c48c2f9c477007234c5bdad0bc8c0969afa0724.diff

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

kbobyrev added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:260 + All, [&](const syntax::Token ) { return Tok.location() < Loc; }); + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin() &&

[clang] f798eb2 - Temporarily Revert "[DataLayout] Fix occurrences that size and range of pointers are assumed to be the same."

Author: Nicola Zaghen Date: 2019-12-12T10:29:54Z New Revision: f798eb21eca97dc44ed40da52ece22780fb74230 URL: https://github.com/llvm/llvm-project/commit/f798eb21eca97dc44ed40da52ece22780fb74230 DIFF: https://github.com/llvm/llvm-project/commit/f798eb21eca97dc44ed40da52ece22780fb74230.diff

[PATCH] D57732: Correct inf typo

Jim added a comment. Do you need someone to commit this change for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57732/new/ https://reviews.llvm.org/D57732 ___ cfe-commits mailing list

[PATCH] D20689: [clang-tidy] Suspicious Call Argument checker

whisperity added a comment. I have developed a related check in D69560 . That one considers types, but is an //interface rule// checker, and does not consider (any) potential call sites. Moreover, it does not consider "swaps" that happen across a function call,

[PATCH] D71197: llvm premerge: clang format test

goncharov updated this revision to Diff 233554. goncharov added a comment. add header guards back Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71197/new/ https://reviews.llvm.org/D71197 Files: clang-tools-extra/clangd/Function.h

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. Thanks again for you reviews! Since I do not have commit rights, I would be grateful if someone could push it for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 ___

[PATCH] D71199: [clang-tidy][WIP] New check readability-prefer-initialization-list

baloghadamsoftware added a comment. In D71199#1777887 , @aaron.ballman wrote: > In D71199#1775083 , @whisperity > wrote: > > > Can you refresh my memory on whether a rule for "if init expr is constant, > >

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60763 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-format: pass. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings . Build artifacts

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d986953c8b9: [IR] Split out target specific intrinsic enums into separate headers (authored by rnk). Changed prior to commit: https://reviews.llvm.org/D71320?vs=233231=233480#toc Repository: rG

RE: [clang] f978ea4 - [clang][clang-scan-deps] Aggregate the full dependency information.

Hi Michael, We are happy to help troubleshoot the issue this caused on our bot. Unfortunately, this bot is not one where we can give you access so we'll have to try and work together to debug this. Can you provide the link to the failing build so we can see which test case it was that caused the

[PATCH] D62731: Add support for options -frounding-math, -ftrapping-math, -ffp-model=, and -ffp-exception-behavior=, : Specify floating point behavior

mibintc added a comment. In D62731#1780597 , @cameron.mcinally wrote: > I don't see a problem with this, but it would be nice to make the > `-f[no-]trapping-math` command line option work. GNU compatibility is good. Thanks Cameron, I'll go that way

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

rnk marked 2 inline comments as done. rnk added a comment. Thanks, I split off the rename and landed it separately, since it is more mechanical. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320

[PATCH] D71320: [IR] Split out target specific intrinsic enums into separate headers

thakis added a comment. Any reason these are called .h? All our other tablegen outputs are called .inc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71320/new/ https://reviews.llvm.org/D71320 ___

[PATCH] D70439: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cfb91f1ef1b: [Analyzer][Docs][NFC] Add CodeChecker to the command line tools (authored by martong). Changed prior to commit: https://reviews.llvm.org/D70439?vs=232540=233590#toc Repository: rG LLVM

[PATCH] D71247: [clangd] Rename constructors and destructors in cross-file case

kbobyrev updated this revision to Diff 233563. kbobyrev marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71247/new/ https://reviews.llvm.org/D71247 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-tools-extra/clangd/unittests/RenameTests.cpp

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FormattedString.cpp:164 } - return R; + OS << '\n'; } this is worth a comment - we translate Paragraphs

[clang] 3f8da5d - [Tooling/Syntax] Helpers to find spelled tokens touching a location.

Author: Sam McCall Date: 2019-12-12T12:59:50+01:00 New Revision: 3f8da5d0910772dc1f6198916a9141bf1d5be885 URL: https://github.com/llvm/llvm-project/commit/3f8da5d0910772dc1f6198916a9141bf1d5be885 DIFF: https://github.com/llvm/llvm-project/commit/3f8da5d0910772dc1f6198916a9141bf1d5be885.diff

[PATCH] D71248: [clangd] Introduce paragraph, the first part of new rendering structs

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 60762 tests passed, 1 failed and 726 were skipped. failed: Clang.CodeGenCXX/runtime-dllstorage.cpp {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:270 + for (const syntax::Token : spelledTokensTouching(Loc, Tokens)) +if (Tok.kind() == tok::identifier) + return

[PATCH] D71378: Modifying ImportDeclContext(...) to ensure that we complete each FieldDecl of a RecordDecl when we are importing the definiton

martong added a comment. Just one more thing, maybe that is too overkill, but I think on a long term we could benefit from a unittest for this case. You could create a test similar to `LLDBLookupTest` in ASTImporterTest.cpp. In that Fixture we use Minimal import and the regular lookup (that is

[PATCH] D71197: llvm premerge: clang format test

goncharov added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. In D57660#1764337 , @Mordante wrote: > I like this improvement. However I'm not a reviewer. Thanks for looking at the patch! > You can land some NFC changes in separate commit. Yep, indeed. Will do when I rebase it.

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

serge-sans-paille updated this revision to Diff 233585. serge-sans-paille added a comment. @george.burgess.iv : take into account reviews, extra testing and function renaming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno added a comment. In D57747#1774848 , @xbolva00 wrote: > Does the whole stack of patch need to be commited at once or maybe you can > land them individually? Hi, thanks for looking at this patch series ! If I remember correctly (it has been

[clang] 4cfb91f - [Analyzer][Docs][NFC] Add CodeChecker to the command line tools

Author: Gabor Marton Date: 2019-12-12T14:22:52+01:00 New Revision: 4cfb91f1ef1b136f82015b792d6f1fafd47fd437 URL: https://github.com/llvm/llvm-project/commit/4cfb91f1ef1b136f82015b792d6f1fafd47fd437 DIFF: https://github.com/llvm/llvm-project/commit/4cfb91f1ef1b136f82015b792d6f1fafd47fd437.diff

[PATCH] D71414: [clangd] Introduce codeblocks

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Follow-up to the patch D71248 Repository: rG LLVM Github

[PATCH] D71083: [Diagnsotics] Small Improvement on -Wmisleading-indentation

This revision was automatically updated to reflect the committed changes. Tyker marked an inline comment as done. Closed by commit rG9c8cfa09d762: [Diagnsotics] Small Improvement on -Wmisleading-indentation (authored by Tyker). Herald added a project: clang. Herald added a subscriber:

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 created this revision. usaxena95 added a reviewer: hokein. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Adds macro references to the dynamic index. Tests added. Also exposed a new API to convert path to URI

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:261 + bool AcceptRight = Right != All.end() && !(Loc < Right->location()); + bool AcceptLeft = Right != All.begin() && !((Right -

[PATCH] D71356: [Tooling/Syntax] Helpers to find spelled tokens touching a location.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60699 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-format: pass. Build artifacts : console-log.txt

  1   2   3   >