[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62209 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[clang] 07c9d53 - [Alignment][NFC] Use Align with CreateAlignedLoad

Author: Guillaume Chatelet Date: 2020-01-27T10:58:36+01:00 New Revision: 07c9d5326648802560adbc1b1b61316c7d3c406d URL: https://github.com/llvm/llvm-project/commit/07c9d5326648802560adbc1b1b61316c7d3c406d DIFF:

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 marked 3 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; gribozavr2 wrote: >

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240506. njames93 added a comment. - added more unevaluated context checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files:

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240507. njames93 added a comment. - Elide braces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. I'm a little uncomfortable about all the tests changing, and I'm unsure if we should be changing the default behaviour. The rules in the past here was to show that this is part of a public style guide. The assumption here is google style wants this. Could you

[PATCH] D73418: [WPD] Emit vcall_visibility metadata for MicrosoftCXXABI

evgeny777 accepted this revision. evgeny777 added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73418/new/ https://reviews.llvm.org/D73418

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Use the latest offline version of cppreference. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73451

[clang-tools-extra] 70f4c6e - [clan-tidy] Fix false positive in bugprone-infinite-loop

Author: Adam Balogh Date: 2020-01-27T10:13:55+01:00 New Revision: 70f4c6e7b14f225f9628fbdab3620ce037613351 URL: https://github.com/llvm/llvm-project/commit/70f4c6e7b14f225f9628fbdab3620ce037613351 DIFF: https://github.com/llvm/llvm-project/commit/70f4c6e7b14f225f9628fbdab3620ce037613351.diff

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2685 + if (Args.hasArg(OPT_fsemantic_interposition)) +Opts.SemanticInterposition = 1; + MaskRay wrote: > `

[PATCH] D71966: [Wdocumentation][RFC] Improve identifier's of \param

gribozavr2 added a comment. In D71966#1840957 , @Mordante wrote: > So if I understand correctly: > > - `getParamNameAsWritten` will become `getArgText` > - The `getParamName` will do the translation from the name in the > documentation to the name in the

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 15 errors and 0 warnings

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 240486. serge-sans-paille added a comment. Improve & comment examples Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c9d5326648: [Alignment][NFC] Use Align with CreateAlignedLoad (authored by gchatelet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73449/new/

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. we seem to be missing some symbols now, like `polymorphic_allocator` `random_shuffle` `gets` etc. and there seems to be a functional change to the parser. Are they intentional, if so why? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG70f4c6e7b14f: [clan-tidy] Fix false positive in bugprone-infinite-loop (authored by baloghadamsoftware). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:387 + unless(inDecltypeOrTemplateArg()), + unless(hasAncestor(cxxNoexceptExpr(

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

baloghadamsoftware added a comment. Should I also commit it to the release 10.0 branch? This is a bugfix so it should be fixed in the release, I think. I added a dependency between this bug and the 10.0.0 release blockers. Is that enough? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73449: [Alignment][NFC] Use Align with CreateAlignedLoad

gchatelet created this revision. gchatelet added a reviewer: courbet. Herald added a reviewer: bollu. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This is patch is part of a series to introduce an Alignment type. See this thread for context:

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. This patch adds a simple mechanism to disallow global rename on std symbols. We might extend it to other

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr) (void)(expr); +struct S {}; njames93 wrote: > gribozavr2 wrote: > > Is the macro a necessary

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani created this revision. topisani added reviewers: kadircet, klimek. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Solves this issue: https://github.com/clangd/clangd/issues/157 This is my first contribution to an llvm

[PATCH] D73270: [clang-tidy] Fix false positive in bugprone-infinite-loop

gribozavr2 added a comment. Please talk to Hans Wennborg about cherry-picking this change into the release. I think it is a safe change, if Hans needs that sort of review from someone. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73270/new/

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin updated this revision to Diff 240510. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71460/new/ https://reviews.llvm.org/D71460 Files: clang/include/clang/Basic/OpenCLExtensions.def clang/lib/Headers/opencl-c.h clang/test/SemaOpenCL/extension-version.cl Index:

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:138 IsMainFileOnly = false; - bool IsIndexable = - isa(RenameDecl) && - SymbolCollector::shouldCollectSymbol( - cast(RenameDecl), RenameDecl.getASTContext(), -

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

gribozavr2 added a comment. Thank you for the contribution! I didn't review the code thoroughly yet, only the tests. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension)

[PATCH] D71460: [OpenCL] Fix support for cl_khr_mipmap_image_writes

AlexeySotkin marked 2 inline comments as done. AlexeySotkin added inline comments. Comment at: clang/lib/Headers/opencl-c.h:14686 +#if defined(cl_khr_mipmap_image_writes) +#pragma OPENCL EXTENSION cl_khr_mipmap_image_writes : begin void __ovld write_imagef(write_only image1d_t

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham created this revision. simon_tatham added reviewers: aaron.ballman, lebedev.ri. Herald added a project: clang. Herald added a subscriber: cfe-commits. The 'z' length modifier, signalling that an integer format specifier takes a `size_t` sized integer, is only supported by the C

[PATCH] D72932: [ARM] Follow AACPS standard for volatile bit-fields access width

ostannard added a comment. > It will require changing all possible initializations, with a sensible value. Where are you seeing multiple initializations? It looks like all of the logic for struct layout happens in `CGRecordLowering::lower`, we might need to add a pass there to calculate the

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 15 errors and 0 warnings

[PATCH] D73353: [clang-format] Handle escaped " in C# string-literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG36a8f7f6d8f5: [clang-format] Handle escaped in C# string-literals (authored by krasimir). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D73354: clang-format: insert trailing commas into containers.

krasimir added a comment. An alternative approach (I'm not endorsing this) that would *in theory* circumvent non-idempotency issue (but would be more fiddly~fiddly to implement and spill across different layers of the formatter): This is just a rough idea and can have multiple issues in itself.

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:466 auto DeclsUnderCursor = locateDeclAt(AST, IdentifierToken->location()); if (DeclsUnderCursor.empty()) kadircet wrote: > `locateDeclAt` is already working on

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240528. hokein marked 5 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files:

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

hokein updated this revision to Diff 240529. hokein added a comment. update the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73450/new/ https://reviews.llvm.org/D73450 Files: clang-tools-extra/clangd/refactor/Rename.cpp

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey created this revision. awpandey added reviewers: probinson, aprantl, dblaikie. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. This patch provides support for //DW_AT_default_value// based on template parameter is default parameter or

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 marked an inline comment as done. Jac1494 added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4598 + if (!(DebugKind == clang::codegenoptions::FullDebugInfo)) +return; aprantl wrote: > nit: > > ``` > if (DebugKind <

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73463 Files:

[PATCH] D73463: [clangd] use SCOPED_TRACE to better trace the testcase in test failure, NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62207 tests passed, 1 failed and 815 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp {icon check-circle

[PATCH] D71451: Support to emit extern variables debuginfo with "-fstandalone-debug"

Jac1494 added a comment. In D71451#1817334 , @aprantl wrote: > In D71451#1816269 , @Jac1494 wrote: > > > ping > > > I'd be curious to the answer to David's questions. If the size increase is > because of unused

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73450: [clangd] Add a symbol-name-based blacklist for rename.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62202 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

njames93 updated this revision to Diff 240512. njames93 added a comment. - Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73441/new/ https://reviews.llvm.org/D73441 Files:

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein updated this revision to Diff 240520. hokein added a comment. refine the code to avoid confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73451/new/ https://reviews.llvm.org/D73451 Files: clang-tools-extra/clangd/CSymbolMap.inc

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

hokein added a comment. In D73451#1841510 , @kadircet wrote: > we seem to be missing some symbols now, like `polymorphic_allocator` > `random_shuffle` `gets` etc. yeap, two majoir reasons: - some symbols

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

gribozavr2 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) njames93 wrote: > gribozavr2 wrote: > > I think we should consider

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with fixes to the test. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:1276 +namespace PR44667 { +#define REQUIRE(expr)

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62206 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked 2 inline comments as done. njames93 added a comment. I'll work up those other test cases Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension)

[PATCH] D73441: [clang-tidy] Fix bugprone-use-after-move when move is in noexcept operator

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62207 tests passed, 0 failed and 815 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running

[clang] 0a57d14 - [ASTMatchers] Fix parent traversal with InitListExpr

Author: Stephen Kelly Date: 2020-01-27T11:19:59Z New Revision: 0a57d14abf99333fbfab15fb918a863aa391 URL: https://github.com/llvm/llvm-project/commit/0a57d14abf99333fbfab15fb918a863aa391 DIFF: https://github.com/llvm/llvm-project/commit/0a57d14abf99333fbfab15fb918a863aa391.diff

[PATCH] D73451: [clangd] Update the include mappings for std symbols.

kadircet added a comment. In D73451#1841595 , @hokein wrote: > In D73451#1841510 , @kadircet wrote: > > > we seem to be missing some symbols now, like `polymorphic_allocator` > > `random_shuffle` `gets` etc. > > >

[clang] 36a8f7f - [clang-format] Handle escaped " in C# string-literals

Author: Krasimir Georgiev Date: 2020-01-27T12:57:20+01:00 New Revision: 36a8f7f6d8f5a9620b1a091e54abacb517ecfbba URL: https://github.com/llvm/llvm-project/commit/36a8f7f6d8f5a9620b1a091e54abacb517ecfbba DIFF:

[PATCH] D73464: [clang] Add TagDecl AST matcher

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh, hokein, JonasToth. f00kat added a project: clang. Herald added a subscriber: cfe-commits. In this case https://reviews.llvm.org/D73090#1840501 @aaron.ballman suggest to add new AST matcher for tagDecl to avoid using

[PATCH] D73380: [clang] Annotating C++'s `operator new` with more attributes

lebedev.ri updated this revision to Diff 240530. lebedev.ri marked an inline comment as done. lebedev.ri added a comment. For the sake of forward progress, remove overly optimistic alignment annotation, and replace it with FIXME. I have some ideas how to deal with that, but i'd prefer to deal

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:29 + + bool isHeader() const { +return llvm::StringSwitch(Extension) gribozavr2 wrote: > njames93

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. Hi @topisani, thanks for working on clangd! Yes that bug fell through the cracks since the logs proposed in the comments were not making use of `-query-driver` option. Do you mind adding some logs to the bug report, without your patch so that we can clearly see its

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 updated this revision to Diff 240611. njames93 marked 6 inline comments as done. njames93 added a comment. - Tweaked default corresponding header settings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73413/new/

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. Herald added a subscriber: ormris. Can you add a bitcode roundtrip test to test/Assembler? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462/new/ https://reviews.llvm.org/D73462

[PATCH] D73062: [analyzer] Simplify BoolAssignmentChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rG88c7b1642079: [analyzer] Simplify BoolAssignmentChecker (authored by Mikhail Gadelha mikhail.gade...@sidia.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 240643. topisani marked an inline comment as done. topisani added a comment. Addressed CR comments I'm sure about the tests, I basically just added to the one test that already exists that it passes one of each "type" of preservable argument. CHANGES

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 xazax.hun wrote: > Strictly speaking, this is implementation defined. But the C11 > implementations I am aware of are following this trend

[PATCH] D73098: [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

njames93 added a comment. May need to roll this back, I think as i had this on the same local branch as D73052 I have brought both of them in at once Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73098/new/

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240657. void added a comment. Use GNU asm predicate for the "asm goto with outputs" extension. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files:

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void added a comment. In D73319#1842900 , @nickdesaulniers wrote: > Great idea; thanks for the patch! Needs documentation. :) I can't find a place for documentation of extensions, at least not the names of extensions like `gnu_asm`.

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

void updated this revision to Diff 240663. void marked 2 inline comments as done. void added a comment. Move extension test to exsiting test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73319/new/ https://reviews.llvm.org/D73319 Files:

[PATCH] D71913: [LTO/WPD] Enable aggressive WPD under LTO option

tejohnson added a comment. In D71913#1837872 , @tejohnson wrote: > FYI I reverted this in rG90e630a95ecc > due to > a cfi test failure in a windows sanitizer bot. Not sure what is

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. This is the original version of the (complete) checker, but now outdated: https://reviews.llvm.org/D71510 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham marked an inline comment as done. simon_tatham added inline comments. Comment at: clang/lib/AST/FormatString.cpp:754 + LO.isMSCompatibilityVersionSpecified() && + !LO.isCompatibleWithMSVC(LangOptions::MSVC2015)) { +// The standard libraries

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 240638. mibintc added a comment. rebase per @sepavloff request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 Files: clang/docs/LanguageExtensions.rst

[clang] 88c7b16 - [analyzer] Simplify BoolAssignmentChecker

Author: Mikhail Gadelha Date: 2020-01-27T14:51:35-04:00 New Revision: 88c7b1642079439a73b4d7a6e57e67347f574a15 URL: https://github.com/llvm/llvm-project/commit/88c7b1642079439a73b4d7a6e57e67347f574a15 DIFF:

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. LGTM!~ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 ___ cfe-commits mailing list

[clang] c98d98b - [analyzer] Fix handle leak false positive when the handle dies too early

Author: Gabor Horvath Date: 2020-01-27T09:52:06-08:00 New Revision: c98d98ba9b0f917385c753becec4ddfef51bc47c URL: https://github.com/llvm/llvm-project/commit/c98d98ba9b0f917385c753becec4ddfef51bc47c DIFF: https://github.com/llvm/llvm-project/commit/c98d98ba9b0f917385c753becec4ddfef51bc47c.diff

[PATCH] D73439: [ASTMatchers] Add cxxNoexceptExpr AST matcher

njames93 updated this revision to Diff 240640. njames93 added a comment. - Tweak documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73439/new/ https://reviews.llvm.org/D73439 Files: clang/docs/LibASTMatchersReference.html

[clang-tools-extra] 27e3671 - [clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions

Author: Nathan Date: 2020-01-27T19:23:21Z New Revision: 27e3671ff49b72640f89c34a415412e400503442 URL: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442 DIFF: https://github.com/llvm/llvm-project/commit/27e3671ff49b72640f89c34a415412e400503442.diff LOG:

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

aprantl added a comment. In D73261#1838683 , @probinson wrote: > In D73261#1838552 , @djtodoro wrote: > > > > Is it necessary to use DIFlags? I am willing to do that but generally, it > > > is not welcomed because

[clang-tools-extra] c72a6ac - Revert "[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions"

Author: Shoaib Meenai Date: 2020-01-27T11:50:25-08:00 New Revision: c72a6ac4b630d2344dbea44a7d75fa61795dcd76 URL: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76 DIFF: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76.diff

[PATCH] D73500: [driver] Add a -builtininc flag that lets Darwin driver include Clang builtin headers even with -nostdinc

arphaman created this revision. arphaman added a reviewer: dexonsmith. Herald added subscribers: ributzka, jkorous. Herald added a project: clang. Some projects use -nostdinc, but need to access some intrinsics files when building specific files. The new `-builtininc` flag lets them use this

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 61841 tests passed, 5 failed and 780 were skipped. failed: libc++.std/language_support/cmp/cmp_partialord/partialord.pass.cpp failed: libc++.std/language_support/cmp/cmp_strongeq/cmp.strongeq.pass.cpp

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun marked 2 inline comments as done. xazax.hun added inline comments. Comment at: clang/test/Analysis/c11lock.c:7 +enum { + thrd_success = 0, + thrd_error = 2 Strictly speaking, this is implementation defined. But the C11 implementations I am aware of

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

simon_tatham updated this revision to Diff 240626. simon_tatham added a comment. Removed the special case for `MSCompatibilityVersion == 0`. If the default compatibility setting needs to be changed, that's a separate piece of work and should be done by someone who understands more than I do

[PATCH] D72829: Implement -fsemantic-interposition

MaskRay added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:488 + if (Context.getLangOpts().SemanticInterposition && + (Context.getLangOpts().PICLevel && !Context.getLangOpts().PIE)) +// Require various optimization to respect semantic interposition.

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun added a comment. In D73376#1839818 , @NoQ wrote: > I don't see any immediate solutions to the boilerplate that don't consist in > introducing better checker APIs. Eg., we could have introduced a > `LazyBugType` - a wrapper around `Optional`

[clang] 2d0b29e - [clang] Fix covered default in switch

Author: Jinsong Ji Date: 2020-01-27T19:28:11Z New Revision: 2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 URL: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46 DIFF: https://github.com/llvm/llvm-project/commit/2d0b29e0de5b2fd7cc05e8a341db3bf460e18d46.diff LOG:

[PATCH] D72705: [clang][checkers] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. I wanted to use the existing infrastructure (ExprEngine) to test what conditions are applied to the function return value. I did not found other way to get this information. So the checker observes what checks are applied to the return value by making assumptions on

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/MissingHeaderFileDeclarationCheck.cpp:75 + continue; +if (AnyHeader || File->NamePart.equals_lower(ThisFile->NamePart)) + return; // Found a good candidate for matching decl

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

aprantl added a comment. Thanks! > define a new DIFlag bit That seems to be a good idea. Also please make sure to add a bitcode roundtrip test to test/Assembler/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73261/new/ https://reviews.llvm.org/D73261

[PATCH] D73493: [AArch64][SVE] Add SVE2 intrinsics for uniform DSP operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr, cameron.mcinally. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. Implements the following intrinsics: - sqrdmlah, sqrdmlsh, sqrdmulh &

[PATCH] D73151: [analyzer] Fix handle leak false positive when the handle dies too early

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98d98ba9b0f: [analyzer] Fix handle leak false positive when the handle dies too early (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

amccarth added a comment. In D73457#1842493 , @simon_tatham wrote: > Removed the special case for `MSCompatibilityVersion == 0`. If the default > compatibility setting needs to be changed, that's a separate piece of work > and should be done by someone

[PATCH] D73319: Add extension 'gnu_asm_goto_with_outputs'

nickdesaulniers added a comment. Great idea; thanks for the patch! Needs documentation. :) Comment at: clang/test/Parser/asm-goto-with-outputs.c:7 +#error Extension 'gnu_asm_goto_with_outputs' should be available by default +#endif + probably don't need a

[PATCH] D73457: [Clang] Warn about 'z' printf modifier in old MSVC.

aaron.ballman added reviewers: rnk, majnemer, zturner. aaron.ballman added a comment. Adding some more Windows reviewers to see if there are more opinions on how to handle this. Comment at: clang/lib/AST/FormatString.cpp:754 + LO.isMSCompatibilityVersionSpecified()

[PATCH] D73261: [dwarf5] Support DebugInfo for constexpr for C++ variables and functions

dblaikie added a comment. General question: What purpose do you (or anyone else - @probinson, @aprantl) have for this attribute? I'd like to encourage the idea that we don't need to implement every feature DWARF provides if there's no planned use for it - things can/should be implemented

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

andrew.w.kaylor added a comment. It's not clear to me from reading this how the "precise" control is going to work with relation to the fast math flags. I don't think MSVC allows the granularity of control over these flags that we have in clang, so maybe they don't have this problem. Consider

[PATCH] D73376: [analyzer] Add FuchsiaLockChecker and C11LockChecker

xazax.hun updated this revision to Diff 240650. xazax.hun added a comment. - Add a FIXME. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73376/new/ https://reviews.llvm.org/D73376 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[clang] e6d2583 - [OPENMP50]Track changes of lastprivate conditional in parallel-based

Author: Alexey Bataev Date: 2020-01-27T14:53:25-05:00 New Revision: e6d2583e45ef3af7646d4a58bada2e639121 URL: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121 DIFF: https://github.com/llvm/llvm-project/commit/e6d2583e45ef3af7646d4a58bada2e639121.diff

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:467-475 +// We will use llvm-objcopy to add target objects’ sections to the output +// fat object. These sections should have ‘exclude’ flag set which tells +// link

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62197 tests passed, 0 failed and 815 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

  1   2   3   >