[PATCH] D69978: Separately track input and output denormal mode

arsenm closed this revision. arsenm added a comment. a3c814d23497bc71b8ed53c35f773366aff02922 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69978/new/ https://reviews.llvm.org/D69978 __

[clang] a3c814d - Separately track input and output denormal mode

Author: Matt Arsenault Date: 2020-02-04T12:59:21-05:00 New Revision: a3c814d23497bc71b8ed53c35f773366aff02922 URL: https://github.com/llvm/llvm-project/commit/a3c814d23497bc71b8ed53c35f773366aff02922 DIFF: https://github.com/llvm/llvm-project/commit/a3c814d23497bc71b8ed53c35f773366aff02922.diff

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts : diff.json

[clang] fce1eef - [clang] fix lib/ASTMatchers for BUILD_SHARED_LIBS=ON

Author: Stephen Neuendorffer Date: 2020-02-04T09:54:28-08:00 New Revision: fce1eefb467e2bc3cd737ce78386e4970beefb7a URL: https://github.com/llvm/llvm-project/commit/fce1eefb467e2bc3cd737ce78386e4970beefb7a DIFF: https://github.com/llvm/llvm-project/commit/fce1eefb467e2bc3cd737ce78386e4970beefb7

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn updated this revision to Diff 242363. john.brawn added a comment. Move DefaultParsedAttrInfo out of file scope, and move custom appertains-to function generation out of the loop in EmitClangAttrParsedAttrImpl so we only need to use one output stream. CHANGES SINCE LAST ACTION http

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a subscriber: hans. aaronpuchert added a comment. @hans, could you cherry-pick this on the version 10 branch? As I wrote in D68923#1857046 , this is a regression from Clang 8. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73975: [clang][NFC] Expand some `auto`s and add another test for matcher `isExpandedFromMacro`.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73975/new/ https://reviews.llvm.org/D73975 _

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

This revision was automatically updated to reflect the committed changes. Closed by commit rG2513118afa38: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73937/new/ https:/

[PATCH] D73975: [clang][NFC] Expand some `auto`s and add another test for matcher `isExpandedFromMacro`.

ymandel created this revision. ymandel added a reviewer: aaron.ballman. Herald added a project: clang. Spells out some `auto`s explicitly and adds another test for the matcher `isExpandedFromMacro`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73975 Files: clang/include/c

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

MaskRay updated this revision to Diff 242359. MaskRay added a comment. Rename to fmax_tokens_EQ as a convention Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73937/new/ https://reviews.llvm.org/D73937 Files: clang/include/clang/Basic/DiagnosticG

[clang] 2513118 - [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

Author: Fangrui Song Date: 2020-02-04T09:39:48-08:00 New Revision: 2513118afa385b9df3662050e3aa0a1e3f5e2a8a URL: https://github.com/llvm/llvm-project/commit/2513118afa385b9df3662050e3aa0a1e3f5e2a8a DIFF: https://github.com/llvm/llvm-project/commit/2513118afa385b9df3662050e3aa0a1e3f5e2a8a.diff

[PATCH] D73900: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata

This revision was automatically updated to reflect the committed changes. Closed by commit rG9271cab270a5: [BPF] use base lvalue type for preserve_{struct,union}_access_index metadata (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] 9271cab - [BPF] use base lvalue type for preserve_{struct, union}_access_index metadata

Author: Yonghong Song Date: 2020-02-04T09:28:30-08:00 New Revision: 9271cab270a52b5200ef45a16f1a9d9baaccaba0 URL: https://github.com/llvm/llvm-project/commit/9271cab270a52b5200ef45a16f1a9d9baaccaba0 DIFF: https://github.com/llvm/llvm-project/commit/9271cab270a52b5200ef45a16f1a9d9baaccaba0.diff

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani added a comment. In D73453#1857095 , @kadircet wrote: > let me know if you need me to commit this. Yes please, thanks for your time! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 _

[PATCH] D73965: [clang] Add matcher to identify macro expansions.

ymandel added a comment. Aaron -- I missed your comments before submitting. I'll send a follow up with fixes. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73965/new/ https://reviews.llvm.org/D73965 _

[PATCH] D73965: [clang] Add matcher to identify macro expansions.

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:313-317 + auto& Context = Finder->getASTContext(); + auto B = + internal::getExpansionLocOfMacro(MacroName, Node.getBeginLoc(), Context); + if (!B) return false; + auto E = ---

[PATCH] D73965: [clang] Add matcher to identify macro expansions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG386fd2c170a7: [clang] Add matcher to identify macro expansions. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73965/new/ https://revi

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

NoQ added a comment. Thanks!! Comment at: clang/docs/ReleaseNotes.rst:408 + +- New checker: ``alpha.plusplus.PlacementNew`` to detect whether the storage + provided for default placement new is sufficiently large. I think this one's out of alpha already (i.e.,

[clang] 386fd2c - [clang] Add matcher to identify macro expansions.

Author: Yitzhak Mandelbaum Date: 2020-02-04T11:43:06-05:00 New Revision: 386fd2c170a78798a097650b8714183d5a9d93c6 URL: https://github.com/llvm/llvm-project/commit/386fd2c170a78798a097650b8714183d5a9d93c6 DIFF: https://github.com/llvm/llvm-project/commit/386fd2c170a78798a097650b8714183d5a9d93c6.

[PATCH] D65050: [SemaTemplate] Mark a function type as dependent when its parameter list contains pack expansion

cpplearner added a comment. ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65050/new/ https://reviews.llvm.org/D65050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaron.ballman added a comment. In D68923#1857046 , @aaronpuchert wrote: > In D68923#1853527 , @aaronpuchert > wrote: > > > In D68923#1853303 , @aaron.ballman > > wrote: >

[PATCH] D73960: [clangd] Don't assert when completing a lambda variable inside the lambda.

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2629035a0090: [clangd] Don't assert when completing a lambda variable inside the lambda. (authored by sammccall). Changed prior to commit: https://reviews.llv

[clang-tools-extra] 2629035 - [clangd] Don't assert when completing a lambda variable inside the lambda.

Author: Sam McCall Date: 2020-02-04T17:24:26+01:00 New Revision: 2629035a009095f62f48413e175437261165ecd7 URL: https://github.com/llvm/llvm-project/commit/2629035a009095f62f48413e175437261165ecd7 DIFF: https://github.com/llvm/llvm-project/commit/2629035a009095f62f48413e175437261165ecd7.diff LO

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:141 +static ParsedAttrInfo DefaultParsedAttrInfo; static const ParsedAttrInfo &getInfo(const ParsedAttr &A) { aaron.ballman wrote: > Might

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

xazax.hun added inline comments. Comment at: clang/docs/ReleaseNotes.rst:429 + +- Numerous smaller false positive fixes. I'd just say `Numerous smaller fixes.` or `Numerous other improvements.` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 2f4c4d0 - Reland "[clangd] Mechanism to make update debounce responsive to rebuild speed."

Author: Sam McCall Date: 2020-02-04T17:17:53+01:00 New Revision: 2f4c4d0a78e352e33f903d96f406999753d23e07 URL: https://github.com/llvm/llvm-project/commit/2f4c4d0a78e352e33f903d96f406999753d23e07 DIFF: https://github.com/llvm/llvm-project/commit/2f4c4d0a78e352e33f903d96f406999753d23e07.diff LO

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17254 +SourceLocation(), Context.getTranslationUnitDecl()); + } rjmccall wrote: > yaxunl wrote: > > rjmccall wrote: > > > Thanks, this looks

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall marked an inline comment as done. sammccall added a comment. In D73873#1857042 , @thakis wrote: > I agree it's a bit strange. The linux bot didn't recover after the revert > either, so something's amiss. > > My Win bot has been hanging since thi

[PATCH] D72189: [SystemZ] Support -msoft-float

jonpa added a comment. In D72189#1857098 , @thakis wrote: > Hello, this breaks tests on all platforms (e.g.: > http://45.33.8.238/mac/7170/step_11.txt) Please revert immediately and please > run tests locally before committing next time. I have added t

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; tejohnson wrote: > evgeny777 wrote: > > tejohnson wrote: > > > evgeny777 wrote:

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks let me know if you need me to commit this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 __

[PATCH] D72189: [SystemZ] Support -msoft-float

thakis added a comment. Hello, this breaks tests on all platforms (e.g.: http://45.33.8.238/mac/7170/step_11.txt) Please revert immediately and please run tests locally before committing next time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D721

[clang] e943329 - [SystemZ] Add 'REQUIRES:' or '-mtriple' to some newly added tests.

Author: Jonas Paulsson Date: 2020-02-04T10:52:10-05:00 New Revision: e943329ba00772f96fbc1fe5dec836cfd0707a38 URL: https://github.com/llvm/llvm-project/commit/e943329ba00772f96fbc1fe5dec836cfd0707a38 DIFF: https://github.com/llvm/llvm-project/commit/e943329ba00772f96fbc1fe5dec836cfd0707a38.diff

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

rjmccall added a comment. In D72742#1854594 , @emilio wrote: > Could anyone update me with how do they want me to proceed here? Is fixing > the coercions enough to allow this to land? Do I need to make it > target-specific? It needs to be target-specif

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

rjmccall added a comment. One minor request, but otherwise LGTM; feel free to commit with that change. Comment at: clang/lib/Sema/SemaExpr.cpp:17254 +SourceLocation(), Context.getTranslationUnitDecl()); + } yaxunl wrote: > rjmccall wrote: > > Thanks,

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, we can go with this for now, since it does fix a bug. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360 ___

[PATCH] D72189: [SystemZ] Support -msoft-float

This revision was automatically updated to reflect the committed changes. Closed by commit rG563e84790f41: [SystemZ] Support -msoft-float (authored by jonpa). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73960: [clangd] Don't assert when completing a lambda variable inside the lambda.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1007 Result.Quality = Signal; -Result.IDForDoc = -Result.Signature.documentation.empt

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

topisani updated this revision to Diff 242334. topisani added a comment. Woops yeah, still getting used to using git like this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 Files: clang-tools-extra/clangd/QueryDriverDatabase.cpp clang-tool

[PATCH] D73965: [clang] Add matcher to identify macro expansions.

ymandel updated this revision to Diff 242335. ymandel added a comment. Fix to get it to link correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73965/new/ https://reviews.llvm.org/D73965 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[clang] 563e847 - [SystemZ] Support -msoft-float

Author: Jonas Paulsson Date: 2020-02-04T10:32:45-05:00 New Revision: 563e84790f41f9f71c3cb10d0bb9feaa7a339c36 URL: https://github.com/llvm/llvm-project/commit/563e84790f41f9f71c3cb10d0bb9feaa7a339c36 DIFF: https://github.com/llvm/llvm-project/commit/563e84790f41f9f71c3cb10d0bb9feaa7a339c36.diff

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

thakis added a comment. I agree it's a bit strange. The linux bot didn't recover after the revert either, so something's amiss. My Win bot has been hanging since this landed and I just CRD'd in and it's hanging in check-clangd and there are tens of ClangdTests processes hanging around and doin

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaronpuchert added a comment. In D68923#1853527 , @aaronpuchert wrote: > In D68923#1853303 , @aaron.ballman > wrote: > > > I think it's a simple enough fix that it may be worth it, but it isn't > > fixing a regre

[PATCH] D73453: Preserve -nostdinc and --sysroot when calling query driver

kadircet added a comment. it seems like the last diff is same as the previous one, maybe you've uploaded the wrong diff ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73453/new/ https://reviews.llvm.org/D73453 ___ cfe-commits mailing list

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

Szelethus created this revision. Szelethus added reviewers: hans, NoQ, Charusso, xazax.hun, baloghadamsoftware, balazske, gamesh411, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, phosek, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szele

[PATCH] D59105: [RFC] Create an Arbitrary Precision Integer Type.

erichkeane abandoned this revision. erichkeane added a comment. Superceded by: https://reviews.llvm.org/D73967 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59105/new/ https://reviews.llvm.org/D59105 ___ cfe-commits mailing list cfe-commits

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane created this revision. erichkeane added reviewers: martong, aaron.ballman, mgehre, mibintc, mikhail.ramalho, arichardson, dmgreen, ebevhan, riccibruno. Herald added subscribers: arphaman, rnkovacs, kosarev. Introduction/Motivation: LLVM-IR supports integers of non-power-of-2 bitwidth,

[PATCH] D73966: [analyzer][WIP] Add 10.0.0 release notes.

Szelethus added a reviewer: dcoughlin. Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/docs/ReleaseNotes.rst:427 + +- ObjectiveC++ changes: + I tried my best here but didn't get far. :) Repository: rG LLVM Github

[PATCH] D73965: [clang] Add matcher to identify macro expansions.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. This revision adds a matcher `isExpandedFromMacro` that determines whether a statement is (transitively) expanded from a given macro. Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

DavidTruby requested changes to this revision. DavidTruby added a comment. This revision now requires changes to proceed. If what I've suggested above doesn't work then the patch lgtm as is Comment at: clang/lib/Driver/Driver.cpp:131 CCLogDiagnostics(false), CCGenDiagnos

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

sammccall added a comment. In D73873#1856880 , @thakis wrote: > This seems to break tests: http://45.33.8.238/linux/9296/step_9.txt Thanks, I've reverted to take a look. It's weird though: - don't see this on any lab buildbots or locally - the lit test

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware updated this revision to Diff 242323. baloghadamsoftware added a comment. `const SVal &` -> `SVal` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73720/new/ https://reviews.llvm.org/D73720 Files: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp clang/test/A

[PATCH] D73720: [Analyzer] Use note tags to track container begin and and changes

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:731 + } + return C.getNoteTag([Text, Name](BugReport &BR) -> std::string { + SmallString<256> Msg; ---

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet added a comment. In D73780#1851920 , @hokein wrote: > In D73780#1851654 , @kadircet wrote: > > > LG. I might be missing some context though, what's the reasoning behind? > > Because, I think it is not nece

[clang-tools-extra] ed98994 - Revert "[clangd] Mechanism to make update debounce responsive to rebuild speed."

Author: Sam McCall Date: 2020-02-04T15:34:10+01:00 New Revision: ed98994f64b8fe6443aef57a5faa953e86d9fc0e URL: https://github.com/llvm/llvm-project/commit/ed98994f64b8fe6443aef57a5faa953e86d9fc0e DIFF: https://github.com/llvm/llvm-project/commit/ed98994f64b8fe6443aef57a5faa953e86d9fc0e.diff LO

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rG69a39dc1f0d0: [clangd] Increase stack size of the new threads on macOS (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D50993?vs=200432&id=242319#toc Repository: rG LLVM Gi

[PATCH] D73245: Depend stddef.h to provide max_align_t for C++11 and provide better fallback in

joerg updated this revision to Diff 242317. joerg retitled this revision from "Don't define std::max_align_t if not used in C++03 mode" to "Depend stddef.h to provide max_align_t for C++11 and provide better fallback in ". joerg edited the summary of this revision. Herald added a subscriber: kryt

[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

sammccall added a comment. Herald added a subscriber: usaxena95. Sorry we let this last piece get stuck in limbo, of course I was reminded of it when someone else hit this problem. Thanks for working on this @Dmitry.Kozhevnikov, I'll update for c++14 and (finally) land it now. Repository: r

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson marked an inline comment as done. tejohnson added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1678 +// breaks any uses on assumes. +if (TypeIdMap.count(TypeId)) + continue; evgeny777 wrote: > tejohnson wrote:

[clang-tools-extra] 69a39dc - [clangd] Increase stack size of the new threads on macOS

Author: Sam McCall Date: 2020-02-04T15:21:27+01:00 New Revision: 69a39dc1f0d08ea43bac03a87bb8bff3937ce2e7 URL: https://github.com/llvm/llvm-project/commit/69a39dc1f0d08ea43bac03a87bb8bff3937ce2e7 DIFF: https://github.com/llvm/llvm-project/commit/69a39dc1f0d08ea43bac03a87bb8bff3937ce2e7.diff LO

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

thakis added a comment. This seems to break tests: http://45.33.8.238/linux/9296/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73873/new/ https://reviews.llvm.org/D73873 ___ cfe-commits mail

[PATCH] D73960: [clangd] Don't assert when completing a lambda variable inside the lambda.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62439 tests passed, 0 failed and 845 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added a comment. In D73775#1856848 , @alexeyr wrote: > In D73775#1856765 , @aaron.ballman > wrote: > > > In D73775#1851553 , @alexeyr wrote: > > > > > Also I a

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia updated this revision to Diff 242312. Anastasia added a comment. Add warning into `IncompatiblePointerTypesDiscardsQualifiers` group. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. In D73775#1856765 , @aaron.ballman wrote: > In D73775#1851553 , @alexeyr wrote: > > > Also I am not sure why, but the ranges added to the diagnostic in lines > > 1222-1226 don't show up in

[PATCH] D73960: [clangd] Don't assert when completing a lambda variable inside the lambda.

sammccall created this revision. sammccall added reviewers: kadircet, kbobyrev. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a fairly ugly hack - we back off several features for any variable whose type isn't d

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added inline comments. Comment at: llvm/lib/Passes/PassBuilder.cpp:1380 + // in ICP (which is performed earlier than this in the regular LTO pipeline). + MPM.addPass(LowerTypeTestsPass(nullptr, nullptr, true)); tejohnson wrote: > evgeny777 wrote: >

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman added a comment. In D73775#1851553 , @alexeyr wrote: > Also I am not sure why, but the ranges added to the diagnostic in lines > 1222-1226 don't show up in the message. Do you mean that there are no squiggly underlines under the range, or

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 242300. yaxunl marked 5 inline comments as done. yaxunl added a comment. revised by Anastasia's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17254 +SourceLocation(), Context.getTranslationUnitDecl()); + } rjmccall wrote: > Thanks, this looks a lot better. > > Should this be moved to SemaOpenMP.cpp (and renamed to be Open

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl updated this revision to Diff 242296. yaxunl marked 4 inline comments as done. yaxunl added a comment. revised by John's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/S

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used") LANGOPT(N

[PATCH] D73951: [Clang] Add logic to search for flang frontend

CarolineConcatto created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. This patch adds more logic to Flang.cpp to search for the flang frontend. A new flag(ffc-fortran-name) was created in this patch to implement the logic in Flang driver. Th

[PATCH] D73949: [clangd] Debounce rebuilds responsively to rebuild times.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62438 tests passed, 0 failed and 845 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook updated this revision to Diff 242286. simoncook added a comment. Switch to using `Optional` for returning version numbers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73891/new/ https://reviews.llvm.org/D73891 Files: clang/include/cl

[PATCH] D73949: [clangd] Debounce rebuilds responsively to rebuild times.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Old: 500ms always. New: rebuild time, up to 500ms. Fixes https://github.com/clangd/clangd/iss

[PATCH] D73873: [clangd] Mechanism to make update debounce responsive to rebuild speed.

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG92570718a86c: [clangd] Mechanism to make update debounce responsive to rebuild speed. (authored by sammccall). Changed prior to commit: https://reviews.llvm.o

[clang-tools-extra] 9257071 - [clangd] Mechanism to make update debounce responsive to rebuild speed.

Author: Sam McCall Date: 2020-02-04T12:28:20+01:00 New Revision: 92570718a86cc4c23108b596002114ab25857b14 URL: https://github.com/llvm/llvm-project/commit/92570718a86cc4c23108b596002114ab25857b14 DIFF: https://github.com/llvm/llvm-project/commit/92570718a86cc4c23108b596002114ab25857b14.diff LO

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

This revision was automatically updated to reflect the committed changes. Closed by commit rG7128aace600f: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ ht

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

simon_tatham added a comment. I wonder if it's worth temporarily redefining all the existing `AEK_FOO` ids to values that don't fit in 32 bits, and making sure the whole test suite still passes. That should catch any remaining cases where an integer type should have been widened. CHANGES SINC

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki added a comment. In D73906#1856615 , @simon_tatham wrote: > I wonder if it's worth temporarily redefining all the existing `AEK_FOO` ids > to values that don't fit in 32 bits, and making sure the whole test suite > still passes. That should catch

[clang] 7128aac - [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

Author: Mikhail Maltsev Date: 2020-02-04T11:24:18Z New Revision: 7128aace600f29c81f735c3b1d3f5f51464c4630 URL: https://github.com/llvm/llvm-project/commit/7128aace600f29c81f735c3b1d3f5f51464c4630 DIFF: https://github.com/llvm/llvm-project/commit/7128aace600f29c81f735c3b1d3f5f51464c4630.diff LO

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added a comment. In D73354#1854115 , @mprobst wrote: > This has landed as https://reviews.llvm.org/rGa324fcf1ae6 (not sure why this > hasn't closed automatically). Thank you, as for not autoclosing my guess it because perhaps you dropped

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 ___ cfe-commits mailing list cf

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia added a comment. In D73360#1852147 , @rjmccall wrote: > If it's reasonable to persist the failure kind, that would probably be good, > but it might be a lot of work. I have looked at it earlier and it indeed affects a lot of Sema in C++ mode.

[PATCH] D73906: [ARM] Make ARM::ArchExtKind use 64-bit underlying type, NFCI

miyuki updated this revision to Diff 242277. miyuki added a comment. More missing unsigned->uint64_t changes, removed a redundant `getAEKID` function (identical to `parseArchExt`). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73906/new/ https://reviews.llvm.org/D73906 Files: clang/

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

Anastasia added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:914 + // + // OpenCL C++ 1.0 v2.1-11 s2.9: + // recursive function calls (ISO C++ Section 5.2.2, item 9) unless Can we remove reference to OpenCL C++ since it's not implemen

[clang] 89b8b42 - [OpenCL] Tidy up OpenCLBuiltins.td

Author: Sven van Haastregt Date: 2020-02-04T10:56:53Z New Revision: 89b8b42184745ee31992275194b925b1b1e3d5b6 URL: https://github.com/llvm/llvm-project/commit/89b8b42184745ee31992275194b925b1b1e3d5b6 DIFF: https://github.com/llvm/llvm-project/commit/89b8b42184745ee31992275194b925b1b1e3d5b6.diff

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

simoncook marked 2 inline comments as done. simoncook added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:50 +static bool isExperimentalExtension(StringRef Ext) { + // Currently 'b' is the only supported experimental extension rogfer0

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

hans added a comment. In D7#1849326 , @hans wrote: > > I created D73680 to place the patch label > > after BTI. > > > > @hans Is there still time to cherry pick the patch to release/10.x? See > > above, Linux develo

[PATCH] D73937: [Driver] Change -fmax-tokens $arg to -fmax-tokens=$arg

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thank for noticing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73937/new/ https://reviews.llvm.org/D73937

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:50 +static bool isExperimentalExtension(StringRef Ext) { + // Currently 'b' is the only supported experimental extension Suggestion: I think we can avoid these two functions

<    1   2