[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. In D72231#1879347 , @rjmccall wrote: > Warning about casting to an enum seems clearly correct and in scope for this > warning. Warning about casting to `_Bool` seems clearly incorrect and should > not be warned about at

[clang] 8b9cb12 - [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

Author: Nick Desaulniers Date: 2020-02-18T15:33:46-08:00 New Revision: 8b9cb120812449dbe67d2252ebf619c4c9cac816 URL: https://github.com/llvm/llvm-project/commit/8b9cb120812449dbe67d2252ebf619c4c9cac816 DIFF:

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added a comment. In D74801#1881693 , @lebedev.ri wrote: > While i certainly agree that it's kinda confusing, i'm not really sure this > is conceptually correct change. >

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis updated this revision to Diff 245295. baziotis edited the summary of this revision. baziotis added a comment. Self-cycle to self-loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801 Files:

[PATCH] D74769: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74769/new/ https://reviews.llvm.org/D74769

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis marked an inline comment as done. baziotis added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1

[PATCH] D72825: Remove unused option that gcc ignored

This revision was automatically updated to reflect the committed changes. Closed by commit rGea789f819f26: Remove unused option that gcc ignored (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! I can't see this being a performance problem (famous last words...) Comment at: clang/lib/Sema/SemaCodeComplete.cpp:8780 + + // We need to manually

[PATCH] D74807: Add cl_khr_mipmap_image_writes as supported to AMDGPU

yaxunl created this revision. yaxunl added a reviewer: b-sumner. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D74807 Files: clang/lib/Basic/Targets/AMDGPU.h Index: clang/lib/Basic/Targets/AMDGPU.h

[clang-tools-extra] 28728bf - Fix a signed/unsigned warning promoted to error.

Author: Eric Christopher Date: 2020-02-18T17:49:22-08:00 New Revision: 28728bf06f556dc8be5bc1fa77129906ba68 URL: https://github.com/llvm/llvm-project/commit/28728bf06f556dc8be5bc1fa77129906ba68 DIFF:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245260. nickdesaulniers added a comment. - add explicit target and spacing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [Driver] -pg shouldn't unconditionally add -mframe-pointer=all w/ -mfentry

nickdesaulniers added inline comments. Comment at: clang/test/Driver/mfentry.c:6 +// RUN: %clang -target x86_64-linux-gnu -pg -mfentry -O2 -fno-omit-frame-pointer -### -E %s 2>&1 | FileCheck -check-prefix=FP --implicit-check-not='"-mframe-pointer=none"' %s +// RUN: %clang

[clang] e28d9ba - PR44958: Allow member calls and typeid / dynamic_cast on mutable objects

Author: Richard Smith Date: 2020-02-18T14:57:13-08:00 New Revision: e28d9bae4b3be60e90daa69a2eeb3254c952e051 URL: https://github.com/llvm/llvm-project/commit/e28d9bae4b3be60e90daa69a2eeb3254c952e051 DIFF: https://github.com/llvm/llvm-project/commit/e28d9bae4b3be60e90daa69a2eeb3254c952e051.diff

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

nridge added a comment. Thanks for looking at this! Sorry for the late response, I was travelling for a few weeks. So far I've only had a chance to look at the tests. Comment at: clang/test/CodeCompletion/concepts.cpp:34 + // RUN: | FileCheck %s -check-prefix=DOT

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

baziotis added a subscriber: jdoerfert. baziotis added a comment. In D74801#1881679 , @efriedma wrote: > Seems fine. Great, thanks and to @jdoerfert! Any way I can find the correct reviewers next time? Repository: rG LLVM Github Monorepo CHANGES

[clang] 24ad121 - Add -std=c++20 flag, replace C++2a with C++20 throughout the Clang

Author: Richard Smith Date: 2020-02-18T16:16:37-08:00 New Revision: 24ad121582454e625bdad125c90d9ac0dae948c8 URL: https://github.com/llvm/llvm-project/commit/24ad121582454e625bdad125c90d9ac0dae948c8 DIFF: https://github.com/llvm/llvm-project/commit/24ad121582454e625bdad125c90d9ac0dae948c8.diff

[clang] 492d4a9 - [NFC] Update the testcase clang_f_opts.c for the removed options

Author: Jim Lin Date: 2020-02-19T09:28:41+08:00 New Revision: 492d4a992d88516da471b60ecd9a37ea80dbf9a4 URL: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4 DIFF: https://github.com/llvm/llvm-project/commit/492d4a992d88516da471b60ecd9a37ea80dbf9a4.diff LOG:

[PATCH] D74790: [Sema][CodeComplete] Handle symlinks for include code completion

dgoldman updated this revision to Diff 245256. dgoldman added a comment. - Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74790/new/ https://reviews.llvm.org/D74790 Files: clang/lib/Sema/SemaCodeComplete.cpp

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on this change. I see it's been reverted (thank you). Please cc me on the updated patch and I can help test it against the Linux kernel. Edit: Link:

[PATCH] D70876: [clang-tidy] Add spuriously-wake-up-functions check

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, do you need me to commit on your behalf? Comment at: clang-tools-extra/test/clang-tidy/bugprone-spuriously-wake-up-functions.c:165 +int main() { return 0; } \ No newline at end of file

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245265. nickdesaulniers added a comment. - s/gnu-linux/linux-gnu/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245263. nickdesaulniers added a comment. - use -### -E and check for -mframe-pointer={all|none} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

nickdesaulniers updated this revision to Diff 245264. nickdesaulniers added a comment. - drop -o - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files: clang/lib/Driver/ToolChains/Clang.cpp

[clang] cf45742 - [hexagon] Fix testcase issue with windows builder.

Author: Sid Manning Date: 2020-02-18T16:36:38-06:00 New Revision: cf4574299a279beeb8acb894583962ec0f41286c URL: https://github.com/llvm/llvm-project/commit/cf4574299a279beeb8acb894583962ec0f41286c DIFF: https://github.com/llvm/llvm-project/commit/cf4574299a279beeb8acb894583962ec0f41286c.diff

[PATCH] D74795: Make diagnostic reporting more robust in presence of corrupt PCH data.

neilmacintosh created this revision. neilmacintosh added reviewers: modocache, doug.gregor, hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, dexonsmith, ilya-biryukov. Herald added a project: clang. When running clangd, I found that occasionally, accessing a precompiled header

[PATCH] D74698: [Driver] -pg shouldn't unconditionally add -mframe-pointer=all w/ -mfentry

nickdesaulniers updated this revision to Diff 245274. nickdesaulniers added a comment. - drop implicit-check-nots, add check for no os target Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74698/new/ https://reviews.llvm.org/D74698 Files:

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Seems fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74801/new/ https://reviews.llvm.org/D74801

[clang] ea789f8 - Remove unused option that gcc ignored

Author: Jim Lin Date: 2020-02-19T08:36:07+08:00 New Revision: ea789f819f26a1b003a1bf07466fc9fa2fe558ec URL: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec DIFF: https://github.com/llvm/llvm-project/commit/ea789f819f26a1b003a1bf07466fc9fa2fe558ec.diff LOG:

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall marked 3 inline comments as done. sammccall added inline comments. Comment at: clang/lib/Sema/CodeCompleteConsumer.cpp:592 } +for (const FixItHint : Results[I].FixIts) { + const SourceLocation BLoc = FixIt.RemoveRange.getBegin(); (This

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1881797 , @nickdesaulniers wrote: > In D72231#1881784 , @rjmccall wrote: > > > In D72231#1881760 , > > @nickdesaulniers wrote: > > > >

[PATCH] D74698: [CodeGen] -pg shouldn't unconditionally add "frame-pointer"="all" fn attr w/ -mfentry

MaskRay added inline comments. Comment at: clang/test/Driver/mfentry.c:5 +// RUN: %clang -pg -mfentry -O0 -emit-llvm -S -o - %s | FileCheck -check-prefix=FP --implicit-check-not='"frame-pointer"="none"' %s +// RUN: %clang -pg -mfentry -O2 -fno-omit-frame-pointer -emit-llvm -S

[PATCH] D74724: [AArch64][SVE] CodeGen of ACLE Builtin Types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74724/new/ https://reviews.llvm.org/D74724 ___ cfe-commits mailing list

[PATCH] D72825: Remove unused option that gcc ignored

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72825/new/ https://reviews.llvm.org/D72825

[PATCH] D74801: [ADT] SCCIterator: Change hasLoop() to hasCycle()

baziotis created this revision. baziotis added reviewers: dexonsmith, lattner, timshen, chandlerc. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya. Herald added projects: clang, LLVM. Not a super important change but yesterday I had to look in this function and initially

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added a comment. While i certainly agree that it's kinda confusing, i'm not really sure this is conceptually correct change. https://en.wikipedia.org/wiki/Loop_(graph_theory) > In graph theory, a loop (also called a self-loop or a "buckle") is an edge > that connects a vertex to

[PATCH] D74698: [Driver] -pg -mfentry should respect target specific decisions for -mframe-pointer=all

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b9cb1208124: [Driver] -pg -mfentry should respect target specific decisions for -mframe… (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74801: [ADT][NFC] SCCIterator: Change hasLoop() to hasCycle()

lebedev.ri added inline comments. Comment at: llvm/tools/opt/PrintSCC.cpp:82-83 errs() << (*I)->getName() << ", "; -if (nextSCC.size() == 1 && SCCI.hasLoop()) - errs() << " (Has self-loop)."; +if (nextSCC.size() == 1 && SCCI.hasCycle()) + errs() << "

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1879347 , @rjmccall wrote: > In D72231#1878528 , @nathanchance > wrote: > > > There appear to a be semantic difference between GCC and clang with the > > current version

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

rjmccall added a comment. In D72231#1881760 , @nickdesaulniers wrote: > In D72231#1879347 , @rjmccall wrote: > > > In D72231#1878528 , @nathanchance > > wrote: > > > > >

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1881784 , @rjmccall wrote: > In D72231#1881760 , @nickdesaulniers > wrote: > > > In D72231#1879347 , @rjmccall > > wrote: > > >

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L added a comment. In D74015#1880847 , @cebowleratibm wrote: > From my perspective, the only issue holding this up is settling on the name. > I'd like to hammer that out and get this committed. It looks everyone agrees on `XL` so far. As

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal updated this revision to Diff 245300. steakhal added a comment. Upload the right diff. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74806/new/ https://reviews.llvm.org/D74806 Files: clang/lib/StaticAnalyzer/Checkers/CStringChecker.cpp

[PATCH] D74806: [analyzer] NFCi: Refactor CStringChecker: use strongly typed internal API

steakhal created this revision. steakhal added reviewers: NoQ, baloghadamsoftware, Szelethus. steakhal added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nickdesaulniers added a comment. In D72231#1881855 , @rjmccall wrote: > No, I understand the pattern, but they must have already done some sort of > pass over the code to make it warning-clean when they're working with a > smaller integer type. Or do

[PATCH] D74811: [Driver] Escape the program path for -frecord-command-line

ravi-ramaseshan created this revision. ravi-ramaseshan added reviewers: scott.linder, rjmccall. Herald added a project: clang. Similar to the rest of the command line that is recorded, the program path must also have spaces and backslashes escaped. Without this parsing the recorded command line

[PATCH] D72231: [Sema] Adds the pointer-to-int-cast diagnostic

nathanchance added a comment. In D72231#1881855 , @rjmccall wrote: > In D72231#1881797 , @nickdesaulniers > wrote: > > > In D72231#1881784 , @rjmccall > > wrote: > > > > >

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

This revision was automatically updated to reflect the committed changes. Closed by commit rG048239e46e49: [Coroutines][6/6] Clang schedules new passes (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/

[clang] 061f3a5 - P0593R6: Pseudo-destructor expressions end object lifetimes.

Author: Richard Smith Date: 2020-02-18T18:41:03-08:00 New Revision: 061f3a50dd824f1eb2394d0f699f3f2ee374b21a URL: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a DIFF: https://github.com/llvm/llvm-project/commit/061f3a50dd824f1eb2394d0f699f3f2ee374b21a.diff

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

aganea added a comment. There seems to be still an issue with this patch, when linking the LLVM unit tests on a two-stage build, it ends with: FAILED: tools/clang/unittests/StaticAnalyzer/StaticAnalysisTests.exe cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E vs_link_exe

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs created this revision. jroelofs added reviewers: efriedma, weimingz, EricWF. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Fixes: https://bugs.llvm.org/show_bug.cgi?id=35527 https://bugs.llvm.org/show_bug.cgi?id=35528 Repository: rG LLVM

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. It's been almost a month since the last comments on this review. If you need more time, please comment here. Otherwise, I will submit this with the current approvals by the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 048239e - [Coroutines][6/6] Clang schedules new passes

Author: Brian Gesiak Date: 2020-02-19T01:03:28-05:00 New Revision: 048239e46e490d441f21f3e26073ec38f19e8a10 URL: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10 DIFF: https://github.com/llvm/llvm-project/commit/048239e46e490d441f21f3e26073ec38f19e8a10.diff

[PATCH] D74812: [Sema] Teach -Warm-interrupt-safety about func ptrs

jroelofs marked an inline comment as done. jroelofs added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:5931 + if (Caller->hasAttr()) { +const Decl *CalleeDecl = FDecl; +if (const auto *UO = dyn_cast(Fn->IgnoreParens())) { This

[PATCH] D69868: Allow "callbr" to return non-void values

jdoerfert added a comment. In D69868#1881985 , @void wrote: > It's been almost a month since the last comments on this review. If you need > more time, please comment here. Otherwise, I will submit this with the > current approvals by the end of the

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

kbobyrev updated this revision to Diff 245331. kbobyrev added a comment. Add pipe and single quote to commit characters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/ https://reviews.llvm.org/D74606 Files:

[PATCH] D74814: IR printing for single function with the new pass manager.

hoyFB created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. hoyFB added a reviewer: wenlei. hoyFB added a subscriber: wenlei. The IR printing always prints out all functions in a module with the new pass manager, even with

[clang-tools-extra] 2a095ff - [clangd] Add add commit characters to the server capabilities

Author: Kirill Bobyrev Date: 2020-02-19T08:32:00+01:00 New Revision: 2a095ff6f5028b7612dae50358a2f6939b6cdc9f URL: https://github.com/llvm/llvm-project/commit/2a095ff6f5028b7612dae50358a2f6939b6cdc9f DIFF:

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a095ff6f502: [clangd] Add add commit characters to the server capabilities (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74606/new/

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille updated this revision to Diff 245327. serge-sans-paille added a comment. Take @Meinersbur review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757 Files:

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv created this revision. alexbdv added reviewers: MaskRay, vsk, JonasToth, ruiu. Herald added a project: clang. Herald added a subscriber: cfe-commits. Function blocks don't have a name specified in source code. Currently their symbol name is based on the parent function's name and an

[PATCH] D74766: [ARM] Fixing range checks for Neon's vqdmulhq_lane and vqrdmulhq_lane intrinsics

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. The range checks performed for the vqrdmulh_lane and vqrdmulh_lane Neon intrinsics were incorrectly using their return type as the base type for the range check performed on their

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. It looks like this broke the windows lldb bot: lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/13902 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D74763: [libTooling] Add option for `buildAST` to report diagnostics.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Currently, `buildAST[WithArgs]` either succeeds or fails. This patch adds support for the caller to pass a `DiagnosticConsumer` to receive all relevant diagnostics. Repository: rG LLVM Github

[clang] 523cae3 - [libTooling] Add option for `buildAST` to report diagnostics.

Author: Yitzhak Mandelbaum Date: 2020-02-18T09:11:51-05:00 New Revision: 523cae324d79d2e532d2be797058a94e8214ec45 URL: https://github.com/llvm/llvm-project/commit/523cae324d79d2e532d2be797058a94e8214ec45 DIFF:

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

Xiangling_L marked an inline comment as done. Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74763: [libTooling] Add option for `buildAST` to report diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG523cae324d79: [libTooling] Add option for `buildAST` to report diagnostics. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74763/new/

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew created this revision. andrew added a reviewer: Sanitizers. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls, krytarowski, arichardson, dberris, emaste. Herald added projects: clang, Sanitizers, LLVM. Add support for asan, msan, and tsan on FreeBSD on aarch64.

[PATCH] D74562: [OpenMP][OMPIRBuilder] Introducing the `OMPBuilderCBHelpers` helper class

fghanim updated this revision to Diff 245151. fghanim added a comment. addressing review comments - Adding a comment to explain minor change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74562/new/ https://reviews.llvm.org/D74562 Files:

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew marked an inline comment as done. andrew added inline comments. Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux_libcdep.cpp:451-463 +# if defined(__aarch64__) || defined(__mips__) +// Variant I +// +// dtv = segbase[0]; +// dtv[2] = base of

[PATCH] D74765: [compiler-rt] Addd FreeBSD arm64 sanitizer support

andrew updated this revision to Diff 245152. andrew marked an inline comment as done. andrew added a comment. Remove unintended changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74765/new/ https://reviews.llvm.org/D74765 Files:

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Thanks for reporting that, are you sure this was the cause of the failure? I'll revert this while investigate, but it does not seem to me this is related to this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

daltenty added a comment. In D74631#1876995 , @sfertile wrote: > 1. We should probably update the COMDAT section of the lang ref to mention > XCOFF doesn't support COMDATS. I will update the langref as suggested. > 2. Will we report an error somewhere

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:436 case CXXConstructExpr::CK_Complete: { +assert(CE && "Complete constructors cannot be inherited!"); std::tie(State, Target) = baloghadamsoftware wrote: >

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

rjmccall added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + ebevhan wrote: > rjmccall wrote: > > leonardchan wrote: > > > ebevhan wrote: > > > > rjmccall wrote: > > > > > ebevhan

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

stella.stamenova added a comment. I am not sure this was the cause of the failure, but other than your patches, there was only one other change in the first failing build. I have not had time to fully investigate yet. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/

[clang] 260b91f - Use getLocation() in "too few/too many arguments" diagnostic

Author: John Marshall Date: 2020-02-18T11:23:17-05:00 New Revision: 260b91f379c8f86d3d6008648b3f2a945a007888 URL: https://github.com/llvm/llvm-project/commit/260b91f379c8f86d3d6008648b3f2a945a007888 DIFF: https://github.com/llvm/llvm-project/commit/260b91f379c8f86d3d6008648b3f2a945a007888.diff

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

I've commit on your behalf in 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! ~Aaron On Mon, Feb 10, 2020 at 12:42 PM Aaron Ballman wrote: > > On Mon, Feb 10, 2020 at 10:06 AM John Marshall > wrote: > > > > Thanks Aaron (and Hubert). > > > > I've attached an updated patch

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

NoQ marked 2 inline comments as done. NoQ added a comment. In D74735#1880617 , @baloghadamsoftware wrote: > In D74735#1880390 , @xazax.hun wrote: > > > If the AST is hard to work with would it make sense to try to

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On 18 Feb 2020, at 16:24, Aaron Ballman wrote: > > I've commit on your behalf in > 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! Thanks very much, Aaron. I regret to report that this appears to have broken an additional test [1] that I didn't see when running the test

[clang] 66c0162 - Hopefully fixing a failing build bot.

Author: Aaron Ballman Date: 2020-02-18T11:39:23-05:00 New Revision: 66c01627719f088bff9a0d09655a8ca0842b2c82 URL: https://github.com/llvm/llvm-project/commit/66c01627719f088bff9a0d09655a8ca0842b2c82 DIFF: https://github.com/llvm/llvm-project/commit/66c01627719f088bff9a0d09655a8ca0842b2c82.diff

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

On Tue, Feb 18, 2020 at 11:37 AM John Marshall wrote: > > On 18 Feb 2020, at 16:24, Aaron Ballman wrote: > > > > I've commit on your behalf in > > 260b91f379c8f86d3d6008648b3f2a945a007888, thank you for the patch! > > Thanks very much, Aaron. > > I regret to report that this appears to have

[clang-tools-extra] 5e7d0eb - Cover cases like (b && c && b) in the redundant expression check.

Author: Alexey Romanov Date: 2020-02-18T11:42:32-05:00 New Revision: 5e7d0ebf735a8b70f92acd1f91c7c45423e611cc URL: https://github.com/llvm/llvm-project/commit/5e7d0ebf735a8b70f92acd1f91c7c45423e611cc DIFF:

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:436 case CXXConstructExpr::CK_Complete: { +assert(CE && "Complete constructors cannot be inherited!"); std::tie(State, Target) = NoQ wrote: > martong wrote: >

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

aaron.ballman closed this revision. aaron.ballman added a comment. In D73775#1875921 , @alexeyr wrote: > @aaron.ballman I just noticed this in > https://mlir.llvm.org/getting_started/Contributing/ > > > Note: if you haven’t used Arcanist to send your

[PATCH] D74473: [analyzer] StdLibraryFunctionsChecker: Use platform dependent EOF and UCharMax

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CheckerHelpers.cpp:114-117 + const auto MacroIt = llvm::find_if( + PP.macros(), [&](const auto ) { return K.first->getName() == Macro; }); + if (MacroIt ==

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. Nice! Thank you for making these changes. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + rjmccall wrote: > The attribute here is `CUDAGlobalAttr`; should this be named in terms of > CUDA, or is the CUDA model

Re: [PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

How did you come to this conclusion? https://buildkite.com/mlir/mlir-core/builds/2790#9ecce42d-5a20-4e52-8621-c7c0dcee7aa7 is a clean build at e8e078c8bf7987b95298062a644bac9eed26f988 that is just before 1b978ddba05cb15e22b4e75adb5e7362ad861987 (if I look at commits on github) and at

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

cebowleratibm added a comment. From my perspective, the only issue holding this up is settling on the name. I'd like to hammer that out and get this committed. Comment at: clang/include/clang/Basic/TargetCXXABI.h:116 +/// - static initialization is adjusted to use

[PATCH] D74757: Fix compiler extension in standalone mode

serge-sans-paille added a comment. Tested without standalone build with polly linked statically and dynamically with success. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74757/new/ https://reviews.llvm.org/D74757

[PATCH] D74757: Fix compiler extension in standalone mode

Meinersbur added a comment. The Windows pre-merge check seem to have failed? Comment at: llvm/cmake/modules/AddLLVM.cmake:886 # process_llvm_pass_plugins([NO_GEN]) # Change to `[GEN_CONFIG]` Comment at:

[clang] 63809d3 - [ARM,MVE] Add vbrsrq intrinsics family

Author: Mikhail Maltsev Date: 2020-02-18T17:31:21Z New Revision: 63809d365e56512b1b6eac6065547f523d10dbf0 URL: https://github.com/llvm/llvm-project/commit/63809d365e56512b1b6eac6065547f523d10dbf0 DIFF: https://github.com/llvm/llvm-project/commit/63809d365e56512b1b6eac6065547f523d10dbf0.diff

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

miyuki updated this revision to Diff 245187. miyuki added a comment. Rebased on master CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74721/new/ https://reviews.llvm.org/D74721 Files: clang/include/clang/Basic/arm_mve.td clang/test/CodeGen/arm-mve-intrinsics/vbrsrq.c

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

jfb added a comment. In D74361#1879559 , @rjmccall wrote: > I'm not sure if it's a good idea to be re-using the existing attribute like > this. It's not that unreasonable, I guess, but I'd like to hear JF's > thoughts. The current uninitialized

[PATCH] D74721: [ARM,MVE] Add vbrsrq intrinsics family

This revision was automatically updated to reflect the committed changes. Closed by commit rG63809d365e56: [ARM,MVE] Add vbrsrq intrinsics family (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74721/new/

[clang] cd2c5af - Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on""

Author: Melanie Blower Date: 2020-02-18T06:55:36-08:00 New Revision: cd2c5af6dfd6e32ee7043894bcb42981ce99e8ac URL: https://github.com/llvm/llvm-project/commit/cd2c5af6dfd6e32ee7043894bcb42981ce99e8ac DIFF:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2549 + Opts.SYCLIsDevice = Opts.SYCL && Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) { +// -sycl-std applies to any SYCL source, not only those

[PATCH] D74769: [AArch64][SVE] Add SVE2 intrinsics for polynomial arithmetic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, dancgr, cameron.mcinally, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the following

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:562 llvm::json::Object{ + {"allCommitCharacters", "

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

baloghadamsoftware added a comment. In D74735#1880390 , @xazax.hun wrote: > If the AST is hard to work with would it make sense to try to change the AST > a bit? Hmm, you mean making `CXXConstructExpr` an abstract base with subclasses

<    1   2   3   >