[PATCH] D74483: [AArch64] Add Cortex-A34 Support for clang and llvm

2020-02-18 Thread Luke Geeson via Phabricator via cfe-commits
LukeGeeson closed this revision. LukeGeeson marked an inline comment as not done. LukeGeeson added inline comments. Comment at: llvm/unittests/Support/TargetParserTest.cpp:784 EXPECT_TRUE(testAArch64CPU( + "cortex-a34", "armv8-a", "crypto-neon-fp-armv8", +

[clang] 2bf44d1 - Revert "Reland "[DebugInfo] Enable the debug entry values feature by default""

2020-02-18 Thread Djordje Todorovic via cfe-commits
Author: Djordje Todorovic Date: 2020-02-18T16:38:11+01:00 New Revision: 2bf44d11cb42a952bdeb778210d8b3e737f0b96e URL: https://github.com/llvm/llvm-project/commit/2bf44d11cb42a952bdeb778210d8b3e737f0b96e DIFF:

[clang] 4518aab - [AArch64] Add Cortex-A34 Support for clang and llvm

2020-02-18 Thread Luke Geeson via cfe-commits
Author: Luke Geeson Date: 2020-02-18T14:56:16Z New Revision: 4518aab289a090a668af0ca4ecde976e18fb2b1e URL: https://github.com/llvm/llvm-project/commit/4518aab289a090a668af0ca4ecde976e18fb2b1e DIFF: https://github.com/llvm/llvm-project/commit/4518aab289a090a668af0ca4ecde976e18fb2b1e.diff LOG:

[PATCH] D73186: [AST] Add fixed-point multiplication constant evaluation.

2020-02-18 Thread Bevin Hansson via Phabricator via cfe-commits
ebevhan added inline comments. Comment at: clang/lib/Basic/FixedPoint.cpp:242 + } else +Overflowed = Result < Min || Result > Max; + rjmccall wrote: > leonardchan wrote: > > ebevhan wrote: > > > rjmccall wrote: > > > > ebevhan wrote: > > > > > ebevhan

[PATCH] D74116: [Sema][C++] Propagate conversion type in order to specialize the diagnostics

2020-02-18 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia updated this revision to Diff 245164. Anastasia retitled this revision from "[Sema][C++] Strawman patch to propagate conversion type in order to specialize the diagnostics" to "[Sema][C++] Propagate conversion type in order to specialize the diagnostics". Anastasia added a comment. -

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

2020-02-18 Thread Sid Manning via Phabricator via cfe-commits
sidneym created this revision. sidneym added reviewers: kparzysz, bcain. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider --sysroot when building the system c include paths. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74776 Files:

[PATCH] D74361: [Clang] Uninitialize attribute on global variables

2020-02-18 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. It zero initialises on x86, but perhaps by coincidence rather than guarantee. Fair enough regarding reuse of the existing attribute, I'll create a new one. Thanks for the pointers on additional cases to test for too. I'll return with an improved patch.

[PATCH] D68578: [HIP] Fix device stub name

2020-02-18 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + tra wrote: > rjmccall wrote: > > The attribute here is `CUDAGlobalAttr`; should this be named in terms of > > CUDA, or is the CUDA model sufficiently

[PATCH] D74776: [Hexagon] clang driver should consider --sysroot option when looking for includes

2020-02-18 Thread Brian Cain via Phabricator via cfe-commits
bcain accepted this revision. bcain added a comment. This revision is now accepted and ready to land. Herald added a subscriber: ormris. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74776/new/ https://reviews.llvm.org/D74776

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-02-18 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. I’ve already reverted the patch, but I’ll reland it again tomorrow. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___ cfe-commits mailing list

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

2020-02-18 Thread Stella Stamenova via Phabricator via cfe-commits
stella.stamenova added a comment. In D73534#1880790 , @stella.stamenova wrote: > I am not sure this was the cause of the failure, but other than your patches, > there was only one other change in the first failing build. I have not had > time to fully

[PATCH] D68578: [HIP] Fix device stub name

2020-02-18 Thread Artem Belevich via Phabricator via cfe-commits
tra added inline comments. Comment at: clang/include/clang/AST/GlobalDecl.h:40 + Stub = 1, +}; + rjmccall wrote: > tra wrote: > > rjmccall wrote: > > > The attribute here is `CUDAGlobalAttr`; should this be named in terms of > > > CUDA, or is the CUDA model

[PATCH] D74631: [clang][XCOFF] Indicate that XCOFF does not support COMDATs

2020-02-18 Thread David Tenty via Phabricator via cfe-commits
daltenty updated this revision to Diff 245201. daltenty added a comment. Herald added subscribers: aheejin, dschuff. - Update lang doc to indicate XCOFF doesn't support COMDAT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74631/new/

[PATCH] D74704: Support -fuse-ld=lld for riscv

2020-02-18 Thread Vlad Vereschaka via Phabricator via cfe-commits
vvereschaka added a comment. Hello @serge-sans-paille, looks like these changes broke the ARM builders: http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/4749 http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/4752 failed tests: - FAIL: Clang::riscv64-toolchain.c

<    1   2   3