[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

aaron.ballman added a comment. In D69560#1889483 , @whisperity wrote: > I'd rather not call them //false positive// because the definition of `false > positive` is ugly and mushy with regards to this check. This check attempts > to enforce an interface r

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75046/new/ https://reviews.llvm.org/D75046

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

jdoerfert added a comment. In D74925#1889185 , @JonChesterfield wrote: > Cool. Can we reasonably add the reproducible from 44893 to a regression > suite, in addition to these IR tests? It's written in C so would need to be > under clang's tests. Don

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

jdoerfert updated this revision to Diff 246256. jdoerfert marked an inline comment as done. jdoerfert added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add tests, addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur updated this revision to Diff 246260. xur added a comment. check if the -fdiscard-value-names explicitly in args (suggested by Jeroen and Serge) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files: clang/include/clang/Basic/DiagnosticDr

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam created this revision. cristian.adam added reviewers: yvvan, thakis, mstorsjo. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. This patch is a squash for: https://reviews.llvm.org/D74564 https://reviews.llvm.org/D74907 And a fix for the issue that got

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

dblaikie added a comment. In D74846#1888410 , @llunak wrote: > Upon further investigation it turns out I probably should not have enabled > those two places for PCH in D69778 at all, > since they do not deal with -fmodul

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

xur updated this revision to Diff 246265. xur added a comment. Uploaded a wrong patch in the last time. This is the correct one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org/D74878 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang

[clang] 7273284 - [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

Author: Craig Topper Date: 2020-02-24T12:07:21-08:00 New Revision: 727328433ad61b8c7acdd4d63e73241303a6beb7 URL: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7 DIFF: https://github.com/llvm/llvm-project/commit/727328433ad61b8c7acdd4d63e73241303a6beb7.diff

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

vingeldal added a comment. In D69560#1889719 , @aaron.ballman wrote: > In D69560#1889483 , @whisperity > wrote: > > > I'd rather not call them //false positive// because the definition of > > `false positive` is

[PATCH] D74268: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rG727328433ad6: [X86] Add back fmaddsub intrinsics to work towards fixing the strict fp… (authored by craig.topper). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver updated this revision to Diff 246277. zoecarver added a comment. - move verification to SemaChecking Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 Files: clang/lib/Sema/SemaChecking.cpp clan

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246279. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp llv

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM aside from the comments I made. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To = AlignedAttr::Cr

[PATCH] D66839: Fix stack address builtin for negative numbers

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://reviews.llvm.org/D66839 ___

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

NoQ added a comment. In D69662#1889545 , @Szelethus wrote: > Sorry for the slack :) > > One should never count on the invocation order of callback funcions in > between checkers. In fact, I'm not too sure that my patches affect this, but > I suspect that

[PATCH] D72841: [RFC] Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc updated this revision to Diff 246285. mibintc marked an inline comment as done. mibintc added a comment. This patch is code complete and ready for your review and consideration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

aaron.ballman added a comment. In D69560#1889925 , @vingeldal wrote: > Doesn't clang-tidy exclude warnings from system headers by default though? Third-party SDKs are not always brought in as system headers, unfortunately. Even ignoring system and third

[PATCH] D75057: Syndicate, test and fix base64 implementation

serge-sans-paille updated this revision to Diff 246290. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75057/new/ https://reviews.llvm.org/D75057 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp compiler-rt/lib/fuzzer/FuzzerUtil.cpp llv

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, guansong. Herald added a reviewer: jdoerfert. Herald added a project: clang. Base declaration in pointer arithmetic expression is determined by binary search with type information. Take "int *a, *b

[PATCH] D74941: [OpenMP] `omp begin/end declare variant` - part 1, parsing

aaron.ballman added inline comments. Comment at: clang/include/clang/Parse/Parser.h:2959 + /// if there was an error. + bool ParseOMPDeclareVariantMatchClause(SourceLocation Loc, OMPTraitInfo &TI); + This file is inconsistent currently, but it looks like `parse

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 246293. cchen added a comment. Remove redundant code in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75077/new/ https://reviews.llvm.org/D75077 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer = What about binary operator?

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno added a comment. Ping! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7616 dyn_cast(I->getAssociatedExpression()); + const auto *UO = dyn_cast(I->getAssociatedExpression()); bool IsPointer =

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75028/new/ https://reviews.llvm.org/D75028 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

arsenm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], I don't think you actually need to delete this. It should

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9965 "memory order clause '%0' is specified here">; +def err_omp_non_lvalue_in_map_or_motion_clauses: Error< + "expected lvalue with no function call in '#pragma omp target update' and

[PATCH] D71018: [ASTImporter] Improved import of TypeSourceInfo (TypeLoc)

shafik added a comment. A few comments and I would like @teemperor to give this a look as well but it looks good to me. Comment at: clang/lib/AST/ASTImporter.cpp:3281 + // Import the function parameters. + SmallVector Parameters; I am curious, why move thi

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15712 +const std::string RTS = RT->getCanonicalTypeInternal().getAsString(); +auto CntLayer = [](char c) { return c == '*' || c == '['; }; +size_t LLayerCnt

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen updated this revision to Diff 246304. cchen added a comment. Remove the counting in MapBaseChecker, instead, comparing the type of root with the type of LHS and RHS, and only visit the subtree having the same type as root. This scheme pass all the test I have. I'll add BinOp into components

[clang] c93112d - Validate argument passed to __builtin_frame_address and __builtin_return_address

Author: zoecarver Date: 2020-02-24T14:23:41-08:00 New Revision: c93112dc4f745b0455addb54bfe1c2f79b827c6d URL: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d DIFF: https://github.com/llvm/llvm-project/commit/c93112dc4f745b0455addb54bfe1c2f79b827c6d.diff LOG

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Current language seems fine. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74935/new/ https://reviews.llvm.org/D74935 _

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver closed this revision. zoecarver added a comment. Resolved by c93112dc4f745b0455addb54bfe1c2f79b827c6d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66839/new/ https://

[clang] 6980782 - Revert "Validate argument passed to __builtin_frame_address and __builtin_return_address"

Author: zoecarver Date: 2020-02-24T14:35:02-08:00 New Revision: 698078257285a044110620d7dab2fb4451a3fa29 URL: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29 DIFF: https://github.com/llvm/llvm-project/commit/698078257285a044110620d7dab2fb4451a3fa29.diff LOG

[PATCH] D66839: Fix stack address builtin for negative numbers

zoecarver reopened this revision. zoecarver added a comment. This revision is now accepted and ready to land. Reverted: 698078257285a044110620d7dab2fb4451a3fa29 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] e6f9cb0 - [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

Author: Nathan James Date: 2020-02-25T00:00:39Z New Revision: e6f9cb025cd765f422b51d01f4a5714db788b3a7 URL: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7 DIFF: https://github.com/llvm/llvm-project/commit/e6f9cb025cd765f422b51d01f4a5714db788b3a7.diff LOG:

[PATCH] D75046: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type

This revision was automatically updated to reflect the committed changes. Closed by commit rGe6f9cb025cd7: [docs] dump_ast_matchers strips internal::(Bindable)?Matcher from Result_type (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

njames93 updated this revision to Diff 246335. njames93 added a comment. - Rebase with trunk Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75040/new/ https://reviews.llvm.org/D75040 Files: clang/docs/LibASTMatchersReference.html clang/docs/too

[PATCH] D74996: [arcconfig] Delete subproject arcconfigs

This revision was automatically updated to reflect the committed changes. Closed by commit rGe34ddc09f464: [arcconfig] Delete subproject arcconfigs (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74996/new/ https://reviews.llvm.

[PATCH] D69868: Allow "callbr" to return non-void values

void marked 2 inline comments as done. void added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineBasicBlock.h:137 + /// List of indirect targets of the callbr of a basic block. + SmallPtrSet InlineAsmBrIndirectTargets; + nickdesaulniers wrote: >

[PATCH] D74925: [OpenMP][Opt] Combine `struct ident_t*` during deduplication

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Nice. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74925/new/ https://reviews.llvm.org/D74925

[PATCH] D75093: clang-cl: Add a `/showIncludes:user` flag.

thakis created this revision. thakis added a reviewer: hans. This flag is like /showIncludes, but it only includes user headers and omits system headers (similar to MD and MMD). The motivation is that projects that already track system includes though other means can use this flag to get consis

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang-Tidy's script

alexfh accepted this revision. alexfh added a comment. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] 5522e82 - [NFC] Cleaned up ASTMatchersInternal Code

Author: Nathan James Date: 2020-02-25T01:47:51Z New Revision: 5522e8296fc5a082ebfc2cd1904099b1ba0570d9 URL: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9 DIFF: https://github.com/llvm/llvm-project/commit/5522e8296fc5a082ebfc2cd1904099b1ba0570d9.diff LOG:

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use move semantics instead of copying for AST Matchers with parameters Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7509

[PATCH] D75097: [cc1as] Unset UseNamesOnTempLabels

MaskRay created this revision. MaskRay added a reviewer: efriedma. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to rL236642 . This fixes https://reviews.llvm.org/D74006#1890487 Repository: rG LLVM Github Monorepo https://re

[PATCH] D69868: Allow "callbr" to return non-void values

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c2a5ce33f0: Allow "callbr" to return non-void values (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org

[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144 def int_amdgcn_dispatch_ptr : - GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">, Intrinsic<[LLVMQualPointerType], [], arsenm wrote: >

[clang] 50cac24 - Support output constraints on "asm goto"

Author: Bill Wendling Date: 2020-02-24T18:51:29-08:00 New Revision: 50cac248773c3a023e8f6ceb9938bdd5e9f15da2 URL: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2 DIFF: https://github.com/llvm/llvm-project/commit/50cac248773c3a023e8f6ceb9938bdd5e9f15da2.diff

[PATCH] D69876: Support output constraints on "asm goto"

This revision was automatically updated to reflect the committed changes. Closed by commit rG50cac248773c: Support output constraints on "asm goto" (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/new/ https://reviews.llvm.org

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void updated this revision to Diff 246363. void added a comment. Explain what's going on in VisitGCCAsmStmt better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71314/new/ https://reviews.llvm.org/D71314 Files: clang/lib/Analysis/UninitializedV

[PATCH] D71314: Emit a warning if a variable is uninitialized in indirect ASM goto destination.

void marked an inline comment as done. void added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:856 +vals[VD] = MayUninitialized; } nickdesaulniers wrote: > Can you walk me through the logic of this function? > > I would assu

[clang] 3e9a7b2 - [ASTMatchers] Matcher macros with params move params instead of copying

Author: Nathan James Date: 2020-02-25T07:50:34Z New Revision: 3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa URL: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa DIFF: https://github.com/llvm/llvm-project/commit/3e9a7b2ba470bbe9cf3de3e4b15ba09dcfd206aa.diff LOG:

[clang] 6a0c066 - [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

Author: Nathan James Date: 2020-02-25T07:51:20Z New Revision: 6a0c066c6102cd463e8ad48881e91e596547507a URL: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a DIFF: https://github.com/llvm/llvm-project/commit/6a0c066c6102cd463e8ad48881e91e596547507a.diff LOG:

[PATCH] D69560: [clang-tidy] Add 'cppcoreguidelines-avoid-adjacent-arguments-of-same-type' check

vingeldal added a comment. In D69560#1890026 , @aaron.ballman wrote: > In D69560#1889925 , @vingeldal wrote: > > > Doesn't clang-tidy exclude warnings from system headers by default though? > > > Third-party SDKs a

[PATCH] D75096: [ASTMatchers] Matcher macros with params move params instead of copying

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e9a7b2ba470: [ASTMatchers] Matcher macros with params move params instead of copying (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D75040: [ASTMatchers] Adds a matcher called `hasAnyOperatorName`

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a0c066c6102: [ASTMatchers] Adds a matcher called `hasAnyOperatorName` (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D75040?vs=246335&id=246375#toc Repository: rG LLVM Git

<    1   2