[clang] d40afad - [git-clang-format] Fix typo in help message

Author: Jim Lin Date: 2020-03-02T18:16:35+08:00 New Revision: d40afadec0acd5f093a5f46fa2362312aef54189 URL: https://github.com/llvm/llvm-project/commit/d40afadec0acd5f093a5f46fa2362312aef54189 DIFF: https://github.com/llvm/llvm-project/commit/d40afadec0acd5f093a5f46fa2362312aef54189.diff LOG:

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

hans added a comment. In D69573#1900089 , @sylvestre.ledru wrote: > @MyDeveloperDay @hans what about adding this to the release notes? > I was trying clang-format 10 on Firefox code base and I noticed this change > which isn't documented in > >

[PATCH] D72911: clang-format: fix spacing in `operator const char*()`

hans added a comment. In D72911#1900091 , @sylvestre.ledru wrote: > @krasimir @MyDeveloperDay @hans Looks like it is a regression from > https://reviews.llvm.org/D72911 > and the fix isn't in 10.0rc2. > Should we take it? Seems pretty safe. I've

[clang-tools-extra] 071002f - [clang-tidy] Copy the Ranges field from the Diagnostic when creating the ClangTidyError

Author: Joe Turner Date: 2020-03-02T12:39:16+01:00 New Revision: 071002ffdb3f13fa3006618e7ee8277a75792df5 URL: https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5 DIFF: https://github.com/llvm/llvm-project/commit/071002ffdb3f13fa3006618e7ee8277a75792df5.diff

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

ymandel added a comment. In D75365#1900784 , @gribozavr2 wrote: > +1 to this fix. > > However, regarding `allOf` vs. `anyOf` semantics, since `optionally` always > succeeds, is there a difference between the two semantics? > > It seems to me that there

[PATCH] D75271: [analyzer][NFC] Change LangOptions to CheckerManager in the shouldRegister* functions.

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. I think this is straightforward after D75360 . This was my original attempt as well, but without D75360 it did not work. This solves the problem of

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield added a comment. The above patch composes sensibly with openmp, e.g. #include #pragma omp declare target int data __attribute__((no_zero_initializer)); #pragma omp allocate(data) allocator(omp_pteam_mem_alloc) #pragma omp end declare target @data = hidden

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:244 +bool Any = false; +// Clang allows duplicating virtual specifiers so check for multiple +// occurances. njames93 wrote: > kadircet wrote: > >

[clang] 8cdcbca - [CodeGen] avoid running the entire optimizer pipeline in clang test file; NFC

Author: Sanjay Patel Date: 2020-03-02T09:12:53-05:00 New Revision: 8cdcbcaa02e7055a6745f2c1bde003c47c91f79e URL: https://github.com/llvm/llvm-project/commit/8cdcbcaa02e7055a6745f2c1bde003c47c91f79e DIFF: https://github.com/llvm/llvm-project/commit/8cdcbcaa02e7055a6745f2c1bde003c47c91f79e.diff

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

sammccall added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:134 public: - HighlightingsBuilder(const SourceManager , - const LangOptions ) - : SourceMgr(SourceMgr), LangOpts(LangOpts) {} +

[PATCH] D75445: [ARM,MVE] Add the `vshlcq` intrinsics.

miyuki added a comment. FYI: I have raised https://github.com/google/llvm-premerge-checks/issues/141 (the premerge check machinery failed to apply the patch, but this is not reflected in the build status). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 9ad1099 - [clangd] No need to query ctor refs in cross-file rename.

Author: Haojian Wu Date: 2020-03-02T15:21:32+01:00 New Revision: 9ad109922450ce3519a5431c72cdc9d4c20a18bf URL: https://github.com/llvm/llvm-project/commit/9ad109922450ce3519a5431c72cdc9d4c20a18bf DIFF: https://github.com/llvm/llvm-project/commit/9ad109922450ce3519a5431c72cdc9d4c20a18bf.diff

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

j0le created this revision. j0le added a reviewer: compnerd. j0le added a project: clang. Herald added a subscriber: kristof.beyls. Hello everyone, this is my first patch to/for clang. I hope, I did everything right. If not, please tell me. I found this bug: If you execute the following

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:287 if (SM.getFileID(ArgStart) == SelFile) { - SourceLocation ArgEnd = SM.getTopMacroCallerLoc(Batch.back().location()); - return testTokenRange(SM.getFileOffset(ArgStart), -

[PATCH] D75445: [ARM,MVE] Add the `vshlcq` intrinsics.

simon_tatham updated this revision to Diff 247642. simon_tatham added a comment. clang-formatted the new C test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75445/new/ https://reviews.llvm.org/D75445 Files:

[PATCH] D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75456/new/ https://reviews.llvm.org/D75456 ___ cfe-commits mailing list

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:50-68 +struct StreamErrorState { + // The error state of an opened stream. + // EofError: EOF condition (feof returns true) + //

[PATCH] D75444: [ARM,MVE] Add the `vsbciq` intrinsics.

simon_tatham updated this revision to Diff 247641. simon_tatham added a comment. clang-formatted the code added to the C test source. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75444/new/ https://reviews.llvm.org/D75444 Files:

[PATCH] D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test

jbcoe updated this revision to Diff 247643. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75456/new/ https://reviews.llvm.org/D75456 Files: clang/lib/Format/FormatToken.h clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format/TokenAnnotator.cpp

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:210 + using ClangTidyCheck::ClangTidyCheck; + bool isLanguageVersionSupported(const LangOptions ) const final { +return LangOpts.C99; The `final` means that one

[PATCH] D75460: [clangd] Fix isInsideMainFile to be aware of preamble.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75460 Files:

[clang] c3af063 - [clang-format] Handle NullCoalescing and NullConditional operators in C#

Author: Jonathan Coe Date: 2020-03-02T13:55:54Z New Revision: c3af063c2bbfe5408d565ee4350c36fc1d0b2758 URL: https://github.com/llvm/llvm-project/commit/c3af063c2bbfe5408d565ee4350c36fc1d0b2758 DIFF: https://github.com/llvm/llvm-project/commit/c3af063c2bbfe5408d565ee4350c36fc1d0b2758.diff LOG:

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

huntergr updated this revision to Diff 247614. huntergr added a comment. - Removed the ) my editor helpfully added to the CHECK line - Added a test to declare_simd_aarch64.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/

[PATCH] D71110: [clangd] A tool to evaluate cross-file rename.

hokein updated this revision to Diff 247615. hokein added a comment. rebase to master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71110/new/ https://reviews.llvm.org/D71110 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247617. JonChesterfield added a comment. - Rename attribute, propose some documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/ https://reviews.llvm.org/D74361 Files:

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp:355 + template + void checkRealloc(CheckerContext , const CallExpr *CE, +ProgramStateRef State) const; The `CHECK_FN` could be used even here?

[PATCH] D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#

This revision was automatically updated to reflect the committed changes. Closed by commit rGc3af063c2bbf: [clang-format] Handle NullCoalescing and NullConditional operators in C# (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#

krasimir added a comment. Sorry, did the last round of comments not make sense? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75368/new/ https://reviews.llvm.org/D75368 ___ cfe-commits mailing list

[clang] 8a37b9e - [OpenCL] Remove spurious atomic_fetch_min/max builtins

Author: Sven van Haastregt Date: 2020-03-02T15:56:48Z New Revision: 8a37b9e61798ad6bb0e268d989c2f8b00a216414 URL: https://github.com/llvm/llvm-project/commit/8a37b9e61798ad6bb0e268d989c2f8b00a216414 DIFF: https://github.com/llvm/llvm-project/commit/8a37b9e61798ad6bb0e268d989c2f8b00a216414.diff

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added a comment. Is it sure that the signedness in the ranges is handled correctly? The EOF is a negative value but the `RangeInt` is unsigned type. The `tryExpandAsInteger` returns `int` too that is put into an unsigned `RangeInt` later. Probably it is better to use `APSInt` for the

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1901120 , @njames93 wrote: > In D75429#1901073 , @kadircet wrote: > > > In D75429#1901018 , @njames93 > > wrote: > > > > > - Fixed clang

[PATCH] D75461: Ignore macro expansions when scanning for fallthrough comments

tbaeder created this revision. tbaeder added a reviewer: tstellar. Herald added a project: clang. Herald added a subscriber: cfe-commits. When scanning for fallthrough comments, it's not useful to go to the definition of a macro. We instead only want to search at the expanded source code

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet updated this revision to Diff 247612. kadircet added a comment. - Add forgetten macroid check, before looking for an macroargexpansion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75447/new/ https://reviews.llvm.org/D75447 Files:

[PATCH] D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c4afce7024a: [clang-format] Rename CSharpNullConditionalSq and add missing test (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

njames93 marked an inline comment as done. njames93 added a comment. I suppose the only other way would be having another virtual function like inside the helper classes virtual bool additionalLanguageConstraints(const LangOptions& LangOpts) const { return true; } bool

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

gribozavr2 added a comment. +1 to this fix. However, regarding `allOf` vs. `anyOf` semantics, since `optionally` always succeeds, is there a difference between the two semantics? It seems to me that there should be no difference between `allOf(optionally(a), optionally(b))` vs.

[clang] 1e30845 - [CodeGen] avoid running the entire optimizer pipeline in clang test file; NFC

Author: Sanjay Patel Date: 2020-03-02T09:47:32-05:00 New Revision: 1e308452bf68b9576a76004de28307f0318ef9eb URL: https://github.com/llvm/llvm-project/commit/1e308452bf68b9576a76004de28307f0318ef9eb DIFF: https://github.com/llvm/llvm-project/commit/1e308452bf68b9576a76004de28307f0318ef9eb.diff

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:50-68 +struct StreamErrorState { + // The error state of an opened stream. + // EofError: EOF condition (feof returns true) + // OtherError: other (non-EOF) error (ferror returns

[clang] ad49765 - [OpenMP] Allow const parameters in declare simd linear clause

Author: Graham Hunter Date: 2020-03-02T14:54:14Z New Revision: ad497658d25a3616e4c57cf7d12e3497a1c66f35 URL: https://github.com/llvm/llvm-project/commit/ad497658d25a3616e4c57cf7d12e3497a1c66f35 DIFF: https://github.com/llvm/llvm-project/commit/ad497658d25a3616e4c57cf7d12e3497a1c66f35.diff

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added a comment. That said, my comments are not of the "over my dead body" kind ;) Comment at: clang/lib/CodeGen/CGCall.cpp:1828 + if (CodeGenOpts.BranchTargetEnforcement) { +FuncAttrs.addAttribute("branch-target-enforcement", "true"); + } I would

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

This revision was automatically updated to reflect the committed changes. Closed by commit rGad497658d25a: [OpenMP] Allow const parameters in declare simd linear clause (authored by huntergr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/

[PATCH] D74131: [analyzer][taint] Add isTainted debug expression inspection check

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! Feel free to commit as you're ready. Comment at: clang/lib/StaticAnalyzer/Checkers/ExprInspectionChecker.cpp:97 .Case("clang_analyzer_express",

[PATCH] D75181: [AArch64] Handle BTI/PAC in case of generated functions.

chill added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64AsmPrinter.cpp:200 +if (!F.hasFnAttribute("branch-target-enforcement")) + return false; +Attribute A = F.getFnAttribute("branch-target-enforcement"); chill wrote: >

[PATCH] D75365: [AST Matchers] Fix bug in 'optionally' matcher wherein all previous bindings are cleared when all inner matchers fail.

gribozavr2 added a comment. > I think the difference is in whether you continue with the submatchers after > a success. Allof does while anyof does not. Oh, the short-circuiting makes a difference! I see. +1 to making it non-variadic then. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D75456: [clang-format] Rename CSharpNullConditionalSq and add missing test

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rename CSharpNullConditionalSq to CSharpNullConditionalLSquare. Add test for spaces inside [] with C# Null conditionals.

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 updated this revision to Diff 247640. njames93 added a comment. - Fixed clang tidy warning, wont fix format as it's contradicting with the style of the rest of the function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

https://reviews.llvm.org/rG8cdcbcaa02e7 https://reviews.llvm.org/rG1e308452bf68 On Thu, Feb 27, 2020 at 6:29 PM Eric Christopher wrote: > Sure. That sounds great. Thanks! > > On Wed, Feb 26, 2020 at 10:45 AM Sanjay Patel > wrote: > >> To be clear - the test is checking IR instructions, but

[PATCH] D74910: [OpenCL] Remove spurious atomic_fetch_min/max builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a37b9e61798: [OpenCL] Remove spurious atomic_fetch_min/max builtins (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74910/new/

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 updated this revision to Diff 247620. njames93 added a comment. - Macro handling more in line with rest of clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D75439: [clangd] No need to query ctor refs in cross-file rename.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ad109922450: [clangd] No need to query ctor refs in cross-file rename. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75439/new/

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 updated this revision to Diff 247621. njames93 marked 3 inline comments as done. njames93 added a comment. - added virtual virtual Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75429/new/ https://reviews.llvm.org/D75429 Files:

[PATCH] D74973: [analyzer] StdLibraryFunctionsChecker refactor w/ inheritance

Szelethus added a comment. I have some high level questions, you have spent far more time with this code and I'm happy to be proven wrong! :) In D74973#1889188 , @martong wrote: > > Is really more kind of constraint needed than range constraint? > >

[PATCH] D75455: [clang-format] Allow nested [] in C# attributes

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Keep track of unpaired [] when identifying C# attribute lines Repository: rG LLVM Github Monorepo

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:287 if (SM.getFileID(ArgStart) == SelFile) { - SourceLocation ArgEnd = SM.getTopMacroCallerLoc(Batch.back().location()); - return

[clang] 9c4afce - [clang-format] Rename CSharpNullConditionalSq and add missing test

Author: Jonathan Coe Date: 2020-03-02T15:46:33Z New Revision: 9c4afce7024aa1fe4efe2631240d1d766b4ea257 URL: https://github.com/llvm/llvm-project/commit/9c4afce7024aa1fe4efe2631240d1d766b4ea257 DIFF: https://github.com/llvm/llvm-project/commit/9c4afce7024aa1fe4efe2631240d1d766b4ea257.diff LOG:

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 247652. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Address review comments, more test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 added a comment. In D75429#1901073 , @kadircet wrote: > In D75429#1901018 , @njames93 wrote: > > > - Fixed clang tidy warning, wont fix format as it's contradicting with the > > style of the rest of the

[PATCH] D75368: [clang-format] Handle NullCoalescing and NullConditional operators in C#

krasimir accepted this revision. krasimir added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/FormatToken.h:109 + TYPE(CSharpNullConditional) \ + TYPE(CSharpNullConditionalSq)

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 marked 2 inline comments as done. njames93 added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:220 +assert(Attr->getLocation().isValid()); +if (Attr->getLocation().isMacroID()) { + Errors =

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

Szelethus added a comment. The high level idea and the implementation of the checker seems great. In general, things that you want to address in later patches should be stated in the code with a `TODO`. I wrote a couple nits that I don't want to delete, but maybe it'd be better to address them

[PATCH] D74361: [Clang] Undef attribute for global variables

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:4365 +The ``loader_uninitialized`` attribute can be placed on global variables to +indicate that the variable does not need to be zero

[PATCH] D75350: [OpenMP] Allow const parameters in declare simd linear clause

fpetrogalli accepted this revision. fpetrogalli added a comment. LGTM, thank you @huntergr ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75350/new/ https://reviews.llvm.org/D75350 ___ cfe-commits

[clang] dc8680e - [CodeGenPGO] Fix shadow variable warning. NFC.

Author: Simon Pilgrim Date: 2020-03-02T15:06:34Z New Revision: dc8680eceb7c992cf1d02f47ad963dca2e287eaf URL: https://github.com/llvm/llvm-project/commit/dc8680eceb7c992cf1d02f47ad963dca2e287eaf DIFF: https://github.com/llvm/llvm-project/commit/dc8680eceb7c992cf1d02f47ad963dca2e287eaf.diff

[clang] 736385c - EHScopeStack::Cleanup has virtual functions so the destructor should be too.

Author: Simon Pilgrim Date: 2020-03-02T15:06:34Z New Revision: 736385c0b49d42f398ffa1458883f0d182178ef4 URL: https://github.com/llvm/llvm-project/commit/736385c0b49d42f398ffa1458883f0d182178ef4 DIFF: https://github.com/llvm/llvm-project/commit/736385c0b49d42f398ffa1458883f0d182178ef4.diff

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

sammccall added a subscriber: jyknight. sammccall added a comment. Per @jyknight on discord: we `-no-canonical-prefixes` disables this behavior in clang. Maybe we should scan for that and not resolve if it's present... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75056: [Driver] Default to -fno-common for all targets

tstellar accepted this revision. tstellar added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75332: [clang-tidy] Add module for llvm-libc and restrict-system-libc-header-check.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvmlibc/RestrictSystemLibcHeadersCheck.cpp:40 +SrcMgr::CharacteristicKind FileType) { + if (SrcMgr::isSystem(FileType)) { +if (!SM.isInMainFile(HashLoc)) { njames93 wrote: >

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

gribozavr2 added a comment. > I think my preference is to go with isLanguageVersionSupported() and not use > base classes. +1, I can see this working, but the introduction of new concepts does not seem like it pulls its weight given the tiny amount of boilerplate that they eliminate.

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:232 +} +CharSourceRange DelRange = CharSourceRange::getTokenRange( +AttrTokens->front().location(), AttrTokens->back().location()); let's use

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1901018 , @njames93 wrote: > - Fixed clang tidy warning, wont fix format as it's contradicting with the > style of the rest of the function I believe the formatting linter messages results from the fact that you are

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. Fixed the spelling/formatting, added more tests. The C++ case would be improved by warning on `int x __attribute__((loader_uninitialised)) = 0` as there are two initializers. The semantics for C are not what I

[PATCH] D75429: [clangd] DefineOutline removes `override` specified from overridden methods.

kadircet added a comment. Thanks for working on this! A few comments on macro handling and coding style. Apart from that mostly needs more testing. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:216 + // Remove the virtual, override and final

[PATCH] D75368: [clang-format] Handle ?. ?? and ?[ as C# tokens

jbcoe planned changes to this revision. jbcoe added a comment. Handle ??, ?. and ?[ in lib/Format/FormatTokenLexer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75368/new/ https://reviews.llvm.org/D75368 ___ cfe-commits mailing list

[PATCH] D75446: [clang][Syntax] Handle macro arguments in spelledForExpanded

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. kadircet added a child revision: D75447: [clangd] Make use of token buffers in semantic highlighting. Repository: rG LLVM Github Monorepo

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added a comment. Thanks! The scope looks good to me now, on to implementation details. I'm being a bit picky on the behaivor because go-to-def is a heavily-used feature, many users won't be expecting what we're doing here, and we can't reasonably expect them to understand the failure

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

hans added a comment. I also just noticed that this broke the Chromium build, see the attached reproducer at https://bugs.chromium.org/p/chromium/issues/detail?id=1057559#c1 clang++: /work/llvm.monorepo/clang/lib/AST/ExprConstant.cpp:14013: llvm::APSInt clang::Expr::EvaluateKnownConstInt(const

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

njames93 added a comment. I'm not entirely sure how to get the spelledTokens working in a good macro safe way? Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp:220 +assert(Attr->getLocation().isValid()); +if

[PATCH] D75429: [clangd] DefineOutline won't copy virtual specifiers on methods

kadircet added a comment. In D75429#1900709 , @njames93 wrote: > I'm not entirely sure how to get the spelledTokens working in a good macro > safe way? I don't really follow this comment, could you elaborate? `TB.expandedTokens` always refer to a

[clang] 7a42bab - Reland "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for defaulted parameters

Author: Awanish Pandey Date: 2020-03-02T16:45:48+05:30 New Revision: 7a42babeb83e3927e89e72a0e7e45be9d41b6c23 URL: https://github.com/llvm/llvm-project/commit/7a42babeb83e3927e89e72a0e7e45be9d41b6c23 DIFF:

[clang-tools-extra] c24c89d - [clangd] Get rid of unnecessary source transformations in locateMacroAt

Author: Kadir Cetinkaya Date: 2020-03-02T13:31:12+01:00 New Revision: c24c89d6f0f55bb95995b4f5587c791ac8d738fc URL: https://github.com/llvm/llvm-project/commit/c24c89d6f0f55bb95995b4f5587c791ac8d738fc DIFF:

[clang-tools-extra] 3ae2fc7 - [clangd] Get rid of lexer usage in locateMacroAt

Author: Kadir Cetinkaya Date: 2020-03-02T13:31:12+01:00 New Revision: 3ae2fc7a8bb3ee074d9fb9c0f235052b86c37aaf URL: https://github.com/llvm/llvm-project/commit/3ae2fc7a8bb3ee074d9fb9c0f235052b86c37aaf DIFF:

[PATCH] D75331: [clangd] Get rid of lexer usage in locateMacroAt

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ae2fc7a8bb3: [clangd] Get rid of lexer usage in locateMacroAt (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75331/new/

[PATCH] D75444: [ARM,MVE] Add the `vsbciq` intrinsics.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75444/new/ https://reviews.llvm.org/D75444

[PATCH] D75259: [clangd] Get rid of unnecssary source transformations in locateMacroAt

This revision was automatically updated to reflect the committed changes. Closed by commit rGc24c89d6f0f5: [clangd] Get rid of unnecessary source transformations in locateMacroAt (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75439: [clangd] No need to query ctor refs in cross-file rename.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for following up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75439/new/ https://reviews.llvm.org/D75439

[clang] 7d594cf - [ARM] Add Cortex-M55 Support for clang and llvm

Author: Luke Geeson Date: 2020-03-02T11:42:26Z New Revision: 7d594cf003d1325a1d85a339c03b720fe63de4c9 URL: https://github.com/llvm/llvm-project/commit/7d594cf003d1325a1d85a339c03b720fe63de4c9 DIFF: https://github.com/llvm/llvm-project/commit/7d594cf003d1325a1d85a339c03b720fe63de4c9.diff LOG:

[clang] 842c5c7 - Fix shadow variable warning. NFC.

Author: Simon Pilgrim Date: 2020-03-02T11:41:20Z New Revision: 842c5c79945ebe664bf113a108eaba495ac0b6d4 URL: https://github.com/llvm/llvm-project/commit/842c5c79945ebe664bf113a108eaba495ac0b6d4 DIFF: https://github.com/llvm/llvm-project/commit/842c5c79945ebe664bf113a108eaba495ac0b6d4.diff

[PATCH] D75414: [clangd] Resolve driver symlinks, and look up unknown relative drivers in PATH.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CompileCommandsTests.cpp:96 Mangler.adjust(Cmd); - EXPECT_EQ("unknown-binary", Cmd.front()); + EXPECT_EQ("/clangd-test/fake/unknown-binary", Cmd.front()); i suppose you rather

[PATCH] D75444: [ARM,MVE] Add the `vsbciq` intrinsics.

simon_tatham created this revision. simon_tatham added reviewers: MarkMurrayARM, dmgreen, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. These are exactly parallel to the existing `vadciq` intrinsics, which we

[PATCH] D75443: [AST] Unpack FPFeatures bits to BinaryOperator, NFC.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hokein edited the summary of this revision. The stmt bit-fields is full (max 64 bits) for BinaryOperator now, adding a new bit field (error) causes an 'static_assert(sizeof(*this) <=8)' violation

[PATCH] D75056: [Driver] Default to -fno-common for all targets

SjoerdMeijer added a comment. Friendly ping, and just checking: are we happy with this? Good to go? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 ___ cfe-commits mailing list

[PATCH] D75441: [clang-tidy] Add helper base check classes that only run on specific language versions

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:224 +/// Helper class for clang-tidy checks that only register when in `c++11` mode. +class Cpp11ClangTidyCheck : public ClangTidyCheck { + using

[PATCH] D75340: [clang-tidy] Change checks to use new isLanguageVersionSupported restriction

njames93 planned changes to this revision. njames93 added a comment. Made another pull request that could neaten this implementation up - https://reviews.llvm.org/D75441, will wait to see how that goes down before getting this pushed. Comment at:

[PATCH] D75255: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a8cbfa514ff: [ARM,MVE] Add ACLE intrinsics for VCVT[ANPM] family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75255/new/

[PATCH] D75254: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb08d2ddd69b4: [ARM,MVE] Add ACLE intrinsics for VCVT.F32.F16 family. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75254/new/

[PATCH] D75252: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa41ecf0eb051: [ARM,MVE] Add ACLE intrinsics for VQMOV[U]N family. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D75252?vs=246934=247580#toc Repository: rG LLVM Github

[clang] b08d2dd - [ARM, MVE] Add ACLE intrinsics for VCVT.F32.F16 family.

Author: Simon Tatham Date: 2020-03-02T10:33:30Z New Revision: b08d2ddd69b4a2209930b31fe456b4d7c1ce148f URL: https://github.com/llvm/llvm-project/commit/b08d2ddd69b4a2209930b31fe456b4d7c1ce148f DIFF: https://github.com/llvm/llvm-project/commit/b08d2ddd69b4a2209930b31fe456b4d7c1ce148f.diff LOG:

[clang] b293a72 - [analyzer][StreamChecker] Using function description objects - NFC.

Author: Balázs Kéri Date: 2020-03-02T12:35:07+01:00 New Revision: b293a7217bae22aa8a5f5e9aab025143c0f744e8 URL: https://github.com/llvm/llvm-project/commit/b293a7217bae22aa8a5f5e9aab025143c0f744e8 DIFF: https://github.com/llvm/llvm-project/commit/b293a7217bae22aa8a5f5e9aab025143c0f744e8.diff

[PATCH] D72041: [clangd] Handle go-to-definition in macro invocations where the target appears in the expansion multiple times

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Awesome, thanks for fixing this! Comment at: clang-tools-extra/clangd/Selection.cpp:261 + // consider it selected. + if

[PATCH] D75447: [clangd] Make use of token buffers in semantic highlighting

kadircet created this revision. kadircet added reviewers: hokein, sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75446: [clang][Syntax] Handle macro arguments in

  1   2   3   >