[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

skan marked an inline comment as done. skan added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") craig.topper

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jeroen.dobbelaere added a comment. In D74935#1908665 , @jdoerfert wrote: > I think we conflate two things here: > > 1. The modifications to the LangRef which should be in accordance with the C > standard (at least I haven't seen you contradict the new

[PATCH] D73846: make sure to not warn about unused macros from -D

llunak added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73846/new/ https://reviews.llvm.org/D73846 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [clang] bdad0a1 - PR45083: Mark statement expressions as being dependent if they appear in

On Fri, Mar 6, 2020 at 4:12 AM Richard Smith wrote: > > I implemented a completely different fix in > a95cc77be154433c37a3110ac9af394b7447fcba. Please can you let me know if it > works out? Stephan reports that it's still breaking compilations (now with an error diagnostic rather than a

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

balazske added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:222 + + struct ASTLoader { +/// Load the ASTUnit by an identifier. Subclasses should determine what this `class` would look better here? (The descendants are

[clang] 8e4a867 - Revert "PR45083: Mark statement expressions as being dependent if they contain"

Author: Stephan Herhut Date: 2020-03-06T11:09:45+01:00 New Revision: 8e4a8677be3061317056335d298d85ce60c23dff URL: https://github.com/llvm/llvm-project/commit/8e4a8677be3061317056335d298d85ce60c23dff DIFF:

[clang] af473d0 - [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

Author: Balázs Kéri Date: 2020-03-06T10:17:58+01:00 New Revision: af473d0e84f1f7bcaca6017012e22beddd260b67 URL: https://github.com/llvm/llvm-project/commit/af473d0e84f1f7bcaca6017012e22beddd260b67 DIFF: https://github.com/llvm/llvm-project/commit/af473d0e84f1f7bcaca6017012e22beddd260b67.diff

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

nand created this revision. nand added reviewers: rsmith, Bigcheese, dexonsmith, jfb. Herald added a project: clang. Herald added a subscriber: cfe-commits. Updated the documentation to better reflect features implemented on the constexpr branch at https://github.com/nandor/llvm-project and

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

steakhal added a comment. Herald added a subscriber: danielkiss. This patch introduced a crash while I was analyzing the libpressio . I was using the `CodeChecker` to drive the analysis with the `--enable-all` flag. The exact command was the following:

[PATCH] D75323: Support relative dest paths in headermap files

takuto.ikuta added a comment. Nico, can we merge this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75323/new/ https://reviews.llvm.org/D75323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74846: fix -fcodegen-modules code when used with PCH (PR44953)

llunak added a comment. Ping. I don't particularly care about the declspec(selectany) corner case, but at least the mistake from D69778 should be fixed (and it's a simple fix), so that it can be committed again. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak added a comment. Ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75687: [clangd] Only minimally escape text when rendering to markdown.

kadircet added a comment. Just writing down my investigation results for context: Looks like we'll never escape `$%'(,/:;?@[^{|}` anymore. Markdown already doesn't provide backslash escaping for `$%',/:;?@^|` which leaves us with parentheses `([{}`: - `[` looks fine as it is only used for

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added a comment. Any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske added a comment. To avoid problems I created a new version of this diff too that follows after the other new ones: https://reviews.llvm.org/D75682 (Adding a new diff can make inline comment positions even more inexact specially if the diff has many differences from an older one?)

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall added a comment. In D75479#1908774 , @nridge wrote: > This method only returns `Bar::uniqueMethodName()` because it's closer in > terms of distance Yeah, missing data is definitely bad: - not finding results makes the feature feel flaky or

[PATCH] D74618: [ARM] Creating 'call_mangled' for Neon intrinsics definitions

pratlucas updated this revision to Diff 248659. pratlucas added a comment. Applying clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74618/new/ https://reviews.llvm.org/D74618 Files: clang/include/clang/Basic/arm_neon_incl.td

[PATCH] D75612: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf473d0e84f1: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC). (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D75612?vs=248176=248665#toc Repository: rG

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

lebedev.ri added a comment. This file needs linewrapping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 ___ cfe-commits mailing list

[PATCH] D75734: [Sema][SVE] Reject atomic sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, jfb, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent revision: D75573: [Sema][SVE]

[PATCH] D72874: [clangd] Add a textual fallback for go-to-definition

sammccall added a comment. I'd like to sync up briefly on https://github.com/clangd/clangd/issues/241 so we know where we want to end up. I think this is in good shape and certainly doesn't need a bigger scope, just want to be able to reason about how things will fit together.

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. C# treats object initializers as braced init blocks. Braced init blocks are no longer indented as continuations.

[PATCH] D75732: [ASTImporter] Added visibility check for variable templates.

balazske created this revision. Herald added subscribers: cfe-commits, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter makes now difference between variable templates with same name

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:43-45 +llvm::errs() +<< "Using ',' as a file extension delimiter is deprecated. Please " + "switch your configuration to use ';'.\n";

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong added a comment. Ping. Please prioritize this patch, since it is fixing a regression caused by https://reviews.llvm.org/D74735. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678

[PATCH] D75678: [analyzer] Skip analysis of inherited ctor as top-level function

martong updated this revision to Diff 248678. martong added a comment. - Remove superfluous param x from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75678/new/ https://reviews.llvm.org/D75678 Files:

[PATCH] D75573: [Sema][SVE] Reject aligned/_Alignas for sizeless types

rsandifo-arm updated this revision to Diff 248672. rsandifo-arm added a comment. Apply changes from git-clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75573/new/ https://reviews.llvm.org/D75573 Files:

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jbcoe added a comment. Requires https://reviews.llvm.org/D75731 to be merged first. Do not use continuation indent for '['

[PATCH] D75574: RFC: Implement objc_direct_protocol attribute to remove protocol metadata

aaron.ballman added reviewers: aaron.ballman, rjmccall, erik.pilkington, MadCoder. aaron.ballman added a comment. Herald added a subscriber: dexonsmith. Adding some more knowledgeable reviewers for comments on your RFC. I pointed out a few minor nits, but I'll hold off on a technical review

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. You seem to have uploaded the wrong diff :) In D75171#1908259 , @baloghadamsoftware wrote: > This is the so called "correct"

[PATCH] D75747: [clang-format] Correct indentation for `[key] = value,` entries in C++ object initialisers

jbcoe added a comment. Requires https://reviews.llvm.org/D75731 to be merged first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75747/new/ https://reviews.llvm.org/D75747 ___ cfe-commits mailing

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

balazske added a comment. I have "mirrored" all 3 changes in this stack to the new series in D75682 . Probably it is possible to reuse these revisions instead but I do not know if it will not confuse phabricator somehow (and how phabricator behaves in such

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske abandoned this revision. balazske added a comment. The patch was split into D75612 and D75614 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. So the core of this is a better version of my patch, thanks! It does work around the problem with dot-to-arrow, which is useful and we should definitely enable that. However I actually

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

pbaran created this revision. pbaran added a reviewer: alexfh. pbaran added a project: clang-tools-extra. Herald added subscribers: kbarton, xazax.hun, nemanjai. Herald added a project: clang. pbaran updated this revision to Diff 248729. pbaran added a comment. Herald added a subscriber: wuzish.

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/objc-method-unavailable-not-override.rst:20 + +Suggests a fix to remove the method declaration entirely. You should also document the user-facing option for the check.

[PATCH] D75745: [clang-tidy] Added AllowMissingMoveFunctionsWhenCopyIsDeleted flag to cppcoreguidelines-special-member-functions

pbaran updated this revision to Diff 248729. pbaran added a comment. Herald added a subscriber: wuzish. Removed unintendedly added comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75745/new/ https://reviews.llvm.org/D75745 Files:

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. In D75356#1909610 , @balazske wrote: > The D75682 is the one that should be used > now, If this patch is supposed to be a followup to D75682 , could you

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75356/new/ https://reviews.llvm.org/D75356 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75700: [NFC] Let mangler accept GlobalDecl

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1028 else - MC.mangleName(ND, Out); + MC.mangleName(GD, Out); } else { rjmccall wrote: > What would be necessary in order for

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas added a reviewer: aaron.ballman. ztamas added a comment. I run the check on LLVM code and found only one catch of suspicious comparison: clang-tidy -p=/home/zolnai/clang/build

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas added a comment. I run the check on LLVM code and found only one catch of suspicious comparison: clang-tidy -p=/home/zolnai/clang/build /home/zolnai/clang/llvm-project/clang/lib/Lex/Lexer.cpp /home/zolnai/clang/llvm-project/clang/lib/Lex/Lexer.cpp:1293:39: warning: comparison

[PATCH] D75749: [clang-tidy] extend bugprone-signed-char-misuse check.

ztamas added a comment. In the LibreOffice codebase, I found 8 catches: https://gist.github.com/tzolnai/2b22492c0cf79f5dba577f6a878657e3 All catches seem valid to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75749/new/

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus added a comment. Actually, this is the diff: diff --git a/clang/include/clang/Basic/DiagnosticDriverKinds.td b/clang/include/clang/Basic/DiagnosticDriverKinds.td index ecd871e36ee..1f2c8c50a01 100644 --- a/clang/include/clang/Basic/DiagnosticDriverKinds.td +++

[PATCH] D70172: [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

yaxunl added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70172/new/ https://reviews.llvm.org/D70172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68165: [analyzer][MallocChecker][NFC] Split checkPostCall up, deploy CallDescriptionMap

Szelethus marked an inline comment as done. Szelethus added a comment. In D68165#1902702 , @Charusso wrote: > I wish for a third map, something like `ReallocationMap`. Other than that it > is a great direction, I love it. Thanks! Hah, that is a neat

[clang] 2eff1c3 - [clang-format] Extend AllowShortLoopsOnASingleLine to do ... while loops.

Author: Mitchell Balan Date: 2020-03-06T11:13:23-05:00 New Revision: 2eff1c3ce48ef529064e2dc006d57c37da0b4d84 URL: https://github.com/llvm/llvm-project/commit/2eff1c3ce48ef529064e2dc006d57c37da0b4d84 DIFF:

[PATCH] D75737: [Sema][SVE] Don't allow fields to have sizeless type

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a reviewer: rengolin. Herald added a project: clang. rsandifo-arm added a parent revision: D75736: [Sema][SVE]

[PATCH] D70086: [ConstExprPreter] Implemented control flow statements

nand updated this revision to Diff 248701. nand added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70086/new/ https://reviews.llvm.org/D70086 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp

[PATCH] D75738: [Sema][SVE] Reject by-copy capture of sizeless types

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. rsandifo-arm added a parent revision: D75737: [Sema][SVE] Don't allow fields to have sizeless

[PATCH] D75736: [Sema][SVE] Don't allow static or thread-local variables to have sizeless type

rsandifo-arm created this revision. rsandifo-arm added reviewers: sdesmalen, efriedma, rovka, rjmccall. Herald added subscribers: cfe-commits, psnobl, rkruppe, tschuett. Herald added a project: clang. rsandifo-arm added a parent revision: D75734: [Sema][SVE] Reject atomic sizeless types.

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/FileExtensionsUtils.cpp:43-45 +llvm::errs() +<< "Using ',' as a file extension delimiter is deprecated. Please " + "switch your configuration to use ';'.\n";

[PATCH] D75623: [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc86f794bd555: [clangd][VSCode] Force VSCode to use the ranking provided by clangd. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75563: [clang][Parse] properly parse asm-qualifiers, asm inline

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmtAsm.cpp:704 + AQ = DeclSpec::AQ_goto; +else { + if (EndLoc.isValid()) nickdesaulniers wrote: > aaron.ballman wrote: > > I would expect a diagnostic if the unknown token is

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

jbcoe updated this revision to Diff 248712. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75731/new/ https://reviews.llvm.org/D75731 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index:

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveCheck.cpp:383 SourceLocation MoveLoc = MovingCall->getExprLoc(); + const bool MoveArgIsConst = MoveArg->getType().isConstQualified(); Drop the top-level

[PATCH] D74735: [analyzer] Add support for CXXInheritedCtorInitExpr.

martong added a comment. @steakhal There is a fix for the crash: https://reviews.llvm.org/D75678 Let's hope that patch get's in soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74735/new/ https://reviews.llvm.org/D74735

[clang-tools-extra] c86f794 - [clangd][VSCode] Force VSCode to use the ranking provided by clangd.

Author: Sam McCall Date: 2020-03-06T13:34:25+01:00 New Revision: c86f794bd555a272f0f74a0b0a48f158e84b26b4 URL: https://github.com/llvm/llvm-project/commit/c86f794bd555a272f0f74a0b0a48f158e84b26b4 DIFF: https://github.com/llvm/llvm-project/commit/c86f794bd555a272f0f74a0b0a48f158e84b26b4.diff

[clang] 6ef953c - [OpenCL] Align vload and vstore builtins

Author: Sven van Haastregt Date: 2020-03-06T12:45:28Z New Revision: 6ef953c2d649cdc4df631c6cfdd54690f4914f4c URL: https://github.com/llvm/llvm-project/commit/6ef953c2d649cdc4df631c6cfdd54690f4914f4c DIFF: https://github.com/llvm/llvm-project/commit/6ef953c2d649cdc4df631c6cfdd54690f4914f4c.diff

[PATCH] D75735: [clangd] WIP: warn the user about missing compile_commands.json

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75735 Files:

[PATCH] D75698: [analyzer][WIP] Suppress bug reports where a tracked expression's latest value change was a result of an invalidation

martong added a comment. > While invalidation is a fundamental part of static analysis, it is > unfortunately not an under-approximation (resulting in fewer but more precise > paths of execution) +1 for saying this out :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:92-125 +class MakeRetVal { + const CallExpr *CE = nullptr; + std::unique_ptr RetVal; + SymbolRef RetSym; + +public: + MakeRetVal(const CallEvent , CheckerContext )

[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall marked an inline comment as done. sammccall added a comment. > I'll make a proposal on https://github.com/clangd/clangd/issues/241 for a bit > more visibility. OK, I wrote a bunch of stuff there (twice, laptop crashed, grr...) I'll put this briefly on hold to see what you/others

[PATCH] D75739: [clangd][vscode] Enable dot-to-arrow fixes in clangd completion.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The previous issue is that the item was filtered out by vscode, because the prefix (which contains ".") are

[PATCH] D75740: [ASTImporter] Corrected import of repeated friend declarations.

balazske created this revision. Herald added subscribers: cfe-commits, martong, teemperor, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Import declarations in correct order if a class contains multiple redundant

[PATCH] D70265: [clang-tidy] Add CppCoreGuidelines I.2 "Avoid non-const global variables" check

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:55-71 + if (const auto *Reference = + Result.Nodes.getNodeAs("reference_to_non-const")) { +diag(Reference->getLocation(), +

[clang] 33bb32b - [Sema] Reword -Wrange-loop-analysis warning messages

Author: Aaron Puchert Date: 2020-03-06T14:57:01+01:00 New Revision: 33bb32bbc674a16973c59c9a6dc119387843a0f0 URL: https://github.com/llvm/llvm-project/commit/33bb32bbc674a16973c59c9a6dc119387843a0f0 DIFF: https://github.com/llvm/llvm-project/commit/33bb32bbc674a16973c59c9a6dc119387843a0f0.diff

[PATCH] D75613: [Sema] Reword -Wrange-loop-analysis warning messages

This revision was automatically updated to reflect the committed changes. Closed by commit rG33bb32bbc674: [Sema] Reword -Wrange-loop-analysis warning messages (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75613/new/

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Let's halt this for now -- we have so many revisions going on seemingly doing the same thing, its becoming really confusing. Please finish D75356

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Okay, very well, then lets abandon this patch. Please keep in mind that phabricator can mark whether a revision was mentioned somewhere else if you only copy the revision ID,

[PATCH] D75612: [Analyzer][StreamChecker] Adding PreCall and refactoring (NFC).

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:321 +ProgramStateRef +StreamChecker::ensureStreamNonNull(SVal StreamVal, CheckerContext , + ProgramStateRef State) const { Just a

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. Could you please fix up the dependencies of this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75356/new/ https://reviews.llvm.org/D75356 ___ cfe-commits mailing

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. Thanks @MyDeveloperDay . I guess more approvals are needed at this point? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list

[PATCH] D74361: [Clang] Undef attribute for global variables

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2718 + // attribute then there are two different definitions. + // In C++, prefer the standard diagnostics + if (!S.getLangOpts().CPlusPlus) { Missing a full stop at the

[PATCH] D75614: [Analyzer][StreamChecker] Check for opened stream before operations.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. Amazing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75614/new/ https://reviews.llvm.org/D75614

[PATCH] D75731: [clang-format] C# does not indent braced initializers as continuations

jbcoe updated this revision to Diff 248719. jbcoe added a comment. Remove comma to tidy up ugly format test and actually test what is needed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75731/new/ https://reviews.llvm.org/D75731 Files: clang/lib/Format/FormatToken.h

[PATCH] D75356: [Analyzer][StreamChecker] Introduction of stream error state handling.

Szelethus added a comment. In D75356#1909193 , @balazske wrote: > To avoid problems I created a new version of this diff too that follows after > the other new ones: > https://reviews.llvm.org/D75682 > (Adding a new diff can make inline comment

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2eff1c3ce48e: [clang-format] Extend AllowShortLoopsOnASingleLine to do ... while loops. (authored by mitchell-stellar). Changed prior to commit: https://reviews.llvm.org/D75022?vs=246512=248748#toc

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks edited the summary of this revision. aeubanks added reviewers: thakis, rnk. aeubanks retitled this revision from "Move warnings added in https://reviews.llvm.org/D75708 under

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

mitchell-stellar added a comment. It's not more approval that is needed, it's just that someone with commit access (assuming you do not) needs to find the time to commit this. For what it's worth, I'm getting a patch rejection for the 4th block in lib/Format/Format.cpp. It seems the contents

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping 3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75209/new/ https://reviews.llvm.org/D75209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 5dadf57 - [OPENMP50]Add 'depobj' modifier in 'depend' clauses.

Author: Alexey Bataev Date: 2020-03-06T11:44:57-05:00 New Revision: 5dadf577d59b53110f2a0084dc9ef9f974116955 URL: https://github.com/llvm/llvm-project/commit/5dadf577d59b53110f2a0084dc9ef9f974116955 DIFF: https://github.com/llvm/llvm-project/commit/5dadf577d59b53110f2a0084dc9ef9f974116955.diff

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248757. jroelofs added a comment. - Drop dead include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/ https://reviews.llvm.org/D75621 Files:

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

jdoerfert added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && Out of curiosity, why do we prevent Objective C here?

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

jdoerfert added a comment. In D74935#1909054 , @jeroen.dobbelaere wrote: > In D74935#1908665 , @jdoerfert wrote: > > > I think we conflate two things here: > > > > 1. The modifications to the LangRef which should

[PATCH] D75621: [clang-tidy] Use ; as separator for HeaderFileExtensions

jroelofs updated this revision to Diff 248755. jroelofs added a comment. - Don't spam the deprecation message. Move that to release notes. - Drop unnecessary `const`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75621/new/

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365 + llvm::SmallString<256> AbsPath = CTUDir; + llvm::sys::path::append(AbsPath, Identifier); Could we check somehow if `CTUDir` is indeed an absolute path? If not then

[PATCH] D75723: [X86] Make intrinsics _BitScan* not limited to Windows

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1904 +// BITSCAN +TARGET_BUILTIN(_BitScanForward, "UcUNi*UNi", "n", "") +TARGET_BUILTIN(_BitScanReverse, "UcUNi*UNi", "n", "") skan wrote: > craig.topper wrote: > > The N

[clang] 865456d - [Concepts] Add null check for TemplateTypeParmType::getDecl() in GetContainedInventedTypeParmVisitor

Author: Saar Raz Date: 2020-03-06T19:32:10+02:00 New Revision: 865456d589e093582acaafd17d58ad1c0cce66af URL: https://github.com/llvm/llvm-project/commit/865456d589e093582acaafd17d58ad1c0cce66af DIFF: https://github.com/llvm/llvm-project/commit/865456d589e093582acaafd17d58ad1c0cce66af.diff

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev marked 6 inline comments as done. ABataev added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:2891 ArgExprs); } + } else if (!getLangOpts().ObjC && getLangOpts().OpenMP >= 50 && jdoerfert

[PATCH] D75209: [OPENMP][NVPTX]Fix PR45003: add support for complex functions.

jdoerfert added a comment. I am unsure we need this with the proper math support. Sema patch for that is going for review today. I'll try this out soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75209/new/ https://reviews.llvm.org/D75209

[PATCH] D75758: [Sema] Add -Wpointer-to-enum-cast and -Wvoid-pointer-to-enum-cast

nathanchance created this revision. nathanchance added reviewers: Mordante, rjmccall. Herald added a project: clang. GCC does not warn on casts from pointers to enumerators, while clang currently does: https://godbolt.org/z/3DFDVG This causes a bunch of extra warnings in the Linux kernel, where

[PATCH] D74361: [Clang] Undef attribute for global variables

JonChesterfield updated this revision to Diff 248807. JonChesterfield marked 2 inline comments as done. JonChesterfield added a comment. - Review comments, add tests for private_extern Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74361/new/

[clang] 6d894af - PR45124: Don't leave behind pending cleanups when declaring implicit

Author: Richard Smith Date: 2020-03-06T13:22:10-08:00 New Revision: 6d894afdea433879f54e5ba07e827db006645b7b URL: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b DIFF: https://github.com/llvm/llvm-project/commit/6d894afdea433879f54e5ba07e827db006645b7b.diff

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

erichkeane added a comment. Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable about the intended guidance for adding to Wmost, so if you can clarify this decision I'd be grateful. Otherwise I think this patch looks fine. Repository: rG LLVM Github Monorepo

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

rnk added a comment. I agree with the reasoning, but this is likely to fire all over existing C++ code. In fact, the one we just added finds issues in Chrome https://ci.chromium.org/p/chrome/builders/ci/ToTWin/5879 ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller

[PATCH] D75768: Add a warning for builtin_return_address/frame_address with > 0 argument

jstenglein added a comment. In D75768#1910303 , @erichkeane wrote: > Any reason to not put this in -Wall like GCC? I'm not terribly knowledgeable > about the intended guidance for adding to Wmost, so if you can clarify this > decision I'd be grateful.

[PATCH] D75569: [clang-tidy] New check for methods marked __attribute__((unavailable)) that do not override a method from a superclass.

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/MethodUnavailableNotOverrideCheck.cpp:63 + } + return FixItHint::CreateRemoval(MD->getSourceRange()); +} I'm not an ObjC expert, so I apologize if this is a dumb question, but

[PATCH] D75770: [WebAssembly] Add SIMD integer min/max builtins

tlively created this revision. tlively added reviewers: aheejin, dschuff, kripken. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100. Herald added a project: clang. Although SIMD integer min/max operations can be expressed using the ?: operator in C++, that operator is

  1   2   >