[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn created this revision. fhahn added reviewers: rsmith, anemet, Bigcheese, dexonsmith. Herald added a subscriber: tschuett. Herald added a project: clang. This patch documents the planned matrix support in Clang, based on the draft specification discussed on cfe-dev in the 'Matrix Support in

[PATCH] D73541: [Clang] Added method getTokenLocations to StringLiteral

njames93 added a comment. Ping?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73541/new/ https://reviews.llvm.org/D73541 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] a711a3a - [Syntax] Build mapping from AST to syntax tree nodes

Author: Marcel Hlopko Date: 2020-03-23T16:22:14+01:00 New Revision: a711a3a46039154c38eade8bef1138b77fdb05ee URL: https://github.com/llvm/llvm-project/commit/a711a3a46039154c38eade8bef1138b77fdb05ee DIFF: https://github.com/llvm/llvm-project/commit/a711a3a46039154c38eade8bef1138b77fdb05ee.diff

[PATCH] D72281: [Matrix] Add matrix type to Clang.

martong added inline comments. Comment at: clang/lib/AST/ASTStructuralEquivalence.cpp:647 + return false; +if (Mat1->getNumRows() != Mat2->getNumRows()) + return false; Should we check `getNumColumns()` too? Repository: rG LLVM Github Monorepo

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. Much more logical than the existing setup. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76509/new/ https://reviews.llvm.org/D76509 ___ cfe-commits

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

This revision was automatically updated to reflect the committed changes. Closed by commit rG57b8a407493c: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to… (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D75360?vs=251056=252073#toc

[clang] 63828a3 - [OPENMP50]Bassic support for exclusive clause.

Author: Alexey Bataev Date: 2020-03-23T13:12:52-04:00 New Revision: 63828a35da6f790f448b87b3eec61d294df31ccc URL: https://github.com/llvm/llvm-project/commit/63828a35da6f790f448b87b3eec61d294df31ccc DIFF: https://github.com/llvm/llvm-project/commit/63828a35da6f790f448b87b3eec61d294df31ccc.diff

[PATCH] D76617: [SveEmitter] Fix encoding/decoding of SVETypeFlags

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, Andrzej. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. This issue was introduced when reworking D75861 . The bug isn't actually hit with current unit tests

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:34 - void handleBegin(CheckerContext , const Expr *CE, const SVal , - const SVal ) const; - void handleEnd(CheckerContext , const Expr *CE, const SVal , -

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

hans added a comment. In D76030#1928448 , @hans wrote: > In D76030#1925445 , @tra wrote: > > > @hans -- this should be cherry-picked into 10 if it's not too late yet. > > > It's probably too late for 10.0.0, but

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:151 +LANGOPT(RecoveryAST, 1, 0, "Preserve expressions in AST when encountering errors") + this should be COMPATIBLE_LANGOPT I believe - it

[clang] ccc0d35 - [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

Author: Adam Balogh Date: 2020-03-23T17:33:26+01:00 New Revision: ccc0d351817bedf3a979144238ffb8e2797285d4 URL: https://github.com/llvm/llvm-project/commit/ccc0d351817bedf3a979144238ffb8e2797285d4 DIFF: https://github.com/llvm/llvm-project/commit/ccc0d351817bedf3a979144238ffb8e2797285d4.diff

[PATCH] D76379: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std::next()`

This revision was automatically updated to reflect the committed changes. Closed by commit rGccc0d351817b: [Analyzer] IteratorRangeChecker verify `std::advance()`, `std::prev()` and `std… (authored by baloghadamsoftware). Changed prior to commit:

[clang] 04336ad - [clang-format] No space inserted between commas in C#

Author: Jonathan Coe Date: 2020-03-23T17:17:27Z New Revision: 04336ada1756fea6ae0a6d86bd2d6bd35cdd19ad URL: https://github.com/llvm/llvm-project/commit/04336ada1756fea6ae0a6d86bd2d6bd35cdd19ad DIFF: https://github.com/llvm/llvm-project/commit/04336ada1756fea6ae0a6d86bd2d6bd35cdd19ad.diff LOG:

[clang] b670ab7 - recommit 1b978ddba05c [CUDA][HIP][OpenMP] Emit deferred diagnostics by a post-parsing AST travese

Author: Yaxun (Sam) Liu Date: 2020-03-23T12:09:07-04:00 New Revision: b670ab7b6b3d2f26179213be1da1d4ba376f50a3 URL: https://github.com/llvm/llvm-project/commit/b670ab7b6b3d2f26179213be1da1d4ba376f50a3 DIFF:

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for this! Mostly just some cleanups/comment nits left. The substantive change is around the `\` and ` ` at end-of-line. It looks like the goal is on improving the parsing of

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

sammccall added a comment. This looks reasonable to me, though I'm not familiar enough with the code to do a good review. Just wanted to confirm my understanding: the problematic offsets that are now section-relative instead of file-relative are only used in two sections of the file (macro

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. In D74918#1937237 , @zoecarver wrote: > @lebedev.ri Where should I put this? Could you maybe point me to another LLVM > target API that clang uses that I could base this off? Maybe it should go > inside the triple or just be

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

lebedev.ri added a comment. SGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76622/new/ https://reviews.llvm.org/D76622 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Nice catch, thanks! We have some FIXMEs about MSVC sadly and I was thinking about the same change back in the days. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl added a comment. In D76520#1937217 , @tra wrote: > In D76520#1936837 , @yaxunl wrote: > > > -Xarch_ works with driver options having value, e.g. > > `-fcf-protection=branch`. I added a test for that. > > >

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4175 namespace { /// PPC32_SVR4_ABIInfo - The 32-bit PowerPC ELF (SVR4) ABI information. class PPC32_SVR4_ABIInfo : public DefaultABIInfo { ZarkoCA wrote: > sfertile wrote: > > This

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. OK, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76509/new/ https://reviews.llvm.org/D76509 ___ cfe-commits mailing list

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGa711a3a46039: [Syntax] Build mapping from AST to syntax tree nodes (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76590: [Analyzer] Model `empty()` member function of containers

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/Iterator.cpp:297 + +ProgramStateRef relateSymbols(ProgramStateRef State, SymbolRef Sym1, + SymbolRef Sym2, bool Equal) { Would `assumeEqual` be a better

[clang] 57b8a40 - [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Author: Kristóf Umann Date: 2020-03-23T17:09:49+01:00 New Revision: 57b8a407493c34c3680e7e1e4cb82e097f43744a URL: https://github.com/llvm/llvm-project/commit/57b8a407493c34c3680e7e1e4cb82e097f43744a DIFF: https://github.com/llvm/llvm-project/commit/57b8a407493c34c3680e7e1e4cb82e097f43744a.diff

[PATCH] D76621: [clang-format] No space inserted between commas in C#

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo

[PATCH] D76620: [SYCL] Implement __builtin_unique_stable_name.

erichkeane created this revision. erichkeane added a reviewer: bader. Herald added subscribers: Anastasia, ebevhan, kristina. erichkeane added a reviewer: rolandschulz. In order to support non-user-named kernels, SYCL needs some way in the integration headers to name the kernel object themselves.

[PATCH] D76604: [Analyzer] Model `size()` member function of containers

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:456 + SVal RetVal) const { + const auto *ContReg = Cont.getAsRegion(); + if (!ContReg) Just out of curiosity: How do we handle

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @lebedev.ri Where should I put this? Could you maybe point me to another LLVM target API that clang uses that I could base this off? Maybe it should go inside the triple or just be a static function? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver updated this revision to Diff 252079. zoecarver added a comment. - Rebase off master - For i386, return 16 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 Files:

[PATCH] D76622: ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

RKSimon created this revision. RKSimon added reviewers: Charusso, ddcc, rnk, xbolva00. Herald added a project: clang. This was noticed on D71817 , which removed another use of __OPTIMIZE__ Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76622

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a comment. In D76520#1936837 , @yaxunl wrote: > -Xarch_ works with driver options having value, e.g. > `-fcf-protection=branch`. I added a test for that. > > `-mframe-pointer=none` is a cc1 option. That's why it cannot be passed by > -Xarch_.

[PATCH] D76621: [clang-format] No space inserted between commas in C#

This revision was automatically updated to reflect the committed changes. Closed by commit rG04336ada1756: [clang-format] No space inserted between commas in C# (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

If its relatively common for someone making a plugin to mess this up, maybe it should be report_fatal_error instead of only catching it in asserts build? ~Craig On Mon, Mar 23, 2020 at 5:24 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 3:31 PM David Blaikie wrote: > > > > On Sun, Mar 22,

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

aganea created this revision. aganea added reviewers: yaxunl, scott.linder. Herald added a project: clang. Herald added a subscriber: cfe-commits. On Windows, when the LLVM toolchain is in the current path (`%PATH%`), fusing the linker yields `c:\{path}\lld.exe` whereas the hip tests did not

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl added a comment. I am curious why opt and llc is not affected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76631/new/ https://reviews.llvm.org/D76631 ___ cfe-commits mailing list

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Herald added a subscriber: wuzish. I'm just going to assume the test changes look good; thank you for taking the time to do this. CHANGES SINCE LAST ACTION

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

JDevlieghere added a comment. It appears this broke the modules build: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12905/console Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/

[clang] 56abcfa - Revert "[analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes"

Author: Jonas Devlieghere Date: 2020-03-23T12:09:24-07:00 New Revision: 56abcfad70ee679ad95ab41d934491ebcaebdf7d URL: https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d DIFF:

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

DmitryPolukhin added a comment. In D76594#1937289 , @sammccall wrote: > This looks reasonable to me, though I'm not familiar enough with the code to > do a good review. > > Just wanted to confirm my understanding: the problematic offsets that are now >

[clang] 55eca28 - [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

Author: Johannes Doerfert Date: 2020-03-23T14:23:46-05:00 New Revision: 55eca2853e4f096be189208770034a8a4fb72666 URL: https://github.com/llvm/llvm-project/commit/55eca2853e4f096be189208770034a8a4fb72666 DIFF:

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252118. oontvoo added a comment. Clear pending action. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252117. oontvoo marked an inline comment as done. oontvoo added a comment. Add a PendingHeaderSearch set Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files:

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76631/new/ https://reviews.llvm.org/D76631

[PATCH] D31343: Add an attribute plugin example

aaron.ballman added a comment. In D31343#1936810 , @Jasmin wrote: > Hello John! > > I was encouraged by Erich after a talk I had with him and Aaron on IRC to > contact you about an use case for this plugin. > > I wanted to use user-specified/unknown

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

tra added a comment. In D76520#1937294 , @yaxunl wrote: > -Xarch_ does not work for passing -cc1 options in the beginning. This patch > does not change that. > > This requires some further changes about how the options after -Xarch_ are > handled. I

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

craig.topper added a comment. In D74918#1937291 , @lebedev.ri wrote: > In D74918#1937237 , @zoecarver wrote: > > > @lebedev.ri Where should I put this? Could you maybe point me to another > > LLVM target API that

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1936769 , @mibintc wrote: > In D76384#1934785 , @rjmccall wrote: > > > Let's make this patch be purely a representation change. I wouldn't expect > > *any* test changes from

[PATCH] D76534: [clang/docs] Fix various sphinx warnings/errors in docs.

rjmccall added a comment. Sure. I'm not asking you to fix this, I'm just asking your opinion about the right thing to do. Is the Sphinx warning reasonable, such that we should fix our (autogenerated, IIRC) input to avoid the "redundant" spellings, or should we ask Sphinx to handle it more

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

efriedma added a comment. I think we should remove the LangRef rule that says "sret" pointers have to be dereferenceable/naturally aligned, and let the frontend add explicit aligned/dereferenceable markings where appropriate. (At that point, sret has no target-independent meaning; it's just

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 252110. oontvoo added a comment. Updated the reader to read the UIDs first, then we'll build up the Importers list at the end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/

[PATCH] D76520: [CUDA][HIP] Add -Xarch_device and -Xarch_host options

yaxunl updated this revision to Diff 252105. yaxunl added a comment. add TODO for fixing space separated arguments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76520/new/ https://reviews.llvm.org/D76520 Files: clang/include/clang/Driver/Options.td

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Mon, Mar 23, 2020 at 1:41 PM Craig Topper wrote: > > If its relatively common for someone making a plugin to mess this up, maybe > it should be report_fatal_error instead of only catching it in asserts build? I think that would also be a reasonable solution if that's the preference. ~Aaron

[clang] 896335b - Don't export symbols from clang/opt/llc if plugins are disabled.

Author: Eli Friedman Date: 2020-03-23T12:17:09-07:00 New Revision: 896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88 URL: https://github.com/llvm/llvm-project/commit/896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88 DIFF: https://github.com/llvm/llvm-project/commit/896335bfb8ea2c09c361c4f1e5a9aa6fb78caf88.diff

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus added a comment. In D75360#1937415 , @JDevlieghere wrote: > It appears this broke the modules build: > http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/12905/console > > Can you please take a look? Yup, on it. Repository: rG LLVM

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

JDevlieghere added a comment. In D75360#1937556 , @Szelethus wrote: > In D75360#1937415 , @JDevlieghere > wrote: > > > It appears this broke the modules build: > >

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Changes LGTM on the Clang side. In D76572#1935791 , @lebedev.ri wrote: > Passing-by remark: > > > I wrote a Clang warning [not pictured] to diagnose

[PATCH] D76527: Don't export symbols from clang/opt/llc if plugins are disabled.

This revision was automatically updated to reflect the committed changes. Closed by commit rG896335bfb8ea: Dont export symbols from clang/opt/llc if plugins are disabled. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76173: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s

This revision was automatically updated to reflect the committed changes. Closed by commit rG55eca2853e4f: [OpenMP][NFC] Minimize memory usage and copying of `OMPTraitInfo`s (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D76173?vs=250347=252123#toc Repository: rG

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

Quuxplusone added a comment. In D76572#1937558 , @rsmith wrote: > In D76572#1935791 , @lebedev.ri > wrote: > > > Passing-by remark: > > > > > I wrote a Clang warning [not pictured] to diagnose any use of `T(x)` >

[PATCH] D74183: [IRGen] Add an alignment attribute to underaligned sret parameters

rjmccall added a comment. In D74183#1937426 , @efriedma wrote: > I think we should remove the LangRef rule that says "sret" pointers have to > be dereferenceable/naturally aligned, and let the frontend add explicit > aligned/dereferenceable markings

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

zhizhouy updated this revision to Diff 252129. zhizhouy marked 2 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: manojgupta. zhizhouy removed a subscriber: manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D76472: AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76472/new/ https://reviews.llvm.org/D76472 ___ cfe-commits mailing list

[PATCH] D76572: Replace `T(x)` with `reinterpret_cast(x)` everywhere it means reinterpret_cast. No functional change

rsmith added a comment. In D76572#1937641 , @Quuxplusone wrote: > [...] take my word for it, you **don't** want to start with the code I wrote > the other day. :) Understood, thanks :) (FWIW, I had a stab at implementing essentially this last year and

[clang] 7bf871c - [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

Author: Kirstóf Umann Date: 2020-03-23T21:50:40+01:00 New Revision: 7bf871c39f739a7382ba89c97f50fd047f36f894 URL: https://github.com/llvm/llvm-project/commit/7bf871c39f739a7382ba89c97f50fd047f36f894 DIFF: https://github.com/llvm/llvm-project/commit/7bf871c39f739a7382ba89c97f50fd047f36f894.diff

[clang] 3f53300 - AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

Author: Matt Arsenault Date: 2020-03-23T16:51:25-04:00 New Revision: 3f533006ba8c8ae6f3596f49f480aa794ed4e347 URL: https://github.com/llvm/llvm-project/commit/3f533006ba8c8ae6f3596f49f480aa794ed4e347 DIFF:

[PATCH] D31343: Add an attribute plugin example

erichkeane added a comment. In D31343#1937588 , @aaron.ballman wrote: > In D31343#1936810 , @Jasmin wrote: > > > Hello John! > > > > I was encouraged by Erich after a talk I had with him and Aaron on IRC to > >

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

leonardchan added a comment. In D74619#1936336 , @pratlucas wrote: > Hi @leonardchan , > > I've double-checked the Neon intrinsics reference and it indeed confirms that > the only allowed value for the lane argument for `vdupq_lane_f64` is `0`: > >

[clang] cfaa84e - Fix "previously declared as a struct" warning

Author: Vitaly Buka Date: 2020-03-23T12:59:16-07:00 New Revision: cfaa84e1a679b2e2eb409eb57292f7caecb642d4 URL: https://github.com/llvm/llvm-project/commit/cfaa84e1a679b2e2eb409eb57292f7caecb642d4 DIFF: https://github.com/llvm/llvm-project/commit/cfaa84e1a679b2e2eb409eb57292f7caecb642d4.diff

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus reopened this revision. Szelethus added a comment. This revision is now accepted and ready to land. In D75360#1937557 , @JDevlieghere wrote: > Oh, I'm sorry, I just reverted it like a minute ago. Its fine, I'll recommit when I have a fix as

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

aganea added a comment. In D76631#1937428 , @yaxunl wrote: > I am curious why opt and llc is not affected In one case (opt, llc, clang-offload-bundler) it finds those programs in the "program paths", ie. the build folder:

[PATCH] D72810: [LifetimeAnalysis] Add support for lifetime annotations on functions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7727 +// Move function type attribute to the declarator. +case ParsedAttr::AT_LifetimeContract: xazax.hun wrote: > aaron.ballman wrote: > > xazax.hun wrote: > > >

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:110-114 +case 26: + return 0; +__attribute__((fallthrough)); // expected-warning{{fallthrough annotation in unreachable code}} +case 27: + break;

[clang] 5896e2d - [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the path

Author: Alexandre Ganea Date: 2020-03-23T16:54:48-04:00 New Revision: 5896e2df45dab7680be321ee63903431a673817b URL: https://github.com/llvm/llvm-project/commit/5896e2df45dab7680be321ee63903431a673817b DIFF:

[clang] 1a4421a - [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

Author: Simon Pilgrim Date: 2020-03-23T21:03:14Z New Revision: 1a4421a5e860ffc63c77594c9fb40787f84241aa URL: https://github.com/llvm/llvm-project/commit/1a4421a5e860ffc63c77594c9fb40787f84241aa DIFF: https://github.com/llvm/llvm-project/commit/1a4421a5e860ffc63c77594c9fb40787f84241aa.diff

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

yaxunl added a comment. In D76631#1937681 , @aganea wrote: > In D76631#1937428 , @yaxunl wrote: > > > I am curious why opt and llc is not affected > > > In one case (opt, llc, clang-offload-bundler) it finds those

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

manojgupta added a comment. Thanks, Noticed a few typos. Rest lgtm but deferring to other reviewers for now for approval. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1110 PTO.SLPVectorization = CodeGenOpts.VectorizeSLP; + PTO.CallGrpahProfile =

[PATCH] D76472: AMDGPU: Emit llvm.fshr for __builtin_amdgcn_alignbit

arsenm closed this revision. arsenm added a comment. 3f533006ba8c8ae6f3596f49f480aa794ed4e347 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76472/new/ https://reviews.llvm.org/D76472

[PATCH] D76631: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain in the path

This revision was automatically updated to reflect the committed changes. Closed by commit rG5896e2df45da: [Clang] Fix HIP tests when running on Windows with the LLVM toolchain is in the… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a4421a5e860: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific)… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76509: [analyzer][NFC] Move the text output type to its own file, move code to PathDiagnosticConsumer creator functions

This revision was automatically updated to reflect the committed changes. Szelethus marked 6 inline comments as done. Closed by commit rG7bf871c39f73: [analyzer][NFC] Move the text output type to its own file, move code to… (authored by Szelethus). Changed prior to commit:

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Ah, thanks. (I'm going to see about renaming/restructuring that API - to return Optional and be called 'get' rather than 'is' to make this more clear) On Mon, Mar 23, 2020 at 5:04 AM Mikhail Maltsev wrote: > Yes, it does. isIntegerConstantExpr assigns a value to CoprocNoAP. > > -- > Regards, >

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

zhizhouy updated this revision to Diff 252143. zhizhouy marked 4 inline comments as done. zhizhouy retitled this revision from "[NFC] Do not run CGProfilePass when -fno-integrated-as is on" to "[NFC] Do not run CGProfilePass when not using integrated assembler". zhizhouy added a comment. Thanks

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

xur added a comment. look good to me with the fix of comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:110 + /// Tuning option to enable/disable call graph profile. Its default value is + /// true. + bool CallGrpahProfile; The default value is

[PATCH] D76653: [clang] Allow -DDEFAULT_SYSROOT to be a relative path

sbc100 created this revision. Herald added subscribers: cfe-commits, sunfish, aheejin, mgorny, dschuff. Herald added a project: clang. sbc100 retitled this revision from "Allow -DDEFAULT_SYSROOT to be a relative path" to "[clang] Allow -DDEFAULT_SYSROOT to be a relative path". sbc100 added

[clang] d0f4af8 - [Coroutines] Insert lifetime intrinsics even O0 is used

Author: Jun Ma Date: 2020-03-24T13:41:55+08:00 New Revision: d0f4af8f3088f72df7fea9983127cbeeebbef6a1 URL: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1 DIFF: https://github.com/llvm/llvm-project/commit/d0f4af8f3088f72df7fea9983127cbeeebbef6a1.diff LOG:

[PATCH] D76119: [Coroutines] Insert lifetime intrinsics even O0 is used

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGd0f4af8f3088: [Coroutines] Insert lifetime intrinsics even O0 is used (authored by junparser). Herald added a project:

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @craig.topper that would mean that it couldn't be constexpr though, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74918/new/ https://reviews.llvm.org/D74918 ___

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 252147. ZarkoCA added a comment. Simplified testcases. Added testcases for variadic arguments being passed directly to the stack when all registers are used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

efriedma added a comment. Not sure what sort of test would catch this; it's not crashing, and the types with the tail padding issue are not naturally exposed by target intrinsic headers (so it would only show up for code using ext_vector_type, or maybe OpenCL code). I only tripped over the

[PATCH] D76094: [clangd] Change line break behaviour for hoverinfo

lolleko updated this revision to Diff 252159. lolleko added a comment. Final Cleanup Removed markdown linebreak parsing for now. No I don't have commit rights yet. Feel fre to merge this for me. Thanks for the thorough review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76646: Rename/refactor isIntegerConstantExpression to getIntegerConstantExpression

dblaikie created this revision. dblaikie added a reviewer: rsmith. Herald added subscribers: cfe-commits, jfb. Herald added a reviewer: jdoerfert. Herald added a project: clang. There is a version that just tests (also called isIntegerConstantExpression) & whereas this version is specifically

[PATCH] D76528: [clang codegen] Clean up handling of vectors with trivial-auto-var-init.

jfb added a comment. The test files I added checked initialization had stores to each padding location, I think that's what would be needed here as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76528/new/ https://reviews.llvm.org/D76528

[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MarcusJohnson91 added a comment. Rebased on Master again, recompiling and re-running all the tests. I'll update this comment when it passes, or create a new diff if it doesn't but nothing had to be changed so it'll probably work. @krasimir I noticed that you've been active recently, can you

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. In D76184#1927159 , @rnk wrote: > I patched this in with it's dependency, and to compile just Attr.h by itself, > it reduces the time from ~2.420s to ~1.920s, so it is worth pushing this > through. :) > > However, I noticed

[clang] 20d704a - [objc_direct] also go through implementations when looking for clashes

Author: Pierre Habouzit Date: 2020-03-23T20:49:09-07:00 New Revision: 20d704a75ed51c7a9a155aa3978d0c02671c3f69 URL: https://github.com/llvm/llvm-project/commit/20d704a75ed51c7a9a155aa3978d0c02671c3f69 DIFF:

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

NoQ added a comment. Sounds good but eventually i hope we re-enable this assert in release+assert builds (D57062 ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76622/new/ https://reviews.llvm.org/D76622

<    1   2   3   >