[PATCH] D77077: [clang] CodeGen: Make getOrEmitProtocol public for Swift

aschwaighofer updated this revision to Diff 253938. aschwaighofer added a comment. - Remove callback. Swift can inspect the generated IR and update it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77077/new/ https://reviews.llvm.org/D77077

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

yaxunl added a comment. Are there any other clang options affecting flushing denormals? If so, are they working properly after this change? Do we need to have tests for them? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

alexcrichton accepted this revision. alexcrichton added a comment. This revision is now accepted and ready to land. At least from my POV looks good :) Thanks for the quick patch! Should this link

[clang] 28518d9 - [InlineFunction] Handle return attributes on call within inlined body

Author: Anna Thomas Date: 2020-03-31T14:35:40-04:00 New Revision: 28518d9ae39ff5c6044e230d58b6ae28b0252cae URL: https://github.com/llvm/llvm-project/commit/28518d9ae39ff5c6044e230d58b6ae28b0252cae DIFF: https://github.com/llvm/llvm-project/commit/28518d9ae39ff5c6044e230d58b6ae28b0252cae.diff

[clang] d1b412a - [clang-format] Correct line breaks in C# generic type constraints

Author: Jonathan Coe Date: 2020-03-31T19:27:01+01:00 New Revision: d1b412ae389e4e30706c326ddec192ffb2e272cf URL: https://github.com/llvm/llvm-project/commit/d1b412ae389e4e30706c326ddec192ffb2e272cf DIFF: https://github.com/llvm/llvm-project/commit/d1b412ae389e4e30706c326ddec192ffb2e272cf.diff

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

sbc100 updated this revision to Diff 253935. sbc100 added a comment. strip in linker Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77115/new/ https://reviews.llvm.org/D77115 Files: clang/test/Driver/embed-bitcode-wasm.c

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. I'm glad to report that your suggestion worked out well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 ___ cfe-commits mailing list

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1589 : getObjFileLowering().getSectionForFunctionDescriptor(F, TM)); - +if (F->isDeclaration()) { + MCSymbolXCOFF *FSym = cast(getSymbol(F)); If it's

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk updated this revision to Diff 253933. rnk added a comment. - Remove definition data bit tracking, use destructor isUsed bit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77081/new/ https://reviews.llvm.org/D77081 Files:

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

teemperor added a comment. I am fine with this if we *really* need it for D75488 . So far the only direct place where we do need the module to be non-const was some redundant assignment for Name (I added a comment in D75488 ),

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1548 + + if (XCOFFSym->hasContainingCsect()) { +MCSymbolXCOFF *QualName = I hope we can find a better solution here. IMO, we don't even want to override this function in

[PATCH] D72872: [ObjC generics] Fix not inheriting type bounds in categories/extensions.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72872/new/ https://reviews.llvm.org/D72872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77064: [clang-format] Correct line breaks in C# generic type constraints

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Awesome! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77064/new/ https://reviews.llvm.org/D77064 ___ cfe-commits mailing list

[PATCH] D76083: [clang-tidy] Expand the list of functions in bugprone-unused-return-value

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnusedReturnValueCheck.cpp:98 + "::access;" + "::bind;" + "::connect;"

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1492 + +if (MAI->hasDotExternDirective()) { + MCSymbol *Name = getSymbol(); This query asked if the target supports .extern. However, .extern is not the only

[PATCH] D77064: [clang-format] Correct line breaks in C# generic type constraints

jbcoe updated this revision to Diff 253925. jbcoe added a comment. Fix failing test by preventing inconsistent states from being constructed where canBreak is false and mustBreak is true. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77064/new/ https://reviews.llvm.org/D77064 Files:

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1498 + } + emitLinkage(, Name); + continue; jasonliu wrote: > I'm surprised we do not enter here for `foo_ext_weak()`. The result of that > is we need to do

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

martong added a comment. Do you have a lit test as well? It would be useful to have one that is similar to the one you mention in the review's summary. Comment at: clang/lib/StaticAnalyzer/Checkers/ContainerModeling.cpp:780 + if (AggressiveEraseModeling) { +if (const

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

sbc100 added a comment. In D77115#1952536 , @alexcrichton wrote: > Seems reasonable to me! In my testing though if these existed as custom > sections they'd still make their way to the final binary through LLD, so > could LLD skip over these sectiosn

[clang] 94d9122 - [NFC] Do not run CGProfilePass when not using integrated assembler

Author: zhizhouy Date: 2020-03-31T10:31:31-07:00 New Revision: 94d912296de21e965198ba1ddd1ca6714b3e4722 URL: https://github.com/llvm/llvm-project/commit/94d912296de21e965198ba1ddd1ca6714b3e4722 DIFF: https://github.com/llvm/llvm-project/commit/94d912296de21e965198ba1ddd1ca6714b3e4722.diff

[clang] 753a324 - Make FunctionDecl::isDefined non-virtual, NFC

Author: Reid Kleckner Date: 2020-03-31T10:12:05-07:00 New Revision: 753a3245f7231ffd86b8af02e57da6ceb2ec5669 URL: https://github.com/llvm/llvm-project/commit/753a3245f7231ffd86b8af02e57da6ceb2ec5669 DIFF: https://github.com/llvm/llvm-project/commit/753a3245f7231ffd86b8af02e57da6ceb2ec5669.diff

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa76e68c9704f: [CodeComplete] Member completion for concept-constrained types. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77103: Add a new -fglobal-isel option and make -fexperimental-isel an alias for it.

dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77103/new/ https://reviews.llvm.org/D77103

[PATCH] D76432: [clangd] Add a tweak for adding "using" statement.

sammccall added a comment. Still LG, should I land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76432/new/ https://reviews.llvm.org/D76432 ___ cfe-commits mailing list

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Preamble.cpp:135 + CI.getLangOpts()->RecoveryAST = Inputs.Opts.BuildRecoveryAST; + There's no prospect of

[clang] a76e68c - [CodeComplete] Member completion for concept-constrained types.

Author: Sam McCall Date: 2020-03-31T18:43:24+02:00 New Revision: a76e68c9704fb5b3faf25bb8d51e405b5310ff08 URL: https://github.com/llvm/llvm-project/commit/a76e68c9704fb5b3faf25bb8d51e405b5310ff08 DIFF: https://github.com/llvm/llvm-project/commit/a76e68c9704fb5b3faf25bb8d51e405b5310ff08.diff

[PATCH] D77125: [Analyzer] Model return values of container insert and delete operations

martong added a comment. It seems like we could model here `emplace` and `emplace_after` exactly the same way we do with `insert` and `insert_after`, couldn't we? Perhaps that could go into this patch too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/include/clang/Sema/Sema.h:12248 + /// SYCLDiagIfDeviceCode(Loc, diag::err_type_unsupported) << "__float128"; + DeviceDiagBuilder SYCLDiagIfDeviceCode(SourceLocation Loc, unsigned

[PATCH] D77150: [Analyzer] New Option for ContainerModeling: AggressiveEraseModeling

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D76725: [clangd] Build ASTs only with fresh preambles or after building a new preamble

sammccall added a comment. Had some discussion offline. - having ASTWorker not worry about preamble validity before dispatching to preambleworker seems like a win - for this, preambleworker needs to call preambleReady whether it's new or not, so ASTWorker can produce diagnostics - AST reuse

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon updated this revision to Diff 253910. Fznamznon added a comment. Apply comments, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74387/new/ https://reviews.llvm.org/D74387 Files: clang/include/clang/Basic/Attr.td

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

martong created this revision. martong added reviewers: Szelethus, NoQ, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang.

[PATCH] D15469: Expose cxx constructor and method properties through libclang and python bindings.

mardy added a comment. In D15469#396582 , @jbcoe wrote: > I'll submit a new patch for `isDeleted` on its own. The rest of this patch > seems uncontentious. > > I hope to find time this week to make the changes. Was the patch for isDeleted ever

[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

sconstab updated this revision to Diff 253888. sconstab added a comment. Added a comment to the header of X86IndirectThunks.cpp to indicate support for LVI thunks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76812/new/ https://reviews.llvm.org/D76812 Files:

[PATCH] D77115: [WebAssembly] Emit .llvmcmd and .llvmbc as custom sections

alexcrichton added a comment. Seems reasonable to me! In my testing though if these existed as custom sections they'd still make their way to the final binary through LLD, so could LLD skip over these sectiosn by default? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5004 CXXCtorInitializer *Member = Initializers[i]; - +if (Member->getInit() && Member->getInit()->containsErrors()) + Constructor->setInvalidDecl();

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA planned changes to this revision. ZarkoCA added a comment. Fixing test case issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 ___ cfe-commits

[PATCH] D77142: [clangd] Add a flag to turn on recovery-expr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77142 Files:

[PATCH] D77056: RFC: [Sema][SVE] Allow non-member operators for SVE types

rsandifo-arm updated this revision to Diff 253867. rsandifo-arm edited the summary of this revision. rsandifo-arm added a comment. Require operators to be defined as static or inside a namespace Also remove redundant brackets and add more tests. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D76862: HIP: Ensure new denormal mode attributes are set

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76862/new/ https://reviews.llvm.org/D76862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

This revision was automatically updated to reflect the committed changes. Closed by commit rG71177ac16801: [clangd] Support new semanticTokens request from LSP 3.16. (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

sammccall added a comment. I like the idea, but it seems to regress quite a lot of diagnostics... e.g. where we fail to deduce auto and then say it's not a pointer. Also this is regressing things in the -fno-recovery-ast case, because of the changes to CheckDeclInExpr with the existing

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:5004 CXXCtorInitializer *Member = Initializers[i]; - +if (Member->getInit() &&

[clang-tools-extra] 71177ac - [clangd] Support new semanticTokens request from LSP 3.16.

Author: Sam McCall Date: 2020-03-31T15:14:35+02:00 New Revision: 71177ac16801ceced4b7dcdd21b05345416f31df URL: https://github.com/llvm/llvm-project/commit/71177ac16801ceced4b7dcdd21b05345416f31df DIFF: https://github.com/llvm/llvm-project/commit/71177ac16801ceced4b7dcdd21b05345416f31df.diff

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76342/new/ https://reviews.llvm.org/D76342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77119: [AVR] Fix function pointer address space

vlastik added a comment. In D77119#1952293 , @dylanmckay wrote: > Nice work @vlastik, do you need someone to commit this for you? Thanks, yes please I need someone to commit the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77119/new/

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76761: [clang-tidy] Fix crash in readability-redundant-string-cstr

This revision was automatically updated to reflect the committed changes. Closed by commit rG3807079d705f: [clang-tidy] Fix crash in readability-redundant-string-cstr (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76761/new/

[clang-tools-extra] 3807079 - [clang-tidy] Fix crash in readability-redundant-string-cstr

Author: Nathan James Date: 2020-03-31T13:27:32+01:00 New Revision: 3807079d705fe04c5c3bde8f848ec922b5771f15 URL: https://github.com/llvm/llvm-project/commit/3807079d705fe04c5c3bde8f848ec922b5771f15 DIFF: https://github.com/llvm/llvm-project/commit/3807079d705fe04c5c3bde8f848ec922b5771f15.diff

[PATCH] D77119: [AVR] Fix function pointer address space

dylanmckay added a comment. Nice work @vlastik, do you need someone to commit this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77119/new/ https://reviews.llvm.org/D77119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

Charusso added a comment. In D73521#1951776 , @ASDenysPetrov wrote: > Will this utility affect Visual Studio builds? The community owns like 50 build-bots, so it should affect all of them by default. I am hoping it will just work. CHANGES SINCE LAST

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/test/CodeGen/aarch64-neon-intrinsics-constrained.c:288 + +// XXX FIXME do we need to check for both w and x registers? +// COMMON-LABEL: test_vceq_f64 kpn wrote: > Anyone? I'm not an ARM expert. The is variants

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz marked an inline comment as done. tamas.petz added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:402 #undef VALUE_CODEGENOPT - danielkiss wrote: > is this change necessary? I think there should be one new line at the end

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

tamas.petz added a comment. Depends on: https://reviews.llvm.org/D77131 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77134/new/ https://reviews.llvm.org/D77134 ___ cfe-commits mailing list

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

danielkiss added a comment. just a nit, LGTM otherwise. Comment at: clang/include/clang/Basic/CodeGenOptions.def:402 #undef VALUE_CODEGENOPT - is this change necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77134: [clang][AARCH64] Add __ARM_FEATURE_{PAC, BTI}_DEFAULT defines

tamas.petz created this revision. tamas.petz added a reviewer: momchil.velikov. tamas.petz added a project: clang. Herald added subscribers: cfe-commits, danielkiss. tamas.petz added a comment. Depends on: https://reviews.llvm.org/D77131 As defined by Arm C Language Extensions (ACLE) these

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

tamas.petz created this revision. tamas.petz added a reviewer: momchil.velikov. tamas.petz added a project: clang. Herald added a subscriber: cfe-commits. danielkiss added a comment. tamas.petz marked an inline comment as done. just a nit, LGTM otherwise. Comment at:

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. > Why not just make half as an argument do the right thing for that case? That would be the ideal approach, but currently there's a limitation on the backend's calling convention lowering that gets in the way. The lowering of calls in `SelectionDAGBuilder` includes a

[PATCH] D76663: [clangd] Support new semanticTokens request from LSP 3.16.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76663/new/ https://reviews.llvm.org/D76663

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Herald added a subscriber: ASDenysPetrov. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-commits mailing list

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. LGTM! Thanks! But I am not that confident with the element regions and field regions, so @NoQ could you please take another look? Comment at:

[PATCH] D77125: [Analyzer] Model return values of container insert and delete operations

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

void edited subscribers, added: manojgupta; removed: cfe-commits. void added a comment. Friendly ping. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62627/new/ https://reviews.llvm.org/D62627 ___

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein updated this revision to Diff 253809. hokein marked an inline comment as done. hokein added a comment. - mark CtorDecl as invalid when the Initializer init expr contains errors - add a testcase that would crash the previous version of the patch Repository: rG LLVM Github Monorepo

[PATCH] D77039: [clang-format] Don't break multi block parameters on ObjCBreakBeforeNestedBlockParam

jolesiak accepted this revision. jolesiak added a comment. This revision is now accepted and ready to land. Makes sense, thanks for patching this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77039/new/ https://reviews.llvm.org/D77039

[PATCH] D77041: [AST] Fix a crash on invalid constexpr Ctorinitializer when building RecoveryExpr.

hokein added a comment. > This makes me nervous, marking the constructor as invalid seems much safer. > Can you show tests it regresses? Yeah, the first version of the patch doesn't seem to fix all crashes (X().Y would lead another crash)... so if we mark the CtorDecl as invalid 1. whenever

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

f00kat updated this revision to Diff 253803. f00kat marked an inline comment as done. f00kat added a comment. Fixed comments in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76996/new/ https://reviews.llvm.org/D76996 Files:

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

tbaeder added a comment. Sorry for taking so long but it seems like I've went down a rabbit hole a bit. My previous patch sets the range in `parseGNUAttributes()` unconditionally, but that seems to trigger cases such as // FixItLoc = possible correct location for the attributes void

[PATCH] D77119: [AVR] Fix function pointer address space

vlastik updated this revision to Diff 253802. vlastik added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77119/new/ https://reviews.llvm.org/D77119 Files: clang/lib/CodeGen/CodeGenTypes.cpp Index: clang/lib/CodeGen/CodeGenTypes.cpp

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcdce2fe561eb: [Syntax] Remove delayed folding from tree building. (authored by hlopko, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77119: [AVR] Fix function pointer address space

vlastik created this revision. vlastik added a reviewer: dylanmckay. Herald added subscribers: cfe-commits, Jim. Herald added a project: clang. Function pointers should be created with program address space. This fixes function pointers on AVR. Repository: rG LLVM Github Monorepo

[PATCH] D76996: [analyzer] Improve PlacementNewChecker

martong added inline comments. Comment at: clang/test/Analysis/placement-new.cpp:265 + + // bad 2(custom align) + 1(index '2' offset) + ::new ([1]) long; // expected-warning{{Storage type is aligned to 3 bytes but allocated type is aligned to 8 bytes}} expected-note 1 {{}}

[clang] cdce2fe - [Syntax] Remove delayed folding from tree building.

Author: Marcel Hlopko Date: 2020-03-31T09:47:50+02:00 New Revision: cdce2fe561eb6e63d77d1d589e521a8e2afb1eef URL: https://github.com/llvm/llvm-project/commit/cdce2fe561eb6e63d77d1d589e521a8e2afb1eef DIFF: https://github.com/llvm/llvm-project/commit/cdce2fe561eb6e63d77d1d589e521a8e2afb1eef.diff

[PATCH] D73521: [analyzer] add-new-checker.py: Introduction

ASDenysPetrov added a comment. Will this utility affect Visual Studio builds? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73521/new/ https://reviews.llvm.org/D73521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko added a comment. I propose adding those tests in a separate patch to keep this one focused. Those tests are currently failing, because: - we assume initializer, if present, is extending the declarator range, but `struct P {} p;` has initializer ending where declarator ended already. -

[PATCH] D76922: [Syntax] Remove delayed folding from tree building.

hlopko updated this revision to Diff 253787. hlopko marked an inline comment as done. hlopko added a comment. Remove unnecessary cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76922/new/ https://reviews.llvm.org/D76922 Files:

[PATCH] D75914: systemz: allow configuring default CLANG_SYSTEMZ_ARCH

uweigand added a comment. Thanks for working on this, @thakis ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75914/new/ https://reviews.llvm.org/D75914 ___ cfe-commits mailing list

[PATCH] D76182: [AVR] Support aliases in non-zero address space

dylanmckay added a comment. Nice patch by the way, the code looks fine, if we can get a basic test in here then it's good to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D76182

[PATCH] D76182: [AVR] Support aliases in non-zero address space

dylanmckay added a comment. I think we should add a test, it shouldn't be too hard I think. Look in `clang/tests`, grep for `alias`. Look like it is `extern const int __mod_usb_device_table __attribute__ ((alias("wacom_usb_ids")));`. If you copy paste a new test (use

<    1   2