[PATCH] D76896: Color dependent names based on their heuristic target if they have one

sammccall added a comment. Great! Needs some tests though :-) Comment at: clang-tools-extra/clangd/FindTarget.cpp:651 +void +VisitCXXDependentScopeMemberExpr(const CXXDependentScopeMemberExpr *E) { + Refs.push_back( Can you move these into some log

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

yaxunl added a comment. In D77743#1972258 , @hliao wrote: > In D77743#1970304 , @tra wrote: > > > In D77743#1970163 , @yaxunl wrote: > > > > > The kernel handle is a variable

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

hliao added a comment. In addition, we may also need to extend the registration to set up the mapping from that global variable to the host side stub function. `hipKernelLaunch` (implemented as a function call instead of the kernel launch syntax) to call into that stub function to prepare the a

[PATCH] D77682: [clang-format] Always break line after enum opening brace

MyDeveloperDay added a comment. I understand now what you are trying to achieve, could you capture something more like that in your tests too.. (just so we don't break this change later) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77682/new/ htt

[PATCH] D68049: Propeller: Clang options for basic block sections

dblaikie added a comment. In D68049#1971276 , @MaskRay wrote: > In D68049#1970825 , @tmsriram wrote: > > > Ping. > > > @rsmith ^^^ > > More specific question, do you think > `clang/test/CodeGen/basicblock-sections.

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

yaxunl added a comment. In D77743#1972292 , @hliao wrote: > In addition, we may also need to extend the registration to set up the > mapping from that global variable to the host side stub function. > `hipKernelLaunch` (implemented as a function call ins

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

hliao added a comment. In D77743#1972298 , @yaxunl wrote: > In D77743#1972292 , @hliao wrote: > > > In addition, we may also need to extend the registration to set up the > > mapping from that global variable to th

[clang] dd1ee6d - [RISCV] Support experimental/unratified extensions

Author: Simon Cook Date: 2020-04-09T18:04:22+01:00 New Revision: dd1ee6dc076fe1da6cf6eeb9cf614d9c1796759a URL: https://github.com/llvm/llvm-project/commit/dd1ee6dc076fe1da6cf6eeb9cf614d9c1796759a DIFF: https://github.com/llvm/llvm-project/commit/dd1ee6dc076fe1da6cf6eeb9cf614d9c1796759a.diff LO

[clang] 61ff296 - [RISCV] Add Clang frontend support for Bitmanip extension

Author: Scott Egerton Date: 2020-04-09T18:04:22+01:00 New Revision: 61ff29637501afcd7476e52064f7a266a95c6e28 URL: https://github.com/llvm/llvm-project/commit/61ff29637501afcd7476e52064f7a266a95c6e28 DIFF: https://github.com/llvm/llvm-project/commit/61ff29637501afcd7476e52064f7a266a95c6e28.diff

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram added a comment. In D68049#1972297 , @dblaikie wrote: > In D68049#1971276 , @MaskRay wrote: > > > In D68049#1970825 , @tmsriram > > wrote: > > > > > Ping. > > > > >

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

yaxunl added a comment. In D77743#1972301 , @hliao wrote: > In D77743#1972298 , @yaxunl wrote: > > > In D77743#1972292 , @hliao wrote: > > > > > In addition, we may also need

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers marked an inline comment as done. vabridgers added a comment. Ahhh yes, I see. I can get this done while we're waiting on https://reviews.llvm.org/D57226 to land. Thanks Gabor!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ h

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

vsavchenko updated this revision to Diff 256331. vsavchenko added a comment. Add extra check to be safe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 Files: clang/lib/StaticAnalyzer/Checkers/NonNullPara

[clang-tools-extra] eaa5559 - [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

Author: Matthias Gehre Date: 2020-04-09T19:26:41+02:00 New Revision: eaa55590945a130131a47a4d2b89e3bbdfced79e URL: https://github.com/llvm/llvm-project/commit/eaa55590945a130131a47a4d2b89e3bbdfced79e DIFF: https://github.com/llvm/llvm-project/commit/eaa55590945a130131a47a4d2b89e3bbdfced79e.diff

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256332. mwyman marked 2 inline comments as done. mwyman added a comment. Adding non-object types for argument to getArgument:atIndex: to verify they don't cause problems. Done while investigating Harbormaster failures. Repository: rG LLVM Github Monorepo

[PATCH] D77743: [HIP] Emit symbols with kernel name in host binary

hliao added a comment. The ambiguity issue is still there. That `__global__` function generates different code if it's compiled as HIP by clang or non-HIP code by clang or other compilers. That will break the resolving from the symbol value to its device kernel name. CHANGES SINCE LAST ACTION

[PATCH] D77545: Represent FP options in AST by special Expression node

sepavloff added a comment. The solution in D76384 (Move FPFeatures from BinaryOperator bitfields to Trailing storage) causes several concerns. 1. It requires substantial code changes. The patch in D76384 is already large and we

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

tra added a comment. The patch could use a more detailed description. Specifically, it does not describe the purpose of these changes. > Replace them with the internal version, i.e. nvvm.texsurf.handle.internal > just before the instruction selector. It's not clear what is 'them'. 'nvvm.texsur

[PATCH] D77811: [clangd] WIP playing with semantic highlighting modifiers

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77811 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp cl

[PATCH] D73307: Unique Names for Functions with Internal Linkage

rnk added a comment. Regarding the alias attribute, it occurs to me that reimplementing this as an early LLVM pass would not have that problem. Do you think that would be worth doing? Comment at: clang/docs/UsersManual.rst:1684 + linkage symbols. The unique name is obtained

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:254 + +Example +=== SjoerdMeijer wrote: > Hi Florian, just reading this for the first time, this is cool stuff, and > just a drive-by comment: > >

[PATCH] D73967: Implement _ExtInt as an extended int type specifier.

erichkeane added a comment. Ping! My understanding is that WG14 gave a very positive response to this, so I'd love to get this into clang so that we can get more user interaction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73967/new/ https://reviews.llvm.org/D73967 _

[PATCH] D77721: [ASTImporter] Add support for importing fixed point literals

vabridgers updated this revision to Diff 256339. vabridgers added a comment. Incorporate Gabor's suggestion for improving test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77721/new/ https://reviews.llvm.org/D77721 Files: clang/include

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

jasonliu added a comment. This is landed in https://github.com/llvm/llvm-project/commit/085689d44cb95604072d0f2b130167d9410ea155. Not sure why it does not close automatically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://review

[PATCH] D77571: [clang-tidy] Add check to find calls to NSInvocation methods under ARC that don't have proper object argument lifetimes.

mwyman updated this revision to Diff 256344. mwyman added a comment. Add check for isScalarType before getting the type, which seems to be triggering an assert. Maybe this is a Mac vs Linux thing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77571

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

sammccall added a comment. Some context for me: I did also start some work on supporting modifiers, and after some experiments with VSCode concluded it was too early (no support in any shipped themes, I saw some hard-to-explain interactions with the default syntax highlighting...). My plan was

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

nand updated this revision to Diff 256346. nand marked 15 inline comments as done. nand added a comment. addressed comments, fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files: clang/docs/C

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

nand added a comment. Thanks for the comments! I tried to clarify what could be done in the future and what is already supported. Comment at: clang/docs/ConstantInterpreter.rst:174 A block containing a primitive reserved storage only for the primitive.

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4205 + +class PPCAIX32TargetCodeGenInfo : public TargetCodeGenInfo { +public: Xiangling_L wrote: > sfertile wrote: > > Xiangling_L wrote: > > > I

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

efriedma removed a reviewer: eli.friedman. efriedma added a comment. Looks roughly fine to me, but I'm not an appropriate reviewer for static analyzer code. Comment at: clang/lib/Analysis/CFG.cpp:2859 // Of everything that can be declared in a DeclStmt, only VarDecls impa

[PATCH] D77776: [Driver] Drop support for FreeBSD < 10

dim added a comment. In D6#1971543 , @arichardson wrote: > Alternatively, the checks could be changed to also handle OSMajorVersion == 0 > and translate that to 10. > This seems to be what NetBSD.cpp does. Darwin.cpp also infers the version > from t

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei updated this revision to Diff 256350. wenlei added a comment. address feedback, allow functions within a module to have different vectlib setting. add test case for inline compatibility check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 256351. ZarkoCA marked 2 inline comments as done. ZarkoCA added a comment. Rebased on https://reviews.llvm.org/D73290 and this patch now depends on it. Removed PPCAIX32TargetCodegenClass from previous diff. Corrected behaviour `PPC32TargetCodeGenInfo::initDwar

[PATCH] D77682: [clang-format] Always break line after enum opening brace

osandov updated this revision to Diff 256352. osandov edited the summary of this revision. osandov added a comment. Update summary and test case to better reflect the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77682/new/ https://reviews.ll

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added a comment. A couple minor comments, but patch is almost ready otherwise. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4249 uint64_t Size; // -msvr4-struct-return puts small aggregates in GPR3 and GPR4. Pedantic nit: Can we emit a fatal er

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ADRAADRA added a comment. In D77451#1970461 , @tra wrote: > Thank you for the patch. I assume you don't have commit access to LLVM. I can > land the patch for you. > How should I attribute it? Will `ADRA ` (used in > phabricator emails) do or do you pr

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

morehouse accepted this revision. morehouse added a comment. Thanks again for the patch. Sorry about the delay in landing it; I'll work on it today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63616/new/ https://reviews.llvm.org/D63616 _

[PATCH] D77701: [Sema] refactor static functions into private methods NFC

dblaikie added a comment. Yeah, if these were already member-function static, I'd agree it was a code smell - but function-scope static functions that take "this" as the first parameter don't seem like a bad thing to me - it reduces the header surface area/dependence. Repository: rG LLVM Gi

[PATCH] D77395: [AST] Dont invalidate VarDecl even the default initializaiton is failed.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. the `attempt to use a deleted function` diagnostic is a bit spammy, because the default-constructor and destructor are often deleted for similar reasons. But I guess this is probably OK,

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76269/new/ https://reviews.llvm.org/D76269 __

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet updated this revision to Diff 256359. kadircet added a comment. Herald added a subscriber: mgorny. - Encapsulate logic into `PreamblePatch` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77392/new/ https://reviews.llvm.org/D77392 Files:

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson added a comment. Great, thanks! A few minor comments below. Looks like it needs a clang-format too. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + Suggest moving the implementatio

[PATCH] D77777: [nvptx] Add `nvvm.texsurf.handle` internalizer.

hliao added a comment. In D7#1972349 , @tra wrote: > The patch could use a more detailed description. Specifically, it does not > describe the purpose of these changes. > > > Replace them with the internal version, i.e. nvvm.texsurf.handle.internal >

[PATCH] D77392: [WIP][clangd] Make signatureHelp work with stale preambles

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1076 + if (PatchAdditionalIncludes) { +for (const auto &Inc : newIncludes( + Input.Preamble.LexedIncludes, sammccall

[clang] 6ed88af - [CUDA] Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

Author: ADRA Date: 2020-04-09T13:08:41-07:00 New Revision: 6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b URL: https://github.com/llvm/llvm-project/commit/6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b DIFF: https://github.com/llvm/llvm-project/commit/6ed88afd780cc2cd04e50e25c5d3ffafc07b1c1b.diff LOG: [CU

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

sammccall added a comment. Yeah, so I guess the point of marking decls invalid is in large part to stop recovery using it. It's not surprising 1 has recovery regressions. 3 should have fewer (basically because you'll get the dependent bits too), but likely still some. 2 definitely seems the way

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rG085689d44cb9: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX (authored by jasonliu). Changed prior to commit: https://reviews.llvm.org/D76130?vs=255321&id=256367#toc Reposi

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd1ee6dc076f: [RISCV] Support experimental/unratified extensions (authored by simoncook). Changed prior to commit: https://reviews.llvm.org/D73891?vs=250770&id=256369#toc Repository: rG LLVM Github M

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG61ff29637501: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton, committed by simoncook). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D77680: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda

This revision was automatically updated to reflect the committed changes. Closed by commit rGeaa55590945a: [clang-tidy] misc-unused-parameters: Don't remove parameter from lambda (authored by mgehre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D776

[PATCH] D77621: Change BitcodeWriter buffer to std::vector instead of SmallVector.

dblaikie added a comment. In D77621#1970015 , @dexonsmith wrote: > In D77621#1968647 , @browneee wrote: > > > Do we want to increase the complexity of SmallVector somewhat? or do we > > want to keep the limit and a

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ed88afd780c: [CUDA] Accept -x cu to indicate language is CUDA, transfer CUDA language flag… (authored by ADRAADRA, committed by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: Syntax error here, master is broken Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei marked 4 inline comments as done. wenlei added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + tejohnson wrote: > Suggest moving the implementation of this constructor t

[PATCH] D76078: [AArch64][SVE] Add a pass for SVE intrinsic optimisations

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76078/new/ https://reviews.llvm.org/D76078 ___ cfe-commits mailing list cfe-commi

[clang] 2a1418f - Fix syntax error

Author: Christopher Tetreault Date: 2020-04-09T13:46:23-07:00 New Revision: 2a1418f242ab17d8d8fef6fe829fc1b9363877ca URL: https://github.com/llvm/llvm-project/commit/2a1418f242ab17d8d8fef6fe829fc1b9363877ca DIFF: https://github.com/llvm/llvm-project/commit/2a1418f242ab17d8d8fef6fe829fc1b9363877

[PATCH] D77825: Fix syntax error

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ctetreau added reviewers: tra, sammccall, ADRAADRA. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D77825 Files: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp Index

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

ctetreau added inline comments. Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:119 + case types::TY_CUDA_DEVICE: +return types::TY_CUDA: default: ctetreau wrote: > Syntax error here, master is broken I went ahead and fixed it. https:/

[PATCH] D76269: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs.

This revision was automatically updated to reflect the committed changes. Closed by commit rG836ce9db7f13: [opaque pointer types] Remove deprecated Instruction/IRBuilder APIs. (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D76269?vs=254971&id=256395#toc Repository:

[PATCH] D77825: Fix syntax error

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG2a1418f242ab: Fix syntax error (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA updated this revision to Diff 256398. ZarkoCA edited the summary of this revision. ZarkoCA added a comment. Addressed comments -added error for -msvr4-struct-return on AIX and modified appropriate test case -changed code structure as per comment -renamed test file Repository: rG LLVM G

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + wenlei wrote: > tejohnson wrote: > > Suggest moving the implementation of this constructor to the .cpp file, in

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion added a comment. In D70366#1971137 , @dexonsmith wrote: > In D70366#1970758 , @jdoerfert wrote: > > > In D70366#1970526 , @dexonsmith > > wrote: > > > > > In

[PATCH] D77451: Accept -x cu to indicate language is CUDA, transfer CUDA language flag to header-file arguments

tra added a comment. Thank you! A apologize for not checking the patch before landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77451/new/ https://reviews.llvm.org/D77451 ___ cfe-commits mailin

[PATCH] D77611: [Sema] Check calls to __attribute__((warn_unused_result)) from StmtExprs

dblaikie added a comment. In D77611#1968236 , @nickdesaulniers wrote: > In D77611#1968227 , @dblaikie wrote: > > > Looks like GCC warns on everything but the last unused expression (the last > > one being the retu

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

rnk added a comment. I'm going to go ahead and push this today. Richard hasn't stamped it, but I did incorporate the feedback, and I'm fairly happy with the results and confident that I addressed the feedback adquately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[clang] 55efb68 - [MS] Mark vbase dtors used when marking dtor used

Author: Reid Kleckner Date: 2020-04-09T14:19:36-07:00 New Revision: 55efb68c19b4911f780ec4d074f8ff2f8529883f URL: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f DIFF: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f.diff

[PATCH] D77669: [clangd] Update TUStatus test to handle async PreambleThread

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Now having read it, I'm slightly nervous we're not catching all the interleavings. An alternate approach if this is too messy would be just to capture the two streams of enums in

[PATCH] D77374: Fix -fsanitize=array-bounds with comma operator

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:882-887 + while (const BinaryOperator *BO = dyn_cast(E)) { +if (!BO->isCommaOp()) + break; +E = BO->getRHS(); +E = E->IgnoreParens(); + } ---

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau updated this revision to Diff 256408. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/ https://reviews.llvm.org/D77257 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp cl

[PATCH] D77702: [clangd] Use token modifiers and more token types for semanticTokens

nridge added a comment. Thanks for your thoughts! In D77702#1972495 , @sammccall wrote: > Some context for me: I did also start some work on supporting modifiers, and > after some experiments with VSCode concluded it was too early (no support in > any s

[PATCH] D77081: [MS] Mark vbase dtors ref'd when ref'ing dtor

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG55efb68c19b4: [MS] Mark vbase dtors used when marking dtor used (authored by rnk). Changed prior to commit: https://rev

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

sammccall added a comment. Can't believe we didn't do this before. Nice catch. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:97 +/// paths used by \p FileSyms. +void shardSlabToFiles(const SymbolSlab &Syms, const RelationSlab &Rels, + FileSymbols

[PATCH] D77831: [clang-tidy] Convert config options that are bools to use the bool overload of get(GlobalOrLocal)?

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. This was done with a script that looks for calls to Options.get(GlobalOrLocal) that take an integer for

[PATCH] D76831: [AST] Preserve the DeclRefExpr when it refers to an invalid decl.

rsmith added a comment. Generally I think we should be moving towards finer-grained "invalid" / "contains errors" bits, so that we can preserve as much of the AST as possible and produce accurate diagnostics for independent errors wherever possible. To that end, I think generally the "invalid"

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a comment. In D70366#1972880 , @LevitatingLion wrote: > In D70366#1971137 , @dexonsmith > wrote: > > > In D70366#1970758 , @jdoerfert > > wrote: > > > > >

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal updated this revision to Diff 256420. steakhal marked 4 inline comments as done. steakhal added a comment. - add full diff context - NFC refactored `RangeSet` comparison function - add tests for compund `RangeSet`s like: `{[0,1],[5,6]} < {[9,9],[11,42],[44,44]}` - NFC clang-format test f

[PATCH] D77792: [analyzer] Extend constraint manager to be able to compare simple SymSymExprs

steakhal added a comment. In D77792#1971921 , @Szelethus wrote: > You seem to have forgotten `-U` :^) Nice catch! Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:774 +Optional RangeConstraintManager::tryAssu

[libunwind] f3d460c - [libunwind] Clean up __arm64__

Author: Fangrui Song Date: 2020-04-09T15:46:48-07:00 New Revision: f3d460ce5874e4dd12b8cf8b227de4cec43a685c URL: https://github.com/llvm/llvm-project/commit/f3d460ce5874e4dd12b8cf8b227de4cec43a685c DIFF: https://github.com/llvm/llvm-project/commit/f3d460ce5874e4dd12b8cf8b227de4cec43a685c.diff

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. In D77545#1972344 , @sepavloff wrote: > The solution in D76384 (Move FPFeatures > from BinaryOperator bitfields to Trailing storage) causes several concerns. > > 1. It requires substantial code c

[PATCH] D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang

morehouse requested changes to this revision. morehouse added a comment. This revision now requires changes to proceed. In D63616#1961449 , @tuktuk wrote: > Am I missing an additional step for test integration, after adding the test > file? Just tried l

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan created this revision. leonardchan added reviewers: rsmith, aaron.ballman. leonardchan added a project: clang. `noderef` was failing to trigger warnings in some cases related to c++ style casting. This patch addresses them. Repository: rG LLVM Github Monorepo https://reviews.llvm

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith added a comment. Code change LGTM. Is there a way to add a `MemoryBuffer` unit test for the change to `shouldUseMmap`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

sammccall added a comment. Naming throughout - sorry to be a pain. I think "shared index" is less precise than it could be. WDYT about "Remote index"? Comment at: clang-tools-extra/clangd/CMakeLists.txt:156 + +option(GRPC_INSTALL_PATH "Path to gRPC library installation." OFF)

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

sammccall added a comment. Oops, hit enter too soon. Well done getting this to work, will patch it and try out locally. Comment at: clang-tools-extra/clangd/index/shared/SharedIndexServer.cpp:43 +// FIXME(kbobyrev): This is copied +std::vector getSymbolIDsFromIndex(llvm::Strin

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

jdoerfert added a subscriber: probinson. jdoerfert added a comment. Found the commit: dcbe35bad518 The way I see it we just have to teach the inliner about `optnone` so we can uncouple the two (`optnone` and `noinline`). @probinson WDTY? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul updated this revision to Diff 256436. sthibaul marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/Gnu.h clang/lib/Driver/ToolChain

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

sthibaul marked 2 inline comments as done. sthibaul added a comment. In D73845#1971282 , @MaskRay wrote: > Moving functions from Linux.cpp to Gnu.cpp is definitely appropriate. Have > you made any adjustment? No, it's really pure code move (and the requ

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei updated this revision to Diff 256437. wenlei marked an inline comment as done. wenlei added a comment. Herald added subscribers: haicheng, eraman. address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77632/new/ https://reviews.llvm

[PATCH] D50256: [Analyzer] Basic support for multiplication and division in the constraint manager (for == and != only)

vabridgers added a comment. ping! Any chance of this patch being accepted? This patch can help some SA false positives. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50256/new/ https://reviews.llvm.org/D50256 ___ cfe-commits mailing list c

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

wenlei marked 4 inline comments as done. wenlei added inline comments. Comment at: llvm/include/llvm/Analysis/TargetLibraryInfo.h:272 +else + VectLibrary = Impl.ClVectorLibrary; + tejohnson wrote: > wenlei wrote: > > tejohnson wrote: > > > Suggest moving

[PATCH] D49074: [Analyzer] Basic support for multiplication and division in the constraint manager

vabridgers added a comment. ping! Any chance of this patch being accepted? This patch can help some SA false positives. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49074/new/ https://reviews.llvm.org/D49074 ___ cfe-commits mailing list c

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

Bigcheese added a comment. Not really. It's a static function in MemoryBuffer.cpp, and the `MemoryBuffer` class doesn't have a `Kind` member so we can't check for `MemoryBufferMMapFile`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ htt

[PATCH] D77632: [TLI] Per-function fveclib for math library used for vectorization

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm. I think one check is missing in the test, see comment below. Comment at: llvm/test/Transforms/Inline/veclib-compat.ll:28 + %rslt = call i32 @callee_massv(i8 123)

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio accepted this revision. dnsampaio added a comment. This revision is now accepted and ready to land. LGTM, not forgetting to remove the exit comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77074/new/ https://reviews.llvm.org/D77074 ___

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith added a comment. In D2#1973250 , @Bigcheese wrote: > Not really. It's a static function in MemoryBuffer.cpp, and the > `MemoryBuffer` class doesn't have a `Kind` member so we can't check for > `MemoryBufferMMapFile`. Ah, but there's a vt

[PATCH] D73845: [Gnu toolchain] Move GCC multilib/multiarch paths support from Linux to Gnu

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! You may need to wait for @phosek to confirm. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73845/new/ https://reviews.llvm.org/D73845 ___

[PATCH] D77774: [OpenMP] Allow to go first in C++-mode in target regions

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. The cmath/math.h story makes me sad, but this is a good workaround. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D4/

[PATCH] D77794: [clangd] Pull installed gRPC and introduce shared-index-(server|client)

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:135 ) add_subdirectory(refactor/tweaks) can you somewhere (shared/README.md?) write down how to get the build working on at least one platform? e.g. 1. install `libgrpc+

[PATCH] D77766: [clangd] Set up machinery for gtests of ClangdLSPServer.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/unittests/LSPClient.cpp:65 + + void reply(llvm::json::Value ID, + llvm::Expected V) override { kadircet wrote: > put methods before fields Done - I don't care much, but curious whe

<    1   2   3   >