[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

george.burgess.iv added a comment. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78162/new/ https://reviews.llvm.org/D78162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77885: AMDGPU: Search for new ROCm bitcode library structure

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:75 +// The desired structure is (${ROCM_ROOT} or +// ${OPENCL_ROOT})/amdgcn/bitcode/*, so try to detect this layout. with your change, the structure becomes

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. Minor fixes, then LGTM. Comment at: clang/lib/AST/ASTImporter.cpp:6807 + importChecked(Err, ToComputationLHSType), + importChecked(Err, ToComputationResultType)); } Oh, these two calls need to use

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbab6df86aefc: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants… (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D78171?vs=257565=257808#toc

[PATCH] D78204: [AArch64][SVE] Remove LD1/ST1 dependency on llvm.masked.load/store

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Practically, I'm not sure you're really getting much benefit out of this; there's very little common code that touches MLOAD/MSTORE nodes anyway. But, sure, LGTM. Repository: rG LLVM

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: arphaman, guansong, yaxunl, jholewinski. Herald added a project: clang. Added codegen for scandirectives in simd loop. The codegen transforms original code: int x = 0; #pragma omp simd

[PATCH] D78171: Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: clang/lib/AST/Decl.cpp:897-898 +// Fall through. +// FIXME: Should GUIDs receive hidden visibility? We give them DSO-local +// linkage in CodeGen. + rnk wrote: > I

[clang] 25db295 - [NFC] Silence compiler warning [-Wmissing-braces].

Author: Huihui Zhang Date: 2020-04-15T11:46:05-07:00 New Revision: 25db295756beffdeeb7e2efc134790c2d3f1ada9 URL: https://github.com/llvm/llvm-project/commit/25db295756beffdeeb7e2efc134790c2d3f1ada9 DIFF: https://github.com/llvm/llvm-project/commit/25db295756beffdeeb7e2efc134790c2d3f1ada9.diff

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 , thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77592: [NFC][CodeGen] Add enum for selecting the layout of components in the vtable

leonardchan updated this revision to Diff 257786. leonardchan retitled this revision from "[NFC}[CodeGen] Make VTable initialization a method of CGCXXABI" to "[NFC][CodeGen] Add enum for selecting the layout of components in the vtable". leonardchan edited the summary of this revision.

[clang] 14d89bf - [ASTMatchers] Fix isDerivedFrom for recursive templates

Author: Jan Korous Date: 2020-04-15T12:49:01-07:00 New Revision: 14d89bfbe0b4f633689d829145fc9f0bfdb07b6e URL: https://github.com/llvm/llvm-project/commit/14d89bfbe0b4f633689d829145fc9f0bfdb07b6e DIFF: https://github.com/llvm/llvm-project/commit/14d89bfbe0b4f633689d829145fc9f0bfdb07b6e.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

This revision was automatically updated to reflect the committed changes. Closed by commit rG2ba4e3a4598b: Move BinaryOperators.FPOptions to trailing storage (authored by mibintc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

efriedma added a comment. For (1), I can see your point that it's sort of a balancing act. But generally, I'm concerned about making fragile assumptions: here, that LocalDeclMap contains precisely the two ImplicitParmDecls for the arguments, and nothing else. If we are going to assume that,

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG6a78c55e3af0: [clangd] Fix a crash for accessing a null field decl returned by… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77612: [ASTMatchers] Fix isDerivedFrom for recursive templates

This revision was automatically updated to reflect the committed changes. Closed by commit rG14d89bfbe0b4: [ASTMatchers] Fix isDerivedFrom for recursive templates (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[PATCH] D78235: [clangd] Store ppdirective in Inclusion

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This will enable PreamblePatching proposed in D77392 craft a more

[clang] 30853cd - Attempt to fix build with MSVC.

Author: Richard Smith Date: 2020-04-15T13:28:24-07:00 New Revision: 30853cd689efd73a005163436673c13a29eca805 URL: https://github.com/llvm/llvm-project/commit/30853cd689efd73a005163436673c13a29eca805 DIFF: https://github.com/llvm/llvm-project/commit/30853cd689efd73a005163436673c13a29eca805.diff

[clang] 57acbae - Improve diagnostic when constant-evaluating a std::initializer_list with

Author: Richard Smith Date: 2020-04-15T13:28:24-07:00 New Revision: 57acbaece1ace979e6a9382d9d517d48895b9ef7 URL: https://github.com/llvm/llvm-project/commit/57acbaece1ace979e6a9382d9d517d48895b9ef7 DIFF: https://github.com/llvm/llvm-project/commit/57acbaece1ace979e6a9382d9d517d48895b9ef7.diff

[PATCH] D77596: [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat

sdesmalen updated this revision to Diff 257824. sdesmalen retitled this revision from "[SveEmitter] Add NoOverload flag and builtin for svpfalse" to "[SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat". sdesmalen edited the summary of this revision. sdesmalen

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 257827. DiggerLin marked 2 inline comments as done. DiggerLin added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 Files:

[PATCH] D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D77595: [SveEmitter] Add builtins for svwhile. sdesmalen added a child revision: D78239: [SveEmitter] Add

[PATCH] D78239: [SveEmitter] Add builtins for FP conversions

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78238: [SveEmitter] Add builtins for svwhilerw/svwhilewr. sdesmalen added a child revision: D77597:

[PATCH] D77597: [SveEmitter] Add ExpandOp1SVALL and builtin for svptrue

sdesmalen updated this revision to Diff 257834. sdesmalen added a comment. rebased patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77597/new/ https://reviews.llvm.org/D77597 Files: clang/include/clang/Basic/TargetBuiltins.h clang/include/clang/Basic/arm_sve.td

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1984683 , @mibintc wrote: > In D76384#1984584 , @rjmccall wrote: > > > I *would* like an NFC patch first that renames `FPFeatures` to something > > like `CurFPFeatures` in order

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 23 inline comments as done. gamesh411 added a comment. Answered most review comments. Thanks for the reviewers @balazske, @martong so far. The question of absolute path policy is still up for debate. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:365

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. In D75184#1984565 , @DmitryPolukhin wrote: > I didn't notice the issue because of massive breakage with diff landed just > be bore mine Sorry about that :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 591be7e - [Format] Work around current vim bugs in clang-format.py

Author: Sam McCall Date: 2020-04-15T20:11:14+02:00 New Revision: 591be7ec500c151d9232366042e21c74e006292c URL: https://github.com/llvm/llvm-project/commit/591be7ec500c151d9232366042e21c74e006292c DIFF: https://github.com/llvm/llvm-project/commit/591be7ec500c151d9232366042e21c74e006292c.diff

[PATCH] D78125: [AVR] Use the correct address space for non-prototyped function calls

rjmccall accepted this revision. rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78125/new/ https://reviews.llvm.org/D78125 ___ cfe-commits mailing list

[PATCH] D78162: [CodeGen] Mark inline definitions of builtins as nobuiltin only if we plan to emit them.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dd17ff08165: [CodeGen] only add nobuiltin to inline builtins if well emit them (authored by george.burgess.iv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] b2d8c89 - Remove false positive in AvoidNonConstGlobalVariables.

Author: Kim Viggedal Date: 2020-04-15T14:48:06-04:00 New Revision: b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 URL: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8 DIFF: https://github.com/llvm/llvm-project/commit/b2d8c89ea48beb83e0392b1f00c9eafa33c09ca8.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. In D76384#1984498 , @mibintc wrote: > Responding to @rjmccall 's review. John, after this is approved I want to > proceed with pragma float_control as proposed in D72841 > . Can you recommend

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis sorry, I didn't notice the issue because of massive breakage with diff landed just be bore mine and also cmake issues on Windows bots. Thank you for trying to fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, and this patch LGTM, thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384

[PATCH] D78233: [NFC] Correcting minor typo.

ncv created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ncv added a reviewer: xazax.hun. Herald added a subscriber: rnkovacs. Hande -> Handle Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78233 Files:

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @thakis, I don't see this bot on LLVM http://lab.llvm.org:8011/console Windows bots there still fail due to cmake issues. The issue is very real and thank you for pointing out but how should I find the bot? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

leonardchan updated this revision to Diff 257800. leonardchan marked an inline comment as done. leonardchan edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389 Files:

[clang] 92e8af0 - [Clang] Expose RequiresNullTerminator in FileManager.

Author: Michael Spencer Date: 2020-04-15T14:17:51-07:00 New Revision: 92e8af0ecbe7eb36bc03a211afa9151c81b7b531 URL: https://github.com/llvm/llvm-project/commit/92e8af0ecbe7eb36bc03a211afa9151c81b7b531 DIFF:

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

mgehre updated this revision to Diff 257774. mgehre marked an inline comment as done. mgehre added a comment. Implement review comments (Thanks!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78139/new/ https://reviews.llvm.org/D78139 Files:

[clang] 2ba4e3a - Move BinaryOperators.FPOptions to trailing storage

Author: Melanie Blower Date: 2020-04-15T12:57:31-07:00 New Revision: 2ba4e3a4598b165245c581c506a813cd4a7dce33 URL: https://github.com/llvm/llvm-project/commit/2ba4e3a4598b165245c581c506a813cd4a7dce33 DIFF:

[PATCH] D77595: [SveEmitter] Add builtins for svwhile

sdesmalen updated this revision to Diff 257829. sdesmalen retitled this revision from "[SveEmitter] Add NoAuto flag and builtins for svwhile." to "[SveEmitter] Add builtins for svwhile". sdesmalen edited the summary of this revision. sdesmalen added a comment. - The function that returns a list

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin marked 8 inline comments as done. DiggerLin added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:441 + case GlobalValue::ExternalWeakLinkage: +if (TM.getTargetTriple().isOSBinFormatXCOFF()) { + OutStreamer->emitSymbolAttribute(GVSym,

[PATCH] D77982: [Windows SEH] Fix the frame-ptr of a nested-filter within a _finally

tentzen added a comment. The fix there deals with SEH filter with SEH _finally parent where its prototype is FIXED (2 implicit parameters). It will never change. For #2, "...I was thinking you would save the ImplicitParmDecl*, not the actual alloca". If we just savw ImplicitParmDecl, we

[PATCH] D78198: [Format] Work around current vim bugs in clang-format.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG591be7ec500c: [Format] Work around current vim bugs in clang-format.py (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78198/new/

[PATCH] D70416: [Driver] Make -static-libgcc imply static libunwind

MaskRay closed this revision. MaskRay added a comment. Closed by 6551ac7489fe070a2edcfac88f68c93321cba9a9 The commit does not have `Differential Revision: ...` so the differential is not closed automatically. Repository:

[PATCH] D78223: [clang-tidy] performance-range-for-copy only for copy.

EricWF created this revision. EricWF added reviewers: fowles, shuaiwang. EricWF added a project: clang-tools-extra. Herald added subscribers: mgehre, xazax.hun. Currently the range-for-copy incorrectly suggests changing a by-value loop var to a reference to avoid copies even when: (1) A

[clang] bab6df8 - Rework how UuidAttr, CXXUuidofExpr, and GUID template arguments and constants are represented.

Author: Richard Smith Date: 2020-04-15T12:20:42-07:00 New Revision: bab6df86aefc5ea4aa3895da7cf46be37add676d URL: https://github.com/llvm/llvm-project/commit/bab6df86aefc5ea4aa3895da7cf46be37add676d DIFF: https://github.com/llvm/llvm-project/commit/bab6df86aefc5ea4aa3895da7cf46be37add676d.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > In D76384#1984498 , @mibintc wrote: > > > Responding to @rjmccall 's review. John, after this is approved I want to > > proceed with pragma

[PATCH] D78233: [NFC] Correcting minor typo.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78233/new/ https://reviews.llvm.org/D78233

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

rsmith abandoned this revision. rsmith added a comment. Superseded by https://reviews.llvm.org/D78171. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77962/new/ https://reviews.llvm.org/D77962 ___

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

efriedma added a comment. > Where is the size expression actually evaluated? Is it evaluated at the point > of the typedef or at the point of the variable definition? At the point of the typedef. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc added a comment. In D76384#1984584 , @rjmccall wrote: > I *would* like an NFC patch first that renames `FPFeatures` to something like > `CurFPFeatures` in order to more clearly distinguish it from `FPOptions` in > Sema code, though. That should

[PATCH] D72959: Relative VTables ABI on Fuchsia

phosek added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:353 COMPATIBLE_VALUE_LANGOPT(MaxTokens, 32, 0, "Max number of tokens per TU or 0") +LANGOPT(FuchsiaRelativeCXXABIVTables, 1, 0, +"Whether to use clang's relative C++ ABI "

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e8af0ecbe7: [Clang] Expose RequiresNullTerminator in FileManager. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D2?vs=256722=257852#toc Repository: rG LLVM Github

[clang] 50472c4 - Remove extra ‘;’. NFC.

Author: Michael Liao Date: 2020-04-15T17:22:03-04:00 New Revision: 50472c422cc6d27a4532a4025c4339fb6920 URL: https://github.com/llvm/llvm-project/commit/50472c422cc6d27a4532a4025c4339fb6920 DIFF: https://github.com/llvm/llvm-project/commit/50472c422cc6d27a4532a4025c4339fb6920.diff

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257789. mibintc added a comment. Responding to @rjmccall 's review. John, after this is approved I want to proceed with pragma float_control as proposed in D72841 . Can you recommend an approach, do you think I will need

[PATCH] D61716: [libclang] Expose AtomicType

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61716/new/ https://reviews.llvm.org/D61716

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257794. ekatz added a comment. Changed the name of the test file to pr45476.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp clang/test/CodeGen/pr45476.cpp

[clang-tools-extra] 6a78c55 - [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

Author: Haojian Wu Date: 2020-04-15T21:42:27+02:00 New Revision: 6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3 URL: https://github.com/llvm/llvm-project/commit/6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3 DIFF: https://github.com/llvm/llvm-project/commit/6a78c55e3af0fc98513bf7e0b76b3b88719ca2c3.diff

[clang] 0b21f15 - [NFC] Correcting minor typo.

Author: Nate Voorhies Date: 2020-04-15T13:36:22-07:00 New Revision: 0b21f15e141737e421845b4a1993c7521af86ae6 URL: https://github.com/llvm/llvm-project/commit/0b21f15e141737e421845b4a1993c7521af86ae6 DIFF: https://github.com/llvm/llvm-project/commit/0b21f15e141737e421845b4a1993c7521af86ae6.diff

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA marked an inline comment as done. ZarkoCA added inline comments. Comment at: clang/test/CodeGen/ppc32-struct-return.c:53 + +// AIX-SVR4: fatal error: error in backend: -msvr4-struct-return not supported on AIX + jasonliu wrote: > jasonliu wrote: > >

[PATCH] D78233: [NFC] Correcting minor typo.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b21f15e1417: [NFC] Correcting minor typo. (authored by ncv). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78233/new/ https://reviews.llvm.org/D78233

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } balazske wrote: > Probably too much

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith - I think that should work - like this ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits mailing list

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov updated this revision to Diff 257617. ASDenysPetrov edited the summary of this revision. ASDenysPetrov added a comment. Herald added a subscriber: mgorny. Improved Negate function in terms of handling `[MIN,A]U[B,MAX] => [MIN,-B]U[-A,MAX]` (previously was

[PATCH] D78181: [clangd] Fix a crash for accessing a null field decl returned by findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:702 continue; +if (!D.getField()) + continue; thanks for fixing this ! But I suppose we should rather return a result with empty `TargetDecl` as this

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } Probably too much of assert here (but it works)? (There is not a way to get the

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 257616. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp Index: clang/lib/AST/Mangle.cpp

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 257622. gamesh411 added a comment. Reorganize test code to overcome testing infrastructure limitations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[clang-tools-extra] dffa9df - [clangd] Shard preamble symbols in dynamic index

Author: Kadir Cetinkaya Date: 2020-04-15T09:10:10+02:00 New Revision: dffa9dfbda56820c02e357ad34c24ce8759b4d26 URL: https://github.com/llvm/llvm-project/commit/dffa9dfbda56820c02e357ad34c24ce8759b4d26 DIFF:

[PATCH] D78020: clang/AMDGPU: Assume denormals are enabled for the default target.

arsenm updated this revision to Diff 257676. arsenm added a comment. Fix comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78020/new/ https://reviews.llvm.org/D78020 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/cl-denorms-are-zero.cl

[PATCH] D77658: [analyzer] StdLibraryFunctionsChecker: Add sanity checks for constraints

Szelethus added a comment. The idea is noble with the addition of `validate` functions, assert in debug builds and just move on in release. However, I'd expect it to be integrated into the signature matching function. Comment at:

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257632. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:153 +#undef CHECKER_DEPENDENCY +#undef GET_CHECKER_DEPENDENCIES + } Szelethus wrote: > balazske wrote: >

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257633. DmitryPolukhin added a comment. Split BitOffset in DeclOffset in high/low parts; rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files:

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257658. kbobyrev marked 14 inline comments as done. kbobyrev added a comment. Address the current round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

kmclaughlin updated this revision to Diff 257657. kmclaughlin marked an inline comment as done. kmclaughlin added a comment. Ensure LoadChain is always preserved in performLD1RQCombine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/ https://reviews.llvm.org/D76929 Files:

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257664. kbobyrev added a comment. Fix protobuf & grpc_cpp_plugin settings in system-installed libs scenario and confirm that everything works as expected with -DLLVM_OPTIMIZED_TABLEGEN=On. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78139: [clang-tidy] modernize-use-using: Fix broken fixit with 'template' keyword

njames93 added inline comments. Comment at: clang/lib/AST/NestedNameSpecifier.cpp:314 +InnerPolicy); +} else if (const auto *SpecType = + dyn_cast(T)) { Can this be renamed as it shadows the `SpecType`

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } ekatz wrote: > rjmccall wrote: > > ekatz wrote: > > > rjmccall wrote: > > > > ekatz wrote: > > > > > rjmccall wrote: > >

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

aaron.ballman added inline comments. Comment at: clang/www/cxx_dr_status.html:3 "http://www.w3.org/TR/html4/strict.dtd;> hubert.reinterpretcast wrote: > hubert.reinterpretcast wrote: > > rsmith wrote: > > > Please heed this comment, and check in a

[clang-tools-extra] f058673 - [dexp] NFC: Change positional argument format

Author: Kirill Bobyrev Date: 2020-04-15T13:28:07+02:00 New Revision: f05867339737bb203b64a95e096fee509313122d URL: https://github.com/llvm/llvm-project/commit/f05867339737bb203b64a95e096fee509313122d DIFF:

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

nand updated this revision to Diff 257637. nand marked 2 inline comments as done. nand added a comment. fixed typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/ https://reviews.llvm.org/D75726 Files:

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:400 + for (; I != E; ++I) { +if (!I->isAlignmentDependent()) + Align = std::max(Align, I->getAlignment(Ctx)); sammccall wrote: > This doesn't seem great - previously if e.g. codegen

[PATCH] D75726: [ConstExprPreter] Updated constant interpreter documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3387d1c30ae: [ConstExprPreter] Updated constant interpreter documentation (authored by nand). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75726/new/

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev updated this revision to Diff 257659. kbobyrev added a comment. Trim dexp output in remote index README. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77794/new/ https://reviews.llvm.org/D77794 Files:

[PATCH] D77794: [clangd] Pull installed gRPC and introduce clangd-remote-(server|client)

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:194 + + add_definitions(-DGOOGLE_PROTOBUF_NO_RTTI=1) + include_directories(${Protobuf_INCLUDE_DIRS}) sammccall wrote: > these global

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz marked an inline comment as done. ekatz added inline comments. Comment at: clang/lib/CodeGen/CGExprAgg.cpp:688 + +op = castE; } rjmccall wrote: > ekatz wrote: > > rjmccall wrote: > > > ekatz wrote: > > > > rjmccall wrote: > > > > > I liked the

[PATCH] D78098: [CGExprAgg] Fix infinite loop in `findPeephole`

ekatz updated this revision to Diff 257665. ekatz edited the summary of this revision. ekatz added a comment. Simplify function using IgnoreParenNoopCasts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78098/new/ https://reviews.llvm.org/D78098 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D77148: [analyzer] ApiModeling: Add buffer size arg constraint with multiplier involved

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:229-234 BufferSizeConstraint(ArgNo BufArgN, ArgNo SizeArgN) : ValueConstraint(BufArgN), SizeArgN(SizeArgN) {} +BufferSizeConstraint(ArgNo BufArgN,

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij commandeered this revision. stuij edited reviewers, added: LukeGeeson; removed: stuij. stuij added a comment. commandeering as I've got some changes to push CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077

[PATCH] D78194: [ARM] Add __bf16 as new Bfloat16 C Type

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, arphaman, kristof.beyls. Herald added a project: clang. This patch upstreams support for a new storage only bfloat16 C type. This type is used to implement primitive support for bfloat16 data, in line with the

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. changes in the last patch: depend on bfloat IR type, and resolve some conflicts that crept in CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___ cfe-commits mailing list

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

lebedev.ri added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

hokein updated this revision to Diff 257638. hokein marked an inline comment as done. hokein added a comment. Use isAlignmentErrorDependent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://reviews.llvm.org/D78085 Files:

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 257635. DmitryPolukhin added a comment. Fix nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serialization/ASTBitCodes.h

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @sammccall thank you for review! I'll wait for one more day for additional feedback if any, and land this diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG with comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78085/new/ https://reviews.llvm.org/D78085

[PATCH] D78085: [AST] Fix recovery-expr crash on invalid aligned attr.

sammccall added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:74 for (const auto *I : D->specific_attrs()) { +// FIXME: should we propagate the error bit? if (I->isAlignmentDependent()) maybe just do this unless it causes

[PATCH] D78189: [analyzer] StdLibraryFunctionsChecker: Add statistics

martong created this revision. martong added reviewers: NoQ, Szelethus, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a

  1   2   3   >