[PATCH] D75479: [clangd] go-to-def on names in comments etc that are used nearby.

sammccall updated this revision to Diff 259295. sammccall marked 15 inline comments as done. sammccall added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75479/new/ https://reviews.llvm.org/D75479 Files:

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

b-sumner added inline comments. Comment at: clang/test/CodeGenCXX/builtin-amdgcn-fence-failure.cpp:5 + +void test_amdgcn_fence_failure() { + JonChesterfield wrote: > arsenm wrote: > > Does this really depend on C++? Can it use OpenCL like the other builtin > >

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259298. saiislam added a comment. Moved builtin-amdgcn-fence-failure.cpp from clang/test/CodeGenCXX/ to clang/test/Sema/ since it is checking an error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/

[PATCH] D78644: [LSan] Enable for SystemZ

iii created this revision. iii added reviewers: vitalybuka, eugenis, uweigand, jonpa. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers. Add runtime support, adjust the tests and enable LSan. Repository: rG LLVM Github Monorepo

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

jdoerfert added a comment. Can we create a test case that shows even if it is a dependent type we will eventuall issue an error if it is not an addressable lvalue or array item? If this is the part that needs refactoring to work, we should add the test with a TODO. Repository: rG LLVM

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington added a comment. The demangler changes should also be made in `libcxxabi/src/demangle`, as there is a copy of the demangler there. This change also needs tests, there should be demangler tests (in libcxxabi/test/test_demangle.cpp), and IRGen tests (in clang/test/CodeGen) that

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Macro argument expansion logic relies on skipping file IDs that created as a result of an include. Unfortunately it fails to do that for predefined buffer

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

jdoerfert added a comment. Can we merge the test changes into D78643 and continue with D78643 as a fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78637/new/

[clang] 5daa25f - clang-format: support aligned nested conditionals formatting

Author: Francois Ferrand Date: 2020-04-22T17:36:33+02:00 New Revision: 5daa25fd7a184524759b6ad065a8bd7e95aa149a URL: https://github.com/llvm/llvm-project/commit/5daa25fd7a184524759b6ad065a8bd7e95aa149a DIFF:

[clang] 3d61b11 - clang-format: Introduce stricter AlignOperands flag

Author: Francois Ferrand Date: 2020-04-22T17:36:38+02:00 New Revision: 3d61b1120e8267aa39f4c9a33d618dbaec4ec6fa URL: https://github.com/llvm/llvm-project/commit/3d61b1120e8267aa39f4c9a33d618dbaec4ec6fa DIFF:

[clang] 662cbaf - [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat

Author: Sander de Smalen Date: 2020-04-22T16:42:08+01:00 New Revision: 662cbaf6476b7cc58d0d71ff98d95d00ce5b420e URL: https://github.com/llvm/llvm-project/commit/662cbaf6476b7cc58d0d71ff98d95d00ce5b420e DIFF:

[PATCH] D32478: [clang-format] Fix AlignOperands when BreakBeforeBinaryOperators is set

This revision was automatically updated to reflect the committed changes. Typz marked 2 inline comments as done. Closed by commit rG3d61b1120e82: clang-format: Introduce stricter AlignOperands flag (authored by Typz). Changed prior to commit:

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:198 + // 'self' variable of the current class method. + if (ReceiverSVal == Message.getSelfSVal()) { +// In this case, we should return the type of the

[PATCH] D70073: [ConstExprPreter] Implemented function calls and if statements

nand added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70073/new/ https://reviews.llvm.org/D70073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78286: [analyzer] Track runtime types represented by Obj-C Class objects

vsavchenko updated this revision to Diff 259314. vsavchenko marked 9 inline comments as done. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78286/new/ https://reviews.llvm.org/D78286 Files:

[PATCH] D77596: [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt[bhwd]_pat

This revision was automatically updated to reflect the committed changes. Closed by commit rG662cbaf6476b: [SveEmitter] Add IsOverloadNone flag and builtins for svpfalse and svcnt… (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D77596?vs=257824=259318#toc

[PATCH] D78577: [OPENMP50]Basic support for uses_allocators clause.

jdoerfert added a subscriber: rnk. jdoerfert added inline comments. Comment at: clang/include/clang/Sema/Sema.h:33 #include "clang/AST/NSAPI.h" +#include "clang/AST/OpenMPClause.h" #include "clang/AST/PrettyPrinter.h" I think @rnk might not be happy with this

[PATCH] D78649: [clang] Make sure argument expansion locations are correct in presence of predefined buffer

sammccall added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:1805 + // macro args expanded in the main file. + if (Entry.getFile().Filename == "" && FID == getMainFileID()) { +if (Entry.getFile().NumCreatedFIDs) nit: reverse

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

ldionne added a comment. This review is for the upcoming CMake upgrade once we branch off the LLVM 11 release branch. I won't apply it until after the branch has been created, which is around July. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78648: [CMake] Bump CMake minimum version to 3.13.4

ldionne created this revision. Herald added subscribers: libcxx-commits, openmp-commits, lldb-commits, Sanitizers, cfe-commits, frgossen, grosul1, jvesely, Joonsoo, liufengdb, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, lebedev.ri,

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

kristof.beyls accepted this revision. kristof.beyls added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78481/new/ https://reviews.llvm.org/D78481

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/test/CodeGenCXX/builtin-amdgcn-fence-failure.cpp:5 + +void test_amdgcn_fence_failure() { + b-sumner wrote: > JonChesterfield wrote: > > arsenm wrote: > > > Does this

[PATCH] D78481: [ARM] Release notes for the Custom Datapath Extension (CDE)

This revision was automatically updated to reflect the committed changes. Closed by commit rGd7ab9e7c9b30: [ARM] Release notes for the Custom Datapath Extension (CDE) (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78481/new/

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

martong added inline comments. Comment at: clang/test/Analysis/PR53280338.cpp:1 +// RUN: %clang_analyze_cc1 -analyzer-checker=core -analyzer-output=text -verify %s + AFAIK rdar is not accessible outside Apple. So, for the rest of the open source developers any

[clang] d7ab9e7 - [ARM] Release notes for the Custom Datapath Extension (CDE)

Author: Mikhail Maltsev Date: 2020-04-22T16:34:19+01:00 New Revision: d7ab9e7c9b309ebac094bba209f7c15ad5f01768 URL: https://github.com/llvm/llvm-project/commit/d7ab9e7c9b309ebac094bba209f7c15ad5f01768 DIFF:

[PATCH] D78643: [OpenMP] Fix false error report of array subscription for templated indexes.

h-joo created this revision. h-joo added a reviewer: ABataev. h-joo added projects: clang, OpenMP. Herald added subscribers: cfe-commits, arphaman, guansong, yaxunl. Herald added a reviewer: jdoerfert. This is a fix for Bug 45383 . This revision fixes

[PATCH] D76038: PR45000: Let Sema::SubstParmVarDecl handle default args of lambdas in initializers

ahatanak added a comment. The test I have passes after applying this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/ https://reviews.llvm.org/D76038 ___ cfe-commits mailing list

[PATCH] D78626: [clangd] Fix a crash for accessing a null template decl returned by findExplicitReferences.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:1293 +struct Base {}; +namespace foo { +template

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

okainov added a comment. Any updates on this one? That sounds so fundamental feature which current version is lacking, it's very frustrating it was not merged yet... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418

[PATCH] D76451: [clangd] Enable textual fallback for go-to-definition on dependent names

sammccall added a comment. Thanks for your patience! Comment at: clang-tools-extra/clangd/XRefs.cpp:154 +getDeclAtPosition(ParsedAST , SourceLocation Pos, DeclRelationSet Relations, + bool *IsDependentName = nullptr) { unsigned Offset =

[PATCH] D69560: [clang-tidy] Add 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type' check

whisperity updated this revision to Diff 259320. whisperity added a comment. - Better organisation of code, cleanup of debug prints, fix nomenclature of functions - Explicitly mention the first and last param of the range for clarity - Downlift the logic of joining and breaking ranges to main

[PATCH] D78652: [clang-tidy] Add "ignore related parameters" heuristics to 'experimental-cppcoreguidelines-avoid-adjacent-arguments-of-the-same-type'

whisperity created this revision. whisperity added reviewers: aaron.ballman, alexfh, hokein, JonasToth, zporky. whisperity added projects: clang-tools-extra, clang. Herald added subscribers: cfe-commits, martong, gamesh411, dkrupp, rnkovacs, kbarton, nemanjai. whisperity added a parent revision:

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78687/new/ https://reviews.llvm.org/D78687

[PATCH] D67112: [Sema] Introduce function reference conversion, NFC

aaronpuchert added a comment. @rsmith, what do you think about this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://reviews.llvm.org/D67112 ___ cfe-commits mailing list

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 259452. yaxunl marked 2 inline comments as done. yaxunl added a comment. Add a negative test for lambda kernel. Add more checks to codegen test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 259450. asbirlea marked 8 inline comments as done. asbirlea added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/ https://reviews.llvm.org/D72893 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea added inline comments. Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +(*C, CG); +ResultFAMCP->updateFAM(FAM); chandlerc wrote: > Check that it doesn't hit an assert failure, but I

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl updated this revision to Diff 259453. yaxunl added a comment. clean up test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/lib/Sema/SemaCUDA.cpp clang/test/CodeGenCUDA/lambda.cu clang/test/SemaCUDA/lambda.cu Index:

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu added a comment. In D78659#1997528 , @lebedev.ri wrote: > 1. Tests missing > 2. Why isn't `noinline` sufficient, why a whole new attribue? 1. Test added. 2. We want to avoid merging multiple call sites of same function, but `noinline` cannot

[PATCH] D78655: [HIP] Let lambda be host device by default

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:722 + if (getLangOpts().HIP) { +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); +Method->addAttr(CUDAHostAttr::CreateImplicit(Context));

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

This revision was automatically updated to reflect the committed changes. Closed by commit rG2899103108d3: [TimeProfiler] Emit clock synchronization point (authored by broadwaylamb). Changed prior to commit: https://reviews.llvm.org/D78030?vs=258061=259413#toc Repository: rG LLVM Github

[PATCH] D78192: Support compiler extensions as a normal component

Meinersbur added a comment. I looks to work fine under my Windows and Linux configuration. One Point though: llvm-config --libs Extensions returns [...] -lPollyPPCG -lPollyISL -lPolly I think `-lPolly` must be first to work with bfd.ld order semantics. See

[PATCH] D78694: [clang-format] Fix lambda with ellipsis in return type

johnchen902 created this revision. johnchen902 added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. johnchen902 retitled this revision from "[Format] Fix lambda with ellipsis in return type" to "[clang-format] Fix lambda with ellipsis in return

[PATCH] D78661: [Sema] Split off warn_impcast_integer_float_precision_constant into -Wimplicit-const-int-float-conversion

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the helping get the patch upstreamed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78661/new/

[clang] 391c15f - [NFC] Correct typo in comment after D76038

Author: Aaron Puchert Date: 2020-04-23T02:26:02+02:00 New Revision: 391c15fccdc6b0d33bb651a298c07216e532904e URL: https://github.com/llvm/llvm-project/commit/391c15fccdc6b0d33bb651a298c07216e532904e DIFF: https://github.com/llvm/llvm-project/commit/391c15fccdc6b0d33bb651a298c07216e532904e.diff

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 259455. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td clang/lib/CodeGen/CGCall.cpp clang/test/CodeGen/attr-nomerge.c

[PATCH] D78677: [SveEmitter] Add builtins for gather prefetches

sdesmalen created this revision. sdesmalen added reviewers: SjoerdMeijer, efriedma. Herald added a subscriber: tschuett. Herald added a project: clang. sdesmalen added a parent revision: D78674: [SveEmitter] Add builtins for contiguous prefetches. Repository: rG LLVM Github Monorepo

[PATCH] D78674: [SveEmitter] Add builtins for contiguous prefetches

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM with a couple minor comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7727 + Value *Offset = Ops.size() > 3 ? Ops[2] : Builder.getInt32(0); + BasePtr =

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78673: [SveEmitter] Use llvm.aarch64.sve.ld1/st1 for contiguous load/store builtins

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78673/new/ https://reviews.llvm.org/D78673

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

jbcoe updated this revision to Diff 259409. jbcoe added a comment. Format patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78642/new/ https://reviews.llvm.org/D78642 Files: clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jcai19 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using -ftrivial-auto-var-init=* options to initiate automatic variables in a file, to disable initialization on some variables, currently we have to manually annotate the variables with

[clang] 2899103 - [TimeProfiler] Emit clock synchronization point

Author: Sergej Jaskiewicz Date: 2020-04-23T01:09:31+03:00 New Revision: 2899103108d38215af8aae377cd0e54794278209 URL: https://github.com/llvm/llvm-project/commit/2899103108d38215af8aae377cd0e54794278209 DIFF:

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis added a comment. One more gentle ping) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74692/new/ https://reviews.llvm.org/D74692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78511: [Driver][doc] Document option -mtune as a no-op. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG35cf2f42dda4: [Driver][docs] Document option -mtune as a no-op. (authored by SjoerdMeijer). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

russell.gallop accepted this revision. russell.gallop added a comment. LGTM, with a few small comments. For the record, I wondered whether the time profiler could emit all ts as absolute, so I tried it out. This has two problems. 1). The "Total" numbers also need adjusting to be at the

[clang-tools-extra] 161afc0 - [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

Author: Sam McCall Date: 2020-04-22T11:11:13+02:00 New Revision: 161afc01064bd5bef42d1655f1b81b3030596527 URL: https://github.com/llvm/llvm-project/commit/161afc01064bd5bef42d1655f1b81b3030596527 DIFF: https://github.com/llvm/llvm-project/commit/161afc01064bd5bef42d1655f1b81b3030596527.diff

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

hokein added a comment. > Is there an easy way to transplant patches written against the old repo, into > the new one? I don't know whether there is an easy way, I'd just copy the changed file from the old repo to new repo, and regenerate a diff, I think this is not too terrible given that we

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks for doing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78598/new/ https://reviews.llvm.org/D78598

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith, @erik.pilkington - how about this ? Z7my_mainv_block_invoke_ZTSi_ZTSj_ZTSPVK3sss demangled as: invocation function for block with params '(int, unsigned int, sss const volatile*)' in my_main() CHANGES SINCE LAST ACTION

[clang] 35cf2f4 - [Driver][docs] Document option -mtune as a no-op.

Author: Sjoerd Meijer Date: 2020-04-22T09:15:48+01:00 New Revision: 35cf2f42dda4d708741e06570b2dbe91cec4dc41 URL: https://github.com/llvm/llvm-project/commit/35cf2f42dda4d708741e06570b2dbe91cec4dc41 DIFF: https://github.com/llvm/llvm-project/commit/35cf2f42dda4d708741e06570b2dbe91cec4dc41.diff

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson added a comment. In D78478#1994923 , @jdoerfert wrote: > I feel there is a lot of good stuff here but it seems to mix two things. A > rewrite of the script infrastructure and the UTC_ARGS stuff. If so, do you > think we could split them? I

[PATCH] D78565: [clang][doc] Clang ARM CPU command line argument reference

SjoerdMeijer abandoned this revision. SjoerdMeijer added a comment. Fair enough, perhaps the audience is too small here on llvm.org for this and this is too niche. In A-profile we have the same problem, so could the exercise for an A-core here, but can't spend time on that now, so will abandon

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv updated this revision to Diff 259181. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp llvm/include/llvm/Demangle/ItaniumDemangle.h Index: llvm/include/llvm/Demangle/ItaniumDemangle.h

[PATCH] D78687: [Fuchsia] Build compiler-rt builtins for 32-bit x86

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added subscribers: cfe-commits, s.egerton, simoncook, mgorny, dberris. Herald added a project: clang. While we don't support 32-bit architectures in Fuchsia, these are needed in the early boot phase on x86, so we build just

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

sameerds added a comment. Can you please submit a squashed single commit for review against the master branch? All the recent commits seem to be relative to previous commits, and I am having trouble looking at the change as a whole. The commit description needs some fixes: 1. Remove use of

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

yaxunl updated this revision to Diff 259458. yaxunl added a comment. Revised to let host/device take precedence over multiversion, as John suggested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/ https://reviews.llvm.org/D77954 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa044ed088a: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec. (authored by plotfi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

dyung added a comment. Hi, this change that you submitted in commit 5daa25fd7a184524759b6ad065a8bd7e95aa149a seems to be causing the test "Clang-Unit :: Format/./FormatTests.exe/FormatTest.ConfigurableUseOfTab" to randomly

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 259480. browneee added a comment. Switch approach back to std::vector change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files:

[PATCH] D78693: Make "#pragma clang attribute" support uninitialized attribute.

jfb added a comment. Looks pretty good to me. Not my areas of expertise so I’d like to have others look too. Thanks for doing this! Comment at: clang/test/Parser/pragma-attribute.cpp:190 +#pragma clang attribute pop +#pragma clang attribute push([[clang::uninitialized]],

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG161afc01064b: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78478: [UpdateTestChecks] Add UTC_ARGS support for update_{llc,cc}_test_checks.py

arichardson updated this revision to Diff 259210. arichardson added a comment. Split into multiple reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78478/new/ https://reviews.llvm.org/D78478 Files:

[PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

sammccall added a comment. In D78598#1995939 , @nridge wrote: > Is there an easy way to transplant patches written against the old repo, into > the new one? If you have a patch file (from git format-patch or downloaded from phab), you should be able

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

labath added a comment. In D76801#1995058 , @dblaikie wrote: > > It becomes a gdb-index problem because with an index the debugger will do a > > (hashed?) string lookup and expect the string to be there. If the strings > > differ, the lookup won't find

[PATCH] D76929: [AArch64][SVE] Add SVE intrinsic for LD1RQ

This revision was automatically updated to reflect the committed changes. Closed by commit rG17f6e18acf5b: [AArch64][SVE] Add SVE intrinsic for LD1RQ (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76929/new/

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259233. kbobyrev marked an inline comment as done. kbobyrev added a comment. Make sure the value of `--remote` flag is stored. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259238. saiislam added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Changed the builtin to be AMDGCN-specific It is named as __builtin_amdgcn_fence(order, scope) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77802: [analyzer] Improved RangeSet::Negate support of unsigned ranges

ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:217 + + const llvm::APSInt sampleValue = getMinValue(); + const bool isUnsigned = sampleValue.isUnsigned();

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

broadwaylamb added a comment. @russell.gallop thanks! I'll address your comments and commit the change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78030/new/ https://reviews.llvm.org/D78030 ___ cfe-commits mailing list

[PATCH] D77735: [SveEmitter] Implement builtins for gathers/scatters

andwar added a comment. The buildbot failures are unrelated to this patch, and locally `make check-all` worked fine. I'll submit this patch as is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77735/new/ https://reviews.llvm.org/D77735

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

saiislam updated this revision to Diff 259239. saiislam added a comment. Removed stale commented code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 Files: clang/docs/LanguageExtensions.rst

[PATCH] D78626: [clangd] Fix a crash for accessing a null template decl returned by findExplicitReferences.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/347. Repository: rG LLVM Github Monorepo

[PATCH] D78637: [OPENMP]Fix PR45383: type dependent array subscripts are diagnosed erroneously.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. If the array subscript expression is type depent, its analysis must be delayed before its instantiation. Repository: rG LLVM Github Monorepo

[PATCH] D78629: [clangd] Look for compilation database in `build` subdirectory of parents.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This matches the conventional location of cmake build directories. It also allows creating a `build`

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked 2 inline comments as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

martong added inline comments. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:227 +/// Identifier. +virtual LoadResultTy load(StringRef Identifier) = 0; +virtual ~ASTLoader() = default; xazax.hun wrote: > martong wrote: > > xazax.hun

[PATCH] D78521: [clangd] Extend dexp to support remote index

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:161 if (CLANGD_ENABLE_REMOTE) + add_definitions(-D CLANGD_REMOTE) include(FindGRPC) Can we use features.inc.in instead for this? (I don't have a strong opinion on which one

[clang] 4eca1c0 - [AArch64][FIX] f16 indexed patterns encoding restrictions.

Author: Pavel Iliin Date: 2020-04-22T14:11:28+01:00 New Revision: 4eca1c06a4a9183fcf7bb230d894617caf3cf3be URL: https://github.com/llvm/llvm-project/commit/4eca1c06a4a9183fcf7bb230d894617caf3cf3be DIFF: https://github.com/llvm/llvm-project/commit/4eca1c06a4a9183fcf7bb230d894617caf3cf3be.diff

[PATCH] D78642: [clang-format] Handle C# property accessors when parsing lines

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Improve C# `{ get; set; } = default;` formatting by handling it in the UnwrappedLineParser rather than trying

[PATCH] D78192: Support compiler extensions as a normal component

serge-sans-paille updated this revision to Diff 259284. serge-sans-paille added a comment. Herald added subscribers: cfe-commits, dang, dexonsmith, steven_wu, hiraditya. Herald added a project: clang. Instead of linking all compiler extensions to the different possible tagets (clang, opt lto

[PATCH] D78521: [clangd] Extend dexp to support remote index

kbobyrev updated this revision to Diff 259257. kbobyrev added a comment. Stream responses in refs() and fuzzyFind() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78521/new/ https://reviews.llvm.org/D78521 Files:

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 259272. baloghadamsoftware added a comment. First version that seems to be working :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/ https://reviews.llvm.org/D77229 Files:

[PATCH] D78232: [OPENMP50]Codegen for scan directive in simd loops.

ABataev updated this revision to Diff 259270. ABataev added a comment. ddress comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78232/new/ https://reviews.llvm.org/D78232 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D77594: [SveEmitter] Add support for _n form builtins

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/utils/TableGen/SveEmitter.cpp:212 + bool hasSplat() const { +return Proto.find_first_of("ajfrKLR") != std::string::npos; + } SjoerdMeijer wrote: > "ajfrKLR" ->

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

JonChesterfield added a comment. Amdgcn specific is fine by me. Hopefully that unblocks this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75917/new/ https://reviews.llvm.org/D75917 ___ cfe-commits

[PATCH] D78638: [analyzer] Consider array subscripts to be interesting lvalues

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Static analyzer

[PATCH] D75917: Expose llvm fence instruction as clang intrinsic

arsenm added inline comments. Comment at: clang/test/CodeGenCXX/builtin-amdgcn-fence-failure.cpp:5 + +void test_amdgcn_fence_failure() { + Does this really depend on C++? Can it use OpenCL like the other builtin tests?This also belongs in a Sema* test directory

[PATCH] D77871: [AArch64] Armv8.6-a Matrix Mult Assembly + Intrinsics

kmclaughlin added inline comments. Comment at: clang/test/CodeGen/aarch64-v8.6a-neon-intrinsics.c:3 +// RUN: -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \ +// RUN: | opt -S -mem2reg \ +// RUN: | FileCheck %s Is it possible to

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware marked 7 inline comments as done. baloghadamsoftware added a comment. Thank you for your comments. Of course I plan to upload all these changes in at least three different patches. But first I needed a version that is working. However if I split this up I will have to write

  1   2   >