[PATCH] D78365: [AST] Preserve the invalid initializer for auto VarDecl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a0d46608131: [AST] Preserve the invalid initializer for auto VarDecl. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D78365?vs=258309=260241#toc Repository: rG LLVM Github

[PATCH] D78909: [clang-format] NFC clang-format the clang-format sources

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, sylvestre.ledru, Abpostelnicu, Wawha, jbcoe. MyDeveloperDay added projects: clang, clang-format. Herald added a subscriber: cfe-commits. In recent patches the clang-format code has become un-formatted,

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay updated this revision to Diff 260261. MyDeveloperDay added a comment. @sylvestre.ledru , @Abpostelnicu I believe to fix your original request you need a combination of D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107)

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

steakhal added a comment. I'm planning to measure how impactful this patch is using the CodeChecker. Stay tuned if you are interested! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457 ___ cfe-commits

[PATCH] D62368: Add support for Hygon Dhyana processor

fanjinke marked an inline comment as done. fanjinke added inline comments. Comment at: compiler-rt/lib/scudo/scudo_utils.cpp:85 + (Ecx == signature_HYGON_ecx); + if (!IsIntel && !IsAMD && !IsHygon) return false; craig.topper wrote: >

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260265. baloghadamsoftware added a comment. All regions of parameters are `ParamRegions`, type stored explicitly, no crashes but 130 of 550 analyzer tests failing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay updated this revision to Diff 260266. MyDeveloperDay added a comment. Need to skip over the template or we won't see this as needing to break on the return type CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78879/new/ https://reviews.llvm.org/D78879 Files:

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Preamble.h:115 + /// mutate include depths. + void patchPreambleIncludes(IncludeStructure ) const; + i am not happy about this interface. I was

[PATCH] D77809: [Analyzer] Include typedef statements in CFG build.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b9b3d56efaa: [Analyzer] Include typedef statements in CFG build. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D77809?vs=259820=260269#toc Repository: rG LLVM Github

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added inline comments. Comment at: clang/lib/CrossTU/CMakeLists.txt:13 clangIndex + clangTooling + clangSerialization We've been very careful to make clang (the compiler binary) only depend on clangToolingCore and not on the much bigger clangTooling

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260229. gamesh411 added a comment. Reword enum value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-docs/CrossTranslationUnit.rst

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff created this revision. sepavloff added reviewers: rjmccall, rnk, yaxunl, plotfi, mstorsjo, dlj. Herald added subscribers: kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet updated this revision to Diff 260228. kadircet added a comment. - Use PreamblePatch - Add more tests - Handle deleted includes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77644/new/ https://reviews.llvm.org/D77644 Files:

[PATCH] D77644: [clangd] Handle additional includes while parsing ASTs

kadircet added a comment. this is ready for review now, to explain the flow: While creating a patch we also record remaining includes from Baseline left in Modified, as the new ones will be put into the patch already. That way ParsedAST can keep track of latest state of the preamble + main file

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, Eugene.Zelenko. Herald added a project: clang. Object of type `Compilation` now can keep a callback that is called after each execution of `Command`. This must simplify adaptation of clang in custom distributions and

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

Abpostelnicu added a comment. I think we are on the right track with this but what if we are dealing with `tok::amp` in a context similar to `operator const FallibleTArray&();` I can speculate that the outcome will be `operator const FallibleTArray &();` which is wrong. CHANGES SINCE LAST

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

sameerds created this revision. Herald added subscribers: llvm-commits, cfe-commits, kerbowa, hiraditya, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl, arsenm. Herald added projects: clang, LLVM. sameerds added reviewers: yaxunl, scchan, arsenm, rampitec, dstuttard. The

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2820 + if (Right.is(tok::star) && Left.is(TT_TemplateCloser)) +return false; if (Right.isOneOf(tok::star, tok::amp, tok::ampamp)) {

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff created this revision. sepavloff added reviewers: rsmith, rjmccall, aganea, hans. Herald added a project: clang. sepavloff added parent revisions: D78897: [Support] raw_fd_ostream can lock file before write, D78899: [Driver] Add callback to Command execution, D78901: [Support] Get

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

ztamas created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ztamas added a reviewer: aaron.ballman. ztamas added a comment. ztamas updated this revision to Diff 260243. I run the check both on LibreOffice and LLVM codebase but did not find any

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

ztamas updated this revision to Diff 260243. ztamas added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78904/new/ https://reviews.llvm.org/D78904 Files: clang-tools-extra/clang-tidy/bugprone/SignedCharMisuseCheck.cpp

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay added a comment. @sylvestre.ledru I'm taking a quick look at formatting the original bug in gecko and whilst the last windows snapshot (Feb 2020) shows the bug $ clang-format --version clang-format version 11.0.0 nsTArray.h:939:29: warning: code should be

[clang] 811c0c9 - [analyzer] On-demand parsing capability for CTU

Author: Endre Fülöp Date: 2020-04-27T11:20:35+02:00 New Revision: 811c0c9eb462d1fef6ab6908aab7881e5c4f5fbf URL: https://github.com/llvm/llvm-project/commit/811c0c9eb462d1fef6ab6908aab7881e5c4f5fbf DIFF: https://github.com/llvm/llvm-project/commit/811c0c9eb462d1fef6ab6908aab7881e5c4f5fbf.diff

[PATCH] D75068: libclang: Add static build support for Windows

cristian.adam added a comment. In D75068#2004072 , @davezarzycki wrote: > Rather than wholly reverting this, I committed a fix: > 665471907a5c072c6653a38c35f35e5d54cef220 > > > The

[clang] 1a0d466 - [AST] Preserve the invalid initializer for auto VarDecl.

Author: Haojian Wu Date: 2020-04-27T10:25:36+02:00 New Revision: 1a0d466081318adfc356917fccc5116f9031ef7e URL: https://github.com/llvm/llvm-project/commit/1a0d466081318adfc356917fccc5116f9031ef7e DIFF: https://github.com/llvm/llvm-project/commit/1a0d466081318adfc356917fccc5116f9031ef7e.diff

[PATCH] D78457: [analyzer][Z3-refutation] Fix a refutation BugReporterVisitor bug

martong accepted this revision. martong added a comment. LGTM! Thanks for addressing the comments! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78457/new/ https://reviews.llvm.org/D78457 ___ cfe-commits mailing list

[PATCH] D78904: [clang-tidy] extend bugprone-signed-char-misuse check with array subscript case.

ztamas added a comment. I run the check both on LibreOffice and LLVM codebase but did not find any catch. I expect that it's not a frequent use case. I added this extension only to fully cover the CERT rule. If this patch is accepted I can add a cert alias for this check. Repository: rG

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

MyDeveloperDay added a subscriber: hans. MyDeveloperDay added a comment. So for the Mozilla case mentioned in the bug report we either need to ask @hans if D76850: clang-format: Fix pointer alignment for overloaded operators (PR45107) can go into the v10

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

Abpostelnicu added a comment. I've cherry-picked D76850 to 10.x and see if this fixes the issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78879/new/ https://reviews.llvm.org/D78879 ___ cfe-commits

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

Abpostelnicu added a comment. In D78879#2004724 , @MyDeveloperDay wrote: > @sylvestre.ledru > > I'm taking a quick look at formatting the original bug in gecko and whilst > the last windows snapshot (Feb 2020) shows the bug > > $ clang-format

[clang] 03f419f - [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

Author: Sander de Smalen Date: 2020-04-27T11:45:10+01:00 New Revision: 03f419f3eb0c426a0a555be9abf7255a89b131cd URL: https://github.com/llvm/llvm-project/commit/03f419f3eb0c426a0a555be9abf7255a89b131cd DIFF:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 closed this revision. gamesh411 added a comment. I am landing this. Thanks for the reviews @martong @balazske @xazax.hun @whisperity ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665

[clang] 3b9b3d5 - [Analyzer] Include typedef statements in CFG build.

Author: Balázs Kéri Date: 2020-04-27T12:36:26+02:00 New Revision: 3b9b3d56efaa6f611458899d5a1cdc74f36d72a4 URL: https://github.com/llvm/llvm-project/commit/3b9b3d56efaa6f611458899d5a1cdc74f36d72a4 DIFF: https://github.com/llvm/llvm-project/commit/3b9b3d56efaa6f611458899d5a1cdc74f36d72a4.diff

[clang] 0d69e41 - Explicitly tell Clang to output to stdout in a test that runs FileCheck

Author: Dmitri Gribenko Date: 2020-04-27T10:13:28+02:00 New Revision: 0d69e412c4f35dfa891a6b83d94f3f76192868a7 URL: https://github.com/llvm/llvm-project/commit/0d69e412c4f35dfa891a6b83d94f3f76192868a7 DIFF:

[PATCH] D78401: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd]

This revision was automatically updated to reflect the committed changes. Closed by commit rG03f419f3eb0c: [SveEmitter] IsInsertOp1SVALL and builtins for svqdec[bhwd] and svqinc[bhwd] (authored by sdesmalen). Changed prior to commit: https://reviews.llvm.org/D78401?vs=259554=260274#toc

[PATCH] D75068: libclang: Add static build support for Windows

davezarzycki added a comment. In D75068#2004885 , @cristian.adam wrote: > In D75068#2004072 , @davezarzycki > wrote: > > > Rather than wholly reverting this, I committed a fix: > >

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe created this revision. jbcoe added reviewers: krasimir, MyDeveloperDay. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Added some examples of properties from Microsoft documentation as test cases.

[clang] 9f1e81f - [ASTImporter] Also import overwritten file buffers

Author: Raphael Isemann Date: 2020-04-27T13:16:08+02:00 New Revision: 9f1e81f1c0ac40f81e2f398148f09d1852226240 URL: https://github.com/llvm/llvm-project/commit/9f1e81f1c0ac40f81e2f398148f09d1852226240 DIFF:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260238. gamesh411 added a comment. Fix index error enum declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D78909: [clang-format] NFC clang-format the clang-format sources

jbcoe accepted this revision. jbcoe added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78909/new/ https://reviews.llvm.org/D78909

[PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

craig.topper created this revision. craig.topper added a reviewer: dblaikie. Herald added subscribers: lldb-commits, cfe-commits, Kayjukh, frgossen, grosul1, dantrushin, Joonsoo, kerbowa, liufengdb, lucyrfox, mgester, arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, jpienaar,

[PATCH] D78882: [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

ftynse accepted this revision. ftynse added a comment. This revision is now accepted and ready to land. LGTM for MLIR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78882/new/ https://reviews.llvm.org/D78882

[PATCH] D77979: [clang-tidy] modernize-use-using: Fix broken fixit with InjectedClassName

This revision was automatically updated to reflect the committed changes. Closed by commit rG145dcef8bdf9: [clang-tidy] modernize-use-using: Fix broken fixit with InjectedClassName (authored by mgehre). Changed prior to commit: https://reviews.llvm.org/D77979?vs=256872=260294#toc Repository:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gribozavr2 added a comment. Sorry, this change broke a couple bots that are in the official CI, at least http://lab.llvm.org:8011/builders/llvm-clang-win-x-aarch64/builds/7566 and http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/66618. I'm reverting this

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gribozavr2 added a comment. Reverted in https://github.com/llvm/llvm-project/commit/96717125e852d1c6ddf41c22dd2d556f4f5aa34d. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2980 -return (Ty->isPromotableIntegerType() ? ABIArgInfo::getExtend(Ty) - : ABIArgInfo::getDirect()); +

[PATCH] D78915: [clang-format] Improved parser for C# properties

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Can you please clang-format the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/

[clang] 8c8aae8 - Revert "recommit c77a4078e01033aa2206c31a579d217c8a07569b"

Author: Dmitri Gribenko Date: 2020-04-27T16:41:35+02:00 New Revision: 8c8aae852b5e60929156054808af941fc0745d46 URL: https://github.com/llvm/llvm-project/commit/8c8aae852b5e60929156054808af941fc0745d46 DIFF:

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. > no crashes but 130 of 550 analyzer tests failing. You most likely need to fill in the reachibility and liveness code with the behavior of the new region. I don't seem to see it in your current code but their default behavior is clearly incorrect; instead, they should

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

mstorsjo added a comment. Ping, @rnk? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78508/new/ https://reviews.llvm.org/D78508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78546: Enable bugprone-argument-comments check in llvm.

sammccall added a comment. > LLVM code style encourages this Not very strongly, it just says it can be helpful (and tells you how to do it if you do it). So I'm wary of making it mandatory in cases where it isn't a clear readability win. Had a look at this on clangd code: - the basic

[PATCH] D78086: [ASTImporter] Also import overwritten file buffers

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f1e81f1c0ac: [ASTImporter] Also import overwritten file buffers (authored by teemperor). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[clang] 9671712 - Revert "[analyzer] On-demand parsing capability for CTU"

Author: Dmitri Gribenko Date: 2020-04-27T14:27:04+02:00 New Revision: 96717125e852d1c6ddf41c22dd2d556f4f5aa34d URL: https://github.com/llvm/llvm-project/commit/96717125e852d1c6ddf41c22dd2d556f4f5aa34d DIFF:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked an inline comment as done. gamesh411 added inline comments. Comment at: clang/lib/CrossTU/CMakeLists.txt:13 clangIndex + clangTooling + clangSerialization thakis wrote: > We've been very careful to make clang (the compiler binary) only

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

gribozavr2 added a comment. Sorry -- this change broke overload resolution for `operator new`, as it is declared in system headers. I'm reverting the patch. $ cat /tmp/in.cu.cc #define __device__ __attribute__((device)) void* operator new(__SIZE_TYPE__ size); __device__ void *operator

[clang] 334ac81 - Fix the check for regparm in FunctionType::ExtInfo

Author: Momchil Velikov Date: 2020-04-27T16:01:07+01:00 New Revision: 334ac81054018c3ae6058a0bf12e9c9363bd50ad URL: https://github.com/llvm/llvm-project/commit/334ac81054018c3ae6058a0bf12e9c9363bd50ad DIFF:

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

aaron.ballman added a comment. Personally, I don't consider those to be useless casts. They appropriately ensure that the types match between the arguments and the format specifiers, rather than relying on underlying details of what SIZE_T expands to for a given target. I would expect these to

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#2005218 , @baloghadamsoftware wrote: > In D77229#2005042 , @NoQ wrote: > > > > no crashes but 130 of 550 analyzer tests failing. > > > > You most likely need to fill in the

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. > How do we calculate the type then? Argument expression type + account for value kind (lvalue argument expression means reference parameter, xvalue argument expression mean rvalue reference parameter). Note that for C-style variadic functions, parameter declarations for

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#2004964 , @baloghadamsoftware wrote: > Even if I put weeks or months of work into it the code will be worse at the > end because there will be lots of branches upon the nature of the variable > and alternative ways for

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

hokein updated this revision to Diff 260306. hokein added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78350/new/ https://reviews.llvm.org/D78350 Files: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2005042 , @NoQ wrote: > > no crashes but 130 of 550 analyzer tests failing. > > You most likely need to fill in the reachibility and liveness code with the > behavior of the new region. I don't seem to see it

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260310. gamesh411 added a comment. [NFC] Fix arcanist double commit revisioning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 260308. gamesh411 added a comment. Remove platform constraint from test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files:

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 reopened this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Non-linux buildbots were utterly broken :( . Trying to fix them... Thanks for reverting this for me :) Also I will investigate the possibility to not depend on Tooling. Repository:

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2005042 , @NoQ wrote: > > no crashes but 130 of 550 analyzer tests failing. > > You most likely need to fill in the reachibility and liveness code with the > behavior of the new region. I don't seem to see it

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. In D77229#2004964 , @baloghadamsoftware wrote: > This is not the proper way, `MemRegion`s for parameters in inlined functions > should remain `VarRegion`s because parameters **are** variables inside. On > the other hand, from

[PATCH] D78933: RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov updated this revision to Diff 260331. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78933/new/ https://reviews.llvm.org/D78933 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. This patches fixes two Clang tests which are failing for XCore target on 2020-04-27 with "unexpected null value" assert failures: CodeGen/2003-12-14-ExternInlineSupport.c CoverageMapping/unused_names.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77270: Fix the check for regparm in FunctionType::ExtInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG334ac8105401: Fix the check for regparm in FunctionType::ExtInfo (authored by chill). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. I spent some time on thinking about this during the weekend. It is no wonder that the tests fail. It seems that many parts of the Analyzer core exploit the fact that the `MemRegion`s of parameters are `VarRegion`s. This is no wonder because all

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

thakis added a comment. Looks like this also breaks tests on Windows and Mac, eg http://45.33.8.238/win/13902/step_7.txt It probably makes sense to revert while you investigate? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/

[PATCH] D78879: [clang-format] [PR45357] Fix issue found with operator spacing

hans added a subscriber: tstellar. hans added a comment. In D78879#2004751 , @MyDeveloperDay wrote: > So for the Mozilla case mentioned in the bug report we either need to ask > @hans if D76850: clang-format: Fix pointer alignment for overloaded >

[clang] f181f1b - [clang] Remove NFC overload in ASTImporterTest

Author: Raphael Isemann Date: 2020-04-27T14:10:43+02:00 New Revision: f181f1b7f73e643fb5d10a6d07832c1a2fb34c0b URL: https://github.com/llvm/llvm-project/commit/f181f1b7f73e643fb5d10a6d07832c1a2fb34c0b DIFF:

[clang] 145dcef - [clang-tidy] modernize-use-using: Fix broken fixit with InjectedClassName

Author: Matthias Gehre Date: 2020-04-27T14:23:23+02:00 New Revision: 145dcef8bdf9da9684c9c4e34a8e6c45baafab74 URL: https://github.com/llvm/llvm-project/commit/145dcef8bdf9da9684c9c4e34a8e6c45baafab74 DIFF:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

MyDeveloperDay added a comment. Were you able to rerun these tests? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

labath added a comment. In D76801#1997451 , @dblaikie wrote: > Yeah, points all taken - as for this actual issue... I'm kind of inclined to > say "hey, our template names already diverge somewhat - and this divergence > is in the realm of acceptable by

[PATCH] D78915: [clang-format] Improved parser for C# properties

jbcoe updated this revision to Diff 260316. jbcoe added a comment. Format patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78915/new/ https://reviews.llvm.org/D78915 Files: clang/lib/Format/UnwrappedLineParser.cpp clang/unittests/Format/FormatTestCSharp.cpp Index:

[PATCH] D78190: Add Bfloat IR type

stuij updated this revision to Diff 260326. stuij added a comment. addressed comments: throughout the patch changed the string `Bfloat` to `BFloat`, expanded description of bfloat in the documentation, addressed misc comments. also added `Type *getBFloatTy()` to IRBuilder.h thanks for the

[PATCH] D78933: RangeConstraintManager optimizations in comparison expressions

ASDenysPetrov created this revision. ASDenysPetrov added reviewers: NoQ, baloghadamsoftware, steakhal, xazax.hun. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, rnkovacs. I got an idea how to make RangeConstraintManager​ more sofisticated. I want

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. Furthermore, there are also problems with `CXXNewExpr`: llvm-project/clang/include/clang/AST/ExprCXX.h:2239: clang::Expr* clang::CXXNewExpr::getPlacementArg(unsigned int): Assertion `(I < getNumPlacementArgs()) && "Index out of range!"' failed. CHANGES

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. And this one: 'Assume' not implemented for this NonLoc UNREACHABLE executed at /home/edmbalo/llvm-project/clang/lib/StaticAnalyzer/Core/SimpleConstraintManager.cpp:67! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77229/new/

[PATCH] D78190: Add Bfloat IR type

stuij marked 8 inline comments as done. stuij added inline comments. Comment at: llvm/include/llvm-c/Core.h:149 LLVMHalfTypeKind,/**< 16 bit floating point type */ + LLVMBfloatTypeKind, /**< 16 bit brain floating point type */ LLVMFloatTypeKind, /**< 32

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2005033 , @NoQ wrote: > > How do we calculate the type then? > > Argument expression type + account for value kind (lvalue argument expression > means reference parameter, xvalue argument expression mean

[PATCH] D78762: build: use `find_package(Python3)` if available

JDevlieghere added a comment. In D78762#2002390 , @compnerd wrote: > @JDevlieghere I think that adding another mechanism for finding the python > executable is not the right approach. You already have the variables that > you are talking about, you

[PATCH] D78836: [clangd] Strip /showIncludes in clangd compile commands

thakis added inline comments. Comment at: clang/lib/Tooling/ArgumentsAdjusters.cpp:101 // -MF, -MG, -MP, -MT, -MQ, -MD, and -MMD. - if (!Arg.startswith("-M")) { + if (!Arg.startswith("-M") && Arg != "/showIncludes") { AdjustedArgs.push_back(Args[i]);

[clang] 5c03bee - clang: Allow backend unsupported warnings

Author: Matt Arsenault Date: 2020-04-27T12:14:51-04:00 New Revision: 5c03beefa720bddb3e3f53c595a76bce7ad50f37 URL: https://github.com/llvm/llvm-project/commit/5c03beefa720bddb3e3f53c595a76bce7ad50f37 DIFF:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya, MatzeB. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. Part of the <=> changes in C++20 make certain patterns of writing equality operators ambiguous with

[PATCH] D78190: Add Bfloat IR type

rjmccall added inline comments. Comment at: llvm/docs/LangRef.rst:2896 + * - ``bfloat`` + - 16-bit brain floating-point value (8-bit mantissa) + rjmccall wrote: > scanon wrote: > > bfloat and fp128 should agree w.r.t. whether or not the implicit bit > >

[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd added a comment. @JDevlieghere I think that for LLDB, which this patch does not touch, the proper thing to do is to have 2 different paths with the ability to explicitly opt into the path, i.e. `LLDB_USE_PYTHON2:BOOL` and `LLDB_USE_PYTHON3:BOOL` with `CMakeDependentOption` to prevent

[PATCH] D78941: [OPENMP]Allow cancellation constructs in target parallel regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: guansong, yaxunl. Herald added a project: clang. omp cancellation point parallel and omp cancel parallel directives are allowed in target paralle regions. Repository: rG LLVM Github Monorepo

[PATCH] D78817: clang: Allow backend unsupported warnings

arsenm closed this revision. arsenm added a comment. 5c03beefa720bddb3e3f53c595a76bce7ad50f37 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78817/new/ https://reviews.llvm.org/D78817

[clang] 7363ffe - [Matrix] Add draft specification for matrix support in Clang.

Author: Florian Hahn Date: 2020-04-27T18:00:23+01:00 New Revision: 7363ffe95f0a32b5cf11affe844577aa7ba6f0f4 URL: https://github.com/llvm/llvm-project/commit/7363ffe95f0a32b5cf11affe844577aa7ba6f0f4 DIFF: https://github.com/llvm/llvm-project/commit/7363ffe95f0a32b5cf11affe844577aa7ba6f0f4.diff

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. Mark as accepted to make Phabricator/arc happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware added a comment. In D77229#2005413 , @baloghadamsoftware wrote: > llvm-project/clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:333: > clang::ento::ProgramStateRef >

[PATCH] D78508: [Clang] Allow long as size_t printf argument on 32-bit Windows platforms.

amccarth added a comment. In D78508#2005311 , @aaron.ballman wrote: > Personally, I don't consider those to be useless casts. They appropriately > ensure that the types match between the arguments and the format specifiers, > rather than relying on

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7363ffe95f0a: [Matrix] Add draft specification for matrix support in Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D76612?vs=258269=260367#toc Repository: rG LLVM

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 Please add a header to the output .CSV, specifying the units of measure where relevant.

[PATCH] D78755: [SveEmitter] Add builtins for svlen

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78755/new/ https://reviews.llvm.org/D78755

  1   2   3   >