[PATCH] D78762: build: use `find_package(Python3)` if available

compnerd closed this revision. compnerd added a comment. rGcd84bfb8142bc7ff3a07a188ffb809f1d86d1fd7 (with the Python2 fixes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78979: OpenCL: Include builtin header by default

arsenm added a comment. I'm also wondering if using -nogpulib for the corresponding linker purpose was correct, since in the OpenCL case it's not really an offload target. Maybe this should switch to -nostdlib? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78979/new/

[PATCH] D78979: OpenCL: Include builtin header by default

yaxunl added a comment. In D78979#2006847 , @arsenm wrote: > I'm also wondering if using -nogpulib for the corresponding linker purpose > was correct, since in the OpenCL case it's not really an offload target. > Maybe this should switch to -nostdlib?

[PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

mgrang updated this revision to Diff 260517. mgrang retitled this revision from "[Sema] Fix null pointer dereference warnings [1/n]" to "[Analysis] Fix null pointer dereference warnings [1/n]". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78853/new/ https://reviews.llvm.org/D78853

[PATCH] D78980: Elaborate more on --rocm-path flag.

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:612 def rocm_path_EQ : Joined<["--"], "rocm-path=">, Group, - HelpText<"ROCm installation path">; + HelpText<"ROCm installation path, used for finding and automatically linking required bitcode

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 260529. zequanwu added a comment. Split the the original differential to 2 smaller ones. This one add nomerge function attribute in IR level. Another one will add the attribute to let frontend recognize it. CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith added a comment. This change tries to fix this bug. https://bugs.llvm.org/show_bug.cgi?id=32810 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 ___

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith created this revision. asmith added reviewers: jbcoe, MyDeveloperDay. Herald added a project: clang. Herald added a subscriber: cfe-commits. asmith added a reviewer: thakis. Before this change enums were formatted incorrectly for the Microsoft style. [Original Source] enum {

[PATCH] D72959: Relative VTables ABI on Fuchsia

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:623 +llvm::Constant *C, llvm::GlobalVariable *VTable, unsigned vtableIdx, +unsigned lastAddrPoint) const { + // No need to get the offset of a nullptr. leonardchan wrote: >

[PATCH] D72959: Relative VTables ABI on Fuchsia

leonardchan marked an inline comment as done. leonardchan added inline comments. Comment at: clang/lib/CodeGen/CGVTables.cpp:623 +llvm::Constant *C, llvm::GlobalVariable *VTable, unsigned vtableIdx, +unsigned lastAddrPoint) const { + // No need to get the offset of a

[PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

dblaikie added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:1938-1940 +// The default value for the argument VD to the current function is +// nullptr. So we assert that VD is non null because we deref VD here. +assert(VD && "!VD");

[clang] be884b7 - Revert "build: use `find_package(Python3)` if available"

Author: Saleem Abdulrasool Date: 2020-04-27T20:03:32-07:00 New Revision: be884b79352de8917ad17fdb9bd70ec982ca8bdd URL: https://github.com/llvm/llvm-project/commit/be884b79352de8917ad17fdb9bd70ec982ca8bdd DIFF:

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260542. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineParser.cpp Index:

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

sameerds added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:158 Args.MakeArgString(Twine("-filetype=") + (OutputIsAsm ? "asm" : "obj"))); + LlcArgs.push_back("--amdgpu-enable-structurizer-workarounds"); arsenm wrote: > We should

[clang] a58b62b - [IR] Replace all uses of CallBase::getCalledValue() with getCalledOperand().

Author: Craig Topper Date: 2020-04-27T22:17:03-07:00 New Revision: a58b62b4a2b96c31b49338b262b609db746449e8 URL: https://github.com/llvm/llvm-project/commit/a58b62b4a2b96c31b49338b262b609db746449e8 DIFF: https://github.com/llvm/llvm-project/commit/a58b62b4a2b96c31b49338b262b609db746449e8.diff

[PATCH] D78890: [clang-tidy] Add check callee-namespace.

PaulkaToast updated this revision to Diff 260218. PaulkaToast marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78890/new/ https://reviews.llvm.org/D78890 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

<    1   2   3