[PATCH] D78903: [Driver] Add option -fproc-stat-report

MaskRay added inline comments. Comment at: clang/docs/UsersManual.rst:786 + + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 aganea wrote: > Why not just `-fproc-stat-report` in this case? It can

[PATCH] D78350: [AST] Build recovery expressions by default for C++.

rsmith added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:151 -COMPATIBLE_LANGOPT(RecoveryAST, 1, 0, "Preserve expressions in AST when encountering errors") +COMPATIBLE_LANGOPT(RecoveryAST, 1, CPlusPlus, "Preserve expressions in AST when

[clang] 20df603 - Make -fno-char8_t disable the char8_t keyword, even in C++20.

Author: Richard Smith Date: 2020-04-28T23:49:35-07:00 New Revision: 20df6038ee76f110640fc7c5fa9b96b84e373932 URL: https://github.com/llvm/llvm-project/commit/20df6038ee76f110640fc7c5fa9b96b84e373932 DIFF: https://github.com/llvm/llvm-project/commit/20df6038ee76f110640fc7c5fa9b96b84e373932.diff

[clang-tools-extra] c35f3f8 - Fix up clangd after clang commit llvmorg-11-init-13375-g0a088ead85f.

Author: Richard Smith Date: 2020-04-28T23:49:35-07:00 New Revision: c35f3f8679050df77a32512a73a94ba856190089 URL: https://github.com/llvm/llvm-project/commit/c35f3f8679050df77a32512a73a94ba856190089 DIFF: https://github.com/llvm/llvm-project/commit/c35f3f8679050df77a32512a73a94ba856190089.diff

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. Otherwise sources including `Index.pb.h` or `Index.grpc.pb.h` can be compiled before the those headers are generated. https://github.com/kirillbobyrev/indexing-tools/runs/629305684 (disregard the mess in the repo) Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

awarzynski added a comment. The suggested flag, `-fortran-fe`, feels quite powerful and I wonder whether it's required this early into the development of the Flang driver? IIUC, this flag would be used to workaround the fact that currently `flang` is a bash script and hence can't be used when

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260921. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added a comment. see D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated this should be handled separately. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 -

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

This revision was automatically updated to reflect the committed changes. Closed by commit rGad97ccf6b26a: [clangd] Move non-clang base pieces into separate support/ lib. NFCI (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

asmith marked 6 inline comments as done. asmith added a comment. The is done unless there are other comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev updated this revision to Diff 260906. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Use DEPENDS instead of add_dependencies. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall updated this revision to Diff 260905. sammccall added a comment. Update CMakeLists for non-default configurations, optimistically. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014 Files:

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:786 + + $ clang -fproc-stat-report=- foo.c + clang-11: output=/tmp/foo-123456.o, total=84000, user=76000, mem=87496 MaskRay wrote: > aganea wrote: > > Why not just `-fproc-stat-report` in

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

rnk accepted this revision. rnk added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79076/new/ https://reviews.llvm.org/D79076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D78982: [clang-format] Fix Microsoft style for C++ enums

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:721 - -**InsertTrailingCommas** (``TrailingCommaStyle``) can be set to ``TCS_Wrapped`` - to insert trailing commas in container literals (arrays and objects) that wrap

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev added a comment. In D79085#2010025 , @sammccall wrote: > Haha, CMake :-( Now that I know this it kind of makes sense (I guess it's faster to just build everything and then link when all deps are ready), just something I didn't think about :)

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hans, Non-Windows non-PIC setups were working just fine until four days ago when D75068 landed. I tried to narrowly unbreak non-Windows non-PIC systems but apparently that broke Windows. For that, I'm sorry. That being said, non-Windows systems are broken again and this breakable was

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Okay, sounds good. For whatever it may be worth, I pasted the build failure to D75068 shortly after it landed with the hope that the original author(s) would commit a quick fix, but that didn't happen. On Wed, Apr 29, 2020, at 10:23 AM, Hans Wennborg wrote: > Your suggestion of > > >

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1752 LngFunctionDeclaration(); +**InsertTrailingCommas** (``TrailingCommaStyle``)

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mprobst, krasimir, mitchell-stellar, asmith. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay edited the summary of this revision. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5606 + // candidates. + auto CantGuaranteeValueAcrossCall = [](outliner::Candidate ) { +// If the unsafe registers in this block are all dead, then we don't need yroux wrote:

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. @craig.topper Did this look OK/ Is there anything else you want from this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > I'm vaguely suspicious this might be wrong for big-endian targets.

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Your suggestion of > if(LLVM_ENABLE_PIC OR (WIN32 AND NOT LIBCLANG_BUILD_STATIC)) sounds good to me. I don't know what the non-Windows non-PIC problem was exactly (your commit didn't mention it), so maybe it's best if you land that to verify it fixes the issue? Thanks, Hans On Wed, Apr 29,

[clang] e717e87 - [libclang] Shared libraries require PIC unless WIN32

Author: David Zarzycki Date: 2020-04-29T11:25:45-04:00 New Revision: e717e8744d374e16603157e5135005727bf17901 URL: https://github.com/llvm/llvm-project/commit/e717e8744d374e16603157e5135005727bf17901 DIFF:

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

krasimir added a comment. Awesome! Thank you! Now that we've got "clang/phabricator/lint/git" robots that leave comments on patches, we may want to think about a way to have this automatically enforced in the future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith updated this revision to Diff 260932. asmith retitled this revision from "[clang-format] Fix Microsoft style for C++ enums" to "[clang-format] Fix Microsoft style for enums". asmith edited the summary of this revision. asmith added a comment. Enable for C# CHANGES SINCE LAST ACTION

[clang-tools-extra] 4645ef1 - [clangd] Add CMake dependencies for Protobuf-generated files

Author: Kirill Bobyrev Date: 2020-04-29T17:01:03+02:00 New Revision: 4645ef17ff1aa30e1890b7c8230b590ef830081b URL: https://github.com/llvm/llvm-project/commit/4645ef17ff1aa30e1890b7c8230b590ef830081b DIFF:

[PATCH] D79072: [Analyzer][VLASizeChecker] Check VLA size in typedef and sizeof.

xazax.hun added a comment. Overall the changes look good to me here. I had a small nit inline. But I wonder if we actually should add more code in the analyzer core to better model the sizes of memory regions corresponding to the VLAs. Comment at:

[PATCH] D73354: clang-format: insert trailing commas into containers.

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:563 + }; + + TrailingCommaStyle InsertTrailingCommas; I think we need to add some text in here to ensure it gets documented automatically in ClangFormatStyleOptions.rst

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

This revision was automatically updated to reflect the committed changes. Closed by commit rG4645ef17ff1a: [clangd] Add CMake dependencies for Protobuf-generated files (authored by kbobyrev). Changed prior to commit: https://reviews.llvm.org/D79085?vs=260906=260920#toc Repository: rG LLVM

[PATCH] D73768: clang-format: [JS] document InsertTrailingCommas.

MyDeveloperDay added a comment. I'm trying to prevent this from getting deleted in D78982: [clang-format] Fix Microsoft style for C++ enums @mprobst When you added this documentation did you add it to Format.h and regenerate the rst text.

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le updated this revision to Diff 260912. j0le retitled this revision from "[Driver][ARM] fix undefined behaviour when checking architecture version" to "[Driver][ARM] parse version of arm/thumb architecture correctly". j0le edited the summary of this revision. j0le added a comment. Changed

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

yroux updated this revision to Diff 260916. yroux edited the summary of this revision. yroux added a comment. Here is a new update of the patch. I remove the logic to disable LowOverheadLoops pass since Eli has added the live-ins infos inside outlined functions in D78605

[PATCH] D79095: [clang-format] NFC Correct clang-format headers file so documentation can be once again autogenerated

MyDeveloperDay added a comment. In D79095#2010250 , @krasimir wrote: > Awesome! Thank you! > Now that we've got "clang/phabricator/lint/git" robots that leave comments > on patches, we may want to think about a way to have this automatically > enforced

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong updated this revision to Diff 260930. martong marked 2 inline comments as done. martong added a comment. - Use Decl::print and 'for: ' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78118/new/ https://reviews.llvm.org/D78118 Files:

[PATCH] D78118: [analyzer] StdLibraryFunctionsChecker: Add option to display loaded summaries

martong marked 4 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:651 +// Get the declaration of a function proto as written in the source file. +StringRef ToString(const FunctionDecl

[clang] e00071d - Fixing typo (singed -> signed); NFC

Author: Aaron Ballman Date: 2020-04-29T10:33:21-04:00 New Revision: e00071db0854ae9030e3b80a1f82c7cd66d57930 URL: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930 DIFF: https://github.com/llvm/llvm-project/commit/e00071db0854ae9030e3b80a1f82c7cd66d57930.diff

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

asmith marked 2 inline comments as done. asmith added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine

RE: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hi, Thank you David for not reverting my 3rd attempt to get libclang to build statically on Windows. In my defense the commit landed on a Saturday, and while I usually hack on weekends, but now I'm involved in moving to a new home and I wasn't able to reply to your message. I'm sorry for

[clang] 209ab6d - Revert 6654719 "[CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC"

Author: Hans Wennborg Date: 2020-04-29T15:12:43+02:00 New Revision: 209ab6d8835cd88320ceb814893759cfbda91d15 URL: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15 DIFF: https://github.com/llvm/llvm-project/commit/209ab6d8835cd88320ceb814893759cfbda91d15.diff

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Haha, CMake :-( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79085/new/ https://reviews.llvm.org/D79085

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, efriedma, dancgr. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. This patch adds AArch64ISD nodes for [S|U]MIN_PRED and

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/CMakeLists.txt:22 ) + add_dependencies(clangdRemoteIndex RemoteIndexProtos) is this equivalent to `DEPENDS RemoteIndexProtos` in the library? Slightly clearer probably.

[PATCH] D78903: [Driver] Add option -fproc-stat-report

aganea added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 sepavloff wrote: > aganea wrote: > > Please add a header to the output .CSV, specifying the

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Could you answer my question up-thread about whether ExtInt is currently target-limited? If it isn't, we need to more broadly audit targets. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785

[PATCH] D79106: [clangd] Move inserted include from detail -> documentation.

sammccall created this revision. sammccall added a reviewer: hokein. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Many clients try to display all the detail inline, with poor results. Repository: rG LLVM

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + sdesmalen wrote: > efriedma wrote: > > I'm vaguely suspicious this might be wrong for big-endian targets. I mean, > > this isn't

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked an inline comment as done. mibintc added inline comments. Comment at: clang/include/clang/AST/Expr.h:2701 + FPOptions FPFeatures; + mibintc wrote: > erichkeane wrote: > > This type already has trailing-storage type stuff. I think in the past

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010546 , @rjmccall wrote: > Could you answer my question up-thread about whether ExtInt is currently > target-limited? If it isn't, we need to more broadly audit targets. Yikes! I missed that question, I'm sorry

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. Every target does something similar, they just all do it in different ways because they're mostly written by different people. We should restrict this feature to targets where we've adequately audited the ABI. It's not a feature until the ABI work is done.

[PATCH] D79087: [SVE][Codegen] Lower legal min & max operations

efriedma added a subscriber: huihuiz. efriedma added inline comments. Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:3851 + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _S)>; + def : SVE_1_Op_Imm_Arith_Pred_Pat(NAME # _D)>; } I don't see any test for this

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2010746 , @jsji wrote: > Looks like this is causing buildbot failure when built with > `-DBUILD_SHARED_LIBS=ON`. > >

[PATCH] D74813: [RFC] Add hash of block contents to function block names

erik.pilkington edited reviewers, added: rjmccall; removed: libc++abi. erik.pilkington added a comment. In D74813#2010767 , @alexbdv wrote: > @erik.pilkington would the hash-based numbering be OK for now ? Feel free to drop the demangler changes for

[PATCH] D79076: [clang] [MinGW] Add the compiler rt libdirs to the search path

This revision was automatically updated to reflect the committed changes. Closed by commit rGa0e53de472c5: [clang] [MinGW] Add the compiler rt libdirs to the search path (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a1d9c0f5ac8: Fix x86/x86_64 calling convention for _ExtInt (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

erichkeane added a comment. 2 small things, @rjmccall and @sepavloff , anything else? Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:870 +def err_pragma_fenv_requires_precise : Error< + "'#pragma STDC FENV_ACCESS ON' is illegal when precise is disabled">; def

[clang] b5a4dee - [NFC] Split ext-int calling convention tests into their own file.

Author: Erich Keane Date: 2020-04-29T12:20:21-07:00 New Revision: b5a4deec6a70da8a1024a2227be66f88e9276b08 URL: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08 DIFF: https://github.com/llvm/llvm-project/commit/b5a4deec6a70da8a1024a2227be66f88e9276b08.diff

[clang-tools-extra] bc029fa - [clangd] Still need pthreads in clangDaemon.

Author: Sam McCall Date: 2020-04-29T21:41:12+02:00 New Revision: bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd URL: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd DIFF: https://github.com/llvm/llvm-project/commit/bc029fa6c5cdc28fa2087f721e5ffe27d9b24ecd.diff

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

baloghadamsoftware updated this revision to Diff 260944. baloghadamsoftware added a comment. Now I made some good progress, thank you @NoQ for your suggestions. Not all of them are implemented yet (currently the +-1 with the indices seem to be working, thus I will fix that part later), but now

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___ cfe-commits mailing list

[PATCH] D79117: [clang] [Darwin] Add reverse mappings for aarch64/aarch64_32 to darwin arch names

mstorsjo created this revision. mstorsjo added a reviewer: t.p.northover. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. These are mapped in MachO::getMachOArchName already, but were missing in ToolChain::getDefaultUniversalArchName. Having these reverse

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. See my audit/WIP on calling conventions here: https://reviews.llvm.org/D79118 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78785/new/ https://reviews.llvm.org/D78785 ___

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

rjmccall added a comment. In D78785#2010738 , @erichkeane wrote: > In D78785#2010654 , @rjmccall wrote: > > > Every target does something similar, they just all do it in different ways > > because they're mostly

[PATCH] D79085: [clangd] Add CMake dependencies for Protobuf-generated files

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. kbobyrev added a comment. Otherwise sources including `Index.pb.h` or

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

On Sun, Apr 26, 2020 at 1:17 PM David Zarzycki via cfe-commits wrote: > > > Author: David Zarzycki > Date: 2020-04-26T07:16:42-04:00 > New Revision: 665471907a5c072c6653a38c35f35e5d54cef220 > > URL: > https://github.com/llvm/llvm-project/commit/665471907a5c072c6653a38c35f35e5d54cef220 > DIFF: >

[clang-tools-extra] ad97ccf - [clangd] Move non-clang base pieces into separate support/ lib. NFCI

Author: Sam McCall Date: 2020-04-29T15:57:12+02:00 New Revision: ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f URL: https://github.com/llvm/llvm-project/commit/ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f DIFF: https://github.com/llvm/llvm-project/commit/ad97ccf6b26a29262c9cbf5b3e7f6e84c6dcf55f.diff

Re: [clang] 6654719 - [CMake] Fix logic error: NOT LIBCLANG_BUILD_STATIC does not imply PIC

Hi Cristian, That's alright. No worries. Good luck with the move (especially during the pandemic). My three stage test of LLVM+clang+lld+libcxx+libcxxabi is almost done, and I'll commit your suggested fix soon. Dave On Wed, Apr 29, 2020, at 10:53 AM, Cristian Adam wrote: > Hi, > > Thank you

[PATCH] D79094: [SemaObjC] Warn on visibility attributes on an @implementation

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, aaron.ballman. Herald added subscribers: ributzka, dexonsmith, jkorous. D60542 added support for attributes on `@implementation`s, but CodeGen always looks for visibility

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 3 inline comments as done. sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:770 + $ cat abc + clang-11,"/tmp/foo-123456.o",92000,84000,87536 + ld,"a.out",900,8000,53568 aganea wrote: > Please add a header to the

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2010527 , @svenvh wrote: > In D78979#2007643 , @Anastasia wrote: > > > > Would it not become confusing since the builtins are going to be included > > > by default? Should we

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @erik.pilkington would the hash-based numbering be OK for now ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 ___ cfe-commits

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. In D78785#2010654 , @rjmccall wrote: > Every target does something similar, they just all do it in different ways > because they're mostly written by different people. > > We should restrict this feature to targets where we've

[PATCH] D79113: Revert "Remove false positive in AvoidNonConstGlobalVariables."

vingeldal created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. vingeldal added reviewers: aaron.ballman, lebedev.ri, JonasToth, gribozavr2. Herald added a subscriber: wuzish. There was concernes about a false positive in clang-tidy check

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. This is looking good. I remember we discussed this on the LLVM call a few weeks ago - there was a discussion as to whether we should be prioritising `-march` or `-mcpu` - do you recall the outcome of

[PATCH] D78979: OpenCL: Include builtin header by default

Anastasia added a comment. In D78979#2007760 , @yaxunl wrote: > In D78979#2007643 , @Anastasia wrote: > > > ah I guess if we leave it under `-cc1 ` we will have the command line > > interface as follows: > > > > -

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

jsji added a comment. Herald added a subscriber: wuzish. Looks like this is causing buildbot failure when built with `-DBUILD_SHARED_LIBS=ON`. http://lab.llvm.org:8011/builders/clang-ppc64le-rhel/builds/3077/steps/build%20stage%201/logs/stdio FAILED: lib/libclangDaemon.so.11git : &&

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I believe this breaks check-builtins on macOS. See https://bugs.chromium.org/p/chromium/issues/detail?id=1076480 for details. The `split()` on the subprocess output throws since it wants a b'.' on py3, but that code has an unqualified except block. That means (I think)

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

DiggerLin updated this revision to Diff 261004. DiggerLin marked an inline comment as done. DiggerLin added a comment. take out the functionality of "remove -u from clang" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/

[PATCH] D74813: [RFC] Add hash of block contents to function block names

dexonsmith added a comment. In D74813#2010859 , @erik.pilkington wrote: > In D74813#2010767 , @alexbdv wrote: > > > @erik.pilkington would the hash-based numbering be OK for now ? > > > Feel free to drop the

[PATCH] D74813: [RFC] Add hash of block contents to function block names

alexbdv added a comment. @dexonsmith what regression are you referring to ? What this change is effectively doing now is changing the numbering of the blocks from incremental to hash-based. So the demangler functionality remains the same (i think) - I saw that it is ignoring the (currently

[PATCH] D78756: [SveEmitter] Add builtins for svreinterpret

sdesmalen marked an inline comment as done. sdesmalen added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:7880 +return Builder.CreateBitCast(Val, Ty); + } + efriedma wrote: > sdesmalen wrote: > > efriedma wrote: > > > I'm vaguely suspicious

[clang] 5b862b6 - Fix ext-int Sema test that didn't specify a triple.

Author: Erich Keane Date: 2020-04-29T14:34:53-07:00 New Revision: 5b862b6aa7705fdbd893dc5946289631e7b6d662 URL: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662 DIFF: https://github.com/llvm/llvm-project/commit/5b862b6aa7705fdbd893dc5946289631e7b6d662.diff

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

rnk added a comment. I think this looks good, but I would like to get a second opinion from Alina (@asbirlea). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 ___ cfe-commits mailing list

[PATCH] D71227: [cuda][hip] Fix function overload resolution in the global initiailizer.

hliao updated this revision to Diff 261003. hliao added a comment. Rebase to trunk and resolve the conflict. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71227/new/ https://reviews.llvm.org/D71227 Files: clang/include/clang/Sema/Sema.h

[PATCH] D79121: Add nomerge function attribute to clang

zequanwu created this revision. zequanwu added a reviewer: rnk. zequanwu added a project: clang. Herald added a subscriber: cfe-commits. Related to D78659 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79121 Files:

[PATCH] D78827: Add support for #pragma clang fp reassoc(on|off) -- floating point control of associative math transformations

mibintc updated this revision to Diff 261036. mibintc added a comment. Thanks for your review @sepavloff and @erichkeane, I have responded to your feedback and reverted the name back to reassoc which is what Serge prefers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/Format.cpp:1143 Style.PenaltyReturnTypeOnItsOwnLine = 1000; + Style.AllowShortEnumsOnASingleLine = (Language != FormatStyle::LK_Cpp); Style.AllowShortFunctionsOnASingleLine = FormatStyle::SFS_None;

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. Sorry please adjust the patch to remove the un-related changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78982/new/ https://reviews.llvm.org/D78982

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

hubert.reinterpretcast accepted this revision. hubert.reinterpretcast added a comment. LGTM with minor comment. Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:2143 + case GlobalValue::AvailableExternallyLinkage: +report_fatal_error("Unhandled

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. I think there's more, just running a local shared build so I can catch them (I should really have done this ahead of time). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79014/new/ https://reviews.llvm.org/D79014

[PATCH] D79014: [clangd] Move non-clang base pieces into separate support/ lib.

sammccall added a comment. In D79014#2011034 , @sammccall wrote: > I think there's more, just running a local shared build so I can catch them > (I should really have done this ahead of time). OK, this now builds for me in shared mode after

[PATCH] D78762: build: use `find_package(Python3)` if available

thakis added a comment. I attempted a fix in e071ea48e923651ae21b9b684b0473248630322c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78762/new/ https://reviews.llvm.org/D78762

[PATCH] D78785: Fix x86/x86_64 calling convention for _ExtInt

erichkeane added a comment. Alright then, I've disabled by default(911add149af563a5a61458de0dd730e3f5348623 ). I'll enable 1 at a time as I fix the calling conventions in D79118 .

Re: [PATCH] D78853: [Analysis] Fix null pointer dereference warnings [1/n]

Am 29.04.20 um 23:11 schrieb Mandeep Singh Grang: > My previous email details why we are doing > this: http://lists.llvm.org/pipermail/llvm-dev/2020-April/141167.html > Basically, we ran the PREfast static analysis tool on LLVM/Clang and > it reported a lot of warnings. I guess some of them are

[PATCH] D78659: Add nomerge function attribute to supress tail merge optimization in simplifyCFG

zequanwu updated this revision to Diff 261059. zequanwu marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78659/new/ https://reviews.llvm.org/D78659 Files: llvm/docs/LangRef.rst llvm/include/llvm/Bitcode/LLVMBitCodes.h

[PATCH] D79079: [clangd] Make use of URIs in FileShardedIndex

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:183 const auto = IndexIt.getValue(); // Note that sources do not contain any information regarding missing // headers, since we

  1   2   >