[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. LGTM, too. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D78827 ___ cfe-commits mailing list

[PATCH] D79059: Fix and re-submit D78534 - [libclang] Install both libclang.a and libclang.so when LIBCLANG_BUILD_STATIC=ON

2020-05-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Sorry for the delayed review here. I'm not the biggest fan of this cos it's encoding knowledge of `llvm_add_library`'s internal behavior (that it creates a `*_static` target if both STATIC

[PATCH] D79451: [libclang] Remove duplicate dependency on LLVMSupport

2020-05-05 Thread Jan Korous via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG02b303321d3f: [libclang] Remove duplicate dependency on LLVMSupport (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D79448: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

2020-05-05 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0fac1c191281: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when… (authored by craig.topper). Herald added a project: clang. Changed prior to commit:

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

2020-05-05 Thread Chandler Carruth via Phabricator via cfe-commits
chandlerc added a comment. Wooot about finally having a test case! (Sorry for nit picking it a bit ) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable

[clang] 02b3033 - [libclang] Remove duplicate dependency on LLVMSupport

2020-05-05 Thread Jan Korous via cfe-commits
Author: Jan Korous Date: 2020-05-05T21:31:07-07:00 New Revision: 02b303321d3f0d3b2c69f68aa25560848dd61f98 URL: https://github.com/llvm/llvm-project/commit/02b303321d3f0d3b2c69f68aa25560848dd61f98 DIFF: https://github.com/llvm/llvm-project/commit/02b303321d3f0d3b2c69f68aa25560848dd61f98.diff

[clang] 0fac1c1 - [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

2020-05-05 Thread Craig Topper via cfe-commits
Author: Craig Topper Date: 2020-05-05T21:12:30-07:00 New Revision: 0fac1c19128106b6d65d349a5ed22fedacab520c URL: https://github.com/llvm/llvm-project/commit/0fac1c19128106b6d65d349a5ed22fedacab520c DIFF: https://github.com/llvm/llvm-project/commit/0fac1c19128106b6d65d349a5ed22fedacab520c.diff

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment. The failing case in this commit looks like the following after formatting (with alignconsecutiveassignments

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

2020-05-05 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv updated this revision to Diff 262281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files: clang/lib/AST/Mangle.cpp clang/test/CXX/expr/expr.prim/expr.prim.lambda/blocks-irgen.mm clang/test/CodeGen/block-with-perdefinedexpr.cpp

[PATCH] D79465: Fix line lengths w/ comments in align

2020-05-05 Thread Jake Merdich via Phabricator via cfe-commits
JakeMerdichAMD created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. JakeMerdichAMD added a project: clang-format. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, VelocityRa, sylvestre.ledru, sammccall, enyquist. JakeMerdichAMD added a comment.

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread Steve Canon via Phabricator via cfe-commits
scanon accepted this revision. scanon added a comment. This revision is now accepted and ready to land. My concerns have been addressed. Thanks for bearing with me, Melanie! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread Steve Canon via Phabricator via cfe-commits
scanon added a comment. (Please get one additional sign off before committing; I'm mainly signing off on the numerics model aspect). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78827/new/ https://reviews.llvm.org/D78827

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka requested changes to this revision. vitalybuka added reviewers: eugenis, glider. vitalybuka added a comment. This revision now requires changes to proceed. In D79445#2021502 , @aeubanks wrote: > In D79445#2021311

[PATCH] D74813: Function block naming - add hash of parameter type to end of block name

2020-05-05 Thread Alex Borcan via Phabricator via cfe-commits
alexbdv updated this revision to Diff 262272. alexbdv marked an inline comment as done. alexbdv edited the summary of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74813/new/ https://reviews.llvm.org/D74813 Files:

[PATCH] D78655: [HIP] Add -fhip-lambda-host-device

2020-05-05 Thread Paul Fultz II via Phabricator via cfe-commits
pfultz2 added a comment. > A slight variation on that, that might be better: lambdas with no > lambda-capture are implicitly HD; lambdas with any lambda-capture (which must > therefore have an enclosing function) inherit the enclosing function's HDness. Lambdas should already inherit the

[PATCH] D68049: Propeller: Clang options for basic block sections

2020-05-05 Thread Han Shen via Phabricator via cfe-commits
shenhan added inline comments. Comment at: lld/ELF/LTO.cpp:80 // Check if basic block sections must be used. // Allowed values for --lto-basicblock-sections are "all", "labels", // "", or none. This is the equivalent Maybe "--lto-basicblock-sections"

[PATCH] D73307: Unique Names for Functions with Internal Linkage

2020-05-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 ___ cfe-commits mailing

[PATCH] D79456: [clangd] Complete filenames after < / ".

2020-05-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. sammccall added a reviewer: adamcz. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Extract prefix filters to CodeComplete so it can be easily tested. Fixes

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:175-177 - ``-fsanitize=undefined``: All of the checks listed above other than ``float-divide-by-zero``,

[PATCH] D74238: [clang] Improve diagnostic note for implicit conversion sequences that would work if more than one implicit user-defined conversion were allowed.

2020-05-05 Thread Logan Smith via Phabricator via cfe-commits
logan-5 abandoned this revision. logan-5 added a comment. @rsmith the intention is to only speculatively search one level deep (e.g. search for chains like A->B, B->C, but no deeper), which should cover most of the cases that are surprising to users. However, the implementation of this patch

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG844096b996a0: [CUDA] Make NVVM builtins available with CUDA-11/PTX6.5 (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

2020-05-05 Thread Jason Liu via Phabricator via cfe-commits
jasonliu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4368 + + return emitVoidPtrVAArg(CGF, VAListAddr, Ty, /*Indirect*/ false, TypeInfo, + SlotSize, /*AllowHigher*/ true); ZarkoCA wrote: > Is there a reason why

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

2020-05-05 Thread Jason Liu via Phabricator via cfe-commits
jasonliu updated this revision to Diff 262252. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/aix-complex.c clang/test/CodeGen/aix-return.c

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D79445#2021311 , @leonardchan wrote: > In `addSanitizersAtO0`, could you make something similar to the `ASanPass` > lambda for the MSan passes and also apply it when adding kernel MSan? It ends up calling an extra

[PATCH] D78573: [Clang][Sema] Capturing section type conflicts between #pragma clang section and section attributes

2020-05-05 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/AST/ASTContext.h:3008 +/// Insertion operator for diagnostics. +inline const DiagnosticBuilder & +operator<<(const DiagnosticBuilder ,

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 262248. aeubanks added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79445/new/ https://reviews.llvm.org/D79445 Files: clang/lib/CodeGen/BackendUtil.cpp Index:

[PATCH] D79035: [clang][AIX] Implement ABIInfo and TargetCodeGenInfo for AIX

2020-05-05 Thread Jason Liu via Phabricator via cfe-commits
jasonliu updated this revision to Diff 262250. jasonliu marked 12 inline comments as done. jasonliu added a comment. Rebase and address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79035/new/ https://reviews.llvm.org/D79035 Files: clang/lib/CodeGen/TargetInfo.cpp

[clang] b0eb7cd - Reapply "NFC: utils/perf-training: Python 3 compatibility for lit.cfg"

2020-05-05 Thread Azharuddin Mohammed via cfe-commits
Author: Azharuddin Mohammed Date: 2020-05-05T15:56:23-07:00 New Revision: b0eb7cd2be849f0551e9b05a0cbf2d59d8c9f50d URL: https://github.com/llvm/llvm-project/commit/b0eb7cd2be849f0551e9b05a0cbf2d59d8c9f50d DIFF:

[clang] 844096b - [CUDA] Make NVVM builtins available with CUDA-11/PTX6.5

2020-05-05 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2020-05-05T15:43:32-07:00 New Revision: 844096b996a0b17d3f380af323614a5fe31b8a68 URL: https://github.com/llvm/llvm-project/commit/844096b996a0b17d3f380af323614a5fe31b8a68 DIFF:

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 262239. vitalybuka added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka updated this revision to Diff 262240. vitalybuka added a comment. updated doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 Files: clang/docs/UndefinedBehaviorSanitizer.rst

[PATCH] D78607: [local-bounds] Ignore volatile operations

2020-05-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. done Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78607/new/ https://reviews.llvm.org/D78607 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 262237. tra added a comment. Actually added sm_80 predicate. It's not used on any builtins yet, but it makes sense to add it right now along with ptx65. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/

[clang] 67175d8 - [cmake] Allow std::filesystem tests in CrossWinToARMLinux.cmake

2020-05-05 Thread Sergej Jaskiewicz via cfe-commits
Author: Sergej Jaskiewicz Date: 2020-05-06T01:31:32+03:00 New Revision: 67175d8dc53b580bad439f85fda12623fa6993fa URL: https://github.com/llvm/llvm-project/commit/67175d8dc53b580bad439f85fda12623fa6993fa DIFF:

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra created this revision. tra added a reviewer: timshen. Herald added subscribers: sanjoy.google, bixia, yaxunl, jholewinski. Herald added a project: clang. tra updated this revision to Diff 262236. tra added a comment. Test that the builtins work all the way to sm_80/ptx65 Repository: rG

[PATCH] D79449: [CUDA] Make NVVM builtins available with CUDA-11 & PTX6.5

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra updated this revision to Diff 262236. tra added a comment. Test that the builtins work all the way to sm_80/ptx65 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79449/new/ https://reviews.llvm.org/D79449 Files:

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

2020-05-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay updated this revision to Diff 262231. MyDeveloperDay added a comment. Reduce false formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79354/new/ https://reviews.llvm.org/D79354 Files: clang/lib/Format/UnwrappedLineParser.cpp

[PATCH] D79448: [X86] Allow Yz inline assembly constraint to choose ymm0 or zmm0 when avx/avx512 are enabled and type is 256 or 512 bits

2020-05-05 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, rnk, echristo. Herald added a subscriber: hiraditya. Herald added a project: LLVM. gcc supports selecting ymm0/zmm0 for the Yz constraint when used with 256 or 512 bit vector types. Fixes PR45806

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); //

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D77954#2021299 , @yaxunl wrote: > I will put a workaround: In device compilation, in implicit `__device__ > __host__` callers, I will keep the old behavior, that is, implicit > `__device__ __host__` candidate has equal preference

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

2020-05-05 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG24b4965ce65b: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with… (authored by kwk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

2020-05-05 Thread Konrad Wilhelm Kleine via Phabricator via cfe-commits
kwk updated this revision to Diff 262226. kwk added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79419/new/ https://reviews.llvm.org/D79419 Files: clang-tools-extra/clang-tidy/add_new_check.py Index:

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Leonard Chan via Phabricator via cfe-commits
leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. In `addSanitizersAtO0`, could you make something similar to the `ASanPass` lambda for the MSan passes and also apply it when adding kernel MSan? Repository: rG LLVM Github

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. FYI, I've just reverted it in bf6a26b066382e0f41bf023c781d84061c542307 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77954/new/

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

2020-05-05 Thread Scott Linder via Phabricator via cfe-commits
scott.linder added a comment. Can you provide more context in the diff? Looking at the current `master` locally it seems like this patch changes the behavior of the `llvm_vcsrevision_h` target when `logs/HEAD` isn't found, such that it only depends on the generation script. I.e. if you

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:719 + !getContext().getTargetInfo().hasInt128Type())) + return getNaturalAlignIndirect(Ty); + erichkeane wrote: > rjmccall wrote: > > It's very weird for 64 and 128 to be

[clang-tools-extra] 24b4965 - [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

2020-05-05 Thread Konrad Kleine via cfe-commits
Author: Konrad Kleine Date: 2020-05-05T17:22:50-04:00 New Revision: 24b4965ce65b14ead595dcc68add22ba37533207 URL: https://github.com/llvm/llvm-project/commit/24b4965ce65b14ead595dcc68add22ba37533207 DIFF: https://github.com/llvm/llvm-project/commit/24b4965ce65b14ead595dcc68add22ba37533207.diff

[clang] bf6a26b - Revert D77954 -- it breaks Eigen & Tensorflow.

2020-05-05 Thread Artem Belevich via cfe-commits
Author: Artem Belevich Date: 2020-05-05T14:07:31-07:00 New Revision: bf6a26b066382e0f41bf023c781d84061c542307 URL: https://github.com/llvm/llvm-project/commit/bf6a26b066382e0f41bf023c781d84061c542307 DIFF:

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

2020-05-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. In D77954#2021026 , @tra wrote: > It appears that re-landed b46b1a916d44216f0c70de55ae2123eb9de69027 > has > created another compilation regression. I don't

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:5813 + // Don't touch the link register + if (MI.readsRegister(ARM::LR, TRI) || MI.modifiesRegister(ARM::LR, TRI)) +return outliner::InstrType::Illegal; yroux wrote: >

[PATCH] D78827: Add support for #pragma clang fp reassociate(on|off) -- floating point control of associative math transformations

2020-05-05 Thread Melanie Blower via Phabricator via cfe-commits
mibintc updated this revision to Diff 262217. mibintc retitled this revision from "Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations" to "Add support for #pragma clang fp reassociate(on|off) -- floating point control of

[PATCH] D79445: [MSan] Pass MSan command line options under new pass manager

2020-05-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. aeubanks added reviewers: nemanjai, vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. Properly forward TrackOrigins and Recover user options to the MSan pass under the new pass manager. This makes the number of

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

2020-05-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8047 +Value *PFalse = Constant::getNullValue(PTrue->getType()); +Value *Sel = Builder.CreateSelect(CmpNE, PTrue, PFalse); +return EmitSVEPredicateCast(Sel, cast(Ty));

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-05 Thread Yvan Roux via Phabricator via cfe-commits
yroux updated this revision to Diff 262205. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76066/new/ https://reviews.llvm.org/D76066 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp

[PATCH] D79357: [SveEmitter] Add builtins for svdup and svindex

2020-05-05 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1050 def SVCOMPACT: SInst<"svcompact[_{d}]", "dPd", "ilUiUlfd", MergeNone, "aarch64_sve_compact">; -// SVDUP_LANE(to land in D78750)

[PATCH] D76066: [ARM][MachineOutliner] Add Machine Outliner support for ARM

2020-05-05 Thread Yvan Roux via Phabricator via cfe-commits
yroux added a comment. In D76066#2014697 , @samparker wrote: > Thanks for adding the MVE changes, but I also still don't see any DSP tests, > i.e QADD, SADD16. hmm... I was wrong w/r to DSP instructions Q and GE flags handling, I don't get what I did

[PATCH] D79440: Fix ForRangeCopyCheck not triggering on iterators returning elements by value in C++17.

2020-05-05 Thread Felix Berger via Phabricator via cfe-commits
flx created this revision. flx added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. The AST is different in C++17 in that there is no MaterializeTemporaryExpr for in the AST for a loop variable that is initialized from an iterator that returns its

[PATCH] D79121: Add nomerge function attribute to clang

2020-05-05 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Sema/SemaStmtAttr.cpp:178 +return true; + return llvm::any_of(S->children(), hasCallExpr); +} rsmith wrote: > This will recurse into too much (eg, the bodies of

[PATCH] D79419: [clang/clang-tools-extra] Fix BZ44437 - add_new_check.py does not work with Python 3

2020-05-05 Thread Daniel Sanders via Phabricator via cfe-commits
dsanders accepted this revision. dsanders added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79419/new/ https://reviews.llvm.org/D79419

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

2020-05-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4938 +if (EIT->getNumBits() > 128) + return getNaturalAlignIndirect(Ty, /*ByVal=*/true); + rjmccall wrote: > erichkeane wrote: >

[PATCH] D79118: Implement _ExtInt ABI for all ABIs in Clang, enable type for ABIs

2020-05-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 262190. erichkeane added a comment. Revert PPC64 changes back to direct/indirect. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79118/new/ https://reviews.llvm.org/D79118 Files: clang/lib/Basic/Targets/AArch64.h

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

2020-05-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); // expected-warning{{FALSE}} + } vsavchenko

[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

2020-05-05 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG276c8dde0b58: [clang][codegen] Refactor argument loading in function prolog. NFC. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78660: [SemaObjC] Add a warning for dictionary literals with duplicate keys

2020-05-05 Thread Erik Pilkington via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG873e27909539: [SemaObjC] Add a warning for dictionary literals with duplicate keys (authored by erik.pilkington). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

2020-05-05 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir added a comment. I'm not familiar with ObjC, but hope this helps: % cat ~/example.mm # left as-is by clang-format without D79354 (int)f : (int)arg { struct A as[] = {{a11, a12}, // {a21, a22}, // {nil, 0}};

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

2020-05-05 Thread Michael Liao via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9142c0b46bfe: [clang][codegen] Hoist parameter attribute setting in function prolog. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79334: [clang-tidy]: Add cert-str34-c alias for bugprone-signed-char-misuse.

2020-05-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some small nits with the documentation. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-signed-char-misuse.rst:117 + + When

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/test/Analysis/constant-folding.c:127-128 + if (a > 10) { +clang_analyzer_eval((a & 1) <= 1); // expected-warning{{FALSE}} +clang_analyzer_eval((a & 1) > 1); //

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

2020-05-05 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/ https://reviews.llvm.org/D79244

[PATCH] D79354: [clang-format] [PR34574] Handle [[nodiscard]] attribute in class declaration

2020-05-05 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. In D79354#2020722 , @krasimir wrote: > I have an example where this goes wrong in ObjC (modulo indentation): > > I think we should try harder to detect the beginning of an attribute > specifier. I think there may be a

[clang] 276c8dd - [clang][codegen] Refactor argument loading in function prolog. NFC.

2020-05-05 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-05-05T15:31:51-04:00 New Revision: 276c8dde0b58cfe29035448a27e16eff9fcf2a5a URL: https://github.com/llvm/llvm-project/commit/276c8dde0b58cfe29035448a27e16eff9fcf2a5a DIFF: https://github.com/llvm/llvm-project/commit/276c8dde0b58cfe29035448a27e16eff9fcf2a5a.diff

[clang] 9142c0b - [clang][codegen] Hoist parameter attribute setting in function prolog.

2020-05-05 Thread Michael Liao via cfe-commits
Author: Michael Liao Date: 2020-05-05T15:31:51-04:00 New Revision: 9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e URL: https://github.com/llvm/llvm-project/commit/9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e DIFF: https://github.com/llvm/llvm-project/commit/9142c0b46bfea13d9348ab3d1d706a10ad9e5c8e.diff

[clang] 86e50af - [AST] Print fixed enum type regardless of language mode

2020-05-05 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 86e50af72d0a0f5cddd2cb487681709eda7934e8 URL: https://github.com/llvm/llvm-project/commit/86e50af72d0a0f5cddd2cb487681709eda7934e8 DIFF:

[clang] 873e279 - [SemaObjC] Add a warning for dictionary literals with duplicate keys

2020-05-05 Thread Erik Pilkington via cfe-commits
Author: Erik Pilkington Date: 2020-05-05T15:30:39-04:00 New Revision: 873e279095391df347b58ba4bab26dbfecab1262 URL: https://github.com/llvm/llvm-project/commit/873e279095391df347b58ba4bab26dbfecab1262 DIFF:

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

2020-05-05 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm updated this revision to Diff 262189. rsandifo-arm added a comment. Put two other related warnings under the new option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79244/new/ https://reviews.llvm.org/D79244 Files:

[PATCH] D72281: [Matrix] Add matrix type to Clang.

2020-05-05 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 262188. fhahn marked 9 inline comments as done. fhahn added a comment. Thanks for the extensive comments! They should be addressed: refactor dependent type construction, template argument deduction, adjust mangling. In D72281#2019417

[PATCH] D78374: [Analyzer][StreamChecker] Added evaluation of fread and fwrite.

2020-05-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:478 + + // FIXME: Check for stream in EOF state? + balazske wrote: > Szelethus wrote: > > Will that be the next patch? :D Eager to see it! > It may be too big

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. That makes sense, thanks. I think I'm comfortable using on/off for this, but it's definitely good to stop and consider, and you're absolutely right that it needs to be documented. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D79244: [Sema] Put existing warning under -Wexcess-initializers

2020-05-05 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm added a comment. In D79244#2019027 , @efriedma wrote: > Should we stick ext_excess_initializers_in_char_array_initializer and > ext_initializer_string_for_char_array_too_long in the same warning group? Yeah, agree that would be better.

[PATCH] D72281: [Matrix] Add matrix type to Clang.

2020-05-05 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:3846 + New = new (*this, TypeAlignment) DependentSizedMatrixType( + *this, ElementTy, QualType(Canon, 0), RowExpr, ColumnExpr, AttrLoc); + } else { rjmccall wrote: > Some of

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

2020-05-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. It appears that re-landed b46b1a916d44216f0c70de55ae2123eb9de69027 has created another compilation regression. I don't have a simple reproducer yet, so here's the error message for now:

[PATCH] D79276: [FileCheck] Support comment directives

2020-05-05 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny updated this revision to Diff 262185. jdenny added a comment. My last update accidentally included D79375 . This strips it back out. Sorry about that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79276/new/ https://reviews.llvm.org/D79276

[PATCH] D74668: [Clang][BPF] implement __builtin_btf_type_id() builtin function

2020-05-05 Thread Andrii Nakryiko via Phabricator via cfe-commits
anakryiko added a comment. In D74668#2020554 , @yonghong-song wrote: > In D74668#2019558 , @anakryiko wrote: > > > what's the use case for flag==0 (no relocation)? why using built-in at all > > in such case? Also

[PATCH] D79265: Let normalize() for posix style convert backslash to slash unconditionally.

2020-05-05 Thread Nico Weber via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8fc7a907b93a: Let normalize() for posix style convert backslash to slash unconditionally. (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

2020-05-05 Thread Steve Canon via Phabricator via cfe-commits
scanon added a comment. > I don't think the C standard is likely to ever bless reassociative FP math > with an expression-local restriction. Steve, do you actually think that would > be a useful optimization mode? I think it's pretty unlikely that C would do this, as well. It is plausibly a

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

2020-05-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. Sure, this is an improvement because we display more information, but I'd argue that it isn't really a more readable warning message :) How about th argument to the call to - cannot be represented with a character - is a null pointer - ... , which violates the

[PATCH] D68049: Propeller: Clang options for basic block sections

2020-05-05 Thread Sriraman Tallam via Phabricator via cfe-commits
tmsriram added a comment. @rsmith Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko added a comment. Here is a little proof I've put together (using Z3): https://gist.github.com/SavchenkoValeriy/2355170159ce1febd27498c36ea22149 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 262171. vsavchenko added a comment. Fix clang-format issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79432: [analyzer] StdLibraryFunctionsChecker: Add summaries for libc

2020-05-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. There a couple functional lines commented out, and we need more tests, so I take that the patch is a proof of concept for now? Because its pretty cool if so. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79432/new/

[clang] 8fc7a90 - Let normalize() for posix style convert backslash to slash unconditionally.

2020-05-05 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2020-05-05T13:54:55-04:00 New Revision: 8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 URL: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6 DIFF: https://github.com/llvm/llvm-project/commit/8fc7a907b93a8e9eef96e872f8f926db3ebfe9b6.diff

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 262170. vsavchenko added a comment. Add clarification on infeasible ranges in bitwise tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files:

[PATCH] D79394: [clang][codegen] Refactor argument loading in function prolog. NFC.

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Oh, yes, if `Fn->getArg(n)` is no longer an `O(n)` linked-list walk, then this seems like a great change. I see that that happened... slightly over three years ago. Hooray for legacies.

[PATCH] D79336: [analyzer] Generalize bitwise OR rules for ranges

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 262163. vsavchenko added a comment. Fix few things here and there Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79336/new/ https://reviews.llvm.org/D79336 Files:

[PATCH] D79236: [docs] Regenerate DiagnosticsReference.rst

2020-05-05 Thread Richard Sandiford via Phabricator via cfe-commits
rsandifo-arm reclaimed this revision. rsandifo-arm added a comment. OK, thanks! Reclaiming and reopening the revision in that case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79236/new/ https://reviews.llvm.org/D79236

[PATCH] D79395: [clang][codegen] Hoist parameter attribute setting in function prolog.

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79395/new/ https://reviews.llvm.org/D79395

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko updated this revision to Diff 262158. vsavchenko added a comment. Add parent change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79434/new/ https://reviews.llvm.org/D79434 Files:

[PATCH] D79434: [analyzer] Generalize bitwise AND rules for ranges

2020-05-05 Thread Valeriy Savchenko via Phabricator via cfe-commits
vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. vsavchenko added a project: clang. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. vsavchenko

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

2020-05-05 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: Szelethus, NoQ, baloghadamsoftware, balazske, steakhal. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a

[PATCH] D78827: Add support for #pragma clang fp reassociate(fast|off) -- floating point control of associative math transformations

2020-05-05 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. The reason we call FP contraction "fast" instead of "on" when it's cross-statement is because "on" is supposed to be consistent with the C language rules, whereas "fast" is stronger. There's no analogous situation with reassociation; I don't think the C standard is

  1   2   3   >