[PATCH] D79678: [clangd] Add CSV export for trace metrics

kadircet accepted this revision. kadircet marked 2 inline comments as done. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Comment at: clang-tools-extra/clangd/support/Trace.cpp:210 +assert(!needsQuote(Metric.Name)); +

[clang-tools-extra] b082813 - clang-tidy doc: Fix the syntax to use rst list type

Author: Sylvestre Ledru Date: 2020-05-10T11:25:20+02:00 New Revision: b0828135dbe3ee52a15163856008bcf05e81ccf8 URL: https://github.com/llvm/llvm-project/commit/b0828135dbe3ee52a15163856008bcf05e81ccf8 DIFF:

[clang-tools-extra] f97f92e - add_new_check.py: Update of the template to add an autofix section

Author: Sylvestre Ledru Date: 2020-05-10T11:25:19+02:00 New Revision: f97f92e5b0fd14240c2ec27c44e1b3cfddfdf668 URL: https://github.com/llvm/llvm-project/commit/f97f92e5b0fd14240c2ec27c44e1b3cfddfdf668 DIFF:

[clang-tools-extra] dc0f79e - clang-tidy doc: add a note for checkers with an autofix

Author: Sylvestre Ledru Date: 2020-05-10T11:25:19+02:00 New Revision: dc0f79ea5b99b9609a21c29089c294ab82d88094 URL: https://github.com/llvm/llvm-project/commit/dc0f79ea5b99b9609a21c29089c294ab82d88094 DIFF:

[clang] bcc5ed7 - [CodeGen] fix test to be (mostly) independent of LLVM optimizer; NFC

Author: Sanjay Patel Date: 2020-05-10T11:19:43-04:00 New Revision: bcc5ed7b24e921c8902d0d0db614576bd249f128 URL: https://github.com/llvm/llvm-project/commit/bcc5ed7b24e921c8902d0d0db614576bd249f128 DIFF: https://github.com/llvm/llvm-project/commit/bcc5ed7b24e921c8902d0d0db614576bd249f128.diff

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl marked 4 inline comments as done. yaxunl added a comment. In D79526#2027695 , @tra wrote: > This one is just a FYI. I've managed to reduce the failure in the first > version of this patch and it looks rather odd because the reduced test case >

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. > Fair point, will this option also control the color of the diagnostics > emitted by clang or just clang tidy specific diagnostics? This option sets `DiagOpts->ShowColors` to `true`. As I known, it controls **all** diagnostics reported by the `clang-tidy` program (by

[PATCH] D33029: [clang-format] add option for dangling parenthesis

MyDeveloperDay added a comment. In D33029#2028254 , @bbassi wrote: > @MyDeveloperDay Thanks. This would be my first revision and I have few > questions before I start coding. Would you be able to answer those over > email? They are mainly about the

[clang-tools-extra] a832fc4 - Revert two patches, not ready to be shared

Author: Sylvestre Ledru Date: 2020-05-10T11:27:13+02:00 New Revision: a832fc4b0c1e056edbb458973fac1f0c6db7a9e5 URL: https://github.com/llvm/llvm-project/commit/a832fc4b0c1e056edbb458973fac1f0c6db7a9e5 DIFF:

[clang-tools-extra] 35d867a - [clangd] Filter pch related flags coming from the user

Author: Kadir Cetinkaya Date: 2020-05-10T13:03:59+02:00 New Revision: 35d867a790c2bcf2008b2ee1895ae8af2793b797 URL: https://github.com/llvm/llvm-project/commit/35d867a790c2bcf2008b2ee1895ae8af2793b797 DIFF:

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl updated this revision to Diff 263041. yaxunl marked 2 inline comments as done. yaxunl added a comment. introduce Sema::IsCUDAImplicitHostDeviceFunction() and remove changes to IdentifyCUDATarget and IdentifyCUDAPreference. Added one more test. CHANGES SINCE LAST ACTION

[clang] d02b3ab - [CodeGen] fix test to be (mostly) independent of LLVM optimizer; NFC

Author: Sanjay Patel Date: 2020-05-10T11:25:37-04:00 New Revision: d02b3aba37d9a18691669392ff26ec28b51741f5 URL: https://github.com/llvm/llvm-project/commit/d02b3aba37d9a18691669392ff26ec28b51741f5 DIFF: https://github.com/llvm/llvm-project/commit/d02b3aba37d9a18691669392ff26ec28b51741f5.diff

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. @alexfh ping ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix (authored by sylvestre.ledru). Repository: rG

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section (authored by sylvestre.ledru).

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. @alexfh ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 added a comment. In D79477#2027978 , @hyd-dev wrote: > None of the clang-tidy command line options are prefixed with `-f`. > This command line option used to be `--color-diagnostics`, but I've followed > @hokein's advice to change it to

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. > Would a test case be needed? `clang::tidy::clangTidyMain()` shows that clang-tidy reports all diagnostics by `clang::tidy::handleErrors()`, which constructs a `clang::tidy::(anonymous namespace)::ErrorReporter`, no matter where they come from, so I think a test

[PATCH] D79669: [clangd] Filter pch related flags coming from the user

This revision was automatically updated to reflect the committed changes. Closed by commit rG35d867a790c2: [clangd] Filter pch related flags coming from the user (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79669/new/

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. has been reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. has been reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263070. wxz2020 added a comment. 1. Added the predicates as suggested 2. brought back the TargetParserTest.cpp which was missed last time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 added a comment. In D79477#2028609 , @hyd-dev wrote: > This option sets `DiagOpts->ShowColors` to `true`. As I known, it controls > **all** diagnostics reported by the `clang-tidy` program (by > `clang::tidy::(anonymous

[clang-tools-extra] c7ebf00 - Fix clangd test that depended on a diagnostic removed in Clang.

Author: Richard Smith Date: 2020-05-10T14:13:25-07:00 New Revision: c7ebf0067014dd66acc2f9ec91e2426340791369 URL: https://github.com/llvm/llvm-project/commit/c7ebf0067014dd66acc2f9ec91e2426340791369 DIFF: https://github.com/llvm/llvm-project/commit/c7ebf0067014dd66acc2f9ec91e2426340791369.diff

[clang] 25544ce - [gcov] Default coverage version to '407*' and delete CC1 option -coverage-cfg-checksum

Author: Fangrui Song Date: 2020-05-10T16:14:07-07:00 New Revision: 25544ce2df0daa4304c07e64b9c8b0f7df60c11d URL: https://github.com/llvm/llvm-project/commit/25544ce2df0daa4304c07e64b9c8b0f7df60c11d DIFF: https://github.com/llvm/llvm-project/commit/25544ce2df0daa4304c07e64b9c8b0f7df60c11d.diff

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

rsmith marked an inline comment as done. rsmith added a comment. In D79378#2019336 , @rjmccall wrote: > Is it reasonable to figure out ahead of time that we can skip the null check > completely? It'd be kindof nice to also take advantage of this at -O0

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia updated this revision to Diff 263085. Anastasia added a comment. - Improved behavior by allowing casting between equivalent types. - Improved formatting. - Improved tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60193/new/ https://reviews.llvm.org/D60193 Files:

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We were serializing it no matter what, which was against the spec Repository: rG LLVM Github

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

Anastasia marked 3 inline comments as done. Anastasia added inline comments. Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T *var2 = addrspace_cast<__private T *>(par);

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

njames93 added a comment. In D79477#2028618 , @hyd-dev wrote: > > Not a fan of this test case as it only demonstrates the color behaviour of > > the process running the check not the actual option itself > > What does "option itself" mean? What I mean

[PATCH] D79691: [clangd] Have suppression comments take precedence over warning-as-error

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This matches the clang-tidy behaviour. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79691 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263079. wxz2020 added a comment. Fix the format issue in TargetParserTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[PATCH] D78129: Add Marvell ThunderX3T110 support

wxz2020 updated this revision to Diff 263081. wxz2020 added a comment. fix a typo, thunderx3t110, not thunderx3t100 in TargetParserTest.cpp CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78129/new/ https://reviews.llvm.org/D78129 Files:

[clang] 13a633b - [gcov] Delete CC1 option -coverage-no-function-names-in-data

Author: Fangrui Song Date: 2020-05-10T12:37:44-07:00 New Revision: 13a633b438b6500ecad9e4f936ebadf3411d0f44 URL: https://github.com/llvm/llvm-project/commit/13a633b438b6500ecad9e4f936ebadf3411d0f44 DIFF: https://github.com/llvm/llvm-project/commit/13a633b438b6500ecad9e4f936ebadf3411d0f44.diff

[clang] d6425e2 - Properly implement 'enum class' parsing.

Author: Richard Smith Date: 2020-05-10T13:21:04-07:00 New Revision: d6425e2c14370ecb5e2a4be4cfdef65f8ae69bd0 URL: https://github.com/llvm/llvm-project/commit/d6425e2c14370ecb5e2a4be4cfdef65f8ae69bd0 DIFF: https://github.com/llvm/llvm-project/commit/d6425e2c14370ecb5e2a4be4cfdef65f8ae69bd0.diff

[clang] 2d3f5a6 - Fix typo in enum-base disambiguation.

Author: Richard Smith Date: 2020-05-10T13:39:49-07:00 New Revision: 2d3f5a62de8e5d2cc25aaa49d0a00d31ed32544a URL: https://github.com/llvm/llvm-project/commit/2d3f5a62de8e5d2cc25aaa49d0a00d31ed32544a DIFF: https://github.com/llvm/llvm-project/commit/2d3f5a62de8e5d2cc25aaa49d0a00d31ed32544a.diff

[PATCH] D79693: [test][ARM][CMSE] Use -ffreestanding for arm_cmse.h tests

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: chill, dmgreen. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: clang. The `arm_cmse.h` header includes standard headers, but some tests that include this header explicitly specify

[PATCH] D79694: [tests][Driver] Set `--sysroot=""` to allow `DEFAULT_SYSROOT` build

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: broadwaylamb, sepavloff, jyknight, mstorsjo. Herald added a project: clang. If `DEFAULT_SYSROOT` is configured to some path, some tests would fail. This patch overrides `sysroot` to be the empty string in the

[clang] 8fc12b8 - Enforce the C++11 anonymous enum bitfields check even for

Author: Richard Smith Date: 2020-05-10T14:03:50-07:00 New Revision: 8fc12b86985a088b2abd62a0684742c8e771d6ae URL: https://github.com/llvm/llvm-project/commit/8fc12b86985a088b2abd62a0684742c8e771d6ae DIFF: https://github.com/llvm/llvm-project/commit/8fc12b86985a088b2abd62a0684742c8e771d6ae.diff

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added a comment. In D72841#2027740 , @plotfi wrote: > Hi @rjmccall, I am also seeing similar failures. It is failing on apple's > master (and the swift branches as well) because ParseLangArgs and > ParseCodeGenArgs are getting called in the

[PATCH] D79526: [CUDA][HIP] Workaround for resolving host device function against wrong-sided function

yaxunl added a comment. In D79526#2027552 , @tra wrote: > In D79526#2027470 , @yaxunl wrote: > > > For implicit host device functions, since they are not guaranteed to work > > in device compilation, we can only

[PATCH] D78900: [HIP][AMDGPU] Enable structurizer workarounds

sameerds marked an inline comment as done. sameerds added inline comments. Comment at: clang/lib/Driver/ToolChains/HIP.cpp:158 Args.MakeArgString(Twine("-filetype=") + (OutputIsAsm ? "asm" : "obj"))); + LlcArgs.push_back("--amdgpu-enable-structurizer-workarounds");

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a comment. @rjmccall @mibintc Can we revert this patch for now then, and re-land when this patch is reworked? It would be good to get those bots passing. @rjmccall are the bots that you see failing on your end public? In D72841#2028834 ,

[PATCH] D79477: [clang-tidy] Add --use-color command line option and UseColor option to control colors in diagnostics

hyd-dev added a comment. In D79477#2028637 , @njames93 wrote: > What I mean to say is, if the behaviour of the testing environment changes to > pipe the result to a terminal that supports color, it could cause this test > case to also fail. The

[PATCH] D79698: Run Coverage pass before other *San passes under new pass manager

aeubanks created this revision. aeubanks added reviewers: vitalybuka, leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes compiler-rt/test/msan/coverage-levels.cpp under the new pass manager (final check-msan test!). Under the old pass manager, the