[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid marked an inline comment as done. zbrid added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5357 - if (Args.hasFlag(options::OPT_mspeculative_load_hardening, options::OPT_mno_speculative_load_hardening, - false)) + if (Args.hasFla

[PATCH] D79733: [clang][SLH] Add __has_feature(speculative_load_hardening)

zbrid created this revision. zbrid added reviewers: craig.topper, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. zbrid marked an inline comment as done. zbrid added inline comments. zbrid marked an inline comment as done. Comment at: clang/lib/Dr

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2029752 , @craig.topper wrote: > I noticed when I pulled this morning that this seems to have been pushed as a > branch to the repo > > From https://github.com/llvm/llvm-project > > eb7d32e..63a4fdd master ->

[PATCH] D79732: AMDGPU/HIP: Don't replace pointer types in kernel argument structs

arsenm created this revision. arsenm added reviewers: hliao, yaxunl. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Currently this is counterproductive and doesn't have the desired effect. The way the promotion is handled is by reinterpreting the poin

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

plotfi added a subscriber: ab. plotfi added a comment. @ab @rjmccall @mibintc Posted D79730 for consideration. @mibintc can you produce a version of _this_ diff that works with D79730 applied. Currently the following fail, as t

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

efriedma added a comment. This approach seems to reflect the consensus from the mailing list. Comment at: clang/include/clang/AST/RecordLayout.h:74 + /// The maximum allowed field alignment. This is set by #pragma pack. + CharUnits MaxFieldAlignment; + If we

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin updated this revision to Diff 263218. aheejin added a comment. - Delete a debugging(?) line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79655/new/ https://reviews.llvm.org/D79655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D79655: [WebAssembly] Ignore exception specifications

aheejin marked an inline comment as done. aheejin added inline comments. Comment at: clang/test/CodeGenCXX/wasm-eh.cpp:399 +// RUN: %clang_cc1 %s -triple wasm32-unknown-unknown -fms-extensions -fexceptions -fcxx-exceptions -fwasm-exceptions -target-feature +exception-handling

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi created this revision. plotfi added reviewers: rjmccall, ab. Herald added a project: clang. Herald added a subscriber: cfe-commits. After speaking with @ab and @rjmccall on https://reviews.llvm.org/D72841#2027740 and https://github.com/apple/llvm-project/pull/1202. it sounds like code-ge

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3192 + Opts.NoHonorNaNs = + Opts.FastMath || CGOpts.NoNaNsFPMath || Opts.FiniteMathOnly; + Opts.NoHonorInfs = mibintc wrote: > @rjmccall I could set these by using Args.h

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

rjmccall added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185 Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) || Args.hasArg(OPT_cl_finite_math_only) || Args.hasArg(OPT_cl_fast_relaxed_math); mibintc wrote: >

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3192 + Opts.NoHonorNaNs = + Opts.FastMath || CGOpts.NoNaNsFPMath || Opts.FiniteMathOnly; + Opts.NoHonorInfs = @rjmccall I could set these by using Args.hasArg instead of C

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

craig.topper added a comment. I noticed when I pulled this morning that this seems to have been pushed as a branch to the repo From https://github.com/llvm/llvm-project eb7d32e..63a4fdd master -> origin/master - [new branch] arcpatch-D62368 -> origin/arcpatch-D62368 Repository:

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e3e56f2a367: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66983

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 5 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ValistChecker.cpp:176-180 if (const auto *DeclReg = Reg->getAs()) { if (isa(DeclReg->getDecl())) Reg = C.getState()->getSVal

[PATCH] D78442: Create a warning flag for 'warn_conv_*_not_used'

rdwampler updated this revision to Diff 263202. rdwampler added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78442/new/ https://reviews.llvm.org/D78442 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 263204. baloghadamsoftware added a comment. Thank you for your comments, @balazske. You are completely right, I updated the patch now. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: cla

[clang] 8e3e56f - [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

Author: Thomas Lively Date: 2020-05-11T10:01:55-07:00 New Revision: 8e3e56f2a36701480eeb65e426701d5a9025cc59 URL: https://github.com/llvm/llvm-project/commit/8e3e56f2a36701480eeb65e426701d5a9025cc59 DIFF: https://github.com/llvm/llvm-project/commit/8e3e56f2a36701480eeb65e426701d5a9025cc59.diff

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rG9959eb918acf: Add vendor identity check for Hygon Dhyana processor in Scudo (authored by cryptoad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62368/new/

[PATCH] D62368: Add vendor identity check for Hygon Dhyana processor in Scudo

cryptoad added a comment. In D62368#2027895 , @fanjinke wrote: > Hi Cryptoad， > > Could you help me to commit the patch? Because I don't have access. > > Thanks. Done, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. pratlucas added reviewers: t.p.northover, ostannard, pcc. During CodeGen for AArch64 Neon intrinsics, Clang was incorrectly assuming all the pointers from which loads w

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, sfertile, cebowleratibm. Xiangling_L added a project: LLVM. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. Implement AIX special alignment rule by recursivel

[PATCH] D79595: Fix bugs when an included file name is typo corrected.

abhinavgaba added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:8 // RUN: touch %t.dir/foo.h -// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -Xclang -verify -fsyntax-only %s 2>&1 | FileCheck %s +// RUN: not %clang_cl /FI\\?\%t.dir\FOO.h /WX -fsynta

[PATCH] D79639: [SveEmitter] Builtins for SVE matrix multiply `mmla`.

sdesmalen added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:74 // q: 1/4 width elements, 4x element count +// b: 1/4 width elements, 4x element count, integer, unsigned // o: 4x width elements, 1/4 element count Can you phrase this like `e

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

JDevlieghere added a comment. I'm in favor of this change. I'm not too happy with how this works in CMake, I've expressed similar concerns when the FORCE_ON approach was suggested in D71306 . I really like what we ended up with in LLDB. The TL;DR is that we have

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

jdoerfert added a comment. Thanks for these! We should probably split this in three patches. I commented below, mostly minor stuff. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPConstants.h:101 +extern Type *IntPtrTy; +extern Type *SizeTy; + I can totally

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

This revision was automatically updated to reflect the committed changes. Closed by commit rG9aee35bcc90f: [Clang] Fix the incorrect return type of atomic_is_lock_free (authored by kamleshbhalui, committed by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

Quuxplusone added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:158 +def DeprecatedCopy : DiagGroup<"deprecated-copy", [DeprecatedCopyUserProvided]>; +def DeprecatedCopyDtor : DiagGroup<"deprecated-copy-dtor", [DeprecatedCopyDtorUserProvided]>; def

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

ldionne added a comment. I'll commit this since I think everyone was fine with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D79504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] 9aee35b - [Clang] Fix the incorrect return type of atomic_is_lock_free

Author: Kamlesh Kumar Date: 2020-05-11T10:48:35-04:00 New Revision: 9aee35bcc90faa9db3ea0111c0a80ebee7446cac URL: https://github.com/llvm/llvm-project/commit/9aee35bcc90faa9db3ea0111c0a80ebee7446cac DIFF: https://github.com/llvm/llvm-project/commit/9aee35bcc90faa9db3ea0111c0a80ebee7446cac.diff

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h:403 /// frame. May fail; returns null on failure. - const VarRegion *getParameterLocation(unsigned Index, -unsigned BlockCoun

[PATCH] D79388: [clang-format] Fix AlignConsecutive on PP blocks

JakeMerdichAMD added a comment. Hey, @MyDeveloperDay, can I get your assistance in committing this? It's probably been long enough for anyone to chime in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79388/new/ https://reviews.llvm.org/D79388

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

jbcoe added a comment. I expect that accepting this patch will need require an update to be made to https://github.com/google/styleguide. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79715/new/ https://reviews.llvm.org/D79715 _

[clang] ec2d93c - [analyzer] SATestBuild.py: Allow comments in run_static_analyzer.cmd.

Author: Artem Dergachev Date: 2020-05-11T17:26:37+03:00 New Revision: ec2d93c7d7b00374535cb3d6658abec4b150f6f6 URL: https://github.com/llvm/llvm-project/commit/ec2d93c7d7b00374535cb3d6658abec4b150f6f6 DIFF: https://github.com/llvm/llvm-project/commit/ec2d93c7d7b00374535cb3d6658abec4b150f6f6.dif

[PATCH] D79714: [Diagnostics] Restore -Wdeprecated warning when user-declared copy assignment operator is defined as deleted (PR45634)

xbolva00 created this revision. xbolva00 added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. Solves https://bugs.llvm.org/show_bug.cgi?id=45634 Be more agressive than GCC with -Wdeprecated-copy. Also provide -W(no-)deprecated-copy-user-provided options

[PATCH] D79715: [clang-format] Update GoogleStyle for C# code to match Google's internal C# style guide

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79715 Files: clang/lib/Format/Format.cpp clang/unittests/

Re: [clang] c90e198 - Fix parsing of enum-base to follow C++11 rules.

On Sat, May 9, 2020 at 4:32 AM Richard Smith via cfe-commits wrote: > > > Author: Richard Smith > Date: 2020-05-08T19:32:00-07:00 > New Revision: c90e198107431f64b73686bdce31c293e3380ac7 > > URL: > https://github.com/llvm/llvm-project/commit/c90e198107431f64b73686bdce31c293e3380ac7 > DIFF: > htt

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. @rjmccall Uncertain how to proceed, can you recommend? If I recall correctly, I added the lines in CompilerOptions because there were many failing lit tests, i could have fixed the lit fails by adding the lang options to the lit tests. (of course that change could have

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 263154. baloghadamsoftware added a comment. Minor fix to get rid of a warning, some comments added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files: clang/include/clang/StaticAnalyzer/Chec

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1051 + + const Expr *OriginExpr; + unsigned Index; We do not use this at all. However,

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added a comment. Thank you for quickly looking into this. In D79704#2029230 , @Szelethus wrote: > - What identifies a `MemRegion`, `TypedValueRegion`s in particular? Why are > parame

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

kamleshbhalui added a comment. In D79504#2029267 , @ldionne wrote: > What name and email do you want this committed with? Kamlesh Kumar kamleshbha...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc marked 2 inline comments as done. mibintc added a comment. Some inline replies/comments to @rjmccall and @plotfi Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3185 Opts.FiniteMathOnly = Args.hasArg(OPT_ffinite_math_only) || Args.hasArg(OPT_cl_finite_ma

[PATCH] D79504: [Clang] Wrong return type of atomic_is_lock_free

ldionne added a comment. What name and email do you want this committed with? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79504/new/ https://reviews.llvm.org/D79504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

balazske updated this revision to Diff 263151. balazske added a comment. Added target dependent tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79330/new/ https://reviews.llvm.org/D79330 Files: clang/lib/StaticAnalyzer/Checkers/VLASizeCheck

[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

mibintc added a comment. I will work @rjmccall comment about codegen vs langopt - can you leave it in place for now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72841/new/ https://reviews.llvm.org/D72841 __

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

Szelethus added a comment. > Currently, parameters of functions without their definition present cannot be > represented as regions because it would be difficult to ensure that the same > declaration is used in every case. To overcome this, we introduce a new kind > of region called ParamRegion

[PATCH] D79378: PR34581: Don't remove an 'if (p)' guarding a call to 'operator delete(p)' under -Oz.

dnsampaio added a comment. From my point it does LGTM. Comment at: clang/lib/CodeGen/CGExprCXX.cpp:2042-2049 // Null check the pointer. llvm::BasicBlock *DeleteNotNull = createBasicBlock("delete.notnull"); llvm::BasicBlock *DeleteEnd = createBasicBlock("delete.end");

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. stuij added a parent revision: D76077: [ARM] Add __bf16 as new Bfloat16 C Type. stuij added a child revision: D79708: [clangd][BFloat] add NEON emitter for bfloat. The pol

[PATCH] D79710: [clangd][BFloat] add create/set/get/dup intrinsics

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls. Herald added a project: clang. This patch is part of a series that adds support for the Bfloat16 extension of the Armv8.6-a architecture, as detailed

[PATCH] D79708: [clangd][BFloat] add NEON emitter for bfloat

stuij created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, kristof.beyls, mgorny. Herald added a project: clang. stuij added a parent revision: D76077: [ARM] Add __bf16 as new Bfloat16 C Type. stuij edited parent revisions, a

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

sammccall accepted this revision. sammccall added a comment. Sorry, I thought I approved already :-( CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D79201: [clang-format] : Fix additional pointer alignment for overloaded operators

MyDeveloperDay added a comment. gentle ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79201/new/ https://reviews.llvm.org/D79201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, wh

[PATCH] D79678: [clangd] Add CSV export for trace metrics

sammccall updated this revision to Diff 263137. sammccall added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79678/new/ https://reviews.llvm.org/D79678 Files: clang-tools-extra/clangd/support/Trace.cpp clang-tools-

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:39 +void recordMetrics(const SelectionTree &S) { + static constexpr trace::Metric Selection("selection", trace::Metric::Counter); this deserves a comment about what we're trac

[PATCH] D79678: [clangd] Add CSV export for trace metrics

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/support/Trace.cpp:210 +assert(!needsQuote(Metric.Name)); +std::string QuotedLabel; +if (needsQuote(Label)) kadircet wrote: > do we ever e

[PATCH] D78190: Add Bfloat IR type

stuij added a comment. Hi there, a gentle ping: does this look good to you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78190/new/ https://reviews.llvm.org/D78190 ___ cfe-commits mailing list cfe-com

[PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

joxeankoret added a comment. Any news? It's amazing that such a basic feature (getting an operator kind) with working patches (since 2015) is not yet available in 2020. If there is any work that needs to be done, I propose myself to do it. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D79701: [clangd] Add metrics for selection tree and recovery expressions.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D79701 Files: clang-tools-extra/clangd/Sele

[PATCH] D78658: [clang][Frontend] Add missing error handling

LemonBoy added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78658/new/ https://reviews.llvm.org/D78658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D79579: [SveEmitter] Add builtins for svmovlb and svmovlt

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cad97595f40: [SveEmitter] Add builtins for svmovlb and svmovlt (authored by sdesmalen). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D79579?vs=262624&id=263125#toc

[PATCH] D60193: [OpenCL] Added addrspace_cast operator

mantognini accepted this revision. mantognini added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/SemaOpenCLCXX/addrspace_cast.cl:19-24 +template +void test_temp(__global int *par) { + T *var1 = addrspace_cast(par); + __private T *va

[clang] 4cad975 - [SveEmitter] Add builtins for svmovlb and svmovlt

Author: Sander de Smalen Date: 2020-05-11T09:41:58+01:00 New Revision: 4cad97595f40f7a5bda25f4aa107cbbce05bd394 URL: https://github.com/llvm/llvm-project/commit/4cad97595f40f7a5bda25f4aa107cbbce05bd394 DIFF: https://github.com/llvm/llvm-project/commit/4cad97595f40f7a5bda25f4aa107cbbce05bd394.di

[PATCH] D79692: [clangd] Make version in PublishDiagnosticsParams optional

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc9fefec4368: [clangd] Make version in PublishDiagnosticsParams optional (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D79692?vs=263084&id=263117#toc Repository: rG LLVM G

[PATCH] D79500: [clangd] Refactor code completion signal's utility properties.

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:112 SymbolRelevanceSignals Relevance; -Relevance.Name = Sym.Name; Relevance.Query = SymbolRelevanceSignals::Generic; why this change? Comment at

[clang-tools-extra] cc9fefe - [clangd] Make version in PublishDiagnosticsParams optional

Author: Kadir Cetinkaya Date: 2020-05-11T10:31:10+02:00 New Revision: cc9fefec4368efb64e78dee1109e342b37d21bca URL: https://github.com/llvm/llvm-project/commit/cc9fefec4368efb64e78dee1109e342b37d21bca DIFF: https://github.com/llvm/llvm-project/commit/cc9fefec4368efb64e78dee1109e342b37d21bca.dif

[PATCH] D79330: [Analyzer][VLASizeChecker] Check for VLA size overflow.

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. With the minor adjustment in the one test case this LGTM. Comment at: clang/test/Analysis/vla.c:107 + if (x == BIGINDEX) { +size_t s = sizeof(int[x][x][x][x]); //

[PATCH] D78129: Add Marvell ThunderX3T110 support

SjoerdMeijer added a comment. This looks good now, but sorry, one more request: I've just noticed a Clang driver test is missing. Can you add a test for this to `clang/test/Driver/aarch64-cpus.c`? And related to this, the relevant tests to `llvm/unittests/Support/TargetParserTest.cpp`? CHANGE

[clang] 507d1eb - Add a missing test file for recovery expressions.

Author: Haojian Wu Date: 2020-05-11T09:23:32+02:00 New Revision: 507d1eb1cec33ccc2fce0ee7f688e19a42e43990 URL: https://github.com/llvm/llvm-project/commit/507d1eb1cec33ccc2fce0ee7f688e19a42e43990 DIFF: https://github.com/llvm/llvm-project/commit/507d1eb1cec33ccc2fce0ee7f688e19a42e43990.diff LO

[PATCH] D79160: [AST] Preserve the type in RecoveryExprs for broken function calls.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8222107aa924: [AST] Preserve the type in RecoveryExprs for broken function calls. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79160/n

[PATCH] D79276: [FileCheck] Support comment directives

jhenderson added inline comments. Comment at: llvm/test/FileCheck/comment/suffixes.txt:1-2 +# Comment prefixes plus check directive suffixes are not comment directives +# and are treated as plain text. + jdenny wrote: > jhenderson wrote: > > jdenny wrote: > > > j

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

efriedma added a comment. For sunpckhi... no, not really. You'd need to either add a new opcode, or add a new shuffle operation of some sort. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/ https://reviews.llvm.org/D79587

[clang] d82538b - Fix -Wunused compiler warning.

Author: Haojian Wu Date: 2020-05-11T09:20:48+02:00 New Revision: d82538b3f691f3ba1cb7a945a5f8594f71816fdf URL: https://github.com/llvm/llvm-project/commit/d82538b3f691f3ba1cb7a945a5f8594f71816fdf DIFF: https://github.com/llvm/llvm-project/commit/d82538b3f691f3ba1cb7a945a5f8594f71816fdf.diff LO

[clang] 8222107 - [AST] Preserve the type in RecoveryExprs for broken function calls.

Author: Haojian Wu Date: 2020-05-11T08:46:18+02:00 New Revision: 8222107aa9249aada81334c922a2d284042242ed URL: https://github.com/llvm/llvm-project/commit/8222107aa9249aada81334c922a2d284042242ed DIFF: https://github.com/llvm/llvm-project/commit/8222107aa9249aada81334c922a2d284042242ed.diff LO

Re: [PATCH] D78598: [clangd] Remove vscode plugin: now https://github.com/clangd/vscode-clangd

yes that's the case. See https://github.com/clangd/vscode-clangd/pulls?q=is%3Apr On Mon, May 11, 2020 at 9:57 AM Nathan Ridge via Phabricator < revi...@reviews.llvm.org> wrote: > nridge added a comment. > > Also, does this mean that patches to vscode-clangd should now be submitted > as a Github P

<    1   2