[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber created this revision. bernhardmgruber added reviewers: aaron.ballman, JonasToth, Eugene.Zelenko, lebedev.ri. bernhardmgruber added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. bernhardmgruber updated this revision

[PATCH] D79322: [FEnv] Small fixes to implementation of flt.rounds

sepavloff updated this revision to Diff 265990. sepavloff edited the summary of this revision. sepavloff added a comment. Updated patch - Removed support for lowering to library call at all. Now it is NFC patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber updated this revision to Diff 265993. bernhardmgruber edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80514/new/ https://reviews.llvm.org/D80514 Files: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp

[PATCH] D79711: [ARM][BFloat] Add poly64_t on AArch32.

stuij updated this revision to Diff 265987. stuij added a comment. added testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711 Files: clang/include/clang/Basic/TargetBuiltins.h

[PATCH] D79992: [clangd] Patch PP directives to use stale preambles while building ASTs

kadircet updated this revision to Diff 265995. kadircet marked 5 inline comments as done. kadircet added a comment. - Assert on patch contents, using regexes for main file match. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79992/new/

[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

bernhardmgruber marked 3 inline comments as done. bernhardmgruber added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:285-302 +SourceLocation End = +expandIfMacroId(ReturnLoc.getSourceRange().getEnd(), SM); +

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8111 "pointer cannot be cast to type %0">; +def err_cast_to_bfloat : Error<"cannot type-cast to __bf16">; +def err_cast_from_bfloat : Error<"cannot type-cast from __bf16">;

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

stuij updated this revision to Diff 265988. stuij added a comment. replanted arg passing test from other patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/ https://reviews.llvm.org/D79708 Files: clang/include/clang/Basic/arm_bf16.td

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij updated this revision to Diff 265985. stuij marked 14 inline comments as done. stuij added a comment. addressed review comments and some related general changes: - renamed IsSoftFloatABI -> IsFloatABISoftFP - split bfloat tests out of arm-mangle-16bit-float.cpp - bfloat shouldn't be

[PATCH] D80509: buildkite test 2

goncharov created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous. Herald added a project: clang. goncharov removed subscribers: jkorous, arphaman, kadircet, usaxena95, cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D80288: [AST] default implementation is possible for non-member functions in C++2a.

This revision was automatically updated to reflect the committed changes. Closed by commit rG447ea9b4f5f5: [AST] default implementation is possible for non-member functions in C++20. (authored by MyDeveloperDay, committed by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D80508: [AST] Fix the source range for TagDecl if there is no matched } brace.

hokein created this revision. hokein added reviewers: sammccall, akyrtzi. Herald added subscribers: usaxena95, kadircet, arphaman, dexonsmith, jkorous, ilya-biryukov. Herald added a project: clang. The AST is preserved when the TagDecl misses a } brace, but the source range seems incorrect (just

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

This revision was automatically updated to reflect the committed changes. Closed by commit rG72c5ea1d73bb: [clangd] Enable cross-file-rename by default. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80507/new/

[clang] 447ea9b - [AST] default implementation is possible for non-member functions in C++20.

Author: mydeveloperday Date: 2020-05-25T10:45:12+02:00 New Revision: 447ea9b4f5f562c8fab7d11ecbb10ecd33155d5b URL: https://github.com/llvm/llvm-project/commit/447ea9b4f5f562c8fab7d11ecbb10ecd33155d5b DIFF:

[PATCH] D80472: [clangd] Add access specifier information to hover contents

kadircet accepted this revision. kadircet marked an inline comment as done. kadircet added a comment. This revision is now accepted and ready to land. thanks! LGTM with some minor comments. let me know if you don't have commit access so that i can land this for you. Comment

[PATCH] D80288: [AST] default implementation is possible for non-member functions in C++2a.

hokein updated this revision to Diff 265978. hokein added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80288/new/ https://reviews.llvm.org/D80288 Files: clang/include/clang/AST/Decl.h

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I suspect we're going to get some complaints from people whose index is perpetually behind and missing files, but this is the tradeoff of the design, we have to accept that or refine

[clang-tools-extra] 72c5ea1 - [clangd] Enable cross-file-rename by default.

Author: Haojian Wu Date: 2020-05-25T10:46:57+02:00 New Revision: 72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 URL: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7 DIFF: https://github.com/llvm/llvm-project/commit/72c5ea1d73bb89af6f82c14ddb0b7f4c2510bab7.diff

[clang-tools-extra] b752a27 - [clangd] Log use of heuristic go-to-def. NFC

Author: Sam McCall Date: 2020-05-25T10:19:34+02:00 New Revision: b752a2743ab0d24d8da5d97c07fbdb996df78b1f URL: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f DIFF: https://github.com/llvm/llvm-project/commit/b752a2743ab0d24d8da5d97c07fbdb996df78b1f.diff

[PATCH] D80507: [clangd] Enable cross-file-rename by default.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The cross-file rename feature is stable enough to enable it (has been rolled out internally for a few weeks).

[PATCH] D79961: [PGO] Fix computation of fuction Hash

serge-sans-paille added a comment. Up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79961/new/ https://reviews.llvm.org/D79961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D71155: [analyzer] CERT STR rule checkers: STR30-C

Charusso added a comment. In D71155#1854908 , @NoQ wrote: > Let's separate `CStringChecker` improvements into a separate patch and have a > separate set of tests for it. I was thinking about creating tests, but I cannot figure out any better testing

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso abandoned this revision. Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. Way more sophisticated matching: https://reviews.llvm.org/D77745 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70805

[PATCH] D71155: [analyzer] CERT STR rule checkers: STR30-C

Charusso updated this revision to Diff 265963. Charusso retitled this revision from "[analyzer] CERT: STR30-C" to "[analyzer] CERT STR rule checkers: STR30-C". Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. - Refactor. CHANGES SINCE LAST ACTION

[PATCH] D71033: [analyzer] CERT STR rule checkers: STR32-C

Charusso updated this revision to Diff 265962. Charusso retitled this revision from "[analyzer] CERT: STR32-C" to "[analyzer] CERT STR rule checkers: STR32-C". Charusso added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. - Refactor. - State out explicitly whether the

[PATCH] D80440: [OpenCL] Prevent fused mul and add by default

sepavloff added a comment. Contraction is just an optimization technique. Unless a user explicitly requests strict FP semantics, contraction does not break C++ semantics. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80440/new/ https://reviews.llvm.org/D80440

[PATCH] D70411: [analyzer] CERT STR rule checkers: STR31-C

Charusso updated this revision to Diff 265959. Charusso retitled this revision from "[analyzer] CERT: STR31-C" to "[analyzer] CERT STR rule checkers: STR31-C". Charusso added a comment. - Refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:754 + if (OnlyLibstdcxxStatic) +CmdArgs.push_back("-Bstatic"); TC.AddCXXStdlibLibArgs(Args, CmdArgs); This is correct. If GNU ld<2.25 compatibility is not

[clang] 52b03aa - [clang-format][PR46043] Parse git config w/ implicit values

Author: Jake Merdich Date: 2020-05-24T20:32:54-04:00 New Revision: 52b03aaa22f650bbd36ceb3bdae4699dae71b2b8 URL: https://github.com/llvm/llvm-project/commit/52b03aaa22f650bbd36ceb3bdae4699dae71b2b8 DIFF: https://github.com/llvm/llvm-project/commit/52b03aaa22f650bbd36ceb3bdae4699dae71b2b8.diff

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0da5d2bbe83: Change default traversal in AST Matchers to ignore invisible nodes (authored by stephenkelly). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80499: Remove obsolete ignore*() matcher uses

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, arphaman, kbarton, nemanjai. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80499 Files:

[clang] d0da5d2 - Change default traversal in AST Matchers to ignore invisible nodes

Author: Stephen Kelly Date: 2020-05-25T00:18:54+01:00 New Revision: d0da5d2bbe8305d06dc01a98706fd73e11e24a9f URL: https://github.com/llvm/llvm-project/commit/d0da5d2bbe8305d06dc01a98706fd73e11e24a9f DIFF: https://github.com/llvm/llvm-project/commit/d0da5d2bbe8305d06dc01a98706fd73e11e24a9f.diff

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

davidstone added a comment. I noticed the missing return because there is a warning (not as error) that caught it, I think the warning about falling off the end of a non-void-returning function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

jfb accepted this revision. jfb added a comment. One suggestions, otherwise looks good. Thanks for doing this :) Comment at: llvm/include/llvm/ADT/DirectedGraph.h:97 + } + friend bool operator!=(const NodeType , const NodeType ) { !(M == N); } davidstone

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay planned changes to this revision. MyDeveloperDay added a comment. @steveire I'm still working on this I have just one issue from your lit that is failing (see below), but I wanted to capture the other changes in the review. const Foo>* p = const_cast>*>(); CHANGES SINCE LAST

[PATCH] D72534: Change default traversal in AST Matchers to ignore invisible nodes

steveire updated this revision to Diff 265946. steveire added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72534/new/ https://reviews.llvm.org/D72534 Files: clang/docs/ReleaseNotes.rst

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. > I would like to reiterate my discomfort with using East/West as the > identifiers here I'd like to think that I can see it from both angles, @steveire is correct, if I just supply Left/Right then we'll have a

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 265949. MyDeveloperDay retitled this revision from "[clang-format] Add Left/Right Const fixer capability" to "[clang-format] Add East/West Const fixer capability". MyDeveloperDay added a comment. Add more test cases Cover more template and namespace

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin marked 6 inline comments as done. danielmartin added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:680 +StringRef getAccessString(AccessSpecifier AS) { + switch (AS) { kadircet wrote: > it is annoying to have this function

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin updated this revision to Diff 265942. danielmartin added a comment. Move clang::getAccess to Specifiers.h and refactor logic in clang-doc to use that function instead of its own. Also changes where "public", "private" etc. is shown in the hover contents. Now it's shown at the

[clang] e60de8c - Add missing test

Author: Stephen Kelly Date: 2020-05-24T22:50:50+01:00 New Revision: e60de8c825d3087dca26d97985febbf97e179311 URL: https://github.com/llvm/llvm-project/commit/e60de8c825d3087dca26d97985febbf97e179311 DIFF: https://github.com/llvm/llvm-project/commit/e60de8c825d3087dca26d97985febbf97e179311.diff

[clang-tools-extra] 2be92b7 - Fix ignore-traversal to call correct method

Author: Stephen Kelly Date: 2020-05-24T22:33:10+01:00 New Revision: 2be92b7f7e41037e051096df8a9c4de35502c036 URL: https://github.com/llvm/llvm-project/commit/2be92b7f7e41037e051096df8a9c4de35502c036 DIFF: https://github.com/llvm/llvm-project/commit/2be92b7f7e41037e051096df8a9c4de35502c036.diff

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar added a comment. In D79437#2052109 , @aaron.ballman wrote: > Thank you for working on this check, I think it's useful functionality. One > concern I have, though, is that it's not flow-sensitive and should probably > be implemented as a

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

Tridacnid added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79912/new/ https://reviews.llvm.org/D79912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80492: Avoid linking libdl unless needed

mstorsjo added a reviewer: beanz. mstorsjo added a subscriber: beanz. mstorsjo added a comment. I think this is ok, but adding @beanz who knows the cmake conventions better than me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/

[PATCH] D80492: Avoid linking libdl unless needed

thieta created this revision. thieta added a reviewer: mstorsjo. thieta added a project: clang. Herald added subscribers: cfe-commits, mgorny. This fixes cross-compilation when targeting a platform not using libdl and mirrors libdl linking in other parts of the code. Repository: rG LLVM

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Sounds good - I'll close this one and open three new ones. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list

[PATCH] D79437: [clang-tidy] Add fsetpos argument checker

DerWaschbar updated this revision to Diff 265930. DerWaschbar marked 3 inline comments as done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79437/new/ https://reviews.llvm.org/D79437 Files:

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked 2 inline comments as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:575 + std::tie(State, RetVal) = + static_cast()->handleConstructionContext(getOriginExpr(), +

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware updated this revision to Diff 265928. baloghadamsoftware marked an inline comment as done. baloghadamsoftware added a comment. `FIXME` and assertions added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79704/new/ https://reviews.llvm.org/D79704 Files:

[PATCH] D79704: [Analyzer] [NFC] Parameter Regions

baloghadamsoftware added a comment. The big question to decide: Either we keep `ParamRegion` as a separate region in the class hierarchy and at the few places where `DeclRegion` or `VarRegion` is used and parameters are possible we duplicate the few lines. (Current status.) The other way is

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 265926. baloghadamsoftware added a comment. Merged `retrieveFromConstructionContext()` to `handleConstructionContext()`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80366/new/ https://reviews.llvm.org/D80366 Files:

[clang-tools-extra] 4c5818d - [clang-tidy] Fix potential assert in use-noexcept check

Author: Nathan James Date: 2020-05-24T14:40:58+01:00 New Revision: 4c5818dd8cd9336136a80a02b262b501b23f6492 URL: https://github.com/llvm/llvm-project/commit/4c5818dd8cd9336136a80a02b262b501b23f6492 DIFF: https://github.com/llvm/llvm-project/commit/4c5818dd8cd9336136a80a02b262b501b23f6492.diff

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 updated this revision to Diff 265923. njames93 added a comment. - Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80371/new/ https://reviews.llvm.org/D80371 Files:

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c5818dd8cd9: [clang-tidy] Fix potential assert in use-noexcept check (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D80371?vs=265923=265924#toc Repository: rG LLVM Github

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

aaron.ballman added a comment. In D80371#2052454 , @njames93 wrote: > In D80371#2052069 , @aaron.ballman > wrote: > > > LGTM, but please add a test case for the changes. > > > As this fix is preventing a crash in

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added a comment. In D80425#2052607 , @thieta wrote: > I am planning to revise this one now that we have thinlto-cache-dir option > landed here are my plans: > > - Keep the libdl patch as is (seems like there are no more comments on this). > -

[PATCH] D80490: Check for rule of five and zero.

vrnithinkumar updated this revision to Diff 265921. vrnithinkumar added a comment. fixed the clang-tidy warnig Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80490/new/ https://reviews.llvm.org/D80490 Files:

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. I am planning to revise this one now that we have thinlto-cache-dir option landed here are my plans: - Keep the libdl patch as is (seems like there are no more comments on this). - Remove the symlink patch for now and potentially move that to another patch - Rework the

[clang] 04ed532 - Fix skip-invisible with overloaded method calls

Author: Stephen Kelly Date: 2020-05-24T12:36:16+01:00 New Revision: 04ed532ef0ce76d53ca456cbc581756bb01d30e7 URL: https://github.com/llvm/llvm-project/commit/04ed532ef0ce76d53ca456cbc581756bb01d30e7 DIFF: https://github.com/llvm/llvm-project/commit/04ed532ef0ce76d53ca456cbc581756bb01d30e7.diff

[clang-tools-extra] 5e9392d - Add explicit traversal mode to matchers for implicit constructors

Author: Stephen Kelly Date: 2020-05-24T12:36:15+01:00 New Revision: 5e9392deaf5bfa43846334e9b07a126ae3410a38 URL: https://github.com/llvm/llvm-project/commit/5e9392deaf5bfa43846334e9b07a126ae3410a38 DIFF: https://github.com/llvm/llvm-project/commit/5e9392deaf5bfa43846334e9b07a126ae3410a38.diff

[PATCH] D80486: [clang-format][PR46043] Parse git config w/ implicit values

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80486/new/ https://reviews.llvm.org/D80486

[clang] 3ed8ebc - Fix return values of some matcher functions

Author: Stephen Kelly Date: 2020-05-24T12:37:44+01:00 New Revision: 3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc URL: https://github.com/llvm/llvm-project/commit/3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc DIFF: https://github.com/llvm/llvm-project/commit/3ed8ebc2f6b8172bed48cc5986d3b7af4cfca1bc.diff

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak updated this revision to Diff 265918. llunak edited the summary of this revision. llunak added a comment. Enabled the option by default for clang-cl to match MSVC. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69585/new/ https://reviews.llvm.org/D69585

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak marked an inline comment as done. llunak added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +

[clang] 72210ce - Fix Wdocumentation warnings after argument renaming. NFC.

Author: Simon Pilgrim Date: 2020-05-24T11:18:20+01:00 New Revision: 72210ce7f57192652414ebbdf9f643f86532d700 URL: https://github.com/llvm/llvm-project/commit/72210ce7f57192652414ebbdf9f643f86532d700 DIFF: https://github.com/llvm/llvm-project/commit/72210ce7f57192652414ebbdf9f643f86532d700.diff

[PATCH] D80490: Check for rule of five and zero.

vrnithinkumar created this revision. vrnithinkumar added reviewers: aaron.ballman, alexfh, jbcoe, dblaikie, rsmith. Herald added subscribers: cfe-commits, kbarton, mgorny, nemanjai. Herald added a project: clang. New check to check if a class defines all special members of none of them. This

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc created this revision. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. No idea if this is 'correct' or the right way to fix this, so just sending this mostly as an FYI. Someone who works more closely on the sanitizers might need to take it over and figure

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265907. pestctrl added a comment. Both extension and extwarn need to be in the c99-extensions group Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265908. pestctrl added a comment. Rebase on master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D80486: [clang-format][PR46043] Parse git config w/ implicit values

JakeMerdichAMD created this revision. JakeMerdichAMD added reviewers: MyDeveloperDay, krasimir, sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. https://bugs.llvm.org/show_bug.cgi?id=46043 Git's config is generally of the format 'key=val', but a setting

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 265900. BRevzin added a comment. - Backing out changes that aren't strictly comparison-related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files:

[PATCH] D80039: [NFC, StackSafety] LTO tests for MTE and StackSafety

This revision was automatically updated to reflect the committed changes. Closed by commit rG088fb9734843: [NFC, StackSafety] LTO tests for MTE and StackSafety (authored by vitalybuka). Changed prior to commit: https://reviews.llvm.org/D80039?vs=264361=265902#toc Repository: rG LLVM Github

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 added a comment. In D80371#2052069 , @aaron.ballman wrote: > LGTM, but please add a test case for the changes. As this fix is preventing a crash in error causing code I can't include a specific test case as the clang-tidy tests will fail if

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

pestctrl updated this revision to Diff 265898. pestctrl added a comment. Added warning to group c99-extensions, only enable warning when C99 or less Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79945/new/ https://reviews.llvm.org/D79945 Files:

[clang] 088fb97 - [NFC, StackSafety] LTO tests for MTE and StackSafety

Author: Vitaly Buka Date: 2020-05-23T17:39:54-07:00 New Revision: 088fb9734843c09493d5965baed775c4ec32d5fb URL: https://github.com/llvm/llvm-project/commit/088fb9734843c09493d5965baed775c4ec32d5fb DIFF: https://github.com/llvm/llvm-project/commit/088fb9734843c09493d5965baed775c4ec32d5fb.diff

[PATCH] D80371: [clang-tidy] Fix potential assert in use-noexcept check

njames93 updated this revision to Diff 265899. njames93 added a comment. - Isolated exact cause of the assert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80371/new/ https://reviews.llvm.org/D80371 Files:

[clang] 9292ece - [clang driver] Spell "--export-dynamic-symbol" with two dashes.

Author: Eli Friedman Date: 2020-05-23T15:46:28-07:00 New Revision: 9292ece9956c98acf0cfa6e188316243ffbf4bed URL: https://github.com/llvm/llvm-project/commit/9292ece9956c98acf0cfa6e188316243ffbf4bed DIFF: https://github.com/llvm/llvm-project/commit/9292ece9956c98acf0cfa6e188316243ffbf4bed.diff

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay updated this revision to Diff 265885. MyDeveloperDay added a comment. switch function to unsigned CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79773/new/ https://reviews.llvm.org/D79773 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D80472: [clangd] Add access specifier information to hover contents

kadircet added a comment. thanks for taking a look at this, this looks great! mostly nits, but the one in tests is important and annoying (it might require you to update some existing cases) Comment at: clang-tools-extra/clangd/Hover.cpp:680 +StringRef

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mati865 added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

mstorsjo added inline comments. Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:967 CMAKE_EXE_LINKER_FLAGS CMAKE_SHARED_LINKER_FLAGS) - elseif(LINKER_IS_LLD_LINK) + elseif(LINKER_IS_LLD_LINK AND NOT MINGW)

Re: Bug in QualTypeNames.cpp and adding an option to prepend "::" to fully qualified names.

Hi, should we submit this CL, adding the option to prepend classes and struct fully qualified names with "::"? This can then allow people to slowly switch to the new function, and I can close my fix/close my bug in CLIF. I can do more on this CL if it is needed, but I would like to be sure this

[PATCH] D80425: Fix LLVM/Clang builds with mingw toolchain

thieta added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80425/new/ https://reviews.llvm.org/D80425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80239: [libTooling] In Transformer, allow atomic changes to span multiple files.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/Transformer.cpp:65 - for (const auto : Case.AddedIncludes) { -auto = I.first; -switch (I.second) { -

[clang] 2e43bab - [docs] Fix warnings in ConstantInterpreter

Author: Jinsong Ji Date: 2020-05-23T19:36:05Z New Revision: 2e43bab1c161a97df4883def3c4c4a8b92883377 URL: https://github.com/llvm/llvm-project/commit/2e43bab1c161a97df4883def3c4c4a8b92883377 DIFF: https://github.com/llvm/llvm-project/commit/2e43bab1c161a97df4883def3c4c4a8b92883377.diff LOG:

[PATCH] D76801: [AST] Print a> without extra spaces in C++11 or later.

dyung added a comment. Hi, we noticed an issue with the GDB test suite that was bisected back to this change and I have put the details in PR46052. Can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76801/new/

[PATCH] D80289: [Driver][X86] Support branch align options with LTO

MaskRay added a comment. In D80289#2051947 , @skan wrote: > Ping. `https://reviews.llvm.org/D80168#2046093` "Unless something is urgent, the usual practice is to ping after a week rather than 24 hours, as many people have big piles on their review

[PATCH] D80461: HIP: Try to deal with more llvm package layouts

arsenm closed this revision. arsenm added a comment. 1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80461/new/ https://reviews.llvm.org/D80461

[clang] 1d96dca - HIP: Try to deal with more llvm package layouts

Author: Matt Arsenault Date: 2020-05-23T13:28:24-04:00 New Revision: 1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 URL: https://github.com/llvm/llvm-project/commit/1d96dca9491e3d75c11c3cd1acff5fcda8c2f613 DIFF:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 265875. BRevzin added a comment. - Adding missing return. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files: clang/include/clang/AST/StmtIterator.h

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin updated this revision to Diff 265874. BRevzin added a comment. Herald added a subscriber: martong. - A few more changes from tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78938/new/ https://reviews.llvm.org/D78938 Files:

[PATCH] D78938: Fixing all comparisons for C++20 compilation.

BRevzin marked 2 inline comments as done. BRevzin added a comment. I hadn't build the tests before, updated with a few more changes. Some of the tests require `u8` literals, whose type changes in C++20. I had no idea what to do with that, so I just `#ifdef`-ed out those tests with the

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:8880 + } +} + rjmccall wrote: > tambre wrote: > > rjmccall wrote: > > > Hmm. I'm concerned about not doing any sort of semantic compatibility > > > check here before we assign the

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265871. tambre marked 6 inline comments as done. tambre added a comment. Weakened noexcept checking. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77491/new/ https://reviews.llvm.org/D77491 Files:

[PATCH] D69585: Add option to instantiate templates already in the PCH

rnk added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +CmdArgs.push_back("-fpch-instantiate-templates");

[PATCH] D77491: [Sema] Introduce BuiltinAttr, per-declaration builtin-ness

tambre updated this revision to Diff 265872. tambre marked 4 inline comments as done. tambre added a comment. Remove memcpy overload tests from warn-fortify-source.c, which relied on identifier-based builtin identification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69585: Add option to instantiate templates already in the PCH

llunak marked an inline comment as done. llunak added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5610 + if (Args.hasFlag(options::OPT_fpch_instantiate_templates, + options::OPT_fno_pch_instantiate_templates, false)) +

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. danielmartin edited the summary of this revision. For https://github.com/clangd/clangd/issues/382 This commit adds access

<    1   2   3   >