[PATCH] D80805: [KernelAddressSanitizer] Make globals constructors compatible with kernel

2020-06-05 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 268796. melver added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update IR test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80805/new/ https://reviews.llvm.org/D80805

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm updated this revision to Diff 268795. paulwalker-arm added a comment. Stop SveEmitter adding a _t suffix to the scalar boolean type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81252/new/ https://reviews.llvm.org/D81252 Files:

[clang] 28c2bdf - [AST] Record SourceLocation for TypoExpr.

2020-06-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-06-05T17:03:32+02:00 New Revision: 28c2bdf18f508460401ba1d6958de87b27d52618 URL: https://github.com/llvm/llvm-project/commit/28c2bdf18f508460401ba1d6958de87b27d52618 DIFF: https://github.com/llvm/llvm-project/commit/28c2bdf18f508460401ba1d6958de87b27d52618.diff

[clang] ecd682b - [ARM] Add __bf16 as new Bfloat16 C Type

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T10:32:43+01:00 New Revision: ecd682bbf5e69e8690b7e3634258f05ae0a70448 URL: https://github.com/llvm/llvm-project/commit/ecd682bbf5e69e8690b7e3634258f05ae0a70448 DIFF: https://github.com/llvm/llvm-project/commit/ecd682bbf5e69e8690b7e3634258f05ae0a70448.diff

[clang] a30b5c5 - Fix MSVC "not all control paths return a value" warning. NFC.

2020-06-05 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2020-06-05T10:45:59+01:00 New Revision: a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08 URL: https://github.com/llvm/llvm-project/commit/a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08 DIFF: https://github.com/llvm/llvm-project/commit/a30b5c5a51f95dc81fdfbeea42cc01b451cd5a08.diff

[clang] c31d213 - [clang][test] Put output into temp directory

2020-06-05 Thread Kadir Cetinkaya via cfe-commits
Author: Kadir Cetinkaya Date: 2020-06-05T13:02:32+02:00 New Revision: c31d2134639bb87d6705fe8fb1a46de61bc4cebf URL: https://github.com/llvm/llvm-project/commit/c31d2134639bb87d6705fe8fb1a46de61bc4cebf DIFF:

[clang-tools-extra] a7534dc - [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

2020-06-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2020-06-05T10:32:07+02:00 New Revision: a7534dc8198f2ff966f55fd9a68d2c444886f2b2 URL: https://github.com/llvm/llvm-project/commit/a7534dc8198f2ff966f55fd9a68d2c444886f2b2 DIFF: https://github.com/llvm/llvm-project/commit/a7534dc8198f2ff966f55fd9a68d2c444886f2b2.diff

[PATCH] D81242: [StackSafety] Run ThinLTO

2020-06-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya, inglorion. Herald added projects: clang, LLVM. ThinLTO linking runs dataflow processing on collected function parameters. Then

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268701. balazske added a comment. Removed bad empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Balázs Kéri via Phabricator via cfe-commits
balazske updated this revision to Diff 268696. balazske added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https://reviews.llvm.org/D80699 Files: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp

[clang] 767516c - Fix gcc5 build of ASTMatchersTest.h

2020-06-05 Thread Hans Wennborg via cfe-commits
Author: Hans Wennborg Date: 2020-06-05T10:38:03+02:00 New Revision: 767516c5463a58f64cc3e0e1125b761aedceecf5 URL: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5 DIFF: https://github.com/llvm/llvm-project/commit/767516c5463a58f64cc3e0e1125b761aedceecf5.diff

[PATCH] D81244: [StackSafety] Control paramer access summary from frontend

2020-06-05 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka created this revision. vitalybuka added reviewers: eugenis, pcc. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added projects: clang, LLVM. MAYBE? let me know if you think we need it. I'll improve the patch. This way we don't need to

[PATCH] D81066: [clangd] Populate the parse options to CodeCompletion/SignatureHelp.

2020-06-05 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa7534dc8198f: [clangd] Populate the parse options to CodeCompletion/SignatureHelp. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D81066?vs=268164=268707#toc Repository: rG

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGecd682bbf5e6: [ARM] Add __bf16 as new Bfloat16 C Type (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/

[clang] 1e44731 - [ARM] Add poly64_t on AArch32.

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T13:04:21+01:00 New Revision: 1e447318339a6e740819ec1568002f4751527efe URL: https://github.com/llvm/llvm-project/commit/1e447318339a6e740819ec1568002f4751527efe DIFF: https://github.com/llvm/llvm-project/commit/1e447318339a6e740819ec1568002f4751527efe.diff

[PATCH] D81255: [clang-format] treat 'lock' as a keyword for C# code

2020-06-05 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir accepted this revision. This revision is now accepted and ready to land. This will put a space in `lock (process)`

[PATCH] D81254: [analyzer] Produce symbolic values for C-array elements

2020-06-05 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov created this revision. ASDenysPetrov added reviewers: dcoughlin, NoQ, alexfh. ASDenysPetrov added a project: clang. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Problem:

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81252/new/ https://reviews.llvm.org/D81252

[PATCH] D79587: [CodeGen][SVE] Legalisation of extends with scalable types

2020-06-05 Thread Kerry McLaughlin via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG89fc0166f532: [CodeGen][SVE] Legalisation of extends with scalable types (authored by kmclaughlin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79587/new/

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 268737. DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. Fix spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/ https://reviews.llvm.org/D80301 Files:

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added inline comments. Comment at: llvm/lib/Support/YAMLTraits.cpp:894 + std::string ) { + Val.clear(); + size_t CurrentPos = 0; njames93 wrote: > If you want to do the same here... > ``` > SmallVector

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-05 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin updated this revision to Diff 268736. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Rewrite input string split too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80301/new/

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 268746. dang marked 3 inline comments as done. dang added a comment. Address some code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files:

[PATCH] D81252: [SVE ACLE] Remove redundant bool_t typedef.

2020-06-05 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm created this revision. Herald added subscribers: cfe-commits, tschuett. Herald added a project: clang. paulwalker-arm added a reviewer: sdesmalen. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81252 Files: clang/utils/TableGen/SveEmitter.cpp Index:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-05 Thread Daniel Grumberg via Phabricator via cfe-commits
dang marked 4 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:248 + /// \returns - True if parsing was successful, false otherwise + bool parseSimpleArgs(const llvm::opt::ArgList , +

[PATCH] D79711: [ARM] Add poly64_t on AArch32.

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1e447318339a: [ARM] Add poly64_t on AArch32. (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79711/new/ https://reviews.llvm.org/D79711

[PATCH] D81173: [clangd] Change ParseInputs to store FSProvider rather than VFS

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. Hmm, having looked at this it is a bit of a mess, but I think partly because we're not converting *enough* code to use this abstraction (e.g. the preamble caching stuff, or prepareCompilerInstance). We should work how how to get the bugfix part of this landed, but I

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please wait a bit in case @njames93 has any final thoughts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fcf5ca033a: [clang][BFloat] add NEON emitter for bfloat (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79708/new/

[PATCH] D75844: [clang] Set begin loc on GNU attribute parsed attrs

2020-06-05 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. I'm looking at this again and I am not sure how it is meant to work. For example in `Parser::parseClassSpecifier` in `ParseDeclCXX.cpp`. Here `attrs` is a local variable of type `ParsedAttributesWithRange`, already before my patch. `attrs` is then passed to 1.

[PATCH] D79710: [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-05 Thread Ties Stuij via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8b137a430636: [clang][BFloat] Add create/set/get/dup intrinsics (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79710/new/

[clang] 8b137a4 - [clang][BFloat] Add create/set/get/dup intrinsics

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T14:35:10+01:00 New Revision: 8b137a430636c6626fcc6ef93b05eb69d6183e57 URL: https://github.com/llvm/llvm-project/commit/8b137a430636c6626fcc6ef93b05eb69d6183e57 DIFF: https://github.com/llvm/llvm-project/commit/8b137a430636c6626fcc6ef93b05eb69d6183e57.diff

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-05 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a reviewer: NoQ. Szelethus added a subscriber: NoQ. Szelethus added a comment. @NoQ @baloghadamsoftware Escapes are more within your realm of expertise. Anything to add? From my end, this looks okay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59520: [WebAssembly] Address review comments on r352930

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59520/new/ https://reviews.llvm.org/D59520

[clang] a6fcf5c - [clang][BFloat] add NEON emitter for bfloat

2020-06-05 Thread Ties Stuij via cfe-commits
Author: Ties Stuij Date: 2020-06-05T14:11:51+01:00 New Revision: a6fcf5ca033a83b815f760664e0cff91c2c13dcd URL: https://github.com/llvm/llvm-project/commit/a6fcf5ca033a83b815f760664e0cff91c2c13dcd DIFF: https://github.com/llvm/llvm-project/commit/a6fcf5ca033a83b815f760664e0cff91c2c13dcd.diff

[PATCH] D80961: WIP: Ignore template instantiations if not in AsIs mode

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D80961#2073049 , @klimek wrote: > Without jumping into the discussion whether it should be the default, I think > we should be able to control template instantiation visitation separately > from other implicit nodes. >

[clang] 23291b9 - Return "[InstCombine] Simplify compare of Phi with constant inputs against a constant"

2020-06-05 Thread Max Kazantsev via cfe-commits
Author: Max Kazantsev Date: 2020-06-05T20:48:29+07:00 New Revision: 23291b9863c8af7ad348c4a7d85d8d784df88eb1 URL: https://github.com/llvm/llvm-project/commit/23291b9863c8af7ad348c4a7d85d8d784df88eb1 DIFF: https://github.com/llvm/llvm-project/commit/23291b9863c8af7ad348c4a7d85d8d784df88eb1.diff

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-05 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 268780. adamcz marked 11 inline comments as done. adamcz added a comment. addressed review comments, some UI questions remain open for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81169/new/

[PATCH] D81169: [clangd] Improve hover on arguments to function call

2020-06-05 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:525 + if (const auto *Var = dyn_cast(D)) { +// Check if we are inside CallExpr kadircet wrote: > umm, is this a fixme or a leftover? I suppose it is from a previous version > of

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-05 Thread Rodrigo Caetano Rocha via Phabricator via cfe-commits
rcorcs added a comment. If reviewers think that this patch is touching in too many files, I could try to focus it only on the LTO related files, converting OptimizationLevel back to two separate values when necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall added a comment. So this is late in the game but... maybe we should just not report this case as a reference? `#undef foo` is valid if `foo` was never defined, and doesn't refer to anything. If we similarly don't resolve the reference in this case as we only import macros that were

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman created this revision. dgoldman added reviewers: sammccall, yvvan. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Exempt ObjC from arrow/dot fixits since this has

[PATCH] D77708: [lit] Improve naming of test result categories

2020-06-05 Thread Julian Lettner via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG99d6e05e7144: [lit] Improve naming of test result categories (authored by yln). Herald added subscribers: cfe-commits, msifontes, jurahul, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer,

[PATCH] D81163: [AST][RecoveryExpr] Preserve the AST for invalid conditions.

2020-06-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81163/new/ https://reviews.llvm.org/D81163

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Zinovy Nis via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc063b4a72bb3: Fix crash on misc-redundant-expression (authored by zinovy.nis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/

[PATCH] D81176: [HIP] Add default header and include path

2020-06-05 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/ROCm.h:68 + + // CUDA architectures for which we have raised an error in + // CheckRocmVersionSupportsArch. tra wrote: > CUDA -> GPU? > Looks like

[PATCH] D81223: Size LTO (1/3): Standardizing the use of OptimizationLevel

2020-06-05 Thread Rodrigo Caetano Rocha via Phabricator via cfe-commits
rcorcs added a comment. LLVM already has the class PassBuilder::OptimizationLevel that encapsulates the logic of both speed and size optimization levels. This class already checks which values for SpeedLevel and SizeLevel are valid. However, other parts of the code define two separate

[clang] 99d6e05 - [lit] Improve naming of test result categories

2020-06-05 Thread Julian Lettner via cfe-commits
Author: Julian Lettner Date: 2020-06-05T08:14:42-07:00 New Revision: 99d6e05e7144a2638c4e85ea75099e9dc6432cde URL: https://github.com/llvm/llvm-project/commit/99d6e05e7144a2638c4e85ea75099e9dc6432cde DIFF:

[PATCH] D81008: [AST] Record SourceLocation for TypoExpr.

2020-06-05 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG28c2bdf18f50: [AST] Record SourceLocation for TypoExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81008/new/

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 added a comment. I decided to do some more stringent benchmarking, just focusing on the matching, not the boilerplate of running clang-tidy. =BeforePatch=== Matcher Timings: 116.0756 user 29.1397 system 145.2154

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 268803. dgoldman added a comment. - Fix test run line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files: clang/test/CodeCompletion/objc-member-access.m Index:

[PATCH] D80896: [clang-tidy][misc-redundant-expression] Support for CXXFoldExpr

2020-06-05 Thread Nathan James via Phabricator via cfe-commits
njames93 accepted this revision. njames93 added a comment. LGTM, nothing else to add. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80896/new/ https://reviews.llvm.org/D80896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

2020-06-05 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Generally looks good to me, but I had a question about test coverage. Comment at: clang-tools-extra/test/clang-tidy/infrastructure/run-clang-tidy_config-file.cpp:1 -// RUN: %run_clang_tidy --help // RUN: rm -rf %t Is there a

[clang-tools-extra] c063b4a - Fix crash on misc-redundant-expression

2020-06-05 Thread Zinovy Nis via cfe-commits
Author: Zinovy Nis Date: 2020-06-05T18:43:57+03:00 New Revision: c063b4a72bb39d9ae4bd13851873ddcbc16f6804 URL: https://github.com/llvm/llvm-project/commit/c063b4a72bb39d9ae4bd13851873ddcbc16f6804 DIFF: https://github.com/llvm/llvm-project/commit/c063b4a72bb39d9ae4bd13851873ddcbc16f6804.diff

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane marked an inline comment as done. erichkeane added a comment. In D80743#2074537 , @rsmith wrote: > In D80743#2074121 , @erichkeane > wrote: > > > @rsmith I think this implements what you've suggested? >

[PATCH] D80743: (PR46111) Properly handle elaborated types in an implicit deduction guide

2020-06-05 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 268822. erichkeane retitled this revision from "(PR46111) Desugar Elaborated types in Deduction Guides." to "(PR46111) Properly handle elaborated types in an implicit deduction guide". erichkeane edited the summary of this revision. CHANGES SINCE LAST

[PATCH] D81263: [Sema][CodeComplete][ObjC] Don't include arrow/dot fixits

2020-06-05 Thread David Goldman via Phabricator via cfe-commits
dgoldman updated this revision to Diff 268818. dgoldman added a comment. - Fix broken diff base (due to lint fixes maybe?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81263/new/ https://reviews.llvm.org/D81263 Files:

<    1   2