[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:65 +#endif #ifndef ALIAS #define ALIAS(X,Y,Z) It is slightly unfortunate to have to use both `UNARY_EXPR_OR_TYPE_TRAIT` and `CXX

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

sammccall marked 6 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:738 + vlog("Dropped diagnostic: {0}: {1}", LastDiag->File, LastDiag->Message); +LastDiag.reset(); + }); hokein wrote: > sha

[PATCH] D81455: [clang][NFC] Generate the {Type,ArrayType,UnaryExprOrType,Expression}Traits enumerations from TokenKinds.def...

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added subscribers: sstefan1, mgorny. Herald added a reviewer: jdoerfert. riccibruno marked an inline comment as done. riccibruno added inline comments. riccibruno marked 2 inline

[clang] 658af94 - [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

Author: Sam McCall Date: 2020-06-09T12:47:27+02:00 New Revision: 658af9435071d5da017c1d65298bdea19ec095e1 URL: https://github.com/llvm/llvm-project/commit/658af9435071d5da017c1d65298bdea19ec095e1 DIFF: https://github.com/llvm/llvm-project/commit/658af9435071d5da017c1d65298bdea19ec095e1.diff LO

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269473. dang marked 3 inline comments as done. dang added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/clang/Basic/Module.h

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rG29353e69d25c: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation (authored by AbbasSabra, committed by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

This revision was automatically updated to reflect the committed changes. baloghadamsoftware marked an inline comment as done. Closed by commit rG813734dad7e8: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent` (authored by baloghadamsoftware). Changed prior to commit: https://r

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG98db1f990fc2: [Analyzer] [NFC] Parameter Regions (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80522?vs=268131&id=269477#toc Repository: rG LLVM Github Monorepo

[PATCH] D80286: [Analyzer] Allow creation of stack frame for functions without definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG5419a3121522: [Analyzer] Allow creation of stack frame for functions without definition (authored by baloghadamsoftware). Changed prior to commit: https://reviews.llvm.org/D80286?vs=266036&id=269478#toc

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269468. dang marked an inline comment as done. dang added a comment. Address @aprantl's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/cla

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269471. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Don't split the snippet omitting logic between the builder and its caller. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81380/new/

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

vsavchenko added a comment. Done, sorry for taking so long! Thank you for your work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing lis

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269466. pratlucas added a comment. Formatting patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75169/new/ https://reviews.llvm.org/D75169 Files: llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/Co

[PATCH] D81444: Make the diagnostic-missing-prototypes put the suggested `static` in front of `const` if exists.

gribozavr2 added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14252 + FD->getReturnType().isConstQualified()) +return FD->getReturnTypeSourceRange().getBegin().getLocWithOffset( +/*strlen("const ")=*/-6); Could

[PATCH] D81452: [AST] RecoveryAST options should only be enabled for C++ only.

sammccall added a comment. Hmm - why? I thought the idea with the explicit `-frecovery-ast` flag was that we could turn it on even when it's not stable. Isn't the idea that one day it will be stable for C, but not yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1715 +CCContextKind, Opts, !IsUsingDeclaration, +NextTokenKind); else sammccall wrote: > now you've got the "should we gen

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269464. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address most comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81380/new/ https://reviews.llvm.org/D81380 Files: clang-tool

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

fhahn added a comment. In D72778#2080928 , @rjmccall wrote: > Yeah, that's fine. Thank you very much John! I filed https://bugs.llvm.org/show_bug.cgi?id=46251 to keep track of the initializer support, with a note on enabling the commented out test. R

[clang] 813734d - [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

Author: Adam Balogh Date: 2020-06-09T12:08:56+02:00 New Revision: 813734dad7e8b526c39806d1a88820b1f0706fb1 URL: https://github.com/llvm/llvm-project/commit/813734dad7e8b526c39806d1a88820b1f0706fb1 DIFF: https://github.com/llvm/llvm-project/commit/813734dad7e8b526c39806d1a88820b1f0706fb1.diff L

[clang] 98db1f9 - [Analyzer] [NFC] Parameter Regions

Author: Adam Balogh Date: 2020-06-09T12:08:56+02:00 New Revision: 98db1f990fc273adc1ae36d4ce97ce66fd27ac30 URL: https://github.com/llvm/llvm-project/commit/98db1f990fc273adc1ae36d4ce97ce66fd27ac30 DIFF: https://github.com/llvm/llvm-project/commit/98db1f990fc273adc1ae36d4ce97ce66fd27ac30.diff L

[clang] 5419a31 - [Analyzer] Allow creation of stack frame for functions without definition

Author: Adam Balogh Date: 2020-06-09T12:08:57+02:00 New Revision: 5419a3121522fe1251d52c7f1fb790d68581e549 URL: https://github.com/llvm/llvm-project/commit/5419a3121522fe1251d52c7f1fb790d68581e549 DIFF: https://github.com/llvm/llvm-project/commit/5419a3121522fe1251d52c7f1fb790d68581e549.diff L

[clang] 29353e6 - [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

Author: Abbas Sabra Date: 2020-06-09T12:55:54+03:00 New Revision: 29353e69d25c0f13cd2704ce2269af464d0751a8 URL: https://github.com/llvm/llvm-project/commit/29353e69d25c0f13cd2704ce2269af464d0751a8 DIFF: https://github.com/llvm/llvm-project/commit/29353e69d25c0f13cd2704ce2269af464d0751a8.diff L

[PATCH] D81394: [clang-format] Brace breaking for C# lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rG7117066bd618: [clang-format] Brace breaking for C# lambdas (authored by Jonathan Coe ). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81394

[PATCH] D72778: [Matrix] Add __builtin_matrix_transpose to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3323a628ec82: [Matrix] Add __builtin_matrix_transpose to Clang. (authored by fhahn). Changed prior to commit: https://reviews.llvm.org/D72778?vs=269050&id=269463#toc Repository: rG LLVM Github Monore

[PATCH] D80941: [PowerPC][Power10] Implement Count Leading/Trailing Zeroes Builtins under bit Mask in LLVM/Clang

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. Thanks Amy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80941/new/ https://reviews.llvm.org/D80941 __

[PATCH] D80421: [Mips] use correct ld.so for musl soft float

joewholden added a comment. This is actually wrong anyway Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80421/new/ https://reviews.llvm.org/D80421 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D81452: [AST] RecoveryAST options should only be enabled for C++ only.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The flag should be off for non-c++ files even there is a "-frecovery-ast" in the commandline. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81452 Files: clang/lib/Frontend/Compi

[PATCH] D75169: [ARM] Supporting lowering of half-precision FP arguments and returns in AArch32's backend

pratlucas updated this revision to Diff 269450. pratlucas added a comment. Splitting the patch into two parts: one for introducing the half-precision handling into AArch32's backend and one for removing the existing coercion of those arguments from Clang. Repository: rG LLVM Github Monorepo C

[PATCH] D81428: [ARM] Moving CMSE handling of half arguments and return to the backend

pratlucas updated this revision to Diff 269452. pratlucas added a comment. Moving the clean-up of the Clang-side handling to a separate patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81428/new/ https://reviews.llvm.org/D81428 Files: llvm/l

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall accepted this revision. sammccall marked 2 inline comments as done. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1283 + Recorder->CCSema->getSourceManager(), Recorder->CC

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas created this revision. Herald added subscribers: cfe-commits, danielkiss, dmgreen, kristof.beyls. Herald added a project: clang. pratlucas added a parent revision: D81428: [ARM] Moving CMSE handling of half arguments and return to the backend. pratlucas added reviewers: rjmccall, chill,

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

sammccall added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1712 +SemaCCS, QueryScopes, *Inserter, FileName, CCContextKind, Opts, +/*GenerateSnippets=*/!IsUsingDeclaration && !HasParenthesisAfter); else sa

[clang] 7117066 - [clang-format] Brace breaking for C# lambdas

Author: Jonathan Coe Date: 2020-06-09T10:20:01+01:00 New Revision: 7117066bd6182f53ec9f97d2e5e81de27c2e0db0 URL: https://github.com/llvm/llvm-project/commit/7117066bd6182f53ec9f97d2e5e81de27c2e0db0 DIFF: https://github.com/llvm/llvm-project/commit/7117066bd6182f53ec9f97d2e5e81de27c2e0db0.diff

[clang] 3323a62 - [Matrix] Add __builtin_matrix_transpose to Clang.

Author: Florian Hahn Date: 2020-06-09T10:14:37+01:00 New Revision: 3323a628ec821b8b75d3b60bf1510931f97d3883 URL: https://github.com/llvm/llvm-project/commit/3323a628ec821b8b75d3b60bf1510931f97d3883 DIFF: https://github.com/llvm/llvm-project/commit/3323a628ec821b8b75d3b60bf1510931f97d3883.diff

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 269439. gamesh411 added a comment. Extend index file format Update documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://reviews.llvm.org/D75665 Files: clang/docs/analyzer/user-doc

[PATCH] D79912: Assignment and Inc/Dec operators wouldn't register as a mutation when Implicit Paren Casts were present

njames93 added a comment. In D79912#2081402 , @Tridacnid wrote: > Awesome. I don't have commit access, https://llvm.org/docs/Phabricator.html > says I just need to ask here and someone will pick it up. Let me know if > there's anything else I need to do.

[PATCH] D81061: [Analyzer][VLASizeChecker] Fix problem with zero index assumption.

balazske marked 2 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VLASizeChecker.cpp:130-131 +// At least check for zero again. +// Assume that this is a more exact fact than the previous assumptions +

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

martong added a comment. In D72705#2041779 , @balazske wrote: > I can make comparisons if more functions are added to the checker, `fputs` > only is not sufficient. Yes, you cannot measure just with fputs, similar thing happened to me with StdCLibraryF

[PATCH] D81351: [clangd] Parse std::make_unique, and emit template diagnostics at expansion.

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:692 +LastDiagWasOriginalError = +Info.getDiags()->getDiagnosticIDs()->isDefaultMappingAsError( +

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1283 + Recorder->CCSema->getSourceManager(), Recorder->CCSema->LangOpts); + HasParenthesisAfter = NextToken->getKind() == tok::l_paren; auto Style = getFormatStyleForFile(Se

[PATCH] D81380: [clangd] Don't produce snippets when completion location is followed by parenthesis

kbobyrev updated this revision to Diff 269430. kbobyrev marked 9 inline comments as done. kbobyrev added a comment. Make sure snippets are omitted only in the function/method/constructor calls for safety and extend the testset. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D80669: [analyzer] LoopWidening: fix crash by avoiding aliased references invalidation

AbbasSabra added a comment. Gentle reminder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80669/new/ https://reviews.llvm.org/D80669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:209 +/// qualified-id: +/// nested-name-specifier template_opt unqualified-id +class IdExpression final : public Expression { Please add a TODO for the accessor for the 'te

[PATCH] D81390: [KernelAddressSanitizer] Make globals constructors compatible with kernel [v2]

melver added a comment. In D81390#2081067 , @nathanchance wrote: > I do not know enough about KASAN enough to review this patch but I can say > that against mainline at > https://git.kernel.org/linus/af7b4801030c07637840191c69eb666917e4135d, there > ap

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269422. eduucaldas edited the summary of this revision. eduucaldas added a comment. Answering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files:

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas updated this revision to Diff 269423. eduucaldas added a comment. nswering simple comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81168/new/ https://reviews.llvm.org/D81168 Files: clang/include/clang/Tooling/Syntax/Nodes.h cl

[PATCH] D81168: Add support for DeclRefExpr in SyntaxTree, by generating IdExpressions

eduucaldas marked 6 inline comments as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:618 + Builder.foldNode(Builder.getRange(it.getLocalSourceRange()), NS, nullptr); + Builder.markChild(NS, syntax::NodeRole::Unknown); +}

<    1   2   3