[PATCH] D81041: Use existing path sep style in clang::FileManager::FixupRelativePath

amccarth added a comment. In D81041#2072396 , @ctetreau wrote: > After some further investigation, I have come to believe that the root cause > of the issue I am seeing is on line 783 of clang/lib/Lex/HeaderSearch.cpp. A > path is constructed using

[PATCH] D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

amyk created this revision. amyk added reviewers: nemanjai, saghir, power-llvm-team, PowerPC, hfinkel. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements builtins for the following prototypes for the VSX Permute Control Vector Generate

[PATCH] D81713: [HIP] Fix rocm not found on rocm3.5

tra added a comment. In D81713#2090309 , @arsenm wrote: > > I can tell that it does not. We're still looking under `/opt/rocm` by > > default. I've ran into it trying to get comgr working with the recent LLVM > > which prompted my comment on Github > >

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. Good to go if @arsenm is OK with fixing -fgpu-rdc in a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel updated this revision to Diff 270482. jtmott-intel added a comment. - Removed sign/unsign select. - Added test and support for placeholder types in builtins. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/ https://reviews.llvm.org/D81420 Files:

[PATCH] D81757: [WebAssembly] Add intrinsic for i64x2.mul

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. This instruction was implemented in 3181273be7

[PATCH] D81420: Fix size for _ExtInt types with builtins

jtmott-intel marked an inline comment as done. jtmott-intel added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:327 return true; TheCall->setArg(2, Arg.get()); } rjmccall wrote: > jtmott-intel wrote: > > rjmccall wrote: > > > I know

[PATCH] D81420: Fix size for _ExtInt types with builtins

rjmccall accepted this revision. rjmccall added a comment. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81420/new/ https://reviews.llvm.org/D81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar created this revision. jaafar added reviewers: aaron.ballman, alexfh, hokein. jaafar added a project: clang-tools-extra. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the process of running this check on a large codebase

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen marked 4 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7821 + Context.getTypeSizeInChars(ElementType).getQuantity(); +} else if (VAT) { + ElementType =

[PATCH] D81772: Reduce -Wregister from DefaultError to a default-on warning.

jyknight created this revision. jyknight added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There is a lot of C++ code in the wild still using 'register', which will become broken if we switch the default compilation mode to C++17. A default-on

[PATCH] D81771: [CUDA,HIP] Use VFS for SDK detection.

tra created this revision. tra added reviewers: yaxunl, arsenm. Herald added subscribers: kerbowa, sanjoy.google, bixia, nhaehnle, wdng, jvesely. Herald added a project: clang. tra updated this revision to Diff 270533. tra edited the summary of this revision. tra added a comment. Replaced

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

amccarth accepted this revision. amccarth added a comment. My only real concern was about the possible reproducibility impact of introducing absolute paths into the binaries. If @thakis and @hans are satisfied this is OK, then LGTM. Comment at:

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw added inline comments. Comment at: clang/lib/Lex/PPExpressions.cpp:262 + // string to UndefPrefixes as an explicit "-Wundef" does. + if (UndefPrefixes.empty() || + llvm::any_of(UndefPrefixes, arphaman wrote: > zixuw wrote: >

[PATCH] D81771: [CUDA,HIP] Use VFS for SDK detection.

tra updated this revision to Diff 270533. tra edited the summary of this revision. tra added a comment. Replaced another use of D.getVFS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81771/new/ https://reviews.llvm.org/D81771 Files:

[PATCH] D81721: [SVE] Ensure proper mangling of ACLE tuple types

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81721/new/ https://reviews.llvm.org/D81721

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:43 #include "clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h" +#include "clang/StaticAnalyzer/Frontend/CheckerRegistry.h" #include

[PATCH] D81752: Revert "[analyzer][NFC] Don't allow dependency checkers to emit diagnostics"

Szelethus accepted this revision. Szelethus added a comment. Yup, I agree. Detailed my answer here a bit: D78126#inline-751477 . Thanks for taking initiative! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

LegalizeAdulthood added a comment. Yeah, the restriction to the header file is a bug. It was a misconception on my part when I originally wrote the matcher. See https://bugs.llvm.org/show_bug.cgi?id=26332 which should also be fixed by the change here. I had attempted to make progress on

[clang] d2c394e - [WebAssembly] Add intrinsic for i64x2.mul

Author: Thomas Lively Date: 2020-06-12T14:08:18-07:00 New Revision: d2c394e74fc5eb33581b58f238a745d7dd18f219 URL: https://github.com/llvm/llvm-project/commit/d2c394e74fc5eb33581b58f238a745d7dd18f219 DIFF: https://github.com/llvm/llvm-project/commit/d2c394e74fc5eb33581b58f238a745d7dd18f219.diff

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval updated this revision to Diff 270481. clementval added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Keep same ordering than OMPKinds.def + add dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f8d87ce - [CMake] Use 'ssh.py' executor to run the remote library tests.

Author: Vladimir Vereschaka Date: 2020-06-12T12:31:59-07:00 New Revision: f8d87ce9ca23a696dbcc52b4b3458272a2ba8091 URL: https://github.com/llvm/llvm-project/commit/f8d87ce9ca23a696dbcc52b4b3458272a2ba8091 DIFF:

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

jkorous added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { aaron.ballman wrote: > njames93 wrote: > > jkorous wrote: > >

[PATCH] D81757: [WebAssembly] Add intrinsic for i64x2.mul

This revision was automatically updated to reflect the committed changes. Closed by commit rGd2c394e74fc5: [WebAssembly] Add intrinsic for i64x2.mul (authored by tlively). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81757/new/

[PATCH] D81769: Repair various issues with modernize-avoid-bind

jaafar marked 3 inline comments as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:38 enum BindArgumentKind { BK_Temporary, BK_Placeholder, BK_CallExpr, BK_Other }; -enum CaptureMode { CM_None, CM_ByRef, CM_ByValue,

[PATCH] D81242: [StackSafety] Run ThinLTO

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM with 2 notes Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if

[PATCH] D80961: Ignore template instantiations if not in AsIs mode

steveire updated this revision to Diff 270472. steveire edited the summary of this revision. steveire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80961/new/ https://reviews.llvm.org/D80961 Files:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L updated this revision to Diff 270548. Xiangling_L marked 35 inline comments as done. Xiangling_L edited the summary of this revision. Xiangling_L added a comment. Address another round of reviews; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:639 + if (CXXGlobalInits.empty()) +return; hubert.reinterpretcast wrote: > Can this part be committed in a separate patch? It does not appear to have > dependencies on other

[clang] 6604295 - [WebAssembly] WebAssembly doesn't support "protected" visibility

Author: Dan Gohman Date: 2020-06-12T19:52:35-07:00 New Revision: 66042959590d6db9d2a12803a16476d4e3508f3f URL: https://github.com/llvm/llvm-project/commit/66042959590d6db9d2a12803a16476d4e3508f3f DIFF: https://github.com/llvm/llvm-project/commit/66042959590d6db9d2a12803a16476d4e3508f3f.diff

[PATCH] D81688: [WebAssembly] WebAssembly doesn't support "protected" visibility

sunfish closed this revision. sunfish added a comment. Landed in 66042959590d6db9d2a12803a16476d4e3508f3f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81688/new/

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:277 + llvm::FunctionType::get(CGM.VoidTy, false) && + "atexit has wrong parameter type."); + s/atexit has wrong parameter type/Argument to atexit has a

[clang] c1e47b4 - [StackSafety] Run ThinLTO

Author: Vitaly Buka Date: 2020-06-12T18:11:29-07:00 New Revision: c1e47b47f8848bb4c1ead8c530940d783c1fbf46 URL: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46 DIFF: https://github.com/llvm/llvm-project/commit/c1e47b47f8848bb4c1ead8c530940d783c1fbf46.diff

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3845 + IS_POSITIVE != DEFAULT_VALUE && this->KEYPATH != DEFAULT_VALUE) \ +Args.push_back(StringAllocator(Twine(PREFIX_TYPE[0]) + NAME)); +#include

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka updated this revision to Diff 270553. vitalybuka marked 3 inline comments as done. vitalybuka added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242 Files:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast marked an inline comment as done. hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:700 + +Fn = CreateGlobalInitOrDestructFunction( +FTy, llvm::Twine("__sterm8000_clang_") + GlobalUniqueModuleId, FI,

[PATCH] D81781: Add additional text format functions to Google style.

nseckar created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. nseckar updated this revision to Diff 270559. nseckar added a comment. nseckar added a reviewer: djasper. Add reviewers This adds a few more function names expecting a text proto argument.

[PATCH] D81781: Add additional text format functions to Google style.

nseckar updated this revision to Diff 270559. nseckar added a comment. Add reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81781/new/ https://reviews.llvm.org/D81781 Files: clang/lib/Format/Format.cpp Index:

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:8 +// RUN: FileCheck %s struct test { Xiangling_L wrote: > jasonliu wrote: > > Looks like the non-inline comments are easier to get ignored and missed, so > > I

[PATCH] D81242: [StackSafety] Run ThinLTO

This revision was automatically updated to reflect the committed changes. Closed by commit rGc1e47b47f884: [StackSafety] Run ThinLTO (authored by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81242/new/ https://reviews.llvm.org/D81242

[PATCH] D81242: [StackSafety] Run ThinLTO

vitalybuka added inline comments. Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:618 +ConstantRange Access = Found->sextOrTrunc(Use.Range.getBitWidth()); +if (Access.signedAddMayOverflow(C.Offset) != +ConstantRange::OverflowResult::NeverOverflows)

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:31 +// CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__sinit8000_clang_510e898aa8d263cac999dd03eeed5b51,

[PATCH] D81691: [clangd] Set CWD in semaCodeComplete

sammccall added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81691/new/ https://reviews.llvm.org/D81691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81392: [clang] Rename Decl::isHidden() to isUnconditionallyVisible()

This revision was automatically updated to reflect the committed changes. Closed by commit rG2e92b397ae4b: [clang] Rename Decl::isHidden() to isUnconditionallyVisible(). (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81392/new/

[clang] 3dcfd48 - [CodeGen] Increase applicability of ffine-grained-bitfield-accesses for targets with limited native integer widths

Author: Alex Bradbury Date: 2020-06-12T10:33:47+01:00 New Revision: 3dcfd482cb17fad2d641c976b822d1fe36dc1359 URL: https://github.com/llvm/llvm-project/commit/3dcfd482cb17fad2d641c976b822d1fe36dc1359 DIFF: https://github.com/llvm/llvm-project/commit/3dcfd482cb17fad2d641c976b822d1fe36dc1359.diff

<    1   2