[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones echristo wrote:

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 272237. MaskRay marked 4 inline comments as done. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files:

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Eric Christopher via Phabricator via cfe-commits
echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones MaskRay wrote:

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments then looks good to go. Thank you so much for your effort here. -eric Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict

[PATCH] D80977: Diagnose cases where the name of a class member is used within a class definition before the member name is declared.

2020-06-19 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. (Partial review; I'll continue reviewing later.) Comment at: clang/lib/Sema/SemaDecl.cpp:1543 +// in class 'C', where we look up 'f' to determine if we're declaring a +// constructor. + } else if (D->isInIdentifierNamespace(Lookup.FirstIDNS))

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked 2 inline comments as done. yaxunl added a comment. In D78655#2019290 , @rsmith wrote: > There are two behaviors that seem to make sense: > > - Treat lambdas as implicitly HD (like constexpr functions) in all CUDA / HIP > language modes. I

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 272225. yaxunl marked 4 inline comments as done. yaxunl added a comment. improve diagnostic message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

2020-06-19 Thread Michael Liao via Phabricator via cfe-commits
hliao added a comment. PING Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-19 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. Is the fallback not working correctly in this case for some reason? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82249/new/ https://reviews.llvm.org/D82249 ___ cfe-commits

[clang] d5f9c4a - [ODRHash] Remove use of 'whitelist'.

2020-06-19 Thread via cfe-commits
Author: Weverything Date: 2020-06-19T18:39:30-07:00 New Revision: d5f9c4a3d10d166af1f445d20510705117eb6fea URL: https://github.com/llvm/llvm-project/commit/d5f9c4a3d10d166af1f445d20510705117eb6fea DIFF: https://github.com/llvm/llvm-project/commit/d5f9c4a3d10d166af1f445d20510705117eb6fea.diff

[PATCH] D82223: [clang-tidy] Implement storeOptions for checks missing it.

2020-06-19 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added a comment. Looks OK for me, but Aaron is proper person to approve patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82223/new/ https://reviews.llvm.org/D82223 ___ cfe-commits

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

2020-06-19 Thread Mitch Phillips via Phabricator via cfe-commits
hctim created this revision. hctim added reviewers: pcc, ostannard. Herald added subscribers: llvm-commits, Sanitizers, cfe-commits, kristof.beyls, rovka. Herald added projects: clang, Sanitizers, LLVM. HWASan globals instruction selection lowering hasn't been implemented in GlobalISel or

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

2020-06-19 Thread Wenlei He via Phabricator via cfe-commits
wenlei marked an inline comment as done. wenlei added inline comments. Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:391 +Remark << ore::NV("Caller", ); +if (ProfileGuidedInline) + Remark << " by profile guided inliner"; davidxl wrote: > is this

[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

2020-06-19 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGc310bf8256f8: [Sema] Comparison of pointers to complete and incomplete types (authored by pestctrl, committed by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] c310bf8 - [Sema] Comparison of pointers to complete and incomplete types

2020-06-19 Thread Eli Friedman via cfe-commits
Author: Benson Chu Date: 2020-06-19T17:01:03-07:00 New Revision: c310bf8256f83f365921562cebc5e4c9aec8e87e URL: https://github.com/llvm/llvm-project/commit/c310bf8256f83f365921562cebc5e4c9aec8e87e DIFF: https://github.com/llvm/llvm-project/commit/c310bf8256f83f365921562cebc5e4c9aec8e87e.diff

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 272209. MaskRay marked an inline comment as done. MaskRay added a comment. Fix more words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files:

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

2020-06-19 Thread David Li via Phabricator via cfe-commits
davidxl added a comment. Can you add a test case where there is more than one level of inline contexts for the callsite? Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:391 +Remark << ore::NV("Caller", ); +if (ProfileGuidedInline) + Remark << " by profile guided

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

2020-06-19 Thread Ravi Narayanaswamy via Phabricator via cfe-commits
RaviNarayanaswamy added a comment. How do you plan to support #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) Are you going to split this into 3 updates since your are using the arg fields. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Eric Christopher via Phabricator via cfe-commits
echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:313-316 +.. option:: -mharden-sls= + +Select straight-line speculation hardening scope + Miss merge? Comment at: clang/docs/ClangCommandLineReference.rst:891

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov marked an inline comment as done. ASDenysPetrov added a comment. Thanks for the quick review, guys! Comment at: clang/test/Analysis/exploded-graph-rewriter/l_name_starts_with_l.cpp:25 + +// This test is passed if exploded_graph_rewriter handles dot file without

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov updated this revision to Diff 272204. ASDenysPetrov added a comment. Removed accidentally included unrelated changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82103/new/ https://reviews.llvm.org/D82103 Files: clang/include/clang/Basic/JsonSupport.h

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 272201. MaskRay added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a reviewer: HAPPY. echristo added a comment. You'll want to grab blacklist/whitelist in the comments around as well. We've been talking about having a need for deprecated aliases file for these options - it's probably worth bringing this patch up on cfe-dev and cc'ing

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 272200. MaskRay edited the summary of this revision. MaskRay edited reviewers, added: pcc; removed: HAPPY. MaskRay added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add aliases Repository: rG LLVM Github

[clang-tools-extra] f8a463c - As part of using inclusive language within the llvm project,

2020-06-19 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2020-06-19T15:43:51-07:00 New Revision: f8a463c170964bff7e239bb8268a4927a4547d3c URL: https://github.com/llvm/llvm-project/commit/f8a463c170964bff7e239bb8268a4927a4547d3c DIFF:

[clang-tools-extra] 937c135 - As part of using inclusive language within the llvm project,

2020-06-19 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2020-06-19T15:41:06-07:00 New Revision: 937c135dd57e86ccd3fd64ca7b07915a75157986 URL: https://github.com/llvm/llvm-project/commit/937c135dd57e86ccd3fd64ca7b07915a75157986 DIFF:

[clang-tools-extra] f92011d - As part of using inclusive language within the llvm project,

2020-06-19 Thread Eric Christopher via cfe-commits
Author: Eric Christopher Date: 2020-06-19T15:12:18-07:00 New Revision: f92011d875cfdca1ed97bf0ab6956364c604b578 URL: https://github.com/llvm/llvm-project/commit/f92011d875cfdca1ed97bf0ab6956364c604b578 DIFF:

[PATCH] D71739: [AssumeBundles] Use operand bundles to encode alignment assumptions

2020-06-19 Thread Tyker via Phabricator via cfe-commits
Tyker updated this revision to Diff 272194. Tyker added a comment. sorry for not doing much recently. i split with an NFC patch with only test updates. and addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71739/new/

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst

[PATCH] D80055: Diagnose union tail padding

2020-06-19 Thread JF Bastien via Phabricator via cfe-commits
jfb abandoned this revision. jfb added a comment. I've gotten what I wanted out of this (diagnosed a particular codebase), and am not sure it's worth pursuing further. If anyone is interested, please let me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: echristo, mehdi_amini, morehouse. Herald added subscribers: Sanitizers, cfe-commits, aaron.ballman. Herald added projects: clang, Sanitizers. MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files

[PATCH] D82020: PowerPC-specific builtin constrained FP enablement

2020-06-19 Thread Andrew J Wock via Phabricator via cfe-commits
ajwock updated this revision to Diff 272186. ajwock added a comment. Took steven.zhang's suggestion, added REQUIRES line to diff. Hopefully addressed harbormaster concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82020/new/ https://reviews.llvm.org/D82020 Files:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-19 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:193 + /// \param [out] Args - The generated arguments. Note that the caller is + /// responsible for insersting the path to the clang executable and "-cc1" if + /// desired.

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

2020-06-19 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Yup, `c-index-test` crashing was one of the motivators behind this. I think this should handle all cases. I tried it with `CLANG_LINK_CLANG_DYLIB` on/off combined with shared/static/shared+static libraries and inspected the generated `build.ninja`, which looked

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

2020-06-19 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl updated this revision to Diff 272171. yaxunl retitled this revision from "[HIP] Add -fhip-lambda-host-device" to "[CUDA][HIP] Let non-caputuring lambda be host device". yaxunl edited the summary of this revision. yaxunl added a comment. Revised by Richard's comments. CHANGES SINCE LAST

[PATCH] D82231: [NFC] Remove unused pass name parser classes

2020-06-19 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG2565581e3704: [NFC] Remove unused pass name parser classes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

2020-06-19 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. > Those flaky test failures seems to be due to ld.lld being not built from > source as part of testing compiler-rt/-only patches. That should be something we can fix in the build system. compiler-rt/test/CMakeLists.txt has a list of executables which the tests

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli updated this revision to Diff 272170. fpetrogalli marked 7 inline comments as done. fpetrogalli added a comment. Thank you for the review @sdesmalen! Francesco Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1811 +def int_aarch64_sve_cvt_bf16f32 : Builtin_SVCVT<"svcvt_bf16_f32_m", llvm_nxv8bf16_ty, llvm_nxv8i1_ty, llvm_nxv4f32_ty>; +def int_aarch64_sve_cvtnt_bf16f32 :

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-19 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov marked an inline comment as done. ASDenysPetrov added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGaf4f2eb47636: [clang-tidy] remove duplicate fixes of alias checkers (authored by Daniel599, committed by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82231: [NFC] Remove unused pass name parser classes

2020-06-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82231/new/ https://reviews.llvm.org/D82231 Files: llvm/include/llvm/IR/LegacyPassNameParser.h Index:

[PATCH] D82231: [NFC] Remove unused pass name parser classes

2020-06-19 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. aeubanks added a reviewer: echristo. aeubanks updated this revision to Diff 272166. aeubanks added a comment. Unintended change Looks like these were for the most

[clang-tools-extra] af4f2eb - [clang-tidy] remove duplicate fixes of alias checkers

2020-06-19 Thread Nathan James via cfe-commits
Author: Daniel Date: 2020-06-19T20:40:59+01:00 New Revision: af4f2eb476361e6da42d6f66a68cada763625c32 URL: https://github.com/llvm/llvm-project/commit/af4f2eb476361e6da42d6f66a68cada763625c32 DIFF: https://github.com/llvm/llvm-project/commit/af4f2eb476361e6da42d6f66a68cada763625c32.diff LOG:

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 272157. ymandel added a comment. fix additional refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82225/new/ https://reviews.llvm.org/D82225 Files: clang/include/clang/Tooling/Transformer/Stencil.h

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd81d69f1c0c1: [libTooling] Change Transformers `cat` to handle some cases of text in macros. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. Deletes `text()` and `selection()` combinators, since they have been deprecated for months. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82225 Files:

[PATCH] D82224: [OpenMP] Remove hard-coded line numbers from test

2020-06-19 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny created this revision. jdenny added reviewers: ABataev, jdoerfert, hfinkel. Herald added subscribers: sstefan1, guansong, yaxunl. jdenny added reviewers: grokos, sfantao, Hahnfeld. Otherwise, it's painful to insert new code. There are many existing examples in the same test file where the

[PATCH] D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel marked an inline comment as done. ymandel added a comment. This revision is now accepted and ready to land. Only nits. Really nice work. I much prefer your new system, having wrestled with config and multi-language testing in the existing framework.

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 272150. ymandel added a comment. Fixed clang tidy lit test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82126/new/ https://reviews.llvm.org/D82126 Files:

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D82126#2104088 , @tdl-g wrote: > Interesting, in all three of those cases, it's reasonable to replace the > entire expression, thus eliminating the macro. None of those "tear" the > macro; if we had a case like > > #define

[PATCH] D82223: [clang-tidy] Implement storeOptions for checks missing it.

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 created this revision. njames93 added reviewers: aaron.ballman, Eugene.Zelenko. Herald added subscribers: cfe-commits, kbarton, xazax.hun, nemanjai. Herald added a project: clang. Just adds the storeOptions for Checks that weren't already storing their options. Repository: rG LLVM

[clang] d81d69f - [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via cfe-commits
Author: Yitzhak Mandelbaum Date: 2020-06-19T18:48:54Z New Revision: d81d69f1c0c161e093531cf1ac9c1fa280ab5bf1 URL: https://github.com/llvm/llvm-project/commit/d81d69f1c0c161e093531cf1ac9c1fa280ab5bf1 DIFF: https://github.com/llvm/llvm-project/commit/d81d69f1c0c161e093531cf1ac9c1fa280ab5bf1.diff

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid marked 2 inline comments as done. zbrid added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption,

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-19 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers updated this revision to Diff 272143. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - make cases more uniform, cleanup some missed fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-19 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:103-118 + case Decl::CXXRecord: // struct/union/class X; [C++] +if (CGDebugInfo *DI = getDebugInfo()) + if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() && +

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

2020-06-19 Thread Nick Desaulniers via Phabricator via cfe-commits
nickdesaulniers added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:103-118 + case Decl::CXXRecord: // struct/union/class X; [C++] +if (CGDebugInfo *DI = getDebugInfo()) + if (CGM.getCodeGenOpts().hasMaybeUnusedDebugInfo() && +

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

2020-06-19 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg added subscribers: fhahn, anemet, thegameg. thegameg added a comment. This sounds useful indeed. @fhahn, @anemet might want to take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82213/new/ https://reviews.llvm.org/D82213

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

2020-06-19 Thread Wenlei He via Phabricator via cfe-commits
wenlei created this revision. wenlei added reviewers: wmi, davidxl, hoy. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. Add call site location info into inline remarks so we can differentiate inline sites. This can be useful for inliner

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

2020-06-19 Thread Daniel Grumberg via Phabricator via cfe-commits
dang updated this revision to Diff 272125. dang added a comment. Allocate string when denormalizing an option backed by an `std::string`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. Yup, i think so! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81407/new/ https://reviews.llvm.org/D81407 ___ cfe-commits mailing list

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Tom Lokovic via Phabricator via cfe-commits
tdl-g added a comment. Interesting, in all three of those cases, it's reasonable to replace the entire expression, thus eliminating the macro. None of those "tear" the macro; if we had a case like #define FOO(a,b,c,d) ((a).find(b) == std::string::npos ? (c) : (d)) FOO("helo", "x", 5, 6); I

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:2244 HelpText<"Disable control-flow mitigations for Load Value Injection (LVI)">; +def m_seses : Flag<["-"], "mseses">, Group, Flags<[CoreOption, DriverOption]>, + HelpText<"Enable speculative

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. Happy. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736 ___ cfe-commits mailing list

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

2020-06-19 Thread Mikhail Maltsev via Phabricator via cfe-commits
miyuki created this revision. miyuki added reviewers: stuij, labrinea, dmgreen, simon_tatham. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. miyuki added a child revision: D80928: [BFloat] Add convert/copy instrinsic support. Currently, in order

[PATCH] D82185: [Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers

2020-06-19 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:256 + SVal SubVal = State->getSVal(UO->getSubExpr(), C.getLocationContext()); + SVal Result = State->getSVal(UO,

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 272117. zbrid added a comment. Fix accidentally deleted clang command line ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel closed this revision. ymandel added a comment. Committed as revision rG9ca50e887db7 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81868/new/

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid added a comment. @sconstab @craig.topper @mattdr -- This is ready for another round of review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; fpetrogalli wrote: > nit:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 272114. zbrid added a comment. seses implies lvi-cfi also enable-seses -> enable-seses-without-lvi-cfi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 Files:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid added inline comments. Comment at: llvm/lib/Target/X86/X86SpeculativeExecutionSideEffectSuppression.cpp:90 + const X86Subtarget = MF.getSubtarget(); + if (!Subtarget.useSpeculativeExecutionSideEffectSuppression() && +

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

2020-06-19 Thread Xun Li via Phabricator via cfe-commits
lxfind updated this revision to Diff 272109. lxfind added a comment. Addressed comments: Updated error message, and sorted notes. The tests are kept unchanged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

2020-06-19 Thread Zola Bridges via Phabricator via cfe-commits
zbrid updated this revision to Diff 272105. zbrid marked an inline comment as done. zbrid added a comment. Update Clang Command Ref with automated tool Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. Tests show that this breaks the test for the clang tidy `abseil-string-find-str-contains`. Curious if this is a desirable change in behavior (in which case I'll update your test file) or the wrong behavior:

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread David Sherwood via Phabricator via cfe-commits
david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82182/new/ https://reviews.llvm.org/D82182

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. In D81736#2103822 , @clementval wrote: > @jdoerfert @jdenny Should we wait until Monday to go ahead with this patch? I > have several other patches

[PATCH] D80301: [yaml][clang-tidy] Fix new line YAML serialization

2020-06-19 Thread Dmitry Polukhin via Phabricator via cfe-commits
DmitryPolukhin added a comment. It looks like there is no support for the proposed solution so I found alternative solution that might be even better. We can use double quotation `"` for multiline strings. It solves problem because in case of double quotation LLVM escapes new line like `\n` so

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_len.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S -O1

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

2020-06-19 Thread Valentin Clement via Phabricator via cfe-commits
clementval added a comment. @jdoerfert @jdenny Should we wait until Monday to go ahead with this patch? I have several other patches that will follow this one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-19 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. So for this patch it would be OK to have the uniqueing location as it is now. A next large change can be to add the global resource leak report uniqueing feature, this changes anyway more existing checkers (including this one). (Still I want to finish other

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

2020-06-19 Thread Sander de Smalen via Phabricator via cfe-commits
sdesmalen marked 2 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true)

[PATCH] D82126: [libTooling] Change Transformer's `cat` to handle some cases of text in macros.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added a comment. In D82126#2103772 , @tdl-g wrote: > LGTM. I found the change description confusing, since it talks about the > selection() stencil but the code is all about the cat() stencil. I realize > (now) that the former is deprecated in

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

2020-06-19 Thread Nathan James via Phabricator via cfe-commits
njames93 marked an inline comment as done. njames93 added inline comments. Herald added a subscriber: wuzish. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.cpp:30 Options.store(Opts, "GslHeader", GslHeader);

[PATCH] D82178: [AArch64][SVE] Guard svbfloat16_t with feature macro in ACLE

2020-06-19 Thread Cullen Rhodes via Phabricator via cfe-commits
c-rhodes updated this revision to Diff 272091. c-rhodes added a comment. Changes: - Include `arm_bf16.h` if `__ARM_FEATURE_BF16_SCALAR_ARITHMETIC` is defined. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82178/new/ https://reviews.llvm.org/D82178 Files:

[PATCH] D82126: [libTooling] Change `selection` stencil to handle some cases of text in macros.

2020-06-19 Thread Tom Lokovic via Phabricator via cfe-commits
tdl-g added a comment. LGTM. I found the change description confusing, since it talks about the selection() stencil but the code is all about the cat() stencil. I realize (now) that the former is deprecated in favor of the latter. But the change description is still confusing. Repository:

[PATCH] D82199: [clang-format] restore indent in conditionals AlignOperands is DontAlign

2020-06-19 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. krasimir edited the summary of this revision. After D50078 , we're experiencing unexpected un-indent using a style combining `AlignOperands: DontAlign` with

[PATCH] D67321: Respect CLANG_LINK_CLANG_DYLIB=ON in libclang and c-index-test

2020-06-19 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. Ping. The current state is that c-index-test crashes for us, and I'd like to see it fixed for 10.0.1. I have a patch of my own but it doesn't handle all that `_static` magic, so I guess this one's better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82182: [AArch64][SVE] Add bfloat16 support to perm and select intrinsics

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/arm_sve.td:1115 +let ArchGuard = "defined(__ARM_FEATURE_SVE_BF16)" in { +def SVREV_BF16: SInst<"svrev[_{d}]","dd", "b", MergeNone, "aarch64_sve_rev">; nit: could create a

[PATCH] D82186: [AArch64][SVE] Add bfloat16 support to svlen intrinsic

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_len.c:2 // REQUIRES: aarch64-registered-target -// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -triple aarch64-none-linux-gnu -target-feature +sve -fallow-half-arguments-and-returns -S

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

2020-06-19 Thread Loïc Joly via Phabricator via cfe-commits
loic-joly-sonarsource added a comment. Can someone with write access merge this please? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80025/new/ https://reviews.llvm.org/D80025 ___ cfe-commits mailing list

[PATCH] D82181: [clang-format] indent in chained conditionals when AlignOperands:DontAlign

2020-06-19 Thread Krasimir Georgiev via Phabricator via cfe-commits
krasimir updated this revision to Diff 272084. krasimir added a comment. - add a regression test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82181/new/ https://reviews.llvm.org/D82181 Files: clang/unittests/Format/FormatTest.cpp Index:

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

2020-06-19 Thread Francesco Petrogalli via Phabricator via cfe-commits
fpetrogalli added inline comments. Comment at: clang/include/clang/Basic/AArch64SVEACLETypes.def:69 -SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16, SveBFloat16Ty, 8, 16, false, false, true) +SVE_VECTOR_TYPE("__SVBFloat16_t", "__SVBFloat16_t", SveBFloat16,

[PATCH] D81571: [analyzer] SATest: Add initial docker infrastructure

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok then! Comment at: clang/utils/analyzer/entrypoint.py:31 + +CMAKE_COMMAND = "cmake -G Ninja -DCMAKE_BUILD_TYPE=Release " \ +"-DCMAKE_INSTALL_PREFIX=/analyzer

[PATCH] D82122: [analyzer][Liveness][RFC][NFC] Propose to turn statement liveness into expression liveness

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. I think you're right, this entire thing only makes sense for expressions. I think `Environment` occasionally carries values of `ReturnStmt`s (by which it means values of their sub-expressions) but even then liveness analysis doesn't need to be aware of that flex. > no lit

[PATCH] D81601: [analyzer] SATest: Use logger in single-threaded mode as well

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Aha ok nvm then! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81601/new/ https://reviews.llvm.org/D81601

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/projects/box2d/run_static_analyzer.cmd:1 +cmake . -DCMAKE_BUILD_TYPE=Release -Bbuild -GNinja +cmake --build build vsavchenko wrote: > NoQ wrote: > > Is there a flag to enable assertions or something

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

2020-06-19 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:383 +# when directory name starts with the letter `l`. +if sys.platform == 'win32': +# Find all `\l` (like `,\l`, `}\l`, `[\l`) except `\\l`,

  1   2   >