[clang] 8f6620f - [MSP430] Update register names

Author: Anatoly Trosinenko Date: 2020-06-22T13:24:03+03:00 New Revision: 8f6620f663031da2bb35b788239f4b607271af84 URL: https://github.com/llvm/llvm-project/commit/8f6620f663031da2bb35b788239f4b607271af84 DIFF:

[clang] c2b22c5 - Fixed ASTMatchers registry and regen ast docs

Author: Nathan James Date: 2020-06-22T10:56:20+01:00 New Revision: c2b22c57fc1394f2566d20369ae29877eb7df1a1 URL: https://github.com/llvm/llvm-project/commit/c2b22c57fc1394f2566d20369ae29877eb7df1a1 DIFF: https://github.com/llvm/llvm-project/commit/c2b22c57fc1394f2566d20369ae29877eb7df1a1.diff

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

Kai added a comment. I would like to get a 2nd opinion before committing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79423: [analyzer][NFC] StdLibraryFunctionsChecker: Add empty Signatures

martong abandoned this revision. martong added a comment. Since D80016 we are able to look up types in the TU, so this patch is no longer needed. We'd like to be as precise with the function signatures as possible. Repository: rG LLVM Github Monorepo

[PATCH] D79433: [analyzer] StdLibraryFunctionsChecker: Add summaries for POSIX

martong abandoned this revision. martong added a comment. This patch is no longer needed because I am going to upstream the POSIX functions in groups, otherwise the patch would be hideously large. The groups are: file handling, networking, pthread_, mq_, dbm_, regex related, sched_, time,

[PATCH] D82187: [AArch64][SVE] ACLE: Add bfloat16 to struct load/stores.

sdesmalen updated this revision to Diff 272342. sdesmalen added a comment. - Updated RUN line in tests to fix test failures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82187/new/ https://reviews.llvm.org/D82187 Files: clang/include/clang/Basic/AArch64SVEACLETypes.def

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

j0le added a comment. In D75453#2094938 , @danielkiss wrote: > Sorry for the delay, it is okay to say "ping" after a while :) > LGTM Hi Daniel, no problem, thanks for comming back to this review after that long time. I will say "ping" next time :)

[PATCH] D82312: Add `CharLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82312 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added a comment. In D78655#2105058 , @yaxunl wrote: > - lambdas with any lambda-capture (which must therefore have an enclosing > function) inherit the enclosing function's HDness. Nit: *any* capture does not necessarily imply existence of the

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

lxfind created this revision. lxfind added reviewers: lewissbaker, modocache, junparser. Herald added a project: clang. Herald added a subscriber: cfe-commits. If we ever assign co_await to a temporary variable, such as foo(co_await expr), we generate AST that looks like this:

[PATCH] D82313: [OpenCL] Reject block arguments

svenvh created this revision. svenvh added a reviewer: Anastasia. Herald added a subscriber: yaxunl. OpenCL 2.0 does not allow block arguments, primarily because it is difficult to support function pointers on the various architectures that OpenCL targets. Clang was still accepting them. Rename

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

fpetrogalli updated this revision to Diff 272480. fpetrogalli added a comment. Formatting changes. NFC. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/ https://reviews.llvm.org/D82141 Files: clang/include/clang/Basic/arm_sve.td

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

baloghadamsoftware updated this revision to Diff 272469. baloghadamsoftware retitled this revision from "[Analyzer][WIP] Handle pointer implemented as iterators in iterator checkers" to "[Analyzer] Handle pointer implemented as iterators in iterator checkers". baloghadamsoftware edited the

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

stuij accepted this revision. stuij added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82206/new/ https://reviews.llvm.org/D82206

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Added support for dynamic memory allocation for globalized variables in case if execution of target regions in parallel is

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. I'll get this fixed, thanks both of you for letting me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added a comment. In D78655#2107190 , @yaxunl wrote: > It seems we can only promote non-capturing lambdas, no matter whether it has > enclosing function or not. I'd be OK with promoting only non-capturing lambdas until we figure out a consistent

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

wristow added inline comments. Comment at: clang/test/CodeGen/fp-strictfp.cpp:1 +// RUN: %clang_cc1 -triple mips64-linux-gnu -frounding-math -ffp-exception-behavior=strict -O2 -verify=rounding,exception -emit-llvm -o - %s | tee /tmp/1 | FileCheck %s +// RUN: %clang_cc1 -triple

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon closed this revision. RKSimon added a comment. Committed at rGb30c16670e428d09a0854a8f418e46a3e705e4d1 (with a typo in the Differential Revision tag so phab didn't catch it) CHANGES SINCE LAST ACTION

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki marked 5 inline comments as done. miyuki added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:1066 if (Name == "vcvt_f16_f32" || Name == "vcvt_f32_f16" || + Name == "vcvt_f32_f64" || Name == "vcvt_f64_f32" || LukeGeeson wrote:

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 272416. dang added a comment. Add a `KeyPathPrefix` field to factor out common key path prefixes, for example all `CodeGenOpts`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/

[clang] be9c581 - [analyzer] Remove forbidden characters from a filename for a graph dump on Windows

Author: Denys Petrov Date: 2020-06-22T17:27:20+03:00 New Revision: be9c5818351bf99a193edbc82e4dc25ab5206a44 URL: https://github.com/llvm/llvm-project/commit/be9c5818351bf99a193edbc82e4dc25ab5206a44 DIFF: https://github.com/llvm/llvm-project/commit/be9c5818351bf99a193edbc82e4dc25ab5206a44.diff

Re: [clang] 028571d - [clang][Driver] Correct tool search path priority

Hi, https://reviews.llvm.org/D79988 is apparently a "Restricted Differential Revision" and I don't have permissions to do that. This being an open source project, this is not something we do. I'm guessing it's not intentional? This also breaks check-clang on macOS:

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

klimek added a reviewer: sammccall. klimek added a comment. +Sam for additional sanity checking. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:902 // Maps (matcher, node) -> the match result for memoization. - typedef std::map MemoizationMap; + typedef std::map>

[PATCH] D82306: [Sema][CodeComplete][ObjC] Don't split the first selector fragment

dgoldman created this revision. dgoldman added reviewers: sammccall, doug.gregor. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, dexonsmith, ilya-biryukov. Herald added a project: clang. Standardize the formatting of selector fragments to include the ':', e.g. for `-

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. Ping. I made the change suggested by @erichkeane . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82281: [clang-tidy] llvm-twine-local ignores parameters

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82281/new/ https://reviews.llvm.org/D82281

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

aaron.ballman added a comment. In D81769#2106574 , @jaafar wrote: > "Ping". I hope this can be considered for 10.0.1. If nothing else I think > reviewing the test cases has a lot of value - there are some real issues with > the current checks and

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn added a comment. Herald added a subscriber: wuzish. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D79830: Add support of __builtin_expect_with_probability

antiagainst added inline comments. Comment at: llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:62 +// __builtin_expect +return {LikelyBranchWeight, UnlikelyBranchWeight}; + } else { FYI: this breaks GCC5:

[PATCH] D79830: Add support of __builtin_expect_with_probability

ashi1 added subscribers: yaxunl, ashi1. ashi1 added a comment. Hi, I am getting a compiler error due to this patch. I am using cmake command: cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;lld;clang-tools-extra" -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86"

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM We don't need to block this on the pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81408/new/

[clang] 009c9b8 - Fix multilevel deduction where an outer pack is used in the type of an

Author: Richard Smith Date: 2020-06-22T16:47:51-07:00 New Revision: 009c9b83acfc8bb863894e349bccc2473c685dbc URL: https://github.com/llvm/llvm-project/commit/009c9b83acfc8bb863894e349bccc2473c685dbc DIFF: https://github.com/llvm/llvm-project/commit/009c9b83acfc8bb863894e349bccc2473c685dbc.diff

[clang] e135cf8 - Add -ast-dump-decl-types flag to include types of value and type

Author: Richard Smith Date: 2020-06-22T16:47:51-07:00 New Revision: e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34 URL: https://github.com/llvm/llvm-project/commit/e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34 DIFF: https://github.com/llvm/llvm-project/commit/e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34.diff

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 272378. avl added a comment. 1. deleted code doing more strict tailcall marking. 2. left removal of "AllCallsAreTailCalls". 3. added check for non-capturing calls while tracking alloca. 4. re-titled the patch. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618 + )"; + EXPECT_TRUE(matches(kTest, expr(nullPointerConstant(; } steveire wrote: > While this

[clang] 632088c - [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

Author: Denys Petrov Date: 2020-06-22T14:19:13+03:00 New Revision: 632088c7e84a7ff625c8c67cdc392849b1358f5d URL: https://github.com/llvm/llvm-project/commit/632088c7e84a7ff625c8c67cdc392849b1358f5d DIFF: https://github.com/llvm/llvm-project/commit/632088c7e84a7ff625c8c67cdc392849b1358f5d.diff

[PATCH] D82092: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter

This revision was automatically updated to reflect the committed changes. Closed by commit rG01f9388d95ac: [analyzer] Handle `\l` symbol in string literals in exploded-graph-rewriter (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D82092?vs=272007=272379#toc

[PATCH] D80025: [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcba56e026c7b: [ASTMatcher] Correct memoization bug ignoring direction (descendants or… (authored by loic-joly-sonarsource, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. Thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn updated this revision to Diff 272530. kpn added a comment. Remove debugging command left in accidentally. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:130 +IsNocapture = true; + else if (Function *CalledFunction = CB.getCalledFunction()) { +if (CalledFunction->getBasicBlockList().size() > 0 &&

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 272564. cchen added a comment. Updated test for clarification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added a comment. In D79895#2107604 , @nick wrote: > This diagnostic bring headaches because frequently `-Wunused-variable` > suppression is done via no-op pseudo-consuming function like > `boost::ignore_unused` >

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

hiraditya added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:801 +if (Branch->isUnconditional()) + if (ReturnInst *Ret = dyn_cast( + Branch->getSuccessor(0)->getFirstNonPHIOrDbg())) can we use isa<>

[PATCH] D82335: [clangd] WIP: config

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. This is a glorious tangled mess that needs to be split, and needs tests... Repository: rG LLVM Github

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[clang] cba56e0 - [ASTMatcher] Correct memoization bug ignoring direction (descendants or ancestors)

Author: Loïc Joly Date: 2020-06-22T12:56:29+02:00 New Revision: cba56e026c7beb91a2716276151c5b4360032834 URL: https://github.com/llvm/llvm-project/commit/cba56e026c7beb91a2716276151c5b4360032834 DIFF: https://github.com/llvm/llvm-project/commit/cba56e026c7beb91a2716276151c5b4360032834.diff

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

junparser added a comment. In D82029#2100675 , @modocache wrote: > Excellent, thank you! The test failures on the diff appear to be legitimate, > they reproduce for me when I apply this patch to my local checkout and run > `ninja check-clang`. Could you

[PATCH] D82284: [AST][RecoveryAST] Preseve invalid return stmt, and suppress the diagnostics for missing return stmt in constexpr func.

sammccall added a comment. This is a nice coverage improvement but diagnostic changes don't seem to particularly be improvements... not opposed to landing as-is but want to consider if we can mitigate these... Comment at:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe935a540ea29: [Analyzer][StreamChecker] Add note tags for file opening. (authored by balazske). Changed prior to commit: https://reviews.llvm.org/D81407?vs=271291=272355#toc Repository: rG LLVM

[PATCH] D79430: [analyzer] StdLibraryFunctionsChecker: Add LazyRanges to support type dependent Max

martong abandoned this revision. martong added a comment. Since D80016 we are able to look up types in the TU, so we can get the maximum value from the found type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 37fb860 - Add support of __builtin_expect_with_probability

Author: Zhi Zhuang Date: 2020-06-22T10:21:28-07:00 New Revision: 37fb860301272d8138d289da5b606115b3fe5a13 URL: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13 DIFF: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13.diff

[clang-tools-extra] 6ae0f5f - [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

Author: Nathan James Date: 2020-06-22T18:26:18+01:00 New Revision: 6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 URL: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 DIFF: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097.diff

[clang] 3a4feb1 - [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

Author: Mikhail Maltsev Date: 2020-06-22T17:35:43Z New Revision: 3a4feb1d53df68bed7748a0625b593ba4b5dae32 URL: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32 DIFF: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32.diff

[clang-tools-extra] 9a8b041 - [clang-tidy] llvm-twine-local ignores parameters

Author: Nathan James Date: 2020-06-22T18:25:45+01:00 New Revision: 9a8b0411448062e7231a0ee26bd14a3d1c097e9e URL: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e DIFF: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e.diff

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

amyk accepted this revision as: amyk. amyk added a comment. Other than Lei's concerns, personally I think this looks good to me. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +//

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

This revision was automatically updated to reflect the committed changes. Closed by commit rG516803dc8685: [Coroutines] Ensure co_await promise.final_suspend() does not throw (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 272546. nickdesaulniers added a comment. - fix clang/test/OpenMP/parallel_codegen.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files:

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

nick added a comment. This diagnostic bring headaches because frequently `-Wunused-variable` suppression is done via no-op pseudo-consuming function like `boost::ignore_unused` . Particularly, it fires in Boost

[PATCH] D82184: [MSP430] Update register names

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f6620f66303: [MSP430] Update register names (authored by atrosinenko, committed by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82184/new/

[PATCH] D75453: [Driver][ARM] parse version of arm/thumb architecture correctly

danielkiss added a comment. j0le, I will commit later this week for you. compnerd do you have any comment for this version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75453/new/ https://reviews.llvm.org/D75453 ___ cfe-commits mailing

[clang] b30c166 - Implement constexpr BinaryOperator for vector types

Author: Erich Keane Date: 2020-06-22T07:05:43-07:00 New Revision: b30c16670e428d09a0854a8f418e46a3e705e4d1 URL: https://github.com/llvm/llvm-project/commit/b30c16670e428d09a0854a8f418e46a3e705e4d1 DIFF: https://github.com/llvm/llvm-project/commit/b30c16670e428d09a0854a8f418e46a3e705e4d1.diff

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, c-rhodes, efriedma, stuij, fpetrogalli, david-arm. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added projects: clang, LLVM. Bfloat16

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand added a comment. I've added the test change to yet another diff, which you can find here: https://reviews.llvm.org/D82317 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678

[PATCH] D82317: [Clang/Test]: Update tests where `frozen` attribute is necessary

guiand created this revision. Herald added subscribers: cfe-commits, sstefan1, phosek, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, dmgreen, Jim, mstorsjo, jocewei, PkmX, jfb, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng,

Re: [clang] 028571d - [clang][Driver] Correct tool search path priority

Thanks for the heads up Nico. Yes that was a mistake, it was reviewed as https://reviews.llvm.org/D79842 but somehow I told arc to land it as the duplicate diff instead. I'll look into the failure. On Mon, 22 Jun 2020 at 13:48, Nico Weber wrote: > > Hi, > > https://reviews.llvm.org/D79988 is

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79167/new/ https://reviews.llvm.org/D79167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 272489. guiand added a comment. I've updated this patch to only include the actual implementation of `frozen`, for easier review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand added a comment. @jdoerfert I've separated out changes to the language reference to https://reviews.llvm.org/D82316 as you suggested. I kept the name `frozen` for now while we reach a consensus regarding its final name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80928: [BFloat] Add convert/copy instrinsic support

miyuki updated this revision to Diff 272406. miyuki added a comment. 1. Rebased and fixed failures 2. Added a test for AArch64 codegen of lane copying intrinsics 3. Addressed reviewers' comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80928/new/ https://reviews.llvm.org/D80928

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. Committed but made a mistake with arc so it landed with the wrong diff number. In any case a failure on MacOS was reported so reverted while I investigate that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82103: [analyzer] Remove forbidden characters from a SourceLocation filename for a graph dump on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGbe9c5818351b: [analyzer] Remove forbidden characters from a filename for a graph dump on… (authored by ASDenysPetrov). Changed prior to commit: https://reviews.llvm.org/D82103?vs=272204=272427#toc

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar added a comment. "Ping". I hope this can be considered for 10.0.1. If nothing else I think reviewing the test cases has a lot of value - there are some real issues with the current checks and fixits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval reopened this revision. clementval added a comment. This revision is now accepted and ready to land. Missing dependencies Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81736/new/ https://reviews.llvm.org/D81736

[PATCH] D82259: Deprecate error prone temporary directory APIs

compnerd added a comment. Thanks @davezarzycki! Minor nit: git-clang-format the patch please, there was at least one linter warning in the changed code. I do wonder if we can get away with the removal of the API though doing that in a follow up is pretty reasonable to me. I think that one

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

erichkeane added a comment. The test needs work (check/check-not lines+ filecheck), otherwise I think this should be alright, particularly if no one else has commented in a while. I'd like to have you upload an updated test validating what you think should be happening before approving

[PATCH] D77068: [XCore] fix crash on unused inline in EmitTargetMetadata

nigelp-xmos marked an inline comment as done. nigelp-xmos added inline comments. Comment at: clang/test/CodeGen/xcore-unused-inline.c:4 + +inline void dead_function(void) {} erichkeane wrote: > What is this test validating? It should likely have a check line of

[PATCH] D82298: [AArch64][SVE] Add bfloat16 support to load intrinsics

fpetrogalli requested changes to this revision. fpetrogalli added inline comments. This revision now requires changes to proceed. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_ldnf1.c:2-4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE

[clang] ef597ed - [sve][acle] Add SVE BFloat16 extensions.

Author: Francesco Petrogalli Date: 2020-06-22T16:53:02Z New Revision: ef597eda8efc2e6ee35eceda10bb5ba7c6109696 URL: https://github.com/llvm/llvm-project/commit/ef597eda8efc2e6ee35eceda10bb5ba7c6109696 DIFF:

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

njames93 updated this revision to Diff 272470. njames93 added a comment. Fix checks failing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80202/new/ https://reviews.llvm.org/D80202 Files: clang/lib/ASTMatchers/ASTMatchFinder.cpp Index:

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

john.brawn updated this revision to Diff 272471. john.brawn retitled this revision from "[Driver] When forcing a crash call abort to get the correct diagnostic" to "[Driver] When forcing a crash print the bug report message". john.brawn edited the summary of this revision. john.brawn added a

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:1240 + true; + false; +} C99 has bool literals, but the program should include stdbool.h. I feel like it is better to make the predicate something like "hasBoolType()"

[PATCH] D82310: Add `BoolLiteralExpression` to SyntaxTree

eduucaldas marked 3 inline comments as done. eduucaldas added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:268 +/// Expression for boolean literals. C++ [lex.bool] +class BoolLiteralExpression final : public Expression { Homogenize

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel marked 2 inline comments as done. aardappel added a comment. I'll likely fork `userstack.ll` since the majority of lines need changes. Comment at: lld/wasm/Driver.cpp:385 +StringRef s = arg->getValue(); +if (s == "wasm32") + config->is64 = false;

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

fpallares added a comment. Hi @HsiangKai, thanks for the patch. So far everything looks good aside from a couple of minor nits. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1638 + + if (getLexer().getKind() == AsmToken::EndOfStatement) { +

[PATCH] D82259: Deprecate error prone temporary directory APIs

aprantl added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3176 + if (llvm::sys::path::cache_directory(Result)) { +llvm::sys::path::append(Result, "clang"); +llvm::sys::path::append(Result, "ModuleCache"); I would prefer to separate this

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Sweet! Thanks for the reviews/responses, LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval added a comment. In D81736#2107202 , @jdenny wrote: > My cmake skills are lacking. Why are there are so many new DEPENDS > relationships where there were none before? Is it because omp_gen is > generating a header file that's included

[PATCH] D81963: [HIP] Move HIP Linking Logic into HIP ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rG77df5a8283ed: [HIP] Move HIP Linking Logic into HIP ToolChain (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D81963?vs=271210=272525#toc

[PATCH] D78759: Add Statically Linked Libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bafb0adcf38: Add Statically Linked Libraries (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D78759?vs=271220=272526#toc Repository:

[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is both confusing and crashy. Repository: rG LLVM Github Monorepo

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. If you feel reasonably confident that each new DEPENDS is needed, then this LGTM. Otherwise, give it a day to see if anyone with stronger cmake skills than me has a comment. Repository:

[clang] 516803d - [Coroutines] Ensure co_await promise.final_suspend() does not throw

Author: Xun Li Date: 2020-06-22T15:01:42-07:00 New Revision: 516803dc8685ebcc5bce38b05391958ffee22643 URL: https://github.com/llvm/llvm-project/commit/516803dc8685ebcc5bce38b05391958ffee22643 DIFF: https://github.com/llvm/llvm-project/commit/516803dc8685ebcc5bce38b05391958ffee22643.diff LOG:

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked 2 inline comments as done. aganea added a subscriber: uweigand. aganea added inline comments. Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:4 +// RUN: %clang_cl /c /Z7 /Fo%t.obj -fdebug-compilation-dir . -- %s +// RUN: llvm-pdbutil dump --types

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 272556. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 Files: clang/test/CodeGen/debug-info-codeview-buildinfo.c lld/COFF/PDB.cpp

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:753 return; + if (LI.Default == LCD_None && LI.Captures.size() == 0) { +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); pfultz2 wrote: > There should at least be a flag to

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:823 + +bool TailRecursionEliminator::canTRE(Function ) { + // The local stack holds all alloca instructions and all byval arguments. There is no need to pass the

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82115/new/ https://reviews.llvm.org/D82115

  1   2   >