[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM, just one nit. Francesco Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1-bfloat.c:4 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Thank you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 _

[PATCH] D82102: [AST][RecoveryExpr] Add error-bit TemplateArgument

This revision was automatically updated to reflect the committed changes. Closed by commit rG5f94c9a421ec: [AST][RecoveryExpr] Add error-bit TemplateArgument (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82102/new/ https://revi

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:62-64 +// OPT-NOT: alloca +// OPT-NOT: ptrtoint +// OPT-NOT: inttoptr arsenm wrote: > Positive checks are preferable (here an

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked an inline comment as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument &Arg : F.ar

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

Meinersbur marked an inline comment as done. Meinersbur added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, +

[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:345 + if (E->isValueDependent() || !E->EvaluateAsRValue(Constant, Ctx) || + // Disable printing for tag-types,

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. In D82288#2111206 , @Szelethus wrote: > I see a lot of `NoEvalCall`, but I wonder whether modifying `errno` warrants > this. Shouldn't we have a

[PATCH] D82446: [clang] Fix duplicate warning

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:2273 ParseSpecifierQualifierList(DS, AS_none, DeclSpecContext::DSC_type_specifier); - DS.Finish(Actions, Actions.getASTContext().getPrintingPolicy()); return false; kamleshb

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); unfortunately the reasoning

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects { --

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk created this revision. amyk added reviewers: power-llvm-team, PowerPC, saghir, nemanjai, hfinkel. amyk added projects: LLVM, clang, PowerPC. Herald added subscribers: shchenz, hiraditya. This patch implements the following function prototypes for the truncate and store VSX Vector instruction

[clang-tools-extra] 6a3cffc - [clangd] Disable printing of Value for tag-types on hover

Author: Kadir Cetinkaya Date: 2020-06-24T17:32:19+02:00 New Revision: 6a3cffce3e8076d0608daf951575d5f4d6a333a6 URL: https://github.com/llvm/llvm-project/commit/6a3cffce3e8076d0608daf951575d5f4d6a333a6 DIFF: https://github.com/llvm/llvm-project/commit/6a3cffce3e8076d0608daf951575d5f4d6a333a6.dif

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 273029. avl added a comment. removed usages of AllocaDerivedValueTracker from canTRE(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 Files: llvm/lib/Transforms/Scalar/

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273030. hliao added a comment. Add comments and enhance tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-t

[PATCH] D77598: Integral template argument suffix and cast printing

rsmith added a comment. In D77598#2064193 , @rsmith wrote: > In D77598#1990197 , @rsmith wrote: > > > Is is feasible to check whether the corresponding template parameter either > > has a deduced type or is a param

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao marked an inline comment as done. hliao added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:237-239 + TTI->isNoopAddrSpaceCast( + P2I->getOperand(0)->getType()->getPointerAddressSpace(), + I2P->getType()->getP

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

jasonliu added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1881 + if (isAIXLayout(Context) && FieldOffset == CharUnits::Zero() && + (IsUnion || NonOverlappingEmptyFieldFound)) { +FirstNonOverlappingEmptyFieldHandled = true; Xiangl

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

hliao updated this revision to Diff 273031. hliao added a comment. enhance test more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81938/new/ https://reviews.llvm.org/D81938 Files: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu llvm

[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover

kadircet updated this revision to Diff 273032. kadircet marked an inline comment as done. kadircet added a comment. - tag -> record in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82326/new/ https://reviews.llvm.org/D82326 Files: clang

[PATCH] D80210: [analyzer] Turn off reports in system headers

bruntib added a comment. Hi, Thanks everyone for the investigation in this problem. I find these suggestions reasonable, and I think this commented example is a strong beating card in our hands to convince our users that paths going through system headers are meaningful and important. I'll star

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); ---

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert created this revision. jdoerfert added reviewers: anchu-rajendran, kiranktp, fghanim. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu, hiraditya, yaxunl. Herald added projects: clang, LLVM. During code generation we might change/add basic blocks so keeping

[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a3cffce3e80: [clangd] Disable printing of Value for tag-types on hover (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82326/new/ htt

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

lh123 marked an inline comment as done. lh123 added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); ---

[PATCH] D82213: [Remarks] Add callsite locations to inline remarks

wenlei added a comment. In D82213#2110941 , @fhahn wrote: > That's interesting. We are also using something similar for the matrix > lowering remarks [1]: we traverse the inlining chain bottom up and emit a > remark at each step which contains the expres

[PATCH] D82429: [sve][acle] Add some C intrinsics for brain float types.

c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve2-intrinsics/acle_sve2_tbl2-bfloat.c:4-5 +// RUN: %clang_cc1 -D__ARM_FEATURE_SVE -D__ARM_FEATURE_SVE2 -D__ARM_FEATURE_SVE_BF16 -D__ARM_FEATURE_BF16_SCALAR_ARITHMETIC -DSVE_OVERLOADED_FORMS -triple aarch6

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko updated this revision to Diff 273051. vsavchenko added a comment. Change build type to Debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81592/new/ https://reviews.llvm.org/D81592 Files: .gitignore clang/utils/analyzer/.dockerigno

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added a comment. I tested this check on several open-source projects: //BitCoin//, //CURL//, //OpenSSL//, //PostGreS/, //TMux/ and //Xerces//. I only got two warnings issued by this checker, the first one in //BitCoin//: src/checkqueue.h:93:25: redundant condition 'fMaster'

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong added a comment. Thanks for the review guys! I understand there are concerns about `evalCall`, so I am trying to dissolve those concerns below. :) In D82288#2111206 , @Szelethus wrote: > I see a lot of `NoEvalCall`, but I wonder whether modifying

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:309-311 +void ErrorReturnChecker::checkAccess(CheckerContext &C, ProgramStateRef State, + const Stmt *LoadS, SymbolRef CallSym, +

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename` and `using`.

kadircet added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:2058 Builder.AddChunk(CodeCompletionString::CK_HorizontalSpace); - Builder.AddPlaceholderChunk("qualifier"); - Builder.AddTextChunk("::"); lh123 wrote: > lh123 wrote:

[PATCH] D81003: [clang] SequenceChecker: Also visit default arguments and default initializers.

riccibruno added a comment. @rsmith > I think it's important that we handle this in the near future (though I don't > mind if you'd like to submit this patch as-is and deal with this as a > follow-on). For a case like: > > void f(int, int = a++); >// ... some time later ... >f(a); >

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

martong added a comment. > We use NoEvalCall in all functions in this patch I just now realized that it is actually not true, sorry about that. So, seems like `fnmatch`, `strcasecmp`, `strncasecmp` are `EvalCallAsPure`. I could skip them from this patch, if you guys consider this as dangerous a

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

lxfind marked an inline comment as done. lxfind added inline comments. Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1286 +continue; + if (CastInst) { +// If we have multiple cast instructions for the alloca, don't junparser wrote:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:816 + for (auto &BB : F) { +for (Instruction &I : BB) { + if (AllocaInst *AI = dyn_cast(&I)) { You can use `for (Instruction &I : instructions(F))` here.

[PATCH] D82473: [Matrix] Use 1st/2nd instead of first/second in matrix diags.

fhahn created this revision. fhahn added reviewers: rjmccall, jfb, Bigcheese. Herald added subscribers: cfe-commits, tschuett, dexonsmith. Herald added a project: clang. This was suggested in D72782 and brings the diagnostics more in line with how argument refere

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

MyDeveloperDay added a comment. I confirm this is still an issue as of v11 (trunk) and it looks like D21279: [clang-format] Fix some issues in clang-format's AlignConsecutive modes was landed even though its not closed. (the code behind D21279

[PATCH] D81598: [analyzer] SATest: Add an easy option to connect to docker for debugging

vsavchenko updated this revision to Diff 273063. vsavchenko added a comment. Add comments on waiting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81598/new/ https://reviews.llvm.org/D81598 Files: clang/utils/analyzer/SATest.py clang/utils/ana

[clang] 69d2fa9 - [SemaObjC] Fix a crash on invalid when 'auto' is used in a @property

Author: Erik Pilkington Date: 2020-06-24T12:11:39-04:00 New Revision: 69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 URL: https://github.com/llvm/llvm-project/commit/69d2fa9ed1c1aba6f473feb03cad257e69a0cf52 DIFF: https://github.com/llvm/llvm-project/commit/69d2fa9ed1c1aba6f473feb03cad257e69a0cf52.dif

[PATCH] D82081: [z/OS] Add binary format goff and operating system zos to the triple

MaskRay added a comment. +@rsmith for clang side changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82081/new/ https://reviews.llvm.org/D82081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D82373: [CodeComplete] Tweak code completion for `typename`.

lh123 updated this revision to Diff 273074. lh123 retitled this revision from "[CodeComplete] Tweak code completion for `typename` and `using`." to "[CodeComplete] Tweak code completion for `typename`.". lh123 added a comment. Address comment. I will add `using $alias$ = $type$;` in a separate p

[PATCH] D82476: [Clang][Driver] Recognize the AIX OBJECT_MODE environment setting

daltenty created this revision. daltenty added reviewers: stevewan, hubert.reinterpretcast, ShuhongL. Herald added a project: clang. Herald added a subscriber: cfe-commits. AIX uses an environment variable called OBJECT_MODE to indicate to utilities in the toolchain whether they should be operatin

[PATCH] D82288: [analyzer][StdLibraryFunctionsChecker] Add POSIX file handling functions

Szelethus added a comment. I went through this a lot more thoroughly, as well as the previous patch, and this looks great, especially for an alpha option. I will admit, I'm a bit concerned by the lack of individual tests (what if a stupid interaction with another checker causes issues?), but I

[clang] 87340a2 - [libTooling] Delete deprecated `Stencil` combinators.

Author: Yitzhak Mandelbaum Date: 2020-06-24T16:45:24Z New Revision: 87340a2bf1d2618565b7cf606913c8968e6513fb URL: https://github.com/llvm/llvm-project/commit/87340a2bf1d2618565b7cf606913c8968e6513fb DIFF: https://github.com/llvm/llvm-project/commit/87340a2bf1d2618565b7cf606913c8968e6513fb.diff

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87340a2bf1d2: [libTooling] Delete deprecated `Stencil` combinators. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82225/new/ https://

[clang] 29125dd - Start adding support for generating CC1 command lines from CompilerInvocation

Author: Daniel Grumberg Date: 2020-06-24T18:05:05+01:00 New Revision: 29125ddf1323951901184d2859274afdecac0327 URL: https://github.com/llvm/llvm-project/commit/29125ddf1323951901184d2859274afdecac0327 DIFF: https://github.com/llvm/llvm-project/commit/29125ddf1323951901184d2859274afdecac0327.dif

[clang] ebc9e0f - Fix coding style. NFC.

Author: Michael Liao Date: 2020-06-24T13:13:42-04:00 New Revision: ebc9e0f1f0786b892b4a6eaf50013a18aed31aa5 URL: https://github.com/llvm/llvm-project/commit/ebc9e0f1f0786b892b4a6eaf50013a18aed31aa5 DIFF: https://github.com/llvm/llvm-project/commit/ebc9e0f1f0786b892b4a6eaf50013a18aed31aa5.diff

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

jdoerfert added a comment. I do not understand why we need the flag. As far as I can tell, it has to be on to support the standard described behavior, right? Why should we (allow to) turn it off? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324

[PATCH] D81599: [analyzer] SATest: Add 5 more projects for testing

vsavchenko updated this revision to Diff 273082. vsavchenko added a comment. Change build mode to Debug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81599/new/ https://reviews.llvm.org/D81599 Files: clang/utils/analyzer/Dockerfile clang/utils

[PATCH] D81592: [analyzer] SATest: Add a set of initial projects for testing

vsavchenko updated this revision to Diff 273083. vsavchenko added a comment. Add a new line in .dockerignore Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81592/new/ https://reviews.llvm.org/D81592 Files: .gitignore clang/utils/analyzer/.docke

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

ABataev added a comment. In D82324#2111953 , @jdoerfert wrote: > I do not understand why we need the flag. As far as I can tell, it has to be > on to support the standard described behavior, right? Why should we (allow > to) turn it off? It might use "

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

This revision was automatically updated to reflect the committed changes. Closed by commit rG29125ddf1323: Start adding support for generating CC1 command lines from CompilerInvocation (authored by dang). Changed prior to commit: https://reviews.llvm.org/D79796?vs=272416&id=273091#toc Reposito

[clang] 8dc9214 - [X86] Replace PROC macros with an enum and a lookup table of processor information.

Author: Craig Topper Date: 2020-06-24T10:46:25-07:00 New Revision: 8dc92142e3c5332d741aff4bc81ee6aeed7784b2 URL: https://github.com/llvm/llvm-project/commit/8dc92142e3c5332d741aff4bc81ee6aeed7784b2 DIFF: https://github.com/llvm/llvm-project/commit/8dc92142e3c5332d741aff4bc81ee6aeed7784b2.diff

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 273093. eduucaldas added a comment. remove union. or relation implemented as a parent-child relation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files: clang/i

[PATCH] D78902: [Driver] Add output file to properties of Command

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78902/new/ https://reviews.llvm.org/D78902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D82302: [Discussion] Interface for nodes related to id-expression

eduucaldas updated this revision to Diff 273096. eduucaldas added a comment. Polishing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82302/new/ https://reviews.llvm.org/D82302 Files: clang/include/clang/Tooling/Syntax/Nodes.h Index: clang/inclu

[PATCH] D78899: [Driver] Add callback to Command execution

sepavloff added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78899/new/ https://reviews.llvm.org/D78899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

kmclaughlin updated this revision to Diff 273092. kmclaughlin added a comment. - Added [HasBF16] predicate to new store pattern in AArch64SVEInstrInfo.td - Check hasBF16() is true for bfloat16 types in performST1Combine/performSTNT1Combine - Added bfloat16 test to sve-pred-contiguous-ldst-address

[PATCH] D82414: [X86] Replace PROC macros with an enum and a lookup table of processor information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8dc92142e3c5: [X86] Replace PROC macros with an enum and a lookup table of processor… (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D82414?vs=272837&id=273101#toc Reposi

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

nigelp-xmos updated this revision to Diff 273100. nigelp-xmos retitled this revision from "[XCore] fix crash on unused inline in EmitTargetMetadata" to "Fix crash on XCore on unused inline in EmitTargetMetadata". nigelp-xmos added a comment. Added explanatory comment and CHECK lines to test case

[clang] 3fa666b - [OpenMP][Docs] Mark TR8 `present` as claimed in docs

Author: Joel E. Denny Date: 2020-06-24T14:21:11-04:00 New Revision: 3fa666b883625a678cfcfd9ad96b2daabcef09e8 URL: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8 DIFF: https://github.com/llvm/llvm-project/commit/3fa666b883625a678cfcfd9ad96b2daabcef09e8.diff

[PATCH] D79472: [X86] Remove support some inline assembly constraints that are no longer supported by gcc.

craig.topper planned changes to this revision. craig.topper added a comment. I committed part of this, but got nervous when I found icc supported some of this. Still need to check our internal tests to see if they are used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

nigelp-xmos added a comment. I do not have commit access, so if this is approved, please could it be committed against author "Nigel Perks" nig...@xmos.com ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77068/new/ https://reviews.llvm.org/D77068

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

zequanwu marked 2 inline comments as done. zequanwu added inline comments. Comment at: clang/lib/Analysis/UninitializedValues.cpp:410 + if (FunctionDecl *fd = CE->getDirectCallee()) { +if (FunctionTemplateDecl *ftd = fd->getPrimaryTemplate()) + return ftd->getTemplatedD

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

zequanwu updated this revision to Diff 273103. zequanwu marked an inline comment as done. zequanwu added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82425/new/ https://reviews.llvm.org/D82425 Files: clang/lib/Analy

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Bumping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: eduucaldas, ymandel. How does RecursiveASTVisitor call the WalkUp callback for expressions? - In pre-order traversal mode, RecursiveASTVisitor calls the WalkUp call

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. gribozavr2 added reviewers: ymandel, eduucaldas. These tests show a bug: post-order traversal introduces an extra call to WalkUp*, that is not present in pre-order traversal. I'm fixing t

[clang] 01ddb2a - [OpenMP][NFC] Remove hard-coded line numbers from test

Author: Joel E. Denny Date: 2020-06-24T14:35:01-04:00 New Revision: 01ddb2a7b044f697a15043e47acdb93e2825809a URL: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a DIFF: https://github.com/llvm/llvm-project/commit/01ddb2a7b044f697a15043e47acdb93e2825809a.diff

[clang] cdd6a27 - [ObjC] Copy a block to the heap if it is passed as a variadic argument

Author: Akira Hatanaka Date: 2020-06-24T11:46:38-07:00 New Revision: cdd6a2788caced6b377af818154138d9983dba5f URL: https://github.com/llvm/llvm-project/commit/cdd6a2788caced6b377af818154138d9983dba5f DIFF: https://github.com/llvm/llvm-project/commit/cdd6a2788caced6b377af818154138d9983dba5f.diff

[PATCH] D81098: [OpenMP] Upgrade default version of OpenMP to 5.0

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81098/new/ https://reviews.llvm.org/D81098 ___

[PATCH] D82224: [OpenMP][NFC] Remove hard-coded line numbers from test

jdenny added a comment. @jdoerfert Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82224/new/ https://reviews.llvm.org/D82224 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar updated this revision to Diff 273117. vrnithinkumar added a comment. Fixing test failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82256/new/ https://reviews.llvm.org/D82256 Files: clang/include/clang/StaticAnalyzer/Checkers/C

[PATCH] D82448: [AArch64][SVE] Add bfloat16 support to store intrinsics

fpetrogalli requested changes to this revision. fpetrogalli added a comment. This revision now requires changes to proceed. Thank you for updating the patch with the missing tests. I only have one request for the code involving assertions, and the use of `let Predicates = ...`. Francesco ===

[PATCH] D82224: [OpenMP][NFC] Remove hard-coded line numbers from test

This revision was automatically updated to reflect the committed changes. Closed by commit rG01ddb2a7b044: [OpenMP][NFC] Remove hard-coded line numbers from test (authored by jdenny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D82256: [analyzer] Enabling ctr in evalCall event

vrnithinkumar marked 5 inline comments as done. vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp:130 +llvm::errs() << " (" << ND->getQualifiedNameAsString() << ')'; + llvm::errs() << " {" << Call.getNumArgs()

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

MaskRay added subscribers: NoQ, MaskRay. MaskRay added a comment. +@NoQ on comments whether clang static analyzer can catch these cases. `clang++ --analyze a.cc` does not warn on `a.size()-2` AFAICT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

aaron.ballman added a comment. Personally, I think this behavior is a bit mysterious given that there are *much* better ways to silence unused variable warnings (like casting to `void`) that have been well-supported by compilers for a long time and I'd prefer not to penalize every call expressi

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I talked to others about the test, and they suggested the correct way to validate this is to make it simply a 'doesn't crash' test, so I'll remove the filecheck/check lines and submit

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

jdoerfert added a reviewer: kiranchandramohan. jdoerfert added a comment. @kiranchandramohan You can add yourself and others ;) Can we test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677 _

[clang] dc3f891 - Fix crash on XCore on unused inline in EmitTargetMetadata

Author: Nigel Perks Date: 2020-06-24T12:48:17-07:00 New Revision: dc3f8913d2ad33b1129ea488393e12cc88061aff URL: https://github.com/llvm/llvm-project/commit/dc3f8913d2ad33b1129ea488393e12cc88061aff DIFF: https://github.com/llvm/llvm-project/commit/dc3f8913d2ad33b1129ea488393e12cc88061aff.diff L

[clang] 56b530d - Fix a pair of wtype-limits and 3 wparentheses warnings from 29125ddf1

Author: Erich Keane Date: 2020-06-24T12:50:25-07:00 New Revision: 56b530d92c42e962a1828e14783601d2861ba353 URL: https://github.com/llvm/llvm-project/commit/56b530d92c42e962a1828e14783601d2861ba353 DIFF: https://github.com/llvm/llvm-project/commit/56b530d92c42e962a1828e14783601d2861ba353.diff L

[PATCH] D27651: [clang-format] Even with AlignConsecutiveDeclarations, PointerAlignment: Right should keep *s and &s to the right

ambroyz added a comment. In D27651#2111783 , @MyDeveloperDay wrote: > I don't see any LLVM contributions from the original author @KP for some > time, @ambroyz are you pinging this issue because your keen for someone to > look at it? I'm not sure if t

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

jdoerfert added a comment. Let me rephrase. Does the user needs to request the fast path or the user needs to request the slow but correct path? Only the former is acceptable IMHO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ https://r

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:16 +template +class RecordingVisitorBase : public TestVisitor { + bool VisitPostOrder;

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

ABataev marked an inline comment as done. ABataev added a comment. In D82324#2112388 , @jdoerfert wrote: > Let me rephrase. Does the user needs to request the fast path or the user > needs to request the slow but correct path? Only the former is acceptabl

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 273133. mibintc added a comment. I decided that I shouldn't make float options that define a macro, like -ffast-math, as BENIGN_LANGOPT, I made ffp-contract= , fp-exception-behavior and rounding-mode BENIGN, I modified the pch test case to test that the beni

[PATCH] D77068: Fix crash on XCore on unused inline in EmitTargetMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc3f8913d2ad: Fix crash on XCore on unused inline in EmitTargetMetadata (authored by nigelp-xmos, committed by erichkeane). Changed prior to commit: https://reviews.llvm.org/D77068?vs=273100&id=273138#t

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82324/new/ https://reviews.llvm.org/D82324

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

fghanim added a comment. Thanks for the Patch. I have few questions to help me understand what's going on. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings What's th

[PATCH] D81938: [InferAddressSpaces] Handle the pair of `ptrtoint`/`inttoptr`.

arsenm added inline comments. Comment at: clang/test/CodeGenCUDA/amdgpu-kernel-arg-pointer-type.cu:62-64 +// OPT-NOT: alloca +// OPT-NOT: ptrtoint +// OPT-NOT: inttoptr hliao wrote: > arsenm wrote: > > Positive checks are preferable (here and through the rest of

[PATCH] D82497: [Clang][SourceManager] optimize getFileIDLocal()

nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. A recent Linux kernel commit exposed a performance cliff in Clang. Calls to SourceManager::getFileIDLocal() when there's a cache miss against La

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added inline comments. Comment at: clang/lib/Basic/SourceManager.cpp:967 if (isOffsetInFileID(FileID::get(-int(MiddleIndex) - 2), SLocOffset)) { FileID Res = FileID::get(-int(MiddleIndex) - 2); kadircet wrote: > my comments above for

[PATCH] D82498: [SourceManager] don't check invalid param of getLocalSLocEntry()

nickdesaulniers created this revision. nickdesaulniers added a reviewer: kadircet. Herald added a project: clang. Herald added a subscriber: cfe-commits. nickdesaulniers retitled this revision from "[SourceManager] don't check Invalid param of getLocalSLocEntry()" to "[SourceManager] don't check i

[PATCH] D80897: [OpenMP] Initial support for std::complex in target regions

jdoerfert added a comment. @tra After chatting with @hfinkel I know now why we don't see the calls in the libc++ case. libc++ implements std::complex without `_Complex` types, stdlib++ does. If the user uses `_Complex` directly we need these functions for sure as the standard defines them (I t

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. I've forked off 1. D82497 (`getFileIDLocal` optimizations) 2. D82498 (don't check `Invalid` for calls to `getLocalSLocEntry`) I agree those should be the less controversial parts of this diff.

Re: [clang] 9d8d064 - [NFC] Silence compiler warning [-Wmissing-braces].

Generally it'd be helpful to describe what the change is in the subject line ("Add braces around initialization of a subobject [-Wmissing-braces]") as that's more informative than "Silence compiler warning [-Wmissing braces]", the latter doesn't say how it was silenced, which might make a differenc

Re: [clang] 719c87e - remove gold linker

"Remove gold linker support from the PS4 toolchain" might've been a more precise commit message - "Remove gold linker" seems a bit too vague. On Tue, Jun 16, 2020 at 1:03 PM Yuanfang Chen via cfe-commits wrote: > > > Author: Yuanfang Chen > Date: 2020-06-16T13:03:31-07:00 > New Revision: 719c87ed

<    1   2   3   >