[PATCH] D82815: [clang-tidy] Sanity checks in ClangTidyTest header.

njames93 created this revision. njames93 added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Motivated by a suspicously failing build, but also good to have anyway in general. Repository: rG LLVM Github Monorepo

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

amyk updated this revision to Diff 274239. amyk added a comment. Updated revision to: - add the MC test cases into `vsx.s` and `vsx.txt`. - create a test file called `builtins-ppc-p10vsx.ll` to place all Power10 VSX builtins tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D81213: [RISCV] Support experimental v extension v0.9.

evandro accepted this revision. evandro added a comment. This revision is now accepted and ready to land. It LGTM after D80802 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81213/new/

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 274275. cchen added a comment. 1. Remove a commit that is not on master branch 2. Add a rule in Sema to avoid non-contiguous array section for map clause 3. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw updated this revision to Diff 274276. zixuw added a comment. Abort the design of making 'Wundef' an alias to 'Wundef-prefix' because it depends on the alias expansion to work, which adds an empty string to 'UndefPrefixes' to do the trick. However, any other way to enable 'Wundef', for

[clang] 5a5f535 - [c++20] Fix handling of operator rewrites naming consteval operator<=>.

Author: Richard Smith Date: 2020-06-29T19:02:47-07:00 New Revision: 5a5f5350e1cbe14eaf852d9003523c7fdb1132af URL: https://github.com/llvm/llvm-project/commit/5a5f5350e1cbe14eaf852d9003523c7fdb1132af DIFF: https://github.com/llvm/llvm-project/commit/5a5f5350e1cbe14eaf852d9003523c7fdb1132af.diff

[clang] 6792a60 - [darwin][driver] pass the minimum supported OS version to the linker

Author: Alex Lorenz Date: 2020-06-29T19:03:57-07:00 New Revision: 6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b URL: https://github.com/llvm/llvm-project/commit/6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b DIFF: https://github.com/llvm/llvm-project/commit/6792a6077889f1ce77a3aa55b3e4fd3f1eb4333b.diff

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

vsapsai added a comment. Seems like this change causes `ninja clean` to fail with the error > ninja: error: remove(include/llvm/Support): Directory not empty Full repro steps are ninja install ninja clean Simpler steps are ninja include/llvm/Support/all ninja clean

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

guiand added a comment. I've run across an issue when bootstrapping clang, that manifests itself in the following code when compiled with optimizations: #include float my_exp2(float a) { return pow(2.0, a); } With this code, the call to `pow` is lifted to a `exp2`, and then the

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

efriedma added a comment. In D81678#2120709 , @guiand wrote: > Could anyone point me to where I might need to make a change for that? LibCallSimplifier::optimizePow Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 31c689e - Move Sema::PragmaStack::Act into Sema.h so it can be instantiated as needed

Author: David Blaikie Date: 2020-06-29T18:02:12-07:00 New Revision: 31c689e69404bb8208de9599626f60c77b6fa81d URL: https://github.com/llvm/llvm-project/commit/31c689e69404bb8208de9599626f60c77b6fa81d DIFF: https://github.com/llvm/llvm-project/commit/31c689e69404bb8208de9599626f60c77b6fa81d.diff

[clang-tools-extra] 1f14287 - [clangd] config() -> Config::current to avoid confict with NS

Author: Sam McCall Date: 2020-06-29T23:05:19+02:00 New Revision: 1f14287eab972e76a521a32a2c326b8ff3b8d21f URL: https://github.com/llvm/llvm-project/commit/1f14287eab972e76a521a32a2c326b8ff3b8d21f DIFF: https://github.com/llvm/llvm-project/commit/1f14287eab972e76a521a32a2c326b8ff3b8d21f.diff

[clang] 381df16 - Clang Driver: Use Apple ld64's new @response-file support.

Author: James Y Knight Date: 2020-06-29T18:26:53-04:00 New Revision: 381df1653c927efa9dac86c24a9db2b98f270de0 URL: https://github.com/llvm/llvm-project/commit/381df1653c927efa9dac86c24a9db2b98f270de0 DIFF:

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

schweitz updated this revision to Diff 274278. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82807/new/ https://reviews.llvm.org/D82807 Files: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp Index: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:4907 + if (Stride) { +auto Res = +PerformOpenMPImplicitIntegerConversion(Stride->getExprLoc(), Stride); cchen wrote: > ABataev wrote: > > `auto`->`ExprResult` > Should I also

[clang] bb162df - [clang] attempt to fix a linux test failure for the darwin-ld-platform-version-macos.c test

Author: Alex Lorenz Date: 2020-06-29T20:13:41-07:00 New Revision: bb162dfe252a1abc15af411d8ba51dda63af306c URL: https://github.com/llvm/llvm-project/commit/bb162dfe252a1abc15af411d8ba51dda63af306c DIFF: https://github.com/llvm/llvm-project/commit/bb162dfe252a1abc15af411d8ba51dda63af306c.diff

[PATCH] D82392: [CodeGen] Add public function to emit C++ destructor call.

rjmccall added a comment. Can we do a design more like what we did with constructors? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82392/new/ https://reviews.llvm.org/D82392 ___ cfe-commits mailing

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX created this revision. ArcsinX added a reviewer: rsmith. ArcsinX added a project: clang. Herald added a subscriber: cfe-commits. ArcsinX edited the summary of this revision. `__builtin_va_*()` and `__builtin_ms_va_*()` declared as functions with reference parameters. This patch fix

[PATCH] D82806: [AIX] Static init support for template specialization and inline variable

Xiangling_L created this revision. Xiangling_L added reviewers: hubert.reinterpretcast, jasonliu, yusra.syeda, ZarkoCA, sfertile. Herald added subscribers: cfe-commits, jfb. Herald added a project: clang. This is a follow-up patch of D74166 . This patch adds

[PATCH] D82807: [clang-tidy] Allows the prevailing include header guard in Flang ...

schweitz created this revision. schweitz added reviewers: bkramer, hokein. schweitz added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Herald added a reviewer: DavidTruby. Herald added a reviewer: sscalpone. Herald added a project: clang. to be recognized rather

[PATCH] D81728: [InstCombine] Add target-specific inst combining

efriedma added a comment. > This combines instructions, so I think it belongs into the InstCombine pass. > On the other hand, the f16 form of the intrinsics is not available on all > targets, so this combination cannot be applied unconditionally but it needs > to be gated depending on the

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt = options::OPT_mlvi_cfi; sconstab wrote: > zbrid wrote: > >

[clang] 4772b99 - Clang Driver: refactor support for writing response files to be

Author: James Y Knight Date: 2020-06-29T18:27:02-04:00 New Revision: 4772b99dffec4f87bb7bc9273495066058ac0186 URL: https://github.com/llvm/llvm-project/commit/4772b99dffec4f87bb7bc9273495066058ac0186 DIFF:

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM. Thank you for adding this! In D82733#2121414 , @phil-blain wrote: > I tested the sphinx build for the `man` and `html` targets. Any

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings fghanim wrote: > jdoerfert wrote: > >

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

jkorous added a comment. @milianw could you try to reduce the reproducer you have? Maybe take lldb and see where does the `nullptr` come from? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/ https://reviews.llvm.org/D82740

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

steven.zhang added inline comments. Comment at: llvm/test/MC/Disassembler/PowerPC/vsx.txt:2 # RUN: llvm-mc --disassemble %s -triple powerpc64-unknown-linux-gnu -mcpu=pwr7 | FileCheck %s +# RUN: llvm-mc --disassemble %s -triple powerpc64-unknown-linux-gnu \ +# RUN:

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

jdoerfert added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2082 + const Type *RetTyPtr = RetTy.getTypePtr(); + if (!RetTy->isVoidType() && !RetTyPtr->isRecordType() && + RetAI.getKind() != ABIArgInfo::Indirect) { guiand wrote: > guiand

[PATCH] D81678: Introduce noundef attribute at call sites for stricter poison analysis

jdoerfert added inline comments. Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:932 case Attribute::NoCfCheck: + case Attribute::NoUndef: break; nikic wrote: > Not familiar with this code, but based on the placement of other similar

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX updated this revision to Diff 274250. ArcsinX added a comment. Fix format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82805/new/ https://reviews.llvm.org/D82805 Files: clang/lib/Sema/SemaInit.cpp clang/test/Sema/init-ref-c.c Index: clang/test/Sema/init-ref-c.c

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain added a comment. I tested the sphinx build for the `man` and `html` targets. Any other targets I should check ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82733/new/ https://reviews.llvm.org/D82733

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain updated this revision to Diff 274286. phil-blain added a comment. Use `note::` Sphinx directive Also: - Fix Sphinx formatting for preformatted text - Correctly pass the linker argument (initial '-' was missing) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4539 +if (CXXRecordDecl *T2RecordDecl = +dyn_cast(T2RecordType->getDecl())) { + const auto = T2RecordDecl->getVisibleConversionFunctions(); I cannot reproduce this with

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk updated this revision to Diff 274260. amyk added a comment. Updated the patch to move the MC/llc tests into the appropriate files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82467/new/ https://reviews.llvm.org/D82467 Files:

[clang] 4d1b7e9 - Fix a few cases that were incorrectly parsed as unary-expressions

Author: Richard Smith Date: 2020-06-29T14:33:21-07:00 New Revision: 4d1b7e9820ee9c87541619ce4dd41e92dc43cd9c URL: https://github.com/llvm/llvm-project/commit/4d1b7e9820ee9c87541619ce4dd41e92dc43cd9c DIFF: https://github.com/llvm/llvm-project/commit/4d1b7e9820ee9c87541619ce4dd41e92dc43cd9c.diff

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274255. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4539 +if (CXXRecordDecl *T2RecordDecl = +dyn_cast(T2RecordType->getDecl())) { + const auto = T2RecordDecl->getVisibleConversionFunctions();

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek updated this revision to Diff 274256. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219 Files: clang/CMakeLists.txt clang/test/CMakeLists.txt clang/test/lit.site.cfg.py.in compiler-rt/test/lit.common.configured.in

[PATCH] D79219: [CMake] Simplify CMake handling for zlib

phosek marked an inline comment as done. phosek added inline comments. Comment at: llvm/cmake/config-ix.cmake:514 + if(ZLIB_FOUND) +set(LLVM_ENABLE_ZLIB "YES" CACHE STRING + "Use zlib for compression/decompression if available. Can be ON, OFF, or FORCE_ON"

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

jyu2 created this revision. jyu2 added reviewers: hfinkel, erichkeane, rjmccall, cfe-commits. Herald added a subscriber: jfb. When using __sync_nand_and_fetch with __int128, a problem is found that the wrong value for the 'invert' value gets emitted to the xor in case where the int size is

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2497 + bool IsArgument) { + if (!CallerMap.lookup(Feature) && !CalleeMap.lookup(Feature)) +return Diag.Report(CallLoc, diag::warn_avx_calling_convention)

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:15 + +Note: In this alias the options ``WarnOnUnfixable`` and +``RefactorConditionVariables`` are both set to ``false`` by default. Please use

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:200 + ` check now supports a + ``RefactorConditionVariables`` option to control whether to refactor condition + variables where possible. Please use single back-ticks

[clang-tools-extra] 11cd977 - Add missing #include

Author: David Blaikie Date: 2020-06-29T22:08:20-07:00 New Revision: 11cd9770174603aa62deabbe96c7d0db64d07058 URL: https://github.com/llvm/llvm-project/commit/11cd9770174603aa62deabbe96c7d0db64d07058 DIFF: https://github.com/llvm/llvm-project/commit/11cd9770174603aa62deabbe96c7d0db64d07058.diff

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

arphaman created this revision. arphaman added reviewers: erik.pilkington, steven_wu. Herald added subscribers: ributzka, dexonsmith, jkorous. Herald added a reviewer: aaron.ballman. This patch canonicalizes the macOS versions in the `availability`, so that clang can treat macOS 10.16

[PATCH] D82782: Clang Driver: refactor support for writing response files to be specified at Command creation, rather than as part of the Tool.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4772b99dffec: Clang Driver: refactor support for writing response files to be specified at… (authored by jyknight). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82777: Clang Driver: Use Apple ld64's new @response-file support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG381df1653c92: Clang Driver: Use Apple ld64s new @response-file support. (authored by jyknight). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82777/new/

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked 10 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp hokein wrote: > we have a few config-related files now, I wonder would

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274237. sammccall marked 3 inline comments as done. sammccall added a comment. Address some review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

craig.topper added a comment. @RKSimon do you mind taking a look at this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82731/new/ https://reviews.llvm.org/D82731 ___ cfe-commits mailing list

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

varungandhi-apple updated this revision to Diff 274242. varungandhi-apple added a comment. - [docs] [lit] Add a more helpful description for lit.py's -s flag. - [NFC] [lit] Separate verbose and showOutput. - [lit] Improve lit's output with default settings and --verbose. Repository: rG LLVM

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751

[PATCH] D82822: [OpenMP][FIX] Consistently use OpenMPIRBuilder if requested

jdoerfert created this revision. jdoerfert added reviewers: anchu-rajendran, kiranktp, fghanim. Herald added subscribers: sstefan1, guansong, bollu, yaxunl. Herald added a project: clang. When we use the OpenMPIRBuilder for the parallel region we need to also use it to get the thread ID (among

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

aprantl added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse Conditional Constant Propagation: {{.*}}

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. This is supposed to have a parent revision D82824 but for some reason phab won't let me add it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. njames93 added a comment. This is supposed to have a parent revision D82824 but for some

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Added a 'RefactorConditionVariables' option to control how the check handles condition variables Repository: rG LLVM

[PATCH] D82791: [lit] Improve lit's output with default settings and --verbose.

varungandhi-apple updated this revision to Diff 274240. varungandhi-apple added a comment. Herald added subscribers: cfe-commits, martong. Herald added a project: clang. Include missing commit separating verbose and showOutput. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82431: [PowerPC][Power10] Implement Test LSB by Byte Builtins in LLVM/Clang

amyk added a comment. @lei Could you please take another look at this to see if this change is OK? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82431/new/ https://reviews.llvm.org/D82431 ___

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain added inline comments. Comment at: clang/docs/CommandGuide/clang.rst:477 + Note: on Darwin, when using :option:`-flto` along with :option:`-g` and + compiling and linking in separate steps, you also need to pass JDevlieghere wrote: > Any reason

[PATCH] D82606: [clangd] Config: config struct propagated through Context

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG9963d93b0731: [clangd] Config: config struct propagated through Context (authored by sammccall). Changed prior to commit:

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

zbrid added a comment. @sconstab @craig.topper - Ping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https://reviews.llvm.org/D79910 ___ cfe-commits mailing list

[clang] f7a1451 - [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

Author: Alex Lorenz Date: 2020-06-29T12:21:54-07:00 New Revision: f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6 URL: https://github.com/llvm/llvm-project/commit/f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6 DIFF: https://github.com/llvm/llvm-project/commit/f7a14514ee63dc2ab9558c50254efb8ac2ad7cc6.diff

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

kees added a comment. In D80791#2120503 , @nickdesaulniers wrote: > Might someone wish to disable PAC/BTI on an individual function, while having > it on for the rest? I guess that would mean you can't call that function > indirectly? It would mean

[PATCH] D82606: [clangd] Config: config struct propagated through Context

thakis added a comment. The test fails on mac and win: http://45.33.8.238/mac/16341/step_9.txt http://45.33.8.238/win/18704/step_9.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606

[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, sstefan1, arphaman, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82800 Files:

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 updated this revision to Diff 274200. njames93 added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720 Files:

[PATCH] D82696: [darwin][driver] isMacosxVersionLT should check against the minimum supported OS version

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7a14514ee63: [darwin][driver] isMacosxVersionLT should check against the minimum supported… (authored by arphaman). Herald added a project: clang. Changed prior to commit:

[clang-tools-extra] c5a6ee1 - Reland [clangd] Config: config struct propagated through Context

Author: Sam McCall Date: 2020-06-29T21:49:25+02:00 New Revision: c5a6ee16f2f6cd7fd46616ba6808a98da53e71bd URL: https://github.com/llvm/llvm-project/commit/c5a6ee16f2f6cd7fd46616ba6808a98da53e71bd DIFF: https://github.com/llvm/llvm-project/commit/c5a6ee16f2f6cd7fd46616ba6808a98da53e71bd.diff

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7893-7897 +llvm::errs() << "DEBUG in CGOpenMPRuntime.cpp\n"; +OASE->getLowerBound()->dump(); +OASE->getLength()->dump(); +OASE->getStride()->dump(); +

[clang] 7c2cb14 - Revert "[clang][SourceManager] cache Macro Expansions"

Author: Nick Desaulniers Date: 2020-06-29T12:54:32-07:00 New Revision: 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 URL: https://github.com/llvm/llvm-project/commit/7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 DIFF:

[clang] 7b8cf98 - Reland "[clang][SourceManager] cache Macro Expansions""

Author: Nick Desaulniers Date: 2020-06-29T12:54:32-07:00 New Revision: 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a URL: https://github.com/llvm/llvm-project/commit/7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a DIFF:

[clang-tools-extra] a3684df - Revert "[clangd] Config: config struct propagated through Context"

Author: Sam McCall Date: 2020-06-29T21:41:57+02:00 New Revision: a3684dfc45c3a7bbdf72750d8a527e07e776b608 URL: https://github.com/llvm/llvm-project/commit/a3684dfc45c3a7bbdf72750d8a527e07e776b608 DIFF: https://github.com/llvm/llvm-project/commit/a3684dfc45c3a7bbdf72750d8a527e07e776b608.diff

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen updated this revision to Diff 274209. cchen added a comment. Revert unnecessary changes made by bot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 Files: clang/include/clang-c/Index.h

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 274210. Herald added a subscriber: ormris. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw updated this revision to Diff 274212. zixuw added a comment. - Refine test cases to check combinations of 'Wundef' and 'Wundef-prefix', and with/without 'Werror'; - Fix issues with '-Werror=undef' by explicitly looking for the option. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82606: [clangd] Config: config struct propagated through Context

sammccall added a comment. Thanks, reverted and looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82606/new/ https://reviews.llvm.org/D82606 ___ cfe-commits mailing list

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss added a comment. In D80791#2120755 , @kees wrote: > In D80791#2120503 , @nickdesaulniers > wrote: > > > Might someone wish to disable PAC/BTI on an individual function, while > > having it on for the

[PATCH] D82690: [clang][SourceManager] cache Macro Expansions pt.2

nickdesaulniers abandoned this revision. nickdesaulniers added a comment. Reverted in 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 , relanded in 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL added a comment. Added testcase for the clang toolchain changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 ___ cfe-commits mailing list

[PATCH] D80681: [clang][SourceManager] cache Macro Expansions

nickdesaulniers added a comment. Reverted in 7c2cb1448ad2d20e251db5e3ae4a0c84c12aa970 , relanded in 7b8cf98b4a9a2f5ea3667fdbf913a4f8952ed36a . Repository:

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added a comment. This seems like it covers a different case than D82735 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76389/new/ https://reviews.llvm.org/D76389

[PATCH] D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

leonardchan created this revision. leonardchan added a reviewer: phosek. leonardchan added a project: clang. After c7bcd431d9c4bfeb631a3599f1d628603e6351d6 , this test started failing when running with the new pass manager.

[clang] de172dd - [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

Author: Leonard Chan Date: 2020-06-29T13:06:42-07:00 New Revision: de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a URL: https://github.com/llvm/llvm-project/commit/de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a DIFF: https://github.com/llvm/llvm-project/commit/de172dd17f0334e1fcbbf28a33d0ea24f7cbff1a.diff

[PATCH] D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82802/new/ https://reviews.llvm.org/D82802

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab accepted this revision. sconstab added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/lib/Driver/ToolChains/Arch/X86.cpp:200 +if (!Args.hasArg(options::OPT_mno_lvi_cfi)) { + Features.push_back("+lvi-cfi"); + LVIOpt =

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen marked 3 inline comments as done. cchen added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7893-7897 +llvm::errs() << "DEBUG in CGOpenMPRuntime.cpp\n"; +OASE->getLowerBound()->dump(); +OASE->getLength()->dump(); +

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

zixuw updated this revision to Diff 274219. zixuw added a comment. - Remove implementation details from the help text of 'Wundef'; - Hide help text for 'Wundef-prefix' and 'Wundef'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 updated this revision to Diff 274223. tianshilei1992 added a comment. Herald added a subscriber: sstefan1. Will update failed tests later CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78075/new/ https://reviews.llvm.org/D78075 Files:

[PATCH] D82802: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rGde172dd17f03: [clang][RelativeVTablesABI] Update CodeGenCXX/RelativeVTablesABI/dynamic-cast. (authored by leonardchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. @thakis Do those bots use `gn`, could that be the cause of the failures? From what I can see `gn` isn't fully supported by llvm and could certainly be the cause of failing builds. Do we have any build bots on mac that don't use `gn` but passed the test case?

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

sammccall abandoned this revision. sammccall added a comment. Abandoning, we'll do this in clangd or find an acceptable way to silence it (see D82736 ). In D82617#2119144 , @dblaikie wrote: > In D82617#2119138

[PATCH] D82741: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) .

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

c-rhodes added a comment. @fpetrogalli thanks for updating, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82345/new/ https://reviews.llvm.org/D82345 ___ cfe-commits mailing list

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 274032. gribozavr added a comment. Added a FIXME about a regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files:

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e5a56865f28: Add tests for sequences of callbacks that RecursiveASTVisitor produces (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun accepted this revision. xazax.hun added a comment. @szelethus The patch looks good to me and I find it a welcome change that should make things easier to understand and maybe even a bit more efficient, I hope this won't break ObjC :) My discussion with Artem is orthogonal to this

[PATCH] D82668: [AArch64][SVE] clang: Add missing svbfloat16_t tests

c-rhodes added inline comments. Comment at: clang/test/CodeGenCXX/aarch64-sve-typeinfo.cpp:4 // RUN: %clang_cc1 -triple aarch64-none-linux-gnu %s -emit-llvm -o - \ -// RUN: -target-feature +sve | FileCheck %s +// RUN: -target-feature +sve,+bf16 | FileCheck %s

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:57 +// CHECK-NEXT: Hoist/decompose integer division and remainder: PASS +// CHECK-NEXT: Simplify the CFG: PASS aprantl wrote: >

  1   2   3   >