[PATCH] D82665: [AArch64][SVE] Add bfloat16 to outstanding tuple vector intrinsics

c-rhodes added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_create2-bfloat.c:9 +// A simple used,unused... macro, long enough to represent any SVE builtin. +#define SVE_ACLE_FUNC(A1,A2_UNUSED,A3,A4_UNUSED) A1##A3 +#else

[PATCH] D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG339ed1e042c0: Move TestClangConfig into libClangTesting and use it in AST Matchers tests (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D82179?vs=274008=274050#toc

[PATCH] D82661: [clang-tidy][NFC] Remove unnecessary includes throughout clang-tidy header files

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM, though I think this should be landed in two commits (one for the headers, one for the tests). Comment at: clang-tools-extra/test/clang-tidy/checkers/google-module.cpp:4 +// CHECK-DAG: {{- key:

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:139 + + const auto *MethodDecl = dyn_cast_or_null(OC->getDecl()); + You should never get null here due to `isStdSmartPointerClass` guarding above. I think the

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, dexonsmith. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. dang added a parent revision: D82574: Merge TableGen files used for clang options. This

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e5a56865f28: Add tests for sequences of callbacks that RecursiveASTVisitor produces (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 274032. gribozavr added a comment. Added a FIXME about a regression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files:

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

c-rhodes added a comment. @fpetrogalli thanks for updating, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82345/new/ https://reviews.llvm.org/D82345 ___ cfe-commits mailing list

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun accepted this revision. xazax.hun added a comment. @szelethus The patch looks good to me and I find it a welcome change that should make things easier to understand and maybe even a bit more efficient, I hope this won't break ObjC :) My discussion with Artem is orthogonal to this

[PATCH] D82741: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) .

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I just checked `BuiltinBug` -- why do we even have this??? Anyways, LGTM. We should probably delete the whole thing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82391: [AArch64][SVE] Add bfloat16 support to svext intrinsic

sdesmalen accepted this revision. sdesmalen added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82391/new/ https://reviews.llvm.org/D82391 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 274027. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 updated this revision to Diff 274012. njames93 added a comment. Figuring out mac crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188 Files: clang-tools-extra/clang-tidy/ClangTidyCheck.cpp

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

sammccall abandoned this revision. sammccall added a comment. Abandoning, we'll do this in clangd or find an acceptable way to silence it (see D82736 ). In D82617#2119144 , @dblaikie wrote: > In D82617#2119138

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. @thakis Do those bots use `gn`, could that be the cause of the failures? From what I can see `gn` isn't fully supported by llvm and could certainly be the cause of failing builds. Do we have any build bots on mac that don't use `gn` but passed the test case?

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr updated this revision to Diff 274010. gribozavr added a comment. Simplified capture lists in lambdas Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82485/new/ https://reviews.llvm.org/D82485 Files:

[PATCH] D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests

gribozavr updated this revision to Diff 274008. gribozavr added a comment. Addressed code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82179/new/ https://reviews.llvm.org/D82179 Files:

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

njames93 added a comment. In D82707#2119303 , @MyDeveloperDay wrote: > In D82707#2118796 , @njames93 wrote: > > > Is that a bad thing? > > > Not really, just a little disappointed ;-( I'm gonna hazard a guess

[PATCH] D82179: Move TestClangConfig into libClangTesting and use it in AST Matchers tests

gribozavr2 marked 5 inline comments as done. gribozavr2 added a comment. > However, is this worth an RFC to the list? I don't think so. I'm consolidating existing testing infrastructure that was already providing this functionality, and using regular parameterized tests (`TEST_P`).

[PATCH] D82741: [Analyzer][StreamChecker] Use BugType instead of BuiltinBug (NFC) .

balazske created this revision. Herald added subscribers: cfe-commits, ASDenysPetrov, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. balazske

[clang-tools-extra] e34523c - Revert "[clang-tidy] relanding b9306fd"

Author: Nathan James Date: 2020-06-29T09:44:11+01:00 New Revision: e34523c87c3f1cfabcf741568dede026bbb12d3a URL: https://github.com/llvm/llvm-project/commit/e34523c87c3f1cfabcf741568dede026bbb12d3a DIFF: https://github.com/llvm/llvm-project/commit/e34523c87c3f1cfabcf741568dede026bbb12d3a.diff

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:117 + recordDefaultImplementation( + __func__, [&, this]() { RecordingVisitorBase::WalkUpFromStmt(S); }); +

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

MyDeveloperDay added a comment. In D82707#2118796 , @njames93 wrote: > In D82707#2118772 , @MyDeveloperDay > wrote: > > > The net result is an actual reduction in the overall % > > > > F12256151: image.png

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/ClangTidyDiagnosticConsumerTest.cpp:31 + ~TestCheck() { +assert(DidRegister && "Check never registered"); +assert(DidFire && "Check never

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

fghanim requested changes to this revision. fghanim added inline comments. This revision now requires changes to proceed. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:282 + IRBuilder<> AllocaBuilder; + /// Map to remember source location strings

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. I've relanded this with some sanity checks in 37cc4fa2eaa3d03ca8cd4947eb0d4c60e3c9b45c . If it fails again without those asserts I'll go back to the drawing board Repository: rG LLVM Github

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw added a comment. I'm not sure how to write a unit test for this, but I ran into a reproducible crash with a complex C++ file which got fixed by this patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/

[clang-tools-extra] 37cc4fa - [clang-tidy] relanding b9306fd

Author: Nathan James Date: 2020-06-29T09:29:39+01:00 New Revision: 37cc4fa2eaa3d03ca8cd4947eb0d4c60e3c9b45c URL: https://github.com/llvm/llvm-project/commit/37cc4fa2eaa3d03ca8cd4947eb0d4c60e3c9b45c DIFF: https://github.com/llvm/llvm-project/commit/37cc4fa2eaa3d03ca8cd4947eb0d4c60e3c9b45c.diff

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

sammccall added a comment. Yeah, IMO we spent a bunch of time on these names, I still like them, and I don't find the arguments since then convincing. New info is of course the warning, and the lack of consensus to change it at clang level. As for this proposal specifically -

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw created this revision. milianw added reviewers: bkramer, yvvan, nik. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Fixes crash when visiting a partial AST after encountering a parse error in the input code: #5 clang::Stmt::getStmtClass (this=) at

[PATCH] D82157: Fix crash on `user defined literals`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:632 +// As a node is built by folding tokens we cannot generate one +// for `_w` +Builder.markChildToken(S->getBeginLoc(), syntax::NodeRole::LiteralToken); This

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

hokein added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp we have a few config-related files now, I wonder would it make sense to create a config/ subdir?

[PATCH] D82388: move "basic" builtins to TableGen

craig.topper added inline comments. Comment at: llvm/include/llvm/TableGen/Record.h:1777 /// string manipulation. struct LessRecordByID { bool operator()(const Record *LHS, const Record *RHS) const { Here’s the sort predicate for it. Repository: rG LLVM

[PATCH] D80791: [AArch64] Generate .note.gnu.property based on module flags.

danielkiss added a comment. This patch solve this too: https://bugs.llvm.org/show_bug.cgi?id=46480 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80791/new/ https://reviews.llvm.org/D80791 ___

[PATCH] D82388: move "basic" builtins to TableGen

craig.topper added a comment. Every Record has an ID that is assigned in order. You can just sort the Records based on that in your emitter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82388/new/ https://reviews.llvm.org/D82388

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2118885 , @thakis wrote: > It's the only change on the blame list, things pass consistently before the > change, and fail consistently after it. Do you happen to have a proper build log for the failing build. That

[PATCH] D82485: Add tests for sequences of callbacks that RecursiveASTVisitor produces

eduucaldas accepted this revision. eduucaldas added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:117 + recordDefaultImplementation( + __func__, [&, this]() { RecordingVisitorBase::WalkUpFromStmt(S); }); + return

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske added a comment. I did not found problems related to traversal scope. At AST import `Decl`'s are added only, but the existing ones should remain valid. So the top-level decls in TraversalScope should remain valid after import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D82701: [clangd][Hover] Dont crash on null types

kadircet marked 4 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:302 P.Type = printType(PVD->getType(), Policy); } else { std::string Param; hokein wrote: > nit: now we can remove this

[PATCH] D82701: [clangd][Hover] Dont crash on null types

kadircet updated this revision to Diff 274000. kadircet marked 2 inline comments as done. kadircet added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82701/new/ https://reviews.llvm.org/D82701 Files:

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

jhenderson accepted this revision. jhenderson added a comment. Latest version LGTM too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81672/new/ https://reviews.llvm.org/D81672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82701: [clangd][Hover] Dont crash on null types

This revision was automatically updated to reflect the committed changes. Closed by commit rG117b9230a74c: [clangd][Hover] Dont crash on null types (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82701/new/

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/441 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82739 Files:

[PATCH] D82738: [clang] Fix a null-NSS-access crash in DependentNameType.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: clang. The DependentNameType must have a non-null NSS. This property could be violated during typo correction. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82738 Files:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82085/new/ https://reviews.llvm.org/D82085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev added a comment. @sammccall ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] 117b923 - [clangd][Hover] Dont crash on null types

Author: Kadir Cetinkaya Date: 2020-06-29T09:10:03+02:00 New Revision: 117b9230a74cfbfe5e409adc2aa2d33c9c584a81 URL: https://github.com/llvm/llvm-project/commit/117b9230a74cfbfe5e409adc2aa2d33c9c584a81 DIFF:

[PATCH] D82701: [clangd][Hover] Dont crash on null types

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, I was going to prepare a patch this morning, then realized this one. Comment at: clang-tools-extra/clangd/Hover.cpp:302 P.Type = printType(PVD->getType(),

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

kadircet added a comment. Thanks, renaming was also another option we had in mind, see https://reviews.llvm.org/D81920#2109901 and possibly the following comments. I thought it was discussed in the disable-the-warning thread, but to elaborate a little more: Naming is hard in general, this

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone created this revision. Quuxplusone added reviewers: sammccall, kadircet, dblaikie. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes an instance of `-Woverloaded-virtual` on GCC. Clarifies the purpose of

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

sammccall added a comment. > Guess perhaps a different question: Why don't you want this for clangd? Does > it make the codebase better by not adhering to this particular warning? Yes, exactly. (Sorry if this wasn't explicit). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

dblaikie added a comment. In D82617#2119138 , @sammccall wrote: > > Guess perhaps a different question: Why don't you want this for clangd? > > Does it make the codebase better by not adhering to this particular warning? > > Yes, exactly. (Sorry if this

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/test/Layout/aix-double-struct-member.cpp:1 +// RUN: %clang_cc1 -emit-llvm-only -triple powerpc-ibm-aix-xcoff \ +// RUN: -fdump-record-layouts -fsyntax-only %s 2>/dev/null | \ I am concerned that

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 273991. logan-5 added a comment. Don't warn for destructors by default. This makes -Wsuggest-[destructor-]override more consistent with the behavior of -Winconsistent-missing-[destructor-]override, as well as gcc. Repository: rG LLVM Github Monorepo

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. I reverted this in 8f73c4432b5fa8510c99a5053c07dc70a610e1fb and check-clang-tools stopped failing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 8f73c44 - Revert "[clang-tidy] Reworked enum options handling(again)"

Author: Nico Weber Date: 2020-06-28T21:49:29-04:00 New Revision: 8f73c4432b5fa8510c99a5053c07dc70a610e1fb URL: https://github.com/llvm/llvm-project/commit/8f73c4432b5fa8510c99a5053c07dc70a610e1fb DIFF: https://github.com/llvm/llvm-project/commit/8f73c4432b5fa8510c99a5053c07dc70a610e1fb.diff

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 273986. logan-5 added a comment. Ran clang-format over the diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 Files: clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D79676: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

This revision was automatically updated to reflect the committed changes. Closed by commit rG80e15b4574f4: [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to… (authored by fghanim). Changed prior to commit: https://reviews.llvm.org/D79676?vs=269584=273983#toc

[clang] 80e15b4 - [Clang][OpenMP][OMPBuilder] Moving OMP allocation and cache creation code to OMPBuilderCBHelpers

Author: Fady Ghanim Date: 2020-06-28T19:04:20-04:00 New Revision: 80e15b4574f4a11792472249f64bac790145cc56 URL: https://github.com/llvm/llvm-project/commit/80e15b4574f4a11792472249f64bac790145cc56 DIFF: https://github.com/llvm/llvm-project/commit/80e15b4574f4a11792472249f64bac790145cc56.diff

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain created this revision. phil-blain added reviewers: echristo, dblaikie. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: JDevlieghere. Herald added a project: clang. If `-Wl,object_path_lto,.o` is not passed at link time when compiling and linking in separate

[clang] abafb65 - [clang][docs] Remove untracked files from formatted status

Author: Nathan James Date: 2020-06-28T09:49:39+01:00 New Revision: abafb655c85d92c02c19c8723ef9ecc5d48574bf URL: https://github.com/llvm/llvm-project/commit/abafb655c85d92c02c19c8723ef9ecc5d48574bf DIFF: https://github.com/llvm/llvm-project/commit/abafb655c85d92c02c19c8723ef9ecc5d48574bf.diff

[clang-tools-extra] bfd99be - [clang-tidy] Update lang restrictions on perf module

Author: Nathan James Date: 2020-06-28T15:18:08+01:00 New Revision: bfd99be0fc58fe644aff76d180b333e6d840126a URL: https://github.com/llvm/llvm-project/commit/bfd99be0fc58fe644aff76d180b333e6d840126a DIFF: https://github.com/llvm/llvm-project/commit/bfd99be0fc58fe644aff76d180b333e6d840126a.diff

[PATCH] D82562: Implement AVX ABI Warning/error

craig.topper added inline comments. Comment at: clang/include/clang/Basic/DiagnosticFrontendKinds.td:246 + "enabled changes the ABI">, + InGroup>; +def err_avx_calling_convention : Error; Should this be -Wpsabi to match gcc? I think that's what

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, LuoYuanke, LiuChen3, echristo, FreddyYe. Herald added subscribers: jfb, hiraditya. Herald added projects: clang, LLVM. craig.topper added a reviewer: erichkeane. This replaces the switch statement implementation

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:148 +if (InnerPointVal && InnerPointVal->isZeroConstant()) { + reportBug(C, Call); +} This doesn't seem to be guarded by `ShouldCheckSmartPtrDereference`.

[clang-tools-extra] b9306fd - [clang-tidy] Reworked enum options handling(again)

Author: Nathan James Date: 2020-06-28T10:18:33+01:00 New Revision: b9306fd042ce1c11d84f05d2124dfdc65b8331fe URL: https://github.com/llvm/llvm-project/commit/b9306fd042ce1c11d84f05d2124dfdc65b8331fe DIFF: https://github.com/llvm/llvm-project/commit/b9306fd042ce1c11d84f05d2124dfdc65b8331fe.diff

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, sbenza, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Extend the default string like classes to include `std::basic_string_view`. Repository: rG LLVM Github Monorepo

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273942. lh123 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

kiranchandramohan added a comment. Is the ordering of code generation for clauses important? copyin -> firstprivate -> barrier -> private Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1673 // // TODO: This defaults to shared right now. auto PrivCB =

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 273925. lh123 edited the summary of this revision. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files:

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

fghanim added a comment. Thanks for working on this. LGTM. Did you make any changes other than splitting from D82470 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82722/new/ https://reviews.llvm.org/D82722

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. It's the only change on the blame list, things pass consistently before the change, and fail consistently after it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/ https://reviews.llvm.org/D82188

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 created this revision. logan-5 added a reviewer: rsmith. logan-5 added a project: clang. Herald added a subscriber: cfe-commits. This patch adds `-Wsuggest-override`, which allows for more aggressive enforcement of modern C++ best practices, as well as better compatibility with gcc,

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

SouraVX accepted this revision. SouraVX added a comment. This revision is now accepted and ready to land. In D82470#2118814 , @jdoerfert wrote: > In D82470#2116581 , @SouraVX wrote: > > > Overall this seems great

[PATCH] D82650: [HIP] Set default FP_CONTRACT to ON

dfukalov abandoned this revision. dfukalov added a comment. I was completely wrong Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82650/new/ https://reviews.llvm.org/D82650 ___ cfe-commits mailing list

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 273957. njames93 added a comment. Include matcher name in error message when failing to build a regex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 created this revision. lh123 added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Remove

[PATCH] D82711: [clang-tidy] Fix hicpp-named-paramater

njames93 created this revision. njames93 added reviewers: aaron.ballman, jbcoe. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Currently this alias instantiates the readability-identifier-naming check, just swap it out to use the readability-named-paramater

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

junparser accepted this revision. junparser added a comment. This revision is now accepted and ready to land. LGTM， Thank you！ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314

[PATCH] D82714: [clangd] Remove redundant `findRefs` calls. NFC.

lh123 updated this revision to Diff 273928. lh123 added a comment. Rebase to head. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82714/new/ https://reviews.llvm.org/D82714 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions

jdoerfert updated this revision to Diff 273961. jdoerfert edited the summary of this revision. jdoerfert added a comment. restrict this to the alloca support Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82470/new/ https://reviews.llvm.org/D82470

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 273960. njames93 added a comment. Moved the code to build and verify the regex out of the macro Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82722: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert created this revision. jdoerfert added reviewers: anchu-rajendran, kiranktp, fghanim. Herald added a subscriber: rogfer01. Herald added projects: clang, LLVM. jdoerfert added a child revision: D82470: [OpenMP][IRBuilder] Support allocas in nested parallel regions. During code

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9306fd042ce: [clang-tidy] Reworked enum options handling(again) (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

[PATCH] D82089: [clang-tidy] modernize-loop-convert reverse iteration support

njames93 updated this revision to Diff 273913. njames93 added a comment. Rebased inline with new enum handling added in D82188 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82089/new/

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8755b6378c2: [Coroutines] Optimize the lifespan of temporary co_await object (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/

[PATCH] D82470: [OpenMP][IRBuilder] Support nested parallel regions

jdoerfert added a comment. In D82470#2116581 , @SouraVX wrote: > Overall this seems great Thanks! I have one minor concern: > This patch seems to do 2 things: Support for nested parallel regions(which > was crashing earlier) and some infrastructure

[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82729 Files:

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

MyDeveloperDay added a comment. The net result is an actual reduction in the overall % F12256151: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82707/new/ https://reviews.llvm.org/D82707

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

njames93 added a comment. In D82188#2118769 , @thakis wrote: > This breaks chevk-clang-tools in mac: http://45.33.8.238/mac/16292/step_8.txt > > Please take a look and revert for now if it takes a while to fix. Are you sure that this is the offending

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

njames93 added a comment. In D82707#2118772 , @MyDeveloperDay wrote: > The net result is an actual reduction in the overall % > > F12256151: image.png Is that a bad thing? Repository: rG LLVM Github Monorepo

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. I have a few pending patches that enforce some long desired restrictions on which checkers can emit diagnostics, and I'd prefer not to mess with your checker after you land

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

This revision was automatically updated to reflect the committed changes. Closed by commit rGabafb655c85d: [clang][docs] Remove untracked files from formatted status (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82707/new/

[PATCH] D82707: [clang][docs] Remove untracked files from formatted status

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for this, I’m happy with this and can take a look at removing the os.walk I agree it might be better/quicker Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D82314: [Coroutines] Optimize the lifespan of temporary co_await object

lxfind updated this revision to Diff 273946. lxfind added a comment. Rebase before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https://reviews.llvm.org/D82314 Files: llvm/lib/Transforms/Coroutines/CoroSplit.cpp

[clang] 20a60f4 - [X86] Explicitly add popcnt feature to Intel CPUs with SSE4.2 in the frontend.

Author: Craig Topper Date: 2020-06-28T11:06:40-07:00 New Revision: 20a60f46f505fc790e126b8b860c689870355f36 URL: https://github.com/llvm/llvm-project/commit/20a60f46f505fc790e126b8b860c689870355f36 DIFF: https://github.com/llvm/llvm-project/commit/20a60f46f505fc790e126b8b860c689870355f36.diff

[PATCH] D82188: [clang-tidy] Reworked enum options handling(again)

thakis added a comment. This breaks chevk-clang-tools in mac: http://45.33.8.238/mac/16292/step_8.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82188/new/

<    1   2   3