[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2123200 , @dmajor wrote: > In that case, more specifically, the problem I'm seeing is that these flags > are not making it through to a small handful of files: LLVMHello.dll, > PrintFunctionNames.dll,

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

This revision was automatically updated to reflect the committed changes. Closed by commit rGa1f4e48c4aca: [clang][docs] Add note about using `-flto` with `-g` on macOS (authored by phil-blain, committed by JDevlieghere). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82887: [ARM] Add Cortex-A77 Support for Clang and LLVM

LukeGeeson created this revision. LukeGeeson added a reviewer: t.p.northover. Herald added subscribers: llvm-commits, cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. This patch upstreams support for the Arm-v8 Cortex-A77 processor for AArch64 and ARM. In

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

ShuhongL updated this revision to Diff 274519. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82677/new/ https://reviews.llvm.org/D82677 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib/Driver/ToolChains/AIX.h

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added a comment. In D82825#2123125 , @njames93 wrote: > In D82825#2122789 , @aaron.ballman > wrote: > > > Other than the documentation and settling on the option name in the parent > > revision, I

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. In D65543#2122942 , @dmajor wrote: > After this change, PGO builds of clang on Windows can no longer find > `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could > potentially make this seamless? Or is it expected

[PATCH] D80804: [AMDGPU] Introduce Clang builtins to be mapped to AMDGCN atomic inc/dec intrinsics

JonChesterfield added a comment. This patch declares the clang builtin as acting on signed values, but the IR intrinsic maps to an instruction which does an unsigned comparison. We don't have ISA support for a signed comparison equivalent. Addition is the same operation on signed or unsigned

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; njames93 wrote: > aaron.ballman

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

Szelethus added a comment. In D82845#2122984 , @balazske wrote: > I checked it with simple debug print, the `LeakedSyms` will contain 2 items > with different `StreamOpenNode`. So I think these should be independent > problem reports for the bug

[PATCH] D82832: Correctly generate invert xor value for Binary Atomics of int size > 64

jfb accepted this revision. jfb added a comment. This revision is now accepted and ready to land. Herald added a subscriber: dexonsmith. This amused me. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82832/new/ https://reviews.llvm.org/D82832

[clang] a1f4e48 - [clang][docs] Add note about using `-flto` with `-g` on macOS

Author: Philippe Blain Date: 2020-06-30T09:33:20-07:00 New Revision: a1f4e48c4aca8c7339be2018926baf860a562f13 URL: https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13 DIFF:

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return;

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, after mine and Aaron's comments. Comment at: clang/lib/Sema/SemaExpr.cpp:19195-19211 +if (Spec == AvailSpecs.end()) + return None; +if

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

This revision was automatically updated to reflect the committed changes. Closed by commit rG2efba0e8122a: [clang-tidy] performance-faster-string-find string-view (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82720?vs=274200=274512#toc Repository: rG LLVM Github

[PATCH] D82626: [CodeComplete] Tweak completion for else.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ba4867c2700: [CodeComplete] Tweak completion for else. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

steakhal updated this revision to Diff 274510. steakhal added a comment. - adds statistic to undecidable branch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82856/new/ https://reviews.llvm.org/D82856 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Index:

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 added a comment. In D82825#2122789 , @aaron.ballman wrote: > Other than the documentation and settling on the option name in the parent > revision, I think this LGTM (the changes will be mechanical and can be done > without further review once

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:969 + // Do not warn for non-closed stream at program exit. + if (Pred && Pred->getCFGBlock() &&

[PATCH] D82185: [Analyzer] Handle pointer implemented as iterators in iterator checkers

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. Thanks, it LGTM now! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82185/new/ https://reviews.llvm.org/D82185 ___ cfe-commits

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. Another point is, if we for example have an i16 umul.fix in legalization, we have no way of knowing in the general case that it is safe to replace it with an smul.fix, since the information that the MSB is not significant does not exist on IR level. This is the 'loss

[PATCH] D80751: [clang][diagnostics] Add '-Wundef-prefix' warning option

ributzka accepted this revision. ributzka added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80751/new/ https://reviews.llvm.org/D80751 ___ cfe-commits mailing list

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

NoQ added a comment. > I have one question though. Isn't this counting all the reports in an > equivalence class? Yes it is. You have no choice but to run refutation before deduplication; otherwise the otherwise-best report in the class may be false when other reports are true. CHANGES

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thank you! Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6278 + return true; +// FIXME(liuhui): Ideally, we should check the ctor parameter list to +

[PATCH] D82856: [analyzer][Z3-refutation] Add statistics for refutation visitor

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2856-2857 Optional IsSAT = RefutationSolver->check(); if (!IsSAT.hasValue()) return; I strongly recommend a statistic for this branch as well. I.e., how

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 274504. atrosinenko added a comment. - Rebase onto an up-to-date upstream commit - Recheck against v9.2.0 - Misc fixes and improvements Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274503. sammccall added a comment. CompiledFragment becomes a std::function, compile interface moved to Fragment.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612

[clang] 8ba4867 - [CodeComplete] Tweak completion for else.

Author: Nathan James Date: 2020-06-30T16:48:24+01:00 New Revision: 8ba4867c27000ee029ab70a1194050d884fce6c7 URL: https://github.com/llvm/llvm-project/commit/8ba4867c27000ee029ab70a1194050d884fce6c7 DIFF: https://github.com/llvm/llvm-project/commit/8ba4867c27000ee029ab70a1194050d884fce6c7.diff

[clang-tools-extra] 2efba0e - [clang-tidy] performance-faster-string-find string-view

Author: Nathan James Date: 2020-06-30T16:45:59+01:00 New Revision: 2efba0e8122aeca29f878c0e3056a4552d20c720 URL: https://github.com/llvm/llvm-project/commit/2efba0e8122aeca29f878c0e3056a4552d20c720 DIFF: https://github.com/llvm/llvm-project/commit/2efba0e8122aeca29f878c0e3056a4552d20c720.diff

[PATCH] D82767: clang-format: Explicitly use python3

compnerd added a comment. While I really like this idea of migrating the scripts to python3, I believe that the current plan is to allow until December for users to migrate, so this might be a bit premature :-(. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82767/new/

[PATCH] D82815: [clang-tidy] Sanity checks in ClangTidyTest header.

This revision was automatically updated to reflect the committed changes. Closed by commit rG833273a81250: [clang-tidy] Sanity checks in ClangTidyTest header. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82815/new/

[PATCH] D82626: [CodeComplete] Tweak completion for else.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice, thanks for doing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/ https://reviews.llvm.org/D82626

[PATCH] D82845: [Analyzer][StreamChecker] Report every leak, clean up state.

balazske added a comment. I checked it with simple debug print, the `LeakedSyms` will contain 2 items with different `StreamOpenNode`. So I think these should be independent problem reports for the bug reporter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr updated this revision to Diff 274495. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82787/new/ https://reviews.llvm.org/D82787 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2117451 , @rjmccall wrote: > Why not legalize to the signed operation? My feeling was that it wasn't right do so in LLVM, because LLVM has no notion of the padding bit and therefore doesn't really care about Clang's

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

riccibruno added inline comments. Comment at: clang/test/Sema/init-ref-c.c:8 +} \ No newline at end of file ArcsinX wrote: > riccibruno wrote: > > I think it would be better to name this test `varargs-arm.c` since this bug > > can only happen with the

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274496. lh123 added a comment. Add the missing `operator!=`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82882: [ASTImporter] Fix AST import crash for a friend decl

vabridgers created this revision. vabridgers added a reviewer: martong. Herald added subscribers: cfe-commits, teemperor, rnkovacs, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a project: clang. Running CTU testing, we found that VisitFriendDecl in ASTImporterLookup.cpp was not

[PATCH] D82787: Make RecursiveASTVisitor call WalkUpFrom for unary and binary operators in post-order traversal mode

gribozavr updated this revision to Diff 274497. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82787/new/ https://reviews.llvm.org/D82787 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

dmajor added a comment. After this change, PGO builds of clang on Windows can no longer find `clang_rt.profile-x86_64.lib`. Is there some cmake magic that could potentially make this seamless? Or is it expected that the burden is on the user to set up the paths manually during the

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 updated this revision to Diff 274493. njames93 marked 2 inline comments as done. njames93 added a comment. Fix missing return statement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82706/new/ https://reviews.llvm.org/D82706 Files:

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:193 if (checkConditionVarUsageInElse(If) != nullptr) { +if (!WarnOnConditionVariables) + return; Would it make sense to hoist this

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

njames93 marked 7 inline comments as done. njames93 added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags

[PATCH] D82548: [CodeComplete] Add code completion for `delete` and `default` specifier.

lh123 updated this revision to Diff 274491. lh123 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82548/new/ https://reviews.llvm.org/D82548 Files: clang/include/clang/Sema/Sema.h clang/lib/Parse/ParseDecl.cpp

[clang-tools-extra] 833273a - [clang-tidy] Sanity checks in ClangTidyTest header.

Author: Nathan James Date: 2020-06-30T16:19:15+01:00 New Revision: 833273a81250213d3ba85ca5419d03155604ada2 URL: https://github.com/llvm/llvm-project/commit/833273a81250213d3ba85ca5419d03155604ada2 DIFF: https://github.com/llvm/llvm-project/commit/833273a81250213d3ba85ca5419d03155604ada2.diff

[PATCH] D82226: Add Metadata to Transformer tooling

This revision was automatically updated to reflect the committed changes. Closed by commit rG9945bd591163: Add Metadata to Transformer tooling (authored by asoffer, committed by ymandel). Changed prior to commit: https://reviews.llvm.org/D82226?vs=274183=274484#toc Repository: rG LLVM

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz added a comment. Resurrecting this, with the ignore #undef when #define is in a module approach. Still worth having a test, especially that it's the first test we have for modules. Note that the test code changed since last version due to introduction of ThreasafeFS since my original

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

baloghadamsoftware added a comment. In D79431#2020951 , @Szelethus wrote: > Sure, this is an improvement because we display more information, but I'd > argue that it isn't really a more readable warning message :) How about > > th argument to the call to

[PATCH] D79431: [analyzer] StdLibraryFunctionsChecker: Add better diagnostics

baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:323 +std::string("Function argument constraint is not satisfied, ") + +VC->getName().data() + ", ArgN: " + std::to_string(VC->getArgNo());

[PATCH] D80525: [clangd] Fix crash-bug in preamble indexing when using modules.

adamcz updated this revision to Diff 274482. adamcz added a comment. Changed to just ignore undefs without matching def Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80525/new/ https://reviews.llvm.org/D80525 Files:

[PATCH] D82486: RecursiveASTVisitor: don't call WalkUp unnecessarily in post-order traversal

gribozavr updated this revision to Diff 274481. gribozavr added a comment. Rebased the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82486/new/ https://reviews.llvm.org/D82486 Files: clang/include/clang/AST/RecursiveASTVisitor.h

[PATCH] D82880: Fix PR35677: UB on __int128_t or __uint128_t template parameters.

davidstone created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82880 Files: clang/lib/AST/StmtPrinter.cpp clang/test/AST/ast-print-int128.cpp Index:

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

baloghadamsoftware accepted this revision. baloghadamsoftware added a comment. This revision is now accepted and ready to land. Now it looks good to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81761/new/ https://reviews.llvm.org/D81761

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 updated this revision to Diff 274476. njames93 added a comment. Moved docs into target check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://reviews.llvm.org/D82825 Files:

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang/test/Sema/init-ref-c.c:8 +} \ No newline at end of file riccibruno wrote: > I think it would be better to name this test `varargs-arm.c` since this bug > can only happen

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 updated this revision to Diff 274473. njames93 added a comment. Renamed new option to WarnOnConditionVariables Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82824/new/ https://reviews.llvm.org/D82824 Files:

[clang] 9945bd5 - Add Metadata to Transformer tooling

Author: Andy Soffer Date: 2020-06-30T15:03:07Z New Revision: 9945bd5911636e7f821ac82fdcf8fdb22126e7dc URL: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc DIFF: https://github.com/llvm/llvm-project/commit/9945bd5911636e7f821ac82fdcf8fdb22126e7dc.diff LOG:

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/ConfigProvider.h:47 + /// This always produces a usable compiled fragment (errors are recovered). + explicit CompiledFragment(Fragment, DiagnosticCallback); +

[PATCH] D82677: [Clang] Handle AIX Include management in the driver

daltenty added inline comments. Comment at: clang/test/Driver/aix-toolchain-include.cpp:1 +// Tests that aix toolchain adds system includes to the search path + nit: aix->AIX nit: period at end of comment. Comment at:

[PATCH] D81272: [clang-tidy] New check `misc-redundant-condition`

baloghadamsoftware added a comment. True positive confirmed in //PostGreS//: Mailing List Archive . It is fixed by now, so you cannot see it on the link in my previous comment anymore.

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd285f29317d6: [AST][RecoveryExpr] Avoid spurious missing typename diagnostic when the NNS… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall updated this revision to Diff 274470. sammccall marked an inline comment as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82612/new/ https://reviews.llvm.org/D82612 Files:

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + balazske

[PATCH] D82631: [AST][RecoveryAST] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

hokein updated this revision to Diff 274463. hokein added a comment. rename the test file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82631/new/ https://reviews.llvm.org/D82631 Files: clang/include/clang/AST/NestedNameSpecifier.h

[PATCH] D82626: [CodeComplete] Tweak completion for else.

njames93 updated this revision to Diff 274469. njames93 added a comment. Address comments and add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82626/new/ https://reviews.llvm.org/D82626 Files: clang/include/clang/Sema/Sema.h

[PATCH] D82699: [driver][arm64] Set target CPU to A12 for compiler invocations that target Apple Silicon

ab added a comment. In D82699#2118313 , @arphaman wrote: > @t.p.northover @ab I noticed that the use of "apple-a12" doesn't infer the > right target features when we're passing in a11 or older, so that's why my > test file has the `INFER-A12` separate

[PATCH] D82612: [clangd] Config: compile Fragment -> CompiledFragment -> Config

sammccall marked 8 inline comments as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/CMakeLists.txt:41 + ConfigCompile.cpp ConfigYAML.cpp Diagnostics.cpp hokein wrote: > sammccall wrote: > > hokein wrote: > > > we have a few

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Other than the documentation and settling on the option name in the parent revision, I think this LGTM (the changes will be mechanical and can be done without further review

[PATCH] D82568: [clang][CrossTU] Invalidate parent map after get cross TU definition.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/CrossTU/CrossTranslationUnit.cpp:723 + // Parent map is invalidated after changing the AST. + ToDecl->getASTContext().getParentMapContext().clear(); + martong

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

Szelethus updated this revision to Diff 274466. Szelethus added a comment. Revert changes to plugins and to the related tests, allow the `example` package to bypass the new restriction. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81761/new/ https://reviews.llvm.org/D81761 Files:

[clang] d285f29 - [AST][RecoveryExpr] Avoid spurious 'missing typename' diagnostic when the NNS contains errors.

Author: Haojian Wu Date: 2020-06-30T16:18:32+02:00 New Revision: d285f29317d6086e9ab941730f1ee5a468196a4e URL: https://github.com/llvm/llvm-project/commit/d285f29317d6086e9ab941730f1ee5a468196a4e DIFF: https://github.com/llvm/llvm-project/commit/d285f29317d6086e9ab941730f1ee5a468196a4e.diff

[libunwind] 70f6389 - [runtimes] Rename newformat to just format, now that the old format has been removed

Author: Louis Dionne Date: 2020-06-30T10:10:30-04:00 New Revision: 70f6389257a85a8fa7f128a05a1ccbd0dbba191c URL: https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c DIFF: https://github.com/llvm/llvm-project/commit/70f6389257a85a8fa7f128a05a1ccbd0dbba191c.diff

[PATCH] D82771: [ASTMatcher] Fix a performance regression: memorize the child match.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f865246a817: [ASTMatcher] Fix a performance regression: memorize the child match. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if`` statement that is used in the ``else``

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr2 added reviewers: ymandel, eduucaldas. gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at:

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus marked 6 inline comments as done. Szelethus added a comment. In D82585#2122634 , @balazske wrote: > It looks like that the dependency manipulation and computation functions I guess there are two ways of looking at this: - CheckerRegistry only

[PATCH] D82875: Added tests for RecursiveASTVisitor for AST nodes that are special cased

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Callbacks.cpp:398 -TEST(RecursiveASTVisitor, StmtCallbacks_TraverseBinaryOperator) { +TEST(RecursiveASTVisitor,

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

riccibruno added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4539 +if (CXXRecordDecl *T2RecordDecl = +dyn_cast(T2RecordType->getDecl())) { + const auto = T2RecordDecl->getVisibleConversionFunctions(); ArcsinX wrote: > riccibruno

[PATCH] D82736: [clangd] Rename FS.view(None) to FS.viewWithDefaultCWD()

Quuxplusone abandoned this revision. Quuxplusone added a comment. Superseded by D82793 . :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82736/new/ https://reviews.llvm.org/D82736

[PATCH] D82706: [ASTMatchers] Enhanced support for matchers taking Regex arguments

aaron.ballman added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:1952 +std::shared_ptr createAndVerifyRegex(StringRef Regex, + llvm::Regex::RegexFlags Flags, Is there a

[PATCH] D82562: Implement AVX ABI Warning/error

erichkeane updated this revision to Diff 274450. erichkeane marked an inline comment as done. erichkeane added a comment. As @craig.topper suggested, extract the four lookups into 2 bool instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82562/new/ https://reviews.llvm.org/D82562

[clang] 9f86524 - [ASTMatcher] Fix a performance regression: memorize the child match.

Author: Haojian Wu Date: 2020-06-30T15:43:51+02:00 New Revision: 9f865246a81759cdcb056c883e6f92fe6693b3d3 URL: https://github.com/llvm/llvm-project/commit/9f865246a81759cdcb056c883e6f92fe6693b3d3 DIFF: https://github.com/llvm/llvm-project/commit/9f865246a81759cdcb056c883e6f92fe6693b3d3.diff

[PATCH] D82793: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

This revision was automatically updated to reflect the committed changes. Closed by commit rG72568984b804: [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension… (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D82793?vs=274181=274451#toc

[PATCH] D82291: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

This revision was automatically updated to reflect the committed changes. Closed by commit rG05c479491c1d: Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB (authored by serge-sans-paille). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + aaron.ballman wrote: >

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:74 + + When `true`, The check will attempt to refactor a variable defined inside + the condition of the ``if``

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

balazske added a comment. It looks like that the dependency manipulation and computation functions, and the checker and option add functions can be member of `CheckerRegistryData`. It would be a bit more simple (no `Data.` call), and these belong naturally to there. Comment

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. dang edited the summary of this revision. Keep track of -fansi-escape-codes in DiagnosticOptions and move the option to the new option parsing system.

[PATCH] D82585: [analyzer][NFC] Move the data structures from CheckerRegistry to the Core library

Szelethus updated this revision to Diff 274445. Szelethus added a comment. Fixes according to reviewer comments! edit: from @gamesh411. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82585/new/ https://reviews.llvm.org/D82585 Files:

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn added a comment. Ping. I'm really hoping to get this into 11. Otherwise we're going multiple releases with options that people already use causing crashes on most architectures. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952

[clang] 05c4794 - Make it possible for client code to consume CLANG_LINK_CLANG_DYLIB

Author: serge-sans-paille Date: 2020-06-30T15:13:53+02:00 New Revision: 05c479491c1d3236cae4eccaa3fcd2794598522c URL: https://github.com/llvm/llvm-project/commit/05c479491c1d3236cae4eccaa3fcd2794598522c DIFF:

[clang-tools-extra] 7256898 - [clangd] Suppress GCC -Woverloaded-virtual by renaming ThreadsafeFS extension point

Author: Sam McCall Date: 2020-06-30T15:06:15+02:00 New Revision: 72568984b8040fa8de70a6b4f9c63b6a5aac8d3f URL: https://github.com/llvm/llvm-project/commit/72568984b8040fa8de70a6b4f9c63b6a5aac8d3f DIFF: https://github.com/llvm/llvm-project/commit/72568984b8040fa8de70a6b4f9c63b6a5aac8d3f.diff

[PATCH] D82824: [clang-tidy] Added option to readability-else-after-return

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/readability-else-after-return.rst:67 + + When `true`, Emit a warning for cases where the check can't output a + Fix-It. These can occur with declarations inside the ``else`` branch

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-else-after-return.rst:3 +.. meta:: + :http-equiv=refresh: 5;URL=readability-else-after-return.html + Hmmm, this means users have five seconds to read the text below

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720

[PATCH] D82815: [clang-tidy] Sanity checks in ClangTidyTest header.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM (the harbormaster failure looks unrelated to your changes from what I can tell) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82823: canonicalize macOS 10.16 availability to macOS 11 while preserving uses of if @available macOS 10.16

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/ExprObjC.h:1719-1721 + VersionTuple getVersion() { return VersionToCheck.Version; } + VersionTuple getVersionAsWritten() { return VersionToCheck.SourceVersion; } Any reason these

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro updated this revision to Diff 274433. djtodoro added a comment. - Add the Driver test - Remove the old high level test in order to avoid troubles when someone updates an LLVM pass with the impact on Debugify output (e.g. a new debug info bugs) - clang-formatted CHANGES SINCE LAST

[PATCH] D82733: [clang][docs] Add note about using `-flto` with `-g` on macOS

phil-blain added a comment. Great, thanks ! Note that I don't have commit access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82733/new/ https://reviews.llvm.org/D82733 ___ cfe-commits mailing list

[PATCH] D82547: [Debugify] Expose debugify (original mode) as CC1 option

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: clang/test/DebugInfo/debugify-each-original.c:16 +// CHECK: Force set function attributes: {{.*}} +// CHECK-NEXT: Infer set function attributes: {{.*}} +// CHECK-NEXT: Interprocedural Sparse

[PATCH] D82729: [clangd] Make sure headers are available in FS inside FindSymbolsTests

sammccall added a comment. In D82729#2121999 , @kadircet wrote: > Yes it does, but tests that I updated are also adding a "foo.cpp" file, which > tries to include some headers. Those headers can only be retrieved from FS > and not from the dirty buffer

<    1   2   3   >