[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, fghanim, JonChesterfield, grokos, AndreyChurbanov, ye-luo, tianshilei1992, ggeorgakoudis. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, guansong, bollu, yaxunl, jholewinski. Herald added projects: clang, OpenMP,

[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. GCC obtained -fdebug-prefix-map first, then r256847 added both -fmacro-prefix-map and -ffile-prefix-map. GCC doesn't have -fcoverage-prefix-map and I saw your https://github.com/apple/swift/pull/32416 However, do we really need one new -f*-prefix-map for every feature?

[PATCH] D83154: clang: Add -fcoverage-prefix-map

keith added a comment. I originally implemented this behavior behind `-fdebug-prefix-map` but there was some pushback, more context: https://lists.llvm.org/pipermail/cfe-dev/2020-June/065668.html Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83154

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened added a comment. In D83004#2134303 , @greened wrote: > > I don't particularly like this mode dichotomy but unifying it would > necessitate updating a whole lot of clang tests. Axtually that's not strictly true, It would just change the tests

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

greened marked an inline comment as done. greened added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser

[clang] 0c6b6e2 - [PowerPC] Implement Vector Splat Immediate Builtins in Clang

Author: Biplob Mishra Date: 2020-07-06T20:29:33-05:00 New Revision: 0c6b6e28e70c06a3cb4704d2d8f90829a689e230 URL: https://github.com/llvm/llvm-project/commit/0c6b6e28e70c06a3cb4704d2d8f90829a689e230 DIFF: https://github.com/llvm/llvm-project/commit/0c6b6e28e70c06a3cb4704d2d8f90829a689e230.diff

[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c6b6e28e70c: [PowerPC] Implement Vector Splat Immediate Builtins in Clang (authored by biplmish, committed by lei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D82617: Disable GCC's -Woverloaded-virtual, which has false positives.

dblaikie added a comment. In D82617#2119394 , @sammccall wrote: > Abandoning, we'll do this in clangd or find an acceptable way to silence it > (see D82736 ). > > In D82617#2119144

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel, echristo, erichkeane, LuoYuanke, LiuChen3, FreddyYe, xiangzhangllvm. Herald added subscribers: jfb, hiraditya. Herald added a project: LLVM. Previously we had to specify the forward and backwards feature dependenci

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

craig.topper updated this revision to Diff 275883. craig.topper added a comment. Drop two header includes I was using for debugging CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 Files: clang/lib/Basic/Targets/X86.cpp clang/lib/Basic/Target

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Works for me :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83273/new/ https://reviews.llvm.org/D83273 ___ cfe-commits mailing lis

[PATCH] D81751: [SemaObjC] Fix a -Wobjc-signed-char-bool false-positive with binary conditional operator

ahatanak added a comment. This looks good to me. Comment at: clang/lib/Sema/SemaChecking.cpp:11825 + Expr *TrueExpr = E->getTrueExpr(); + if (isa(E)) Can you use `BinaryConditionalOperator::getCommon` here? CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275885. oontvoo added a comment. Dont skip checking even for templated type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp cl

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

rriddle accepted this revision. rriddle added a comment. Approval for anything MLIR related. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83087/new/ https://reviews.llvm.org/D83087 ___ cfe-commits mai

[PATCH] D83111: [X86-64] Support Intel AMX Intrinsic

This revision was automatically updated to reflect the committed changes. Closed by commit rG939d8309dbd4: [X86-64] Support Intel AMX Intrinsic (authored by xiangzhangllvm). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/

[clang] 939d830 - [X86-64] Support Intel AMX Intrinsic

Author: Xiang1 Zhang Date: 2020-07-07T10:13:40+08:00 New Revision: 939d8309dbd4ee6cf6e9ef3e8ea26df008b006b4 URL: https://github.com/llvm/llvm-project/commit/939d8309dbd4ee6cf6e9ef3e8ea26df008b006b4 DIFF: https://github.com/llvm/llvm-project/commit/939d8309dbd4ee6cf6e9ef3e8ea26df008b006b4.diff

[PATCH] D83111: [X86-64] Support Intel AMX Intrinsic

xiangzhangllvm added a comment. In D83111#2134747 , @craig.topper wrote: > LGTM with all instances of "pointer point" replace with just "pointer" Done it in commit. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D83004: [UpdateCCTestChecks] Include generated functions if asked

jdoerfert added inline comments. Comment at: llvm/utils/update_cc_test_checks.py:133 + parser.add_argument('--include-generated-funcs', action='store_true', + help='Output checks for functions not in source') parser.add_argument('tests', nargs='+') --

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:2414 +assert(PreferredAlign >= ABIAlign && + "PreferredAlign is at least as large as ABIAlign."); +return PreferredAlign; Minor nit: s/is/should be/; ==

[PATCH] D83087: DomTree: remove explicit use of DomTreeNodeBase::iterator

kuhar accepted this revision. kuhar added a comment. LGTM modulo accidental formatting changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83087/new/ https://reviews.llvm.org/D83087 ___ cfe-commits

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. 🎉! I vaguely remember that we talked offline about a few nasty test cases that with casts and overflows, would it make sense to add them? Like, even if they don't pass yet, they may prove valuable.

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:202-219 +ProgramStateRef +SmartPtrModeling::updateTrackedRegion(const CallEvent &Call, CheckerContext &C, + const MemRegion *ThisValRegion) const { +

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275895. oontvoo added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivia

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275898. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

oontvoo updated this revision to Diff 275899. oontvoo added a comment. updated diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83263/new/ https://reviews.llvm.org/D83263 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/attr-trivial-

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1910 + +auto upgradeAlignmentIfQualified = [&](const BuiltinType *BTy) { + if (BTy->getKind() == BuiltinType::Double || "Qualified" is a term of art in the co

[PATCH] D83154: clang: Add -fcoverage-prefix-map

MaskRay added a comment. -fdebug-prefix-map does not make sense to me because coverage is not debug info. I am on the fence whether we need -fcoverage-prefix-map. I created https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96092 (Should --coverage respect -ffile-prefix-map?) Comme

[PATCH] D83263: [WIP] Clang crashed while checking for deletion of copy and move ctors

rsmith added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:9733 return true; return false; }; This is not the right fallback answer if the class is a dependent type -- we don't yet know if there's a non-deleted copy or move constru

[PATCH] D83273: [X86] Remove the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f3d698f2af: [X86] Move the feature dependency handling in X86TargetInfo… (authored by craig.topper). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D83273?vs=275883&i

[PATCH] D83281: [OpenMP] Allow traits for the OpenMP context selector `isa`

jdoerfert created this revision. jdoerfert added reviewers: jhuber6, fghanim, JonChesterfield, grokos, ggeorgakoudis, ABataev. Herald added subscribers: llvm-commits, sstefan1, guansong, bollu, hiraditya, yaxunl. Herald added projects: clang, LLVM. NOTE: The changes are fairly mechanical overall

[clang] 16f3d69 - [X86] Move the feature dependency handling in X86TargetInfo::setFeatureEnabledImpl to a table based lookup in X86TargetParser.cpp

Author: Craig Topper Date: 2020-07-06T23:14:02-07:00 New Revision: 16f3d698f2afbbea43e0c3df81df6f2a640ce806 URL: https://github.com/llvm/llvm-project/commit/16f3d698f2afbbea43e0c3df81df6f2a640ce806 DIFF: https://github.com/llvm/llvm-project/commit/16f3d698f2afbbea43e0c3df81df6f2a640ce806.diff

[clang] 0882c9d - [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values

Author: Saiyedul Islam Date: 2020-07-07T06:36:25Z New Revision: 0882c9d4fc49858338c9655154f1ad8357a8e516 URL: https://github.com/llvm/llvm-project/commit/0882c9d4fc49858338c9655154f1ad8357a8e516 DIFF: https://github.com/llvm/llvm-project/commit/0882c9d4fc49858338c9655154f1ad8357a8e516.diff LOG

[PATCH] D83121: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values

This revision was automatically updated to reflect the committed changes. Closed by commit rG0882c9d4fc49: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

<    1   2   3