[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276009. dang added a comment. Rebase on top of some changes to parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 276008. dang added a comment. Make mergers use values directly instead of constant references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276007. dang added a comment. Make mergers use values directly instead of constant references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83211 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83298 Files: clang/include/clang

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2135081 , @Hahnfeld wrote: > This is definitely not NFC and breaks API compatibility (but apparently > nobody cares anymore?). This is the device RTL. I am not aware we (want to) keep the API stable. If we are, I'm

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

xazax.hun accepted this revision. xazax.hun added a comment. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 ___ cfe-commits mailing list cfe-comm

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

sammccall marked 5 inline comments as done. sammccall added inline comments. Comment at: .gitignore:57 +# clangd index. (".clangd" is a config file now, thus trailing slash) +.clangd/ +.cache kadircet wrote: > why do we still need this ? i thought index (and othe

[PATCH] D83296: [clang-format] Add a MacroExpander.

klimek created this revision. klimek added a reviewer: sammccall. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. The MacroExpander allows to expand simple (non-resursive) macro definitions from a macro identifier token and macro arguments. It annotates the tokens wit

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, gamesh411, martong, balazske. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xaza

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan added a subscriber: danilaml. ebevhan added a comment. In D62574#2133160 , @danilaml wrote: > What are the remaining roadblocks left before this patch can be merged? I'm > interested in having a target-specific way to define the allowed > explici

[clang-tools-extra] 3b1e3d2 - [clang-tidy] Fix an unused-raii check crash on objective-c++.

Author: Haojian Wu Date: 2020-07-07T13:36:20+02:00 New Revision: 3b1e3d22735b37eea3ce52d655009f5cd4ad2262 URL: https://github.com/llvm/llvm-project/commit/3b1e3d22735b37eea3ce52d655009f5cd4ad2262 DIFF: https://github.com/llvm/llvm-project/commit/3b1e3d22735b37eea3ce52d655009f5cd4ad2262.diff LO

[PATCH] D83293: [clang-tidy] Fix an unused-raii check crash on objective-c++.

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b1e3d22735b: [clang-tidy] Fix an unused-raii check crash on objective-c++. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83293/new/ h

[PATCH] D83293: [clang-tidy] Fix an unused-raii check crash on objective-c++.

hokein updated this revision to Diff 275994. hokein marked an inline comment as done. hokein added a comment. fix names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83293/new/ https://reviews.llvm.org/D83293 Files: clang-tools-extra/clang-tidy

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

ABataev added a comment. In D83268#2135081 , @Hahnfeld wrote: > This is definitely not NFC and breaks API compatibility (but apparently > nobody cares anymore?). +1. Better to introduce new entry points and mark these ones as deprecated. Repository:

[PATCH] D81552: [ASTMatchers] Added hasDirectBase Matcher

njames93 added a comment. I've removed the hasClass changes as they dont entirely belong in here and weren't well received. Now with just the hasDirectBase this should be in a good state. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81552/new/ h

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

njames93 updated this revision to Diff 275991. njames93 added a comment. Removed all hasClass related changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81552/new/ https://reviews.llvm.org/D81552 Files: clang/docs/LibASTMatchersReference.htm

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

ebevhan created this revision. ebevhan added reviewers: rjmccall, leonardchan, bjope. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds codegen to Clang for fixed-point shift operations. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83294

[PATCH] D83293: [clang-tidy] Fix an unused-raii check crash on objective-c++.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-unused-raii-crash.mm:3 + +struct Foo { + ~Foo() {} Foo => CxxClass ABC => ObjcC

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:149 + case OO_PipePipe: + // Less common binary operators + case OO_ArrowStar: Please drop

[PATCH] D83293: [clang-tidy] Fix an unused-raii check crash on objective-c++.

hokein created this revision. hokein added a reviewer: gribozavr2. Herald added a subscriber: xazax.hun. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83293 Files: clang-tools-extra/clang-tidy/bugprone/UnusedRaiiCheck.cpp clang-tools-extra/tes

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

kadircet added inline comments. Comment at: .gitignore:57 +# clangd index. (".clangd" is a config file now, thus trailing slash) +.clangd/ +.cache why do we still need this ? i thought index (and other caches) would reside in `.cache` ? Commen

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 275983. atrosinenko added a comment. Fix path separators in unit test on Windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files: clang/include/clang/Driver

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko updated this revision to Diff 275981. vsavchenko added a comment. Get rid of 'isZero' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko marked 8 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:506 + APSIntType Type(Int); + return Int == Type.getZeroValue(); +} xazax.hun wrote: > Does the semantics if this

[PATCH] D83290: [clangd] Enable async preambles by default

kadircet created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. We've been testing this internally for a couple weeks now and it seems to be stable enough. Let's flip the flag before branch cu

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

sammccall added a comment. What's the rationale/motivation for this? I'd expect this to break a lot of subtle assumptions, because the invariant "nothing can be dependent without being instantiation-dependent" is a useful one. It also doesn't seem correct from first principles. My mental model

[PATCH] D83218: Hand Allocator and IdentifierTable into FormatTokenLexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2a61397607: Hand Allocator and IdentifierTable into FormatTokenLexer. (authored by klimek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83218/new/ https

[clang] 8c2a613 - Hand Allocator and IdentifierTable into FormatTokenLexer.

Author: Manuel Klimek Date: 2020-07-07T11:56:34+02:00 New Revision: 8c2a613976075368a1f6e3ac3c9c8b1927b465ec URL: https://github.com/llvm/llvm-project/commit/8c2a613976075368a1f6e3ac3c9c8b1927b465ec DIFF: https://github.com/llvm/llvm-project/commit/8c2a613976075368a1f6e3ac3c9c8b1927b465ec.diff

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

sammccall added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType here we're splitting the type (e.g. int&&) into a type + VK, and passing both to

[PATCH] D83218: Hand Allocator and IdentifierTable into FormatTokenLexer.

klimek updated this revision to Diff 275964. klimek added a comment. Address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83218/new/ https://reviews.llvm.org/D83218 Files: clang/lib/Format/FormatTokenLexer.cpp clang/lib/Format

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

sammccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:6229 +/// +/// FIXME: RecoveryExpr is C++ only, make it work for C by supporting dependence +/// mechanism for C language in clang. this could be a little more specific (e.g. what does C

[PATCH] D83212: [Fixed Point] Add fixed-point shift operations and consteval.

ebevhan updated this revision to Diff 275962. ebevhan added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83212/new/ https://reviews.llvm.org/D83212 Files: clang/include/clang/Basic/FixedPoint.h clang/lib/AST/ExprConstant.

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:1254 +// sufficient. +return S1->get() == S2->get() && + S1->get() == S2->get(); xazax.hun wrote: > Sorry, but I am a bit confused here.

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:506 + APSIntType Type(Int); + return Int == Type.getZeroValue(); +} Does the semantics if this differ from ` llvm::APInt::isNullValue`? Comm

[PATCH] D80202: [ASTMatchers] Performance optimization for memoization

sammccall added inline comments. Comment at: clang/lib/ASTMatchers/ASTMatchFinder.cpp:902 // Maps (matcher, node) -> the match result for memoization. - typedef std::map MemoizationMap; + typedef std::map> MemoizationMap; MemoizationMap ResultCache; klime

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 275959. atrosinenko added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files: clang/include/clang/Driver/Options.td c

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko marked 3 inline comments as done. atrosinenko added inline comments. Comment at: clang/lib/Driver/ToolChains/MSP430.cpp:154 + SmallString<128> MultilibInclude(GCCInstallation.getInstallPath()); + llvm::sys::path::append(MultilibInclude, "include"); ---

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko updated this revision to Diff 275957. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/ https://reviews.llvm.org/D83286 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko updated this revision to Diff 275956. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 Files: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVi

[PATCH] D82381: [analyzer] Introduce small improvements to the solver infra

vsavchenko updated this revision to Diff 275955. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82381/new/ https://reviews.llvm.org/D82381 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedCons

[PATCH] D83190: [analyzer] Model iterator random incrementation symmetrically

gamesh411 updated this revision to Diff 275954. gamesh411 added a comment. fix tidy diagnostic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83190/new/ https://reviews.llvm.org/D83190 Files: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

hans added inline comments. Comment at: llvm/lib/Transforms/IPO/PassManagerBuilder.cpp:170 PassManagerBuilder::PassManagerBuilder() { OptLevel = 2; Oh, just noticed: I think CallGraphProfile should be initialized along with the other flags here. ==

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, ASDenysPetrov, xazax.hun, Szelethus. Herald added subscribers: cfe-commits, martong, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. This co

[PATCH] D83055: [clang][Driver] Fix tool path priority test failure

DavidSpickett updated this revision to Diff 275950. DavidSpickett added a comment. - Removed \ from regex, not needed for POSIX syntax. - Reflowed text in commit description. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83055/new/ https://reviews.

[PATCH] D82445: [analyzer][solver] Track symbol equivalence

vsavchenko updated this revision to Diff 275949. vsavchenko added a comment. Fix comments and add a test for downcasts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82445/new/ https://reviews.llvm.org/D82445 Files: clang/include/clang/StaticAnal

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:281 + Range.startCharacter = Symbol.range.start.character; + Range.endLine = Symbol.range.end.line; + Range.endCharacter = Symbol.range.end.character; sammccall wrote: > kboby

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG9a1a7d888b53: [SVE] Add more warnings checks to clang and LLVM SVE tests (authored by david-arm). Repository: rG LLVM G

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev updated this revision to Diff 275945. kbobyrev added a comment. Don't convert test paths to system native, UNIX native is good enough. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 Files: clang

[PATCH] D83218: Hand Allocator and IdentifierTable into FormatTokenLexer.

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/FormatTokenLexer.h:121 llvm::Regex MacroBlockEndRegex; + llvm::SpecificBumpPtrAllocator &Allocator; this seems a

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

nikic requested changes to this revision. nikic added inline comments. This revision now requires changes to proceed. Comment at: llvm/test/Other/opt-O2-pipeline.ll:289 +; CHECK-NEXT: Branch Probability Analysis +; CHECK-NEXT: Block Frequency Analysis ; CHECK-NEX

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 added a comment. The checker has been updated, the comments and the logic polished. I would still take a stab at this being a ClangSa checker (as opposed to being a Tidy check). What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275942. eduucaldas added a comment. Unifying user defined binary operator tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/lib/Tooling/Syntax/Bui

[PATCH] D82943: [SVE] Add more warnings checks to clang and LLVM SVE tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a1a7d888b53: [SVE] Add more warnings checks to clang and LLVM SVE tests (authored by david-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82943/new/ h

[clang] 9a1a7d8 - [SVE] Add more warnings checks to clang and LLVM SVE tests

Author: David Sherwood Date: 2020-07-07T09:33:20+01:00 New Revision: 9a1a7d888b53ebe5a934a8193de37da86e276f1e URL: https://github.com/llvm/llvm-project/commit/9a1a7d888b53ebe5a934a8193de37da86e276f1e DIFF: https://github.com/llvm/llvm-project/commit/9a1a7d888b53ebe5a934a8193de37da86e276f1e.diff

[PATCH] D83233: [clangd] Enable reading config from files by default.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:700 +ProviderStack.push_back( +config::Provider::fromAncestorRelativeYAMLFiles(".clangd", TFS)); +llvm::SmallString<256> UserConfig; should we first update th

[PATCH] D83233: [clangd] Enable reading config from files by default.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LG from my side Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83233/new/ https://reviews.llvm.org/D83233

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 marked 8 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:42 +BugType & +SufficientSizeArrayIndexingChecker::GetBugTypeForType(const QualType T) const { + auto BT = BugTypeCa

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 marked 4 inline comments as done. gamesh411 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:622 + } // end: "alpha.cplusplus" NoQ wrote: > What makes this checker C++-specific? All your tests are in plain C.

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

hans accepted this revision. hans added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83013/new/ https://reviews.llvm.org/D83013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

hans added a comment. > I don't want to block this patch, but I do agree with Eric's point. We > *really* want to focus more on the switch then invest into more LPM infra. > Short term resolutions to unblock folks, with the best split possible, sure, > keeping in mind they'll need to be cleaned

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas added a comment. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:741 bool WalkUpFromIntegerLiteral(IntegerLiteral *S) { +if (S->getLocation().isInvalid()) + return true; gribozavr2 wrote: > WDYT about overriding `TraverseCXXOperatorCa

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275940. eduucaldas marked 9 inline comments as done. eduucaldas added a comment. Answering comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954 Files: clang/li

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 updated this revision to Diff 275938. gamesh411 added a comment. fix detection logic fix license header add missing warning to test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69318/new/ https://reviews.llvm.org/D69318 Files: clang/i

[PATCH] D82740: [libclang]: check validity before visiting Stmt node

milianw abandoned this revision. milianw added a comment. great, thanks for the help - please land the other change then Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82740/new/ https://reviews.llvm.org/D82740 ___

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett added a comment. I saw similar behaviour on Mac OSX and fixed that in the reland. (https://reviews.llvm.org/rGd6efc9811646edbfe13f06c2676fb469f1c155b1) Are you still seeing a failure with that applied? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D82728: [clang] Add -Wsuggest-override

dblaikie added a comment. In D82728#2135142 , @logan-5 wrote: > Glad this is generating some discussion. For my $0.02, I would also > (obviously) love to be able to enable this warning on all the codebases I > work on, and this patch was born out of a di

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. Glad this is generating some discussion. For my $0.02, I would also (obviously) love to be able to enable this warning on all the codebases I work on, and this patch was born out of a discussion on the C++ Slack with another user who had found this warning very useful i

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

MyDeveloperDay added a comment. https://reviews.llvm.org/D79773#2131680 has something to do with your .clang-format file, the base LLVM style seems fine. template concept bool EqualityComparable = requires(T a, T b) { { a == b } -> bool; }; vs template concept bool EqualityCo

[PATCH] D82629: [libclang] Fix crash when visiting a captured VLA.

ckandeler added a comment. In D82629#2134521 , @jkorous wrote: > @ckandeler do you have commit access or do you want me to land the patch? I do not, so it'd be great if you could do it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D82954: Fix crash on overloaded postfix unary operators due to invalid SourceLocation

eduucaldas updated this revision to Diff 275930. eduucaldas added a comment. `->*` and `,` are binary operators. Unit tests covering most of the operator kinds Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82954/new/ https://reviews.llvm.org/D82954

[PATCH] D83099: [clangd] Store index in '.cache/clangd/index' instead of '.clangd/index'

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Comment at: .gitignore:58 +.clangd/ +.cache # static analyzer regression testing project files I'm afraid that many projects have t

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

kbobyrev updated this revision to Diff 275929. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Hide FoldingRanges feature behind the flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82436/new/ https://reviews.llvm.org/D82436

[PATCH] D83121: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values

This revision was automatically updated to reflect the committed changes. Closed by commit rG0882c9d4fc49: [AMDGPU] Change Clang AMDGCN atomic inc/dec builtins to take unsigned values (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D83111: [X86-64] Support Intel AMX Intrinsic

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG939d8309dbd4: [X86-64] Support Intel AMX Intrinsic (authored by xiangzhangllvm). Herald added a project: clang. Herald add

[PATCH] D82520: [Power10] Implement Vector Splat Immediate Builtins in LLVM/Clang

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rG0c6b6e28e70c: [PowerPC] Implement Vector Splat Immediate Builtins in Clang (authored by biplmish, committed by lei). Her

[PATCH] D83233: [clangd] Enable reading config from files by default.

hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:436 +"Project config is from a .clangd file in the project directory.\n" +"User config is from clangd/config.yaml in the following directories:\n" +"\tWindows: %USERPRO

[PATCH] D83183: [clang] Rework how and when APValues are dumped

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf63e3ea558bb: [clang] Rework how and when APValues are dumped (authored by riccibruno). Changed prior to commit: https:

[PATCH] D82821: [WebAssembly] Added 64-bit memory.grow/size/init/copy/fill

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG16d83c395a1f: [WebAssembly] Added 64-bit memory.grow/size/copy/fill (authored by aardappel). Herald added a project: clang

[PATCH] D83084: DomTree: Remove the releaseMemory() method

This revision was automatically updated to reflect the committed changes. Closed by commit rG723a44c9b5d6: DomTree: Remove the releaseMemory() method (authored by nhaehnle). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83084/new/ https://reviews.ll

[PATCH] D82425: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty function body.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG054704082b46: [SemaCXX] Fix false positive of -Wuninitialized-const-reference in empty… (authored by zequanwu). Repositor

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG39d2ae0afb23: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking… (authored by kpn). Changed pr

[PATCH] D83114: [clang] Fix the incorrect dependence bits for DependentExtIntType.

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd9a241f1650: [clang] Fix the incorrect dependence bits for DependentExtIntType. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83114/ne

[PATCH] D82825: [clang-tidy] Added alias llvm-else-after-return.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc3c693b617f: [clang-tidy] Added alias llvm-else-after-return. (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82825/new/ https://revi

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe80b81d1cbf8: [Support] Fix formatted_raw_ostream for UTF-8 (authored by ostannard). Repository: rG LLVM Github Monorep

[PATCH] D81750: [analyzer] Don't allow hidden checkers to emit diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfd6b4b811aa: [analyzer] Don't allow hidden checkers to emit diagnostics (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D81750?vs=270447&id=275607#toc Repository: rG LLVM

[PATCH] D82921: Removed a RecursiveASTVisitor feature to visit operator kinds with different methods

This revision was automatically updated to reflect the committed changes. Closed by commit rG5689b38c6a42: Removed a RecursiveASTVisitor feature to visit operator kinds with different… (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D82921?vs=275064&id=275601#toc Rep

[PATCH] D78126: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2956076976c: [analyzer][NFC] Don't allow dependency checkers to emit diagnostics (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D78126?vs=270372&id=275605#toc Repository:

[PATCH] D81761: [analyzer] Force dependency checkers to be hidden

This revision was automatically updated to reflect the committed changes. Closed by commit rG690ff37a2869: [analyzer] Force dependency checkers to be hidden (authored by Szelethus). Changed prior to commit: https://reviews.llvm.org/D81761?vs=274466&id=275598#toc Repository: rG LLVM Github Mo

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 updated this revision to Diff 275928. logan-5 marked 6 inline comments as done. logan-5 added a comment. Addressed some feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82728/new/ https://reviews.llvm.org/D82728 Files: clang/inclu

[PATCH] D82442: [Coroutines] Warning if the return type of coroutine_handle::address is not void*

This revision was automatically updated to reflect the committed changes. Closed by commit rG8849831d55a2: [Coroutines] Warning if return type of coroutine_handle::address is not void* (authored by ChuanqiXu, committed by junparser). Herald added a project: clang. Herald added a subscriber: cfe-c

[PATCH] D83173: [VE] Correct stack alignment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdf3bda047d5a: [VE] Correct stack alignment (authored by kaz7). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 3cbfe98 - [X86] Merge X86TargetInfo::setFeatureEnabled and X86TargetInfo::setFeatureEnabledImpl. NFC

Author: Craig Topper Date: 2020-07-06T23:54:56-07:00 New Revision: 3cbfe988bc5cd366fb0f62e597f899b489c3834d URL: https://github.com/llvm/llvm-project/commit/3cbfe988bc5cd366fb0f62e597f899b489c3834d DIFF: https://github.com/llvm/llvm-project/commit/3cbfe988bc5cd366fb0f62e597f899b489c3834d.diff

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

Hahnfeld added a comment. This is definitely not NFC and breaks ABI compatibility (but apparently nobody cares anymore). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83268/new/ https://reviews.llvm.org/D83268 __

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/Preprocessor/aarch64-target-features.c:415 // CHECK-BFLOAT: __ARM_FEATURE_BF16_VECTOR_ARITHMETIC 1 - nit: unrelated change

<    1   2   3