[PATCH] D83374: [analyzer][tests] Fix zip unpacking

vsavchenko created this revision. vsavchenko added reviewers: NoQ, xazax.hun. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: rG LLVM Gith

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

gamesh411 marked 7 inline comments as done. gamesh411 added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:27 +: public Checker> { + mutable std::unique_ptr BT; + balazske wrote: > The bug type can be i

[PATCH] D83373: [analyzer][tests] Make test interruption safe

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: clang. Repository: r

[PATCH] D80873: [clang][cmake] Force CMAKE_LINKER for multistage build in case of BOOTSTRAP_LLVM_ENABLE_LLD and MSVC

phosek added inline comments. Comment at: clang/CMakeLists.txt:751 + if(BOOTSTRAP_LLVM_ENABLE_LLD) +if(MSVC AND NOT BOOTSTRAP_CMAKE_SYSTEM_NAME) + set(${CLANG_STAGE}_LINKER -DCMAKE_LINKER=${LLVM_RUNTIME_OUTPUT_INTDIR}/lld-link.exe) I don't understand t

[clang] cfcf8e1 - [analyzer] Silence gcc -Wparentheses warning [NFC]

Author: Mikael Holmen Date: 2020-07-08T10:23:59+02:00 New Revision: cfcf8e17ef537686e03c58921a10593a2b0c4a3d URL: https://github.com/llvm/llvm-project/commit/cfcf8e17ef537686e03c58921a10593a2b0c4a3d DIFF: https://github.com/llvm/llvm-project/commit/cfcf8e17ef537686e03c58921a10593a2b0c4a3d.diff

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar). Changed prio

[clang] 20e271a - [analyzer] Warning for default constructed unique_ptr dereference

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-07-08T09:51:02+02:00 New Revision: 20e271a98de5609e22766e56f9c374b150f06982 URL: https://github.com/llvm/llvm-project/commit/20e271a98de5609e22766e56f9c374b150f06982 DIFF: https://github.com/llvm/llvm-project/commit/20e271a98de5609e22766e56f

[PATCH] D83079: [clang][aarch64] Generate preprocessor macros for -march=armv8.6a+sve.

sdesmalen added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:369 + if (llvm::is_contained(Features, "+v8.6a")) { +if (!llvm::is_contained(Features, "-i8mm") && +!llvm::is_contained(Features, "+noi8mm")) Is this correct an

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

This revision was automatically updated to reflect the committed changes. Closed by commit rG20e271a98de5: [analyzer] Warning for default constructed unique_ptr dereference (authored by vrnithinkumar). Changed prior to commit: https://reviews.llvm.org/D81315?vs=275434&id=276327#toc Repository:

[PATCH] D83233: [clangd] Enable reading config from files by default.

hokein accepted this revision. hokein added a comment. looks like you didn't upload the latest version. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83233/new/ https://reviews.llvm.org/D83233 ___ cfe-

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12944 + Fn->getBeginLoc(), RParenLoc, SubExprs, + ReturnType.isNull() + ? ReturnType sammccall wrote: > here we're splitting the type (e.g. int&&) into a type + VK, and p

[PATCH] D83201: [AST][RecoveryExpr] Fix the value category for recovery expr.

hokein updated this revision to Diff 276325. hokein marked an inline comment as done. hokein added a comment. address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83201/new/ https://reviews.llvm.org/D83201 Files: clang/lib/AST/Expr.cpp

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

JohelEGP added a comment. Ah, that makes sense. The very definition of Allman is to always break before braces. I suppose I'll need to use `BreakBeforeBraces: Custom` and `BraceWrapping:`. I did some testing and noticed that the weird format comes with any of these: BreakBeforeBraces: Custom

[PATCH] D82805: [clang] Fix a crash on passing C structure of incompatible type to function with reference parameter

ArcsinX added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82805/new/ https://reviews.llvm.org/D82805 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 276322. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-extra/

[PATCH] D83371: [clangd] Factor out some helper functions related to heuristic resolution in TargetFinder

nridge updated this revision to Diff 276321. nridge added a comment. Improve patch split Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83371/new/ https://reviews.llvm.org/D83371 Files: clang-tools-extra/clangd/FindTarget.cpp Index: clang-tools-

[PATCH] D82739: Improve heuristic resolution of dependent types in TargetFinder

nridge added a comment. Split out the refactoring into D83371 which this depends on now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739

<    1   2   3