[PATCH] D78760: Check a class doesn't have a dependent type before iterating over its base classes

ahatanak added a comment. Does the updated patch look okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78760/new/ https://reviews.llvm.org/D78760 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

regehr added a comment. > Did you mean to check something like the following? > > define i32 @src(i1 %cond, i32 %x) { > %x2 = freeze i32 %x > %s = select i1 %cond, i32 %x2, i32 undef > ret i32 %s > } > > define i32 @tgt(i1 %cond, i32 %x) { > %x2 = freeze i32 %x > ret

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1263 - // The maximum field alignment overrides base align. + assert(!IsUnion && "Unions cannot have base classes."); + // AIX `power` alignment does not apply the preferred align

[PATCH] D83448: [CodeGen] Emit destructor calls to destruct non-trivial C struct temporaries created by conditional and assignment operators

ahatanak created this revision. ahatanak added a reviewer: rjmccall. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. rdar://problem/64989559 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83448 Files: clang/lib/CodeGen/CGExprAgg.cpp

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

sameerds added a comment. The documentation for HIP __ballot seems to indicate that the user does not have to explicitly specify the warp size. How is that achieved with these new builtins? Can this be captured in a lit test here? https://github.com/ROCm-Developer-Tools/HIP/blob/master/docs/ma

Buildbot numbers for the week of 06/21/2020 - 06/27/2020

Hello everyone, Below are some buildbot numbers for the week of 06/21/2020 - 06/27/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 06/28/2020 - 07/04/2020

Hello everyone, Below are some buildbot numbers for the last week of 06/28/2020 - 07/04/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

michele.scandale created this revision. michele.scandale added reviewers: chandlerc, beanz, zturner. Herald added subscribers: lldb-commits, cfe-commits, MaskRay, aheejin, arichardson, sbc100, mgorny, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Herald added projec

[PATCH] D71124: [RISCV] support clang driver to select cpu

asb added a comment. This has been hanging around for a while, but I think we'd basically agreed this is the right logic. The comments have ended up referring to flags that don't exist on Clang making it a little hard to follow, and I've added a request to slightly expand testing. If you make t

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1208 +// "first (inherited) member". +HandledFirstNonOverlappingEmptyField = true; + We need some sort of `IsFirstNonEmptyBase` to record that the current base

[PATCH] D80802: [RISCV] Upgrade RVV MC to v0.9.

asb added a comment. I've gone through and can't see any obvious issues. I defer to one of the RISC-V Vector extension usual suspects for giving a LGTM on the detail of the altered instructions etc. Once we have that, this looks good to land IMHO. Repository: rG LLVM Github Monorepo CHANGES

[clang] e3e47e8 - [OpenMP] Make complex soft-float functions on the GPU weak definitions

Author: Johannes Doerfert Date: 2020-07-09T01:06:55-05:00 New Revision: e3e47e80355422df2e730cf97a0c80bb6de3915e URL: https://github.com/llvm/llvm-project/commit/e3e47e80355422df2e730cf97a0c80bb6de3915e DIFF: https://github.com/llvm/llvm-project/commit/e3e47e80355422df2e730cf97a0c80bb6de3915e.d

[PATCH] D83436: [clangd] Fix error handling in config.yaml parsing.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks. Comment at: clang-tools-extra/clangd/ConfigYAML.cpp:36 // meaningfully recover (e.g. YAML syntax error broke the stream). // The private parse() helpers follow

[clang] f988846 - Increase DIAG_SIZE_AST as we have hit it.

Author: Douglas Yung Date: 2020-07-08T23:29:47-07:00 New Revision: f9888462cc76fb486161709d88522bd419a89504 URL: https://github.com/llvm/llvm-project/commit/f9888462cc76fb486161709d88522bd419a89504 DIFF: https://github.com/llvm/llvm-project/commit/f9888462cc76fb486161709d88522bd419a89504.diff

[PATCH] D83242: [RFC][BPF] support expr with typedef type for FIELD_EXISTENCE reloc

yonghong-song added a comment. Sounds good. Will try to add support for union/struct type as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83242/new/ https://reviews.llvm.org/D83242 ___ cfe-commi

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

hokein added a comment. In D83419#2140573 , @sammccall wrote: > In D83419#2140311 , @njames93 wrote: > > > I'm not a huge fan of using `error`, maybe `createError`, > > Its definitely out of place in Logger, but t

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276637. eduucaldas marked 4 inline comments as done. eduucaldas added a comment. Add support for {Integer,Float,Char,String}UserDefinedLiteral Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https:/

<    1   2   3