[PATCH] D80263: [HeaderSearch] Fix processing #import-ed headers multiple times with modules enabled.

vsapsai added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80263/new/ https://reviews.llvm.org/D80263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl updated this revision to Diff 276799. avl added a comment. addressed comments: added test for multiple recursive calls, removed duplicated check for operand bundles, simplified and commented tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Previously clangd would jump to forward declarations for protocols and classes instead of the

[PATCH] D83500: [PowerPC][Power10] Implement custom codegen for the vec_replace_elt and vec_replace_unaligned builtins.

amyk created this revision. amyk added reviewers: PowerPC, power-llvm-team, nemanjai, lei. amyk added projects: LLVM, PowerPC, clang. Herald added a subscriber: shchenz. This patch implements custom codegen for the `vec_replace_elt` and `vec_replace_unaligned` builtins. These builtins map to the

[PATCH] D82767: clang-format: Explicitly use python3

arsenm added a comment. In D82767#2141962 , @serge-sans-paille wrote: > In D82767#2132903 , @MyDeveloperDay > wrote: > > > We may not be consistent across all of LLVM > > > > $ find . -name '*.py' -print -exec /

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

nikic accepted this revision. nikic added a comment. LG from my side. New compile-time numbers: https://llvm-compile-time-tracker.com/compare.php?from=0b39d2d75275b80994dac06b7ad05031cbd09393&to=fd070b79e063fff2fad3cd4a467f64dfca83eb90&stat=instructions It's nearly neutral now. =

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

This revision was automatically updated to reflect the committed changes. Closed by commit rG2da9572a9b10: [OPENMP50] extend array section for stride (Parsing/Sema/AST) (authored by cchen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ ht

[clang] 2da9572 - [OPENMP50] extend array section for stride (Parsing/Sema/AST)

Author: cchen Date: 2020-07-09T13:28:51-05:00 New Revision: 2da9572a9b10c8e4d0db2f3267f1a2c0ea31c896 URL: https://github.com/llvm/llvm-project/commit/2da9572a9b10c8e4d0db2f3267f1a2c0ea31c896 DIFF: https://github.com/llvm/llvm-project/commit/2da9572a9b10c8e4d0db2f3267f1a2c0ea31c896.diff LOG: [O

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 276785. Conanap marked 3 inline comments as done. Conanap added a comment. Now depends on D83364 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap added a comment. Also removed unnecessary brackets and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ https://reviews.llvm.org/D82502 ___ cfe-commits mailing list cfe-commit

[PATCH] D82574: Merge TableGen files used for clang options

dmgreen added a comment. Hello Did you mean to remove CC1Options.td too? Otherwise it does not appear to be used any more or this has duplicated the contents. Also can you make sure the new content of Options.td reflects the latest version of CC1Options.td, and that no extra changes have been

[PATCH] D83364: [PowerPC][Power10] Implement Instruction definition and MC Tests for Load and Store VSX Vector with Zero or Sign Extend

lei accepted this revision. lei added a comment. LGTM thx. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83364/new/ https://reviews.llvm.org/D83364 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D82157: Fix crash on `user defined literals`

gribozavr2 added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:737 + Builder.findToken(TokLoc)->text(Context.getSourceManager()); + auto Literal = NumericLiteralParser{TokSpelling, + TokLoc,

[PATCH] D79730: [NFCi] Switch ordering of ParseLangArgs and ParseCodeGenArgs.

plotfi added a subscriber: dexonsmith. plotfi added a comment. In D79730#2030530 , @rjmccall wrote: > I think it makes sense; if nothing else, we're trying to upstream all that > work. @rjmccall Should I still try to land this or should this stuff get p

[PATCH] D79147: Switch to using -debug-info-kind=constructor as default (from =limited)

akhuang updated this revision to Diff 276778. akhuang added a comment. fix one more test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79147/new/ https://reviews.llvm.org/D79147 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driv

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

dokyungs created this revision. Herald added subscribers: Sanitizers, cfe-commits, mgorny. Herald added projects: clang, Sanitizers. libFuzzer intercepts certain library functions such as memcmp/strcmp by defining weak hooks. Weak hooks, however, are called only when other runtimes such as ASan

[clang] fccd29d - Merge TableGen files used for clang options

Author: Daniel Grumberg Date: 2020-07-09T18:28:51+01:00 New Revision: fccd29dddee92ffa7cd8a9adec6e626760538dae URL: https://github.com/llvm/llvm-project/commit/fccd29dddee92ffa7cd8a9adec6e626760538dae DIFF: https://github.com/llvm/llvm-project/commit/fccd29dddee92ffa7cd8a9adec6e626760538dae.dif

[PATCH] D82574: Merge TableGen files used for clang options

This revision was automatically updated to reflect the committed changes. Closed by commit rGfccd29dddee9: Merge TableGen files used for clang options (authored by dang). Changed prior to commit: https://reviews.llvm.org/D82574?vs=273407&id=276775#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D83454: [CMake] Make `intrinsics_gen` dependency unconditional.

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks like a good cleanup. Hope someone with more CMake-fu to confirm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83454/new/ https://review

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276772. eduucaldas added a comment. Nothing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/S

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas marked an inline comment as done. eduucaldas added inline comments. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:736 + auto TokSpelling = + Builder.findToken(TokLoc)->text(Context.getSourceManager()); + auto Literal = NumericLiteralParser{TokSp

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276771. eduucaldas added a comment. nothing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm.org/D82157 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib/Tooling/S

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276770. eduucaldas added a comment. Add support for integer and floating UDL even for raw literal operator and numeric literal operator template Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ http

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

JonChesterfield added a comment. Changing to getGridValue would be useful for sharing parts of this with amdgcn. The aomp toolchain handles codegen for amdgcn by adding if (isAMDGCN) to this file. Until such time as tregions obsoletes this code, I think we should go with layers instead of scatt

[PATCH] D82728: [clang] Add -Wsuggest-override

logan-5 added a comment. Feels like a dumb question, but I'm not sure if and how those build failures are related to this patch? They seem to involve completely separate parts of the LLVM project (and `.c` files to boot). Was it that the build was failing for an unrelated reason at the moment t

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

saiislam created this revision. saiislam added reviewers: jdoerfert, ABataev, JonChesterfield. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Use common interface for accessing target specific GPU grid values in NVPTX OpenMP codegen a

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276759. martong added a comment. - Reuse summaries with accept and other functions when sockaddr is a union of pointers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407

[PATCH] D83426: Unbreak Clang standalone build.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems reasonable to me, this seems like it would be useful to downstream packagers for Linux distros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D82767: clang-format: Explicitly use python3

serge-sans-paille added a comment. In D82767#2132903 , @MyDeveloperDay wrote: > We may not be consistent across all of LLVM > > $ find . -name '*.py' -print -exec /usr/bin/head -2 {} \; | grep "#!" | > sort | uniq -c > 6 #! /usr/bin/env python

[PATCH] D82436: [clangd] Implement textDocument/foldingRange

sammccall added a comment. Tests :-) Comment at: clang-tools-extra/clangd/Protocol.h:1522 +struct FoldingRange { + unsigned startLine; + llvm::Optional startCharacter; nit: =0 (and on endLine) Comment at: clang-tools-extra/clangd/SemanticSe

[PATCH] D83490: [cmake] Support running compiler-rt tests in CrossWinToARMLinux.cmake

broadwaylamb created this revision. broadwaylamb added a reviewer: vvereschaka. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls, mgorny, dberris. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83490 Files: clang/cmake/caches/Cro

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen added a comment. In D82800#2141819 , @ABataev wrote: > In D82800#2141818 , @cchen wrote: > > > @ABataev , can you commit this patch for me when you have time? Thanks. > > > I think you can request commit acces

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

This revision was automatically updated to reflect the committed changes. Closed by commit rG3cca818efabb: Refactored NumericLiteralParser to not require a Preprocessor (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83480/new/

[clang] 3cca818 - Refactored NumericLiteralParser to not require a Preprocessor

Author: Dmitri Gribenko Date: 2020-07-09T17:33:58+02:00 New Revision: 3cca818efabbccdde36b06609cf75ee7caa8e012 URL: https://github.com/llvm/llvm-project/commit/3cca818efabbccdde36b06609cf75ee7caa8e012 DIFF: https://github.com/llvm/llvm-project/commit/3cca818efabbccdde36b06609cf75ee7caa8e012.dif

[PATCH] D75229: [clang-tidy] Add signal-in-multithreaded-program check

jfb added a comment. It seems like you don't want this check to trigger on POSIX platforms, given: > Exceptions CON37-C-EX1: Implementations such as POSIX that provide defined > behavior when multithreaded programs use custom signal handlers are exempt > from this rule [IEEE Std 1003.1-2013].

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev added a comment. In D82800#2141818 , @cchen wrote: > @ABataev , can you commit this patch for me when you have time? Thanks. I think you can request commit access from Chris Lattner and commit it yourself. Repository: rG LLVM Github Monorepo

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

sammccall added a comment. In D83419#2141433 , @hokein wrote: > > Sorry, I should give some reasons here: > > These are sensible reasons. My only (not a strong) concern is that "error" is > quite special, we need to be careful to choose it -- note that th

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

cchen added a comment. @ABataev , can you commit this patch for me when you have time? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 ___ cfe-commits m

[PATCH] D82646: [MSP430] Align the _Complex ABI with current msp430-gcc

This revision was automatically updated to reflect the committed changes. Closed by commit rG67422e429475: [MSP430] Align the _Complex ABI with current msp430-gcc (authored by atrosinenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82646/new/ ht

[PATCH] D77493: [clang-tidy] Add do-not-refer-atomic-twice check

jfb added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-do-not-refer-atomic-twice.cpp:10 +_Atomic int n2 = ATOMIC_VAR_INIT(0); +_Atomic(int) n3 = ATOMIC_VAR_INIT(0); + Can you cover `std::atomic` as well? Com

[clang] 67422e4 - [MSP430] Align the _Complex ABI with current msp430-gcc

Author: Anatoly Trosinenko Date: 2020-07-09T18:28:48+03:00 New Revision: 67422e4294754e08f277b1ba22820487eb76b918 URL: https://github.com/llvm/llvm-project/commit/67422e4294754e08f277b1ba22820487eb76b918 DIFF: https://github.com/llvm/llvm-project/commit/67422e4294754e08f277b1ba22820487eb76b918.

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

sammccall added a comment. In D83213#2141387 , @hokein wrote: > I think this depends on how we interpret the instantiation-dependent bit. In > clang, it currently has two semantics: > > 1. an expression (somehow) depends on a template parameter; > 2. an e

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang added a comment. Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

gribozavr2 added inline comments. Comment at: clang/include/clang/Lex/LiteralSupport.h:57-59 - NumericLiteralParser(StringRef TokSpelling, - SourceLocation TokLoc, - Preprocessor &PP); eduucaldas wrote: > We don't need

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

gribozavr updated this revision to Diff 276740. gribozavr added a comment. Addressed code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83480/new/ https://reviews.llvm.org/D83480 Files: clang/include/clang/Lex/LiteralSupport.h

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

erichkeane closed this revision. erichkeane added a comment. Gah, misspelled differential revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] 4d4d903 - Fix warning caused by __builtin_expect_with_probability was not handled

Author: Zhi Zhuang Date: 2020-07-09T08:01:33-07:00 New Revision: 4d4d9037670a3537c14092807a717284ea0c4f92 URL: https://github.com/llvm/llvm-project/commit/4d4d9037670a3537c14092807a717284ea0c4f92 DIFF: https://github.com/llvm/llvm-project/commit/4d4d9037670a3537c14092807a717284ea0c4f92.diff LO

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, + *

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

eduucaldas accepted this revision. eduucaldas added a comment. This revision is now accepted and ready to land. Additionally, consider applying a similar change to `CharLiteralParser`, for consistency. All the comments are just suggestions. Feel free to land this without answering them.

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, +

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

Szelethus accepted this revision. Szelethus added a comment. LGTM, but if we knowingly a subpar solution, we should make that clear in the surrounding code. I know the followup patch is around the corner, but just to be sure. Comment at: clang/lib/StaticAnalyzer/Checkers/Iter

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

gamesh411 added a comment. @Szelethus thanks for being watchful, appreciated c: CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

gamesh411 accepted this revision. gamesh411 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isInte

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isIntegralOrEnumerationType

[PATCH] D82657: [AST][RecoveryAST] Preserve the type by default for recovery expression.

hokein updated this revision to Diff 276733. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82657/new/ https://reviews.llvm.org/D82657 Files: clang/lib/Frontend/CompilerInvocation.cpp clang/test/CXX/temp/temp.cons

[PATCH] D83362: Fix warning caused by __builtin_expect_with_probability was not handled in places such as constant folding

LukeZhuang added a comment. Hi, could you please help me commit this change? Thank you very much! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83362/new/ https://reviews.llvm.org/D83362 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:1735-1747 + if (!addToFunctionSummaryMap( + "accept", Summary(ArgTypes{IntTy, *StructSockaddrPtrRestrictTy, + *

[PATCH] D83286: [analyzer][solver] Track symbol disequalities

vsavchenko updated this revision to Diff 276729. vsavchenko added a comment. Fix review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83286/new/ https://reviews.llvm.org/D83286 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

Szelethus added a comment. I don't like this solution t much, but I respect the urgency, and since we don't introduce a compatibility issue, I trust we can remove this if we decide to change to TableGen. Post-commit LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D71124: [RISCV] support clang driver to select cpu

khchen planned changes to this revision. khchen marked an inline comment as done. khchen added a comment. BTW, this patch depends on D77030 , which aim to avoid the forcing of any ProcessorModel to have `FeatureRVCHints` feature. But if we decide to keep the `Feat

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:48-50 #ifndef ANALYZER_OPTION_DEPENDS_ON_USER_MODE /// Create a new analyzer option, but dont generate a method for it in /// AnalyzerOptions. It's value depends on the opt

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

This revision was automatically updated to reflect the committed changes. Closed by commit rGd12d0b73f1c9: [analyzer] Add CTUImportCppThreshold for C++ files (authored by martong). Changed prior to commit: https://reviews.llvm.org/D83475?vs=276722&id=276727#toc Repository: rG LLVM Github Mon

[clang] d12d0b7 - [analyzer] Add CTUImportCppThreshold for C++ files

Author: Gabor Marton Date: 2020-07-09T15:36:33+02:00 New Revision: d12d0b73f1c9c3a711c5cc15266a2b493cd712e9 URL: https://github.com/llvm/llvm-project/commit/d12d0b73f1c9c3a711c5cc15266a2b493cd712e9 DIFF: https://github.com/llvm/llvm-project/commit/d12d0b73f1c9c3a711c5cc15266a2b493cd712e9.diff

[clang] 31b0569 - make -fmodules-codegen and -fmodules-debuginfo work also with PCHs

Author: Luboš Luňák Date: 2020-07-09T15:22:26+02:00 New Revision: 31b05692cd33b6dcc39402169b36d895e1aa87f4 URL: https://github.com/llvm/llvm-project/commit/31b05692cd33b6dcc39402169b36d895e1aa87f4 DIFF: https://github.com/llvm/llvm-project/commit/31b05692cd33b6dcc39402169b36d895e1aa87f4.diff L

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

This revision was automatically updated to reflect the committed changes. Closed by commit rG31b05692cd33: make -fmodules-codegen and -fmodules-debuginfo work also with PCHs (authored by llunak). Changed prior to commit: https://reviews.llvm.org/D69778?vs=263839&id=276726#toc Repository: rG

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/IteratorModeling.cpp:275-276 } else if (isRandomIncrOrDecrOperator(OK)) { +if (!BO->getRHS()->getType()->isIntegralOrEnumerationType()) + return; handlePtrIncrOrDecr(C, BO->getLHS(), -

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

martong updated this revision to Diff 276722. martong marked an inline comment as done. martong added a comment. - Remove extra whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83475/new/ https://reviews.llvm.org/D83475 Files: clang/incl

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

gamesh411 added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:333 +"for import when inlining functions during CTU analysis of C++ " +"source files. ", 8u) extra whitespac

[PATCH] D83480: Refactored NumericLiteralParser to not require a Preprocessor

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We would like to use NumericLiteralParser in the implementation of the syntax tree builder, and plumbing a preprocessor there seems inconvenient and superfluous. Repository: rG LLVM Github M

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

gamesh411 accepted this revision. gamesh411 added a comment. This revision is now accepted and ready to land. It will be interesting to see how different C and C++ projects will prove in terms of AST complexity, and Decl-size, but I understand that for now, these two options are necessary to not

[PATCH] D83478: [OPENMP]Fix compiler crash for target data directive without actual target codegen.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Need to privatize addresses of the captured variables when trying to emit the body of the target data directive in no target codegen mode. Repo

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong added a comment. In D83407#2141075 , @balazske wrote: > Are not some functions missing from the list (`shutdown`, `sockatmark`, > `socket`) (these come from )? And `getnameinfo` comes from > with many other functions that are not added.

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276716. martong marked 2 inline comments as done and an inline comment as not done. martong added a comment. - Remove redundant line from test code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

martong updated this revision to Diff 276715. martong added a comment. - Add getRestrictTy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83407/new/ https://reviews.llvm.org/D83407 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsCheck

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

yaxunl added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.cpp:293 +"wavefrontsize32" : "wavefrontsize64"; + Features.insert(std::make_pair(DefaultWaveSizeFeature, true)); +} what's the default wave front size in backend for gfx10*

[PATCH] D83475: [analyzer] Add CTUImportCppThreshold for C++ files

martong created this revision. martong added reviewers: gamesh411, Szelethus. Herald added subscribers: cfe-commits, ASDenysPetrov, steakhal, Charusso, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a project: clang. The

[PATCH] D83474: Add support for specifying only a denormalizer

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This commit adds a denormalyzer for optimization level. Depends on D83406 Repository: rG LLVM Git

[PATCH] D82800: [OPENMP50] extend array section for stride (Parsing/Sema/AST)

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82800/new/ https://reviews.llvm.org/D82800 ___

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

Szelethus added a comment. After reading @martong's comment D72705#2035844 and @balazske's comment D72705#2086994 , I think there is a need to argue across all paths of execution within the function, and as such

[PATCH] D83419: [clangd] Add error() function for creating formatv-style llvm::Errors. NFC

hokein added a comment. > Sorry, I should give some reasons here: These are sensible reasons. My only (not a strong) concern is that "error" is quite special, we need to be careful to choose it -- note that there is an `error` function in glibc which is used for error-reporting. maybe there ar

[PATCH] D82663: [CodeGen] Have CodeGen for fixed-point unsigned with padding emit signed operations.

ebevhan added a comment. In D82663#2140507 , @leonardchan wrote: > In D82663#2130355 , @ebevhan wrote: > > > Well, it's not so much as adding the bit, but adding the information that > > the bit exists. That means

[clang] b444705 - Make helpers static. NFC.

Author: Benjamin Kramer Date: 2020-07-09T13:48:56+02:00 New Revision: b44470547e2ec8a52abb67c3f538ecc49ee27970 URL: https://github.com/llvm/llvm-project/commit/b44470547e2ec8a52abb67c3f538ecc49ee27970 DIFF: https://github.com/llvm/llvm-project/commit/b44470547e2ec8a52abb67c3f538ecc49ee27970.dif

[PATCH] D81583: Update SystemZ ABI to handle C++20 [[no_unique_address]] attribute

asb added a comment. This LGTM from a RISC-V perspective. I'll likely follow up with a RISC-V test case similar to the SystemZ one post-commit, but given this is really fixing a cross-platform ABI issue this seems non-urgent. Thanks for spotting and addressing this issue. CHANGES SINCE LAST A

[PATCH] D79773: [clang-format] Improve clang-formats handling of concepts

klimek added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:631-636 + else if (FormatTok->is(tok::arrow)) { +// Following the } we can find a trailing return type arrow +// as part of an implicit conversion constraint. +nextToken(); +parseS

[PATCH] D83213: [AST][RecoveryExpr] Don't set the instantiation-bit.

hokein added a comment. I think this depends on how we interpret the instantiation-dependent bit. In clang, it currently has two semantics: 1. an expression (somehow) depends on a template parameter; 2. an expression is dependent; Prior to RecoveryExpression being added, 1 and 2 are equal, so w

[PATCH] D83294: [Fixed Point] Add codegen for fixed-point shifts.

ebevhan marked an inline comment as done. ebevhan added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3603-3604 auto ResultFixedSema = Ctx.getFixedPointSemantics(ResultTy); - auto CommonFixedSema = LHSFixedSema.getCommonSemantics(RHSFixedSema, true); + auto

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

hokein added inline comments. Comment at: clang/lib/AST/ComputeDependence.cpp:498 ExprDependence clang::computeDependence(RecoveryExpr *E) { - // Mark the expression as value- and instantiation- dependent to reuse - // existing suppressions for dependent code, e.g. avoiding -

[PATCH] D83215: [AST][RecoveryExpr] Clarify the documentation of RecoveryExpr.

hokein updated this revision to Diff 276700. hokein marked 4 inline comments as done. hokein added a comment. refine the doc based on the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83215/new/ https://reviews.llvm.org/D83215 Fil

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev marked an inline comment as done. kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:64 + if (ParsedURI->scheme() != "file") { +elog("Can not parse URI with scheme other than \"file\" {0}", URI); +return

[clang-tools-extra] 93bb994 - [clangd] Implement path and URI translation for remote index

Author: Kirill Bobyrev Date: 2020-07-09T12:52:55+02:00 New Revision: 93bb9944cb577f0529636dc5acfba16026740962 URL: https://github.com/llvm/llvm-project/commit/93bb9944cb577f0529636dc5acfba16026740962 DIFF: https://github.com/llvm/llvm-project/commit/93bb9944cb577f0529636dc5acfba16026740962.diff

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

This revision was automatically updated to reflect the committed changes. Closed by commit rG93bb9944cb57: [clangd] Implement path and URI translation for remote index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 276693. atrosinenko added a comment. Just an automatic rebase to (possibly) fix failing "Apply patch" step. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/new/ https://reviews.llvm.org/D81676 Files:

[PATCH] D82938: [clangd] Implement path and URI translation for remote index

kbobyrev updated this revision to Diff 276692. kbobyrev marked 15 inline comments as done. kbobyrev added a comment. Address post-LGTM round of comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82938/new/ https://reviews.llvm.org/D82938 File

[clang-tools-extra] 6a3b10e - [change-namespace][NFC] Clean up joinNamespaces

Author: Nathan James Date: 2020-07-09T11:29:49+01:00 New Revision: 6a3b10e294feceb94064f32450de5c068a13dd03 URL: https://github.com/llvm/llvm-project/commit/6a3b10e294feceb94064f32450de5c068a13dd03 DIFF: https://github.com/llvm/llvm-project/commit/6a3b10e294feceb94064f32450de5c068a13dd03.diff

[PATCH] D81676: [MSP430] Align the toolchain definition with the TI's msp430-gcc v9.2.0

atrosinenko updated this revision to Diff 276686. atrosinenko added a comment. Just add the test on `-rtlib=compiler-rt` handling as everything other is ready for basic clang_rt.builtins support. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81676/

[PATCH] D83295: [Analyzer] Hotfix for various crashes in iterator checkers

baloghadamsoftware updated this revision to Diff 276684. baloghadamsoftware edited the summary of this revision. baloghadamsoftware added a comment. Test added for the third fix in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83295/new/ https://reviews.llvm.org/D83295 File

[clang] 397c682 - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2020-07-09T11:06:39+01:00 New Revision: 397c68202a990c80a71de2816cee413cd5b5865e URL: https://github.com/llvm/llvm-project/commit/397c68202a990c80a71de2816cee413cd5b5865e DIFF: https://github.com/llvm/llvm-project/commit/397c68202a990c80a71de2816cee413cd5b5865e.diff

[PATCH] D69318: [analyzer] Add SufficientSizeArrayIndexingChecker

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SufficientSizeArrayIndexingChecker.cpp:27 +: public Checker> { + mutable std::unique_ptr BT; + gamesh411 wrote: > balazske wrote: > > The bug type can be initialized here: > > `BT

[PATCH] D82157: Fix crash on `user defined literals`

eduucaldas updated this revision to Diff 276681. eduucaldas added a comment. Document proposed solution for treating raw literal operators and numeric template operators Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82157/new/ https://reviews.llvm

<    1   2   3   >